Re: [Qemu-devel] [PATCH v5 0/3] qcow2 metadata cache

2011-01-26 Thread TeLeMan
These patches break booting Windows.

[Qemu-devel] Fwd: Proposal: Improving patch tracking and review using Rietveld

2011-01-26 Thread Paolo Bonzini
Forwarding this from the GCC mailing list. Since patchwork isn't more than a mail archive the way it's implemented in QEMU, this may be a more interesting possibility. Paolo At Google we use a code review tool which was open sourced a couple of years ago: Rietveld (http://code.google.com/app

[Qemu-devel] Re: [PATCH v2 5/5] pci: use uint8_t for devfn_min

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 03:56:39PM +0900, Isaku Yamahata wrote: > use uint8_t for devfn_min instead of int. > > Signed-off-by: Isaku Yamahata Applied, thanks. > --- > hw/pci.c |6 +++--- > hw/pci.h |6 +++--- > hw/pci_internals.h |2 +- > 3 files changed, 7 inse

[Qemu-devel] [PATCH] escc: fix interrupt flags

2011-01-26 Thread Aurelien Jarno
Recent PowerPC kernel end up in kernel panic during boot in -nographic mode. In this mode the second serial port is used as the udbg console, and thus a few characters are sent on this port. This activates the tx interrupt flag, and later choke the Linux kernel, as it was not expecting such a flag

[Qemu-devel] Re: [PATCH v2 4/5] pci: use PCI_SLOT in pci_get_bus_devfn()

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 03:56:38PM +0900, Isaku Yamahata wrote: > use PCI_SLOT in pci_get_bus_devfn(). > > Signed-off-by: Isaku Yamahata Tweaked the comment and applied. > --- > hw/pci.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index

[Qemu-devel] Re: [PATCH v2 3/5] pci/pcie: make pci_find_device() ARI aware.

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 03:56:37PM +0900, Isaku Yamahata wrote: > make pci_find_device() ARI aware. > > Signed-off-by: Isaku Yamahata I moved the function to pci.c and renamed it to pci_devfn_enabled (it does not deal with the slot anymore). > --- > hw/pci.c |6 ++ > hw/pci.h | 42

[Qemu-devel] Re: [PATCH v2 2/5] pci: use devfn for pci_find_device() instead of (slot, fn) pair

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 03:56:36PM +0900, Isaku Yamahata wrote: > (slot, fn) pair is somewhat confusing because of ARI. > So use devfn for pci_find_device() instead of (slot, fn). > > Signed-off-by: Isaku Yamahata Applied, thanks. > --- > hw/pci-hotplug.c |5 +++-- > hw/pci.c |

[Qemu-devel] Re: [PATCH v2 1/5] pci: replace the magic, 256, for the maximum of devfn

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 03:56:35PM +0900, Isaku Yamahata wrote: > Introduce symbol PCI_DEVFN_MAX for the maximum of devfn > and replace the magic, 256. > > Signed-off-by: Isaku Yamahata Applied, tweaked the comment. > --- > hw/pci.h |1 + > hw/pci_internals.h |2 +- > 2 files

[Qemu-devel] [PATCH v2 2/5] pci: use devfn for pci_find_device() instead of (slot, fn) pair

2011-01-26 Thread Isaku Yamahata
(slot, fn) pair is somewhat confusing because of ARI. So use devfn for pci_find_device() instead of (slot, fn). Signed-off-by: Isaku Yamahata --- hw/pci-hotplug.c |5 +++-- hw/pci.c |4 ++-- hw/pci.h |2 +- hw/pci_host.c|2 +- hw/pcie_host.c |3 +-- 5 fi

[Qemu-devel] [PATCH v2 1/5] pci: replace the magic, 256, for the maximum of devfn

2011-01-26 Thread Isaku Yamahata
Introduce symbol PCI_DEVFN_MAX for the maximum of devfn and replace the magic, 256. Signed-off-by: Isaku Yamahata --- hw/pci.h |1 + hw/pci_internals.h |2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index 0d2753f..aa5f912 100644 --- a/

[Qemu-devel] [PATCH v2 5/5] pci: use uint8_t for devfn_min

2011-01-26 Thread Isaku Yamahata
use uint8_t for devfn_min instead of int. Signed-off-by: Isaku Yamahata --- hw/pci.c |6 +++--- hw/pci.h |6 +++--- hw/pci_internals.h |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index e25bf7a..6725f50 100644 --- a/hw/

[Qemu-devel] [PATCH v2 4/5] pci: use PCI_SLOT in pci_get_bus_devfn()

2011-01-26 Thread Isaku Yamahata
use PCI_SLOT in pci_get_bus_devfn(). Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 471d4d7..e25bf7a 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -558,7 +558,7 @@ PCIBus *pci_get_bus_devfn(int *devfnp, con

[Qemu-devel] [PATCH v2 3/5] pci/pcie: make pci_find_device() ARI aware.

2011-01-26 Thread Isaku Yamahata
make pci_find_device() ARI aware. Signed-off-by: Isaku Yamahata --- hw/pci.c |6 ++ hw/pci.h | 42 ++ hw/pcie.c | 13 - hw/pcie.h |1 - 4 files changed, 48 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] [PATCH v2 0/5] pci/pcie: implement ARI enable bit correctly

2011-01-26 Thread Isaku Yamahata
Changes v1 -> v2: - dropped PCI_DEVFN_MAX - use uint8_t for devfn instead of int - move pcie_check_slot into pci.h and made it static inline - minor clean ups Isaku Yamahata (5): pci: replace the magic, 256, for the maximum of devfn pci: use devfn for pci_find_device() instead of (slot, fn) pa

Re: [Qemu-devel] QEMU icon

2011-01-26 Thread Mulyadi Santosa
On Thu, Jan 27, 2011 at 02:18, Stefan Weil wrote: > Since some time, I urgently wanted to have an icon for QEMU. > As I did not find one, I tried to design one, and here is the > current result: http://qemu.weilnetz.de/qemu-icon.svg. Nice job Stefan! :) anyway, may I suggest something? What if t

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2011-01-26 Thread Zhiyuan-lv
I verified the fix on kernel 2.6.35. After rebuilding kernel with the patch, I could boot MeeGo image with qemu-kvm successfully. Can I know when the kernel update will be available for Ubuntu 10.10? Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which i

[Qemu-devel] Re: [PATCH] pci: typo in pcibus_get_dev_path()

2011-01-26 Thread Michael S. Tsirkin
On Thu, Jan 27, 2011 at 12:49:04PM +0900, Isaku Yamahata wrote: > This patch fixes typo in pcibus_get_dev_path(). > Without this patch, the result of pcibus_get_dev_path() isn't unique. > > Signed-off-by: Isaku Yamahata Good catch, applied, thanks. > --- > hw/pci.c |2 +- > 1 files changed

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-26 Thread Wolfgang Schildbach
I can confirm that this bug is gone with QEMU commit commit 0fad6efce5d3f18278b7239dece3c251b3e7c04d. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/702885 Title: "Internal resource leak" error with

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Isaku Yamahata
On Wed, Jan 26, 2011 at 03:57:15PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 26, 2011 at 10:53:42PM +0900, Isaku Yamahata wrote: > > On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > > > > The bit should

[Qemu-devel] [PATCH] pci: typo in pcibus_get_dev_path()

2011-01-26 Thread Isaku Yamahata
This patch fixes typo in pcibus_get_dev_path(). Without this patch, the result of pcibus_get_dev_path() isn't unique. Signed-off-by: Isaku Yamahata --- hw/pci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index d2a0cee..b3d8ba5 100644 --- a/hw/pc

[Qemu-devel] Re: [PATCH] savevm: unbreak register_savevm_live()/vmstate_register_with_alias_id()

2011-01-26 Thread Isaku Yamahata
I sent the patch out too early. I found the issue is in pcibus_get_dev_path(). Sorry for noise. On Wed, Jan 26, 2011 at 07:04:51AM -0700, Alex Williamson wrote: > On Wed, 2011-01-26 at 18:45 +0900, Isaku Yamahata wrote: > > This patch unbreaks 7685ee6abcb939104801f84b3fe9645412528088. > > With the

[Qemu-devel] [PATCH] linux-user: implement sched_{g,s}etaffinity

2011-01-26 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- linux-user/syscall.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3e285c6..f95429f 100644 --- a/linux-user/syscall.c +++ b/linux-user/s

[Qemu-devel] [PATCH] user: speed up init_paths a bit

2011-01-26 Thread Mike Frysinger
The current init_paths code will attempt to opendir() every single file it finds. This can obviously generated a huge number of syscalls with even a moderately small sysroot that will fail. Since the readdir() call provides the file type in the struct itself, use it. On my system, this prevents

Re: [Qemu-devel] [PATCH v2] linux-user/FLAT: allow targets to override FLAT processing

2011-01-26 Thread Mike Frysinger
On Tue, Jan 25, 2011 at 01:15, Mike Frysinger wrote: > This brings flatload.c more in line with the current Linux FLAT loader > which allows targets to handle various FLAT aspects in their own way. > For the common behavior, the new functions get stubbed out. > > Signed-off-by: Mike Frysinger > --

Re: [Qemu-devel] Re: [PATCH] linux-user/FLAT: allow targets to override FLAT reloc processing

2011-01-26 Thread Mike Frysinger
On Wed, Jan 26, 2011 at 16:21, riku voipio wrote: > On 01/24/2011 11:48 AM, Mike Frysinger wrote: >> This brings flatload.c more in line with the current Linux FLAT loader >> which allows targets to handle FLAT relocations in their own way.  For >> the common behavior, the new functions get stubbed

Re: [Qemu-devel] Re: [PATCH V9 16/16] xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

2011-01-26 Thread Anthony Liguori
On 01/26/2011 08:36 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_machine_fv.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c index 0a90312..f48b978 100644 --- a

Re: [Qemu-devel] [PATCH V9 12/16] Introduce qemu_ram_ptr_unlock.

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD --- cpu-common.h |1

Re: [Qemu-devel] [PATCH V9 15/16] xen: Set running state in xenstore.

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD --- xen-all.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/acpi_piix4.c |4 hw/xen.h|2 ++ xen-all.c |7 +++ xen-stub.c |4 4 files changed, 17 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH V9 10/16] xen: Introduce the Xen mapcache

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Jun Nakajima On IA32 host or IA32 PAE host, at present, generally, we can't create an HVM guest with more than 2G memory, because generally it's almost impossible for Qemu to find a large enough and consecutive virtual address space

Re: [Qemu-devel] [PATCH V9 09/16] xen: add a 8259 Interrupt Controller

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Introduce a 8259 Interrupt Controller for target-xen; every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen_common.h |2 ++ hw/xen_machine_fv.c

Re: [Qemu-devel] [PATCH V9 07/16] xen: Add the Xen platform pci device

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Steven Smith Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith Signed-off-by: Anthony PERARD Signed-off-by: Stefano Sta

Re: [Qemu-devel] [PATCH V9 06/16] xen: Add initialisation of Xen

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Signed-off-by: Anthony PERARD --- Makefile.target |3 +++ hw/xen.h| 13 + vl.c|2 ++ xen-all.c | 29 + xen-stub.c | 17

Re: [Qemu-devel] [PATCH V9 05/16] xen: Add xen_machine_fv

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- Makefile.target |3 + hw/x

Re: [Qemu-devel] [PATCH V9 04/16] xen: Support new libxc calls from xen unstable.

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Anthony PERARD Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable

Re: [Qemu-devel] [PATCH V9 03/16] xen: Add a generic layer for xc calls

2011-01-26 Thread Anthony Liguori
On 01/25/2011 08:29 AM, anthony.per...@citrix.com wrote: From: Alexander Graf This patch adds a generic layer for xc calls, allowing us to choose between the xenner and xen implementations at runtime. Signed-off-by: Alexander Graf Signed-off-by: Anthony PERARD --- hw/xen_interfaces.c | 100 +

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-26 Thread Anthony Liguori
On 01/26/2011 03:23 PM, Stefan Hajnoczi wrote: Both g_malloc() and g_try_malloc() are available where g_try_malloc() returns NULL on failure. g_malloc() matches qemu_malloc() exit behavior today but in the future it would be possible to use g_try_malloc() for proper out-of-memory handling. But

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 3:53 PM, Anthony Liguori wrote: > On 01/25/2011 10:47 PM, Daniel Veillard wrote: >> >> On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: >> >>> >>> Both the recent I/O loop and threadlet series have me concerned that >>> we're >>> digging ourselves deeper int

[Qemu-devel] Re: [PATCH] linux-user/FLAT: allow targets to override FLAT reloc processing

2011-01-26 Thread riku voipio
On 01/24/2011 11:48 AM, Mike Frysinger wrote: This brings flatload.c more in line with the current Linux FLAT loader which allows targets to handle FLAT relocations in their own way. For the common behavior, the new functions get stubbed out. Do you have some instructions howto build flat bina

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Lluís
Richard Henderson writes: > On 01/26/2011 12:17 PM, Lluís wrote: >> Richard Henderson writes: >> >>> On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: P.S. Please just answer that last question, whether it is possible to have a variable showing the upper bound of heap (some brk_end) for a

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Stefano Bonifazi
On 01/26/2011 09:19 PM, Richard Henderson wrote: On 01/26/2011 12:17 PM, Lluís wrote: Richard Henderson writes: On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: P.S. Please just answer that last question, whether it is possible to have a variable showing the upper bound of heap (some brk_end)

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Richard Henderson
On 01/26/2011 12:17 PM, Lluís wrote: > Richard Henderson writes: > >> On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: >>> P.S. Please just answer that last question, whether it is possible to >>> have a variable showing the upper bound of heap (some brk_end) for a >>> target process > >> No, the

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Lluís
Richard Henderson writes: > On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: >> P.S. Please just answer that last question, whether it is possible to >> have a variable showing the upper bound of heap (some brk_end) for a >> target process > No, the heap grows until it reaches some other memory ma

[Qemu-devel] Re: [PATCH] Add a QEMU icon

2011-01-26 Thread Stefan Weil
Am 26.01.2011 20:23, schrieb Stefan Weil: The icon was designed using Inkscape. It is licensed under GPL version 2 or later. A bitmap file and code for its usage from SDL is added, too. Signed-off-by: Stefan Weil --- Sorry, the subject line was wrong. please fix it before committing the

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 11:09 AM, Alexander Graf wrote: > >> Please be aware of the fact that I'm currently reworking the whole CC >> model, so if you start working on the register acceleration now there >> will be conflicts for sure :). >> > > Roger. > > >> Do you have

[Qemu-devel] [PATCH] Add an qemu icon

2011-01-26 Thread Stefan Weil
The icon was designed using Inkscape. It is licensed under GPL version 2 or later. A bitmap file and code for its usage from SDL is added, too. Signed-off-by: Stefan Weil --- configure |1 + pc-bios/qemu-icon.bmp | Bin 0 -> 2118 bytes pc-bios/qemu-icon.svg | 117 +

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 11:09 AM, Alexander Graf wrote: > Please be aware of the fact that I'm currently reworking the whole CC > model, so if you start working on the register acceleration now there > will be conflicts for sure :). Roger. > Do you have code to test it with? Er, I assume I can pull someth

[Qemu-devel] QEMU icon

2011-01-26 Thread Stefan Weil
Since some time, I urgently wanted to have an icon for QEMU. As I did not find one, I tried to design one, and here is the current result: http://qemu.weilnetz.de/qemu-icon.svg. The following patch adds the icon and SDL related code to QEMU. More patches will add an installer for Windows which a

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 11:01 AM, Alexander Graf wrote: > >>> As far as I know, it does not happen at random. Which seems to be >>> what you are suggesting. >>> >> It happens on load/store and potentially helpers. The main difference >> IIUC between globals and temps is

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 11:01 AM, Alexander Graf wrote: >> As far as I know, it does not happen at random. Which seems to be >> what you are suggesting. > > It happens on load/store and potentially helpers. The main difference > IIUC between globals and temps is that globals are kept in registers as > lon

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 10:27 AM, Alexander Graf wrote: > >> What do I do on a page fault now? I could rerun the translator to find >> out which registers would be stuck in a temporary, but I have no way to >> actually read the temporary's value, as all register state is thrown

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 10:27 AM, Alexander Graf wrote: > What do I do on a page fault now? I could rerun the translator to find > out which registers would be stuck in a temporary, but I have no way to > actually read the temporary's value, as all register state is thrown > away on a page fault IIUC. When

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 08:50 AM, Alexander Graf wrote: > >> Oh, you mean basically to have the following: >> >> TCGv_i32 regs32[16]; >> TCGv_i64 regs[16]; >> >> Then declare both as globals with offset and just switch between the >> access type using a disas struct variable. On

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 08:50 AM, Alexander Graf wrote: > Oh, you mean basically to have the following: > > TCGv_i32 regs32[16]; > TCGv_i64 regs[16]; > > Then declare both as globals with offset and just switch between the > access type using a disas struct variable. Once the TB ends, I'd > obviously have

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-26 Thread Johannes Stezenbach
Hi, just a few thoughts from a qemu novice... On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: > This series introduces a hard dependency on glib. The initial use is portable > threads but I see this as just the beginning. Glib/Gobject offer many nice > things including: > > -

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Stefano Bonifazi
On 01/26/2011 04:38 PM, Richard Henderson wrote: On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: P.S. Please just answer that last question, whether it is possible to have a variable showing the upper bound of heap (some brk_end) for a target process No, the heap grows until it reaches some oth

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Anthony Liguori
On 01/26/2011 10:38 AM, Avi Kivity wrote: On 01/26/2011 06:28 PM, Anthony Liguori wrote: On 01/26/2011 10:13 AM, Avi Kivity wrote: Serializing against a global mutex has the advantage that it can be treated as a global lock that is decomposed into fine-grained locks. For example, we can start

[Qemu-devel] Re: [PATCH 1/5] SharpSL scoop device - convert to qdev

2011-01-26 Thread Dmitry Eremin-Solenikov
Hi, So what about theese patches? On 1/20/11, Dmitry Eremin-Solenikov wrote: > Convert SharpSL scoop device to qdev, remove lots of supporting code, as > lot of init and gpio related things can now be done automagically. > > Signed-off-by: Dmitry Eremin-Solenikov -- With best wishes Dmitry

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 08:00 AM, Alexander Graf wrote: > >> Keeping it only inside of the translator would break on page faults, as >> the lower 32 bits of the register would lie around in a temporary which >> is invisible for the page fault resolver. >> > > Given that QEM

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 08:00 AM, Alexander Graf wrote: > Keeping it only inside of the translator would break on page faults, as > the lower 32 bits of the register would lie around in a temporary which > is invisible for the page fault resolver. Given that QEMU doesn't support truely async signals, and th

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Avi Kivity
On 01/26/2011 06:28 PM, Anthony Liguori wrote: On 01/26/2011 10:13 AM, Avi Kivity wrote: Serializing against a global mutex has the advantage that it can be treated as a global lock that is decomposed into fine-grained locks. For example, we can start the code conversion from an explict async

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Avi Kivity
On 01/26/2011 06:00 PM, Alexander Graf wrote: Richard Henderson wrote: > On 01/26/2011 01:23 AM, Alexander Graf wrote: > >> agraf@toonie:/studio/s390/qemu-s390> grep deposit target-s390x/translate.c >> tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0, 32); >> tcg_gen_deposit_i64(regs

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Avi Kivity
On 01/26/2011 06:19 PM, Anthony Liguori wrote: What do you mean by threaded version? Stefan didn't post it, but the original code also has a GThread based implementation when ucontext isn't available (like on Windows). It uses a mutex to control the execution of the coroutines. Ah ok. Th

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Anthony Liguori
On 01/26/2011 10:22 AM, Avi Kivity wrote: On 01/26/2011 06:19 PM, Anthony Liguori wrote: What do you mean by threaded version? Stefan didn't post it, but the original code also has a GThread based implementation when ucontext isn't available (like on Windows). It uses a mutex to control th

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Anthony Liguori
On 01/26/2011 10:13 AM, Avi Kivity wrote: Serializing against a global mutex has the advantage that it can be treated as a global lock that is decomposed into fine-grained locks. For example, we can start the code conversion from an explict async model to a threaded sync model by converting th

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Anthony Liguori
On 01/26/2011 10:13 AM, Avi Kivity wrote: On 01/26/2011 06:00 PM, Anthony Liguori wrote: On 01/26/2011 09:25 AM, Avi Kivity wrote: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code withou

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Anthony Liguori
On 01/26/2011 10:13 AM, Avi Kivity wrote: On 01/26/2011 06:00 PM, Anthony Liguori wrote: On 01/26/2011 09:25 AM, Avi Kivity wrote: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code withou

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Avi Kivity
On 01/26/2011 06:00 PM, Anthony Liguori wrote: On 01/26/2011 09:25 AM, Avi Kivity wrote: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code without callbacks but use coroutines to switch st

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Avi Kivity
On 01/26/2011 06:08 PM, Anthony Liguori wrote: On 01/26/2011 09:50 AM, Kevin Wolf wrote: Am 26.01.2011 16:40, schrieb Avi Kivity: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Converting qcow2 to use coroutines is fairly simple since most of qcow2 is synchronous. The synchronous I/O functio

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Avi Kivity
On 01/26/2011 05:50 PM, Kevin Wolf wrote: In the other thread you mentioned that you have written some code independently. Do you have it in some public git repository? I've written it mostly in my mind... IIRC I have the basic coroutine equivalents (in my series they are simply threads, witho

Re: [Qemu-devel] [RFC][PATCH 05/12] coroutine: Add coroutines

2011-01-26 Thread Anthony Liguori
On 01/26/2011 09:29 AM, Avi Kivity wrote: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Add functions to create coroutines and transfer control into a coroutine and back out again. + +struct Coroutine { +struct coroutine co; +}; + +/** + * Coroutine entry point + * + * When the coroutine

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Anthony Liguori
On 01/26/2011 09:50 AM, Kevin Wolf wrote: Am 26.01.2011 16:40, schrieb Avi Kivity: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Converting qcow2 to use coroutines is fairly simple since most of qcow2 is synchronous. The synchronous I/O functions likes bdrv_pread() now transparently

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Alexander Graf
Richard Henderson wrote: > On 01/26/2011 01:23 AM, Alexander Graf wrote: > >> agraf@toonie:/studio/s390/qemu-s390> grep deposit target-s390x/translate.c >> tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0, 32); >> tcg_gen_deposit_i64(regs[reg], regs[reg], v, 0, 32); >> tcg_gen_depos

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Kevin Wolf
Am 26.01.2011 16:40, schrieb Avi Kivity: > On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: >> Converting qcow2 to use coroutines is fairly simple since most of qcow2 >> is synchronous. The synchronous I/O functions likes bdrv_pread() now >> transparently work when called from a coroutine, so all th

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Anthony Liguori
On 01/26/2011 09:25 AM, Avi Kivity wrote: On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code without callbacks but use coroutines to switch stacks under the hood. + +int cc_swap(struct con

Re: [Qemu-devel] [RFC][PATCH 11/12] qcow2: Convert qcow2 to use coroutines for async I/O

2011-01-26 Thread Avi Kivity
On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Converting qcow2 to use coroutines is fairly simple since most of qcow2 is synchronous. The synchronous I/O functions likes bdrv_pread() now transparently work when called from a coroutine, so all the synchronous code just works. The explicitly asy

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-26 Thread Anthony Liguori
On 01/25/2011 10:47 PM, Daniel Veillard wrote: On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us bor

Re: [Qemu-devel] [RFC][PATCH 05/12] coroutine: Add coroutines

2011-01-26 Thread Avi Kivity
On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Add functions to create coroutines and transfer control into a coroutine and back out again. + +struct Coroutine { +struct coroutine co; +}; + +/** + * Coroutine entry point + * + * When the coroutine is entered for the first time, opaque is p

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-26 Thread Richard Henderson
On 01/26/2011 01:23 AM, Alexander Graf wrote: > agraf@toonie:/studio/s390/qemu-s390> grep deposit target-s390x/translate.c > tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0, 32); > tcg_gen_deposit_i64(regs[reg], regs[reg], v, 0, 32); > tcg_gen_deposit_i64(regs[reg], regs[reg], tmp, 0,

Re: [Qemu-devel] [RFC][PATCH 01/12] coroutine: Add gtk-vnc coroutines library

2011-01-26 Thread Avi Kivity
On 01/22/2011 11:29 AM, Stefan Hajnoczi wrote: Asynchronous image format code is becoming very complex. Let's try using coroutines to write sequential code without callbacks but use coroutines to switch stacks under the hood. + +int cc_swap(struct continuation *from, struct continuation *to) +

Re: [Qemu-devel] [PATCH v3] New trace-event backend: stderr

2011-01-26 Thread Peter Maydell
On 26 January 2011 13:37, Fabien Chouteau wrote: > +echo "                           Available backends:" > $($source_path/scripts/tracetool --list-backends) Not enough quoting -- this will break if $source_path has a space in it. Try: echo " Available backends: $("$s

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-26 Thread Richard Henderson
On 01/26/2011 03:07 AM, Stefano Bonifazi wrote: > P.S. Please just answer that last question, whether it is possible to > have a variable showing the upper bound of heap (some brk_end) for a > target process No, the heap grows until it reaches some other memory mapped entity. r~

[Qemu-devel] [patch 4/5] Add flag to indicate external users to block device

2011-01-26 Thread Marcelo Tosatti
Certain operations such as drive_del or resize cannot be performed while external users (eg. block migration) reference the block device. Add a flag to indicate that. Signed-off-by: Marcelo Tosatti Index: qemu/block.c === --- qemu.

Re: [Qemu-devel] [PATCH v3] New trace-event backend: stderr

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 1:37 PM, Fabien Chouteau wrote: > This backend sends trace events to standard error output during the emulation. > > Also add a "--list-backends" option to tracetool, so configure script can > display the list of available backends. > > Signed-off-by: Fabien Chouteau > ---

[Qemu-devel] [patch 2/5] blockdev: add refcount to DriveInfo

2011-01-26 Thread Marcelo Tosatti
The host part of a block device can be deleted with in progress block migration. To fix this, add a reference count to DriveInfo, freeing resources on last reference. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Index: qemu/blockdev.c ===

[Qemu-devel] Re: [PATCH V9 16/16] xen: Add Xen hypercall for sleep state in the cmos_s3 callback.

2011-01-26 Thread anthony . perard
From: Anthony PERARD Signed-off-by: Anthony PERARD --- hw/xen_machine_fv.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/hw/xen_machine_fv.c b/hw/xen_machine_fv.c index 0a90312..f48b978 100644 --- a/hw/xen_machine_fv.c +++ b/hw/xen_machine_fv.c @@ -38,9 +38

[Qemu-devel] [patch 0/5] block migration interaction fixes

2011-01-26 Thread Marcelo Tosatti
See individual patches for details.

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Isaku Yamahata
On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote: > On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > > The bit should be writable, not w1c. > > > > 3.2.5.18 bridge control register > > bit 11 Discard Timer SERR# Enable > > > > When set to 1, this bit enables t

[Qemu-devel] Re: [PATCH] savevm: unbreak register_savevm_live()/vmstate_register_with_alias_id()

2011-01-26 Thread Alex Williamson
On Wed, 2011-01-26 at 18:45 +0900, Isaku Yamahata wrote: > This patch unbreaks 7685ee6abcb939104801f84b3fe9645412528088. > With the changeset, more than one instances of same device on bus > that provides get_dev_path method can't be created because it hits > the assertion. > This patch removes the

Re: [Qemu-devel] Re: Errors on MMIO read access on VM suspend / resume operations

2011-01-26 Thread Stefan Berger
On 01/26/2011 08:31 AM, Jan Kiszka wrote: On 2011-01-26 14:15, Jan Kiszka wrote: On 2011-01-26 14:08, Stefan Berger wrote: On 01/26/2011 07:09 AM, Jan Kiszka wrote: On 2011-01-26 13:05, Stefan Berger wrote: On 01/26/2011 03:14 AM, Jan Kiszka wrote: On 2011-01-25 17:49, Stefan Berger wrote:

Re: [Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.

2011-01-26 Thread Anthony PERARD
On Wed, 26 Jan 2011, Isaku Yamahata wrote: > On Tue, Jan 25, 2011 at 02:29:20PM +, anthony.per...@citrix.com wrote: > > From: Anthony PERARD > > > > Signed-off-by: Anthony PERARD > > --- > > hw/acpi_piix4.c |4 > > hw/xen.h|2 ++ > > xen-all.c |7 +++ > >

Re: [Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 15:01, Stefan Hajnoczi wrote: > On Wed, Jan 26, 2011 at 1:56 PM, Jan Kiszka wrote: >> Looks like this should also include SIGIO in case hpet is selected as >> host timer. > > Yeah that can't hurt although since hpet is periodic we don't risk > forgetting to rearm the timer. > > Can

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 10:53:42PM +0900, Isaku Yamahata wrote: > On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote: > > On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > > > The bit should be writable, not w1c. > > > > > > 3.2.5.18 bridge control register > > > bi

[Qemu-devel] Re: [PATCH] pci: w1cmask[PCI_BRIDGE_CONTROL] initialized incorrectly

2011-01-26 Thread Michael S. Tsirkin
On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote: > The bit should be writable, not w1c. > > 3.2.5.18 bridge control register > bit 11 Discard Timer SERR# Enable > > When set to 1, this bit enables the bridge to assert SERR# on > the primary interface when either the Primary Dis

[Qemu-devel] [patch 3/5] block-migration: add reference to target DriveInfo

2011-01-26 Thread Marcelo Tosatti
So that ejection of attached device by guest does not free data in use by block migration instance. Signed-off-by: Marcelo Tosatti CC: Markus Armbruster Index: qemu/block-migration.c === --- qemu.orig/block-migration.c +++ qemu/blo

[Qemu-devel] [patch 1/5] block-migration: actually disable dirty tracking on cleanup

2011-01-26 Thread Marcelo Tosatti
Call to set_dirty_tracking() is misplaced. Signed-off-by: Marcelo Tosatti Index: qemu/block-migration.c === --- qemu.orig/block-migration.c +++ qemu/block-migration.c @@ -528,6 +528,8 @@ static void blk_mig_cleanup(Monitor *mon

[Qemu-devel] [patch 5/5] block: enable in_use flag

2011-01-26 Thread Marcelo Tosatti
Set block device in use during block migration, disallow drive_del and bdrv_truncate for in use devices. Signed-off-by: Marcelo Tosatti Index: qemu/blockdev.c === --- qemu.orig/blockdev.c +++ qemu/blockdev.c @@ -690,6 +690,10 @@ int

[Qemu-devel] [Bug 702885] Re: "Internal resource leak" error with ARM NEON vmull.s32 insn

2011-01-26 Thread Aurelien Jarno
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/702885 Title: "Internal resource leak" error with ARM NEON vmull.s32 insn Status in QEMU: Fi

Re: [Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Stefan Hajnoczi
On Wed, Jan 26, 2011 at 1:56 PM, Jan Kiszka wrote: > Looks like this should also include SIGIO in case hpet is selected as > host timer. Yeah that can't hurt although since hpet is periodic we don't risk forgetting to rearm the timer. Can you explain the signalfd idea a little more? I'm not sur

[Qemu-devel] Re: [PATCH] kvm: Prevent dynticks race condition for !CONFIG_IOTHREAD

2011-01-26 Thread Jan Kiszka
On 2011-01-26 14:12, Jan Kiszka wrote: > On 2011-01-26 10:39, Stefan Hajnoczi wrote: >> The dynticks timer arranges for SIGALRM to be raised when the next >> pending timer expires. When building with !CONFIG_IOTHREAD, we need to >> check whether a request to exit the vcpu is pending before re-ente

  1   2   >