Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread Isaku Yamahata
Added CC to Tristan. I doubt that he is still interested in EFI, though. On Thu, Mar 03, 2011 at 04:46:34PM +0900, Isaku Yamahata wrote: > > Seabios has the patch to address the similar issue with > the changeset of b82a1e49fc0e72fb9bf1a642d6aa707345b0f398, > which enables memory/io unconditional

[Qemu-devel] Re: [PATCH v4 2/2] rtl8139: add vlan tag insertion

2011-03-02 Thread Michael S. Tsirkin
On Wed, Mar 02, 2011 at 05:36:20PM -0500, Benjamin Poirier wrote: > Add support to the emulated hardware to insert vlan tags in packets > going from the guest to the network. > > Signed-off-by: Benjamin Poirier > Cc: Igor V. Kovalenko > Cc: Jason Wang > Cc: Michael S. Tsirkin > --- > hw/rtl81

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread Isaku Yamahata
Seabios has the patch to address the similar issue with the changeset of b82a1e49fc0e72fb9bf1a642d6aa707345b0f398, which enables memory/io unconditionally. I suppose the EFI bios is very old so that it has the same issue. I think the following file is the one to modify. efi-vfirmware.hg/edk2-spa

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread Isaku Yamahata
On Thu, Mar 03, 2011 at 08:43:11AM +0200, vagran wrote: > I am using TianoCore EFI by Tristan Gingold which is published > on http://wiki.qemu.org/download/efi-bios.tar.bz2. If you would try > to load it on Qemu 0.14.0 (built either for i386 or x86_64) you will > see nothing on VGA display or seria

[Qemu-devel] [PATCH v2 3/3] correct VNC_DIRTY_WORDS on 64 bit machine

2011-03-02 Thread Wen Congyang
VNC_DIRTY_WORDS is wrong on 64 bit long machine. Signed-off-by: Wen Congyang --- ui/vnc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/vnc.h b/ui/vnc.h index 8a1e7b9..5fc54e5 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@ -81,7 +81,7 @@ typedef void VncSendHextileTile(V

[Qemu-devel] Re: [PATCH 3/3] correct VNC_DIRTY_WORDS on 64 bit machine

2011-03-02 Thread Wen Congyang
At 03/03/2011 02:41 PM, Corentin Chary Write: > On Thu, Mar 3, 2011 at 3:44 AM, Wen Congyang wrote: >> VNC_DIRTY_WORDS is wrong on 64 bit long machine. >> >> Signed-off-by: Wen Congyang >> >> --- >> ui/vnc.h |3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/ui/vn

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread vagran
I am using TianoCore EFI by Tristan Gingold which is published on http://wiki.qemu.org/download/efi-bios.tar.bz2. If you would try to load it on Qemu 0.14.0 (built either for i386 or x86_64) you will see nothing on VGA display or serial console. But it still will be able to load OS after timeout i

[Qemu-devel] Re: [PATCH 3/3] correct VNC_DIRTY_WORDS on 64 bit machine

2011-03-02 Thread Corentin Chary
On Thu, Mar 3, 2011 at 3:44 AM, Wen Congyang wrote: > VNC_DIRTY_WORDS is wrong on 64 bit long machine. > > Signed-off-by: Wen Congyang > > --- >  ui/vnc.h |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/ui/vnc.h b/ui/vnc.h > index 8a1e7b9..239a7a7 100644 > --- a/ui

[Qemu-devel] RE: Printed Roll-up Banners USD7 Only (GIGAPrint Overseas)

2011-03-02 Thread CarmanChow
Dear IBT Ing. B?ro Trncik V. GIGAPrint Ltd. | 11/F, Fu Hop Fty Bldg, 209-211 Wai Yip St, Kwun Tong, Kowloon, HK | 23892088

Re: [Qemu-devel] [PATCH v2] disable sigcld handling before calling pclose()

2011-03-02 Thread Wen Congyang
At 12/21/2010 12:05 PM, Wen Congyang Write: > When I use the command 'virsh save' to save the domain state, > I receive the following error message: > operation failed: Migration unexpectedly failed. > > I debug the qemu by adding some printf(), and find the function > pclose() returns -1. > > I

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread Isaku Yamahata
On Thu, Mar 03, 2011 at 12:03:53PM +0900, Isaku Yamahata wrote: > Hi. Thank you for reporting. > Can you elaborate on the changeset that you pointed out and > your work around? > > Regarding to the changeset, it had the issue, but I suppose > 80376c3fc2c38fdd45354e4b0eb45031f35587ed fixed it. > Do

Re: [Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread Isaku Yamahata
Hi. Thank you for reporting. Can you elaborate on the changeset that you pointed out and your work around? Regarding to the changeset, it had the issue, but I suppose 80376c3fc2c38fdd45354e4b0eb45031f35587ed fixed it. Do you found any other issue? Regarding to your workaround, what was the proble

[Qemu-devel] [PATCH 3/3] correct VNC_DIRTY_WORDS on 64 bit machine

2011-03-02 Thread Wen Congyang
VNC_DIRTY_WORDS is wrong on 64 bit long machine. Signed-off-by: Wen Congyang --- ui/vnc.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/ui/vnc.h b/ui/vnc.h index 8a1e7b9..239a7a7 100644 --- a/ui/vnc.h +++ b/ui/vnc.h @@ -81,7 +81,8 @@ typedef void VncSendHextileTile(

Re: [Qemu-devel] [RFC][PATCH] Preliminary BeBox support

2011-03-02 Thread François Revol
Le 2 mars 2011 à 22:59, Andreas Färber a écrit : > Hello François, > > Am 01.03.2011 um 01:15 schrieb François Revol: > >> Since Natalia raised the subject I though I'd post my current patch for the >> BeBox support. >> I think the loader stuff can probably be committed already with some clean

[Qemu-devel] Invitation to connect on LinkedIn

2011-03-02 Thread Starrry Han via LinkedIn
LinkedIn Starrry Han requested to add you as a connection on LinkedIn: -- Jiajun, I'd like to add you to my professional network on LinkedIn. - Starrry Accept invitation from Starrry Han http://www.linkedin.com/e/-kkb1ec-gkt15x24-k/qTMmi8QEI_f

Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Wen Congyang
At 03/03/2011 06:27 AM, Stefan Weil Write: > Am 02.03.2011 23:01, schrieb Stefan Weil: >> Am 02.03.2011 19:47, schrieb Peter Maydell: >>> On 2 March 2011 18:36, Stefan Weil wrote: No. I dont't think that the third parameter of bitmap_clear is ok like that. See my patch for the correct va

Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Peter Maydell
On 2 March 2011 22:01, Stefan Weil wrote: > The part missing in my patch is correct handling of another > rounding effect: > > VNC_DIRTY_WORDS is exact for 32 bit long values (and the > "old" code which used uint32_t until some weeks ago), where > VNC_DIRTY_WORDS = 2560/16/32 = 5. > > For 64 bit v

[Qemu-devel] [PATCH v4 1/2] rtl8139: add vlan tag extraction

2011-03-02 Thread Benjamin Poirier
Add support to the emulated hardware to extract vlan tags in packets going from the network to the guest. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko Cc: Jason Wang Cc: Michael S. Tsirkin -- AFAIK, extraction is optional to get vlans working. The driver requests rx detagging but sh

[Qemu-devel] [PATCH v4 2/2] rtl8139: add vlan tag insertion

2011-03-02 Thread Benjamin Poirier
Add support to the emulated hardware to insert vlan tags in packets going from the guest to the network. Signed-off-by: Benjamin Poirier Cc: Igor V. Kovalenko Cc: Jason Wang Cc: Michael S. Tsirkin --- hw/rtl8139.c | 102 ++ 1 files chan

[Qemu-devel] [PATCH v4] rtl8139: add vlan support

2011-03-02 Thread Benjamin Poirier
I've tested v4 with x86_64 host/guest. I used the same testing procedure as before. I've tested a plain configuration as well as one with tso + vlan offload, successfully. I had to hack around the Linux 8139cp driver to be able to enable tso on vlan which leads me to wonder, can someone with acces

Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Stefan Weil
Am 02.03.2011 23:01, schrieb Stefan Weil: Am 02.03.2011 19:47, schrieb Peter Maydell: On 2 March 2011 18:36, Stefan Weil wrote: No. I dont't think that the third parameter of bitmap_clear is ok like that. See my patch for the correct value. Wen's patch: + const size_t width = ds_get_width(v

[Qemu-devel] [PATCH 2/2] net: fix qemu_can_send_packet logic

2011-03-02 Thread Vincent Palatin
If any of the clients is not ready to receive (ie it has a can_receive callback and can_receive() returns false), we don't want to start sending, else this client may miss/discard the packet. I got this behaviour with the following setup : the emulated machine is using an USB-ethernet adapter, it

[Qemu-devel] net: small fixes

2011-03-02 Thread Vincent Palatin
Dear Qemu developers, While debugging a machine emulation using SLIRP based user networking, I ran into a couple of issues. Please find attached the patches for them : 1) fix the SLIRP compilation when the debug traces are activated. 2) avoid packet loss with several receivers on the same vlan.

[Qemu-devel] [PATCH 1/2] net: fix trace when debug is activated in slirp

2011-03-02 Thread Vincent Palatin
make the code compile correctly when DEBUG is activated. Signed-off-by: Vincent Palatin --- slirp/bootp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/slirp/bootp.c b/slirp/bootp.c index 0905c6d..1eb2ed1 100644 --- a/slirp/bootp.c +++ b/slirp/bootp.c @@ -284,7 +284,7

Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Stefan Weil
Am 02.03.2011 19:47, schrieb Peter Maydell: On 2 March 2011 18:36, Stefan Weil wrote: No. I dont't think that the third parameter of bitmap_clear is ok like that. See my patch for the correct value. Wen's patch: + const size_t width = ds_get_width(vd->ds) / 16; [...] -bitmap_set(width_ma

Re: [Qemu-devel] [RFC][PATCH] Preliminary BeBox support

2011-03-02 Thread Andreas Färber
Hello François, Am 01.03.2011 um 01:15 schrieb François Revol: Since Natalia raised the subject I though I'd post my current patch for the BeBox support. I think the loader stuff can probably be committed already with some cleanup. The rest is mostly a copy of the prep file with tweaks and n

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-03-02 Thread Anthony Liguori
On 03/02/2011 11:30 AM, Avi Kivity wrote: It's really the natural generalization of what you're proposing. So basically, the only differences are: 1) always use the new RAID1 format 2) drop the progress bitmap 3) support multiple devices per file 4) let drive properties be specified beyond

[Qemu-devel] Re: EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread vagran
vagran wrote: Hi, I have noted that Qemu VGA and serial console with EFI BIOS stopped working in 0.14.0 (and in latest development snapshot is still not working). Everything was fine in 0.13.0. However EFI BIOS itself is able to load kernel if it was properly configured on used disk image. The

[Qemu-devel] [PATCH] fix offset for MMIO subpage access

2011-03-02 Thread Vincent Palatin
When using a MMIO subpage not starting on a page boundary, the offset value given to the access handler is based on the start of the MMU page not on the subpage base. As a consequence, if you are mapping the same subpage sized MMIO device at different addresses, this is somewhat impractical and con

Re: [Qemu-devel] Memory Map

2011-03-02 Thread Vincent Palatin
Hi, On Wed, Mar 2, 2011 at 12:11, Salvatore Lionetti wrote: > Still now, some memory region is called with base+offset. > > So: > > [0x204] <= value (write from uP register) > cause > read(opaque, offset=204, value) > > while > [0x504] <= value (write from uP register) > cause > read(opaque, offs

Re: [Qemu-devel] Re: [PATCH] moving eeprom initialization

2011-03-02 Thread William Dauchy
On Wed, Mar 2, 2011 at 7:28 PM, Gerhard Wiesinger wrote: > Your patch should be based on fixes for correct EEPROM initialization, see > for details: http://www.mail-archive.com/qemu-devel@nongnu.org/msg56414.html This patch is not yet integrated upstream. I will correct it if needed. -- William

[Qemu-devel] EFI console stopped working in Qemu 0.14.0

2011-03-02 Thread vagran
Hi, I have noted that Qemu VGA and serial console with EFI BIOS stopped working in 0.14.0 (and in latest development snapshot is still not working). Everything was fine in 0.13.0. However EFI BIOS itself is able to load kernel if it was properly configured on used disk image. The only effect is

[Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support

2011-03-02 Thread Marcelo Tosatti
On Wed, Mar 02, 2011 at 04:36:34PM -0300, Marcelo Tosatti wrote: > On Wed, Mar 02, 2011 at 08:03:42PM +0100, Jan Kiszka wrote: > > On 2011-03-02 19:43, Marcelo Tosatti wrote: > > > On Tue, Mar 01, 2011 at 02:35:56PM +0200, Avi Kivity wrote: > > >> On 02/28/2011 04:05 PM, Paolo Bonzini wrote: > > >>

[Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support

2011-03-02 Thread Marcelo Tosatti
On Wed, Mar 02, 2011 at 08:03:42PM +0100, Jan Kiszka wrote: > On 2011-03-02 19:43, Marcelo Tosatti wrote: > > On Tue, Mar 01, 2011 at 02:35:56PM +0200, Avi Kivity wrote: > >> On 02/28/2011 04:05 PM, Paolo Bonzini wrote: > >>> On 02/28/2011 01:13 PM, Avi Kivity wrote: > > > > If there'

[Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support

2011-03-02 Thread Jan Kiszka
On 2011-03-02 19:43, Marcelo Tosatti wrote: > On Tue, Mar 01, 2011 at 02:35:56PM +0200, Avi Kivity wrote: >> On 02/28/2011 04:05 PM, Paolo Bonzini wrote: >>> On 02/28/2011 01:13 PM, Avi Kivity wrote: > If there's a git tree of this I'll be happy to do an autotest run. >>> >>> Sure, it

[Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support

2011-03-02 Thread Marcelo Tosatti
On Tue, Mar 01, 2011 at 02:35:56PM +0200, Avi Kivity wrote: > On 02/28/2011 04:05 PM, Paolo Bonzini wrote: > >On 02/28/2011 01:13 PM, Avi Kivity wrote: > >>> > >> > >>If there's a git tree of this I'll be happy to do an autotest run. > > > >Sure, it's branch iothread-win32 of git://github.com/bonzi

Re: [Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Peter Maydell
On 2 March 2011 18:36, Stefan Weil wrote: > No. I dont't think that the third parameter of bitmap_clear is > ok like that. See my patch for the correct value. Wen's patch: +const size_t width = ds_get_width(vd->ds) / 16; [...] -    bitmap_set(width_mask, 0, (ds_get_width(vd->ds) / 16)); -  

Re: [Qemu-devel] Re: [PATCH] moving eeprom initialization

2011-03-02 Thread Gerhard Wiesinger
Hello, Your patch should be based on fixes for correct EEPROM initialization, see for details: http://www.mail-archive.com/qemu-devel@nongnu.org/msg56414.html Ciao, Gerhard -- http://www.wiesinger.com/ On Wed, 2 Mar 2011, William Dauchy wrote: On Wed, Mar 2, 2011 at 2:36 PM, William Dauc

[Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Stefan Weil
Am 02.03.2011 11:57, schrieb Corentin Chary: On Wed, Mar 2, 2011 at 3:58 AM, Wen Congyang wrote: This bug is reported by Stefan Weil: Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced a severe bug (heap corruption). bitmap_clear was called with a wrong argument which caused o

Re: [Qemu-devel] Re: OMAP3 bug: disassembler disagreed with translator

2011-03-02 Thread Антон Кочков
Good day! Right now it works, you can see source at the http://gitorious.org/droid/qemu Don't see at the hw/motorola.c - here is only stub yet, not with real hardware, i'm experimenting with it. But omap3* files works ok with every other hardware. Here you can see examples how it works: https://w

[Qemu-devel] [PATCH] target-arm: Set carry flag correctly for Thumb2 ORNS

2011-03-02 Thread Peter Maydell
The code for Thumb2 ORNS (or negated and set flags) was trashing a TCG input register which was needed later for use in calculating flags, with the effect that the carry flag was always set with the wrong sense. Fix this by using a TCG temporary instead. Signed-off-by: Peter Maydell --- target-a

Re: [Qemu-devel] Memory Map

2011-03-02 Thread Salvatore Lionetti
Hi, many thanks for your response. Now i'm i've avoided the unregistering stuff, map done already at desired address space. Still now, some memory region is called with base+offset. So: [0x204] <= value (write from uP register) cause read(opaque, offset=204, value) while [0x504] <= value (wr

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-03-02 Thread Avi Kivity
On 03/01/2011 05:51 PM, Anthony Liguori wrote: Do a hot unplug of a network device with upstream libvirt with acpiphp unloaded, consult libvirt and then consult the monitor to see who has the right view of the guests config. libvirt is right and the monitor is wrong. On real hardware, calli

[Qemu-devel] [PATCH] allow to load android binary

2011-03-02 Thread matthieu castet
Hi, Android binary start with a weird elf program header : the first one is of size 0 pointing to NULL addr. Ignore LOAD program where MemSiz is 0. Elf file type is EXEC (Executable file) Entry point 0xb0001000 There are 5 program headers, starting at offset 52 Program Headers: Type

[Qemu-devel] Re: [PATCH] moving eeprom initialization

2011-03-02 Thread William Dauchy
On Wed, Mar 2, 2011 at 2:36 PM, William Dauchy wrote: > The initialization should not be only on reset but also when initializing > the device. > It resolves a bug when hot plugging a pci network device: the mac address > was always null. > --- >  hw/pcnet.c   |   27 ++- >

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-03-02 Thread Anthony Liguori
On 03/02/2011 08:00 AM, Avi Kivity wrote: On 03/02/2011 02:39 PM, Anthony Liguori wrote: Here is where your race is: 2. Management sends a switch command 3. QEMU receives switch command 4. QEMU stops doubling IO and switches to the destination 5. QEMU sends acknowledgement of switch command

[Qemu-devel] [PATCH] Don't allow multiwrites against a block device without underlying medium

2011-03-02 Thread Ryan Harper
If the block device has been closed, we no longer have a medium to submit IO against, check for this before submitting io. This prevents a segfault further in the code where we dereference elements of the block driver. Signed-off-by: Ryan Harper --- block.c |5 + 1 files changed, 5 inse

[Qemu-devel] [PATCH] Do not delete BlockDriverState when deleting the drive

2011-03-02 Thread Ryan Harper
When removing a drive from the host-side via drive_del we currently have the following path: drive_del qemu_aio_flush() bdrv_close() drive_uninit() bdrv_delete() When we bdrv_delete() we end up qemu_free()'ing the BlockDriverState pointer however, the block devices retain a copy of this pointer,

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Michael Roth
On 03/02/2011 07:18 AM, Jes Sorensen wrote: On 03/02/11 14:13, Michael Roth wrote: On 03/02/2011 04:19 AM, Jes Sorensen wrote: It is absolutely vital for me that we do not make things much more complicated for users with this move. I don't want to get into a situation where we start forcing e

[Qemu-devel] [PATCH] moving eeprom initialization

2011-03-02 Thread William Dauchy
The initialization should not be only on reset but also when initializing the device. It resolves a bug when hot plugging a pci network device: the mac address was always null. --- hw/pcnet.c | 27 ++- hw/rtl8139.c | 24 2 files changed, 26 in

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/02/11 14:13, Michael Roth wrote: > On 03/02/2011 04:19 AM, Jes Sorensen wrote: >> It is absolutely vital for me that we do not make things much more >> complicated for users with this move. I don't want to get into a >> situation where we start forcing external packages or daemons in order >

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Michael Roth
On 03/02/2011 04:19 AM, Jes Sorensen wrote: On 02/28/11 18:44, Anthony Liguori wrote: On Feb 28, 2011 10:44 AM, "Jes Sorensen" wrote: Separating host-side virtagent and other tasks from core QEMU = To improve auditing of the core QEM

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-03-02 Thread Avi Kivity
On 03/02/2011 02:39 PM, Anthony Liguori wrote: Here is where your race is: 2. Management sends a switch command 3. QEMU receives switch command 4. QEMU stops doubling IO and switches to the destination 5. QEMU sends acknowledgement of switch command 6. Management receives acknowledge of swi

Re: [Qemu-devel] [PATCH] spice/qxl: locking fix for qemu-kvm

2011-03-02 Thread Alon Levy
On Wed, Mar 02, 2011 at 02:32:03PM +0200, Alon Levy wrote: > From: Gerd Hoffmann Err, that "From" got there by mistake, and the title should of course not say "for qemu-kvm".. > > qxl needs to release the qemu lock before calling some libspice > functions (and re-aquire it later). In upstream

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Alon Levy
On Wed, Mar 02, 2011 at 01:04:58PM +0200, Dor Laor wrote: > On 03/02/2011 12:58 PM, Alon Levy wrote: > >On Wed, Mar 02, 2011 at 11:25:44AM +0100, Jes Sorensen wrote: > >>On 03/01/11 15:25, Dor Laor wrote: > >>>On 03/01/2011 02:40 PM, Anthony Liguori wrote: > > On Mar 1, 2011 7:07 AM, "Dor

Re: [Qemu-devel] Re: [patch 2/3] Add support for live block copy

2011-03-02 Thread Anthony Liguori
On 03/01/2011 03:59 AM, Dor Laor wrote: On 02/28/2011 08:12 PM, Anthony Liguori wrote: On Feb 28, 2011 11:47 AM, "Avi Kivity" mailto:a...@redhat.com>> wrote: > > On 02/28/2011 07:33 PM, Anthony Liguori wrote: >> >> >> > >> > You're just ignoring what I've written. >> >> No, you're just impervio

Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-02 Thread Alon Levy
On Wed, Mar 02, 2011 at 12:34:24PM +0100, Jan Kiszka wrote: > On 2011-03-02 11:56, Alon Levy wrote: > > On Wed, Mar 02, 2011 at 09:22:35AM +0100, Jan Kiszka wrote: > >> On 2011-03-01 13:58, Alon Levy wrote: > >>> On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote: > On 2011-02-27 20:03

[Qemu-devel] [PATCH] spice/qxl: locking fix for qemu-kvm

2011-03-02 Thread Alon Levy
From: Gerd Hoffmann qxl needs to release the qemu lock before calling some libspice functions (and re-aquire it later). In upstream qemu qxl can just use qemu_mutex_{unlock,lock}_iothread. In qemu-kvm this doesn't work, qxl needs additionally save+restore the cpu_single_env pointer on unlock+lo

[Qemu-devel] [Request for inputs]Qemu parameters that need runtime change.

2011-03-02 Thread Prerna Saxena
Hi, QEMU at present can be started with a huge list of parameters, and only a subset of these can be changed at runtime. For the remaining ones, one needs to restart the qemu instance. I've been trying to put together a list of some such parameters, which would make good candidates for a runtim

Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-02 Thread Jan Kiszka
On 2011-03-02 11:56, Alon Levy wrote: > On Wed, Mar 02, 2011 at 09:22:35AM +0100, Jan Kiszka wrote: >> On 2011-03-01 13:58, Alon Levy wrote: >>> On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote: On 2011-02-27 20:03, Alon Levy wrote: > On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan

Re: [Qemu-devel] [PATCH -V2 4/6] hw/9pfs: Implement syncfs

2011-03-02 Thread Aneesh Kumar K. V
On Wed, 2 Mar 2011 10:20:41 +, Stefan Hajnoczi wrote: > On Wed, Mar 2, 2011 at 5:05 AM, Aneesh Kumar K. V > wrote: > > On Tue, 1 Mar 2011 20:27:19 +, Stefan Hajnoczi > > wrote: > >> On Tue, Mar 1, 2011 at 6:02 PM, Aneesh Kumar K. V > >> wrote: > >> > On Tue, 1 Mar 2011 15:59:19 +,

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Dor Laor
On 03/02/2011 12:58 PM, Alon Levy wrote: On Wed, Mar 02, 2011 at 11:25:44AM +0100, Jes Sorensen wrote: On 03/01/11 15:25, Dor Laor wrote: On 03/01/2011 02:40 PM, Anthony Liguori wrote: On Mar 1, 2011 7:07 AM, "Dor Laor" Qemu is the one that should spawn them and they should be transparent fr

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/02/11 11:58, Alon Levy wrote: > On Wed, Mar 02, 2011 at 11:25:44AM +0100, Jes Sorensen wrote: >> I had a few thoughts about this already, which I think will work for >> both spice and vnc. What we could do is to expose the video memory via >> shared memory. That way a spice or vnc daemon coul

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/02/11 11:56, Dor Laor wrote: > On 03/02/2011 12:25 PM, Jes Sorensen wrote: >> On 03/01/11 15:25, Dor Laor wrote: >> Using shared memory this way should allow us to implement the video >> clients without performance loss, in fact it should be beneficial since >> it would allow them to run full

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Alon Levy
On Wed, Mar 02, 2011 at 11:25:44AM +0100, Jes Sorensen wrote: > On 03/01/11 15:25, Dor Laor wrote: > > On 03/01/2011 02:40 PM, Anthony Liguori wrote: > >> > >> On Mar 1, 2011 7:07 AM, "Dor Laor" >> > Qemu is the one that should spawn them and they should be transparent > >> from the management. T

[Qemu-devel] Re: [PATCH RESEND v2 1/2] fix vnc regression

2011-03-02 Thread Corentin Chary
On Wed, Mar 2, 2011 at 3:46 AM, Wen Congyang wrote: > This patch fix the following two regressions: > 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(). > 2. The unit of bitmap_intersects()'third parameter is bit, not words. >   But we pass the num of words to bitmap_inter

[Qemu-devel] Re: [PATCH RESEND 2/2] vnc: Fix heap corruption

2011-03-02 Thread Corentin Chary
On Wed, Mar 2, 2011 at 3:58 AM, Wen Congyang wrote: > This bug is reported by Stefan Weil: > > Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced > a severe bug (heap corruption). > > bitmap_clear was called with a wrong argument > which caused out-of-bound writes to width_mask. >

Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-02 Thread Alon Levy
On Wed, Mar 02, 2011 at 09:22:35AM +0100, Jan Kiszka wrote: > On 2011-03-01 13:58, Alon Levy wrote: > > On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote: > >> On 2011-02-27 20:03, Alon Levy wrote: > >>> On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote: > On 2011-02-26 12:43

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Dor Laor
On 03/02/2011 12:25 PM, Jes Sorensen wrote: On 03/01/11 15:25, Dor Laor wrote: On 03/01/2011 02:40 PM, Anthony Liguori wrote: On Mar 1, 2011 7:07 AM, "Dor Laor" Qemu is the one that should spawn them and they should be transparent from the management. This way running qemu stays the same and

Re: [Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-03-02 Thread Alon Levy
On Tue, Mar 01, 2011 at 12:53:40PM -0600, Rick Vernam wrote: > On Tuesday 01 March 2011 12:29:14 Serge Hallyn wrote: > > @Rick, > > > > would you expect a fedora guest to reproduce this? Would it have the > > qxl driver? Or must it be Windows? > > I don't have a fedora guest to test on, and I d

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/02/11 11:42, Dor Laor wrote: > On 03/02/2011 12:28 PM, Jes Sorensen wrote: >> On 03/01/11 15:25, Dor Laor wrote: >>> I agree it is desirable to the this for spice but it is allot more >>> complex than virtagent isolation. Spice is performance sensitive and >>> contains much more state. It nee

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Dor Laor
On 03/02/2011 12:28 PM, Jes Sorensen wrote: On 03/01/11 15:25, Dor Laor wrote: On 03/01/2011 02:40 PM, Anthony Liguori wrote: Spice is the logical place to start, no? It's the largest single dependency we have and it does some scary things with qemu_mutex. I would use spice as a way to prove

Re: [Qemu-devel] REPOST: [PATCH v3] tracetool: Add optional argument to specify dtrace probe names

2011-03-02 Thread Stefan Hajnoczi
On Wed, Mar 2, 2011 at 8:22 AM, wrote: > From: Jes Sorensen > > Optional feature allowing a user to generate the probe list to match > the name of the binary, in case they wish to install qemu under a > different name than qemu-{system,user}, > > Signed-off-by: Jes Sorensen > --- >  scripts/tra

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-03-02 Thread Dave Walker
@Serge, I had to re-target your branch (and merge) against 0.14.0~rc1 +noroms-0ubuntu4 as *ubuntu3 had already been uploaded for a different fix, and the package-importer failed to suck it in. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/01/11 15:25, Dor Laor wrote: > On 03/01/2011 02:40 PM, Anthony Liguori wrote: >> Spice is the logical place to start, no? It's the largest single >> dependency we have and it does some scary things with qemu_mutex. I >> would use spice as a way to prove the concept. > > I agree it is desir

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/01/11 15:25, Dor Laor wrote: > On 03/01/2011 02:40 PM, Anthony Liguori wrote: >> >> On Mar 1, 2011 7:07 AM, "Dor Laor" > > Qemu is the one that should spawn them and they should be transparent >> from the management. This way running qemu stays the same and qemu just >> need to add the logic

[Qemu-devel] [Bug 723871] Re: qemu-kvm-0.14.0 Aborts with -vga qxl

2011-03-02 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 0.14.0~rc1+noroms-0ubuntu4 --- qemu-kvm (0.14.0~rc1+noroms-0ubuntu4) natty; urgency=low * Apply spice-qxl-locking-fix-for-qemu-kvm.patch to fix bug with -qxl. (LP: #723871) -- Serge HallynTue, 01 Mar 2011 11:12:44 -0600 ** Chang

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 03/01/11 13:07, Dor Laor wrote: > On 02/28/2011 07:44 PM, Anthony Liguori wrote: >> I'm very nervous about having a large number of daemons necessary to run >> QEMU. I think a reasonable approach would be a single front-end daemond. > > s/daemon/son processes/ > Qemu is the one that should spa

Re: [Qemu-devel] [PATCH -V2 4/6] hw/9pfs: Implement syncfs

2011-03-02 Thread Stefan Hajnoczi
On Wed, Mar 2, 2011 at 5:05 AM, Aneesh Kumar K. V wrote: > On Tue, 1 Mar 2011 20:27:19 +, Stefan Hajnoczi wrote: >> On Tue, Mar 1, 2011 at 6:02 PM, Aneesh Kumar K. V >> wrote: >> > On Tue, 1 Mar 2011 15:59:19 +, Stefan Hajnoczi >> > wrote: >> >> >> Please explain the semantics of P9_TS

Re: [Qemu-devel] QEMU: Discussion of separating core functionality vs supportive features

2011-03-02 Thread Jes Sorensen
On 02/28/11 18:44, Anthony Liguori wrote: > On Feb 28, 2011 10:44 AM, "Jes Sorensen" wrote: >> > Separating host-side virtagent and other tasks from core QEMU >> > = >> > >> > To improve auditing of the core QEMU code, it would be ideal t

Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl

2011-03-02 Thread Jan Kiszka
On 2011-03-01 13:58, Alon Levy wrote: > On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote: >> On 2011-02-27 20:03, Alon Levy wrote: >>> On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote: On 2011-02-26 12:43, xming wrote: > When trying to start X (and it loads qxl driver)

[Qemu-devel] [PATCH v3 11/17] kvm: x86: Inject pending MCE events on state writeback

2011-03-02 Thread Jan Kiszka
The current way of injecting MCE events without updating of and synchronizing with the CPUState is broken and causes spurious corruptions of the MCE-related parts of the CPUState. As a first step towards a fix, enhance the state writeback code with support for injecting events that are pending in

[Qemu-devel] [PATCH v3 02/17] kvm: Fix build warning when KVM_CAP_SET_GUEST_DEBUG is lacking

2011-03-02 Thread Jan Kiszka
Original fix by David Gibson. CC: David Gibson Signed-off-by: Jan Kiszka --- kvm-all.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index e6a7de4..7753c8a 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -998,7 +998,9 @@ int kvm_cpu_exec(CPUState *env

[Qemu-devel] [PATCH v3 13/17] kvm: x86: Consolidate TCG and KVM MCE injection code

2011-03-02 Thread Jan Kiszka
This switches KVM's MCE injection path to cpu_x86_inject_mce, both for SIGBUS and monitor initiated events. This means we prepare the MCA MSRs in the VCPUState also for KVM. We have to drop the MSRs writeback restrictions for this purpose which is now safe as every uncoordinated MSR injection is r

[Qemu-devel] REPOST: [PATCH v3] tracetool: Add optional argument to specify dtrace probe names

2011-03-02 Thread Jes . Sorensen
From: Jes Sorensen Optional feature allowing a user to generate the probe list to match the name of the binary, in case they wish to install qemu under a different name than qemu-{system,user}, Signed-off-by: Jes Sorensen --- scripts/tracetool | 19 +-- 1 files changed, 13 in

[Qemu-devel] [PATCH v3 00/17] [uq/master] Patch queue, part IV (MCE edition)

2011-03-02 Thread Jan Kiszka
This is mostly a rebase of the previous round, just including one additional ppc build fix (patch 2) for a regression in a previous part. Please merge. CC: David Gibson CC: Hidetoshi Seto CC: Huang Ying CC: Jin Dongming Huang Ying (2): Add qemu_ram_remap KVM, MCE, unpoison memory address

[Qemu-devel] [PATCH v3 09/17] kvm: x86: Move MCE functions together

2011-03-02 Thread Jan Kiszka
Pure function suffling to avoid multiple #ifdef KVM_CAP_MCE sections, no functional changes. While at it, annotate some #ifdef sections. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/kvm.c | 346 ++

[Qemu-devel] [PATCH v3 06/17] x86: Refine error reporting of MCE injection services

2011-03-02 Thread Jan Kiszka
As this service is used by the human monitor, make sure that errors get reported to the right channel, and also raise the verbosity. This requires to move Monitor typedef in qemu-common.h to resolve the include dependency. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Don

[Qemu-devel] [PATCH v3 07/17] x86: Optionally avoid injecting AO MCEs while others are pending

2011-03-02 Thread Jan Kiszka
Allow to tell cpu_x86_inject_mce that it should ignore Action Optional MCE events when the target VCPU is still processing another one. This will be used by KVM soon. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- monitor.c|7 +-- target-i

[Qemu-devel] [PATCH v3 05/17] x86: Small cleanups of MCE helpers

2011-03-02 Thread Jan Kiszka
Fix some code style issues, use proper headers, and align to cpu_x86 naming scheme. No functional changes. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- cpu-all.h|4 monitor.c|2 +- target-i386/cpu.h|5 + targ

[Qemu-devel] [PATCH v3 17/17] KVM, MCE, unpoison memory address across reboot

2011-03-02 Thread Jan Kiszka
From: Huang Ying In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If the error physical memory p

[Qemu-devel] [PATCH v3 16/17] Add qemu_ram_remap

2011-03-02 Thread Jan Kiszka
From: Huang Ying qemu_ram_remap() unmaps the specified RAM pages, then re-maps these pages again. This is used by KVM HWPoison support to clear HWPoisoned page tables across guest rebooting, so that a new page may be allocated later to recover the memory error. [ Jan: style fixlets, WIN32 fix ]

[Qemu-devel] [PATCH v3 04/17] x86: Perform implicit mcg_status reset

2011-03-02 Thread Jan Kiszka
Reorder mcg_status in CPUState to achieve automatic clearing on reset. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/cpu.h|3 ++- target-i386/helper.c |2 -- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/target-i386/c

[Qemu-devel] [PATCH v3 14/17] kvm: x86: Clean up kvm_setup_mce

2011-03-02 Thread Jan Kiszka
There is nothing to abstract here. Fold kvm_setup_mce into its caller and fix up the error reporting (return code of kvm_vcpu_ioctl holds the error value). Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/kvm.c | 11 --- 1 files changed, 4

[Qemu-devel] [PATCH v3 03/17] x86: Account for MCE in cpu_has_work

2011-03-02 Thread Jan Kiszka
MCEs can be injected asynchronously, so they can also terminate the halt state. Signed-off-by: Jan Kiszka CC: Huang Ying CC: Hidetoshi Seto CC: Jin Dongming --- target-i386/exec.h | 15 ++- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/target-i386/exec.h b/targe

[Qemu-devel] [PATCH v3 12/17] x86: Run qemu_inject_x86_mce on target VCPU

2011-03-02 Thread Jan Kiszka
We will use the current TCG-only MCE injection path for KVM as well, and then this read-modify-write of the target VCPU state has to be performed synchronously in the corresponding thread. Signed-off-by: Jan Kiszka --- target-i386/helper.c | 87 +

[Qemu-devel] [PATCH v3 10/17] kvm: Rename kvm_arch_process_irqchip_events to async_events

2011-03-02 Thread Jan Kiszka
We will broaden the scope of this function on x86 beyond irqchip events. Signed-off-by: Jan Kiszka --- kvm-all.c |2 +- kvm.h |2 +- target-i386/kvm.c |2 +- target-ppc/kvm.c |2 +- target-s390x/kvm.c |2 +- 5 files changed, 5 insertions(+), 5 deletio