Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-26 Thread Gerd Hoffmann
On 05/25/11 16:33, Alon Levy wrote: On Wed, May 25, 2011 at 04:06:03PM +0200, Gerd Hoffmann wrote: On 05/25/11 15:53, Alon Levy wrote: Without this windows xp guests set a 4 bits per pixel graphics mode. Hmm? Never seen this. Details please. When I start a windows xp guest with -vga qxl

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-26 Thread Alon Levy
On Thu, May 26, 2011 at 08:50:01AM +0200, Gerd Hoffmann wrote: On 05/25/11 16:33, Alon Levy wrote: On Wed, May 25, 2011 at 04:06:03PM +0200, Gerd Hoffmann wrote: On 05/25/11 15:53, Alon Levy wrote: Without this windows xp guests set a 4 bits per pixel graphics mode. Hmm? Never seen this.

Re: [Qemu-devel] [PATCH 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64()

2011-05-26 Thread Alexander Graf
On 26.05.2011, at 06:56, Stefan Weil wrote: Am 26.05.2011 06:32, schrieb Stefan Weil: Am 26.05.2011 00:15, schrieb Alexander Graf: On 25.05.2011, at 22:25, Stefan Weil wrote: tcg_gen_shl_i64 needs an argument of type TCGv_i64. Using tmp4 needs some additional changes. Signed-off-by:

Re: [Qemu-devel] Xen: enabling emulated MSI injection

2011-05-26 Thread Wei Liu
On Thu, May 26, 2011 at 3:21 PM, Jan Kiszka jan.kis...@siemens.com wrote: A cleaner way of hooking into this would be registering on the MSI MMIO target region (replacing the APIC). That would give you MSI support as well. However, KVM has much more complex requirements for MSI handling when

Re: [Qemu-devel] Xen: enabling emulated MSI injection

2011-05-26 Thread Jan Kiszka
On 2011-05-26 09:35, Wei Liu wrote: On Thu, May 26, 2011 at 3:21 PM, Jan Kiszka jan.kis...@siemens.com wrote: A cleaner way of hooking into this would be registering on the MSI MMIO target region (replacing the APIC). That would give you MSI support as well. However, KVM has much more complex

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-26 Thread Gerd Hoffmann
Hi, Which qemu version? Which seabios vgabios version? qemu is the spice v36 branch with some unrelated patches. seabios + vgabios upstream (seabios with 0x900 size hack). I can retest with qemu upstream. Hmm, same here. Windows xp booting in 4bit usually indicates VBE doesn't

Re: [Qemu-devel] [RFCv2] vga: VBE: report maximum VGA_MEM_SIZE memory

2011-05-26 Thread Gerd Hoffmann
On 05/25/11 17:56, Alon Levy wrote: When using -vga qxl the amount reported is minimally 32 MiB, making windows guests come up in a 16 color mode. With this change they work correctly, coming up with the full range of VBE supported modes. This patch changes just the reported memory size by VBE

Re: [Qemu-devel] [PATCH v5 4/4] rbd: Add bdrv_truncate implementation

2011-05-26 Thread Kevin Wolf
Am 25.05.2011 22:34, schrieb Josh Durgin: Signed-off-by: Josh Durgin josh.dur...@dreamhost.com --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a44d160..b95b1eb 100644 --- a/block/rbd.c +++

Re: [Qemu-devel] [PATCH 1/2] QMP: add get_events(wait=True) option

2011-05-26 Thread Stefan Hajnoczi
On Wed, May 25, 2011 at 10:15 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Wed, 25 May 2011 19:48:00 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The get_events() function polls for new QMP events and then returns.  It can be useful to wait for the next QMP event so add

[Qemu-devel] header include order causes build failure

2011-05-26 Thread Christoph Egger
Hi, qemu build system includes third party headers before qemu headers which is wrong. It should be the other way around. When 'nas' (Network Audio System, http://www.pdl.cmu.edu/NASD/Downloads/NASDcode.html) is installed then there is an external audio/audio.h. Due to the wrong header

Re: [Qemu-devel] [PATCH v5 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-26 Thread Kevin Wolf
Am 25.05.2011 22:34, schrieb Josh Durgin: The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or conf. The conf option specifies a Ceph configuration file to read. This allows rbd volumes from

Re: [Qemu-devel] [RFC] reduce reported VGA framebuffer to 8 MiB

2011-05-26 Thread Alon Levy
On Thu, May 26, 2011 at 09:44:38AM +0200, Gerd Hoffmann wrote: Hi, Which qemu version? Which seabios vgabios version? qemu is the spice v36 branch with some unrelated patches. seabios + vgabios upstream (seabios with 0x900 size hack). I can retest with qemu upstream. Hmm,

Re: [Qemu-devel] [PATCH 2/2] QMP: add server mode to QEMUMonitorProtocol

2011-05-26 Thread Stefan Hajnoczi
The test-stream.py script performs several automated tests of the image streaming QMP interface, including exercising both the incremental and background streaming modes. This should probably be ported to KVM-Autotest rather than reinventing the wheel. Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 00/26] q35 chipset support for native pci express support

2011-05-26 Thread Isaku Yamahata
On Wed, May 25, 2011 at 09:15:55AM +0200, Jan Kiszka wrote: FWIW, patch below fixes UHCI here. I suspect more bugs in this area as accessing the chip_config registers appears to rely on the host being little endian (direct memcpy). In contrast, the PCI mapping issue turned out to be a read

Re: [Qemu-devel] [PATCH v2 1/2] Generalize -machine command line option

2011-05-26 Thread Ian Campbell
On Wed, 2011-05-25 at 11:54 +0100, Anthony PERARD wrote: On Wed, 25 May 2011, Ian Campbell wrote: On Tue, 2011-05-24 at 18:18 +0200, Jan Kiszka wrote: On 2011-05-24 18:06, Ian Campbell wrote: On Sun, 2011-05-22 at 13:00 +0200, Jan Kiszka wrote: From: Jan Kiszka

[Qemu-devel] [PATCH] target-i386: GPF on invalid MSRs

2011-05-26 Thread Josh Triplett
qemu currently returns 0 for rdmsr on invalid MSRs, and ignores wrmsr on invalid MSRs. Real x86 processors GPF on invalid MSRs, which allows software to detect unavailable MSRs. Emulate this behavior correctly in qemu. Bug discovered via the BIOS Implementation Test Suite http://biosbits.org/;

Re: [Qemu-devel] [PATCH] target-i386: GPF on invalid MSRs

2011-05-26 Thread Alexander Graf
On 26.05.2011, at 11:08, Josh Triplett wrote: qemu currently returns 0 for rdmsr on invalid MSRs, and ignores wrmsr on invalid MSRs. Real x86 processors GPF on invalid MSRs, which allows software to detect unavailable MSRs. Emulate this behavior correctly in qemu. Bug discovered via the

[Qemu-devel] [PATCH v2 0/3] spapr qdevification

2011-05-26 Thread Paolo Bonzini
This series fixes some problems with spapr's qdev interface. Patch 1 is the important one, which makes it possible to use -device to create vio devices. The other two are cosmetic. v1-v2: abstracted the call to xics_find_qirq behind spapr_find_qirq Paolo Bonzini (3): spapr: proper

[Qemu-devel] [PATCH v2 1/3] spapr: proper qdevification

2011-05-26 Thread Paolo Bonzini
Right now the spapr devices cannot be instantiated with -device, because the IRQs need to be passed to the spapr_*_create functions. Do this instead in the bus's init wrapper. This is particularly important with the conversion from scsi-disk to scsi-{cd,hd} that Markus made. After his patches,

[Qemu-devel] [PATCH v2 2/3] spapr: prepare for qdevification of irq

2011-05-26 Thread Paolo Bonzini
Restructure common properties for sPAPR devices so that IRQ definitions can be added in one place. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Alexander Graf ag...@suse.de Cc: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_llan.c |4 +--- hw/spapr_vio.h |5 +

[Qemu-devel] [PATCH v2 3/3] spapr: make irq customizable via qdev

2011-05-26 Thread Paolo Bonzini
This also lets the user see the irq in info qtree. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Alexander Graf ag...@suse.de Cc: David Gibson da...@gibson.dropbear.id.au --- hw/spapr_vio.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/hw/spapr_vio.c

Re: [Qemu-devel] [PULL] usb patch queue: initial usb 2.0 support.

2011-05-26 Thread Gerd Hoffmann
On 05/23/11 11:43, Gerd Hoffmann wrote: Hi, Here is the usb patch queue, with EHCI support being the outstanding new feature. Most patches are unmodified. Patch #5 got a better commit message. The EHCI patch now lists all contributes in the commit message too (they where listed in the

[Qemu-devel] [PATCH 04/12] usb-ehci: trace port state

2011-05-26 Thread Gerd Hoffmann
Trace usb port operations (attach, detach, reset), drop a few obsolete DPRINTF's. No change in behavior. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 10 -- trace-events |3 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/usb-ehci.c

[Qemu-devel] [PATCH 00/12] ehci: tracing, multiqueue, bugfixes.

2011-05-26 Thread Gerd Hoffmann
Hi, This patch series brings a number of improvements for the EHCI host adapter. First it makes EHCI use the tracing infrastructure. Conversion is done in a bunch of steps to ease review and to improve bisectability in case regressions show up. Not all debug messages are converted (yet).

[Qemu-devel] [PATCH 01/12] usb-linux: catch NODEV in more places.

2011-05-26 Thread Gerd Hoffmann
Factor out disconnect code (called when a device disappears) to a separate function. Add a check for NODEV errno to a few more places to make sure we notice disconnects. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- usb-linux.c | 27 --- 1 files changed, 20

[Qemu-devel] [PATCH 02/12] usb-ehci: trace mmio and usbsts

2011-05-26 Thread Gerd Hoffmann
This patch starts adding trace support to ehci. It traces updates of the status register (USBSTS), mmio access and controller reset. It also adds functions to set and clear status register bits and puts them in use everywhere. Some DPRINTF's are dropped in favor of the new tracepoints. No

[Qemu-devel] [PATCH 11/12] ehci: fix a number of unused-but-set-variable warnings (new with gcc-4.6)

2011-05-26 Thread Gerd Hoffmann
From: Hans de Goede hdego...@redhat.com --- hw/usb-ehci.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 2bbb5e4..e368395 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -740,11 +740,9 @@ static void ehci_detach(USBPort *port)

[Qemu-devel] [PATCH 09/12] usb-ehci: fix offset writeback in ehci_buffer_rw

2011-05-26 Thread Gerd Hoffmann
Two bugs at once: First the mask is backwards, so the it used to keeps the offset and clears the page address, which is not what we need when we update the offset. Second the offset calculation is wrong in case head isn't page aligned. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 03/12] usb-ehci: trace state machine changes

2011-05-26 Thread Gerd Hoffmann
Add functions to get and set the current state of the state machine, add tracepoints there to trace state transitions. Add support for traceing the queue heads and transfer descriptors as we look at them. Drop a few DPRINTFs and all DPRINTF_ST lines, they are obsolete now. No change in

[Qemu-devel] [PATCH 10/12] usb-ehci: fix error handling.

2011-05-26 Thread Gerd Hoffmann
Set the correct bits for nodev, stall and babble errors. Raise errint irq. Fix state transition from WRITEBACK to the next state. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 25 +++-- 1 files changed, 15 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 06/12] usb-ehci: trace buffer copy

2011-05-26 Thread Gerd Hoffmann
Add a trace point for buffer copies and drop the DPRINTF's. No change in behavior. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c |8 +--- trace-events |1 + 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index

[Qemu-devel] [PATCH 05/12] usb-ehci: improve mmio tracing

2011-05-26 Thread Gerd Hoffmann
Add a separate tracepoint to log how register values change in response to a mmio write. Especially useful for registers which have read-only or clear-on-write bits in them. No change in behavior. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-ehci.c | 16 ++--

[Qemu-devel] [PATCH 08/12] usb-ehci: multiqueue support

2011-05-26 Thread Gerd Hoffmann
This patch adds support for keeping multiple queues going at the same time. One slow device will not affect other devices any more. The patch adds code to manage EHCIQueue structs. It also does a number of changes to the state machine: * The state machine will never ever stop in EXECUTING any

[Qemu-devel] [PATCH 12/12] usb: cancel async packets on unplug

2011-05-26 Thread Gerd Hoffmann
This patch adds USBBusOps struct with (for now) only a single callback which is called when a device is about to be destroyed. The USB Host adapters are implementing this callback and use it to cancel any async requests which might be in flight before the device actually goes away.

[Qemu-devel] [PATCH 07/12] usb-ehci: add queue data struct

2011-05-26 Thread Gerd Hoffmann
Add EHCIQueue struct, move the fields needed to track the queue state into that struct. Pass the new struct instead of ehci state down to functions which handle the queue state. Lot of variable references have changed due to that without an actual functional change. Replace fetch_addr with two

[Qemu-devel] [PULL v5 00/25] SCSI subsystem improvements

2011-05-26 Thread Paolo Bonzini
The following changes since commit aa29141d84d58171c2d219f0a4b599bd76fb2e37: Merge remote-tracking branch 'kraxel/CVE-2011-1751' into staging (2011-05-25 07:04:13 -0500) are available in the git repository at: git://github.com/bonzini/qemu.git scsi.2 This series includes the following

[Qemu-devel] [PATCH v5 03/25] scsi: introduce scsi_req_data

2011-05-26 Thread Paolo Bonzini
This abstracts calling the command_complete callback, reducing churn in the following patches. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-bus.c | 11 +++ hw/scsi-disk.c|8 hw/scsi-generic.c |6 +++---

[Qemu-devel] [PATCH v5 02/25] scsi-generic: Remove bogus double complete

2011-05-26 Thread Paolo Bonzini
scsi-generic scsi_read_complete() should not -both- call the client complete callback with SCSI_REASON_DATA -and- call scsi_command_complete(). The former will cause the client to queue a new read or write request, while the later will free the request data structure, thus causing the new read or

[Qemu-devel] [PATCH v5 09/25] scsi: commonize purging requests

2011-05-26 Thread Paolo Bonzini
The code for canceling requests upon reset is already the same. Clean it up and move it to scsi-bus.c. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-bus.c | 12 hw/scsi-disk.c| 18 ++

[Qemu-devel] [PATCH v5 01/25] scsi: add tracing of scsi requests

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-bus.c |6 ++ trace-events |6 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index ceeb4ec..0fd85fc 100644 --- a/hw/scsi-bus.c

[Qemu-devel] [PATCH v5 07/25] lsi: extract lsi_find_by_tag

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/lsi53c895a.c | 63 +- 1 files changed, 38 insertions(+), 25 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 704e8ad..1ebcde7

[Qemu-devel] [PATCH v5 06/25] scsi: reference-count requests

2011-05-26 Thread Paolo Bonzini
With the next patch, a device may hold SCSIRequest for an indefinite time. Split a rather big patch, and protect against access errors, by reference counting them. There is some ugliness in scsi_send_command implementation due to the need to unref the request when it fails. This will go away

[Qemu-devel] [PATCH v5 11/25] scsi: introduce scsi_req_cancel

2011-05-26 Thread Paolo Bonzini
This is for when the request must be dropped in the void, but still memory should be freed. To this end, the devices register a second callback in SCSIBusOps. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/esp.c | 16

[Qemu-devel] [PATCH v5 04/25] scsi: introduce SCSIBusOps

2011-05-26 Thread Paolo Bonzini
There are more operations than a SCSI bus can handle, besides completing commands. One example, which this series will introduce, is cleaning up after a request is cancelled. More long term, a SCSI bus can represent the LUNs attached to a target; in this case, while all commands will ultimately

[Qemu-devel] [PATCH v5 10/25] scsi: introduce scsi_req_abort

2011-05-26 Thread Paolo Bonzini
This covers the case of canceling a request's I/O and still completing it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-bus.c|9 + hw/scsi.h|1 + hw/spapr_vscsi.c |8 ++-- 3 files changed, 12

[Qemu-devel] [PATCH v5 13/25] scsi: Update sense code handling

2011-05-26 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de The SCSI spec has a quite detailed list of sense codes available. It even mandates the use of specific ones for some failure cases. The current implementation just has one type of generic error which is actually a violation of the spec in certain cases. This

[Qemu-devel] [PATCH v5 15/25] scsi: introduce scsi_req_new

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/esp.c |2 +- hw/lsi53c895a.c |3 +-- hw/scsi-bus.c|5 + hw/scsi.h|1 + hw/spapr_vscsi.c |2 +- hw/usb-msd.c |2 +- 6 files changed, 10

[Qemu-devel] [PATCH v5 12/25] scsi: use scsi_req_complete

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-generic.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index c008e9c..229d24f 100644 --- a/hw/scsi-generic.c +++

[Qemu-devel] [PATCH v5 14/25] scsi: do not call send_command directly

2011-05-26 Thread Paolo Bonzini
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/esp.c |2 +- hw/lsi53c895a.c |2 +- hw/scsi-bus.c |9 - hw/scsi-disk.c|1 -

[Qemu-devel] [PATCH v5 19/25] scsi-disk: add data direction checking

2011-05-26 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de scsi_req_parse() already provides for a data direction setting, so we should be using it to check for correct direction. And we should return the sense code 'INVALID FIELD IN CDB' in these cases. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo

[Qemu-devel] [PATCH v5 16/25] scsi: introduce scsi_req_continue

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Christoph Hellwig h...@lst.de --- hw/esp.c | 26 ++ hw/lsi53c895a.c | 22 -- hw/scsi-bus.c| 16 +--- hw/scsi.h|1 + hw/spapr_vscsi.c | 26

[Qemu-devel] [PATCH v5 17/25] scsi: introduce scsi_req_get_buf

2011-05-26 Thread Paolo Bonzini
... and remove some SCSIDevice variables or fields that now become unused. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/esp.c |2 +- hw/lsi53c895a.c |2 +- hw/scsi-bus.c|5 + hw/scsi.h|1 +

[Qemu-devel] [PATCH v5 25/25] scsi: ignore LUN field in the CDB

2011-05-26 Thread Paolo Bonzini
The LUN field in the CDB is a historical relic. Ignore it as reserved, which is what modern SCSI specifications actually say. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-disk.c|6 +++--- hw/scsi-generic.c |5 ++--- 2 files

[Qemu-devel] [PATCH v5 22/25] esp: rename sense to status

2011-05-26 Thread Paolo Bonzini
This mirrors the LSI patch that was recently committed. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Christoph Hellwig h...@lst.de --- hw/esp.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/esp.c b/hw/esp.c index cd6dfc7..7af20a8 100644 ---

[Qemu-devel] [PATCH v5 08/25] scsi: Use 'SCSIRequest' directly

2011-05-26 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de Currently the SCSIRequest structure is abstracted away and cannot accessed directly from the driver. This requires the handler to do a lookup on an abstract 'tag' which identifies the SCSIRequest structure. With this patch the SCSIRequest structure is exposed

[Qemu-devel] [PATCH v5 18/25] scsi: Implement 'get_sense' callback

2011-05-26 Thread Paolo Bonzini
From: Hannes Reinecke h...@suse.de The get_sense callback copies existing sense information into the provided buffer. This is required if sense information should be transferred together with the command response. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v5 23/25] scsi: split command_complete callback in two

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Christoph Hellwig h...@lst.de --- hw/esp.c | 62 ++--- hw/lsi53c895a.c | 60 ++-- hw/scsi-bus.c|4 +- hw/scsi.h|9 + hw/spapr_vscsi.c | 101

[Qemu-devel] [PATCH v5 21/25] scsi-generic: Handle queue full

2011-05-26 Thread Paolo Bonzini
The sg driver currently has a hardcoded limit of commands it can handle simultaneously. When this limit is reached the driver will return -EDOM. So we need to capture this to enable proper return values here. Signed-off-by: Hannes Reinecke h...@suse.de Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH v5 24/25] scsi: rename arguments to the new callbacks

2011-05-26 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Christoph Hellwig h...@lst.de --- hw/esp.c | 10 +- hw/lsi53c895a.c | 20 ++-- hw/spapr_vscsi.c | 31 ++- hw/usb-msd.c | 10 +- 4 files changed, 34 insertions(+),

[Qemu-devel] [PATCH] target-arm: Fix compilation failure for 64 bit hosts

2011-05-26 Thread Peter Maydell
Use the correct _ptr aliases for manipulating the pointer to the fp_status; this fixes a compilation failure on 64 bit hosts. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Apologies for the build breakage. target-arm/translate.c | 18 +- 1 files changed, 9

[Qemu-devel] [PATCH v5 05/25] scsi-generic: do not use a stale aiocb

2011-05-26 Thread Paolo Bonzini
If a request is canceled after it has been completed, scsi_cancel_io would pass a stale aiocb to bdrv_aio_cancel. Avoid this. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Cc: Christoph Hellwig h...@lst.de --- hw/scsi-generic.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v5 20/25] scsi: make write_data return void

2011-05-26 Thread Paolo Bonzini
The return value is unused anyway. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Christoph Hellwig h...@lst.de --- hw/scsi-disk.c|6 ++ hw/scsi-generic.c |7 ++- hw/scsi.h |2 +- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread malc
On Wed, 25 May 2011, Brad wrote: Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation of PowerPC host support for OpenBSD/powerpc based architectures. Signed-off-by: Brad Smith b...@comstyle.com --- cache-utils.c | 11 +-- 1 files changed, 9 insertions(+), 2

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-26 Thread Kirill Batuzov
On Fri, 20 May 2011, Richard Henderson wrote: On 05/20/2011 05:39 AM, Kirill Batuzov wrote: +case INDEX_op_sar_i32: +#if TCG_TARGET_REG_BITS == 64 +x = 0x; +y = 0x; +#endif +r = x 0x8000; +x = ~0x8000; +x =

Re: [Qemu-devel] [PATCH 1/2] QMP: add get_events(wait=True) option

2011-05-26 Thread Luiz Capitulino
On Thu, 26 May 2011 09:03:49 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, May 25, 2011 at 10:15 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Wed, 25 May 2011 19:48:00 +0100 Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The get_events() function polls for new QMP

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread Brad
- Original message - On Wed, 25 May 2011, Brad wrote: Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation of PowerPC host support for OpenBSD/powerpc based architectures. Signed-off-by: Brad Smith b...@comstyle.com --- cache-utils.c |    11

Re: [Qemu-devel] [PATCH 1/3] Add ppc_init_cacheline_sizes() function for OpenBSD.

2011-05-26 Thread malc
On Thu, 26 May 2011, Brad wrote: - Original message - On Wed, 25 May 2011, Brad wrote: Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation of PowerPC host support for OpenBSD/powerpc based architectures. Signed-off-by: Brad Smith b...@comstyle.com

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-26 Thread Richard Henderson
On 05/26/2011 05:36 AM, Kirill Batuzov wrote: x = (int32_t)x (int32_t)y; This expression has an implementation-defined behavior accroding to C99 6.5.7 so we decided to emulate signed shifts by hand. Technically, yes. In practice, no. GCC, ICC, LLVM, MSVC all know what the user wants here

[Qemu-devel] [PATCH] xen: fix interrupt routing

2011-05-26 Thread Stefano Stabellini
xen: fix interrupt routing - remove i440FX-xen and i440fx_write_config_xen we don't need to intercept pci config writes to i440FX anymore; - introduce PIIX3-xen and piix3_write_config_xen we do need to intercept pci config write to the PCI-ISA bridge to update the PCI link routing; - set the

[Qemu-devel] [Bug 788697] Re: [PowerPC] [patch] mtmsr does not preserve high bits of MSR

2011-05-26 Thread Nathan Whitehorn
** Patch added: mtmstr.diff https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/788697 Title: [PowerPC] [patch] mtmsr

[Qemu-devel] [Bug 788697] [NEW] [PowerPC] [patch] mtmsr does not preserve high bits of MSR

2011-05-26 Thread Nathan Whitehorn
Public bug reported: The mtmsr instruction on 64-bit PPC does not preserve the high-order 32-bits of the MSR the way it is supposed to, instead setting them to 0, which takes 64-bit code out of 64-bit mode. There is some code that does the right thing, but it brokenly only preserves these bits

[Qemu-devel] [Bug 788701] Re: qem-user fails to run rpcgen (i386, x86_64)

2011-05-26 Thread Rafał Krypa
** Attachment added: rpcgen.tar.bz2 https://bugs.launchpad.net/bugs/788701/+attachment/2143749/+files/rpcgen.tar.bz2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/788701 Title: qem-user fails

[Qemu-devel] [Bug 788701] [NEW] qem-user fails to run rpcgen (i386, x86_64)

2011-05-26 Thread Rafał Krypa
Public bug reported: Confirmed on qemu current development tree (git commit aa29141). While trying to run eglibc's rpcgen from native system by qemu-user, I get an error: qemu-x86_64 /usr/bin/rpcgen -c /dev/null fork: Invalid argument I am running a Debian Wheezy system and rpcgen comes from

[Qemu-devel] [PATCH] hw/9118.c: Implement active-low interrupt support

2011-05-26 Thread Peter Maydell
The 9118 ethernet controller interrupt line is active low unless the IRQ config register is programmed to set both the IRQ_POL (polarity: active-high) and IRQ_TYPE (type: push-pull) bits: implement support for inverting the irq output in other configurations. This also requires that we support

[Qemu-devel] [Bug 788701] Re: qemu-user fails to run rpcgen (i386, x86_64)

2011-05-26 Thread Rafał Krypa
** Summary changed: - qem-user fails to run rpcgen (i386, x86_64) + qemu-user fails to run rpcgen (i386, x86_64) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/788701 Title: qemu-user fails to run

Re: [Qemu-devel] [Bug 788697] Re: [PowerPC] [patch] mtmsr does not preserve high bits of MSR

2011-05-26 Thread Alexander Graf
On 26.05.2011, at 18:09, Nathan Whitehorn wrote: ** Patch added: mtmstr.diff https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 788734] [NEW] vmwgfx does not work in Linux guest in kvm

2011-05-26 Thread Michal Suchanek
Public bug reported: loading the vmwgfx module of kernel 2.6.39-rc7 in kvm 0.14 results in [drm:vmw_driver_load] *ERROR* Hardware has no pitchlock and the kernel module fails. Consequently vmwgfx is broken, only the vmwlegacy driver works. ** Affects: qemu Importance: Undecided

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-26 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 6 May 2011 18:36:31 +0300 Blue Swirl blauwir...@gmail.com wrote: On Fri, May 6, 2011 at 12:08 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Mon, May 2, 2011 at 6:57 PM, Luiz Capitulino

Re: [Qemu-devel] [PATCH] target-arm: Fix compilation failure for 64 bit hosts

2011-05-26 Thread Stefan Weil
Am 26.05.2011 13:03, schrieb Peter Maydell: Use the correct _ptr aliases for manipulating the pointer to the fp_status; this fixes a compilation failure on 64 bit hosts. Signed-off-by: Peter Maydellpeter.mayd...@linaro.org --- Apologies for the build breakage. target-arm/translate.c | 18

[Qemu-devel] [PATCH] Buildfix: fix libcacard build with -m32 on 64bit machine

2011-05-26 Thread Stefan Berger
When configuring with --extra-cflags=-m32 on a 64bit machine the following error appears during compilation: make -C libhw64 V=1 TARGET_DIR=libhw64/ all make[1]: Entering directory `/root/tmp/qemu-git/libhw64' make[1]: Leaving directory `/root/tmp/qemu-git/libhw64' make -C libcacard V=1

[Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug

2011-05-26 Thread Peter Maydell
The PPC helper functions booke206_tlbflush and booke_setpid both take an i32 argument, so we need to use TCGv_i32 rather than TCGv, to avoid a compilation failure when compiling in debug mode. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-ppc/translate_init.c |8

Re: [Qemu-devel] [PATCH 01/12] usb-linux: catch NODEV in more places.

2011-05-26 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Factor out disconnect code (called when a device disappears) to a separate function. Add a check for NODEV errno to a few more places to make sure we notice disconnects. Ah, you mean ENODEV! Suddenly the subject makes sense. Fix it up? [...]

Re: [Qemu-devel] [PATCH] Buildfix: fix libcacard build with -m32 on 64bit machine

2011-05-26 Thread Alon Levy
On Thu, May 26, 2011 at 01:56:54PM -0400, Stefan Berger wrote: When configuring with --extra-cflags=-m32 on a 64bit machine the following error appears during compilation: Thanks for the fix. Reviewed-by: Alon Levy al...@redhat.com make -C libhw64 V=1 TARGET_DIR=libhw64/ all make[1]:

Re: [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug

2011-05-26 Thread Stefan Weil
Am 26.05.2011 20:05, schrieb Peter Maydell: The PPC helper functions booke206_tlbflush and booke_setpid both take an i32 argument, so we need to use TCGv_i32 rather than TCGv, to avoid a compilation failure when compiling in debug mode. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] block bug: tray status is not updated (and/or guest ignores it)

2011-05-26 Thread Luiz Capitulino
I'm testing with qemu.git (HEAD aa29141d84d), procedure: 1. Start a VM with: # qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso 2. Then inside the guest run: # eject /dev/sr0 mount /dev/sr0 /mnt Results: Actual: The cdrom is successfully mounted Expected: The

Re: [Qemu-devel] [PATCH] target-ppc: Fix compilation error with --enable-debug

2011-05-26 Thread Peter Maydell
On 26 May 2011 19:28, Stefan Weil w...@mail.berlios.de wrote: Am 26.05.2011 20:05, schrieb Peter Maydell: The PPC helper functions booke206_tlbflush and booke_setpid both take an i32 argument, so we need to use TCGv_i32 rather than TCGv, to avoid a compilation failure when compiling in debug

Re: [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu

2011-05-26 Thread Peter Maydell
On 21 May 2011 09:31, Alexander Graf ag...@suse.de wrote: On 20.05.2011, at 22:30, Stefan Weil wrote: When QEMU was configured with --enable-debug-tcg, compilation fails in spr_write_booke206_mmucsr0() and in spr_write_booke_pid(). Similar changes are also needed in conditional code which is

Re: [Qemu-devel] dynamically linked binaries under sparc-linux-user

2011-05-26 Thread Blue Swirl
On Tue, May 24, 2011 at 10:42 PM, Artyom Tarasenko atar4q...@gmail.com wrote: Should it be possible to use dynamically linked binaries under sparc*-linux-user? Under qemu-system-sparc the Debian 4.08r1 initrd works fine, but: master$ sparc-linux-user/qemu-sparc -strace -L

[Qemu-devel] [PATCH] ppc host, target-ppc: fix building of kvm.c

2011-05-26 Thread Stefan Berger
Below patch fixes the following error when building on a ppc host: cc1: warnings being treated as errors /root/qemu/qemu-git/target-ppc/kvm.c: In function kvm_arch_get_registers: /root/qemu/qemu-git/target-ppc/kvm.c:188: error: unused variable sregs Signed-off-by: Stefan Berger

[Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-26 Thread Stefan Berger
With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of Qemu (on a ppc64 host) when passing these compiler flags via 'configure ... --extra-cflags=-m32'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- configure |9 - 1 file changed, 8

Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env

2011-05-26 Thread Blue Swirl
On Wed, May 25, 2011 at 7:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: This patchset is largely aimed at rolling back the changes from an earlier patchset of mine: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html which made various Neon helper routines use the correct

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-26 Thread Blue Swirl
On Wed, May 25, 2011 at 10:20 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 25 May 2011 19:44, Greg McGary greg.mcg...@gmail.com wrote: I would like to create a QEMU model of an SoC that has several CPU cores having different architectures.  I'm guessing this can be done. It's not

Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-26 Thread malc
On Thu, 26 May 2011, Stefan Berger wrote: With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of Qemu (on a ppc64 host) when passing these compiler flags via 'configure ... --extra-cflags=-m32'. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations.

2011-05-26 Thread Blue Swirl
On Thu, May 26, 2011 at 4:56 PM, Richard Henderson r...@twiddle.net wrote: On 05/26/2011 05:36 AM, Kirill Batuzov wrote:   x = (int32_t)x (int32_t)y; This expression has an implementation-defined behavior accroding to C99 6.5.7 so we decided to emulate signed shifts by hand. Technically,

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-05-26 Thread Blue Swirl
On Thu, May 26, 2011 at 8:25 PM, Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: On Fri, 6 May 2011 18:36:31 +0300 Blue Swirl blauwir...@gmail.com wrote: On Fri, May 6, 2011 at 12:08 PM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl

Re: [Qemu-devel] [PATCH] host-pcc: enable building with -m32 or -m64

2011-05-26 Thread Stefan Berger
On 05/26/2011 03:14 PM, malc wrote: On Thu, 26 May 2011, Stefan Berger wrote: With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of Qemu (on a ppc64 host) when passing these compiler flags via 'configure ... --extra-cflags=-m32'. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env

2011-05-26 Thread Peter Maydell
On 26 May 2011 20:01, Blue Swirl blauwir...@gmail.com wrote: On Wed, May 25, 2011 at 7:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: This obviously still leaves some global CPUState use in op_helper.c, but it's a move in the right direction. Have you seen any measurable changes in

Re: [Qemu-devel] [PATCH 0/6] target-arm: reduce usage of global env

2011-05-26 Thread Peter Maydell
On 25 May 2011 17:00, Peter Maydell peter.mayd...@linaro.org wrote: This patchset is largely aimed at rolling back the changes from an earlier patchset of mine: http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html Some of these patches include the same TCGv_i32/_ptr error fixed

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-26 Thread Lluís
Blue Swirl writes: On Wed, May 25, 2011 at 10:20 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 25 May 2011 19:44, Greg McGary greg.mcg...@gmail.com wrote: I would like to create a QEMU model of an SoC that has several CPU cores having different architectures.  I'm guessing this can

Re: [Qemu-devel] Multi heterogenous CPU archs for SoC sim?

2011-05-26 Thread Andreas Färber
Am 25.05.2011 um 20:44 schrieb Greg McGary: I would like to create a QEMU model of an SoC that has several CPU cores having different architectures. I'm guessing this can be done. In theory, many things are possible. In practice, it's a matter of manhours you're willing to invest. Without

  1   2   >