Am 27.05.2011 01:07, schrieb Josh Durgin:
> This patchset moves the complexity of the rbd format into librbd and
> adds truncation support.
>
> Changes since v5:
> * compare full string, not prefix, with "conf" in 2/4
> * when truncate fails, just return librbd's error
>
> Changes since v4:
>
Am 26.05.2011 23:12, schrieb Luiz Capitulino:
> On Thu, 19 May 2011 14:33:19 +0200
> Kevin Wolf wrote:
>
>> These printfs aren't really debug messages, but clearly indicate a bug if
>> they
>> ever become effective.
>
> Then we have a bug somewhere, starting a VM with:
>
> # qemu -hda disks/t
On 05/26/11 20:20, Markus Armbruster wrote:
Gerd Hoffmann writes:
Factor out disconnect code (called when a device disappears) to a
separate function. Add a check for NODEV errno to a few more places to
make sure we notice disconnects.
Ah, you mean ENODEV! Suddenly the subject makes sense.
Am 26.05.2011 23:48, schrieb Andreas Färber:
Am 26.05.2011 um 00:17 schrieb Alexander Graf:
On 26.05.2011, at 00:10, Peter Maydell wrote:
On 25 May 2011 21:25, Stefan Weil wrote:
Feel free to combine patches if larger patches are preferred.
I'd vote for combining at least 03..12, having n
Hi,
restoring previously created qemu suspend to disk images with
qemu-0.14.1 or 0.14.0 fails
the loop in qemu_loadvm_state() seems to fallsly match an EOF and does
not proceed with the rest of the sections
same problem when migrating from 0.12.5 to 0.14.x
any hints/ideas ?
Regars,
Jason
On Thu, 26 May 2011, Brad wrote:
> On 26/05/11 9:15 AM, malc wrote:
> > On Thu, 26 May 2011, Brad wrote:
> >
> > > - Original message -
> > > > On Wed, 25 May 2011, Brad wrote:
> > > >
> > > > > Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation
> > > > > of PowerPC h
Nigel's error is also topic in bug
https://bugs.launchpad.net/qemu/+bug/726962
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/720787
Title:
Fails to compile on MacOS
Status in QEMU:
New
Bug desc
On 27.05.2011, at 01:33, Nathan Whitehorn wrote:
> On 05/26/11 11:45, agraf wrote:
>> On 26.05.2011, at 18:09, Nathan Whitehorn wrote:
>>
>>> ** Patch added: "mtmstr.diff"
>>>
>>> https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff
>>>
>>> --
>>> You received this b
On 05/26/11 11:45, agraf wrote:
> On 26.05.2011, at 18:09, Nathan Whitehorn wrote:
>
>> ** Patch added: "mtmstr.diff"
>>
>> https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff
>>
>> --
>> You received this bug notification because you are a member of qemu-
>> devel-ml,
On 26/05/11 9:15 AM, malc wrote:
On Thu, 26 May 2011, Brad wrote:
- Original message -
On Wed, 25 May 2011, Brad wrote:
Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation
of PowerPC host support for OpenBSD/powerpc based architectures.
Signed-off-by: Brad Smith
Public bug reported:
For building 32bit Qemu on Mac OS X 10.6.7 , i configure with --extra-
cflags=-m32 --extra-ldflags=-m32. make with gcc-4.2 then crashes with:
GEN qemu-options.def
CCqemu-nbd.o
gcc-4.2: -E, -S, -save-temps and -M options are not allowed with multiple -arch
flags
mak
If scheduling fails, the number of outstanding I/Os must be correct,
or there will be a hang when waiting for everything to be flushed.
Reviewed-by: Christian Brunner
Reported-by: Stefan Hajnoczi
Signed-off-by: Josh Durgin
---
block/rbd.c | 24
1 files changed, 20 in
librbd stacks on top of librados to provide access
to rbd images.
Using librbd simplifies the qemu code, and allows
qemu to use new versions of the rbd format
with few (if any) changes.
Reviewed-by: Christian Brunner
Signed-off-by: Josh Durgin
Signed-off-by: Yehuda Sadeh
---
block/rbd.c
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]]
Each option is used to configure rados, and may be any Ceph option, or "conf".
The "conf" option specifies a Ceph configuration file to read.
This allows rbd volumes from more than one Ceph cluster to be used by
speci
Reviewed-by: Christian Brunner
Signed-off-by: Josh Durgin
---
block/rbd.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index f4da6ab..bdc448a 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -688,6 +688,19 @@ static int64_t qemu_rb
This patchset moves the complexity of the rbd format into librbd and
adds truncation support.
Changes since v5:
* compare full string, not prefix, with "conf" in 2/4
* when truncate fails, just return librbd's error
Changes since v4:
* fixed cosmetic issues pointed out by Christian Brunner
Ch
On 05/26/2011 01:05 AM, Kevin Wolf wrote:
Am 25.05.2011 22:34, schrieb Josh Durgin:
Signed-off-by: Josh Durgin
---
block/rbd.c | 15 +++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index a44d160..b95b1eb 100644
--- a/block/rbd.c
+++
On 05/26/2011 01:13 AM, Kevin Wolf wrote:
Am 25.05.2011 22:34, schrieb Josh Durgin:
The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]]
Each option is used to configure rados, and may be any Ceph option, or "conf".
The "conf" option specifies a Ceph configuration fil
same with 0.14.1 with Mac OS X 10.6.7.
target ppc-darwin-user has the same problem:
CCppc-darwin-user/main.o
cc1: warning: /Users/michael/Downloads/qemu-0.14.1/darwin-user/ppc: No such
file or directory
In file included from /Users/michael/Downloads/qemu-0.14.1/target-ppc/cpu.h:855,
Public bug reported:
0.14.1 crashes on Mac OS X 64bit with some targets (*-bsd-user):
CCi386-bsd-user/cpu-exec.o
/Users/michael/Downloads/qemu-0.14.1/cpu-exec.c: In function
‘cpu_x86_signal_handler’:
/Users/michael/Downloads/qemu-0.14.1/cpu-exec.c:895: error: dereferencing
pointer to inco
Hi everybody
Where can I find the codes for monitor command "log in_asm". I want to know how
QEMU monitor capture the executed instruction in ASM in a simultaneous way
rather than a bunch of Logs.
Thank you very much for your time.
Best wishes
On 05/26/2011 05:24 PM, Andreas Färber wrote:
Am 26.05.2011 um 22:31 schrieb Stefan Berger:
On 05/26/2011 04:20 PM, Andreas Färber wrote:
Am 26.05.2011 um 21:00 schrieb Stefan Berger:
With the below patch I can build either ppc (-m32) or ppc64 (-m64)
versions of Qemu (on a ppc64 host) when p
Am 26.05.2011 um 00:17 schrieb Alexander Graf:
On 26.05.2011, at 00:10, Peter Maydell wrote:
On 25 May 2011 21:25, Stefan Weil wrote:
Feel free to combine patches if larger patches are preferred.
I'd vote for combining at least 03..12, having nine patches all
of which have the same summary
Am 26.05.2011 um 20:28 schrieb Stefan Weil :
> Am 26.05.2011 20:05, schrieb Peter Maydell:
>> The PPC helper functions booke206_tlbflush and booke_setpid both
>> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
>> to avoid a compilation failure when compiling in debug mode.
>
Am 26.05.2011 um 20:50 schrieb Stefan Berger :
> Below patch fixes the following error when building on a ppc host:
>
> cc1: warnings being treated as errors
> /root/qemu/qemu-git/target-ppc/kvm.c: In function kvm_arch_get_registers:
> /root/qemu/qemu-git/target-ppc/kvm.c:188: error: unused vari
Am 26.05.2011 um 22:31 schrieb Stefan Berger:
On 05/26/2011 04:20 PM, Andreas Färber wrote:
Am 26.05.2011 um 21:00 schrieb Stefan Berger:
With the below patch I can build either ppc (-m32) or ppc64 (-m64)
versions of Qemu (on a ppc64 host) when passing these compiler
flags via 'configure .
On 05/26/2011 01:25 PM, Blue Swirl wrote:
>> I don't see the point. The C99 implementation defined escape hatch
>> exists for weird cpus. Which we won't be supporting as a QEMU host.
>
> Maybe not, but a compiler with this property could arrive. For
> example, GCC developers could decide that si
On Thu, 19 May 2011 14:33:19 +0200
Kevin Wolf wrote:
> These printfs aren't really debug messages, but clearly indicate a bug if they
> ever become effective.
Then we have a bug somewhere, starting a VM with:
# qemu -hda disks/test.img -enable-kvm -m 1G -cdrom /dev/sr0
Where the host's CDROM
On Thu, 26 May 2011, Stefan Berger wrote:
> On 05/26/2011 04:20 PM, Andreas F?rber wrote:
> > Am 26.05.2011 um 21:00 schrieb Stefan Berger:
> >
> > > With the below patch I can build either ppc (-m32) or ppc64 (-m64)
> > > versions of Qemu (on a ppc64 host) when passing these compiler flags via
>
On 05/26/2011 04:20 PM, Andreas Färber wrote:
Am 26.05.2011 um 21:00 schrieb Stefan Berger:
With the below patch I can build either ppc (-m32) or ppc64 (-m64)
versions of Qemu (on a ppc64 host) when passing these compiler flags
via 'configure ... --extra-cflags="-m32"'.
You probably meant "w
On Thu, May 26, 2011 at 11:07 PM, Lluís wrote:
> Blue Swirl writes:
>
>> On Wed, May 25, 2011 at 10:20 PM, Peter Maydell
>> wrote:
>>> On 25 May 2011 19:44, Greg McGary wrote:
I would like to create a QEMU model of an SoC that has several
CPU cores having different architectures. I'm
On Thu, May 26, 2011 at 11:10 PM, Richard Henderson wrote:
> On 05/26/2011 12:14 PM, Blue Swirl wrote:
>> On Thu, May 26, 2011 at 4:56 PM, Richard Henderson wrote:
>>> On 05/26/2011 05:36 AM, Kirill Batuzov wrote:
> x = (int32_t)x >> (int32_t)y;
>
This expression has an implementat
Hello,
I'm trying to boot a custom linux kernel in qemu, and I plan to
contribute the necessary work to make it work (this is the first step
I'm taking to add OS support in qemu). I'm totally new to qemu, and I
haven't found enough information to know how to start debugging the
thing, so I thought
On Thu, May 26, 2011 at 1:56 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> Reviewed-by: Christoph Hellwig
> ---
> hw/scsi-bus.c | 6 ++
> trace-events | 6 ++
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index ce
Am 26.05.2011 um 21:00 schrieb Stefan Berger:
With the below patch I can build either ppc (-m32) or ppc64 (-m64)
versions of Qemu (on a ppc64 host) when passing these compiler flags
via 'configure ... --extra-cflags="-m32"'.
You probably meant "without passing"?
Nack. Please don't hardcode
On 05/26/2011 12:14 PM, Blue Swirl wrote:
> On Thu, May 26, 2011 at 4:56 PM, Richard Henderson wrote:
>> On 05/26/2011 05:36 AM, Kirill Batuzov wrote:
x = (int32_t)x >> (int32_t)y;
>>> This expression has an implementation-defined behavior accroding to
>>> C99 6.5.7 so we decided to em
Am 25.05.2011 um 20:44 schrieb Greg McGary:
I would like to create a QEMU model of an SoC that has several CPU
cores having different architectures. I'm guessing this can be done.
In theory, many things are possible. In practice, it's a matter of
manhours you're willing to invest. Without
Blue Swirl writes:
> On Wed, May 25, 2011 at 10:20 PM, Peter Maydell
> wrote:
>> On 25 May 2011 19:44, Greg McGary wrote:
>>> I would like to create a QEMU model of an SoC that has several
>>> CPU cores having different architectures. I'm guessing this
>>> can be done.
>>
>> It's not supported
On 25 May 2011 17:00, Peter Maydell wrote:
> This patchset is largely aimed at rolling back the changes from an
> earlier patchset of mine:
> http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html
Some of these patches include the same TCGv_i32/_ptr error fixed
in http://patchwork.ozl
On 26 May 2011 20:01, Blue Swirl wrote:
> On Wed, May 25, 2011 at 7:00 PM, Peter Maydell
> wrote:
>> This obviously still leaves some global CPUState use in op_helper.c,
>> but it's a move in the right direction.
>
> Have you seen any measurable changes in performance? The discussion
> about the
On 05/26/2011 03:14 PM, malc wrote:
On Thu, 26 May 2011, Stefan Berger wrote:
With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of
Qemu (on a ppc64 host) when passing these compiler flags via 'configure ...
--extra-cflags="-m32"'.
Signed-off-by: Stefan Berger
---
c
On Thu, May 26, 2011 at 8:25 PM, Markus Armbruster wrote:
> Luiz Capitulino writes:
>
>> On Fri, 6 May 2011 18:36:31 +0300
>> Blue Swirl wrote:
>>
>>> On Fri, May 6, 2011 at 12:08 PM, Markus Armbruster
>>> wrote:
>>> > Blue Swirl writes:
>>> >
>>> >> On Mon, May 2, 2011 at 6:57 PM, Luiz Capit
On Thu, May 26, 2011 at 4:56 PM, Richard Henderson wrote:
> On 05/26/2011 05:36 AM, Kirill Batuzov wrote:
>>> x = (int32_t)x >> (int32_t)y;
>>>
>> This expression has an implementation-defined behavior accroding to
>> C99 6.5.7 so we decided to emulate signed shifts by hand.
>
> Technically, yes
On Thu, 26 May 2011, Stefan Berger wrote:
> With the below patch I can build either ppc (-m32) or ppc64 (-m64) versions of
> Qemu (on a ppc64 host) when passing these compiler flags via 'configure ...
> --extra-cflags="-m32"'.
>
> Signed-off-by: Stefan Berger
>
> ---
> configure |9 +++
On Wed, May 25, 2011 at 10:20 PM, Peter Maydell
wrote:
> On 25 May 2011 19:44, Greg McGary wrote:
>> I would like to create a QEMU model of an SoC that has several
>> CPU cores having different architectures. I'm guessing this
>> can be done.
>
> It's not supported currently as far as I'm aware.
On Wed, May 25, 2011 at 7:00 PM, Peter Maydell wrote:
> This patchset is largely aimed at rolling back the changes from an
> earlier patchset of mine:
> http://lists.gnu.org/archive/html/qemu-devel/2011-04/msg00244.html
> which made various Neon helper routines use the correct FP status
> flags by
With the below patch I can build either ppc (-m32) or ppc64 (-m64)
versions of Qemu (on a ppc64 host) when passing these compiler flags via
'configure ... --extra-cflags="-m32"'.
Signed-off-by: Stefan Berger
---
configure |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Inde
Below patch fixes the following error when building on a ppc host:
cc1: warnings being treated as errors
/root/qemu/qemu-git/target-ppc/kvm.c: In function kvm_arch_get_registers:
/root/qemu/qemu-git/target-ppc/kvm.c:188: error: unused variable sregs
Signed-off-by: Stefan Berger
---
target-ppc
On Tue, May 24, 2011 at 10:42 PM, Artyom Tarasenko wrote:
> Should it be possible to use dynamically linked binaries under
> sparc*-linux-user?
> Under qemu-system-sparc the Debian 4.08r1 initrd works fine, but:
>
> master$ sparc-linux-user/qemu-sparc -strace -L
> ../debian-4.08r1-initrd/ ../debia
On 21 May 2011 09:31, Alexander Graf wrote:
> On 20.05.2011, at 22:30, Stefan Weil wrote:
>> When QEMU was configured with --enable-debug-tcg,
>> compilation fails in spr_write_booke206_mmucsr0() and in
>> spr_write_booke_pid(). Similar changes are also needed
>> in conditional code which is norma
On 26 May 2011 19:28, Stefan Weil wrote:
> Am 26.05.2011 20:05, schrieb Peter Maydell:
>> The PPC helper functions booke206_tlbflush and booke_setpid both
>> take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
>> to avoid a compilation failure when compiling in debug mode.
> See ht
I'm testing with qemu.git (HEAD aa29141d84d), procedure:
1. Start a VM with:
# qemu -hda disks/test.img -enable-kvm -m 1G -cdrom Fedora-14-x86_64-DVD.iso
2. Then inside the guest run:
# eject /dev/sr0 && mount /dev/sr0 /mnt
Results:
Actual: The cdrom is successfully mounted
Expected: The
Am 26.05.2011 20:05, schrieb Peter Maydell:
The PPC helper functions booke206_tlbflush and booke_setpid both
take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
to avoid a compilation failure when compiling in debug mode.
Signed-off-by: Peter Maydell
---
target-ppc/translate_init
On Thu, May 26, 2011 at 01:56:54PM -0400, Stefan Berger wrote:
> When configuring with --extra-cflags="-m32" on a 64bit machine the
> following error appears during compilation:
Thanks for the fix.
Reviewed-by: Alon Levy
>
> make -C libhw64 V="1" TARGET_DIR="libhw64/" all
> make[1]: Entering
Gerd Hoffmann writes:
> Factor out disconnect code (called when a device disappears) to a
> separate function. Add a check for NODEV errno to a few more places to
> make sure we notice disconnects.
Ah, you mean ENODEV! Suddenly the subject makes sense. Fix it up?
[...]
The PPC helper functions booke206_tlbflush and booke_setpid both
take an i32 argument, so we need to use TCGv_i32 rather than TCGv,
to avoid a compilation failure when compiling in debug mode.
Signed-off-by: Peter Maydell
---
target-ppc/translate_init.c |8
1 files changed, 4 insert
When configuring with --extra-cflags="-m32" on a 64bit machine the
following error appears during compilation:
make -C libhw64 V="1" TARGET_DIR="libhw64/" all
make[1]: Entering directory `/root/tmp/qemu-git/libhw64'
make[1]: Leaving directory `/root/tmp/qemu-git/libhw64'
make -C libcacard V="1
Am 26.05.2011 13:03, schrieb Peter Maydell:
Use the correct _ptr aliases for manipulating the pointer to
the fp_status; this fixes a compilation failure on 64 bit hosts.
Signed-off-by: Peter Maydell
---
Apologies for the build breakage.
target-arm/translate.c | 18 +-
1 fil
Luiz Capitulino writes:
> On Fri, 6 May 2011 18:36:31 +0300
> Blue Swirl wrote:
>
>> On Fri, May 6, 2011 at 12:08 PM, Markus Armbruster wrote:
>> > Blue Swirl writes:
>> >
>> >> On Mon, May 2, 2011 at 6:57 PM, Luiz Capitulino
>> >> wrote:
>> >>> On Sat, 30 Apr 2011 09:33:15 +0300
>> >>> Blue
Public bug reported:
loading the vmwgfx module of kernel 2.6.39-rc7 in kvm 0.14 results in
[drm:vmw_driver_load] *ERROR* Hardware has no pitchlock
and the kernel module fails.
Consequently vmwgfx is broken, only the vmwlegacy driver works.
** Affects: qemu
Importance: Undecided
S
On 26.05.2011, at 18:09, Nathan Whitehorn wrote:
> ** Patch added: "mtmstr.diff"
>
> https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff
>
> --
> You received this bug notification because you are a member of qemu-
> devel-ml, which is subscribed to QEMU.
> https://
** Summary changed:
- qem-user fails to run rpcgen (i386, x86_64)
+ qemu-user fails to run rpcgen (i386, x86_64)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/788701
Title:
qemu-user fails to run
The 9118 ethernet controller interrupt line is active low unless
the IRQ config register is programmed to set both the IRQ_POL
(polarity: active-high) and IRQ_TYPE (type: push-pull) bits:
implement support for inverting the irq output in other configurations.
This also requires that we support sett
Public bug reported:
Confirmed on qemu current development tree (git commit aa29141). While
trying to run eglibc's rpcgen from native system by qemu-user, I get an
error:
qemu-x86_64 /usr/bin/rpcgen -c /dev/null
fork: Invalid argument
I am running a Debian Wheezy system and rpcgen comes from li
** Attachment added: "rpcgen.tar.bz2"
https://bugs.launchpad.net/bugs/788701/+attachment/2143749/+files/rpcgen.tar.bz2
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/788701
Title:
qem-user fails
** Patch added: "mtmstr.diff"
https://bugs.launchpad.net/bugs/788697/+attachment/2143748/+files/mtmstr.diff
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/788697
Title:
[PowerPC] [patch] mtmsr do
Public bug reported:
The mtmsr instruction on 64-bit PPC does not preserve the high-order
32-bits of the MSR the way it is supposed to, instead setting them to 0,
which takes 64-bit code out of 64-bit mode. There is some code that does
the right thing, but it brokenly only preserves these bits whe
xen: fix interrupt routing
- remove i440FX-xen and i440fx_write_config_xen
we don't need to intercept pci config writes to i440FX anymore;
- introduce PIIX3-xen and piix3_write_config_xen
we do need to intercept pci config write to the PCI-ISA bridge to update
the PCI link routing;
- set the num
On 05/26/2011 05:36 AM, Kirill Batuzov wrote:
>> x = (int32_t)x >> (int32_t)y;
>>
> This expression has an implementation-defined behavior accroding to
> C99 6.5.7 so we decided to emulate signed shifts by hand.
Technically, yes. In practice, no. GCC, ICC, LLVM, MSVC all know
what the user wan
On Thu, 26 May 2011, Brad wrote:
> - Original message -
> > On Wed, 25 May 2011, Brad wrote:
> >
> > > Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation
> > > of PowerPC host support for OpenBSD/powerpc based architectures.
> > >
> > > Signed-off-by: Brad Smith
> >
- Original message -
> On Wed, 25 May 2011, Brad wrote:
>
> > Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation
> > of PowerPC host support for OpenBSD/powerpc based architectures.
> >
> > Signed-off-by: Brad Smith
> >
> > ---
> > cache-utils.c | 11 +--
On Thu, 26 May 2011 09:03:49 +0100
Stefan Hajnoczi wrote:
> On Wed, May 25, 2011 at 10:15 PM, Luiz Capitulino
> wrote:
> > On Wed, 25 May 2011 19:48:00 +0100
> > Stefan Hajnoczi wrote:
> >
> >> The get_events() function polls for new QMP events and then returns. It
> >> can be useful to wait f
On Fri, 20 May 2011, Richard Henderson wrote:
>
> On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
> > +case INDEX_op_sar_i32:
> > +#if TCG_TARGET_REG_BITS == 64
> > +x &= 0x;
> > +y &= 0x;
> > +#endif
> > +r = x & 0x8000;
> > +x &= ~0x80
On Wed, 25 May 2011, Brad wrote:
> Add ppc_init_cacheline_sizes() function for OpenBSD to fix compilation
> of PowerPC host support for OpenBSD/powerpc based architectures.
>
> Signed-off-by: Brad Smith
>
> ---
> cache-utils.c | 11 +--
> 1 files changed, 9 insertions(+), 2 deletions
The return value is unused anyway.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-disk.c|6 ++
hw/scsi-generic.c |7 ++-
hw/scsi.h |2 +-
3 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
inde
If a request is canceled after it has been completed, scsi_cancel_io
would pass a stale aiocb to bdrv_aio_cancel. Avoid this.
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/scsi-generic.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-generic.c b/
Use the correct _ptr aliases for manipulating the pointer to
the fp_status; this fixes a compilation failure on 64 bit hosts.
Signed-off-by: Peter Maydell
---
Apologies for the build breakage.
target-arm/translate.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
di
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 10 +-
hw/lsi53c895a.c | 20 ++--
hw/spapr_vscsi.c | 31 ++-
hw/usb-msd.c | 10 +-
4 files changed, 34 insertions(+), 37 deletions(-)
diff --git a/h
The sg driver currently has a hardcoded limit of commands it
can handle simultaneously. When this limit is reached the
driver will return -EDOM. So we need to capture this to
enable proper return values here.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hell
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 62 ++---
hw/lsi53c895a.c | 60 ++--
hw/scsi-bus.c|4 +-
hw/scsi.h|9 +
hw/spapr_vscsi.c | 101 ++---
From: Hannes Reinecke
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
-
From: Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed
directly from the driver. This requires the handler to do a lookup on
an abstract 'tag' which identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to the driver.
This mirrors the LSI patch that was recently committed.
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/esp.c b/hw/esp.c
index cd6dfc7..7af20a8 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -61,7 +61,
The LUN field in the CDB is a historical relic. Ignore it as reserved,
which is what modern SCSI specifications actually say.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-disk.c|6 +++---
hw/scsi-generic.c |5 ++---
2 files changed, 5 insertions(+), 6 del
... and remove some SCSIDevice variables or fields that now become unused.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
hw/usb-m
Signed-off-by: Paolo Bonzini
Cc: Christoph Hellwig
---
hw/esp.c | 26 ++
hw/lsi53c895a.c | 22 --
hw/scsi-bus.c| 16 +---
hw/scsi.h|1 +
hw/spapr_vscsi.c | 26 ++
hw/usb-msd.c |
From: Hannes Reinecke
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
And we should return the sense code 'INVALID FIELD IN CDB'
in these cases.
Signed-off-by: Hannes Reinecke
Signed-off-by: Paolo Bonzini
Reviewed-by: Chr
Move the common part of scsi-disk.c and scsi-generic.c to the SCSI layer.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/esp.c |2 +-
hw/lsi53c895a.c |2 +-
hw/scsi-bus.c |9 -
hw/scsi-disk.c|1 -
hw/scsi-generic.c |1 -
hw/scsi
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-generic.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index c008e9c..229d24f 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -290,7 +290,6 @@ s
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/esp.c |2 +-
hw/lsi53c895a.c |3 +--
hw/scsi-bus.c|5 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |2 +-
hw/usb-msd.c |2 +-
6 files changed, 10 insertions(+), 5 deletions(-)
diff --git
From: Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of generic error
which is actually a violation of the spec in certain cases.
This patch introduces
This covers the case of canceling a request's I/O and still
completing it.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-bus.c|9 +
hw/scsi.h|1 +
hw/spapr_vscsi.c |8 ++--
3 files changed, 12 insertions(+), 6 deletions(-)
diff --gi
There are more operations than a SCSI bus can handle, besides completing
commands. One example, which this series will introduce, is cleaning up
after a request is cancelled.
More long term, a "SCSI bus" can represent the LUNs attached to a
target; in this case, while all commands will ultimately
This is for when the request must be dropped in the void,
but still memory should be freed. To this end, the devices
register a second callback in SCSIBusOps.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/esp.c | 16 ++--
hw/lsi53c895a.c | 30 +++
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/lsi53c895a.c | 63 +-
1 files changed, 38 insertions(+), 25 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 704e8ad..1ebcde7 100644
--- a/hw/lsi53c895a.c
++
With the next patch, a device may hold SCSIRequest for an indefinite
time. Split a rather big patch, and protect against access errors,
by reference counting them.
There is some ugliness in scsi_send_command implementation due to
the need to unref the request when it fails. This will go away
wit
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-bus.c |6 ++
trace-events |6 ++
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ceeb4ec..0fd85fc 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -4,6 +4
The code for canceling requests upon reset is already the same. Clean
it up and move it to scsi-bus.c.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-bus.c | 12
hw/scsi-disk.c| 18 ++
hw/scsi-generic.c | 18 ++
scsi-generic scsi_read_complete() should not -both- call the client
complete callback with SCSI_REASON_DATA -and- call
scsi_command_complete(). The former will cause the client to queue a
new read or write request, while the later will free the request data
structure, thus causing the new read or
This abstracts calling the command_complete callback, reducing churn
in the following patches.
Signed-off-by: Paolo Bonzini
Reviewed-by: Christoph Hellwig
---
hw/scsi-bus.c | 11 +++
hw/scsi-disk.c|8
hw/scsi-generic.c |6 +++---
hw/scsi.h |1 +
tr
1 - 100 of 136 matches
Mail list logo
