Re: [Qemu-devel] [PATCH V7] Guest stop notification

2012-01-27 Thread Alexander Graf
On 27.01.2012, at 22:49, Jan Kiszka wrote: > On 2012-01-27 21:48, Anthony Liguori wrote: >> On 01/17/2012 12:27 PM, Eric B Munson wrote: >>> Often when a guest is stopped from the qemu console, it will report >>> spurious >>> soft lockup warnings on resume. There are kernel patches being >>> d

Re: [Qemu-devel] ICH6+ chipset emulation

2012-01-27 Thread Isaku Yamahata
On Fri, Jan 27, 2012 at 08:12:59PM +0100, Jan Kiszka wrote: > On 2012-01-27 17:18, Dmitry Zamaruev wrote: > > Hi, > > > > I'm trying to run specific firmware under QEMU, and it is tied > > (hardcoded) to newer chipsets than QEMU currently supports. > > I know there was an effort to emulate Q35, bu

Re: [Qemu-devel] git bisect results

2012-01-27 Thread Jan Kiszka
On 2012-01-26 14:10, Erik Rull wrote: > I assume from these results that the gui_grab is never set to 1 when having > entered the window in windowed mode with the cursor. > > Maybe that's why the sdl_grab_start() is called so often. > > It seems that the condition in sdl_grab_start() > (SDL_WM_

[Qemu-devel] [PATCH] sdl: Do not grab mouse on mode switch while in background

2012-01-27 Thread Jan Kiszka
From: Jan Kiszka When the mouse mode changes to absolute while the SDL windows is not in focus, refrain from grabbing the input. It would steal from some other window. Signed-off-by: Jan Kiszka --- I bet this makes no difference for your problem, Erik, but I came across this while trying to re

Re: [Qemu-devel] [PATCH] arm: add device tree support

2012-01-27 Thread Paul Brook
> If compiled with CONFIG_FDT, allow user to specify a device tree file using > the -dtb argument. If the machine supports it then the dtb will be loaded > into memory and passed to the kernel on boot. Adding annother machine feels wrong. Why does the board specific code need to know about this

[Qemu-devel] [PATCH] arm: add device tree support

2012-01-27 Thread Grant Likely
If compiled with CONFIG_FDT, allow user to specify a device tree file using the -dtb argument. If the machine supports it then the dtb will be loaded into memory and passed to the kernel on boot. This version of the patch only adds support to the arm versatile and versatile express platforms. Ot

Re: [Qemu-devel] [PATCH V7] Guest stop notification

2012-01-27 Thread Jan Kiszka
On 2012-01-27 21:48, Anthony Liguori wrote: > On 01/17/2012 12:27 PM, Eric B Munson wrote: >> Often when a guest is stopped from the qemu console, it will report >> spurious >> soft lockup warnings on resume. There are kernel patches being >> discussed that >> will give the host the ability to tel

Re: [Qemu-devel] Merging kvm-apic into qemu-kvm

2012-01-27 Thread Jan Kiszka
On 2012-01-26 16:49, Avi Kivity wrote: > On 01/26/2012 05:45 PM, Jan Kiszka wrote: >>> I merged the upstream patches one by one, resolving the mechanical and logical conflicts in each step. Was done for that backend/frontend concept, but the adjustments should basically be the same n

Re: [Qemu-devel] [PATCH] Init win32 CRITICAL_SECTION before starting thread; crash when attaching disks

2012-01-27 Thread Stefan Weil
Am 29.12.2011 18:29, schrieb Bogdan Harjoc: Git commit 8d3bc51 crashes on win32 on startup because qemu_tcg_init_vcpu calls: qemu_thread_create(th, qemu_tcg_cpu_thread_fn, ... ... qemu_thread_get_handle(th) which locks th->data->cs, a CRITICAL_SECTION which is initialized only in the thread_f

Re: [Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-27 Thread Stefan Berger
On 01/27/2012 04:10 PM, Stefan Berger wrote: After bisecting the following commit seems to be the culprit for the suspend/resume problems that I am seeing with the current tip (73093354418602a2ff5e43cb91a21b17fbf047d8). commit 59abb06198ee9471e29c970f294eae80c0b39be1 Author: Blue Swirl Date:

[Qemu-devel] suspend/resume not working on tip due to 59abb06

2012-01-27 Thread Stefan Berger
After bisecting the following commit seems to be the culprit for the suspend/resume problems that I am seeing with the current tip (73093354418602a2ff5e43cb91a21b17fbf047d8). commit 59abb06198ee9471e29c970f294eae80c0b39be1 Author: Blue Swirl Date: Sun Jan 22 11:00:44 2012 + Once I rever

[Qemu-devel] [PATCH v2] macio: Improve shallow, half-hearted qdev'ification

2012-01-27 Thread Andreas Färber
From: Anthony Liguori Split macio into two PCIDevices with declarative device ID, macio-oldworld and macio-newworld. Drop is_oldworld state in favor of two separate init functions and deferred creation. Signed-off-by: Andreas Färber Cc: Alexander Graf --- v1 -> v2: * Patch was ignored for QO

Re: [Qemu-devel] [PATCH V7] Guest stop notification

2012-01-27 Thread Anthony Liguori
On 01/17/2012 12:27 PM, Eric B Munson wrote: Often when a guest is stopped from the qemu console, it will report spurious soft lockup warnings on resume. There are kernel patches being discussed that will give the host the ability to tell the guest that it is being stopped and should ignore the

Re: [Qemu-devel] [PATCH V7] Guest stop notification

2012-01-27 Thread Eric B Munson
On Tue, 17 Jan 2012, Eric B Munson wrote: > Often when a guest is stopped from the qemu console, it will report spurious > soft lockup warnings on resume. There are kernel patches being discussed that > will give the host the ability to tell the guest that it is being stopped and > should ignore

Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account

2012-01-27 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: Floppies can be simple or double-sided. However, current code was only taking the common case into account (ie 2 sides). Impact? This repairs single-sided floppies Are single sided floppies broken before the patch? How? Yes. For head

Re: [Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 07:21 PM, Stefano Stabellini wrote: rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-27 Thread Hervé Poussineau
Markus Armbruster a écrit : Hervé Poussineau writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Yes. Impact? CCR is only used to program media rate, wh

Re: [Qemu-devel] ICH6+ chipset emulation

2012-01-27 Thread Jan Kiszka
On 2012-01-27 17:18, Dmitry Zamaruev wrote: > Hi, > > I'm trying to run specific firmware under QEMU, and it is tied > (hardcoded) to newer chipsets than QEMU currently supports. > I know there was an effort to emulate Q35, but it seems not to get mainstream. > Is there any chance to see one of IC

[Qemu-devel] [PATCH] unin_pci: Fix typos in device names

2012-01-27 Thread Andreas Färber
Commit 999e12bbe85c5dcf49bef13bce4f97399c7105f4 (sysbus: apic: ioapic: convert to QEMU Object Model) introduced two typos, one of which broke the mac99 machine. Signed-off-by: Andreas Färber Cc: Anthony Liguori --- hw/unin_pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) dif

Re: [Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator

2012-01-27 Thread Jan Kiszka
On 2012-01-27 19:21, Stefano Stabellini wrote: > PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: > this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. > > Signed-off-by: Stefano Stabellini > --- > hw/pc.c |7 +-- > 1 files changed, 5 insertion

[Qemu-devel] [PATCH 2/2] Improve default machine options usability

2012-01-27 Thread Jan Kiszka
So far we overwrite the machine options completely with defaults if no accel=value is provided. More user friendly is to fill in only unspecified options. The new qemu_opts_set_defaults enables this. Signed-off-by: Jan Kiszka --- vl.c | 17 ++--- 1 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 1/2] qemu-option: Introduce default mechanism

2012-01-27 Thread Jan Kiszka
This adds qemu_opts_set_defaults, an interface provide default values for a QemuOpts set. Default options are parsed from a string and then prepended to the list of existing options, or they serve as the sole QemuOpts set. Signed-off-by: Jan Kiszka --- qemu-option.c | 58 ++

[Qemu-devel] [PATCH v3 2/6] xen: disable rtc_clock

2012-01-27 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index d1fc597..b

[Qemu-devel] [PATCH v3 3/6] xen: introduce an event channel for buffered io event notifications

2012-01-27 Thread Stefano Stabellini
Use the newly introduced HVM_PARAM_BUFIOREQ_EVTCHN to receive notifications for buffered io events. After the first notification is received leave the event channel masked and setup a timer to process the rest of the batch. Once we have completed processing the batch, unmask the event channel and d

[Qemu-devel] [PATCH v3 4/6] timers: the rearm function should be able to handle delta = INT64_MAX

2012-01-27 Thread Stefano Stabellini
Fix win32_rearm_timer and mm_rearm_timer: they should be able to handle INT64_MAX as a delta parameter without overflowing. Also, the next deadline in ms should be calculated rounding down rather than up (see unix_rearm_timer and dynticks_rearm_timer). Finally ChangeTimerQueueTimer takes an unsign

[Qemu-devel] [PATCH v3 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 8c8bbc3..3207e40 1

[Qemu-devel] [PATCH v3 1/6] xen: do not initialize the interval timer emulator

2012-01-27 Thread Stefano Stabellini
PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 85

[Qemu-devel] [PATCH v3 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index a9ba0eb..8c8bbc3 1

[Qemu-devel] [PATCH v3 0/6] prevent Qemu from waking up needlessly

2012-01-27 Thread Stefano Stabellini
Hi all, this small patch series prevents Qemu from waking up needlessly on Xen several times a second in order to check some timers. The first patch stops Qemu from emulating the PIT on Xen, the second patch disables the rtc_clock entirely. The third patch makes use of a new mechanism to receiv

Re: [Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images

2012-01-27 Thread Praveen_Paladugu
I didn't know other patches were already submitted. I picked up the patch from opensuse distribution. I realized no related code is available in upstream project. So I created one based on the head of the git tree. Please feel free to ignore this patch, since other/better patches seem to be ava

[Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-27 Thread Stefan Weil
Up to now, there was no special section for the different host operating systems used with QEMU. scripts/get_maintainer.pl did not show a maintainer for OS specific files and patches. Therefore I added three hosts systems: * POSIX for the majority of host systems which are supported. This incl

[Qemu-devel] ICH6+ chipset emulation

2012-01-27 Thread Dmitry Zamaruev
Hi, I'm trying to run specific firmware under QEMU, and it is tied (hardcoded) to newer chipsets than QEMU currently supports. I know there was an effort to emulate Q35, but it seems not to get mainstream. Is there any chance to see one of ICH6/7/8/9/10 emulated in QEMU ? wbr, Dmitry.

Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev

2012-01-27 Thread Anthony Liguori
On 01/24/2012 01:32 PM, Anthony Liguori wrote: This series makes qdev a proper Object and converts qdev's type inheritance to QOM inheritance. The first half of the series are manual cleanups/refactorings. The second half is mostly scripted conversion, separated out into reviewable and bisectab

Re: [Qemu-devel] [PULL 0/6] Trivial patches for 20 to 27 January 2012

2012-01-27 Thread Anthony Liguori
On 01/27/2012 01:27 AM, Stefan Hajnoczi wrote: The following changes since commit 331636431af32ece373f4b1fb7c3ae9d0615e2a6: vga: compile cirrus_vga in hwlib (2012-01-25 18:32:59 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches Pulled. Th

Re: [Qemu-devel] [PULL 0/5] arm-devs queue (to go after target-arm queue)

2012-01-27 Thread Anthony Liguori
On 01/26/2012 08:02 AM, Peter Maydell wrote: Hi; this is a pullreq for my arm-devs queue, which is basically the Highbank patches. There is a slight sequencing issue here: it would be better if this went in after the target-arm queue which I sent a pullreq for yesterday, because that includes a

Re: [Qemu-devel] [PULL 00/22] Block patches

2012-01-27 Thread Anthony Liguori
On 01/26/2012 10:37 AM, Kevin Wolf wrote: The following changes since commit 331636431af32ece373f4b1fb7c3ae9d0615e2a6: vga: compile cirrus_vga in hwlib (2012-01-25 18:32:59 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regar

[Qemu-devel] [PATCH] Change license from GPLv2 to GPLv2+

2012-01-27 Thread Stefan Weil
This file only contains code from Red Hat, so it can use GPLv2+. Tested with `git blame -M -C net/checksum.c`. Signed-off-by: Stefan Weil --- net/checksum.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/net/checksum.c b/net/checksum.c index 264c23f..9919b2e 100644

Re: [Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images

2012-01-27 Thread Kevin Wolf
Am 27.01.2012 17:19, schrieb Andreas Färber: > Am 27.01.2012 00:46, schrieb praveen_palad...@dell.com: >> According to VMDK specification, while using virtual scsi adapter, the value >> of adapterType has to be set to "lsilogic" or "buslogic". When the user adds >> "scsi" to the list of qemu-img

Re: [Qemu-devel] [PATCH] To support scsi Virtual Adapter while creating VMDK images

2012-01-27 Thread Andreas Färber
Am 27.01.2012 00:46, schrieb praveen_palad...@dell.com: > According to VMDK specification, while using virtual scsi adapter, the value > of adapterType has to be set to "lsilogic" or "buslogic". When the user adds > "scsi" to the list of qemu-img options (Example: qemu-img create -f vmdk foo > -

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Stefan Weil
Am 27.01.2012 13:47, schrieb Anthony Liguori: On 01/27/2012 03:14 AM, Michael Tokarev wrote: The amount of spam our wiki.qemu.org collects, is increasing every day. It was easy several months ago to manually delete these pages once a week to keep wiki spam-free, now they sometimes manage to re-

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 01:14:11PM +0400, Michael Tokarev wrote: > The amount of spam our wiki.qemu.org collects, is > increasing every day. It was easy several months > ago to manually delete these pages once a week to > keep wiki spam-free, now they sometimes manage to > re-create a page while I

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-27 Thread Gerhard Wiesinger
On Thu, 26 Jan 2012, Markus Armbruster wrote: Gerd Hoffmann writes: On 01/26/12 08:45, Markus Armbruster wrote: Gerhard Wiesinger writes: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled (or romfile=no or romfile=none) parameter. With hotplug

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Stefan Weil
Am 27.01.2012 13:47, schrieb Anthony Liguori: On 01/27/2012 03:14 AM, Michael Tokarev wrote: The amount of spam our wiki.qemu.org collects, is increasing every day. It was easy several months ago to manually delete these pages once a week to keep wiki spam-free, now they sometimes manage to re-

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Stefan Weil
Am 27.01.2012 13:47, schrieb Anthony Liguori: On 01/27/2012 03:14 AM, Michael Tokarev wrote: The amount of spam our wiki.qemu.org collects, is increasing every day. It was easy several months ago to manually delete these pages once a week to keep wiki spam-free, now they sometimes manage to re-

Re: [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Stefano Stabellini wrote: > On Fri, 27 Jan 2012, Paolo Bonzini wrote: > > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > > Also delta in qemu_next_alarm_deadline is a 64 bit value so set the > > > default to INT64_MAX instead of INT32_MAX. > > > > > > Signed-off-by: Stef

Re: [Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2)

2012-01-27 Thread Andreas Färber
Am 27.01.2012 16:42, schrieb Anthony Liguori: > On 01/27/2012 09:05 AM, Andreas Färber wrote: >> Am 25.01.2012 22:37, schrieb Anthony Liguori: >>> On 01/25/2012 03:30 PM, Andreas Färber wrote: Am 24.01.2012 20:32, schrieb Anthony Liguori: > This class provides the main building block for Q

Re: [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > There is no reason why the minimum timeout should be 1sec, it could > > easily be 1h and we would save lots of cpu cycles. > > > > Signed-off-by: Stefano Stabellini > > --- > > qemu-timer.c |2 +-

Re: [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
On Fri, 27 Jan 2012, Paolo Bonzini wrote: > On 01/27/2012 01:26 PM, Stefano Stabellini wrote: > > Also delta in qemu_next_alarm_deadline is a 64 bit value so set the > > default to INT64_MAX instead of INT32_MAX. > > > > Signed-off-by: Stefano Stabellini > > --- > > qemu-timer.c | 10 --

Re: [Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2)

2012-01-27 Thread Anthony Liguori
On 01/27/2012 09:05 AM, Andreas Färber wrote: Am 25.01.2012 22:37, schrieb Anthony Liguori: On 01/25/2012 03:30 PM, Andreas Färber wrote: Am 24.01.2012 20:32, schrieb Anthony Liguori: This class provides the main building block for QEMU Object Model and is extensively documented in the header

Re: [Qemu-devel] [PATCH 04/28] qom: add the base Object class (v2)

2012-01-27 Thread Andreas Färber
Am 25.01.2012 22:37, schrieb Anthony Liguori: > On 01/25/2012 03:30 PM, Andreas Färber wrote: >> Am 24.01.2012 20:32, schrieb Anthony Liguori: >>> This class provides the main building block for QEMU Object Model and is >>> extensively documented in the header file. It is largely inspired by >>> G

[Qemu-devel] [PATCH v2] main-loop: Fix SetEvent() on uninitialized handle on win32

2012-01-27 Thread Michael Roth
The __attribute__((constructor)) init_main_loop() automatically get called if qemu-tool.o is linked in. On win32, this leads to a qemu_notify_event() call which attempts to SetEvent() on a HANDLE that won't be initialized until qemu_init_main_loop() is manually called, breaking qemu-tools.o program

Re: [Qemu-devel] Coroutines and ucontext

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 03:39:22PM +0100, Paolo Bonzini wrote: > On 01/27/2012 01:39 PM, Alex Barcelo wrote: > >I have read that one of the reasons for using makecontext is that it > >saves the signal state. But there also exist functions like > >"sigsetjmp" and "siglongjmp" which can be used to ju

Re: [Qemu-devel] [PATCH v2] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Markus Armbruster
Laszlo Ersek writes: > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > exclusion. We shouldn't close the pidfile on success (as introduced by > commit 1bbd1592), because that drops the lock as well [1]: > > "File locks shall be released on first close by the locking proces

Re: [Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 01:26 PM, Stefano Stabellini wrote: There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 01:26 PM, Stefano Stabellini wrote: Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 01:26 PM, Stefano Stabellini wrote: rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

Re: [Qemu-devel] Coroutines and ucontext

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 01:39 PM, Alex Barcelo wrote: I have read that one of the reasons for using makecontext is that it saves the signal state. But there also exist functions like "sigsetjmp" and "siglongjmp" which can be used to jump around the coroutines while preserving signal masks. I have a patch

Re: [Qemu-devel] [PATCH 0/3] linux-user: Implement missing *xattr calls

2012-01-27 Thread Peter Maydell
Ping^2 ? -- PMM On 4 January 2012 11:39, Peter Maydell wrote: > Ping? > > -- PMM > > On 14 December 2011 15:37, Peter Maydell wrote: >> These patches implement the missing *xattr syscalls: >>  listxattr >>  fsetattr, fgetattr, fremovexattr, flistxattr >>  lsetattr, lgetattr, lremovexattr, llist

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 08:15 AM, Jan Kiszka wrote: On 2012-01-27 15:06, Anthony Liguori wrote: On 01/27/2012 07:32 AM, Jan Kiszka wrote: On 2012-01-27 14:07, Anthony Liguori wrote: On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-27 15:06, Anthony Liguori wrote: > On 01/27/2012 07:32 AM, Jan Kiszka wrote: >> On 2012-01-27 14:07, Anthony Liguori wrote: >>> On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset su

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 07:32 AM, Jan Kiszka wrote: On 2012-01-27 14:07, Anthony Liguori wrote: On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 08:03 AM, Andreas Färber wrote: Am 27.01.2012 14:07, schrieb Anthony Liguori: [...] My guess is that a SuperIO chip could be an ISADevice and that we could simply make the PIIX3 has-a SuperIO. Then the ISAPC would have a trivial ISA chipset that has-a SuperIO. That sounds pretty

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Andreas Färber
Am 27.01.2012 14:07, schrieb Anthony Liguori: > [...] My guess is that a SuperIO > chip could be an ISADevice and that we could simply make the PIIX3 has-a > SuperIO. Then the ISAPC would have a trivial ISA chipset that has-a > SuperIO. That sounds pretty much like our construction site for PReP.

[Qemu-devel] [PATCH v2] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Laszlo Ersek
The lockf() call in qemu_create_pidfile() aims at ensuring mutual exclusion. We shouldn't close the pidfile on success (as introduced by commit 1bbd1592), because that drops the lock as well [1]: "File locks shall be released on first close by the locking process of any file descriptor for

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-27 14:07, Anthony Liguori wrote: > On 01/27/2012 02:50 AM, Jan Kiszka wrote: >> On 2012-01-26 20:00, Anthony Liguori wrote: >>> A long time ago, there was a grand plan to merge q35 chipset support. The >>> start >>> of that series was a refactoring of pc.c which split a bunch of the "c

Re: [Qemu-devel] [PATCH v2] optionroms: Silence intermediate file removal

2012-01-27 Thread Andreas Färber
Am 27.01.2012 13:26, schrieb Jan Kiszka: > The build process of optionroms spits out an "rm ..." line. Moreover, it > removes all .o files that can be handy for debugging purposes. > > Disable automatic intermediate removal and only clean up the unneeded > and large .img and .raw files. > > Signe

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-27 Thread Andreas Färber
Am 27.01.2012 13:41, schrieb Anthony Liguori: > On 01/27/2012 03:38 AM, Andreas Färber wrote: >> Am 27.01.2012 07:23, schrieb Stefan Hajnoczi: >>> On Tue, Jan 24, 2012 at 06:17:36PM +0100, Andreas Färber wrote: From: Andreas Färber VMState supports the type bool but qdev instead supp

Re: [Qemu-devel] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Markus Armbruster
Laszlo Ersek writes: > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > exclusion. We shouldn't close the pidfile on success, because that drops > the lock as well [1]: > > "File locks shall be released on first close by the locking process > of any file descriptor for

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Anthony Liguori
On 01/27/2012 02:50 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: A long time ago, there was a grand plan to merge q35 chipset support. The start of that series was a refactoring of pc.c which split a bunch of the "common" functionality into a separate file that could be sha

Re: [Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Anthony Liguori
On 01/27/2012 03:14 AM, Michael Tokarev wrote: The amount of spam our wiki.qemu.org collects, is increasing every day. It was easy several months ago to manually delete these pages once a week to keep wiki spam-free, now they sometimes manage to re-create a page while I delete it! No, it is not

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-27 Thread Anthony Liguori
On 01/27/2012 03:38 AM, Andreas Färber wrote: Am 27.01.2012 07:23, schrieb Stefan Hajnoczi: On Tue, Jan 24, 2012 at 06:17:36PM +0100, Andreas Färber wrote: From: Andreas Färber VMState supports the type bool but qdev instead supports bit, backed by uint32_t. Therefore let's add DEFINE_PROP_BOO

[Qemu-devel] Coroutines and ucontext

2012-01-27 Thread Alex Barcelo
I have read that one of the reasons for using makecontext is that it saves the signal state. But there also exist functions like "sigsetjmp" and "siglongjmp" which can be used to jump around the coroutines while preserving signal masks. I have a patch that uses sigsetjmp and siglongjmp instead of

[Qemu-devel] USB device plugged in => windows XP guest stalls at bootup

2012-01-27 Thread Erik Rull
Hi all, when having a USB device connected to a windows XP guest that is booting (or rebooting) the guest will never finish booting. It hangs before the screen gets resized and the well known Windows is starting dialog appears. If there is no usb device given to the guest, everything is fine, if

[Qemu-devel] [PATCH v2] optionroms: Silence intermediate file removal

2012-01-27 Thread Jan Kiszka
The build process of optionroms spits out an "rm ..." line. Moreover, it removes all .o files that can be handy for debugging purposes. Disable automatic intermediate removal and only clean up the unneeded and large .img and .raw files. Signed-off-by: Jan Kiszka --- Changes in v2: - comment on

[Qemu-devel] [PATCH v2 4/5] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-27 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index cd026c6..648db1d 1

[Qemu-devel] [PATCH v2 3/5] xen: introduce an event channel for buffered io event notifications

2012-01-27 Thread Stefano Stabellini
Use the newly introduced HVM_PARAM_BUFIOREQ_EVTCHN to receive notifications for buffered io events. After the first notification is received leave the event channel masked and setup a timer to process the rest of the batch. Once we have completed processing the batch, unmask the event channel and d

[Qemu-devel] [PATCH v2 5/5] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-27 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 648db1d..b792a32 1

[Qemu-devel] [PATCH v2 2/5] xen: disable rtc_clock

2012-01-27 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini --- xen-all.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index d1fc597..b

[Qemu-devel] [PATCH v2 1/5] xen: do not initialize the interval timer emulator

2012-01-27 Thread Stefano Stabellini
PIT is emulated by the hypervisor so we don't need to emulate it in Qemu: this patch prevents Qemu from waking up needlessly at PIT_FREQ on Xen. Signed-off-by: Stefano Stabellini --- hw/pc.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 85

[Qemu-devel] [PATCH v2 0/5] prevent Qemu from waking up needlessly

2012-01-27 Thread Stefano Stabellini
Hi all, this small patch series prevents Qemu from waking up needlessly on Xen several times a second in order to check some timers. The first patch stops Qemu from emulating the PIT on Xen, the second patch disables the rtc_clock entirely. The third patch makes use of a new mechanism to receive

Re: [Qemu-devel] [PATCH v8] qdev: Add support for property type bool

2012-01-27 Thread Jan Kiszka
On 2012-01-27 13:17, Juan Quintela wrote: >> +{ >> +bool *ptr = qdev_get_prop_ptr(dev, prop); >> +if (strcmp(str, "true") == 0 || strcmp(str, "yes") == 0) { >> +*ptr = true; >> +} else if (strcmp(str, "false") == 0 || strcmp(str, "no") == 0) { >> +*ptr = false; >> +}

Re: [Qemu-devel] [PATCH v8] qdev: Add support for property type bool

2012-01-27 Thread Juan Quintela
Andreas Färber wrote: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add PROP_TYPE_BOOL and qdev_prop_set_bool(). > PropertyInfo qdev_prop_bit = { > -.name = "boolean", > +.name = "bit", my plan for vmstat

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-27 Thread Paolo Bonzini
On 01/24/2012 07:16 PM, Luiz Capitulino wrote: @@ -237,6 +238,17 @@ static bool do_check_io_limits(BlockIOLimit *io_limits) return true; } +static void on_medium_eject(BlockDriverState *bs, int is_ejected) +{ +QObject *data; + +data = qobject_from_jsonf("{ 'device': %s, 'ejected':

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 10:52 AM, Kevin Wolf wrote: > Conclusion: eject returned an error, but a few seconds later the tray opened and > the media wasn't purged. What happened here is that, the_guest_ > opened the tray. The code in this patch would trigger the event, but >

Re: [Qemu-devel] [PATCH v8] qdev: Add support for property type bool

2012-01-27 Thread Andreas Färber
Am 26.01.2012 16:54, schrieb Andreas Färber: > From: Andreas Färber > > VMState supports the type bool but qdev instead supports bit, backed by > uint32_t. Therefore let's add PROP_TYPE_BOOL and qdev_prop_set_bool(). > > With non-programmers in mind, instead of universal true/false provide > two

Re: [Qemu-devel] [Android-virt] [PATCH 00/12] Add support for Cortex-A15 and vexpress-a15

2012-01-27 Thread Marc Zyngier
On 17/01/12 19:08, Peter Maydell wrote: > On 15 January 2012 22:56, Christoffer Dall wrote: >> On Fri, Jan 13, 2012 at 3:57 PM, Peter Maydell >> wrote: >>> PPS: these patches are against qemu-master so for kvm you'd need >>> to (a) rebase them on qemu-linaro (b) put the kvm patches on top >>> of

Re: [Qemu-devel] [Qemu-trivial] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Daniel P. Berrange
On Fri, Jan 27, 2012 at 06:36:39AM +, Stefan Hajnoczi wrote: > On Thu, Jan 26, 2012 at 10:36:41PM +0100, Laszlo Ersek wrote: > > The lockf() call in qemu_create_pidfile() aims at ensuring mutual > > exclusion. We shouldn't close the pidfile on success, because that drops > > the lock as well [1

Re: [Qemu-devel] [PATCH] optionroms: Silence intermediate file removal

2012-01-27 Thread Andreas Färber
Am 23.01.2012 19:34, schrieb Jan Kiszka: > The build process of optionroms spits out an "rm ..." line. Moreover, it > removes all .o files that can be handy for debugging purposes. > > Disable automatic intermediate removal and only clean up the unneeded > and large .img and .raw files. > > Signe

Re: [Qemu-devel] [PATCH 2/6] qdev-property: Make bit property parsing stricter

2012-01-27 Thread Andreas Färber
Am 27.01.2012 08:27, schrieb Stefan Hajnoczi: > From: Jan Kiszka > > By using strncasecmp, we allow for arbitrary characters after the > "on"/"off" string. Fix this by switching to strcasecmp. > > Reviewed-by: Andreas Färber > Reviewed-by: Markus Armbruster > Signed-off-by: Jan Kiszka > Signe

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-27 Thread Kevin Wolf
Am 26.01.2012 18:57, schrieb Luiz Capitulino: > On Wed, 25 Jan 2012 10:42:04 -0200 > Luiz Capitulino wrote: > >> On Wed, 25 Jan 2012 09:41:20 +0100 >> Kevin Wolf wrote: >> >>> Am 24.01.2012 21:03, schrieb Eric Blake: On 01/24/2012 11:16 AM, Luiz Capitulino wrote: > Libvirt wants to be n

Re: [Qemu-devel] [PATCH v6] qdev: Add support for property type bool

2012-01-27 Thread Andreas Färber
Am 27.01.2012 07:23, schrieb Stefan Hajnoczi: > On Tue, Jan 24, 2012 at 06:17:36PM +0100, Andreas Färber wrote: >> From: Andreas Färber >> >> VMState supports the type bool but qdev instead supports bit, backed by >> uint32_t. Therefore let's add DEFINE_PROP_BOOL() and qdev_prop_set_bool(). >> >>

[Qemu-devel] cry for help: wiki.qemu.org spam

2012-01-27 Thread Michael Tokarev
The amount of spam our wiki.qemu.org collects, is increasing every day. It was easy several months ago to manually delete these pages once a week to keep wiki spam-free, now they sometimes manage to re-create a page while I delete it! No, it is not counted in 1000s per day - not yet anyway. But

Re: [Qemu-devel] [PATCH v3 7/9] fdc: check if media rate is correct before doing any transfer

2012-01-27 Thread Markus Armbruster
Hervé Poussineau writes: > The programmed rate has to be the same as the required rate for the > floppy format ; if that's not the case, the transfer should abort. > > Revalidate floppy after migration, so media_rate field doesn't have > to be saved/restored. I'm not at all sure that's a good id

Re: [Qemu-devel] [PATCH v3 9/9] fdc: DIR (Digital Input Register) should return status of current drive...

2012-01-27 Thread Markus Armbruster
Impact? What exactly is broken and fixed?

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-27 Thread Markus Armbruster
Hervé Poussineau writes: > DIR and CCR registers share the same address ; DIR is read-only > while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that correct? Impact?

Re: [Qemu-devel] [Android-virt] [PATCH 02/12] arm: make the number of GIC interrupts configurable

2012-01-27 Thread Peter Maydell
On 27 January 2012 00:33, Rusty Russell wrote: > Peter Maydell wrote: >> Anyway, if we would otherwise die horribly later on we should >> catch these cases, but it would be good to have at least a comment >> saying that these are implementation limitations rather than >> architectural ones. > > Go

Re: [Qemu-devel] [Qemu-trivial] [PATCH] keep the PID file locked for the lifetime of the process

2012-01-27 Thread Laszlo Ersek
On 01/27/12 07:36, Stefan Hajnoczi wrote: On Thu, Jan 26, 2012 at 10:36:41PM +0100, Laszlo Ersek wrote: The lockf() call in qemu_create_pidfile() aims at ensuring mutual exclusion. We shouldn't close the pidfile on success, because that drops the lock as well [1]: "File locks shall be rele

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

2012-01-27 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: > A long time ago, there was a grand plan to merge q35 chipset support. The > start > of that series was a refactoring of pc.c which split a bunch of the "common" > functionality into a separate file that could be shared by the two. > > But q35 never g

Re: [Qemu-devel] [Qemu-trivial] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command

2012-01-27 Thread Paolo Bonzini
On 01/27/2012 06:59 AM, Stefan Hajnoczi wrote: > Signed-off-by: Thomas Higdon > --- Kevin: Will you take this through your block/scsi tree? Yes, he did already. Paolo

Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account

2012-01-27 Thread Markus Armbruster
Hervé Poussineau writes: > Floppies can be simple or double-sided. However, current code > was only taking the common case into account (ie 2 sides). Impact? Are single sided floppies broken before the patch? How?

  1   2   >