[Qemu-devel] Is cache=writeback safe yet?

2012-02-20 Thread Virtbie
Dear qemuers, thanks for your exellent software. I would like to use cache=writeback, but I still can't understand if this is safe or not in case of power loss. In particular with virtio-blk on bare LVM device. Qemu manpage still says cache=writeback isn't safe, but I seem to find some discor

Re: [Qemu-devel] [PATCH 07/12] exec: add missing breaks to the watch_mem_write

2012-02-20 Thread Meador Inge
On 02/18/2012 11:11 AM, Max Filippov wrote: > Signed-off-by: Max Filippov Reviewed-by: Meador Inge > --- > exec.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/exec.c b/exec.c > index b81677a..f105b43 100644 > --- a/exec.c > +++ b/exec.c > @@ -3289,9

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 07:59 AM, Gerd Hoffmann wrote: On 02/20/12 14:45, Anthony Liguori wrote: On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this

Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

2012-02-20 Thread Meador Inge
On 02/18/2012 10:33 AM, Andreas Färber wrote: > Am 17.02.2012 18:06, schrieb Andreas Färber: >> Am 17.02.2012 18:03, schrieb Meador Inge: >>> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f >>> where 'watch_mem_write' was modified to fall-through to 'abort' on >>> every inp

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Anthony Liguori
On 02/20/2012 06:47 AM, Kevin Wolf wrote: Am 20.02.2012 13:17, schrieb Kevin Wolf: Am 20.02.2012 00:44, schrieb Anthony Liguori: Hi, I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 08:06 AM, Stefano Stabellini wrote: On Mon, 20 Feb 2012, Anthony Liguori wrote: On 02/19/2012 08:52 PM, Brad Smith wrote: On 19/02/12 9:44 PM, Anthony Liguori wrote: On 02/19/2012 08:24 PM, Brad Smith wrote: On 19/02/12 8:10 PM, Anthony Liguori wrote: If not, it will be nice to

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Anthony Liguori
On 02/20/2012 06:17 AM, Kevin Wolf wrote: Am 20.02.2012 00:44, schrieb Anthony Liguori: I'm not attempting to make a pretty desktop virtualization UI. Maybe we'll go there eventually but that's not what this series is about. This is just attempting to use a richer toolkit such that we can enab

Re: [Qemu-devel] [PATCH 6/6] gtk: make default UI

2012-02-20 Thread Stefano Stabellini
On Mon, 20 Feb 2012, Anthony Liguori wrote: > On 02/19/2012 08:52 PM, Brad Smith wrote: > > On 19/02/12 9:44 PM, Anthony Liguori wrote: > >> On 02/19/2012 08:24 PM, Brad Smith wrote: > >>> On 19/02/12 8:10 PM, Anthony Liguori wrote: > > If not, it will be nice to keep > > SDL because GTK hu

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Gerd Hoffmann
On 02/20/12 14:45, Anthony Liguori wrote: > On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: >> On 02/20/12 00:44, Anthony Liguori wrote: >>> We want to expose VCs using a VteTerminal widget. We need access to >>> provide our >>> own CharDriverState in order to do this. >> >> /me wonders why you touch

Re: [Qemu-devel] [PATCH 5/6] gtk: add support for screen scaling and full screen

2012-02-20 Thread Anthony Liguori
On 02/20/2012 01:41 AM, Paolo Bonzini wrote: On 02/20/2012 12:45 AM, Anthony Liguori wrote: +static void gd_menu_zoom_in(GtkMenuItem *item, void *opaque) +{ +GtkDisplayState *s = opaque; + +s->scale_x *= 1.25; +s->scale_y *= 1.25; + +gd_resize(s->ds); +} + +static void gd_menu_zo

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Anthony Liguori
On 02/20/2012 03:17 AM, Gerd Hoffmann wrote: On 02/20/12 00:44, Anthony Liguori wrote: We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. /me wonders why you touch vc's at all for this. Doesn't it make alot more sense to j

[Qemu-devel] [PATCH v3] Add tab-completion for device_add.

2012-02-20 Thread Andrzej Zaborowski
From: Andrzej Zaborowski Signed-off-by: Andrzej Zaborowski --- v2: pass only char *prop_name as qdev_driver_prop_foreach_func parameter, Anthony noted Property was soon going away. v3: use QOM. --- monitor.c | 58 ++ 1 files changed, 5

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Gerd Hoffmann
Hi, > I'll send a series that works with vnc+spice and sdl+spice (didn't test > sdl+vnc+spice), and screendumps at the same time. > >> >> Setting the QEMU_ALLOCATED_FLAG flag sounds hackish too. QEMU_ALLOCATED_FLAG is just a flag which is used by the defaultallocator_free_displaysurface functi

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
Hi, >> (2) Async monitor command. Keeps interface and works nicely. A bunch >> of QAPI bits tickled into master meanwhile, so we could look at >> this again. Luiz? What is the status here? > > I was going to look for QAPI bits after this series (i.e. (2)). Doing > (3) is also pos

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Gerd Hoffmann
Hi, >>> @@ -151,6 +171,7 @@ void qxl_render_update(PCIQXLDevice *qxl) >> >> dpy_update() call here. Calling that one isn't safe without grabbing >> the qemu lock. > > About dpy_update, discovered it the hard way. You mean I need the lock > for dpy_update or also before? Any qemu code should b

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 13:17, schrieb Kevin Wolf: > Am 20.02.2012 00:44, schrieb Anthony Liguori: >> Hi, >> >> I realize UIs are the third rail of QEMU development, but over the years I've >> gotten a lot of feedback from users about our UI. I think everyone struggles >> with the SDL interface and its lack

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Gerd Hoffmann
Hi, >> Which spice server version added async support? IIRC this is 0.8.2? >> >> I'm tempted to raise the minimal supported version to 0.8.latest and zap >> a bunch of #ifdefs from the code. What do you think? >> > > How does that work? raise the minimal supported version in configure? Yes.

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:41:09PM +0100, Gerd Hoffmann wrote: > On 02/19/12 22:28, Alon Levy wrote: > > Add an implementation of the DisplayAllocator callbacks for qxl. Uses > > the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 > > bits per pixel line convertion. Since free/

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:32:44PM +0100, Gerd Hoffmann wrote: > On 02/19/12 22:28, Alon Levy wrote: > > This changes the behavior of the monitor command. After the previous > > patch, there is no longer an option of deadlock with virt-manager, but > > ppm_save is called too early, before the updat

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread Peter Maydell
On 20 February 2012 12:12, andrzej zaborowski wrote: > On 17 February 2012 19:21, Peter Maydell wrote: >> Does anybody know what the distinction between these two constants >> is supposed to be? They were introduced by commit 29885477 >> back in 2008... (Also, why "INTR" and "GC"?) > > Apparently

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 12:10:38PM +0100, Gerd Hoffmann wrote: > Hi, > > > > +void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie) > > +{ > > This is called from spice server thread context, correct? > > > -for (i = 0; i < ARRAY_SIZE(dirty); i++) { > > +for (i = 0; i

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 11:56:58AM +0100, Gerd Hoffmann wrote: > > +if (cookie == NULL) { > > +cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, > > +QXL_IO_UPDATE_AREA_ASYNC, > > +0); > > +} > > Automagi

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
On 20 February 2012 13:12, andrzej zaborowski wrote: > I have neither of the TRMs at hand but I downloaded the TRM for > omap35x which features i2c module 3.1 and it looks like the current Sorry, the revision is not given in the TRM, 3.1 is an example. Cheers

Re: [Qemu-devel] [PATCH 0/6] Add GTK UI to enable basic accessibility

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 00:44, schrieb Anthony Liguori: > Hi, > > I realize UIs are the third rail of QEMU development, but over the years I've > gotten a lot of feedback from users about our UI. I think everyone struggles > with the SDL interface and its lack of discoverability but it's worse than I > thi

Re: [Qemu-devel] omap_i2c: distinction between OMAP2_INTR_REV and OMAP2_GC_REV?

2012-02-20 Thread andrzej zaborowski
Hi, On 17 February 2012 19:21, Peter Maydell wrote: > I'm looking at cleaning up some more omap3 patches, and have > been working on the omap_i2c related ones. At the moment in > omap_i2c.c there are the following #defines for the I2C module > revision (as exposed via the revision register): > >

[Qemu-devel] [PATCH 2/2] build: replace librt check function

2012-02-20 Thread Roger Pau Monne
Replace clock_gettime with timer_gettime, since at least under uclibc 0.9.33 the clock_getttime function can be used without linking against librt (although the manual page states the opposite). Signed-off-by: Roger Pau Monne --- configure |3 ++- 1 files changed, 2 insertions(+), 1 deletion

[Qemu-devel] [PATCH 1/2] build: check if libm is needed in configure

2012-02-20 Thread Roger Pau Monne
Remove the hardcoded use of libm and instead rely on configure to check for it. It is needed at least for qemu-ga and qemu-system. Signed-off-by: Roger Pau Monne --- Makefile.target |4 configure | 14 ++ 2 files changed, 14 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] build: add needed missing libraries libm and librt

2012-02-20 Thread Roger Pau Monné
2012/2/18 Andreas Färber : > Am 18.02.2012 09:24, schrieb Blue Swirl: >> On Wed, Feb 8, 2012 at 17:06, Roger Pau Monne >> wrote: >>> libm is used in cutils.c, but the library was not specified >>> when linking some binaries, throwing the following error: >>> >>> cutils.o: In function `strtosz_suf

Re: [Qemu-devel] [RFC 7/7] qxl: add allocator

2012-02-20 Thread Gerd Hoffmann
On 02/19/12 22:28, Alon Levy wrote: > Add an implementation of the DisplayAllocator callbacks for qxl. Uses > the QEMU_ALLOCATED_FLAG to ensure vga/vga_draw_graphic does the 24 to 32 > bits per pixel line convertion. Since free/resize/create are defined in > qxl.c, it is easy to ensure consistent u

[Qemu-devel] [Bug 924943] Re: usb-host devices given by command line are routed incomplete to the guest

2012-02-20 Thread Erik Rull
Still present with the latest patch queue and update from the GIT master. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/924943 Title: usb-host devices given by command line are routed incomplete to

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Paolo Bonzini
On 02/20/2012 12:13 PM, Alexander Barabash wrote: > I would only suggest that the documentation of object_property_add_child() > be amended to reflect the fact that the child object may be retrieved using > object_property_get_link(). Sure, feel free to post a patch for that or to add a synonym wi

Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback

2012-02-20 Thread Gerd Hoffmann
On 02/19/12 22:28, Alon Levy wrote: > This changes the behavior of the monitor command. After the previous > patch, there is no longer an option of deadlock with virt-manager, but > ppm_save is called too early, before the update has completed. With this > patch it is called at the correct moment,

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Anthony PERARD
On Mon, Feb 20, 2012 at 10:51, Tobias Geiger wrote: > i wanted to test these patches against > http://xenbits.xensource.com/xen-unstable.hg but it seems to check out an > outdated version of upstream-qemu, even with "QEMU=upstream". > > Where can i check out the qemu-upstream version to which thes

Re: [Qemu-devel] [PATCH v2] Revised: Add object_property_get_child().

2012-02-20 Thread Alexander Barabash
On 02/19/2012 06:04 PM, Alexander Barabash wrote: Add object_property_get_child(). Please disregard this patch. object_property_get_link() works for this purpose.

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Alexander Barabash
On 02/20/2012 11:11 AM, Paolo Bonzini wrote: On 02/19/2012 01:36 PM, Alexander Barabash wrote: The proposed object_property_get_child() may return either the direct child with the specified name in the composition tree, or the value of the link with the specified name, as object_property_get_li

Re: [Qemu-devel] [RFC 4/7] qxl: make qxl_render_update async

2012-02-20 Thread Gerd Hoffmann
Hi, > +void qxl_render_update_area_done(PCIQXLDevice *qxl, QXLCookie *cookie) > +{ This is called from spice server thread context, correct? > -for (i = 0; i < ARRAY_SIZE(dirty); i++) { > +for (i = 0; i < ARRAY_SIZE(data->dirty); i++) { > if (qemu_spice_rect_is_empty(dirty+i)

Re: [Qemu-devel] [Xen-devel] [PATCH V7 00/11] Xen PCI Passthrough

2012-02-20 Thread Tobias Geiger
Hi! i wanted to test these patches against http://xenbits.xensource.com/xen-unstable.hg but it seems to check out an outdated version of upstream-qemu, even with "QEMU=upstream". Where can i check out the qemu-upstream version to which these patches apply? Thanks and Greetings Tobias Am Frei

Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie

2012-02-20 Thread Gerd Hoffmann
> +if (cookie == NULL) { > +cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, > +QXL_IO_UPDATE_AREA_ASYNC, > +0); > +} Automagic cookie creation is still there. I think when cookie is NULL you should just

Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io

2012-02-20 Thread Alexander Graf
On 20.02.2012, at 04:01, David Gibson wrote: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. >

Re: [Qemu-devel] [PATCH] usb-hid: activate usb tablet / mouse after migration.

2012-02-20 Thread Peter Lieven
On 21.10.2011 11:22, Gerd Hoffmann wrote: Hi, Original: * Mouse #1: QEMU HID Tablet (absolute) Mouse #0: QEMU PS/2 Mouse Start from the snapshot: * Mouse #0: QEMU PS/2 Mouse Mouse #1: QEMU HID Tablet (absolute) The active mouse device is not be saved into the snapshot. That shouldn'

[Qemu-devel] KVM call agenda for Tuesday 21th

2012-02-20 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] [PATCH] block: fix block I/O throtting with IDE

2012-02-20 Thread Chris Webb
Zhi Yong Wu writes: > On Mon, Feb 20, 2012 at 5:18 AM, Chris Webb wrote: > > I would indeed quite like to backport this to qemu 1.0! Am I right in > > thinking the sanest way to do this is to apply 922453bca6a9 to bring all the > > relevant qemu_aio_flush() calls through the same place before I

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
On Mon, Feb 20, 2012 at 5:39 PM, Kevin Wolf wrote: > Am 20.02.2012 10:29, schrieb Zhi Yong Wu: >> On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf wrote: >>> Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: From: Zhi Yong Wu If one guest has multiple disks with enabling I/O throttlin

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 10:29, schrieb Zhi Yong Wu: > On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf wrote: >> Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: >>> From: Zhi Yong Wu >>> >>> If one guest has multiple disks with enabling I/O throttling function >>> separately, when draining activities are do

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
For example, one disk of one guest is hot plugout, its other disks should not be affected if those disks also enable I/O throttling. But if one whole VM need to be stored, all throttled requests for all disks need to be drained. On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf wrote: > Am 20.02.2012 0

Re: [Qemu-devel] [PATCH][v12] megasas: LSI Megaraid SAS HBA emulation

2012-02-20 Thread Hannes Reinecke
On 02/18/2012 01:38 PM, Gerhard Wiesinger wrote: > Hello Hannes, > > Patch applies well to qemu tree and with a one line modification to > qemu-kvm. > > My testcase was to install Fedora 16 x64 on qemu-kvm. Unfortunatly > it was NOT successful. > > 1.) Strange thing is that udevd got into timeou

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Zhi Yong Wu
On Mon, Feb 20, 2012 at 5:26 PM, Kevin Wolf wrote: > Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: >> From: Zhi Yong Wu >> >> If one guest has multiple disks with enabling I/O throttling function >> separately, when draining activities are done, some requests maybe are in >> the throttled

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-20 Thread Kevin Wolf
Am 20.02.2012 05:50, schrieb zwu.ker...@gmail.com: > From: Zhi Yong Wu > > If one guest has multiple disks with enabling I/O throttling function > separately, when draining activities are done, some requests maybe are in the > throttled queue; So we need to restart them at first. > > Moreover,

Re: [Qemu-devel] [PATCH 1/6] console: allow VCs to be overridden by UI

2012-02-20 Thread Gerd Hoffmann
On 02/20/12 00:44, Anthony Liguori wrote: > We want to expose VCs using a VteTerminal widget. We need access to provide > our > own CharDriverState in order to do this. /me wonders why you touch vc's at all for this. Doesn't it make alot more sense to just have a -chardev vte (which then opens

Re: [Qemu-devel] [PATCH] qom: Fix object_initialize_with_type() assertion

2012-02-20 Thread Paolo Bonzini
On 02/20/2012 12:49 AM, Andreas Färber wrote: > Assert the object is at least sizeof(Object), not sizeof(ObjectClass). > > Signed-off-by: Andreas Färber > --- > qom/object.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qom/object.c b/qom/object.c > index b1ead1

Re: [Qemu-devel] [PATCH] Add object_property_get_child().

2012-02-20 Thread Paolo Bonzini
On 02/19/2012 01:36 PM, Alexander Barabash wrote: > > > The proposed object_property_get_child() may return either > the direct child with the specified name in the composition tree, > or the value of the link with the specified name, as > object_property_get_link() indeed does. Have you actuall

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: Remove unneeded include statements

2012-02-20 Thread Stefan Hajnoczi
On Sat, Feb 11, 2012 at 10:07:55AM +0100, Stefan Weil wrote: > The standard include files are already included in qemu-common.h. > > malloc.h and alloca.h were needed for alloca() which was removed > from TCG code some years ago when switching from dyngen to TCG > (see commit 49516bc0d622112caac9d

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu

2012-02-20 Thread Michael S. Tsirkin
On Wed, Dec 14, 2011 at 08:43:17AM -0500, Stefan Berger wrote: > This patch adds the main code of the TPM frontend driver, the TPM TIS > interface, to Qemu. The code is largely based on the previous implementation > for Xen but has been significantly extended to meet the standard's > requirements,

Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event

2012-02-20 Thread Markus Armbruster
Luiz Capitulino writes: > The event name changed, which caused the subject to change too, hope this > won't cause confusion. > > v3 > > o Rename the event to DEVICE_TRAY_MOVED > o Rename the 'ejected' event data to 'tray-open' > o Only call bdrv_eject() if the tray state changed > o Drop ide_tray

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-20 Thread Markus Armbruster
Luiz Capitulino writes: > It's emitted whenever the tray is moved by the guest or by HMP/QMP > commands. > > Signed-off-by: Luiz Capitulino > --- > QMP/qmp-events.txt | 18 ++ > block.c| 24 > monitor.c |3 +++ > monitor.h

Re: [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load()

2012-02-20 Thread Markus Armbruster
Luiz Capitulino writes: > This is used to sync the physical tray state after migration when > using CD-ROM passthrough. However, migrating when using passthrough > is broken anyway and shouldn't be supported... > > So, drop this function as it causes a problem with the DEVICE_TRAY_MOVED > event,

Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Alon Levy
On Mon, Feb 20, 2012 at 09:00:14AM +0100, Gerd Hoffmann wrote: > Hi, > > > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the > > spice-protocol patch? > > Yes. > > >> -if (qxl->vram_size < 4096) { > >> -qxl->vram_size = 4096; > >> +if (qxl->vram_size < qxl->vram32_

Re: [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change

2012-02-20 Thread Markus Armbruster
Luiz Capitulino writes: > It's not needed. Besides we can then assume that bdrv_eject() is > only called when there's a tray state change, which is useful to > the DEVICE_TRAY_MOVED event (going to be added in a future > commit). We can assume that only after the next patch "ide: drop ide_tray_s

Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl

2012-02-20 Thread Gerd Hoffmann
Hi, > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the > spice-protocol patch? Yes. >> -if (qxl->vram_size < 4096) { >> -qxl->vram_size = 4096; >> +if (qxl->vram_size < qxl->vram32_size) { >> +qxl->vram_size = qxl->vram32_size; > > Am I reading correctly

<    1   2