Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 22:42, Luiz Capitulino ha scritto: > On Tue, 17 Apr 2012 22:26:55 +0200 > Paolo Bonzini wrote: > >> Il 17/04/2012 21:36, Luiz Capitulino ha scritto: >>> +switch(qobject_type(obj)) { >>> +case QTYPE_QSTRING: >>> +qstring_append(arglist, >>> +

Re: [Qemu-devel] [PATCH v6 1/5] sockets: change inet_connect() to support nonblock socket

2012-04-17 Thread Orit Wasserman
On 04/17/2012 05:54 PM, Amos Kong wrote: > Add a bool argument to inet_connect() to assign if set socket > to block/nonblock, and delete original argument 'socktype' > that is unused. > > Retry to connect when following errors are got: > -EINTR > -EWOULDBLOCK (win32) > Connect's successful for

Re: [Qemu-devel] [PATCH v6 2/5] qerror: add five qerror strings

2012-04-17 Thread Orit Wasserman
On 04/17/2012 05:54 PM, Amos Kong wrote: > Add five new qerror strings, they are about socket: > QERR_SOCKET_CONNECT_IN_PROGRESS > QERR_SOCKET_CONNECT_FAILED > QERR_SOCKET_LISTEN_FAILED > QERR_SOCKET_BIND_FAILED > QERR_SOCKET_CREATE_FAILED > > Signed-off-by: Amos Kong > --- > qerror.c

[Qemu-devel] [Bug 984516] Re: should use sdl-config for static build not pkg-config

2012-04-17 Thread Stefan Weil
pkg-config supports --static, and QEMU uses it. Please try whether pkg-config --libs --static sdl gives the correct flags with your distribution. If not, that distribution is buggy. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

[Qemu-devel] [Bug 984476] Re: "segmentaion" error when DMAing

2012-04-17 Thread Stefan Weil
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/984476 Title: "segmentaion" error when DMAing Status in QEMU: Confirmed Bug description: When

[Qemu-devel] [Bug 984476] Re: "segmentaion" error when DMAing

2012-04-17 Thread Stefan Weil
Was it "TCP segmentaion Error"? Then it is still there. Thanks for reporting. It will be fixed in latest QEMU. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/984476 Title: "segmentaion" error when

Re: [Qemu-devel] [PATCH 0/7 V6] VMXNET3 paravirtual NIC device implementation

2012-04-17 Thread Gerhard Wiesinger
As already pretested this patch I got from Dmitry now I successfully tested it on Fedora 16 and Knoppix 6.7 (retested again successfully). netio performance on localhost (ok): Packet size 1k bytes: 33645 KByte/s Tx, 25279 KByte/s Rx. Packet size 2k bytes: 45884 KByte/s Tx, 24854 KByte/s Rx

Re: [Qemu-devel] [PATCH 4/7 V6] Header with various utility functions shared by VMWARE SCSI and network devices

2012-04-17 Thread Michael S. Tsirkin
On Tue, Apr 17, 2012 at 03:32:38PM +0300, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > Signed-off-by: Dmitry Fleytman > Signed-off-by: Yan Vugenfirer I can easily see how different vmware devices would share some code. However: > --- > hw/vmware_utils.h | 126 > ++

[Qemu-devel] [Bug 984476] Re: "segmentaion" error when DMAing

2012-04-17 Thread Rob
Yeah it was. Sorry, should have specified. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/984476 Title: "segmentaion" error when DMAing Status in QEMU: Confirmed Bug description: When

Re: [Qemu-devel] [PATCH 6/7 V6] Packet abstraction used by VMWARE network devices

2012-04-17 Thread Michael S. Tsirkin
On Tue, Apr 17, 2012 at 03:32:40PM +0300, Dmitry Fleytman wrote: > +/*= > + > *= > + * > + *TX INTERFACE > + * > + >

[Qemu-devel] [PATCH] e1000: Fix spelling (segmentaion -> segmentation) in debug output

2012-04-17 Thread Stefan Weil
This was reported by https://bugs.launchpad.net/qemu/+bug/984476. I also changed the case for 'error'. Signed-off-by: Stefan Weil --- hw/e1000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index 7babc0b..9c76462 100644 --- a/hw/e1000.c +++ b

Re: [Qemu-devel] [PATCH 0/3] switch to seavgabios

2012-04-17 Thread Gerhard Wiesinger
Negative also here: Don't see anything on screen on startup... From log, latest qemu-kvm git version: Running option rom at c180:3d4e Running option rom at c180:3da2 Running option rom at c180:3df6 Running option rom at c580:0003 qemu-system-x86_64: /root/download/qemu/git/qemu-kvm/exec.c:2641:

[Qemu-devel] [PATCH] qemu kvm: Accept PCID feature

2012-04-17 Thread Mao, Junjie
This patch makes Qemu accept the PCID feature specified from configuration or command line options. Signed-off-by: Mao, Junjie --- target-i386/cpuid.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index b9bfeaf..bc061b0 100644

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-04-17 Thread 陳韋任
On Tue, Apr 17, 2012 at 08:17:09PM +, Blue Swirl wrote: > On Tue, Apr 17, 2012 at 05:40, Xin Tong wrote: > > that is possible. but if that is the case, why not split the tlb > > walking and the tlb fill ? can anyone please confirm ? > > I sent a patch earlier that did something like that but

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Max Filippov
On Wed, Apr 18, 2012 at 12:27 AM, Peter Maydell wrote: > On 17 April 2012 21:19, Blue Swirl wrote: >> On Mon, Apr 16, 2012 at 21:58, Max Filippov wrote: >>> What is the use case of the default board? >> >> If an architecture has multiple boards, the default board can be used >> without using -M

[Qemu-devel] [Bug 984476] [NEW] "segmentaion" error when DMAing

2012-04-17 Thread Rob
Public bug reported: When working with QEMU's PCI network card E1000 emulator, I accidentally put virtual addresses into the memory mapped registers when I should have put physical addresses. Short story is, the address was too large for the physical address space so when the network card tried to

Re: [Qemu-devel] [PATCH v6 1/5] sockets: change inet_connect() to support nonblock socket

2012-04-17 Thread Amos Kong
On 18/04/12 10:10, Michael Roth wrote: On Tue, Apr 17, 2012 at 10:54:01PM +0800, Amos Kong wrote: Add a bool argument to inet_connect() to assign if set socket to block/nonblock, and delete original argument 'socktype' that is unused. Retry to connect when following errors are got: -EINTR

Re: [Qemu-devel] [PATCH v6 5/5] use inet_listen()/inet_connect() to support ipv6 migration

2012-04-17 Thread Amos Kong
On 18/04/12 10:17, Michael Roth wrote: On Tue, Apr 17, 2012 at 10:54:39PM +0800, Amos Kong wrote: Use help functions in qemu-socket.c for tcp migration, which already support ipv6 addresses. Currently errp will be set to UNDEFINED_ERROR when migration fails, qemu would output "migration failed:

[Qemu-devel] [Bug 984516] [NEW] should use sdl-config for static build not pkg-config

2012-04-17 Thread Kenneth Salerno
Public bug reported: In the configure script when a user wants to compile a static QEMU and enable SDL support (i.e. ./configure --static --enable-sdl): pkg-config does not have an option "--static-libs". For correct results (to find the static archive libSDL.a) you need to use sdl-config --stati

[Qemu-devel] [Bug 984516] Re: should use sdl-config for static build not pkg-config

2012-04-17 Thread Kenneth Salerno
Sorry, I stripped out the "2>/dev/null" when I was debugging and forgot to add it back in: diff --git a/configure b/configure index 2d62d12..3de4c9b 100755 --- a/configure +++ b/configure @@ -1548,7 +1548,7 @@ int main( void ) { return SDL_Init (SDL_INIT_VIDEO); } EOF sdl_cflags=`$sdlconfig -

Re: [Qemu-devel] [PATCH v6 5/5] use inet_listen()/inet_connect() to support ipv6 migration

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 10:54:39PM +0800, Amos Kong wrote: > Use help functions in qemu-socket.c for tcp migration, > which already support ipv6 addresses. > > Currently errp will be set to UNDEFINED_ERROR when migration fails, > qemu would output "migration failed: ...", and current user can > se

Re: [Qemu-devel] [PATCH v6 1/5] sockets: change inet_connect() to support nonblock socket

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 10:54:01PM +0800, Amos Kong wrote: > Add a bool argument to inet_connect() to assign if set socket > to block/nonblock, and delete original argument 'socktype' > that is unused. > > Retry to connect when following errors are got: > -EINTR > -EWOULDBLOCK (win32) > Connec

Re: [Qemu-devel] [PATCH v6 3/5] sockets: use error class to pass connect error

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 10:54:20PM +0800, Amos Kong wrote: > Add a new argument in inet_connect()/inet_connect_opts() > to pass back connect error. > > Change nbd, vnc to use new interface. Looks good! Reviewed-by: Michael Roth > > Signed-off-by: Amos Kong > --- > nbd.c |2 +- >

Re: [Qemu-devel] [PATCH v6 2/5] qerror: add five qerror strings

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 10:54:11PM +0800, Amos Kong wrote: > Add five new qerror strings, they are about socket: > QERR_SOCKET_CONNECT_IN_PROGRESS > QERR_SOCKET_CONNECT_FAILED > QERR_SOCKET_LISTEN_FAILED > QERR_SOCKET_BIND_FAILED > QERR_SOCKET_CREATE_FAILED > > Signed-off-by: Amos Kong

[Qemu-devel] qemu physical address

2012-04-17 Thread Xin Tong
I am reading how qemu refill TLB working. target-i386/helper.c pte = pte & env->a20_mask; /* Even if 4MB pages, we map only one 4KB page in the cache to avoid filling it too fast */ page_offset = (addr & TARGET_PAGE_MASK) & (page_size - 1); paddr = (pte & TARGET_PAGE_MASK)

[Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 0c98fcc..cc4f566 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -711,6 +711,21 @@ static void x86_cp

Re: [Qemu-devel] [PATCH 5/7 V6] Various utility functions used by VMWARE network devices

2012-04-17 Thread Michael S. Tsirkin
On Tue, Apr 17, 2012 at 03:32:39PM +0300, Dmitry Fleytman wrote: > diff --git a/hw/vmxnet_utils.h b/hw/vmxnet_utils.h > new file mode 100644 > index 000..18d218d > --- /dev/null > +++ b/hw/vmxnet_utils.h > @@ -0,0 +1,341 @@ > +/* > + * QEMU VMWARE VMXNET* paravirtual NICs - network auxiliary co

[Qemu-devel] [PATCH 05/15] target-i386: Add "model" property to X86CPU

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 26 +++--- 1 files changed, 23 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index aa0d328..f4eb24c 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -626,10 +626,27 @@ static v

[Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property for X86CPU

2012-04-17 Thread Andreas Färber
Using it now would incur converting the three x86_def_t vendor words into a string for object_property_set_str(), then back to three words in the "vendor" setter. The built-in CPU definitions use numeric preprocessor defines to initialize the three words in a charset-safe way, so do not change the

[Qemu-devel] [PATCH 06/15] target-i386: Add "stepping" property to X86CPU

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f4eb24c..2e62a6f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -649,10 +649,28 @@ static

[Qemu-devel] [PATCH 03/15] target-i386: Add range check for -cpu , family=x

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e95a1d8..d30185b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -693,7 +693,7 @@ static int cpu_x86_find_by_name(x86

[Qemu-devel] [PATCH 10/15] target-i386: Add property getter for CPU stepping

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2beb3ab..0c98fcc 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -675,6 +675,18 @@ static void x86_cpuid

[Qemu-devel] [PATCH 12/15] target-i386: Introduce "level" property for X86CPU

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index cc4f566..c9d5be5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -711,6 +711,39

[Qemu-devel] [PATCH 02/15] target-i386: Pass X86CPU to cpu_x86_register()

2012-04-17 Thread Andreas Färber
Avoids an x86_env_get_cpu() call there, to work with QOM properties. Signed-off-by: Andreas Färber --- target-i386/cpu.c|3 ++- target-i386/cpu.h|2 +- target-i386/helper.c |2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/c

[Qemu-devel] [PATCH 13/15] target-i386: Introduce "xlevel" property for X86CPU

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 38 +- 1 files changed, 37 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c9d5be5..2785690 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -744,6 +744,39

[Qemu-devel] [PATCH 08/15] target-i386: Add property getter for CPU family

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 78cb568..21041b5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -599,6 +599,20 @@ static int check_fe

[Qemu-devel] [PATCH 15/15] target-i386: Introduce "tsc-frequency" property for X86CPU

2012-04-17 Thread Andreas Färber
Use Hz as unit. Signed-off-by: Andreas Färber --- target-i386/cpu.c | 37 - 1 files changed, 36 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1ece541..f26253f 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@

[Qemu-devel] [PATCH 04/15] target-i386: Add "family" property to X86CPU

2012-04-17 Thread Andreas Färber
Add the property early in the initfn so that it can be used in helpers such as mce_init(). Signed-off-by: Andreas Färber --- target-i386/cpu.c | 38 +- 1 files changed, 33 insertions(+), 5 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c inde

[Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties

2012-04-17 Thread Andreas Färber
Hello, This series introduces some QOM properties for X86CPU, so that our built-in init code exercises the same code paths as QMP, as suggested by Eduardo: * "family", * "model", * "stepping" and * "model-id" (rather than "model_id") This QOM'ifies my previously introduced helper functions, adding

Re: [Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property for X86CPU

2012-04-17 Thread Andreas Färber
Am 18.04.2012 01:11, schrieb Andreas Färber: > Using it now would incur converting the three x86_def_t vendor words > into a string for object_property_set_str(), then back to three words > in the "vendor" setter. > The built-in CPU definitions use numeric preprocessor defines to > initialize the t

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Andreas Färber
Am 17.04.2012 22:51, schrieb Blue Swirl: > On Tue, Apr 17, 2012 at 20:35, Peter Maydell wrote: >> On 17 April 2012 21:31, Blue Swirl wrote: >>> On Tue, Apr 17, 2012 at 20:27, Peter Maydell >>> wrote: ARM has a default board set, which is unfortunate because it's hardware that nobody u

[Qemu-devel] [PATCH 09/15] target-i386: Add property getter for CPU model

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 21041b5..2beb3ab 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -640,6 +640,18 @@ static void x86_cpuid

[Qemu-devel] [PATCH 07/15] target-i386: Add "model-id" property to X86CPU

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2e62a6f..78cb568 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -673,8 +673,11 @@ static void x86_cpuid_vers

[Qemu-devel] [PATCH 01/15] target-i386: Fix x86_cpuid_set_model_id()

2012-04-17 Thread Andreas Färber
Don't assume zero'ed cpuid_model[] fields. Signed-off-by: Andreas Färber --- target-i386/cpu.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 3df53ca..80c1ca5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -627,6

Re: [Qemu-devel] [PATCH] qemu-ga: generate missing stubs for fsfreeze

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 01:54:49PM -0300, Luiz Capitulino wrote: > On Tue, 17 Apr 2012 10:15:03 -0500 > Michael Roth wrote: > > > On Tue, Apr 17, 2012 at 11:44:39AM -0300, Luiz Capitulino wrote: > > > On Fri, 13 Apr 2012 21:07:36 -0500 > > > Michael Roth wrote: > > > > > > > When linux-specific

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Anthony Liguori
On 04/17/2012 03:59 PM, Peter Maydell wrote: On 17 April 2012 21:43, Blue Swirl wrote: On Tue, Apr 17, 2012 at 20:31, Peter Maydell wrote: Well, it could. But we should make that decision based on whether it makes sense and has a use case for actual users of the board, not because we're tryin

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 21:43, Blue Swirl wrote: > On Tue, Apr 17, 2012 at 20:31, Peter Maydell wrote: >> Well, it could. But we should make that decision based on whether it >> makes sense and has a use case for actual users of the board, not >> because we're trying to get away with not having a setup

[Qemu-devel] [PATCH 08/18] qemu-option: opts_do_parse(): use error_set()

2012-04-17 Thread Luiz Capitulino
The functions qemu_opts_do_parse() and opts_parse() both call opts_do_parse(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 38 -- 1

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 21:51, Blue Swirl wrote: > On Tue, Apr 17, 2012 at 20:35, Peter Maydell wrote: >> On 17 April 2012 21:31, Blue Swirl wrote: >>> On Tue, Apr 17, 2012 at 20:27, Peter Maydell >>> wrote: ARM has a default board set, which is unfortunate because it's hardware that nobody

[Qemu-devel] [PATCH 18/18] qapi: convert netdev_del

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +-- hmp.c|9 + hmp.h|1 + net.c| 11 +-- net.h|1 - qapi-schema.json | 14 ++ qmp-commands.hx |5 + 7 fi

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 20:35, Peter Maydell wrote: > On 17 April 2012 21:31, Blue Swirl wrote: >> On Tue, Apr 17, 2012 at 20:27, Peter Maydell >> wrote: >>> ARM has a default board set, which is unfortunate because it's >>> hardware that nobody uses now, so the QEMU default setting >>> mostly

[Qemu-devel] [PATCH 06/18] qemu-option: qemu_opts_validate(): use error_set()

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- net.c |6 +- qemu-option.c | 16 +--- qemu-option.h |2 +- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/net.c b/net.c index 1922d8a..f5d9cc7 100644 --- a/net.c +++ b/net.c @@ -1136,10 +1136,14 @@ int net_clie

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-17 Thread Blue Swirl
On Mon, Apr 16, 2012 at 21:47, Anthony Liguori wrote: > On 04/16/2012 04:24 PM, Peter Maydell wrote: >> >> On 16 April 2012 18:42, Anthony Liguori  wrote: >>> >>> On 04/16/2012 12:17 PM, Peter Maydell wrote: Here's my stab at it:            Maintained:  Someone actually looks after

[Qemu-devel] [PATCH 09/18] qemu-option: qemu_opts_do_parse(): convert error_set()

2012-04-17 Thread Luiz Capitulino
qemu_chr_parse_compat() calls qerror_report_err() because its callers expect QError semantics. Signed-off-by: Luiz Capitulino --- qemu-char.c | 12 ++-- qemu-option.c | 10 -- qemu-option.h |3 ++- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/qemu-cha

[Qemu-devel] [PATCH 11/18] qerror: introduce QERR_INVALID_OPTION_GROUP

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 96fbe71..5d92096 100644 --- a/qerror.c +++ b/qerror.c @@ -156,6 +156,10 @@ static const QErrorStringTable qerror_table[] = { .desc =

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 20:31, Peter Maydell wrote: > On 17 April 2012 21:24, Blue Swirl wrote: >> On Tue, Apr 17, 2012 at 07:33, Peter Maydell >> wrote: >>> Just testing a device shouldn't require running a particular >>> board model either, of course. >> >> The goal is obviously to make compr

Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list

2012-04-17 Thread Luiz Capitulino
On Tue, 17 Apr 2012 22:26:55 +0200 Paolo Bonzini wrote: > Il 17/04/2012 21:36, Luiz Capitulino ha scritto: > > +switch(qobject_type(obj)) { > > +case QTYPE_QSTRING: > > +qstring_append(arglist, > > + qstring_get_str(qobject_to_

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 21:31, Blue Swirl wrote: > On Tue, Apr 17, 2012 at 20:27, Peter Maydell wrote: >> ARM has a default board set, which is unfortunate because it's >> hardware that nobody uses now, so the QEMU default setting >> mostly serves to trip up users who try to run a kernel for >> some oth

[Qemu-devel] [PATCH 04/18] qemu-option: parse_option_size(): use error_set()

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qemu-option.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index a8b50af..61354af 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -203,7 +203,8 @@ static void parse_option_number(cons

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 20:27, Peter Maydell wrote: > On 17 April 2012 21:19, Blue Swirl wrote: >> On Mon, Apr 16, 2012 at 21:58, Max Filippov wrote: >>> What is the use case of the default board? >> >> If an architecture has multiple boards, the default board can be used >> without using -M opt

[Qemu-devel] [PATCH 10/18] qemu-option: introduce qemu_opt_set_err()

2012-04-17 Thread Luiz Capitulino
This is like qemu_opt_set(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_opt_set(). Signed-off-by: Luiz Capitulino --- qemu-option.c |6 ++ qemu-option.h |2 ++ 2 files changed, 8 insertions(+) diff --git a/qemu-o

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 21:24, Blue Swirl wrote: > On Tue, Apr 17, 2012 at 07:33, Peter Maydell wrote: >> Just testing a device shouldn't require running a particular >> board model either, of course. > > The goal is obviously to make comprehensive tests for all devices in > all boards. Also, if a devic

[Qemu-devel] [PATCH 07/18] qemu-option: opt_set(): use error_set()

2012-04-17 Thread Luiz Capitulino
The functions qemu_opt_set() and opts_do_parse() both call opt_set(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 38 +- 1 file cha

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 12:00, Anthony Liguori wrote: > On 04/17/2012 02:44 AM, Paolo Bonzini wrote: >> >> Il 17/04/2012 09:33, Peter Maydell ha scritto: I think the issue is that all of these machines mandate a -kernel option.  qtest doesn't care if you pass a -kernel but requ

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Peter Maydell
On 17 April 2012 21:19, Blue Swirl wrote: > On Mon, Apr 16, 2012 at 21:58, Max Filippov wrote: >> What is the use case of the default board? > > If an architecture has multiple boards, the default board can be used > without using -M option. Unless the Xtensa architecture has a particular board

Re: [Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list

2012-04-17 Thread Paolo Bonzini
Il 17/04/2012 21:36, Luiz Capitulino ha scritto: > +switch(qobject_type(obj)) { > +case QTYPE_QSTRING: > +qstring_append(arglist, > + qstring_get_str(qobject_to_qstring(obj))); > +break; Does this escape commas c

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 07:33, Peter Maydell wrote: > On 17 April 2012 02:16, Anthony Liguori wrote: >> On 04/16/2012 05:54 PM, Peter Maydell wrote: >>> Yuck! Nack, this is way too invasive. Testing frameworks >>> shouldn't require random pointless changes to every board >>> model. >> >> I think

Re: [Qemu-devel] [PATCH 2/3] qtest: enable qtest for most targets

2012-04-17 Thread Blue Swirl
On Mon, Apr 16, 2012 at 21:58, Max Filippov wrote: >> Skip ROM or kernel loading and TCG init for qtest. >> >> For Xtensa there is no default board and the > > What is the use case of the default board? If an architecture has multiple boards, the default board can be used without using -M option.

Re: [Qemu-devel] qemu softmmu inlined lookup sequence

2012-04-17 Thread Blue Swirl
On Tue, Apr 17, 2012 at 05:40, Xin Tong wrote: > that is possible. but if that is the case, why not split the tlb > walking and the tlb fill ? can anyone please confirm ? I sent a patch earlier that did something like that but it wasn't very successful: http://lists.nongnu.org/archive/html/qemu-d

[Qemu-devel] [PATCH 01/18] qemu-option: qemu_opts_create(): use error_set()

2012-04-17 Thread Luiz Capitulino
This commit converts qemu_opts_create() from qerror_report() to error_set(). Currently, most calls to qemu_opts_create() can't fail, so most callers don't need any changes. The two cases where code checks for qemu_opts_create() erros are: 1. Initialization code in vl.c. All of them print their

[Qemu-devel] [PATCH 15/18] qapi: implement support for variable argument list

2012-04-17 Thread Luiz Capitulino
The variable argument list allows QAPI functions to receive a string in the format "name1=value1,name2=value2 ... nameN=valueN". This is going to be used by QMP commands that accept options in QemuOpts format, like netdev_add. The variable argument list is represented by the QAPI type '**'. It's

[Qemu-devel] [PATCH 05/18] qemu-option: qemu_opt_parse(): use error_set()

2012-04-17 Thread Luiz Capitulino
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 54 +--

[Qemu-devel] [PATCH 12/18] qemu-config: find_list(): use error_set()

2012-04-17 Thread Luiz Capitulino
Note that qemu_find_opts() callers still expect automatic error reporting with QError, so qemu_find_opts() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-config.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions

[Qemu-devel] [PATCH 13/18] qemu-config: introduce qemu_find_opts_err()

2012-04-17 Thread Luiz Capitulino
This is like qemu_find_opts(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_find_opts(). Signed-off-by: Luiz Capitulino --- qemu-config.c |5 + qemu-config.h |3 +++ 2 files changed, 8 insertions(+) diff --git a/qe

[Qemu-devel] [PATCH 16/18] net: purge the monitor object from all init functions

2012-04-17 Thread Luiz Capitulino
The only backend that really uses it is the socket one, which calls monitor_get_fd(). But it can use 'cur_mon' instead. Signed-off-by: Luiz Capitulino --- hw/pci-hotplug.c |2 +- hw/usb/dev-network.c |2 +- net.c| 18 +++--- net.h|2 +

[Qemu-devel] [PATCH 17/18] qapi: convert netdev_add

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Anthony Liguori Signed-off-by: Luiz Capitulino --- hmp-commands.hx |3 +- hmp.c| 33 +++ hmp.h|1 + hw/pci-hotplug.c |8 +++-- hw/usb/dev-network.c |7 ++-- net.c| 89 +

[Qemu-devel] [PATCH 14/18] qstring: introduce qstring_len()

2012-04-17 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qstring.c |9 + qstring.h |1 + tests/check-qstring.c | 17 + 3 files changed, 27 insertions(+) diff --git a/qstring.c b/qstring.c index b7e12e4..b1bf975 100644 --- a/qstring.c +++ b/qstring.c @@ -32,6 +

[Qemu-devel] [PATCH 03/18] qemu-option: parse_option_bool(): use error_set()

2012-04-17 Thread Luiz Capitulino
Note that set_option_parameter() callers still expect automatic error reporting with QError, so set_option_parameter() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletio

[Qemu-devel] [PATCH 02/18] qemu-option: parse_option_number(): use error_set()

2012-04-17 Thread Luiz Capitulino
Note that qemu_opt_parse() callers still expect automatic error reporting with QError, so qemu_opts_parse() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino --- qemu-option.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH 00/18]: qapi: convert netdev_add & netdev_del

2012-04-17 Thread Luiz Capitulino
As device_add depends on some qom stuff, I've switched to netdev_add/del as most patches are common. Will appreciate your review, specially the qemu-option changes (which are boring and thus easy to make mistakes). blockdev.c |2 +- hmp-commands.hx |6 +- hmp.c

Re: [Qemu-devel] [PATCH] arm-dis: Fix spelling in comments (iff -> if)

2012-04-17 Thread Peter Maydell
On 17 April 2012 19:22, Andreas Färber wrote: > Am 17.04.2012 19:58, schrieb Stefan Weil: >> The spelling 'iff' is sometimes used for 'if and only if'. >> Even if that meaning could be applied here, it is not used >> consistently. It is also quite unusual to use 'if and only if' >> in technical do

Re: [Qemu-devel] [PATCH] arm-dis: Fix spelling in comments (iff -> if)

2012-04-17 Thread Andreas Färber
Am 17.04.2012 19:58, schrieb Stefan Weil: > The spelling 'iff' is sometimes used for 'if and only if'. > Even if that meaning could be applied here, it is not used > consistently. It is also quite unusual to use 'if and only if' > in technical documentation. Therefore a simple 'if' should be > pref

[Qemu-devel] [PATCH BUILD FIX 2/2] xen: add a dummy xc_hvm_inject_msi for Xen < 4.2

2012-04-17 Thread Stefano Stabellini
xc_hvm_inject_msi is only available on Xen >= 4.2: add a dummy compatibility function for Xen < 4.2. Also enable msi support only on Xen >= 4.2. Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD --- hw/pc.c |2 +- hw/xen.h| 10 ++ hw/xen_common.h | 15 +

[Qemu-devel] [PATCH BUILD FIX 1/2] xen,configure: detect Xen 4.2

2012-04-17 Thread Stefano Stabellini
Xen 4.2 is the first to support xc_hvm_inject_msi: use it to determine if we are running on it. Signed-off-by: Stefano Stabellini Acked-by: Anthony PERARD --- configure | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH BUILD FIX 0/2] build xc_hvm_inject_msi on Xen < 4.2

2012-04-17 Thread Stefano Stabellini
Hi all, this small patch series fixes the build breakage introduced by f1dbf015dfb0aa7f66f710a1f1bc58b662951de2 with Xen < 4.2. The problem is that xc_hvm_inject_msi is only defined from Xen 4.2 onwards so we need to provide a compatibility function for older Xen versions. Stefano Stabellini (2)

[Qemu-devel] [PATCH] arm-dis: Fix spelling in comments (iff -> if)

2012-04-17 Thread Stefan Weil
The spelling 'iff' is sometimes used for 'if and only if'. Even if that meaning could be applied here, it is not used consistently. It is also quite unusual to use 'if and only if' in technical documentation. Therefore a simple 'if' should be preferred here. Signed-off-by: Stefan Weil --- arm-di

Re: [Qemu-devel] [Bug 891625] Re: [qemu-kvm] add vhost-net to kvm group udev rules 65-kvm.rules

2012-04-17 Thread Alon Bar-Lev
Well, at Gentoo we have kvm group, and I think that this comes from upstream rule. Doing vhost_net is good, anything that may be assigned to regular users. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

[Qemu-devel] [Bug 891625] Re: [qemu-kvm] add vhost-net to kvm group udev rules 65-kvm.rules

2012-04-17 Thread Michael Tokarev
I wonder if it really belongs to kvm group, -- maybe a separate "vhost_net" group should be used instead. Yes it can only be used with qemu/kvm currently, but maybe some other tool will use it in the future, and looking at how many security issues /dev/kvm access had, maybe vhost_net shold be rest

[Qemu-devel] [PATCH] block: Fix spelling in comment (ineffcient -> inefficient)

2012-04-17 Thread Stefan Weil
Signed-off-by: Stefan Weil --- block/cow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/cow.c b/block/cow.c index 8d3c9f8..a5a00eb 100644 --- a/block/cow.c +++ b/block/cow.c @@ -103,7 +103,7 @@ static int cow_open(BlockDriverState *bs, int flags) } /* - * XX

Re: [Qemu-devel] [PATCH] tci: GETPC() macro must return an uintptr_t

2012-04-17 Thread Eric Blake
On 04/17/2012 11:22 AM, Stefan Weil wrote: > Change the data type of tci_tb_ptr, so GETPC() returns an > uintptr_t now (like for all other TCG targets). > > This completes commit 2050396801ca0c8359364d61eaadece951006057 > and fixes builds with TCI. > > Signed-off-by: Stefan Weil > --- > exec-al

Re: [Qemu-devel] [PATCH 2/2] qemu-ga: fix help output

2012-04-17 Thread Luiz Capitulino
On Tue, 17 Apr 2012 12:07:39 -0500 Michael Roth wrote: > > Signed-off-by: Michael Roth Reviewed-by: Luiz Capitulino > --- > qemu-ga.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/qemu-ga.c b/qemu-ga.c > index d6f786e..74a1b02 100644 > --- a/qemu-ga.c

Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze

2012-04-17 Thread Luiz Capitulino
On Tue, 17 Apr 2012 12:07:38 -0500 Michael Roth wrote: > When linux-specific commands (including guest-fsfreeze-*) were consolidated > under defined(__linux__), we forgot to account for the case where > defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer > being generated on

Re: [Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-04-17 Thread Luiz Capitulino
On Mon, 26 Mar 2012 17:58:46 +0800 Wen Congyang wrote: > Hi, all > > 'virsh dump' can not work when host pci device is used by guest. We have > discussed this issue here: > http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html No more review comments, will assume this is good en

[Qemu-devel] [PATCH] tci: GETPC() macro must return an uintptr_t

2012-04-17 Thread Stefan Weil
Change the data type of tci_tb_ptr, so GETPC() returns an uintptr_t now (like for all other TCG targets). This completes commit 2050396801ca0c8359364d61eaadece951006057 and fixes builds with TCI. Signed-off-by: Stefan Weil --- exec-all.h |2 +- tci.c |4 ++-- 2 files changed, 3 ins

Re: [Qemu-devel] [PATCH] qapi: g_hash_table_find() instead of GHashTableIter.

2012-04-17 Thread Luiz Capitulino
On Sat, 14 Apr 2012 00:01:49 +0900 "NODA, Kai" wrote: > From: "NODA, Kai" > > GHashTableIter was first introduced in glib 2.16. > This patch removes it in favor of older g_hash_table_find() > for better compatibility with RHEL5. Missing signed-off, otherwise looks good. > --- > qapi/qmp-inpu

Re: [Qemu-devel] [PATCH] tci: Use uintptr_t for the GETPC() macro

2012-04-17 Thread Stefan Weil
Am 17.04.2012 19:02, schrieb Eric Blake: On 04/17/2012 10:49 AM, Stefan Weil wrote: Am 17.04.2012 18:40, schrieb Eric Blake: On 04/17/2012 10:36 AM, Stefan Weil wrote: This completes commit 2050396801ca0c8359364d61eaadece951006057 and fixes builds with TCI. Signed-off-by: Stefan Weil --- exec

Re: [Qemu-devel] [PATCH 35/46] qemu-iotests: qcow2.py

2012-04-17 Thread Philipp Hahn
Hello, On Thursday 05 April 2012 17:52:13 Kevin Wolf wrote: > This adds a tool that is meant to inspect and edit qcow2 files in a > low-level way, that wouldn't be possible with qemu-img/io, for example > by adding yet unknown extensions or flags. This way we can test whether > qemu deals properly

[Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze

2012-04-17 Thread Michael Roth
When linux-specific commands (including guest-fsfreeze-*) were consolidated under defined(__linux__), we forgot to account for the case where defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer being generated on linux hosts that don't have FIFREEZE support. Fix this. Tested-

[Qemu-devel] [PATCH 2/2] qemu-ga: fix help output

2012-04-17 Thread Michael Roth
Signed-off-by: Michael Roth --- qemu-ga.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index d6f786e..74a1b02 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -117,12 +117,13 @@ static gboolean register_signal_handlers(void) static void usage(con

Re: [Qemu-devel] [PATCH] tci: Use uintptr_t for the GETPC() macro

2012-04-17 Thread Eric Blake
On 04/17/2012 10:49 AM, Stefan Weil wrote: > Am 17.04.2012 18:40, schrieb Eric Blake: >> On 04/17/2012 10:36 AM, Stefan Weil wrote: >>> This completes commit 2050396801ca0c8359364d61eaadece951006057 >>> and fixes builds with TCI. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> exec-all.h |2 +-

  1   2   3   >