Re: [Qemu-devel] [Qemu-ppc] [PATCH] Bug fix for #986241: spell env correctly

2012-04-23 Thread Peter Maydell
On 23 April 2012 03:25, Peter Portante wrote: > Can somebody speak to the history of using a global variable for env state > instead of passing it around in function calls? Is this because we could not > trust the compiler to keep it in a register between function calls? If so, > then do you think

Re: [Qemu-devel] [PATCH v3] ARM: Exynos4210 IRQ: Introduce new IRQ gate functionality.

2012-04-23 Thread Peter Maydell
On 23 April 2012 06:08, Evgeny Voevodin wrote: > Peter, wait, n_in is a property that board sets. So it should be > saved/restored. As I understand it, migration will always be between two identical configurations. So properties never need to be saved or restored. -- PMM

[Qemu-devel] compile problem

2012-04-23 Thread Zhi Hui Li
Ater I git pull to the newest version, I make qemu, the error happen: CCx86_64-softmmu/vga.o CCx86_64-softmmu/memory.o CCx86_64-softmmu/savevm.o CCx86_64-softmmu/xen-all.o cc1: warnings being treated as errors /home/mm/code-new/qemu-2012-3-19/test-new/qemu/xen-all.c: In fu

Re: [Qemu-devel] compile problem

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 10:13, Zhi Hui Li ha scritto: > Ater I git pull to the newest version, > I make qemu, the error happen: > > > CCx86_64-softmmu/vga.o > CCx86_64-softmmu/memory.o > CCx86_64-softmmu/savevm.o > CCx86_64-softmmu/xen-all.o > cc1: warnings being treated as errors >

[Qemu-devel] [PATCH] qemu-iotests: ignore fragmentation information for qed

2012-04-23 Thread Dong Xu Wang
We added image fragmentation statistics functions to qemu-img several days ago, those patches will cause "./check -qed" failed. This patch will ignore fragmentation statistics information of qed format, and then "./check -qed" will work. Signed-off-by: Dong Xu Wang --- tests/qemu-iotests/check

Re: [Qemu-devel] [PATCH 25/25] qdev: split part of device_finalize to device_unrealize

2012-04-23 Thread Paolo Bonzini
Il 20/04/2012 19:56, Anthony Liguori ha scritto: > On 04/03/2012 06:15 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> hw/qdev.c | 35 --- >> 1 file changed, 20 insertions(+), 15 deletions(-) >> >> diff --git a/hw/qdev.c b/hw/qdev.c >> index e

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Stefan Hajnoczi
On Sun, Apr 22, 2012 at 5:37 PM, Xin Tong wrote: > i have an OS image that does not have network drivers. are there any > other ways to copy a benchmark onto the os image ? You can insert a CD-ROM: (qemu) info block ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted] ... (qemu

Re: [Qemu-devel] [PATCH] qemu-iotests: ignore fragmentation information for qed

2012-04-23 Thread Kevin Wolf
Am 23.04.2012 10:43, schrieb Dong Xu Wang: > We added image fragmentation statistics functions to qemu-img several days > ago, those patches will cause "./check -qed" failed. This patch will ignore > fragmentation statistics information of qed format, and then "./check -qed" > will work. > > > S

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Kevin Wolf
Am 22.04.2012 18:37, schrieb Xin Tong: > i have an OS image that does not have network drivers. are there any > other ways to copy a benchmark onto the os image ? If it is a raw image you can use kpartx to get block devices on the host that you can use for mounting the guest file system on the hos

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Zhi Yong Wu
On Mon, Apr 23, 2012 at 4:29 PM, Stefan Hajnoczi wrote: > On Sun, Apr 22, 2012 at 5:37 PM, Xin Tong wrote: >> i have an OS image that does not have network drivers. are there any >> other ways to copy a benchmark onto the os image ? > > You can insert a CD-ROM: > > (qemu) info block > ide1-cd0: r

Re: [Qemu-devel] compile problem

2012-04-23 Thread Zhi Hui Li
On 2012年04月23日 16:21, Paolo Bonzini wrote: Il 23/04/2012 10:13, Zhi Hui Li ha scritto: Ater I git pull to the newest version, I make qemu, the error happen: CCx86_64-softmmu/vga.o CCx86_64-softmmu/memory.o CCx86_64-softmmu/savevm.o CCx86_64-softmmu/xen-all.o cc1: war

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Zhi Yong Wu
On Mon, Apr 23, 2012 at 4:41 PM, Zhi Yong Wu wrote: > On Mon, Apr 23, 2012 at 4:29 PM, Stefan Hajnoczi wrote: >> On Sun, Apr 22, 2012 at 5:37 PM, Xin Tong wrote: >>> i have an OS image that does not have network drivers. are there any >>> other ways to copy a benchmark onto the os image ? >> >>

Re: [Qemu-devel] [PATCH 07/10] Do not use pa_simple PulseAudio API

2012-04-23 Thread Jan Kiszka
On 2012-04-17 14:32, Marc-André Lureau wrote: > Unfortunately, pa_simple is a limited API which doesn't let us > retrieve the associated pa_stream. It is needed to control the volume > of the stream. > > In v4: > - add missing braces > > Signed-off-by: Marc-André Lureau ... > + > +static pa_st

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Zhi Yong Wu
On Mon, Apr 23, 2012 at 4:46 PM, Zhi Yong Wu wrote: > On Mon, Apr 23, 2012 at 4:41 PM, Zhi Yong Wu wrote: >> On Mon, Apr 23, 2012 at 4:29 PM, Stefan Hajnoczi wrote: >>> On Sun, Apr 22, 2012 at 5:37 PM, Xin Tong wrote: i have an OS image that does not have network drivers. are there any >>>

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Zhi Yong Wu
On Mon, Apr 23, 2012 at 5:00 PM, Zhi Yong Wu wrote: > On Mon, Apr 23, 2012 at 4:46 PM, Zhi Yong Wu wrote: >> On Mon, Apr 23, 2012 at 4:41 PM, Zhi Yong Wu wrote: >>> On Mon, Apr 23, 2012 at 4:29 PM, Stefan Hajnoczi wrote: On Sun, Apr 22, 2012 at 5:37 PM, Xin Tong wrote: > i have

[Qemu-devel] [PATCH v2] qemu-iotests: ignore fragmentation information for qed

2012-04-23 Thread Dong Xu Wang
We added image fragmentation statistics functions to qemu-img several days ago, those patches will cause "./check -qed" failed. This patch will ignore fragmentation statistics information of qed format, and then "./check -qed" will work. Signed-off-by: Dong Xu Wang --- v1->v2: change functio

Re: [Qemu-devel] [PATCH v2] qemu-iotests: ignore fragmentation information for qed

2012-04-23 Thread Dong Xu Wang
Sorry, missed "v2" Lable in title. On Mon, Apr 23, 2012 at 17:14, Dong Xu Wang wrote: > We added image fragmentation statistics functions to qemu-img several days > ago, those patches will cause "./check -qed" failed. This patch will ignore > fragmentation statistics information of qed format, a

Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support

2012-04-23 Thread Stefan Hajnoczi
On Sat, Apr 21, 2012 at 9:51 AM, Nicholas A. Bellinger wrote: > On Fri, 2012-04-20 at 12:09 +0100, Stefan Hajnoczi wrote: >> On Fri, Apr 20, 2012 at 8:46 AM, Paolo Bonzini wrote: >> > Il 20/04/2012 09:00, Nicholas A. Bellinger ha scritto: > > > >> > - no support for migration (there can be pendi

Re: [Qemu-devel] [PATCH] virtio: add missing mb() on notification

2012-04-23 Thread Stefan Hajnoczi
On Sun, Apr 22, 2012 at 3:54 PM, Michael S. Tsirkin wrote: > During normal operation, virtio host first writes a used index > and then checks whether it should interrupt the guest > by reading guest avail flag/used event index values. > Guest does the reverse: writes the index/flag, > then checks

[Qemu-devel] KVM call agenda for April, Tuesday 24

2012-04-23 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

[Qemu-devel] [PATCH 2/7] [s390] fix error handling on kernel and initrd failures

2012-04-23 Thread Christian Borntraeger
If the user specifies a non-existing or non-accessable kernel or initrd qemu does not fail, instead it ipls into the system, which then falls into a program check loop due to the zeroed memory with no kernel. Lets add some sanity checks. Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c

Re: [Qemu-devel] [PATCH 10/10] Enable mixemu by default, add runtime option

2012-04-23 Thread Paolo Bonzini
Il 17/04/2012 16:01, malc ha scritto: > On Tue, 17 Apr 2012, Marc-Andr? Lureau wrote: > >> Without MIXEMU, volume control on the guest doesn't work (except when >> volume is applied by guest "emulation", in Win7 for example). >> >> Instead rely on backend volume support, or fallback on mixeng if >

Re: [Qemu-devel] [PATCH v2 0/2] [trivial] More concise handling of tracetool-generated files

2012-04-23 Thread Stefan Hajnoczi
On Wed, Apr 18, 2012 at 7:15 PM, Lluís Vilanova wrote: > Some trivial changes to handle tracetool-generated files more concisely. > > Signed-off-by: Lluís Vilanova > --- > NOTE: Applies on top of the tracetool rewrite. > > Changes in v2: > > * Only remove tracetool-generated files that were actua

[Qemu-devel] [PATCH 1/7] [s390] fix kernel_commandline handling

2012-04-23 Thread Christian Borntraeger
From: Christian Borntraeger The current handling of kernel parameters is broken. The pointer is always valid, even if no -kernel or -append is specified. We must check if the kernel rom address is valid instead, otherwise qemu might segfault. Signed-off-by: Christian Borntraeger --- hw/s390-vi

[Qemu-devel] [PATCH 6/7] [s390] remove default cdrom, sd-card and floppy support

2012-04-23 Thread Christian Borntraeger
From: Einar Lueck This patch simply disables CDROM, SD card and floppy support for the s390 virtio machine. Without this patch, a default CDROM drive would get added which has currently no backing on s390. Signed-off-by: Einar Lueck Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c |

[Qemu-devel] [PATCH 4/7] [s390] reset avail and used index on reboot

2012-04-23 Thread Christian Borntraeger
From: Jens Freimann reset the guest vring avail/used idx fields, otherwise it's possible that old values remain in memory which would cause a reboot to fail with a "Guest moved used index" message Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- hw/s390-virtio-bus.c |

[Qemu-devel] [PATCH 0/7] Fixes for s390

2012-04-23 Thread Christian Borntraeger
Alex, here are some fixes for s390 kvm. The reboot patches are fixes only and are not enough to have a fully working reboot. Additional infrastructure that completes reboot will come with a later patch series. Christian Borntraeger (3): [s390] fix kernel_commandline handling [s390] fix error

[Qemu-devel] [PATCH 5/7] [s390] support reboot for kvm on s390

2012-04-23 Thread Christian Borntraeger
From: Jens Freimann This patch adds reboot support for s390x-softmmu by calling the generic reboot support in kvm. Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-s390x/kvm

[Qemu-devel] [PATCH 3/7] [s390] reboot: reset device pages on reboot

2012-04-23 Thread Christian Borntraeger
From: Jens Freimann This patch fixes reboot on s390 by resetting the device page on reboot. Signed-off-by: Jens Freimann Signed-off-by: Christian Borntraeger --- hw/s390-virtio-bus.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c inde

[Qemu-devel] [PATCH 7/7] [s390] dont call system_shutdown on disabled wait

2012-04-23 Thread Christian Borntraeger
A disabled wait usually indicates a guest problem. Dont shutdown the guest to allow guest dumping. Have some special cases, e.g. a quiesce disabled wait. In that case we want to shutdown. Long term solution might be a crashed/panic indication. Signed-off-by: Christian Borntraeger --- target-s39

[Qemu-devel] buildbot failure in qemu on default_i386_rhel61

2012-04-23 Thread qemu
The Buildbot has detected a new failure on builder default_i386_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/241 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61_32bit

[Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling set_features callback, not after

2012-04-23 Thread Alon Levy
We could drop the features parameter but that's a little more work and it's not really needed. Signed-off-by: Alon Levy --- hw/virtio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio.c b/hw/virtio.c index 064aecf..aeddc81 100644 --- a/hw/virtio.c +++ b/hw/virtio

[Qemu-devel] [PATCH 2/2] virtio-serial-bus: query guest features after guest sets them

2012-04-23 Thread Alon Levy
From: Amit Shah Currently we query the virtio features w/o even waiting for the guest to boot up and ack features. Do the querying after set_features has succeeded. The check to enable guest_connected for the host to be able to write to the guest was flawed in this way, causing all ports to be

Re: [Qemu-devel] [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-23 Thread Vasilis Liaskovitis
On Sun, Apr 22, 2012 at 04:58:47PM +0300, Gleb Natapov wrote: > On Thu, Apr 19, 2012 at 04:08:46PM +0200, Vasilis Liaskovitis wrote: > > Hotplugged memory is not persistent in the e820 memory maps. After > > hotplugging > > a memslot and rebooting the VM, the hotplugged device is not present. >

Re: [Qemu-devel] [RFC PATCH 8/9] pc: adjust e820 map on hot-add and hot-remove

2012-04-23 Thread Gleb Natapov
On Mon, Apr 23, 2012 at 01:27:40PM +0200, Vasilis Liaskovitis wrote: > On Sun, Apr 22, 2012 at 04:58:47PM +0300, Gleb Natapov wrote: > > On Thu, Apr 19, 2012 at 04:08:46PM +0200, Vasilis Liaskovitis wrote: > > > Hotplugged memory is not persistent in the e820 memory maps. After > > > hotplugging

Re: [Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling set_features callback, not after

2012-04-23 Thread Amit Shah
On (Mon) 23 Apr 2012 [14:26:23], Alon Levy wrote: > We could drop the features parameter but that's a little more work and > it's not really needed. > > Signed-off-by: Alon Levy Michael, can you ack this? I'm running these through the test suite and will send them both once everything's fine.

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-23 Thread Michal Privoznik
On 20.04.2012 15:36, Luiz Capitulino wrote: > On Fri, 20 Apr 2012 14:07:16 +0200 > Michal Privoznik wrote: > But, I think if we tell users we'll *only* send response on error, we should do our part to *not* send the responses, rather than relying on them having implemented the rese

Re: [Qemu-devel] [PATCH] qcow2: Fix refcount block allocation during qcow2_allocate_cluster_at()

2012-04-23 Thread Kevin Wolf
Am 23.04.2012 01:35, schrieb Marcelo Tosatti: > On Sun, Apr 22, 2012 at 08:18:49PM -0300, Marcelo Tosatti wrote: >> On Fri, Apr 20, 2012 at 03:56:01PM +0200, Kevin Wolf wrote: >>> Refcount block allocation and refcount table growth rely on >>> s->free_cluster_index pointing to somewhere after the c

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-23 Thread Vasilis Liaskovitis
Hi, On Sun, Apr 22, 2012 at 05:20:59PM +0300, Gleb Natapov wrote: > On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: > > On 04/22/2012 05:09 PM, Gleb Natapov wrote: > > > On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: > > > > On 04/22/2012 04:56 PM, Gleb Natapov wrote: > >

Re: [Qemu-devel] [PATCH 2/2] virtio-serial-bus: query guest features after guest sets them

2012-04-23 Thread Michael S. Tsirkin
On Mon, Apr 23, 2012 at 02:26:24PM +0300, Alon Levy wrote: > From: Amit Shah > > Currently we query the virtio features w/o even waiting > for the guest to boot up and ack features. > > Do the querying after set_features has succeeded. > > The check to enable guest_connected for the host to be

Re: [Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling set_features callback, not after

2012-04-23 Thread Michael S. Tsirkin
On Mon, Apr 23, 2012 at 02:26:23PM +0300, Alon Levy wrote: > We could drop the features parameter but that's a little more work and > it's not really needed. > > Signed-off-by: Alon Levy I think it's fine the way it is but if you want callbacks to use vdev->guest_features remove the features par

[Qemu-devel] [PATCHv2 0/3] virtio: fix memory access races

2012-04-23 Thread Michael S. Tsirkin
This is a follow-up to my previous patch: it turns out that a single mb() isn't sufficient as network loss could still be triggered under stress. Patch 1 is repost of v1. The following two patches fix more races found by code inspection and comparison with vhost in kernel. After applying these pa

[Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification

2012-04-23 Thread Michael S. Tsirkin
This fixes an issue dual to the one fixed by patch 'virtio: add missing mb() on notification' and applies on top. In this case, to enable vq kick to exit to host, qemu writes out used flag then reads the avail index. if these are reordered we get a race: host avail index read: ring is empty

[Qemu-devel] [PATCHv2 1/3] virtio: add missing mb() on notification

2012-04-23 Thread Michael S. Tsirkin
During normal operation, virtio first writes a used index and then checks whether it should interrupt the guest by reading guest avail index/flag values. Guest does the reverse: writes the index/flag, then checks the used ring. The ordering is important: if host avail flag read bypasses the used

[Qemu-devel] [Bug 986770] Re: Oops: spice configured but not active

2012-04-23 Thread Alexandr
thx, this solves problem, but patches failed, i have to edit code manually -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/986770 Title: Oops: spice configured but not active Status in QEMU: New

Re: [Qemu-devel] [RFC PATCH 0/9] ACPI memory hotplug

2012-04-23 Thread Avi Kivity
On 04/22/2012 05:20 PM, Gleb Natapov wrote: > On Sun, Apr 22, 2012 at 05:13:27PM +0300, Avi Kivity wrote: > > On 04/22/2012 05:09 PM, Gleb Natapov wrote: > > > On Sun, Apr 22, 2012 at 05:06:43PM +0300, Avi Kivity wrote: > > > > On 04/22/2012 04:56 PM, Gleb Natapov wrote: > > > > > start. We will ne

[Qemu-devel] Fwd: buildbot failure in qemu on rhel6-32bit

2012-04-23 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on rhel6-32bit Date: Mon, 23 Apr 2012 11:10:06 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder rhel6-32bit while building qemu. Full details are available at:

Re: [Qemu-devel] Optimization for amd CPUs without amd-v using sse2, 3, 4 instructions

2012-04-23 Thread 陳韋任
On Sun, Apr 22, 2012 at 12:07:40PM +0800, 陳韋任 wrote: > > I am using qemu to run VMs on my computer with amd chip on board. > > However, my computer doesn't support amd-v, so the performance of the VM is > > low. > > I do have experiences in optimization of program using sse technique. > > Is it po

[Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-04-23 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on fedora-default Date: Mon, 23 Apr 2012 12:43:39 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder fedora-default while building qemu. Full details are availabl

[Qemu-devel] [Bug 986770] Re: Oops: spice configured but not active

2012-04-23 Thread Alon Levy
Seems commit ad1be89948f88e89708b04ccd782456ccec3a6f0 from qemu needs to go in to qemu-kvm. Could you try that and report if it fixes the issue for you? commit ad1be89948f88e89708b04ccd782456ccec3a6f0 Author: Alon Levy Date: Wed Mar 14 20:33:37 2012 +0200 spice: fix broken initialization

[Qemu-devel] Fwd: buildbot failure in qemu on rhel5-default

2012-04-23 Thread Gerd Hoffmann
Original Message Subject: buildbot failure in qemu on rhel5-default Date: Mon, 23 Apr 2012 12:04:44 +0200 From: build...@spunk.home.kraxel.org To: kra...@gmail.com The Buildbot has detected a failed build on builder rhel5-default while building qemu. Full details are available

[Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads

2012-04-23 Thread Michael S. Tsirkin
virtio has the equivalent of: if (vq->last_avail_index != vring_avail_idx(vq)) { read descriptor head at vq->last_avail_index; } In theory, processor can reorder descriptor head read to happen speculatively before the index read. this would trigger the following ra

Re: [Qemu-devel] [PATCH] spice: require spice-protocol >= 0.8.1

2012-04-23 Thread Peter Maydell
Ping? This patch doesn't seem to have made it into master yet and I don't think it was in the last spice pullreq... (patchwork id http://patchwork.ozlabs.org/patch/145294/) thanks -- PMM On 7 March 2012 14:19, Alon Levy wrote: > Requiring spice-server >= 0.8.2 is not enough since spice-server.p

Re: [Qemu-devel] [PATCH 1/2] virtio: set guest_features before calling set_features callback, not after

2012-04-23 Thread Alon Levy
On Mon, Apr 23, 2012 at 04:06:02PM +0300, Michael S. Tsirkin wrote: > On Mon, Apr 23, 2012 at 02:26:23PM +0300, Alon Levy wrote: > > We could drop the features parameter but that's a little more work and > > it's not really needed. > > > > Signed-off-by: Alon Levy > > I think it's fine the way i

Re: [Qemu-devel] [RFC 0/2]: qemu-ga: drop automatic reaper

2012-04-23 Thread Michael Roth
On Mon, Apr 23, 2012 at 02:20:53PM +0200, Michal Privoznik wrote: > On 20.04.2012 15:36, Luiz Capitulino wrote: > > On Fri, 20 Apr 2012 14:07:16 +0200 > > Michal Privoznik wrote: > > > But, I think if we tell users we'll *only* send response on error, > we should do our part to *not* se

Re: [Qemu-devel] Fwd: buildbot failure in qemu on fedora-default

2012-04-23 Thread Stefano Stabellini
On Mon, 23 Apr 2012, Gerd Hoffmann wrote: > Original Message > Subject: buildbot failure in qemu on fedora-default > Date: Mon, 23 Apr 2012 12:43:39 +0200 > From: build...@spunk.home.kraxel.org > To: kra...@gmail.com > > The Buildbot has detected a failed build on builder fedora-

[Qemu-devel] [PATCH v3 3/6] target-cris: Start QOM'ifying CPU init

2012-04-23 Thread Andreas Färber
Move VR-independent code from cpu_cris_init() into an initfn. Signed-off-by: Andreas Färber --- target-cris/cpu.c |9 + target-cris/translate.c |2 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/target-cris/cpu.c b/target-cris/cpu.c index 93c7e00..c59660

[Qemu-devel] [PATCH v3 4/6] target-microblaze: QOM'ify CPU

2012-04-23 Thread Andreas Färber
Embed CPUMBState as first member of QOM MicroBlazeCPU. Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber Tested-by: Peter A. G. Crosthwaite [AF: Updated cpu.c to include cpu-qom.h indirectly via cpu.h] --- Makefile.target |1 + target-microbl

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-23 Thread Eduardo Habkost
On Sat, Apr 21, 2012 at 09:23:50AM +0200, Jan Kiszka wrote: > On 2012-04-20 17:36, Eduardo Habkost wrote: > > On Fri, Apr 20, 2012 at 05:19:17PM +0200, Jan Kiszka wrote: > >> On 2012-04-20 17:00, Eduardo Habkost wrote: > >>> On Fri, Apr 20, 2012 at 12:12:38PM +0200, Jan Kiszka wrote: > On 2012

[Qemu-devel] [PATCH] fix BCD mask for date (Solaris 2.5 guest hang fix)

2012-04-23 Thread Artyom Tarasenko
Fix BCD mask for date. The most visible effect of this patch is Solaris 2.5.1 doesn't hang at boot if the day of month is >21. Signed-off-by: Artyom Tarasenko --- hw/m48t59.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/m48t59.c b/hw/m48t59.c index 60bbb00..0c

[Qemu-devel] [PATCH v3 5/6] target-microblaze: QOM'ify CPU reset

2012-04-23 Thread Andreas Färber
Move code from cpu_state_reset() to QOM mb_cpu_reset(). Signed-off-by: Andreas Färber Tested-by: Peter A. G. Crosthwaite --- target-microblaze/cpu.c | 51 - target-microblaze/translate.c | 51 +--- 2 files cha

[Qemu-devel] [PATCH v3 2/6] target-cris: QOM'ify CPU reset

2012-04-23 Thread Andreas Färber
Move code from cpu_state_reset() into QOM cris_cpu_reset(). Let CPU init call cpu_reset(). Signed-off-by: Andreas Färber --- target-cris/cpu.c | 23 ++- target-cris/translate.c | 22 ++ 2 files changed, 24 insertions(+), 21 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] fix BCD mask for date (Solaris 2.5 guest hang fix)

2012-04-23 Thread Andreas Färber
Am 23.04.2012 16:48, schrieb Artyom Tarasenko: > Fix BCD mask for date. The most visible effect of this patch is > Solaris 2.5.1 doesn't hang at boot if the day of month is >21. > > Signed-off-by: Artyom Tarasenko > --- > hw/m48t59.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions

[Qemu-devel] [PATCH] virtio-serial-bus: fix guest_connected pre-driver

2012-04-23 Thread Alon Levy
guest_connected should be false before guest driver initialization, and true after, both for multiport aware and non multiport aware drivers. Don't set it before the guest_features are available, instead use set_status which is called by io to VIRTIO_PCI_STATUS with VIRTIO_CONFIG_S_DRIVER_OK by ev

[Qemu-devel] [PULL] QOM CPUState for cris and microblaze

2012-04-23 Thread Andreas Färber
Hello Edgar, Ask and thou shall receive: Please pull the cris and microblaze QOM CPU conversions. Changes from v2: * Rebased onto master (all preceding targets got merged in the meantime). * target-cris/{cpu.c,cpu-qom.h}: Include cpu.h from cpu.c, not from cpu-qom.h. * target-microblaze/{cpu.c,c

[Qemu-devel] [PATCH v3 6/6] target-microblaze: QOM'ify CPU init

2012-04-23 Thread Andreas Färber
Move code from cpu_mb_init() to a QOM initfn. Signed-off-by: Andreas Färber Tested-by: Peter A. G. Crosthwaite [AF: Leave cpu_reset() call in cpu_mb_init()] --- target-microblaze/cpu.c | 11 +++ target-microblaze/translate.c |2 -- 2 files changed, 11 insertions(+), 2 deleti

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2012-04-23 Thread Serge Hallyn
Thanks, Max. Marked as affecting upstream QEMU per the last comment. ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Confirmed ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH v3 1/6] target-cris: QOM'ify CPU

2012-04-23 Thread Andreas Färber
Embed CPUCRISState as first member of QOM CRISCPU. Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber --- Makefile.target |1 + target-cris/cpu-qom.h | 70 +++ target-cris/cpu.c | 60 +++

[Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errno for block_job_create()

2012-04-23 Thread Stefan Hajnoczi
The block job API uses -errno return values internally and we convert these to Error in the QMP functions. This is ugly because the Error should be created at the point where we still have all the relevant information. More importantly, it is hard to add new error cases to this case since we quic

[Qemu-devel] [PATCH 4/4] qemu-iotests: add block-stream with invalid speed value test

2012-04-23 Thread Stefan Hajnoczi
Add a test to exercise the BlockJobSpeedInvalid error code path in the block-stream command. The 'speed' parameter allows the speed limit of the job to be applied immediately when the job starts instead of issuing a separate block-job-set-speed command later. If the parameter has an invalid value

Re: [Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errno for block_job_create()

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: > +stream_start(bs, base_bs, base, block_stream_cb, bs, errp); > +if (error_is_set(errp)) { > +return; > } This needs to be Error *local_err = NULL; stream_start(bs, base_bs, base, block_stream_cb, bs, &local_err);

Re: [Qemu-devel] [PATCH v2] qemu-iotests: ignore fragmentation information for qed

2012-04-23 Thread Kevin Wolf
Am 23.04.2012 11:14, schrieb Dong Xu Wang: > We added image fragmentation statistics functions to qemu-img several days > ago, those patches will cause "./check -qed" failed. This patch will ignore > fragmentation statistics information of qed format, and then "./check -qed" > will work. > > Sign

[Qemu-devel] [PATCH 0/4] block: add optional 'speed' parameter to block-stream

2012-04-23 Thread Stefan Hajnoczi
This series is based on Luiz' latest QMP pull request at git://repo.or.cz/qemu/qmp-unstable.git queue/qmp (d980956d5bfa9f4fd56c00a0b168c3c0f67bc0d2). This dependency is necessary because this series conflicts with the block_stream -> block-stream rename. Eric Blake raised concerns about the inabi

Re: [Qemu-devel] [PATCH 1/4] block: use Error mechanism instead of -errno for block_job_create()

2012-04-23 Thread Stefan Hajnoczi
On Mon, Apr 23, 2012 at 4:42 PM, Paolo Bonzini wrote: > Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: >> +    stream_start(bs, base_bs, base, block_stream_cb, bs, errp); >> +    if (error_is_set(errp)) { >> +        return; >>      } > > This needs to be > >    Error *local_err = NULL; >    str

Re: [Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: > There are at least two different errors that can occur in > block_job_set_speed(): the job might not support setting speeds or the > value might be invalid. > > Use the Error mechanism to report the error where it occurs. This patch > adds the ne

Re: [Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: > +/* Only set speed when necessary to avoid NotSupported error */ > +if (speed != 0) { > +Error *local_err = NULL; > + > +block_job_set_speed(job, speed, &local_err); > +if (error_is_set(&local_err)) { > +

Re: [Qemu-devel] [PATCH 4/4] qemu-iotests: add block-stream with invalid speed value test

2012-04-23 Thread Paolo Bonzini
Il 23/04/2012 17:39, Stefan Hajnoczi ha scritto: > + > +result = self.vm.qmp('block-stream', device='drive0', speed=-1) > +self.assert_qmp(result, 'error/class', 'BlockJobSpeedInvalid') > +self.assert_qmp(result, 'error/data/value', -1) Apart from /me disagreeing on introdu

Re: [Qemu-devel] [PATCH] virtio-serial-bus: fix guest_connected pre-driver

2012-04-23 Thread Michael S. Tsirkin
On Mon, Apr 23, 2012 at 06:23:10PM +0300, Alon Levy wrote: > guest_connected should be false before guest driver initialization, and > true after, both for multiport aware and non multiport aware drivers. > > Don't set it before the guest_features are available, instead use > set_status which is c

Re: [Qemu-devel] [PATCH v6 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-23 Thread Peter Maydell
On 23 April 2012 00:31, Peter Chubb wrote: > Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built > around the FreeScale i.MX31. > +    if (serial_hds[3]) { > +        serial_mm_init(address_space_mem, KZM_FPGA, 0, > +                       qdev_get_gpio_in(dev, 52), > +      

Re: [Qemu-devel] setjmp and longjmp in qemu

2012-04-23 Thread Peter Maydell
On 23 April 2012 01:06, Xin Tong wrote: > QEMU uses this very hard to understand setjmp and longjmp to handle > asynchronous interrupt. what i do not understand is that say one of > the process is doing a context switching in the guest os. tlb_flush > gets called, what if in the middle of tlb_flus

[Qemu-devel] [PATCH 3/4] block: add 'speed' optional parameter to block-stream

2012-04-23 Thread Stefan Hajnoczi
Allow streaming operations to be started with an initial speed limit. This eliminates the window of time between starting streaming and issuing block-job-set-speed. Users should use the new optional 'speed' parameter instead so that speed limits are in effect immediately when the job starts. Sign

[Qemu-devel] [PATCH 2/4] block: use Error mechanism instead of -errno for block_job_set_speed()

2012-04-23 Thread Stefan Hajnoczi
There are at least two different errors that can occur in block_job_set_speed(): the job might not support setting speeds or the value might be invalid. Use the Error mechanism to report the error where it occurs. This patch adds the new BlockJobSpeedInvalid QError. The error is specific to bloc

Re: [Qemu-devel] [PATCH v6 2/5] Implement i.MX31 Clock Control Module

2012-04-23 Thread Peter Maydell
On 23 April 2012 00:31, Peter Chubb wrote: > +    /* Frequencies precalculated on register changes */ > +    uint32_t pll_refclk_freq; > +    uint32_t mcu_clk_freq; > +    uint32_t hsp_clk_freq; > +    uint32_t ipg_clk_freq; > +} IMXCCMState; > + > +static const VMStateDescription vmstate_imx_ccm

[Qemu-devel] [PULL 0/2]: QMP queue

2012-04-23 Thread Luiz Capitulino
Two small QMP/QAPI fixes. The changes (since 3c30dd5a68e9fee6af67cfd0d14ed7520820f36a) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp NODA, Kai (1): qapi: g_hash_table_find() instead of GHashTableIter. Stefan Hajnoczi (1): qmp: make b

[Qemu-devel] [PULL 2/2] qapi: g_hash_table_find() instead of GHashTableIter.

2012-04-23 Thread Luiz Capitulino
From: "NODA, Kai" GHashTableIter was first introduced in glib 2.16. This patch removes it in favor of older g_hash_table_find() for better compatibility with RHEL5. Signed-off-by: NODA, Kai Signed-off-by: Luiz Capitulino --- qapi/qmp-input-visitor.c | 25 + 1 file ch

[Qemu-devel] [PULL 1/2] qmp: make block job command naming consistent

2012-04-23 Thread Luiz Capitulino
From: Stefan Hajnoczi The block streaming and job commands used '_' instead of '-' for reasons of compatibility with libvirt, which already included support for the '_' naming. However, the semantics of block_job_cancel have changed and libvirt now needs to handle the new semantics. Since the o

Re: [Qemu-devel] [PATCH v6 3/5] FreeSCALE i.MX31 support: Timers

2012-04-23 Thread Peter Maydell
On 23 April 2012 00:31, Peter Chubb wrote: > Implement the timers on the FreeScale i.MX31 SoC. > This is not a complete implementation, but gives enough for > Linux to boot and run. In particular external triggers, which are > not useful under QEMU, are not implemented. Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-23 Thread MORITA Kazutaka
At Mon, 23 Apr 2012 08:08:46 +0200, Christoph Hellwig wrote: > > On Fri, Apr 20, 2012 at 12:15:36PM -0700, MORITA Kazutaka wrote: > > His patch sets the SD_FLAG_CMD_CACHE flag for writes only when the > > user selects cache=writeback or cache=none. If SD_FLAG_CMD_CACHE is > > not set in the reque

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-04-23 Thread Jan Kiszka
On 2012-04-23 16:48, Eduardo Habkost wrote: > Trying to summarize the points above: > > Groups (A) and (B) are: > > A) a feature that KVM supports and emulate by itself and can be enabled >by userspace blindly, without requiring any additional userspace >code to work. > B) a feature that

Re: [Qemu-devel] [PATCH] qapi: g_hash_table_find() instead of GHashTableIter.

2012-04-23 Thread Luiz Capitulino
On Sat, 21 Apr 2012 22:41:27 +0900 "NODA, Kai" wrote: > From: "NODA, Kai" > > GHashTableIter was first introduced in glib 2.16. > This patch removes it in favor of older g_hash_table_find() > for better compatibility with RHEL5. > > Signed-off-by: NODA, Kai Forgot to say this was applied, bu

Re: [Qemu-devel] [PATCH] fix BCD mask for date (Solaris 2.5 guest hang fix)

2012-04-23 Thread Artyom Tarasenko
On Mon, Apr 23, 2012 at 5:18 PM, Andreas Färber wrote: > Am 23.04.2012 16:48, schrieb Artyom Tarasenko: >> Fix BCD mask for date. The most visible effect of this patch is >> Solaris 2.5.1 doesn't hang at boot if the day of month is >21. >> >> Signed-off-by: Artyom Tarasenko >> --- >>  hw/m48t59.c

Re: [Qemu-devel] [PATCH 1/2] target-arm: Change cpu_arm_init() return type to ARMCPU

2012-04-23 Thread Peter Maydell
On 20 April 2012 18:39, Andreas Färber wrote: > Make cpu_arm_init() return a QOM ARMCPU, so that we don't need to > obtain an ARMCPU through arm_env_get_cpu() in machine init code. > This requires to adjust the inclusion site of cpu-qom.h and in turn, > forward-looking, to homogenize its include o

Re: [Qemu-devel] [PATCH] fix BCD mask for date (Solaris 2.5 guest hang fix)

2012-04-23 Thread Blue Swirl
On Mon, Apr 23, 2012 at 14:48, Artyom Tarasenko wrote: > Fix BCD mask for date. The most visible effect of this patch is > Solaris 2.5.1 doesn't hang at boot if the day of month is >21. Thanks, applied. > > Signed-off-by: Artyom Tarasenko > --- >  hw/m48t59.c |    6 +++--- >  1 files changed, 3

[Qemu-devel] [PATCH v4 1/4] target-sh4: QOM'ify CPU

2012-04-23 Thread Andreas Färber
Embed CPUSH4State as first member of SuperHCPU. Let CPUClass::reset() call cpu_state_reset() for now. Signed-off-by: Andreas Färber Reviewed-by: Peter Maydell --- Makefile.target|1 + target-sh4/cpu-qom.h | 70 target-sh4/cpu.c

[Qemu-devel] [PATCH v4 0/4] QOM'ify SuperH CPU

2012-04-23 Thread Andreas Färber
Hello, This series converts the SuperH CPU to QOM. Subclasses, the feature flags bugfix and its consequences throughout code as well as the controversial QOM'ification of the SH7750 SoC are postponed. I tested it using the sh-test-0.2 test image. Available at: git://github.com/afaerber/qemu-cpu.

[Qemu-devel] [PATCH v4 2/4] target-sh4: QOM'ify CPU reset

2012-04-23 Thread Andreas Färber
Move code from cpu_state_reset() to QOM superh_cpu_reset(). Signed-off-by: Andreas Färber Reviewed-by: Peter Maydell --- target-sh4/cpu.c | 21 - target-sh4/translate.c | 22 ++ 2 files changed, 22 insertions(+), 21 deletions(-) diff --git a/ta

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Xin Tong
I tried to insert a cdrom using this command. but when i go under the guest /dev/cdrom. i see nothing ./qemu-system-x86_64 -hda /home/xtong/qemu/qemu-0.14.1/x86_64-softmmu/debian_lenny_amd64_standard.qcow2 -cdrom /home/xtong/qemu/qemu-0.14.1/x86_64-softmmu/ubuntu-11.10-server-amd64.iso On Mon,

Re: [Qemu-devel] [PATCH 1/2] target-arm: Change cpu_arm_init() return type to ARMCPU

2012-04-23 Thread Andreas Färber
Am 23.04.2012 19:00, schrieb Peter Maydell: > On 20 April 2012 18:39, Andreas Färber wrote: >> Make cpu_arm_init() return a QOM ARMCPU, so that we don't need to >> obtain an ARMCPU through arm_env_get_cpu() in machine init code. >> This requires to adjust the inclusion site of cpu-qom.h and in tur

Re: [Qemu-devel] [PATCH] Bug fix for #986241: spell env correctly

2012-04-23 Thread Peter Portante
On Sun, Apr 22, 2012 at 3:56 PM, Andreas Färber wrote: > Am 20.04.2012 17:44, schrieb Peter Portante: > > Signed-off-by: Peter Portante > > Fix itself looks okay, but author, maintainer and qemu-ppc were missing > in CC, and a better commit message would be: > > ---8<--- > pseries: Fix use of gl

Re: [Qemu-devel] copy benchmarks onto qemu

2012-04-23 Thread Xin Tong
i also issued the change ide-cd0 /home/xtong/qemu/qemu-0.14.1/x86_64-softmmu/ubuntu-11.10-server-amd64.iso in the qemu montoring tool. where can i find the inserted cd rom in the guest os ? Xin On Mon, Apr 23, 2012 at 1:17 PM, Xin Tong wrote: > I tried to insert a cdrom using this command. but

  1   2   3   >