Re: [Qemu-devel] [PATCH 2/2] tcg/arm: Implement movcond_i32

2012-09-27 Thread Paolo Bonzini
Il 26/09/2012 20:48, Peter Maydell ha scritto: Implement movcond_i32 for ARM, as the sequence mov dst, v2 (implicitly done by the tcg common code) cmp c1, c2 movCC dst, v1 Should you make tcg/optimize.c prefer movcond a, a, b to movcond a, b, a, similar to commit c2b0e2f

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-27 Thread Bharata B Rao
On Wed, Sep 26, 2012 at 06:38:02PM +0200, Paolo Bonzini wrote: Il 26/09/2012 18:11, Bharata B Rao ha scritto: +static int parse_volume_options(GlusterConf *gconf, char *path) +{ +char *token, *saveptr; + +/* volname */ +token = strtok_r(path, /, saveptr); +

Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-27 Thread Michal Privoznik
On 26.09.2012 22:46, Anthony Liguori wrote: Michal Privoznik mpriv...@redhat.com writes: On 25.09.2012 19:08, Doug Goldstein wrote: On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012

Re: [Qemu-devel] [RFC PATCH 00/17] Support for multiple AIO contexts

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:48, schrieb Paolo Bonzini: Il 26/09/2012 16:31, Kevin Wolf ha scritto: In fact, after removing io_flush, I don't really see what makes AIO fd handlers special any more. Note that while the handlers aren't that special indeed, there is still some magic because

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 08:41, Bharata B Rao ha scritto: As you note, I don't need 2nd strtok strictly since the rest of the string is available in saveptr. But I thought using saveptr is not ideal or preferred. I wanted to use the most appropriate/safe delimiter to extract the image string in the

Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:15, Wenchao Xia ha scritto: 于 2012-9-19 17:57, Paolo Bonzini 写道: Il 19/09/2012 08:35, Wenchao Xia ha scritto: +QEMU_OBJS=$(tools-obj-y) $(block-obj-y) +QEMU_OBJS_FILTERED=$(filter %.o,$(QEMU_OBJS)) What does this filter out? $(block-obj-y) contains /block, which would

[Qemu-devel] [Bug 1056668] [NEW] qemu-system-arm crash at startup with -usbdevice

2012-09-27 Thread thierry bultel
Public bug reported: This happens with official 1.2.0 version, but I reproduce the same issue with the main git branch On my host: :~$ lsusb | grep Logi Bus 004 Device 002: ID 046d:c219 Logitech, Inc. Cordless RumblePad 2 :~$ qemu/arm-softmmu/qemu-system-arm -kernel output/images/uImage -initrd

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-27 Thread Thomas Huth
Am Wed, 26 Sep 2012 10:56:07 +0200 schrieb Alexander Graf ag...@suse.de: On 26.09.2012, at 03:18, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 26, 2012 at 03:03:10AM +0200, Alexander Graf wrote: [snip] spapr-nvram: if (!drive || checksum_is_bad(drive))

Re: [Qemu-devel] [RFC PATCH 00/17] Support for multiple AIO contexts

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 09:11, Kevin Wolf ha scritto: Am 26.09.2012 17:48, schrieb Paolo Bonzini: Il 26/09/2012 16:31, Kevin Wolf ha scritto: In fact, after removing io_flush, I don't really see what makes AIO fd handlers special any more. Note that while the handlers aren't that special indeed,

[Qemu-devel] [PATCH 3/3] vga: remove CONFIG_BOCHS_VBE

2012-09-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga.c | 34 +- hw/vga_int.h | 28 +++- 2 files changed, 12 insertions(+), 50 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 053f89d..679cabc 100644 --- a/hw/vga.c +++

[Qemu-devel] [PATCH 1/3] vga: add mmio bar to standard vga

2012-09-27 Thread Gerd Hoffmann
This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc_piix.c |4 ++ hw/vga-pci.c | 108

[Qemu-devel] [PATCH 0/3] vga: add mmio bar

2012-09-27 Thread Gerd Hoffmann
Hi, This patch series adds a mmio bar to the standard vga. It also drops a file into docs/specs/ describing the mmio bar and the other properties of the qemu standard vga and does a little cleanup by removing CONFIG_BOCHS_VBE. cheers, Gerd Gerd Hoffmann (3): vga: add mmio bar to standard

[Qemu-devel] [PATCH 2/3] vga: add specs for standard vga

2012-09-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/standard-vga.txt | 64 +++ hw/vga-isa.c|2 + hw/vga-pci.c|2 + 3 files changed, 68 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] [Qemu-ppc] [0/6] Pending pseries updates

2012-09-27 Thread Alexander Graf
On 27.09.2012, at 01:31, David Gibson d...@au1.ibm.com wrote: On Wed, Sep 26, 2012 at 02:59:25PM +0200, Alexander Graf wrote: On 26.09.2012, at 05:12, David Gibson wrote: Hi Alex, Here's another batch of updates for pseries, some of which affect wider target-ppc code. I have sent a

Re: [Qemu-devel] [PATCH V4 1/5] libqblock build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:23, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and

Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:23, Wenchao Xia ha scritto: This patch contains type and macro defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- libqblock/libqblock-internal.h | 57 +

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-27 Thread Bharata B Rao
On Thu, Sep 27, 2012 at 09:19:34AM +0200, Paolo Bonzini wrote: For gluster://server/volnamepath/to/image, the image is extracted as //path/to/image. Should there be three /'s here? I assume it's just a typo. Yes it was a typo. I'm concerned that there is no documentation of

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:24, Wenchao Xia ha scritto: +#libqblock +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y)) I don't think you need qtest-obj-y for anything. +libqblock-la-path = $(libqblock-lib-path)/$(libqblock-lib-la) +

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 10:28, Bharata B Rao ha scritto: How would the URIs look like? gluster://server/testvol//dir/a.img ? Isn't this a valid URI ? Here volname=testvol and image=/dir/a.img. It is, but I think it would be canonicalized to gluster://server/testvol/dir/a.img. If that's valid and

[Qemu-devel] [Bug 1056668] Re: qemu-system-arm crash at startup with -usbdevice

2012-09-27 Thread Peter Maydell
Well, it's certainly a bug that we crash (and I'll look into that). However, the vexpress-a9 model does not have any USB controller, so a fix for this bug would just make us print a nicer error message instead of crashing... -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-09-27 Thread Avi Kivity
On 09/24/2012 01:11 PM, Paolo Bonzini wrote: A better plan would be to incorporate this code into glib, completing the extremely sparse URI support that is already there. However, we would not be able to use it anyway, because we support compiling on old glib versions. If the same (or very

Re: [Qemu-devel] [PATCH v9 2/4] qemu: URI parsing library

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:03, Avi Kivity ha scritto: On 09/24/2012 01:11 PM, Paolo Bonzini wrote: A better plan would be to incorporate this code into glib, completing the extremely sparse URI support that is already there. However, we would not be able to use it anyway, because we support

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Avi Kivity
On 09/27/2012 05:13 AM, liu ping fan wrote: On Mon, Sep 24, 2012 at 5:42 PM, Avi Kivity a...@redhat.com wrote: On 09/24/2012 10:32 AM, liu ping fan wrote: On Mon, Sep 24, 2012 at 3:44 PM, Avi Kivity a...@redhat.com wrote: On 09/24/2012 08:33 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at

Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex

2012-09-27 Thread Avi Kivity
On 09/26/2012 10:25 PM, Luiz Capitulino wrote: o v3 - doc log fixups - rename KeyCode.hex to KeyCode.number This actually fixes a regression introduced by the qapi conversion, please refer to patch 2/3 for details. It's also important to note that this series changes the QMP

Re: [Qemu-devel] [PATCH v2 07/45] qmp: add block-job-pause and block-job-resume

2012-09-27 Thread Paolo Bonzini
Il 26/09/2012 19:45, Eric Blake ha scritto: @@ -1855,12 +1855,55 @@ # # @device: the device name # +# @force: #optional whether to allow cancellation of a paused job (default false) +# Do we need (since 1.3) designation on this argument? Yes. Paolo

Re: [Qemu-devel] [PATCH v2 11/45] iostatus: move BlockdevOnError declaration to QAPI

2012-09-27 Thread Paolo Bonzini
Il 26/09/2012 19:54, Eric Blake ha scritto: +# +# @stop: for guest operations, stop the virtual machine; +#for jobs, pause the job +# +# @enospc: same as @stop on ENOSPC, same as @report otherwise. +# +# Since: 1.3 +## +{ 'enum': 'BlockdevOnError', + 'data': ['report',

Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error

2012-09-27 Thread Paolo Bonzini
Il 26/09/2012 21:10, Eric Blake ha scritto: +- device: device name (json-string) +- operation: I/O operation (json-string, read or write) For symmetry with BLOCK_JOB_{CANCELLED,COMPLETED}, you also need: - type: Job type (stream for image streaming, json-string) Libvirt would like to

Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 02:01, Eric Blake ha scritto: +{ event: BLOCK_JOB_READY, +data: { device: ide0-hd1, + operation: write, + action: stop }, You didn't document operation and action; are you missing documentation for this event, or are they bad copy-and-paste in

Re: [Qemu-devel] [PATCH v2 35/45] add hierarchical bitmap data type and test cases

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 04:53, Eric Blake ha scritto: +++ b/hbitmap.c @@ -0,0 +1,400 @@ +/* + * Hierarchical Bitmap Data Type + * + * Copyright Red Hat, Inc., 2012 vs. +++ b/tests/test-hbitmap.c @@ -0,0 +1,408 @@ +/* + * Hierarchical bitmap unit-tests. + * + * Copyright (C) 2012

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:16, Avi Kivity ha scritto: needs to be a little more complicated. After translation, we need to look up the address again in a different phys_map. So a MemoryRegion that is an iommu needs to hold its own phys_map pointer for the lookup. But let's ignore the problem for

Re: [Qemu-devel] [PATCH v4 1/3] rtl8139: implement 8139cp link status

2012-09-27 Thread Stefan Hajnoczi
On Mon, Sep 17, 2012 at 3:25 AM, Amos Kong ak...@redhat.com wrote: From: Jason Wang jasow...@redhat.com Add a link status chang callback and change the link status bit in BMSR MSR accordingly. Tested in Linux/Windows guests. The link status bit of MediaStatus is infered from

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Alexander Graf
On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at 14:51 +0530, Avik Sil wrote: Hi, We would like to get a method to boot from devices provided in -boot arguments in qemu when the 'boot-device' is set in nvram for pseries machine. I mean the boot device

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Avi Kivity
On 09/27/2012 11:29 AM, Paolo Bonzini wrote: virtio-net is per-spec not going through the iommu. What's that smell? A feature bit? -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Benjamin Herrenschmidt
On Thu, 2012-09-27 at 11:33 +0200, Alexander Graf wrote: I think the command line should override anything user specified. So basically: * user defined -boot option (or bootindex magic from Gleb) * nvram * fallback to default Eventually we should try to implement some sort of

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:34, Avi Kivity ha scritto: virtio-net is per-spec not going through the iommu. What's that smell? A feature bit? Why is it a bad thing that it does not go through the iommu? Paolo

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Alexander Graf
On 27.09.2012, at 11:35, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at 11:33 +0200, Alexander Graf wrote: I think the command line should override anything user specified. So basically: * user defined -boot option (or bootindex magic from Gleb) * nvram * fallback to default

Re: [Qemu-devel] [PATCH V4 1/5] libqblock build system

2012-09-27 Thread Wenchao Xia
Ok, I'll correct them. Il 27/09/2012 04:23, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones

Re: [Qemu-devel] [Bug 1056668] Re: qemu-system-arm crash at startup with -usbdevice

2012-09-27 Thread thierry bultel
Le 27/09/2012 10:47, Peter Maydell a écrit : Well, it's certainly a bug that we crash (and I'll look into that). However, the vexpress-a9 model does not have any USB controller, so a fix for this bug would just make us print a nicer error message instead of crashing... Yes indeed, is there

Re: [Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify

2012-09-27 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: The current code duplicates the QKeyCodeList keys in order to store the key values for release_keys() late run. This is a bit complicated though, as we have to care about correct ordering and then release_keys() will have to index key_defs[] over

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Gleb Natapov
On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at 14:51 +0530, Avik Sil wrote: Hi, We would like to get a method to boot from devices provided in -boot arguments in qemu when the

Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines

2012-09-27 Thread Wenchao Xia
I will change the code for most of comments, but have some response below. Il 27/09/2012 04:23, Wenchao Xia ha scritto: This patch contains type and macro defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Wenchao Xia
于 2012-9-27 16:30, Paolo Bonzini 写道: Il 27/09/2012 04:24, Wenchao Xia ha scritto: +#libqblock +LIBQBLOCK_TEST_DIR=$(SRC_PATH)/tests/libqblock/test_images +qtest-lib-y=$(patsubst %.o, %.lo,$(qtest-obj-y)) I don't think you need qtest-obj-y for anything. OK, I will remove it.

Re: [Qemu-devel] [PATCH v3] qemu/xen: Add 64 bits big bar support on qemu

2012-09-27 Thread Stefano Stabellini
On Thu, 27 Sep 2012, Xudong Hao wrote: v3 changes from v2: - Refine code following by the qemu code style - As suggestion by Stefano, cheanup code, add some code comment v2 changes from v1: - Rebase to qemu upstream from qemu-xen Currently it is assumed PCI device BAR access 4G memory.

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Avi Kivity
On 09/27/2012 11:36 AM, Paolo Bonzini wrote: Il 27/09/2012 11:34, Avi Kivity ha scritto: virtio-net is per-spec not going through the iommu. What's that smell? A feature bit? Why is it a bad thing that it does not go through the iommu? You can't assign the device to nested guests or to

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Gleb Natapov
On Thu, Sep 27, 2012 at 03:35:53PM +0530, Nikunj A Dadhania wrote: On Thu, 27 Sep 2012 11:51:36 +0200, Gleb Natapov g...@redhat.com wrote: On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at

Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:52, Wenchao Xia ha scritto: Please use QBO_ instead of QB_ throughout. Also write COMPAT instead of CPT, and remove CPT_NONE since 0.10 is the default: __NONE is used to indicate whether this property is set or get, so it is actually have 3 status than just 2: Not set,

Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 11:56, Wenchao Xia ha scritto: +$(LIBQBLOCK_TEST_DIR): +@echo Make libqblock test directory +mkdir $(LIBQBLOCK_TEST_DIR) You can leave the files in tests/ directly, and avoid this as well. Having a new directory will make clean easier, otherwise the script will need

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Benjamin Herrenschmidt
On Thu, 2012-09-27 at 11:51 +0200, Gleb Natapov wrote: Yes, forget about -boot. It is deprecated :) You should use bootindex (device property) to set boot priority. It constructs OF device path and passes it to firmware. There is nothing blurry about OF device path. Of course it is ;-) They

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 12:08, Avi Kivity ha scritto: virtio-net is per-spec not going through the iommu. What's that smell? A feature bit? Why is it a bad thing that it does not go through the iommu? You can't assign the device to nested guests or to guest userspace via vfio. Some guests may

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Gleb Natapov
On Thu, Sep 27, 2012 at 08:21:43PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at 11:51 +0200, Gleb Natapov wrote: Yes, forget about -boot. It is deprecated :) You should use bootindex (device property) to set boot priority. It constructs OF device path and passes it to

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-09-27 Thread Gleb Natapov
On Thu, Sep 27, 2012 at 04:04:54PM +0530, Nikunj A Dadhania wrote: On Thu, 27 Sep 2012 12:13:05 +0200, Gleb Natapov g...@redhat.com wrote: On Thu, Sep 27, 2012 at 03:35:53PM +0530, Nikunj A Dadhania wrote: If the user does not set bootindex, qemu would decide the bootindex? No.

[Qemu-devel] [Bug 1056668] Re: qemu-system-arm crash at startup with -usbdevice

2012-09-27 Thread Peter Maydell
I'm afraid not -- there isn't currently any A9 model with either USB or PCI (for plugging in a PCI usb controller). (There are a few models of boards where the hardware has a USB controller but we don't have a model of it, including the vexpress-a9, but that doesn't help unless anybody writes the

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-27 Thread Avi Kivity
On 09/27/2012 12:22 PM, Paolo Bonzini wrote: Il 27/09/2012 12:08, Avi Kivity ha scritto: virtio-net is per-spec not going through the iommu. What's that smell? A feature bit? Why is it a bad thing that it does not go through the iommu? You can't assign the device to nested guests or to

[Qemu-devel] [PATCH V4 3/5] exec: Introduce helper to set dirty flags.

2012-09-27 Thread Anthony PERARD
This new helper/hook is used in the next patch to add an extra call in a single place. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Reviewed-by: Avi Kivity a...@redhat.com --- exec.c | 52 +--- 1 file changed, 17 insertions(+), 35

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-09-27 Thread Karl-Michael Schindler
I tried another approach in my patch for the package in fink on Mac OS X. Since dyngen-exec.h seems to be the only place with a GLOBAL register variable, I removed register from the variable declaration. So far, it seems to work. Regarding an impact on performance, I have no information. Has

[Qemu-devel] [PATCH V4 5/5] xen: Set the vram dirty when an error occur.

2012-09-27 Thread Anthony PERARD
If the call to xc_hvm_track_dirty_vram() fails, then we set dirtybit on all the video ram. This case happens during migration. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- xen-all.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen-all.c b/xen-all.c index

[Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory.

2012-09-27 Thread Anthony PERARD
This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- exec.c | 1 + memory.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/exec.c b/exec.c index 366684c..1114a09 100644 --- a/exec.c

[Qemu-devel] [PATCH V4 1/5] QMP, Introduce xen-set-global-dirty-log command.

2012-09-27 Thread Anthony PERARD
This command is used during a migration of a guest under Xen. It calls memory_global_dirty_log_start or memory_global_dirty_log_stop according to the argument pass to the command. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com ---

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-09-27 Thread Peter Maydell
I removed register from the variable declaration That is going to be badly broken somewhere along the line for at least some CPU targets: don't try to ship that! This is all fixed properly in git master (because Blue Swirl committed a lot of patches that let us finally drop the need for that

[Qemu-devel] [PATCH V4 2/5] xen: Introduce xen_modified_memory.

2012-09-27 Thread Anthony PERARD
This function is to be used during live migration. Every write access to the guest memory should call this funcion so the Xen tools knows which pages are dirty. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen.h | 1 + xen-all.c | 21 + xen-stub.c | 4

[Qemu-devel] [PATCH V4 0/5] Xen, introducing dirty log for migration.

2012-09-27 Thread Anthony PERARD
Hi, This patch set will fix live migration under Xen. For this I introduce a new QMP command to switch global-dirty log and few calls (in exec.c and memory.c) to xen set_dirty function. Change since v3: - Coding style of patch 2 - Reword last patch comment Change since v2: - renamed

Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex

2012-09-27 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Before the qapi conversion, the sendkey command could be used to send key codes in hex directly to the guest. In HMP, this would be like: (qemu) sendkey 0xdc However, the qapi conversion broke this, as it only supports sending QKeyCode

Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex

2012-09-27 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: o v3 - doc log fixups - rename KeyCode.hex to KeyCode.number This actually fixes a regression introduced by the qapi conversion, please refer to patch 2/3 for details. It's also important to note that this series changes the QMP

Re: [Qemu-devel] [RFC v2 1/7] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 07:14, Dong Xu Wang ha scritto: Call qemu_opt_set() instead of duplicating opt_set(). It will set opt-str in qemu_opt_set_bool, without opt-str, there will be some potential bugs. These are uses of opt-str, and what happens when it isn't set: * qemu_opt_get(): returns

Re: [Qemu-devel] [PATCH v2 02/45] blockdev: rename block_stream_cb to a generic block_job_cb

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: From: Jeff Cody jc...@redhat.com Signed-off-by: Jeff Cody jc...@redhat.com This should also be signed off by you, not only by Jeff. Kevin

Re: [Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 07:14, Dong Xu Wang ha scritto: +int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val) +{ +char buffer[1024]; +snprintf(buffer, sizeof(buffer), % PRId64, val); +return qemu_opt_set(opts, name, buffer); +} This has the same problem as

Re: [Qemu-devel] [PATCH v2 0/3] qmp/hmp: dump-guest-memory fixes

2012-09-27 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: Please, check individual patches for details. Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [RFC v2 7/7] remove QEMUOptionParameter

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 07:14, Dong Xu Wang ha scritto: remove QEMUOptionParameter, and use QemuOpts and QemuOptsList. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block.c | 88 ++-- block.h |5 +- block/Makefile.objs |9 +- block/qcow2.c

Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: Do this in a separate commit before we move the functions to blockjob.h. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: split out of the next patch block_int.h | 4 ++-- 1 file modificato, 2 inserzioni(+), 2 rimozioni(-)

[Qemu-devel] [PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2

2012-09-27 Thread Mel Gorman
The clearing of PG_migrate_skip potentially takes a long time if the zone is massive. Be safe and check if it needs to reschedule. This is a fix for mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated.patch Signed-off-by: Mel Gorman mgor...@suse.de --- mm/compaction.c |

Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 14:03, Kevin Wolf ha scritto: /** - * block_job_cancel: + * block_job_cancel_sync: * @job: The job to be canceled. * - * Asynchronously cancel the job and wait for it to reach a quiescent + * Synchronously cancel the job and wait for it to reach a quiescent *

Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex

2012-09-27 Thread Luiz Capitulino
On Thu, 27 Sep 2012 11:19:58 +0200 Avi Kivity a...@redhat.com wrote: On 09/26/2012 10:25 PM, Luiz Capitulino wrote: o v3 - doc log fixups - rename KeyCode.hex to KeyCode.number This actually fixes a regression introduced by the qapi conversion, please refer to patch 2/3 for

Re: [Qemu-devel] [PATCH v2 03/45] block: fix documentation of block_job_cancel_sync

2012-09-27 Thread Kevin Wolf
Am 27.09.2012 14:08, schrieb Paolo Bonzini: Il 27/09/2012 14:03, Kevin Wolf ha scritto: /** - * block_job_cancel: + * block_job_cancel_sync: * @job: The job to be canceled. * - * Asynchronously cancel the job and wait for it to reach a quiescent + * Synchronously cancel the job and

Re: [Qemu-devel] [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-27 Thread Mel Gorman
On Wed, Sep 26, 2012 at 09:49:30AM +0900, Minchan Kim wrote: On Tue, Sep 25, 2012 at 10:12:07AM +0100, Mel Gorman wrote: On Mon, Sep 24, 2012 at 02:26:44PM -0700, Andrew Morton wrote: On Mon, 24 Sep 2012 10:39:38 +0100 Mel Gorman mgor...@suse.de wrote: On Fri, Sep 21, 2012 at

Re: [Qemu-devel] [Qemu-ppc] [0/6] Pending pseries updates

2012-09-27 Thread David Gibson
On Thu, Sep 27, 2012 at 10:05:48AM +0200, Alexander Graf wrote: On 27.09.2012, at 01:31, David Gibson d...@au1.ibm.com wrote: On Wed, Sep 26, 2012 at 02:59:25PM +0200, Alexander Graf wrote: On 26.09.2012, at 05:12, David Gibson wrote: Hi Alex, Here's another batch of

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: Job pausing reuses the existing support for cancellable sleeps. A pause happens at the next sleeping point and lasts until the coroutine is re-entered explicitly. Cancellation was already doing a forced resume, so implement it explicitly in terms

[Qemu-devel] [PATCH 0/3] console cleanup patches

2012-09-27 Thread Gerd Hoffmann
Hi, Initial small console cleanup patches, broken out of the fbdev patch series. cheers, Gerd Gerd Hoffmann (3): console: QLIST-ify display change listeners. console: add unregister_displaychangelistener console: move set_mouse + cursor_define callbacks console.c |2 +-

[Qemu-devel] [PATCH 2/3] console: add unregister_displaychangelistener

2012-09-27 Thread Gerd Hoffmann
Also change the way the gui_timer is initialized: each time a displaychangelistener is registered or unregistered we'll check whenever we need a timer (due to dpy_refresh callback being present) and if so setup a timer, otherwise zap it. This way the gui timer works correctly with

[Qemu-devel] [PATCH 3/3] console: move set_mouse + cursor_define callbacks

2012-09-27 Thread Gerd Hoffmann
When adding DisplayChangeListeners the set_mouse and cursor_define callbacks have been left in DisplayState for some reason. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |2 +- console.h | 39 +++ hw/jazz_led.c

[Qemu-devel] [PATCH 1/3] console: QLIST-ify display change listeners.

2012-09-27 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h | 72 +++ hw/xenfb.c |2 +- vl.c |9 ++- 3 files changed, 42 insertions(+), 41 deletions(-) diff --git a/console.h b/console.h index f990684..646ad4b 100644

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 14:18, Kevin Wolf ha scritto: Signed-off-by: Paolo Bonzini pbonz...@redhat.com I think there's a problem with terminology at least. What does paused really mean? Is it that the job has been requested to pause, or that it has actually yielded and is inactive? The commit

Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete to block_job_completed

2012-09-27 Thread Kevin Wolf
Am 26.09.2012 17:56, schrieb Paolo Bonzini: The imperative will be used for the QMP command. Signed-off-by: Paolo Bonzini pbonz...@redhat.com I would still be glad if we found a better name. Having two functions block_job_complete() and block_job_completed() sounds like a great source for

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Kevin Wolf
Am 27.09.2012 14:27, schrieb Paolo Bonzini: Il 27/09/2012 14:18, Kevin Wolf ha scritto: Signed-off-by: Paolo Bonzini pbonz...@redhat.com I think there's a problem with terminology at least. What does paused really mean? Is it that the job has been requested to pause, or that it has actually

Re: [Qemu-devel] [PATCH] block: live snapshot documentation tweaks

2012-09-27 Thread Luiz Capitulino
On Wed, 26 Sep 2012 16:34:29 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com Applied to the qmp branch, thanks. --- qapi-schema.json | 4 ++-- 1 file modificato, 2 inserzioni(+), 2 rimozioni(-) diff --git a/qapi-schema.json

Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex

2012-09-27 Thread Luiz Capitulino
On Thu, 27 Sep 2012 13:42:57 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Before the qapi conversion, the sendkey command could be used to send key codes in hex directly to the guest. In HMP, this would be like: (qemu) sendkey 0xdc

Re: [Qemu-devel] [PATCH v2 06/45] block: add support for job pause/resume

2012-09-27 Thread Paolo Bonzini
Il 27/09/2012 14:45, Kevin Wolf ha scritto: Am 27.09.2012 14:27, schrieb Paolo Bonzini: Il 27/09/2012 14:18, Kevin Wolf ha scritto: Signed-off-by: Paolo Bonzini pbonz...@redhat.com I think there's a problem with terminology at least. What does paused really mean? Is it that the job has been

Re: [Qemu-devel] [PATCH 1/2] tcg/arm: Factor out code to emit immediate or reg-reg op

2012-09-27 Thread Peter Maydell
On 26 September 2012 20:46, Peter Maydell peter.mayd...@linaro.org wrote: On 26 September 2012 20:01, Richard Henderson r...@twiddle.net wrote: The patch itself is fine. But as a followup, if movcc is no longer free, then perhaps the setcond sequence is better as cmp mov

Re: [Qemu-devel] [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

2012-09-27 Thread Mel Gorman
On Tue, Sep 25, 2012 at 01:03:52PM -0700, Andrew Morton wrote: On Tue, 25 Sep 2012 10:12:07 +0100 Mel Gorman mgor...@suse.de wrote: First, we'd introduce a variant of get_pageblock_migratetype() that returns all the bits for the pageblock flags and then helpers to extract either the

[Qemu-devel] [PATCH v9 03/14] target-mips-ase-dsp: Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number

2012-09-27 Thread Jia Liu
Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number. Signed-off-by: Jia Liu pro...@gmail.com --- target-mips/translate.c | 122 --- 1 file changed, 95 insertions(+), 27 deletions(-) diff --git a/target-mips/translate.c

[Qemu-devel] [PATCH v9 01/14] target-mips-ase-dsp: Add internal funtions

2012-09-27 Thread Jia Liu
Add internal functions using by MIPS ASE DSP instructions. Signed-off-by: Jia Liu pro...@gmail.com --- target-mips/Makefile.objs |2 +- target-mips/dsp_helper.c | 1121 + 2 files changed, 1122 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PATCH v9 10/14] target-mips-ase-dsp: Add compare-pick instructions

2012-09-27 Thread Jia Liu
Add MIPS ASE DSP Compare-Pick instructions. Signed-off-by: Jia Liu pro...@gmail.com --- target-mips/dsp_helper.c | 235 ++ target-mips/helper.h | 52 +++ target-mips/translate.c | 356 ++ 3 files changed, 643

[Qemu-devel] [PATCH v9 14/14] target-mips-ase-dsp: Change TODO file

2012-09-27 Thread Jia Liu
Delete DSP r1 DSP r2 from TODO file. Signed-off-by: Jia Liu pro...@gmail.com --- target-mips/TODO |2 -- 1 file changed, 2 deletions(-) diff --git a/target-mips/TODO b/target-mips/TODO index 2a3546f..15d67cd 100644 --- a/target-mips/TODO +++ b/target-mips/TODO @@ -6,8 +6,6 @@ General -

[Qemu-devel] [PULL 00/15]: QMP queue

2012-09-27 Thread Luiz Capitulino
The changes (since ac05f3492421caeb05809ffa02c6198ede179e43) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (7): qapi: convert add_client qmp: dump-guest-memory: improve schema doc (again) qmp: dump-guest-memory: don't spin

[Qemu-devel] [PULL 03/15] Add qemu-ga-client script

2012-09-27 Thread Luiz Capitulino
From: Ryota Ozaki ozaki.ry...@gmail.com This is an easy-to-use QEMU guest agent client written in Python. It simply provides commands to call guest agent functions like ping, fsfreeze and shutdown. Additionally, it provides extra useful commands, e.g, cat, ifconfig and reboot, by using guet agent

[Qemu-devel] [PULL 12/15] input: qmp_send_key(): simplify

2012-09-27 Thread Luiz Capitulino
The current code duplicates the QKeyCodeList keys in order to store the key values for release_keys() late run. This is a bit complicated though, as we have to care about correct ordering and then release_keys() will have to index key_defs[] over again. Switch to an array of integers, which is

[Qemu-devel] [PULL 15/15] block: live snapshot documentation tweaks

2012-09-27 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 28d8815..f4c2185

[Qemu-devel] [PULL 06/15] pci-assign: use monitor_handle_fd_param

2012-09-27 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com There is no need to open-code the choice between a file descriptor number or a named one. Just use monitor_handle_fd_param, which also takes care of printing the error message. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Luiz

[Qemu-devel] [PULL 01/15] Make negotiation optional in QEMUMonitorProtocol

2012-09-27 Thread Luiz Capitulino
From: Ryota Ozaki ozaki.ry...@gmail.com This is a preparation for qemu-ga-client which uses QEMUMonitorProtocol class. The class tries to negotiate capabilities on connect, however, qemu-ga doesn't suppose it and fails. This change makes the negotiation optional, though it's still performed by

[Qemu-devel] [PULL 04/15] qapi: do not protect enum values from namespace pollution

2012-09-27 Thread Luiz Capitulino
From: Paolo Bonzini pbonz...@redhat.com Enum values are always preceded by the uppercase name of the enum, so they do not conflict with reserved words. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py | 4 ++--

[Qemu-devel] [PULL 11/15] hmp: dump-guest-memory: hardcode protocol argument to file:

2012-09-27 Thread Luiz Capitulino
Today, it's necessary to specify the protocol you want to use when dumping the guest memory, for example: (qemu) dump-guest-memory file:/tmp/guest-memory This has a few issues: 1. It's cumbersome to type 2. We loose file path autocompletion 3. Being able to specify fd:X in HMP makes little

  1   2   3   4   5   >