Re: [Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 20:06, Luiz Capitulino ha scritto: +if (ret 0 || local_err) { +if (!local_err) { +error_set_errno(errp, -ret, QERR_UNDEFINED_ERROR); Two problems here. First, ret usually is not -errno. If we really want to use it here (I think this is great

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 20:24, Luiz Capitulino ha scritto: That DPRINTF() usage is really bizarre, it seems its purpose is to report an error to the user, but that's a debugging call. I'd let it there and replace it later with proper tracing code, but that's quite minor for me. Please, at least

Re: [Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 22:08, Luiz Capitulino ha scritto: On Wed, 3 Oct 2012 16:36:58 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Before: $ qemu-system-x86_64 nbd:localhost:12345 inet_connect_opts: connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345): Connection refused

Re: [Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 22:29, Luiz Capitulino ha scritto: On Wed, 3 Oct 2012 16:37:00 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Before: $ qemu-system-x86_64 -vnc foo.bar:12345 getaddrinfo(foo.bar,18245): Name or service not known Failed to start VNC server on `foo.bar:12345'

Re: [Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 08:28, Paolo Bonzini ha scritto: void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) diff --git a/vl.c b/vl.c index 53917c9..45a5ba5 100644 --- a/vl.c +++ b/vl.c @@ -3692,8 +3692,11 @@ int main(int argc, char **argv, char **envp) #ifdef CONFIG_VNC /*

Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller

2012-10-05 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Thursday, October 04, 2012 9:37 PM To: Bhushan Bharat-R65777 Cc: Avi Kivity; qemu-devel@nongnu.org; qemu-...@nongnu.org Subject: Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller On 04.10.2012,

Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:31, Søren Sandmann ha scritto: No, that's not possible. The revision must be the same for all machines started with the same -M argument. So your only choice is to make 0.12 a requirement for QEMU 1.3. Then you can use compatibility properties (see the long list of

Re: [Qemu-devel] [PATCH] Require spice-server 0.12.0 and spice-protocol 0.12.2

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:37, Søren Sandmann ha scritto: From: Søren Sandmann Pedersen s...@redhat.com Set the default PCI revision to QXL_REVISION_STABLE_V12, and remove the various #ifs on various subversions of spice-server 0.11.x. Also set the revision to 3 for the PC 1.2 machine for

Re: [Qemu-devel] [Bug 1060928] [NEW] Error in launch virtual server port

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 12:57:32PM -, javier navarro altimira wrote: --- .- script bash launcher #!/bin/bash qemu-system-i386 -m 128 -display sdl -cpu pentium \ -k es \ -net nic,vlan=0,macaddr=52:54:00:12:02:04,model=pcnet \ -net

Re: [Qemu-devel] [PATCH v3 09/22] qapi: QmpOutputVisitor, implement array handling

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: } +static void qmp_output_start_carray(Visitor *v, void **obj, const char *name, +size_t elem_count, size_t elem_size, +Error **errp) +{ +qmp_output_start_list(v,

Re: [Qemu-devel] Qcow2 allocate and free cluster

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 21, 2012 at 11:15:42AM +0530, Gaurab Basu wrote: My question is how the clusters are allocated. What I have understood, it maintains a free_cluster_index to manage which host clusters are free. In the function update_refcount(), if a cluster is freed it makes the free_cluster_index

Re: [Qemu-devel] [PATCH v3 07/22] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: +elif argentry.has_key('embedded struct'): Just embedded perhaps? Paolo +tmp_ptr_name = %s_%s_ptr % (c_var(field_prefix).replace(., ), c_var(argname)) +ret += mcgen(''' +%(type)s

Re: [Qemu-devel] [PATCH v3 05/22] qapi: qapi_visit.py, support arrays and complex qapi definitions

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: Add support for arrays in the code generators. Complex field descriptions can now be used to provide additional information to the visitor generators, such as the max size of an array, or the field within a struct to use to determine how many

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: For the serial number decreasing issue, I think there's only these two ways to select, there's no ideal way to resolve this issue. My use case for this is for the kdump kernel to find proper disks, after 1st kernel crashing 2nd kernel

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to kvm if the host supports it

2012-10-05 Thread Peter Maydell
On 5 October 2012 03:24, Alexander Graf ag...@suse.de wrote: On 05.10.2012, at 04:17, Anthony Liguori wrote: Alexander Graf ag...@suse.de writes: We get similar problems on PPC. Take the following example: $ qemu-system-ppc -M mpc8544ds -kernel uImage -nographic But do you really expect

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: +#define QIDL_SCHEMA_ADD_LINK(name, obj, path, errp) \ +g_assert(qidl_data_##name.schema_obj); \ +object_property_add_link(obj, path, container, \ Why container as the type? Paolo +

Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build infrastructure

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: + +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py qidl.py qidl_parser.py qapi.py qapi_visit.py) + $(call rm -f $(*D)/qidl-generated/$(*F).qidl.c) + $(if $(strip $(shell grep QIDL_ENABLE() $ 1/dev/null echo

Re: [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: These patches are based are origin/master, and can also be obtained from: git://github.com/mdroth/qemu.git qidl-base-v3 Changes since v2: - Documentations fix-ups and clarifications (Eric) - Moved annotations in front of variable names and

[Qemu-devel] [PATCH] fsdev: Don't ignore setfsuid/setfsgid return values

2012-10-05 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com In current implementation of setfsuid/setfsgid there is no way to know if it failed by checking the return value. This patch assumes setfsuid/setfsgid returns -1 in case of error. Eventually kernel code needs to be fixed. Signed-off-by: M. Mohan Kumar

Re: [Qemu-devel] List of Virtualized IO devices - QEMU

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 30, 2012 at 08:52:02PM -0500, Krishna Kumaar Natarajan wrote: Where can I find the list of IO devices virtualized for QEMU ? Your question is very general. In the source tree you'll find *emulated* devices in hw/. On the command-line you can do: $ qemu-system-x86_64 -device \?

Re: [Qemu-devel] [PATCH 04/14] qdev: allow multiple qdev_init_gpio_in() calls

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs

Re: [Qemu-devel] [PATCH 04/18] qemu-sockets: add nonblocking connect for Unix sockets

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:38, Luiz Capitulino ha scritto: On Wed, 3 Oct 2012 16:36:51 +0200 Paolo Bonzini pbonz...@redhat.com wrote: This looks like a bug fix, because if is_waitconnect==false unix_connect_opts() shouldn't block. Am I right? It could be a start, but it doesn't fix it yet.

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-05 Thread Benjamin Herrenschmidt
On Fri, 2012-10-05 at 02:43 +0200, Alexander Graf wrote: We should also be able to get the raw bootindex values for a qdev, yes? I was thinking we could instead copy those values into the device tree when we populate it. The trouble is that we don't actually generate (in qemu) nodes for

[Qemu-devel] [RFC] Starting a (secondary) CPU when it is halted or reset

2012-10-05 Thread Ronald Hecht
Hello all, I have a question regarding LEON SPARC SMP. In a LEON SPARC SMP system secondary CPUs (others that CPU#0) can be started by setting certain bits in the interrupt controller. At startup (reset) all CPUs are halted except CPU#0. In QEMU version 0.12 it was possible to simply set

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Fix BAT put

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 05:29, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Oct 05, 2012 at 04:36:46AM +0200, Alexander Graf wrote: In the sregs API, upper and lower 32bit segments of the BAT registers are swapped when doing a set. Since we need to support old kernels out there, don't

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 11:12, Benjamin Herrenschmidt b...@au1.ibm.com wrote: On Fri, 2012-10-05 at 02:43 +0200, Alexander Graf wrote: We should also be able to get the raw bootindex values for a qdev, yes? I was thinking we could instead copy those values into the device tree when we populate

Re: [Qemu-devel] [RFC] Starting a (secondary) CPU when it is halted or reset

2012-10-05 Thread Jan Kiszka
On 2012-10-05 11:28, Ronald Hecht wrote: Hello all, I have a question regarding LEON SPARC SMP. In a LEON SPARC SMP system secondary CPUs (others that CPU#0) can be started by setting certain bits in the interrupt controller. At startup (reset) all CPUs are halted except CPU#0. In QEMU

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread wenchao xia
于 2012-10-3 20:21, Paolo Bonzini 写道: Il 03/10/2012 13:31, wenchao xia ha scritto: +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) +{ +return info-member_addr-virt_size; Please change this to: QBlockStaticInfoAddr addrs; qb_setup_info_addr(info, addrs);

Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 13:20, wenchao xia ha scritto: Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see what it really is. It is actually defined in internal header files. Yes, but even the type should be hidden. It should be purely an implementation detail, at least for

Re: [Qemu-devel] [PATCH] fsdev: Don't ignore setfsuid/setfsgid return values

2012-10-05 Thread Eric Blake
On 10/05/2012 02:36 AM, M. Mohan Kumar wrote: From: M. Mohan Kumar mo...@in.ibm.com In current implementation of setfsuid/setfsgid there is no way to know if it failed by checking the return value. This patch assumes setfsuid/setfsgid returns -1 in case of error. Eventually kernel code

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Disable code after return statement

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 08:41:32AM +0200, Stefan Weil wrote: Report from smatch: microdrive.c:212 md_common_read(34) info: ignoring unreachable code. microdrive.c:273 md_common_write(33) info: ignoring unreachable code. sd.c:343 sd_req_crc_validate(9) info: ignoring unreachable code.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Fix return value check for bdrv_read, bdrv_write

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 08:51:01AM +0200, Stefan Weil wrote: Those functions return -errno in case of an error. The old code would typically only detect EPERM (1) errors. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/nand.c| 34 ++ hw/onenand.c |

Re: [Qemu-devel] [PATCH 2/2] Adding BAR0 for e500 PCI controller

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 09:11, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Thursday, October 04, 2012 9:37 PM To: Bhushan Bharat-R65777 Cc: Avi Kivity; qemu-devel@nongnu.org; qemu-...@nongnu.org Subject: Re: [Qemu-devel] [PATCH

Re: [Qemu-devel] [PATCH] configure: Support empty target list (--target-list=)

2012-10-05 Thread Stefan Hajnoczi
On Wed, Sep 26, 2012 at 10:04:38PM +0200, Stefan Weil wrote: Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cpu: Add missing 'static' attribute to qemu_global_mutex

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 07:41:42AM +0200, Stefan Weil wrote: Contrary to its name, 'qemu_global_mutex' is only used locally in cpus.c. Signed-off-by: Stefan Weil s...@weilnetz.de --- cpus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 02:55:43PM +0100, Peter Maydell wrote: Use the recently introduced tcg_out_mov_reg() function rather than the equivalent inline code. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- This is a minor follow-on cleanup patch after commit 9716ef3b1.

Re: [Qemu-devel] [PATCH 08/14] m25p80: Initial implementation of SPI flash device

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Added device model for m25p80 style SPI flash family. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com ---

Re: [Qemu-devel] [PATCH] slirp: Fix spelling in comment (enought - enough, insure - ensure)

2012-10-05 Thread Stefan Hajnoczi
On Thu, Sep 27, 2012 at 08:57:38PM +0200, Stefan Weil wrote: Signed-off-by: Stefan Weil s...@weilnetz.de --- As a non native speaker, I feel that 'ensure' is better here than 'insure'. Could a native speaker please confirm that? Thanks, Stefan slirp/ip_icmp.h |4 ++-- 1 file

Re: [Qemu-devel] [PATCH] vnc: Fix spelling (hellmen - hellman) in comment

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 28, 2012 at 06:11:49PM +0200, Stefan Weil wrote: The algorithm was named after Martin E. Hellman. Signed-off-by: Stefan Weil s...@weilnetz.de --- ui/vnc-tls.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array.

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO pins are connected to. This is ok for inputs (as an input can only have

Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Removed the explicit SSI mux and wired the CS line directly up to the SSI devices. Signed-off-by: Peter A. G. Crosthwaite

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Luiz Capitulino
On Fri, 05 Oct 2012 08:25:46 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 04/10/2012 20:24, Luiz Capitulino ha scritto: That DPRINTF() usage is really bizarre, it seems its purpose is to report an error to the user, but that's a debugging call. I'd let it there and replace it later

Re: [Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets

2012-10-05 Thread Luiz Capitulino
On Fri, 05 Oct 2012 08:27:25 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 04/10/2012 22:08, Luiz Capitulino ha scritto: On Wed, 3 Oct 2012 16:36:58 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Before: $ qemu-system-x86_64 nbd:localhost:12345 inet_connect_opts:

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Device model for xilinx XPS SPI controller (v2.0) Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com ---

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
[was a private thread due to typo in qemu list address] On 2012-10-05 14:40, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 00:06, Lucas Meneghel Rodrigues ha scritto: +static void debugexit_ioport_write(void *opaque, uint32_t addr, uint32_t val) +{ +

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:41, Luiz Capitulino ha scritto: That DPRINTF() usage is really bizarre, it seems its purpose is to report an error to the user, but that's a debugging call. I'd let it there and replace it later with proper tracing code, but that's quite minor for me.

Re: [Qemu-devel] [PATCH 07/14] hw: Added generic FIFO API.

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com ---

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:43, Jan Kiszka ha scritto: This | 1 might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just exit(val)? The reason for ' | 1' was to make sure that the guest couldn't trigger an exit(0). If there's a

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:42 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Device model for xilinx XPS SPI controller (v2.0) Signed-off-by:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-sockets: Fix compiler warning (regression for MinGW)

2012-10-05 Thread Stefan Hajnoczi
On Fri, Sep 28, 2012 at 07:07:39PM +0200, Stefan Weil wrote: setsockopt needs a type cast for MinGW. That type cast is missing in a recent commit which results in a compiler warning. Like for other socket related functions which have the same problem, we add a 'qemu_setsockopt' macro which

Re: [Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 13:49, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: On Fri, Oct 5, 2012 at 10:42 PM, Peter Maydell peter.mayd...@linaro.org wrote: You need also an entry for irqline. Shouldnt need it as irqline is just a cached copy of the IRQ state to save on qemu_set_irq()

Re: [Qemu-devel] [PULL 0/14] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller

2012-10-05 Thread Peter Maydell
On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: The following changes since commit e744c06fca438dc08271e626034e632a270c91c8: Peter Maydell (1): fpu/softfloat.c: Return correctly signed values from uint64_to_float32 are available in the git

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
On 2012-10-05 14:46, Paolo Bonzini wrote: Il 05/10/2012 14:43, Jan Kiszka ha scritto: This | 1 might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just exit(val)? The reason for ' | 1' was to make sure that the guest couldn't

Re: [Qemu-devel] [PATCH] cleanup useless return sentence

2012-10-05 Thread Stefan Hajnoczi
On Sat, Sep 29, 2012 at 01:36:21PM +0800, Amos Kong wrote: This patch cleans up return sentences in the end of void functions. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- block/qed-table.c|1 - blockdev.c |

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Alberto Garcia
On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes. http://wiki.qemu.org/Planning/1.2 I remember having had a brief look through your patches

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 11:19:39AM +0200, Stefan Weil wrote: It was missing for leon3 and mips_fulong2e. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/leon3.c |2 +- hw/mips/mips_fulong2e.c |2 +- This file doesn't exist in my tree (based on qemu.git/master

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-barrier: Fix compiler version check for future gcc versions

2012-10-05 Thread Stefan Hajnoczi
On Wed, Oct 03, 2012 at 11:11:02PM +0200, Stefan Weil wrote: The current check will give a wrong result for gcc-5.x with x 4. Using QEMU_GNUC_PREREQ is simpler and fixes that issue. Signed-off-by: Stefan Weil s...@weilnetz.de --- With current gcc versions (gcc-4.x) there is no problem.

Re: [Qemu-devel] [Qemu-trivial] [RFC 01/13] qdev: kill bogus comment

2012-10-05 Thread Stefan Hajnoczi
On Thu, Oct 04, 2012 at 04:15:21PM -0300, Eduardo Habkost wrote: When the DeviceInfo code was removed, the comment describing qdev_subclass_init() was left in the code by mistake. Remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/qdev.c | 1 -

Re: [Qemu-devel] [Qemu-trivial] [PATCH] versatilepb: Use symbolic indices for ARM PIC

2012-10-05 Thread Stefan Hajnoczi
On Thu, Oct 04, 2012 at 10:49:43PM +0200, Stefan Weil wrote: It is more readable, and all other code does it like that, too. Signed-off-by: Stefan Weil s...@weilnetz.de --- hw/versatilepb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Thanks, applied to the trivial patches

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 14:43, Jan Kiszka ha scritto: This | 1 might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just exit(val)? The reason for ' | 1' was to make sure that the guest

[Qemu-devel] [PULL 00/12] Trivial patches for 24 September to 5 October 2012

2012-10-05 Thread Stefan Hajnoczi
The following changes since commit a14c74928ba1fdaada515717f4d3c3fa3275d6f7: Merge remote-tracking branch 'sstabellini/xen-2012-10-03' into staging (2012-10-04 19:56:26 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch

[Qemu-devel] [PATCH 03/12] cpu: Add missing 'static' attribute to qemu_global_mutex

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de Contrary to its name, 'qemu_global_mutex' is only used locally in cpus.c. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c

[Qemu-devel] [PATCH 08/12] cleanup useless return sentence

2012-10-05 Thread Stefan Hajnoczi
From: Amos Kong ak...@redhat.com This patch cleans up return sentences in the end of void functions. Reported-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- block/qed-table.c| 1 - blockdev.c

[Qemu-devel] [PATCH 04/12] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code

2012-10-05 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Use the recently introduced tcg_out_mov_reg() function rather than the equivalent inline code. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Stefan Hajnoczi stefa...@gmail.com ---

[Qemu-devel] [PATCH 12/12] versatilepb: Use symbolic indices for ARM PIC

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de It is more readable, and all other code does it like that, too. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- hw/versatilepb.c | 3 ++- 1 file changed, 2

[Qemu-devel] [PATCH 10/12] qemu-barrier: Fix compiler version check for future gcc versions

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de The current check will give a wrong result for gcc-5.x with x 4. Using QEMU_GNUC_PREREQ is simpler and fixes that issue. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- qemu-barrier.h | 2 +- 1 file changed, 1

[Qemu-devel] [PATCH 11/12] qdev: kill bogus comment

2012-10-05 Thread Stefan Hajnoczi
From: Eduardo Habkost ehabk...@redhat.com When the DeviceInfo code was removed, the comment describing qdev_subclass_init() was left in the code by mistake. Remove it. Cc: qemu-triv...@nongnu.org Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@gmail.com

[Qemu-devel] [PATCH 09/12] hw: Add missing 'static' attribute for QEMUMachine

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de It was missing for leon3 and mips_fulong2e. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- hw/leon3.c | 2 +- hw/mips_fulong2e.c | 2 +- 2 files changed, 2

[Qemu-devel] [PATCH 07/12] qemu-sockets: Fix compiler warning (regression for MinGW)

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de setsockopt needs a type cast for MinGW. That type cast is missing in a recent commit which results in a compiler warning. Like for other socket related functions which have the same problem, we add a 'qemu_setsockopt' macro which provides that type cast where

[Qemu-devel] [PATCH 06/12] vnc: Fix spelling (hellmen - hellman) in comment

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de The algorithm was named after Martin E. Hellman. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- ui/vnc-tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c

Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-10-05 Thread Erlon Cruz
Hi all, Just retaking the discussion of some days ago. After some discussions here and considering the suggestions in this thread, we got 3 main ideas for the DLPAR on QEMU/KVM. 1 - introduce a new device/driver that will be used to communicate changes in the DT to the guest + make thinks

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 16:00, Avik Sil avik...@linux.vnet.ibm.com wrote: On 10/05/2012 05:39 PM, Alexander Graf wrote: On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: On Fri, 5 Oct 2012 12:24:47 +0200, Alexander Graf ag...@suse.de wrote: On 05.10.2012, at 10:29, Avik Sil

Re: [Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:34 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com Removed the explicit SSI mux and wired the CS line directly up to the

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:58, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 14:43, Jan Kiszka ha scritto: This | 1 might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just exit(val)? The reason for '

Re: [Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array.

2012-10-05 Thread Peter Crosthwaite
On Fri, Oct 5, 2012 at 10:31 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 5 October 2012 01:08, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: From: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com stellaris_init() defines arrays of qemu_irq to decides what each of

Re: [Qemu-devel] [PATCH v2] target-mips: Use TCG registers for the FPU.

2012-10-05 Thread Richard Henderson
Ping. You gave it your Reviewed-by. r~ On 09/18/2012 11:04 PM, Richard Henderson wrote: With normal FP, this doesn't have much affect on the generated code, because most of the FP operations are not CONST/PURE, and so we spill registers in about the same frequency as the explicit

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 15:58, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 14:43, Jan Kiszka ha scritto: This | 1 might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Anthony Liguori
Alexander Graf ag...@suse.de writes: On 05.10.2012, at 16:00, Avik Sil avik...@linux.vnet.ibm.com wrote: On 10/05/2012 05:39 PM, Alexander Graf wrote: On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: On Fri, 5 Oct 2012 12:24:47 +0200, Alexander Graf ag...@suse.de wrote: On

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:20, Alberto Garcia ha scritto: On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes. http://wiki.qemu.org/Planning/1.2 I remember

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 16:23, Anthony Liguori ha scritto: Understood. The right solution is of course to fix hw/*.c. I don't think it's an awful thing for test harnesses to just use a reserved range of exit reasons. But that's not what exit((val 1) | 1) does, since it allows you to do exit(1)...

[Qemu-devel] [PATCH 7/8] target-arm: use deposit instead of hardcoded version

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno aurel...@aurel32.net Use the deposit op instead of and hardcoded bit field insertion. It allows the host to emit the corresponding instruction if available. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 4/8] target-arm: convert add_cc and sub_cc helpers to TCG

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno aurel...@aurel32.net Now that the setcond TCG op is available, it's possible to replace add_cc and sub_cc helpers by TCG code. The code generated by TCG is actually very close to the one generated by GCC for the helper, and this avoid all the consequences of using an helper:

[Qemu-devel] [PATCH 01/12] hw: Fix return value check for bdrv_read, bdrv_write

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de Those functions return -errno in case of an error. The old code would typically only detect EPERM (1) errors. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@gmail.com --- hw/nand.c| 34 ++

[Qemu-devel] [PATCH 02/12] configure: Support empty target list (--target-list=)

2012-10-05 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a trick which works with POSIX

Re: [Qemu-devel] Enablig DLPAR capacity on QEMU pSeries

2012-10-05 Thread Anthony Liguori
Benjamin Herrenschmidt b...@kernel.crashing.org writes: On Wed, 2012-09-12 at 17:53 +0200, Alexander Graf wrote: On 09/12/2012 04:54 PM, Erlon Cruz wrote: Hi all, We are planning to implement DLPAR capacity on QEMU pSeries. As we What is DLPAR? Hotplug support? Yes. lack of

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Michael Roth
On Fri, Oct 05, 2012 at 10:14:09AM +0200, Paolo Bonzini wrote: Il 04/10/2012 19:33, Michael Roth ha scritto: +#define QIDL_SCHEMA_ADD_LINK(name, obj, path, errp) \ +g_assert(qidl_data_##name.schema_obj); \ +object_property_add_link(obj, path, container, \ Why container as the

Re: [Qemu-devel] [PATCH v3] Add infrastructure for QIDL-based device serialization

2012-10-05 Thread Michael Roth
On Fri, Oct 05, 2012 at 10:26:29AM +0200, Paolo Bonzini wrote: Il 04/10/2012 19:33, Michael Roth ha scritto: These patches are based are origin/master, and can also be obtained from: git://github.com/mdroth/qemu.git qidl-base-v3 Changes since v2: - Documentations fix-ups and

Re: [Qemu-devel] [PATCH] Require spice-server 0.12.0 and spice-protocol 0.12.2

2012-10-05 Thread Søren Sandmann
Paolo Bonzini pbonz...@redhat.com writes: Nice cleanup, thanks! As a followup, there is some confusion between values of the revision property (1-4) and PCI device revisions (QXL_REVISION_STABLE_Vxy). They are the same right now, but this means that you can do one of the following: 1) if

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 05/10/2012 15:20, Alberto Garcia ha scritto: On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes.

Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2012-10-05 Thread Andreas Färber
Am 05.10.2012 15:20, schrieb Alberto Garcia: On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote: Ping We are currently in Hard Freeze, new devices will not get accepted before the release, and our review may focus on bug fixes. http://wiki.qemu.org/Planning/1.2 I remember

Re: [Qemu-devel] [Qemu-ppc] [PATCH] Workaround to bypass default qemu boot devices passed to SLOF

2012-10-05 Thread Alexander Graf
On 05.10.2012, at 16:25, Anthony Liguori aligu...@us.ibm.com wrote: Alexander Graf ag...@suse.de writes: On 05.10.2012, at 16:00, Avik Sil avik...@linux.vnet.ibm.com wrote: On 10/05/2012 05:39 PM, Alexander Graf wrote: On 05.10.2012, at 13:41, Nikunj A Dadhania wrote: On Fri, 5 Oct

[Qemu-devel] [PATCH 1/8] cpu_dump_state: move DUMP_FPU and DUMP_CCOP flags from x86-only to generic

2012-10-05 Thread Peter Maydell
Move the DUMP_FPU and DUMP_CCOP flags for cpu_dump_state() from being x86-specific flags to being generic ones. This allows us to drop some TARGET_I386 ifdefs in various places, and means that we can (potentially) be more consistent across architectures about which monitor commands or debug abort

[Qemu-devel] [PATCH 3/8] target-arm: use globals for CC flags

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno aurel...@aurel32.net Use globals for CC flags instead of loading/storing them each they are accessed. This allows some optimizations to be performed by the TCG optimization passes. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Peter Maydell

Re: [Qemu-devel] MIPS DSP for Qemu

2012-10-05 Thread Peter Maydell
On 3 October 2012 22:37, reed kotler rkot...@mips.com wrote: A year and half ago, I did a complete implementation for Mips DSP in Qemu. My port has passed all the MIPS AVPs (Architectural Verification Programs) for DSP, which is something not available to the public but is what all

Re: [Qemu-devel] [PATCH v3 21/22] qidl: qidl.h, definitions for qidl annotations

2012-10-05 Thread Paolo Bonzini
Il 04/10/2012 19:33, Michael Roth ha scritto: Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qidl.h | 113 1 file changed, 113 insertions(+) create mode 100644 qidl.h diff --git a/qidl.h b/qidl.h new file

[Qemu-devel] [PATCH 6/8] target-arm: mark a few integer helpers const and pure

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/helper.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/target-arm/helper.h

[Qemu-devel] [PATCH 5/8] target-arm: convert sar, shl and shr helpers to TCG

2012-10-05 Thread Peter Maydell
From: Aurelien Jarno aurel...@aurel32.net Now that the movcond TCG op is available, it's possible to replace shl and shr helpers by TCG code. The code generated by TCG is slightly longer than the code generated by GCC for the helper but is still worth it as this avoid all the consequences of

[Qemu-devel] [PULL 0/8] target-arm queue

2012-10-05 Thread Peter Maydell
Usual target-arm pullreq; mostly Aurelien's performance improvement patches. The 'drop macro' patch has only been on the list a few days but it's completely trivial so I threw it in too. Please pull. thanks -- PMM The following changes since commit a14c74928ba1fdaada515717f4d3c3fa3275d6f7:

[Qemu-devel] [PATCH 8/8] target-arm: Drop unused DECODE_CPREG_CRN macro

2012-10-05 Thread Peter Maydell
This macro snuck through code review despite being unused; drop it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- target-arm/cpu.h |2 -- 1 file changed, 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 7fac94f..ff4de10 100644 --- a/target-arm/cpu.h +++

[Qemu-devel] [PATCH 2/8] target-arm: Reinstate display of VFP registers in cpu_dump_state

2012-10-05 Thread Peter Maydell
Reinstate the display of VFP registers in cpu_dump_state(), if the CPU has them (this code had been #if 0'd out a for a long time). We drop the attempt ot display the values as floating point, since this makes assumptions about the host 'float' and 'double' formats and is not done by eg the i386

  1   2   3   >