Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-19 Thread Gerd Hoffmann
On 11/19/12 14:11, Alexander Larsson wrote: > This way you can easily tell from qemu if the guest is using > a qxl driver or not. Device properties are for configuration, not inspection. cheers, Gerd

[Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-11-19 Thread Pandarathil, Vijaymohan R
Add support for error containment when a PCI pass-thru device assigned to a KVM guest encounters an error. This is for PCIe devices/drivers that support AER functionality. When the OS is notified of an error in a device either through the firmware first approach or through an interrupt handled by t

[Qemu-devel] [PATCH 4/4] AER-QEMU: Bring down the guest when KVM detects a PCI device error

2012-11-19 Thread Pandarathil, Vijaymohan R
- When KVM_RUN ioctl returns with an exit reason requesting a shutdown of the guest due to a PCI device error detected by AER, shutdown the guest immediately. Signed-off-by: Vijay Mohan Pandarathil --- kvm-all.c | 6 ++ linux-headers/linux/kvm.h | 1 + 2 files changed, 7 inse

Re: [Qemu-devel] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-19 Thread Wei-Ren Chen
ping? On Fri, Nov 16, 2012 at 10:29:47AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > Hi all, > > Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 > and microMIPS32 DSP. Add comment here to help reading. > > Please review, thanks. > > Regards, > chenwj > > Signed-off-by: Chen Wei-Ren >

[Qemu-devel] [PATCH 3/4] AER-KVM: Integration of KVM with AER for PCI pass-thru devices

2012-11-19 Thread Pandarathil, Vijaymohan R
- Register a notifier function to be called whenever a PCIe error is detected by the AER subsystem. - The notifier function bumps up a global count to keep track of the error notifications. - Before guest entry, each vcpu checks if there has been any new notifications sin

[Qemu-devel] [PATCH 2/4] AER-GHES: Add support for error notification in firmware first approach of AER

2012-11-19 Thread Pandarathil, Vijaymohan R
- When an uncorrected recoverable error is reported via an NMI in the firmware first model of AER, invoke the callbacks registered for notifications as well as mark the device as tainted. - Add a new function ghes_mark_dev_err() leveraged from ghes_do_proc() to identify the dev

[Qemu-devel] [PATCH 1/4] AER-PCI: Add infrastructure for notification of errors to other subsystems

2012-11-19 Thread Pandarathil, Vijaymohan R
- Adds infrastructure support for error notifications from AER subsystem to other subsystems. The generic notifier_chain functionality is used. - When the AER rootport driver detects an uncorrected error, invoke the callbacks registered for notifications as well as mark the device as tainted. -

Re: [Qemu-devel] [PATCH] m25p80: Fix wrong jedec id for Numonyx n25q128

2012-11-19 Thread walimis
On Tue, Nov 20, 2012 at 02:32:33PM +1000, Peter Crosthwaite wrote: >Hi Liming, > >On Mon, Nov 19, 2012 at 11:03 PM, Liming Wang wrote: >> The jedec id of "n25q128" should be 0x20bb18, not 0x20ba18. >> >> Signed-off-by: Liming Wang >> --- >> hw/m25p80.c |2 +- >> 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-11-19 Thread Matthew Ogilvie
On Mon, Nov 19, 2012 at 04:28:31PM +0100, BALATON Zoltan wrote: > On Sun, 9 Sep 2012, Matthew Ogilvie wrote: > > Intel's definition of "edge triggered" means: "asserted with a > > low-to-high transition at the time an interrupt is registered and > > then kept high until the interrupt is served via

Re: [Qemu-devel] [PATCH] m25p80: Fix wrong jedec id for Numonyx n25q128

2012-11-19 Thread Peter Crosthwaite
Hi Liming, On Mon, Nov 19, 2012 at 11:03 PM, Liming Wang wrote: > The jedec id of "n25q128" should be 0x20bb18, not 0x20ba18. > > Signed-off-by: Liming Wang > --- > hw/m25p80.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/m25p80.c b/hw/m25p80.c > index 3895e73.

Re: [Qemu-devel] assertion in temp_save

2012-11-19 Thread Max Filippov
On Sun, Nov 18, 2012 at 7:34 AM, Max Filippov wrote: > On Sun, Nov 18, 2012 at 7:19 AM, Max Filippov wrote: >> Hi Aurelien, >> >> starting with commit 2c0366f tcg: don't explicitly save globals and temps >> I get the following abort on target-xtensa: >> >> qemu-system-xtensa: tcg/tcg.c:1665: temp

[Qemu-devel] [PATCH] kvm: fix incorrect length in a loop over kvm dirty pages map

2012-11-19 Thread Alexey Kardashevskiy
QEMU allocates a map enough for 4k pages. However the system page size can be 64K (for example on POWER) and the host kernel uses only a small part of it as one big stores a dirty flag for 16 pages 4K each, the hpratio variable stores this ratio and the kvm_get_dirty_pages_log_range function handle

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-19 Thread Justin Shafer
Oh yeah.. wine goes in /usr/local/bin. I created a symbolic link from /usr/gnemul/qemu-i386/usr/local/lib/libwine* /usr/local/lib. Same with the wine folder.. it needs to be seen as /usr/local/lib/wine. -- You received this bug notification because you are a member of qemu- devel-ml, which is sub

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-19 Thread Justin Shafer
I still have one program that refuses to run.. I think its having a problem with an x86 library on the gnemul side... I noticed libpng.so.3 wanted to be in the gnemul folder by wine.. even though it didn't exist on the X86 machine I was using to compile.. so I copied it from libpng12.so.. Anyone h

[Qemu-devel] [Bug 739785] Re: qemu-i386 user mode can't fork (bash: fork: Invalid argument)

2012-11-19 Thread Justin Shafer
Requirements to get Wine 1.5.11 and Qemu to work with Ubuntu 12.10 on ARM 1. VMSPLIT-3G and BINFMT_MISC must be compiled into the kernel.. It makes my kernel crash when I access the lan\wifi with traffic.. 2. Use Qemu-0.14.1 with the NPTL Patch ./configure --enable-sdl --target-list=i386-linux-u

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-11-19 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/390 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

[Qemu-devel] [ANNOUNCE] We are now in hard freeze

2012-11-19 Thread Anthony Liguori
At this point, we only are taking bug fixes until the final release of 1.3 on December 3rd. Submaintainers may continue to accept patches into their trees for new features at their discretion (although those pull requests will need to wait until 1.4 opens up). http://wiki.qemu.org/Planning/1.3

[Qemu-devel] [ANNOUNCE] QEMU 1.3.0-rc0 is out!

2012-11-19 Thread anthony
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 1.3 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.3.0-rc0.tar.bz2 You can help improv

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-19 Thread David Gibson
On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: > > On 13.11.2012, at 03:46, David Gibson wrote: > > > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models > > to represent a TLB entry contains a hwaddr. That works reasonably for now, > > but is troublesome

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-19 Thread David Gibson
On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: > > On 13.11.2012, at 03:47, David Gibson wrote: > > > From: Alexey Kardashevskiy > > > > In future (with VFIO) we will have multiple PCI host bridges on > > pseries. Each one needs a unique LIOBN (IOMMU id). At the moment we > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-19 Thread David Gibson
On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: > > > Currently, the pseries machine initializes the cpus, then the XICS > > > interrupt controller. However, to support the upcoming in-kernel XICS > > > implementati

Re: [Qemu-devel] BlockDriverState member in_use (was: KVM Forum 2012 Block BoF minutes)

2012-11-19 Thread Marcelo Tosatti
On Mon, Nov 19, 2012 at 06:03:55PM +0100, Markus Armbruster wrote: > Marcelo Tosatti writes: > > > On Thu, Nov 15, 2012 at 02:31:53PM +0100, Markus Armbruster wrote: > [...] > >> BlockDriverState member in_use and DriveInfo member refcount are a mess: > >> > >> - in_use is used to avoid running

Re: [Qemu-devel] [PATCH] tci: Fix type of tci_read_label

2012-11-19 Thread Stefan Weil
Am 19.11.2012 21:43, schrieb Richard Henderson: Fixes the pointer truncation that was occurring for branches. Cc: Stefan Weil Cc: Blue Swirl Signed-off-by: Richard Henderson --- tci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tci.c b/tci.c index 9c87c8e..54cf1d9

Re: [Qemu-devel] no monitor after disable vnc

2012-11-19 Thread Peter Cheung
Hi --enable-sdl can come up with a monitor screen, thanks Thanksfrom Peter > Date: Mon, 19 Nov 2012 14:38:45 +0100 > From: pbonz...@redhat.com > To: mcheun...@hotmail.com > CC: qemu-devel@nongnu.org > Subject: Re: no monitor after disable vnc > > Il 19/11/2012 14:25, Peter Cheung ha scritto:

[Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-19 Thread Stefan Priebe
From: Stefan Priebe This one fixes a race qemu also had in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. It also removes the useless cancelled flag and introduces instead a status flag with EINPROGRESS

[Qemu-devel] (no subject)

2012-11-19 Thread Stefan Priebe
>From Stefan Priebe # This line is ignored. From: Stefan Priebe Cc: pve-de...@pve.proxmox.com Cc: pbonz...@redhat.com Cc: ceph-de...@vger.kernel.org Subject: QEMU/PATCH: rbd block driver: fix race between completition and cancel In-Reply-To: ve-de...@pve.proxmox.com pbonz...@redhat.com ceph-de.

[Qemu-devel] [PATCH] tci: Fix type of tci_read_label

2012-11-19 Thread Richard Henderson
Fixes the pointer truncation that was occurring for branches. Cc: Stefan Weil Cc: Blue Swirl Signed-off-by: Richard Henderson --- tci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tci.c b/tci.c index 9c87c8e..54cf1d9 100644 --- a/tci.c +++ b/tci.c @@ -338,9 +338,9 @

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > > "Public domain" is not a valid copyright header/license grant. Sez who? > > I'd suggest using something like CC0 which is a formal statement of > no copyright claims. > > http://www.ohloh.net/licenses/cc0-1-universal > > Please send these sorts

[Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-19 Thread Anthony Liguori
"Public domain" is not a valid copyright header/license grant. I'd suggest using something like CC0 which is a formal statement of no copyright claims. http://www.ohloh.net/licenses/cc0-1-universal Please send these sorts of changes to the mailing list first too. Regards, Anthony Liguori ---

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > malc writes: > > > On Mon, 19 Nov 2012, Peter Maydell wrote: > > > >> On 19 November 2012 18:21, malc wrote: > >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> >> +5) Files without explicit licenses fall under the GPL v2. > >> > > >> > I have i

Re: [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-19 Thread Benjamin Herrenschmidt
On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: > > Currently, the pseries machine initializes the cpus, then the XICS > > interrupt controller. However, to support the upcoming in-kernel XICS > > implementation we will need to initialize the irq controller before the > > vcpus. This pat

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread Anthony Liguori
malc writes: > On Mon, 19 Nov 2012, Peter Maydell wrote: > >> On 19 November 2012 18:21, malc wrote: >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: >> >> +5) Files without explicit licenses fall under the GPL v2. >> > >> > I have issue with this, files without licenses are just that files >> >

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Stefan Weil wrote: > Am 19.11.2012 19:34, schrieb malc: > > On Mon, 19 Nov 2012, Peter Maydell wrote: > > > > > On 19 November 2012 18:21, malc wrote: > > > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > > > > > +5) Files without explicit licenses fall under the GPL v2. > >

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread Stefan Weil
Am 19.11.2012 19:34, schrieb malc: On Mon, 19 Nov 2012, Peter Maydell wrote: On 19 November 2012 18:21, malc wrote: On Mon, 19 Nov 2012, Anthony Liguori wrote: +5) Files without explicit licenses fall under the GPL v2. I have issue with this, files without licenses are just that files with

Re: [Qemu-devel] [PATCHv3 0/2] Preparing safe sigprocmask wrapper on qemu-user

2012-11-19 Thread Alex Barcelo
ping On Sat, Oct 20, 2012 at 4:15 PM, Alex Barcelo wrote: > qemu-user needs SIGSEGV (at least) for some internal use. If the guest > application masks it and does unsafe sigprocmask, then the application > crashes. Problems happen in applications with self-modifying code (who > also change the

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Peter Maydell wrote: > On 19 November 2012 18:21, malc wrote: > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> +5) Files without explicit licenses fall under the GPL v2. > > > > I have issue with this, files without licenses are just that files > > without licenses. > >

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread Peter Maydell
On 19 November 2012 18:21, malc wrote: > On Mon, 19 Nov 2012, Anthony Liguori wrote: >> +5) Files without explicit licenses fall under the GPL v2. > > I have issue with this, files without licenses are just that files > without licenses. If we believe this (and it seems a logical thing to believe

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > There's a couple changes here. Please note that no one should consider this > as > licensing guidance from IBM. I'm merely updating this based on what I would > consider community consensus. > > The first change clarifies that the overall license i

Re: [Qemu-devel] [PATCH 0/1] s390 files gplv2 or later

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 19:17, Paolo Bonzini wrote: > Il 19/11/2012 18:31, Alexander Graf ha scritto: >> Given that GPLv2 only code is compatible with LGPLv2+, can't you just >> declare all IBM s390x code to be GPLv2 only? > > What Christian did matches what we have done for all files, so I'd > prefer

Re: [Qemu-devel] [PATCH 0/1] s390 files gplv2 or later

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 18:31, Alexander Graf ha scritto: > Given that GPLv2 only code is compatible with LGPLv2+, can't you just > declare all IBM s390x code to be GPLv2 only? What Christian did matches what we have done for all files, so I'd prefer that. Paolo > Then the rest should > solve itself autom

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 17:40, Anthony Liguori ha scritto: > There's a couple changes here. Please note that no one should consider this > as > licensing guidance from IBM. I'm merely updating this based on what I would > consider community consensus. > > The first change clarifies that the overall licen

Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-11-19 Thread Stefan Weil
Am 19.11.2012 15:24, schrieb Jan Kiszka: See patches for details. Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model Is AT24Cxx compatible to Microchip 24C02SC or SGS Thomson ST24C02 (which are emulated in hw/mips_malta.c)? Could we share code? Stefa

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix regression for MinGW (assertion caused by short string)

2012-11-19 Thread Stefan Weil
Am 19.11.2012 12:31, schrieb Stefan Hajnoczi: On Sun, Nov 18, 2012 at 09:26:15AM +0100, Stefan Weil wrote: The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename w

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-19 Thread Peter Maydell
On 16 November 2012 15:35, wrote: > From: KONRAD Frederic You forgot to CC enough people... > This patch create a new VirtioBus, which can be added to Virtio transports > like > virtio-pci, virtio-mmio,... > > One VirtIODevice can be connected to this device, like virtio-blk in the 3rd > patc

Re: [Qemu-devel] [PATCH 0/1] s390 files gplv2 or later

2012-11-19 Thread Alexander Graf
On 12.11.2012, at 12:44, Christian Borntraeger wrote: > IBMs s390 contributions were meant to to be gplv2 or later (since > we were contributing to qemu). Several of the s390 specific files > link to gpl code anyway so the ones in qemu repository will have > a hard time being strictly LGPL. > So

Re: [Qemu-devel] [PATCHv2] tap: reset vnet header size on open

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 11:23, Michael S. Tsirkin wrote: > For tap, we currently assume the vnet header size is 10 > (the default value) but that might not be the case > if tap is persistent and has been used by qemu previously. > To fix, set host header size in tap device on open. > > Signed-off-by:

Re: [Qemu-devel] Ubuntu/Debian Installer + Virtio-SCSI -> Bad ram pointer

2012-11-19 Thread Stefan Hajnoczi
On Thu, Nov 8, 2012 at 4:26 PM, Peter Lieven wrote: > Has anyone any other idea what the cause could be or where to start? Hi Peter, I suggested posting the source tree you are building. Since you have applied patches yourself no one else is able to follow along with the gdb output or reproduce

Re: [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions

2012-11-19 Thread Stefan Hajnoczi
On Thu, Nov 01, 2012 at 05:12:28PM +0800, Dong Xu Wang wrote: > +/* Create a new QemuOptsList and make its desc to the merge of first and > second. > + * It will allocate space for one new QemuOptsList plus enouth space for > + * QemuOptDesc in first and second QemuOptsList. First argument's QemuO

Re: [Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer

2012-11-19 Thread Stefan Hajnoczi
On Thu, Nov 01, 2012 at 05:12:29PM +0800, Dong Xu Wang wrote: > diff --git a/block/qcow.c b/block/qcow.c > index b239c82..9bb736a 100644 > --- a/block/qcow.c > +++ b/block/qcow.c > @@ -651,7 +651,7 @@ static void qcow_close(BlockDriverState *bs) > error_free(s->migration_blocker); > } > > -

[Qemu-devel] [PATCH] qxl: Export "mode" as a property

2012-11-19 Thread Alexander Larsson
This way you can easily tell from qemu if the guest is using a qxl driver or not. --- hw/qxl.c | 1 + hw/qxl.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 1d16863..98af0bb 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -2261,6 +2261,7 @@ static Property

[Qemu-devel] BlockDriverState member in_use (was: KVM Forum 2012 Block BoF minutes)

2012-11-19 Thread Markus Armbruster
Marcelo Tosatti writes: > On Thu, Nov 15, 2012 at 02:31:53PM +0100, Markus Armbruster wrote: [...] >> BlockDriverState member in_use and DriveInfo member refcount are a mess: >> >> - in_use is used to avoid running certain things concurrently, but the >> rules are unclear, except they're clear

[Qemu-devel] qemu-stable-1.1

2012-11-19 Thread Michael Tokarev
Hello. I'm trying to pick whatever fixes applicable for 1.1.x series of qemu and qemu-kvm. Since Michael Roth said he will not be releasing more 1.1.x series, I think I can at least try to do that. Qemu-1.1 will be included in upcoming Debian Wheezy release, so we're interested in keeping it sta

[Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread Anthony Liguori
There's a couple changes here. Please note that no one should consider this as licensing guidance from IBM. I'm merely updating this based on what I would consider community consensus. The first change clarifies that the overall license is GPLv2. We have never had GPLv1 code. The phrase "GNU G

Re: [Qemu-devel] [0/12] Pending pseries patches

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 03:46, David Gibson wrote: > Here again is my current set of outstanding pseries patches, updated > for current upstream. I don't think any of these has changed in > substance since their last posting. As explained last time around, > some of the From/Signed-off-by combination

Re: [Qemu-devel] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 03:47, David Gibson wrote: > From: Alexey Kardashevskiy > > In future (with VFIO) we will have multiple PCI host bridges on > pseries. Each one needs a unique LIOBN (IOMMU id). At the moment we > derive these from the pci domain number, but the whole notion of > domain numbe

Re: [Qemu-devel] [PATCH] block: add bdrv_reopen() support for raw hdev devices

2012-11-19 Thread Jeff Cody
On 11/19/2012 10:45 AM, Kevin Wolf wrote: > Am 19.11.2012 16:37, schrieb Jeff Cody: >> The host device reopen handler for raw-posix is the same as the file reopen >> handler. >> > > What about host_floppy and (twice) host_cdrom? > > Kevin > Do we need / want reopen for floppy and/or cdrom?

Re: [Qemu-devel] [PATCH 3/5] exec: Do not use absolute address hints for code_gen_buffer with -fpie

2012-11-19 Thread Richard Henderson
On 2012-11-18 12:48, Stefan Weil wrote: > This patch breaks the TCG interpreter. Here is a test run on Debian x86_64 > (output shortened): Nack. This is hiding some bug elsewhere in the tcg interpreter. I disbelieve that the interpreter *requires* a pointer in the low 32-bits of the x86_64 addr

Re: [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 03:46, David Gibson wrote: > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models > to represent a TLB entry contains a hwaddr. That works reasonably for now, > but is troublesome for saving the state, which we'll want to do in future. > hwaddr is a large

[Qemu-devel] [PATCH] migration: fix rate limiting

2012-11-19 Thread Paolo Bonzini
buffered_rate_limit is called to prevent the RAM migration callback from putting too much data in the buffer. So it has to check against the amount of data currently in the buffer, not against the amount of data that has been transferred so far. s->bytes_xfer is used to communicate between succes

Re: [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 03:46, David Gibson wrote: > From: Ben Herrenschmidt > > Currently, the pseries machine initializes the cpus, then the XICS > interrupt controller. However, to support the upcoming in-kernel XICS > implementation we will need to initialize the irq controller before the > vcpu

Re: [Qemu-devel] [PATCH] block: add bdrv_reopen() support for raw hdev devices

2012-11-19 Thread Kevin Wolf
Am 19.11.2012 17:16, schrieb Jeff Cody: > On 11/19/2012 10:45 AM, Kevin Wolf wrote: >> Am 19.11.2012 16:37, schrieb Jeff Cody: >>> The host device reopen handler for raw-posix is the same as the file reopen >>> handler. >>> > >> >> What about host_floppy and (twice) host_cdrom? >> >> Kevin >> > >

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-19 Thread lementec fabien
Hi, Thanks, it is actually a good idea to start with. I will write a spec based on an improved version of what I have already implemented. I think I will have some time this week, I will keep you updated soon. Best regards, Fabien. 2012/11/19 Stefan Hajnoczi : > On Fri, Nov 16, 2012 at 02:05:29

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 16:22, schrieb Paolo Bonzini: Il 19/11/2012 16:04, Stefan Priebe - Profihost AG ha scritto: [ 49.183366] sd 2:0:0:1: [sdb] [ 49.183366] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE [ 49.183366] sd 2:0:0:1: [sdb] [ 49.183366] Sense Key : Aborted Command [current] [ 49.1

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread ronnie sahlberg
On Mon, Nov 19, 2012 at 7:18 AM, Paolo Bonzini wrote: > Il 19/11/2012 15:58, Peter Lieven ha scritto: >> >> -/* XXX we should pass the iovec to write16 to avoid the extra copy */ >> -/* this will allow us to get rid of 'buf' completely */ >> size = nb_sectors * BDRV_SECTOR_SIZE; >> -

Re: [Qemu-devel] [PATCH] block: add bdrv_reopen() support for raw hdev devices

2012-11-19 Thread Kevin Wolf
Am 19.11.2012 16:37, schrieb Jeff Cody: > The host device reopen handler for raw-posix is the same as the file reopen > handler. > > Signed-off-by: Jeff Cody > --- > block/raw-posix.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index f2f04

[Qemu-devel] [PATCH] block: add bdrv_reopen() support for raw hdev devices

2012-11-19 Thread Jeff Cody
The host device reopen handler for raw-posix is the same as the file reopen handler. Signed-off-by: Jeff Cody --- block/raw-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index f2f0404..c7061e6 100644 --- a/block/raw-posix.c +++ b/block/raw-p

Re: [Qemu-devel] [PATCH 1/3] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-11-19 Thread Christian Borntraeger
On 19/11/12 16:08, Markus Armbruster wrote: > You're undoing my work separation of guessing L-CHS from the DOS > partition table and choosing a translation. Why? Might be my fault during rebasing. Will check with Einar.

Re: [Qemu-devel] [PATCH v5 5/6] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-11-19 Thread BALATON Zoltan
On Sun, 9 Sep 2012, Matthew Ogilvie wrote: Intel's definition of "edge triggered" means: "asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or goes away unhandled." So the only difference b

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread Peter Lieven
Am 19.11.2012 um 16:18 schrieb Paolo Bonzini : > Il 19/11/2012 15:58, Peter Lieven ha scritto: >> >> -/* XXX we should pass the iovec to write16 to avoid the extra copy */ >> -/* this will allow us to get rid of 'buf' completely */ >> size = nb_sectors * BDRV_SECTOR_SIZE; >> -acb

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 16:04, Stefan Priebe - Profihost AG ha scritto: > [ 49.183366] sd 2:0:0:1: [sdb] > [ 49.183366] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE > [ 49.183366] sd 2:0:0:1: [sdb] > [ 49.183366] Sense Key : Aborted Command [current] > [ 49.183366] sd 2:0:0:1: [sdb] > [ 49.183

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 15:58, Peter Lieven ha scritto: > > -/* XXX we should pass the iovec to write16 to avoid the extra copy */ > -/* this will allow us to get rid of 'buf' completely */ > size = nb_sectors * BDRV_SECTOR_SIZE; > -acb->buf = g_malloc(size); > -qemu_iovec_to_buf(acb->q

Re: [Qemu-devel] [PATCH 1/3] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-11-19 Thread Markus Armbruster
Christian Borntraeger writes: > From: Einar Lueck > > This patch extends the function guess_disk_lchs. If no geo could > be derived from reading disk content, HDIO_GETGEO ioctl is issued. > If this is not successful (e.g. image files) geometry is derived > from the size of the disk (as before).

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, new patch attached. Desciption is still wrong. > I think this is all unneeded. Just store rcb->ret into > rcb->acb->status, and your version of qemu_rbd_aio_cancel should just > work. > > Also, I think the acb->cancelled field is not necessary anymore after > these changes. 1.) It

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 15:48, Stefan Priebe - Profihost AG ha scritto: > So you mean in qemu_rbd_complete_aio i should remove the check for > cancelled and then just overwrite acb->status to that it changes from > -EINPROGRESS to something else? > > And qemu_rbd_aio_cancel should just wait for status != -E

[Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-19 Thread Peter Lieven
libiscsi expects all write16 data in a linear buffer. If the iovec only contains one buffer we can skip the linearization step as well as the additional malloc/free and pass the buffer directly. Reported-by: Ronnie Sahlberg Signed-off-by: Peter Lieven --- block/iscsi.c | 24 +++--

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Am 19.11.2012 15:41, schrieb Paolo Bonzini: Il 19/11/2012 15:28, Stefan Priebe - Profihost AG ha scritto: typedef struct RADOSCB { @@ -376,6 +377,10 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb) RBDAIOCB *acb = rcb->acb; int64_t r; +if (acb->bh) { +return; +}

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 15:28, Stefan Priebe - Profihost AG ha scritto: > typedef struct RADOSCB { > @@ -376,6 +377,10 @@ static void qemu_rbd_complete_aio(RADOSCB *rcb) > RBDAIOCB *acb = rcb->acb; > int64_t r; > > +if (acb->bh) { > +return; > +} > + > r = rcb->ret; > >

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 15:16, Stefan Priebe - Profihost AG ha scritto: > Hi Paolo, > Hi Josh, > > i started to port the iscsi fixes to rbd. The one think i'm missing is. > How to tell / call rbd to cancel I/O on the server side? > > I grepped librbd source code for abort / cancel but didn't find anything.

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, this is my current work status on porting these fixes to rbd. Right now the discards get still canceled by the client kernel. Might you have a look what i have forgotten? Thanks! Stefan Am 19.11.2012 14:06, schrieb Paolo Bonzini: Il 19/11/2012 14:01, Stefan Priebe - Profihost AG h

[Qemu-devel] [PATCH 1/2] i2c: Introduce device address mask

2012-11-19 Thread Jan Kiszka
Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the transmitted address before matching it against the stored on

[Qemu-devel] [PATCH 2/2] Add AT24Cxx I2C EEPROM device model

2012-11-19 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by the "size" property (required for sizes < 512, the blockdev sector size) or is derived from the size of the backing block d

[Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model

2012-11-19 Thread Jan Kiszka
See patches for details. Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model hw/Makefile.objs |2 +- hw/at24.c| 363 ++ hw/ds1338.c |2 +- hw/i2c.c |9 +- hw/i2c.h

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Stefan Priebe - Profihost AG
Hi Paolo, Hi Josh, i started to port the iscsi fixes to rbd. The one think i'm missing is. How to tell / call rbd to cancel I/O on the server side? I grepped librbd source code for abort / cancel but didn't find anything. Qemu must be able to tell rbd to cancel a specific I/O request. Greets

[Qemu-devel] [PATCH 0/2] [PULL] slirp: Fix for ARP assert and DSN search DHCP option

2012-11-19 Thread Jan Kiszka
The following changes since commit ce34cf72fe508b27a78f83c184142e8d1e6a048a: Merge remote-tracking branch 'awilliam/tags/vfio-pci-for-qemu-1.3.0-rc0' into staging (2012-11-14 08:53:40 -0600) are available in the git repository at: git://git.kiszka.org/qemu.git queues/slirp Klaus Stengel (1

[Qemu-devel] [PATCH 2/2] slirp: Add domain-search option to slirp's DHCP server

2012-11-19 Thread Jan Kiszka
From: Klaus Stengel This patch will allow the user to include the domain-search option in replies from the built-in DHCP server. The domain suffixes can be specified by adding dnssearch= entries to the "-net user" parameter. [Jan: tiny style adjustments] Signed-off-by: Klaus Stengel Signed-off

[Qemu-devel] [PATCH 1/2] slirp: Don't crash on packets from 0.0.0.0/8.

2012-11-19 Thread Jan Kiszka
From: Nickolai Zeldovich LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich Signed-off-by: Jan Kiszka --- slirp/arp_table.

Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2012-11-19 Thread Alex Horn
>> Out of curiosity, does anyone know how long this particular bug has >> been undetected or how/when it was introduced? > > Probably it was introduced last September when the model was rewritten. > But it's really unlikely that the bug would have been detected. Thanks for that quick assessment.

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Markus Armbruster
Alexander Graf writes: > On 19.11.2012, at 14:44, Christian Borntraeger wrote: > >> On 19/11/12 14:36, Alexander Graf wrote: >>> >>> On 12.11.2012, at 09:22, Christian Borntraeger wrote: >>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to

Re: [Qemu-devel] slow virtio network with vhost=on and multiple cores

2012-11-19 Thread Peter Lieven
On 13.11.2012 17:33, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 06:22:56PM +0200, Michael S. Tsirkin wrote: On Tue, Nov 13, 2012 at 12:49:03PM +0100, Peter Lieven wrote: On 09.11.2012 19:03, Peter Lieven wrote: Remark: If i disable interrupts on CPU1-3 for virtio the performance is ok a

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 14:44, Christian Borntraeger wrote: > On 19/11/12 14:36, Alexander Graf wrote: >> >> On 12.11.2012, at 09:22, Christian Borntraeger wrote: >> >>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >>> default/standard interface to their block devices / drives. Th

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Alexander Graf
On 19.11.2012, at 14:35, Eduardo Habkost wrote: > On Mon, Nov 19, 2012 at 02:14:27PM +0100, Alexander Graf wrote: >> >> On 13.11.2012, at 13:11, Christian Borntraeger wrote: >> >>> From: Heinz Graalfs >>> >>> The global variable 'ram_size' is hidden by the local variable >>> declaration in s3

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Christian Borntraeger
On 19/11/12 14:36, Alexander Graf wrote: > > On 12.11.2012, at 09:22, Christian Borntraeger wrote: > >> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >> default/standard interface to their block devices / drives. Therfore, >> this patch introduces a new field default_block per

Re: [Qemu-devel] no monitor after disable vnc

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 14:25, Peter Cheung ha scritto: > Dear All > When i compile qemu in ubuntu 12.10 with "./configure > --target-list=i386-softmmu --prefix=/root/qemu --enable-debug > --disable-vnc --disable-werror" , after i start qemu, no screen output, > how to enable it? Please attach your config

Re: [Qemu-devel] [PATCH 1/1] Support default block interfaces per QEMUMachine

2012-11-19 Thread Alexander Graf
On 12.11.2012, at 09:22, Christian Borntraeger wrote: > There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a > default/standard interface to their block devices / drives. Therfore, > this patch introduces a new field default_block per QEMUMachine struct. > The prior use_scsi field bec

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2012 at 02:14:27PM +0100, Alexander Graf wrote: > > On 13.11.2012, at 13:11, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > The global variable 'ram_size' is hidden by the local variable > > declaration in s390_init() > > That's the point of Eduardo's patch, no?

Re: [Qemu-devel] [PATCH 2/3] s390: Virtual channel subsystem support.

2012-11-19 Thread Alexander Graf
On 31.10.2012, at 17:24, Cornelia Huck wrote: > Provide a mechanism for qemu to provide fully virtual subchannels to > the guest. In the KVM case, this relies on the kernel's css support > for I/O and machine check interrupt handling. The !KVM case handles > interrupts on its own. > > Signed-off

[Qemu-devel] no monitor after disable vnc

2012-11-19 Thread Peter Cheung
Dear All When i compile qemu in ubuntu 12.10 with "./configure --target-list=i386-softmmu --prefix=/root/qemu --enable-debug --disable-vnc --disable-werror" , after i start qemu, no screen output, how to enable it? Thanksfrom Peter

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Peter Maydell
On 19 November 2012 13:14, Alexander Graf wrote: > > On 13.11.2012, at 13:11, Christian Borntraeger wrote: > >> From: Heinz Graalfs >> >> The global variable 'ram_size' is hidden by the local variable >> declaration in s390_init() > > That's the point of Eduardo's patch, no? Or do we need access

Re: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one

2012-11-19 Thread Alexander Graf
On 13.11.2012, at 13:11, Christian Borntraeger wrote: > From: Heinz Graalfs > > The global variable 'ram_size' is hidden by the local variable > declaration in s390_init() That's the point of Eduardo's patch, no? Or do we need access to the global to change its value afterwards? If so, please

Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 14:01, Stefan Priebe - Profihost AG ha scritto: >> The right behavior is to return >> only after the target says whether the cancellation was done or not. >> For libiscsi, it was implemented by the commits you mention. > > So the whole bunch of changes is needed for rbd? Something l

  1   2   >