[Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Elta Era
Hi all, I make three patch about mips 1: Fix my email address in dsp_helper.c 2: Fix repl_ph, value should sign-extend to target_long 3: Fix gen_HILO, there is a bug when we use dsp arch, at that time acc index will be 0-3, and mipsdsp already add in. mipsdsp just take acc index from opcode, on ot

Re: [Qemu-devel] [PATCH/RFC] block: Ensure that block size constraints are considered

2012-12-10 Thread Kevin Wolf
Am 07.12.2012 21:26, schrieb Heinz Graalfs: > Hello Kevin, > > I'm resending my answer as of Nov 23rd. > > Is this still on your queue? No, it wasn't. I guess I was waiting for a new version of the patch. >>> } >>> >>> void *qemu_blockalign(BlockDriverState *bs, size_t size) >>> diff --git

Re: [Qemu-devel] [PATCH 4/8] s390: Add channel I/O instructions.

2012-12-10 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: > Provide handlers for (most) channel I/O instructions. > > Signed-off-by: Cornelia Huck > --- > target-s390x/cpu.h| 87 +++ > target-s390x/ioinst.c | 694 +- > target-s390x/ioinst.h | 16 ++

[Qemu-devel] [PATCH] qemu-img: find the highest offset in use during check

2012-12-10 Thread Federico Simoncelli
This patch adds the support for reporting the highest offset in use by an image. This is particularly useful after a conversion (or a rebase) where the destination is a block device in order to find the actual amount of space in use. Signed-off-by: Federico Simoncelli --- block.h

Re: [Qemu-devel] [PATCH 4/8] s390: Add channel I/O instructions.

2012-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2012 10:00:16 +0100 Alexander Graf wrote: > > > On 07.12.2012, at 13:50, Cornelia Huck wrote: > > > Provide handlers for (most) channel I/O instructions. > > > > Signed-off-by: Cornelia Huck > > --- > > target-s390x/cpu.h| 87 +++ > > target-s390x/ioinst.c | 694 > >

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Wei-Ren Chen
Hi, > 1: Fix my email address in dsp_helper.c > 2: Fix repl_ph, value should sign-extend to target_long > 3: Fix gen_HILO, there is a bug when we use dsp arch, at that time acc index > will be 0-3, and mipsdsp already add in. mipsdsp just take acc index from > opcode, on other arch, it my bring a

Re: [Qemu-devel] removing on-demand msix vector allocation

2012-12-10 Thread Michael S. Tsirkin
On Fri, Dec 07, 2012 at 08:37:22AM +0100, Jan Kiszka wrote: > On 2012-12-06 08:59, Michael S. Tsirkin wrote: > > I've been looking at handling of msix masking > > in qemu. It looks like all of virtio,vfio and > > device assignment implemented their own > > similar but slightly different thing. > >

Re: [Qemu-devel] [PATCH 6/8] s390: Wire up channel I/O in kvm.

2012-12-10 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: > Trigger the code for our virtual css in case of instruction > intercepts for I/O instructions. > > Handle the tsch exit for the subchannel-related part of tsch. > > Signed-off-by: Cornelia Huck > --- > target-s390x/cpu.h | 11 +++ > target-s390

Re: [Qemu-devel] removing on-demand msix vector allocation

2012-12-10 Thread Jan Kiszka
On 2012-12-10 10:36, Michael S. Tsirkin wrote: > On Fri, Dec 07, 2012 at 08:37:22AM +0100, Jan Kiszka wrote: >> On 2012-12-06 08:59, Michael S. Tsirkin wrote: >>> I've been looking at handling of msix masking >>> in qemu. It looks like all of virtio,vfio and >>> device assignment implemented their

Re: [Qemu-devel] removing on-demand msix vector allocation

2012-12-10 Thread Michael S. Tsirkin
On Mon, Dec 10, 2012 at 10:39:39AM +0100, Jan Kiszka wrote: > On 2012-12-10 10:36, Michael S. Tsirkin wrote: > > On Fri, Dec 07, 2012 at 08:37:22AM +0100, Jan Kiszka wrote: > >> On 2012-12-06 08:59, Michael S. Tsirkin wrote: > >>> I've been looking at handling of msix masking > >>> in qemu. It look

Re: [Qemu-devel] [RFC PATCH v4 0/8] s390: channel I/O support in qemu.

2012-12-10 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: > Hi, > > just a quick dump of my qemu patch series for channel I/O. > > I've managed to chop the virtual css patch into some smaller > chunks (patches 2-6), which are hopefully easier to review. > > The virtio-ccw patch is still based upon the cur

Re: [Qemu-devel] [PATCH 2/8] s390: Channel I/O basic defintions.

2012-12-10 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: > Basic channel I/O structures and helper function. > > Signed-off-by: Cornelia Huck > --- > target-s390x/Makefile.objs | 2 +- > target-s390x/ioinst.c | 46 ++ > target-s390x/ioinst.h | 207 +++

Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-10 Thread Alexander Graf
On 07.12.2012, at 13:50, Cornelia Huck wrote: > I/O interrupts are queued per isc. Only crw pending machine checks > are supported. > > Signed-off-by: Cornelia Huck > --- > target-s390x/cpu.h| 67 +++ > target-s390x/helper.c | 145

Re: [Qemu-devel] [PATCH 2/8] s390: Channel I/O basic defintions.

2012-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2012 09:07:57 +0100 Alexander Graf wrote: > > On 07.12.2012, at 13:50, Cornelia Huck wrote: > > > Basic channel I/O structures and helper function. > > > > Signed-off-by: Cornelia Huck > > --- > > target-s390x/Makefile.objs | 2 +- > > target-s390x/ioinst.c | 46

Re: [Qemu-devel] [PATCH 0/2] tests: avoid aio_flush() in test cases

2012-12-10 Thread Kevin Wolf
Am 04.12.2012 17:59, schrieb Paolo Bonzini: > Il 04/12/2012 16:12, Stefan Hajnoczi ha scritto: >> There is a patch to drop aio_flush(). Most callers shouldn't use that >> interface. It turns out that the aio and thread pool test cases *do* need >> low-level flush functionality so they can test th

Re: [Qemu-devel] [PATCH 3/8] s390: I/O interrupt and machine check injection.

2012-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2012 09:20:57 +0100 Alexander Graf wrote: > > On 07.12.2012, at 13:50, Cornelia Huck wrote: > > > I/O interrupts are queued per isc. Only crw pending machine checks > > are supported. > > > > Signed-off-by: Cornelia Huck > > --- > > target-s390x/cpu.h| 67 +

Re: [Qemu-devel] [PATCH 6/8] s390: Wire up channel I/O in kvm.

2012-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2012 10:40:15 +0100 Alexander Graf wrote: > > > On 07.12.2012, at 13:50, Cornelia Huck wrote: > > > Trigger the code for our virtual css in case of instruction > > intercepts for I/O instructions. > > > > Handle the tsch exit for the subchannel-related part of tsch. > > > > S

Re: [Qemu-devel] [RFC PATCH v4 0/8] s390: channel I/O support in qemu.

2012-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2012 09:02:51 +0100 Alexander Graf wrote: > > On 07.12.2012, at 13:50, Cornelia Huck wrote: > > > Hi, > > > > just a quick dump of my qemu patch series for channel I/O. > > > > I've managed to chop the virtual css patch into some smaller > > chunks (patches 2-6), which are hope

[Qemu-devel] [PATCH] qxl+vnc: register a vm state change handler for dummy spice_server

2012-12-10 Thread Uri Lublin
When qxl + vnc are used, a dummy spice_server is initialized. The spice_server has to be told when the VM runstate changes, which is what this patch does. Without it, from qxl_send_events(), the following error message is shown: qxl_send_events: spice-server bug: guest stopped, ignoring --- ui/

[Qemu-devel] [PATCH] qxl: save qemu_create_displaysurface_from result

2012-12-10 Thread Gerd Hoffmann
https://bugzilla.redhat.com/show_bug.cgi?id=885644 Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 98ecb21..88e63f8 100644 --- a/hw/qxl-rend

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-10 Thread Luiz Capitulino
On Sat, 8 Dec 2012 06:26:05 + Dietmar Maurer wrote: > > 2. wait for the (kernel-based) auto-ballooning feature, which is on the > > works > > Do you have more information on that? Any links? No, no links. What's being worked right now is a notification mechanism for the kernel to infor

[Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-10 Thread Fabien Chouteau
An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau --- block/raw-win32.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c inde

Re: [Qemu-devel] [RFC 3/3] docs: document virtio-balloon stats

2012-12-10 Thread Dietmar Maurer
> > > 2. wait for the (kernel-based) auto-ballooning feature, which is on the > > > works > > > > Do you have more information on that? Any links? > > No, no links. What's being worked right now is a notification mechanism for > the kernel to inform user-space about memory pressure: > > htt

Re: [Qemu-devel] [PATCH] qemu-img: find the highest offset in use during check

2012-12-10 Thread Kevin Wolf
Am 10.12.2012 10:13, schrieb Federico Simoncelli: > This patch adds the support for reporting the highest offset in use by > an image. This is particularly useful after a conversion (or a rebase) > where the destination is a block device in order to find the actual > amount of space in use. > > Si

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Kevin Wolf
Hi Keith, Am 08.12.2012 20:20, schrieb Keith Busch: >> IIUC from the website above, NVMe is to be used with SSDs? It would be >> good to add to the commit message how to actually use the device >> command-line-wise beyond the obvious -device nvme: I did not spot on >> brief sight where you expose

Re: [Qemu-devel] [PATCH qom-cpu 1/4] target-i386: Inline -cpu host check into cpu_x86_register()

2012-12-10 Thread Eduardo Habkost
On Sun, Dec 09, 2012 at 08:45:50PM +0100, Andreas Färber wrote: > Simplifies the upcoming cleanup of cpu_x86_find_by_name(). ...by making cpu_x86_register() more complicated, and having CPU model name lookup spread into different parts of the code. The CPU model lookup is a bit complex because of

[Qemu-devel] [PATCH 1/2] pixman: require 0.16.4 as minimum version

2012-12-10 Thread Gerd Hoffmann
Lower the bar a bit. 0.16.4 is known-good, and is shipped by debian. Fixes build failures on the debian-based buildbot slaves. Signed-off-by: Gerd Hoffmann --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e5aedef..a4e62c4 1007

[Qemu-devel] [PATCH 2/2] pixman: update internal copy to pixman-0.28.2

2012-12-10 Thread Gerd Hoffmann
Some w64 fixes by Stefan Weil found their way into 0.28.2, so update the internal copy to that version to improve windows support. Signed-off-by: Gerd Hoffmann --- pixman |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pixman b/pixman index 97336fa..a5e5179 16 --- a

[Qemu-devel] [PATCH 0/2] pixman: two little fixes.

2012-12-10 Thread Gerd Hoffmann
Hi, Two little pixman fixes. The first unbreaks a bunch of build failures. please apply, Gerd Gerd Hoffmann (2): pixman: require 0.16.4 as minimum version pixman: update internal copy to pixman-0.28.2 configure |4 ++-- pixman|2 +- 2 files changed, 3 insertions(+), 3 dele

Re: [Qemu-devel] [Qemu-ppc] [0/2] pseries: Rework PCI code for handling multiple PHBs

2012-12-10 Thread Michael S. Tsirkin
On Wed, Nov 28, 2012 at 01:50:53PM +1100, David Gibson wrote: > On Tue, Nov 27, 2012 at 02:36:57PM +0200, Michael S. Tsirkin wrote: > > On Tue, Nov 27, 2012 at 05:07:31PM +1100, David Gibson wrote: > > > Hi Michael, Alex, > > > > > > This patch represents a compromise I hope will be acceptable aft

Re: [Qemu-devel] [PATCH 1/2] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs

2012-12-10 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 05:07:32PM +1100, David Gibson wrote: > The PAPR specification requires that every bus or device mediated by the > IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check > to enforce this, which will help catch errors in configuration earlier. > > Signe

Re: [Qemu-devel] [PATCH 2/2] pseries: Properly handle allocation of multiple PCI host bridges

2012-12-10 Thread Michael S. Tsirkin
On Tue, Nov 27, 2012 at 05:07:33PM +1100, David Gibson wrote: > From: Alexey Kardashevskiy > > Multiple - even many - PCI host bridges (i.e. PCI domains) are very > common on real PAPR compliant hardware. For reasons related to the > PAPR specified IOMMU interfaces, PCI device assignment with VF

Re: [Qemu-devel] [PATCH v5 06/11] dataplane: add Linux AIO request queue

2012-12-10 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 03:21:22PM +0100, Kevin Wolf wrote: > Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: > > The IOQueue has a pool of iocb structs and a function to add new > > read/write requests. Multiple requests can be added before calling the > > submit function to actually tell the host

Re: [Qemu-devel] [PATCH v5 10/11] dataplane: add virtio-blk data plane code

2012-12-10 Thread Stefan Hajnoczi
On Fri, Dec 07, 2012 at 07:04:39PM +0100, Kevin Wolf wrote: > Am 05.12.2012 21:47, schrieb Stefan Hajnoczi: > > virtio-blk-data-plane is a subset implementation of virtio-blk. It only > > handles read, write, and flush requests. It does this using a dedicated > > thread that executes an epoll(2)-

Re: [Qemu-devel] [PATCHv6] rbd block driver fix race between aio completition and aio cancel

2012-12-10 Thread Kevin Wolf
Am 30.11.2012 14:50, schrieb Stefan Hajnoczi: > On Fri, Nov 30, 2012 at 9:55 AM, Stefan Priebe wrote: >> This one fixes a race which qemu had also in iscsi block driver >> between cancellation and io completition. >> >> qemu_rbd_aio_cancel was not synchronously waiting for the end of >> the comman

[Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane

2012-12-10 Thread Stefan Hajnoczi
This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and without going through the QEMU block layer. Khoa Huynh reported an increase from 140,000 IOPS

[Qemu-devel] [PATCH v6 05/12] dataplane: add event loop

2012-12-10 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

[Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-10 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

Re: [Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane

2012-12-10 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 2:09 PM, Stefan Hajnoczi wrote: > v6: Note that v6 is based on git://repo.or.cz/qemu/kevin.git block. Stefan

[Qemu-devel] [PATCH v6 01/12] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-12-10 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

[Qemu-devel] [PATCH v6 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-12-10 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code

2012-12-10 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH v6 07/12] iov: add iov_discard_front/back() to remove data

2012-12-10 Thread Stefan Hajnoczi
The iov_discard_front/back() functions remove data from the front or back of the vector. This is useful when peeling off header/footer structs. Signed-off-by: Stefan Hajnoczi --- iov.c | 51 +++ iov.h | 13 + 2 files changed, 64 insert

[Qemu-devel] [PATCH v6 08/12] test-iov: add iov_discard_front/back() testcases

2012-12-10 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/test-iov.c | 150 +++ 1 file changed, 150 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index cbe7a89..720d95c 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@ -250,11 +250,161 @@

[Qemu-devel] [PATCH v6 11/12] dataplane: add virtio-blk data plane code

2012-12-10 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-12-10 Thread Wei-Ren Chen
[CC'ed qemu-trivial] ping? On Wed, Nov 21, 2012 at 07:52:48AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > When tb_remove was first commited at fd6ce8f6, there were three different > calls pass different names to offsetof. In current codebase, the other two > calls are replaced with tb_page_remove. T

[Qemu-devel] [PATCH v6 09/12] iov: add qemu_iovec_concat_iov()

2012-12-10 Thread Stefan Hajnoczi
The qemu_iovec_concat() function copies a subset of a QEMUIOVector. The new qemu_iovec_concat_iov() function does the same for a iov/cnt pair. It is easy to define qemu_iovec_concat() in terms of qemu_iovec_concat_iov(). The existing code is mostly unchanged, except for the assertion src->size >

[Qemu-devel] [PATCH v6 10/12] virtio-blk: restore VirtIOBlkConf->config_wce flag

2012-12-10 Thread Stefan Hajnoczi
Two slightly different versions of a patch to conditionally set VIRTIO_BLK_F_CONFIG_WCE through the "config-wce" qdev property have been applied (ea776abca and eec7f96c2). David Gibson noticed that the "config-wce" property is broken as a result and fixed it recently. The fix sets the host_featu

[Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code

2012-12-10 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] KVM call agenda for 2012-12-11

2012-12-10 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

[Qemu-devel] [PATCH v6 06/12] dataplane: add Linux AIO request queue

2012-12-10 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 1:36 PM, Kevin Wolf wrote: > Hi Keith, > > Am 08.12.2012 20:20, schrieb Keith Busch: >>> IIUC from the website above, NVMe is to be used with SSDs? It would be >>> good to add to the commit message how to actually use the device >>> command-line-wise beyond the obvious -de

Re: [Qemu-devel] [PATCH] virtio: verify that all outstanding buffers are flushed (was Re: vmstate conversion for virtio?)

2012-12-10 Thread Anthony Liguori
Rusty Russell writes: > "Michael S. Tsirkin" writes: > > No, because I don't understand it. Is it true for the case of > virtio_blk, which has outstanding requests? > >>> Currently we dump a massive structure; it's inelegant at the very >>> least. Inelegant is a kind word.. There's a couple t

Re: [Qemu-devel] [PATCH_v3] add target-openrisc floating point exception

2012-12-10 Thread Wei-Ren Chen
Hi Feng, One question, > @@ -25,5 +25,5 @@ void HELPER(exception)(CPUOpenRISCState *env, > uint32_t excp) > { > OpenRISCCPU *cpu = OPENRISC_CPU(ENV_GET_CPU(env)); > > -raise_exception(cpu, excp); > +do_raise_exception(cpu, excp, 0); > } Shouldn't above helper function be ca

Re: [Qemu-devel] [Bug 1087974] [NEW] [regression] vnc tight png produces garbled output

2012-12-10 Thread Stefan Hajnoczi
On Sat, Dec 8, 2012 at 12:46 PM, Tim Hardeck wrote: > Public bug reported: > > VNC Tight PNG compression did work fine two or three month ago but don't > anymore. Now when Tight PNG is used parts of the desktop are shown but they > are scrambled together. > I have always tested this feature agai

[Qemu-devel] [RFC 0/4] virtio: stabilize migration format

2012-12-10 Thread Anthony Liguori
This series replaces: qemu_put_buffer(f, (unsigned char*)&req->elem, sizeof(req->elem)); With code that properly saves out each element of the structure using a well defined endian format. Migration is broken today from big endian to little endian hosts. There's no way to fix this problem w

[Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements

2012-12-10 Thread Anthony Liguori
Putting raw structures on the wire is bad news. Add a wrapper and use it. Note that in virtio-serial-bus, we were mapping both the in and out vectors as writable. This is a bug that is fixed by this change. I checked the revision history, it has been there since the code was first added and doe

[Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format

2012-12-10 Thread Anthony Liguori
We were memcpy()'ing a structure to the wire :-/ Since savevm really only works on x86 today, lets just declare that this element is sent over the wire as a little endian value in order to fix the bitness. Unfortunately, we also send raw pointers and size_t which are going to be different values

[Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines

2012-12-10 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- qemu-file.h | 7 +++ savevm.c| 45 + 2 files changed, 52 insertions(+) diff --git a/qemu-file.h b/qemu-file.h index d64bdbb..ac5286c 100644 --- a/qemu-file.h +++ b/qemu-file.h @@ -94,6 +94,9 @@ static inline

[Qemu-devel] [PATCH 4/4] virtio: bump migration version number

2012-12-10 Thread Anthony Liguori
And disable migration on big endian hosts from older versions where endianness of the device state was ambiguous on the wire. Signed-off-by: Anthony Liguori --- hw/virtio-blk.c| 13 +++-- hw/virtio-serial-bus.c | 9 +++-- 2 files changed, 18 insertions(+), 4 deletions(-) di

Re: [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines

2012-12-10 Thread Peter Maydell
On 10 December 2012 14:29, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > qemu-file.h | 7 +++ > savevm.c| 45 + > 2 files changed, 52 insertions(+) > > diff --git a/qemu-file.h b/qemu-file.h > index d64bdbb..ac5286c 100644 >

Re: [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines

2012-12-10 Thread Anthony Liguori
Peter Maydell writes: > On 10 December 2012 14:29, Anthony Liguori wrote: >> Signed-off-by: Anthony Liguori >> --- >> qemu-file.h | 7 +++ >> savevm.c| 45 + >> 2 files changed, 52 insertions(+) >> >> diff --git a/qemu-file.h b/qemu-file.h >

[Qemu-devel] [PATCH] target-mips: Fix for helpers for EXTR_* instructions

2012-12-10 Thread Petar Jovanovic
From: Petar Jovanovic The change removes some unnecessary and incorrect code for EXTR_S.H. Further, it corrects the mask for shift value in the EXTR_ instructions. It also extends the existing tests so they trigger the issues corrected with the change. Signed-off-by: Petar Jovanovic --- target

Re: [Qemu-devel] [PATCH V17 1/6] docs: document for add-cow file format

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > Document for add-cow format, the usage and spec of add-cow are introduced. > > Signed-off-by: Dong Xu Wang > --- > docs/specs/add-cow.txt | 154 > > 1 files changed, 154 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-12-10 Thread Wei-Ren Chen
On Mon, Nov 26, 2012 at 08:23:10AM -0800, Richard Henderson wrote: > On 11/24/2012 10:12 AM, Peter Maydell wrote: > > MacOS gcc objects to this: > > In file included from /Users/pm215/src/qemu/tcg/tcg.c:174: > > /Users/pm215/src/qemu/tcg/i386/tcg-target.c:105:19: warning: cpuid.h: > > No such file

[Qemu-devel] [Bug 1087974] Re: [regression] vnc tight png produces garbled output

2012-12-10 Thread Tim Hardeck
47683d669f993308c2b84bed4ce64aafb5d7ced4 is the first bad commit commit 47683d669f993308c2b84bed4ce64aafb5d7ced4 Author: Gerd Hoffmann Date: Thu Oct 11 12:04:33 2012 +0200 pixman/vnc: remove rgb_prepare_row* functions Let pixman do it instead. Signed-off-by: Gerd Hoffmann :04000

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
On Fri, 07 Dec 2012 19:57:35 +0100 Andreas Färber wrote: > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > Caller of visit_type_unit_suffixed_int() will have to specify > > value of 'K' suffix via unit argument. > > For Kbytes it's 1024, for Khz it's 1000. > > > > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Stefano Stabellini
On Fri, 7 Dec 2012, Ian Jackson wrote: > Stefano Stabellini writes ("[Xen-devel] [PATCH 0/2] QEMU/xen: simplify > cpu_ioreq_pio and cpu_ioreq_move"): > > after reviewing the patch "fix multiply issue for int and uint types" > > with Ian Jackson, we realized that cpu_ioreq_pio and cpu_ioreq_move ar

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Jovanovic, Petar
> 0002-Make-repl_ph-to-sign-extended-to-target_long.patch > 0003-Fix-gen_HILO-to-make-it-adapt-each-arch-which-use-ac.patch Can you send examples/tests for the issues that you fix? It makes easier to review if you provide a simple example of a failing test. Petar

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread Igor Mammedov
On Fri, 7 Dec 2012 18:09:06 -0200 Eduardo Habkost wrote: > On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Signed-off-by: Igor Mammedov > > > --- > > > v2: > > >- replace visit_type_freq() with visit_type_unit_suffixed_i

[Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a magic number

2012-12-10 Thread Wei-Ren Chen
From the discussion on the ML [1], the exception limit defined by magic number 0x100 is actually EXCP_SC defined in cpu.h. Replace the magic number with EXCP_SC. Remove "#if 1 .. #endif" as well. [1] http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03080.html Signed-off-by: Chen Wei-Ren

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. > > Take a look at hw/vi

[Qemu-devel] What is the current state of the various usb implementations?

2012-12-10 Thread tom289332
Hello, I sent this to qemu-discuss a week ago and got no responses, so I'm trying here. Looking at `qemu-kvm -device ?`, there seem to be multiple usb implementations: ich9-usb-uhci2 ich9-usb-uhci3 ich9-usb-uhci1 piix3-usb-uhci piix4-usb-uhci vt82c686b-usb-uhci ich9-usb-ehci1 usb-ehci nec-usb-xhc

[Qemu-devel] [RFC PATCH v7 1/8] qdev : add a maximum device allowed field for the bus.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Add a max_dev field to BusState to specify the maximum amount of devices allowed on the bus ( have no effect if max_dev=0 ) Signed-off-by: KONRAD Frederic --- hw/qdev-core.h| 2 ++ hw/qdev-monitor.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/hw

[Qemu-devel] [RFC PATCH v7 2/8] virtio-bus : Introduce virtio-bus

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Introduce virtio-bus. Refactored transport device will create a bus which extends virtio-bus. Signed-off-by: KONRAD Frederic --- hw/Makefile.objs | 1 + hw/virtio-bus.c | 120 +++ hw/virtio-bus.h | 83 ++

[Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Here the virtio-blk-pci is modified for the new API. The device virtio-pci-blk extends virtio-pci. It creates and connects a virtio-blk during the init. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 113 +++- hw/v

[Qemu-devel] [PATCH] xen: fix trivial PCI passthrough MSI-X bug

2012-12-10 Thread Stefano Stabellini
We are currently passing entry->data as address parameter. Pass entry->addr instead. Signed-off-by: Stefano Stabellini Tested-by: Sander Eikelenboom Xen-devel: http://marc.info/?l=xen-devel&m=135515462613715 diff --git a/hw/xen_pt_msi.c b/hw/xen_pt_msi.c index 6807672..db757cd 100644 --- a/hw/x

Re: [Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-10 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-12-10 06:14, Matthew Ogilvie wrote: >> On Sun, Nov 25, 2012 at 02:51:36PM -0700, Matthew Ogilvie wrote: >>> This series makes a series of mostly-unrelated fixes to allow >>> running an old Microport UNIX (ca 1987) guest under qemu. >>> >>> Changes since version 6: >>>

Re: [Qemu-devel] [PULL] Memory API ioport cleanups

2012-12-10 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > As coordinated with Avi and Gerd, here's some ioport conversions to Memory > API. > > Cc: Avi Kivity > Cc: Gerd Hoffmann > Cc: Julien Grall > Cc: Jason Baron > > Pulled. Thanks. Regards, Anthony Liguori > The following changes since commit 16c6c80ac3a7

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06

2012-12-10 Thread Anthony Liguori
Andreas Färber writes: > Hello, > > This is my current QOM CPU patch queue. Please pull. > > Regards, > Andreas Pulled. Thanks. Regards, Anthony Liguori > > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: Paolo Bonzini > > > The following changes since commit 19e6c50d2d843220efbdd3b2db21d83c

Re: [Qemu-devel] [PULL 00/13] Trivial patches for 2 to 7 November

2012-12-10 Thread Anthony Liguori
Stefan Hajnoczi writes: > These patches were mostly submitted during the 1.3 hard freeze. I'll catch up > with the new trivial patches next week. > > The following changes since commit 80625b97b52836b944a6438e8e3e9d992e6a00b6: > > xilinx_uartlite: Accept input after rx FIFO pop (2012-12-05 09:

Re: [Qemu-devel] [PULL 00/18] acpi: switch to memory api

2012-12-10 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > Same patches as posted last week. No review comments, 1.4 tree > open, so it should be ready to go in now. > > cheers, > Gerd > > The following changes since commit 16c6c80ac3a772b42a87b77dfdf0fdac7c607b0e: > > Open up 1.4 development branch (2012-12-03 14:0

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2012-12-10 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move"): > On Fri, 7 Dec 2012, Ian Jackson wrote: ... > > +if (req->df) addr -= offset; > > +else addr -= offset; > > This can't be right, can it? Indeed not. v2 has this fixed. > The

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2012-12-06

2012-12-10 Thread Paolo Bonzini
Il 10/12/2012 17:57, Anthony Liguori ha scritto: > Andreas Färber writes: > >> Hello, >> >> This is my current QOM CPU patch queue. Please pull. >> >> Regards, >> Andreas > > Pulled. Thanks. Thanks, I'll rebase the directory stuff as soon as possible, please help reviewing it in the meantime! :

[Qemu-devel] [PATCH v2] kvm: Detect number of available memory slots from the host kernel

2012-12-10 Thread Alex Williamson
The kernel already exposes an interface for this, x86 returns a proper value and for the rest we can default to the defacto standard of 32. The primary motivation for this is to support more PCI assigned devices, both through pci-assign and vfio-pci. Signed-off-by: Alex Williamson --- v2: Test (!

Re: [Qemu-devel] [PATCH V17 4/6] rename qcow2-cache.c to block-cache.c

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > We will re-use qcow2-cache as block layer common cache code, > so change its name and made some changes, define a struct named > BlockTableType, pass BlockTableType and table size parameters to > block cache initialization function. > > Signed-off-by: D

Re: [Qemu-devel] [PATCH V17 6/6] qemu-iotests: add add-cow iotests support.

2012-12-10 Thread Kevin Wolf
Am 06.12.2012 07:51, schrieb Dong Xu Wang: > This patch will use qemu-iotests to test add-cow file format. > > Signed-off-by: Dong Xu Wang > --- > tests/qemu-iotests/017 |2 +- > tests/qemu-iotests/020 |2 +- > tests/qemu-iotests/common|6 ++ > tests/qemu-iotests/

Re: [Qemu-devel] [PATCH qom-cpu v2 0/5] target-alpha: CPU subclasses

2012-12-10 Thread Richard Henderson
On 12/08/2012 05:40 PM, Andreas Färber wrote: > Andreas Färber (5): > target-alpha: Let cpu_alpha_init() return AlphaCPU > alpha: Pass AlphaCPU array to Typhoon > target-alpha: Avoid leaking the alarm timer over reset > target-alpha: Turn CPU definitions into subclasses > target-alpha: Ad

[Qemu-devel] [RFC PATCH v7 4/8] virtio-pci : Refactor virtio-pci device.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic Create the virtio-pci device. This transport device will create a virtio-pci-bus, so one VirtIODevice can be connected. Signed-off-by: KONRAD Frederic --- hw/virtio-pci.c | 127 hw/virtio-pci.h | 19 + 2 fi

[Qemu-devel] [PATCH v2] tcg-i386: Perform cmov detection at runtime for 32-bit.

2012-12-10 Thread Richard Henderson
Cc: Aurelien Jarno Cc: Peter Maydell Signed-off-by: Richard Henderson --- configure | 19 +++ tcg/i386/tcg-target.c | 31 ++- tcg/i386/tcg-target.h | 5 - 3 files changed, 49 insertions(+), 6 deletions(-) Changes v1->v2: * Configur

Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:13:45PM +0100, Igor Mammedov wrote: > On Fri, 7 Dec 2012 18:09:06 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 07, 2012 at 08:00:09PM +0100, Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > > Signed-off-by: Igor Mammedov > > > > --- > >

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > On Fri, 07 Dec 2012 19:57:35 +0100 > Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Caller of visit_type_unit_suffixed_int() will have to specify > > > value of 'K' suffix via unit argument. > > > For

[Qemu-devel] [PATCHv2 1/2] qemu-img: find the highest offset in use during check

2012-12-10 Thread Federico Simoncelli
This patch adds the support for reporting the highest offset in use by an image. This is particularly useful after a conversion (or a rebase) where the destination is a block device in order to find the actual amount of space in use. Signed-off-by: Federico Simoncelli --- block.h

[Qemu-devel] [RFC PATCH v7 0/8] Virtio refactoring.

2012-12-10 Thread fred . konrad
From: KONRAD Frederic You can clone that from here : git.greensocs.com/home/greensocs/git/qemu_virtio.git virtio_refactoring_v7 These are the two last steps of refactoring ( only for virtio-blk device. ): * It modifies virtio-blk-pci to extend virtio-pci and to connect a virtio-blk du

Re: [Qemu-devel] Some patch about mips, gen_HILO bug fix.

2012-12-10 Thread Richard Henderson
On 12/10/2012 12:37 AM, Elta Era wrote: > tcg_gen_movi_tl(cpu_gpr[ret], \ > -(target_long)((int32_t)imm << 16 | \ > +(target_long)(int32_t)((int32_t)imm << 16 | \ > (uint32_t)(uint16_t)

Re: [Qemu-devel] [PATCH 1/4] fix implicit declaration of syscall() in linux-user/mmap.c

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: on glibc, this header is getting pulled in automatically via another header, however on musl we need to include it explicitly. linux-user/mmap.c:705:9: warning: implicit declaration of function 'syscall' linux-user/mmap.c:705:9: warning: nested extern d

Re: [Qemu-devel] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: the test for glibc< 2 "succeeds" wrongly for any non-glibc C library, and breaks the build on musl libc. we must first test if __GLIBC__ is defined at all, before using it unconditionally. Signed-off-by: John Spencer --- user-exec.c |2 +- 1 fi

[Qemu-devel] [PATCH 2/2] qemu-img: add json output option to the check command

2012-12-10 Thread Federico Simoncelli
This option --output=[human|json] make qemu-img check output an human or JSON representation at the choice of the user. Signed-off-by: Federico Simoncelli --- qapi-schema.json | 38 + qemu-img-cmds.hx |4 +- qemu-img.c | 246 +++---

Re: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is

Re: [Qemu-devel] [PATCH 3/4] fix implicit declaration of syscall() in linux-user/syscall.c

2012-12-10 Thread Stefan Weil
Am 10.12.2012 07:59, schrieb John Spencer: Signed-off-by: John Spencer --- linux-user/syscall.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 31d5276..fabbcd7 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscal

  1   2   >