Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.

2013-06-27 Thread Paolo Bonzini
Il 27/06/2013 20:28, Stefan Weil ha scritto: > Am 25.06.2013 18:25, schrieb Cornelia Huck: >> On hosts that support ioeventfd, make use of it for host-to-guest >> notifications via diagnose 500. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/s390x/css.c|2 +- >> hw/s390x/css.h

[Qemu-devel] [PATCH trivial] doc: we use seabios, not bochs bios

2013-06-27 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-doc.texi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 8022890..185dd47 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -214,7 +214,7 @@ PCI UHCI USB controller and a virtual USB hub. SMP is

[Qemu-devel] [Bug 1195482] Re: sudo make install doesn't install qemu binary

2013-06-27 Thread Stefan Weil
The binary "qemu" is now called "qemu-system-i386". QEMU provides more than one binary since several years. Here is the list for system emulation: qemu-system-alpha, qemu-system-arm, qemu-system-cris, qemu-system-i386, qemu-system-lm32, qemu-system-m68k, qemu-system-microblazeel, qemu-system-mic

[Qemu-devel] [PATCH V4 7/7] monitor: improve "help" to allow show details of single command in sub group

2013-06-27 Thread Wenchao Xia
A new parameter type 'S' is introduced to allow user input any string. "help info block" do not tip extra parameter error now. Signed-off-by: Wenchao Xia --- hmp-commands.hx |2 +- monitor.c | 30 +- 2 files changed, 30 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH V4 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-06-27 Thread Wenchao Xia
In help functions info_cmds is treated as sub command group now, not as a special case any more. Still help can't show message for single command under "info", since command parser reject additional parameter, which can be improved by change "help" item parameter define later. "log" is still treate

[Qemu-devel] [PATCH V4 6/7] monitor: improve "help" in auto completion for sub command

2013-06-27 Thread Wenchao Xia
Now special case "help *" in auto completion can work with sub commands, such as "help info a*". Signed-off-by: Wenchao Xia --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 5a66fb0..d07f6ec 100644 --- a/monitor.c +++ b/monito

[Qemu-devel] [PATCH V4 5/7] monitor: support sub commands in auto completion

2013-06-27 Thread Wenchao Xia
This patch allow auto completion work normal for sub command case, "info block [DEVICE]" can auto complete now, by re-enter the completion function. Also, original "info" is treated as a special case, now it is treated as a sub command group, global variable info_cmds is not used in any more. "hel

[Qemu-devel] [PATCH V4 0/7] monitor: support sub command group in auto completion and help

2013-06-27 Thread Wenchao Xia
Global variable *mon_cmds and *info_cmds are not directly used any more, *cur_mon is not used in completion related functions. It is possible to create a monitor with different command table now, but that requirement do not exist yet, so not changed it to save trouble. Log command is still a specia

[Qemu-devel] [PATCH V4 2/7] monitor: avoid direct use of global variable *mon_cmds

2013-06-27 Thread Wenchao Xia
New member *cmd_table is added in structure Monitor to avoid direct usage of *mon_cmds. Now monitor have an associated command table, when global variable *info_cmds is also discarded, structure Monitor would gain full control about how to deal with user input. Signed-off-by: Wenchao Xia Reviewed

[Qemu-devel] [PATCH V4 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-06-27 Thread Wenchao Xia
Parameter *mon is added to replace *cur_mon, and readline_completion() pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). In short, structure ReadLineState controls where the action would be taken now. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake

[Qemu-devel] [PATCH V4 3/7] monitor: code move for parse_cmdline()

2013-06-27 Thread Wenchao Xia
get_str() is called by parse_cmdline() so it is moved also. Some code style error reported by check script, is also fixed. Signed-off-by: Wenchao Xia --- monitor.c | 191 +++-- 1 files changed, 98 insertions(+), 93 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent"

2013-06-27 Thread Lei Li
On 06/27/2013 10:22 PM, Markus Armbruster wrote: This reverts commit 6a85e60cb994bd95d1537aafbff65816f3de4637. Commit 51767e7 "qemu-char: Add new char backend CirMemCharDriver" introduced a memory ring buffer character device driver named "memory". Commit 3949e59 "qemu-char: Saner naming of mem

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
On 06/27/2013 04:54 PM, Stefan Hajnoczi wrote: The interesting question is how effective this approach is. If it's good enough then it would be a fairly simple modification to dump.c. I see, if excluding zero page in ELF can make a lot of size reduce, it's better to choose this method. But th

[Qemu-devel] [PATCH V1 2/2] Add tests for sync modes 'TOP' and 'NONE'

2013-06-27 Thread Ian Main
This patch adds tests for sync modes top and none. I'd be interested in hearing ideas on how to improve these tests if people feel they are inadequate. Especially SYNC_MODE_NONE would be hard to test. Signed-off-by: Ian Main --- tests/qemu-iotests/055 | 63 +

[Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-06-27 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies change

[Qemu-devel] [PATCH V1 0/2] Implement sync modes for drive-backup.

2013-06-27 Thread Ian Main
This patch adds sync modes on top of the work that Stefan Hajnoczi has done. These patches apply on kevin/block with '[PATCH] block: add drive_backup HMP command' also applied. Hopefully all is in order as this is my first QEMU patch. Many thanks to Stephan and Fam Zheng for their help. I tri

Re: [Qemu-devel] [PATCH V3 1/7] monitor: discard global variable *cur_mon in completion functions

2013-06-27 Thread Wenchao Xia
于 2013-6-28 5:26, Eric Blake 写道: On 06/26/2013 09:27 PM, Wenchao Xia wrote: Parameter *mon is added to replace *cur_mon, and readline_completion() pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). In short, structure ReadLineState controls where the

[Qemu-devel] Patch to fix linux for sh4.

2013-06-27 Thread Rob Landley
I have images that boot under qemu-system-sh4 at: http://landley.net/aboriginal/bin/system-image-sh4.tar.bz2 But in order to get them to work with current kernels, I have to apply the attached sh4.patch to qemu. What I did with earlier kernels was apply the attached linux-fixsh4-2.patch

[Qemu-devel] Openbios upgrade broke sparc32 linux.

2013-06-27 Thread Rob Landley
Commit 467b34689d27 upgraded the openbios image, and ever since my linux system images hang about the time they try to initialize interrupts. http://landley.net/aboriginal/bin/system-image-sparc.tar.bz2 Extract that and "./run-emulator.sh" in the tarball. Using qemu 1.2.0 for example works

[Qemu-devel] [Bug 1195482] [NEW] sudo make install doesn't install qemu binary

2013-06-27 Thread Karl-Philipp Richter
Public bug reported: Hi together, I noticed that ./configure && make && sudo make install (e.g. on branch stable-1.5) no longer installs the qemu binary (in /usr/bin or /usr/local/bin. It would be nice if this works out-of-the-box. Thanks in advance for taking care about this. ** Affects: qemu

Re: [Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-27 Thread Claudio Fontana
> Claudio Fontana writes: > > Shehbaz Jaffer wrote: > > > >> I want to determine the amount of screen activity taking place on VGA > >> monitor/ Screen for different applications (eg. playing vlc video, normal > >> typing.) > >> > >> When I do not start the X server, I can easily determine the scr

Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-27 Thread Fam Zheng
On Thu, 06/27 13:40, Paolo Bonzini wrote: > Il 27/06/2013 13:37, Fam Zheng ha scritto: > >>> > > > >>> > > Yes, this makes me realize that ref count it not a solution to retire > >>> > > bs->in_use, because we can't tell if drive-del or block-resize is safe > >>> > > with only reference number. Bu

Re: [Qemu-devel] [PATCH 3/6] rdma: core logic

2013-06-27 Thread Peter Maydell
On 27 June 2013 23:44, wrote: > +if test "$rdma" != "no" ; then > + cat > $TMPC < +#include > +int main(void) { return 0; } > +EOF > + rdma_libs="-lrdmacm -libverbs" > + if compile_prog "-Werror" "$rdma_libs" ; then Do you really need -Werror in your test's CFLAGS? If so, you need a comment

Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

2013-06-27 Thread Eric Blake
On 06/27/2013 08:22 AM, Markus Armbruster wrote: > Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" > assertion. Broken in commit 1da48c65. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster > --- > qemu-char.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

[Qemu-devel] [PATCH] q35 chipset: Extend support of SMBUS(module pm_smbus.c) HST_STS register v2.

2013-06-27 Thread Maksim Ratnikov
From b4c324b42b488aca76aae06c8fa23a45acd91fcf Mon Sep 17 00:00:00 2001 From: MRatnikov Date: Fri, 28 Jun 2013 02:57:51 +0400 Subject: [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS register v2 Signed-off-by: MRatnikov --- Previous realization doesn't consider flags in the status

Re: [Qemu-devel] [PATCH 4/6] rdma: allow state transitions between other states besides ACTIVE

2013-06-27 Thread Eric Blake
On 06/27/2013 04:44 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP > state was not really a 'formal' state. It has been used as a 'zero' state > and QEMU has been unconditionally transitioning into

Re: [Qemu-devel] [PATCH 1/6] rdma: update documentation to reflect new unpin support

2013-06-27 Thread Eric Blake
On 06/27/2013 04:44 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As requested, the protocol now includes memory unpinning support. > This has been implemented in a non-optimized manner, in such a way > that one could devise an LRU or other workload-specific information > o

Re: [Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP

2013-06-27 Thread Eric Blake
On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This exposes throughput (in megabits/sec) through QMP. > > Reviewed-by: Juan Quintela > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod > Tested-by: Michael R. Hines > Sig

Re: [Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-27 Thread Eric Blake
On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Using the previous patches, we're now able to timestamp the SETUP > state. Once we have this time, let the user know about it in the > schema. > > Reviewed-by: Juan Quintela > Signed-off-by: Michael R. Hine

Re: [Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed()

2013-06-27 Thread Peter Maydell
On 27 June 2013 23:44, wrote: > arch_init.c | 29 +++-- > include/migration/migration.h |2 ++ Implementation in arch_init.c but prototype in migration.h? The function pretty clearly has nothing to do with initialization anyway, which suggests it's

Re: [Qemu-devel] [PATCH v12 01/15] rdma: add documentation

2013-06-27 Thread Michael R. Hines
On 06/27/2013 06:41 PM, Eric Blake wrote: On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vi

[Qemu-devel] [PATCH 4/6] rdma: allow state transitions between other states besides ACTIVE

2013-06-27 Thread mrhines
From: "Michael R. Hines" This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state and QEMU has been unconditionally transitioning into this state when the QMP migrate command was called. In preparation

[Qemu-devel] [PATCH 2/6] rdma: introduce ram_handle_compressed()

2013-06-27 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. H

[Qemu-devel] [PATCH 6/6] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-27 Thread mrhines
From: "Michael R. Hines" Using the previous patches, we're now able to timestamp the SETUP state. Once we have this time, let the user know about it in the schema. Reviewed-by: Juan Quintela Signed-off-by: Michael R. Hines --- hmp.c |4 include/migration/migra

[Qemu-devel] [PATCH 1/6] rdma: update documentation to reflect new unpin support

2013-06-27 Thread mrhines
From: "Michael R. Hines" As requested, the protocol now includes memory unpinning support. This has been implemented in a non-optimized manner, in such a way that one could devise an LRU or other workload-specific information on top of the basic mechanism to influence the way unpinning happens du

[Qemu-devel] [PATCH 0/6] rdma: core logic and unpin support

2013-06-27 Thread mrhines
From: "Michael R. Hines" Changes: - Per request, basic (compile-time-enabled) unpin support is available, but turned off by default. Michael R. Hines (6): rdma: update documentation to reflect new unpin support rdma: introduce ram_handle_compressed() rdma: core logic rdma: allow state

[Qemu-devel] [PATCH 5/6] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-27 Thread mrhines
From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (what we're calling 'NONE' here) and QEMU has been unconditionally transitioning into this state when the QMP migration command was

Re: [Qemu-devel] [PATCH v12 01/15] rdma: add documentation

2013-06-27 Thread Eric Blake
On 06/25/2013 07:35 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > docs/rdma.txt contains full documentation, > wiki links, github url and contact information. > > Reviewed-by: Juan Quintela > Reviewed-by: Paolo Bonzini > Reviewed-by: Chegu Vinod > Tested-by: Chegu Vinod

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Juan Quintela
Juan Quintela wrote: > Peter Maydell wrote: >> On 27 June 2013 11:37, Juan Quintela wrote: >>> Anthony, please pull. >>> >>> - improve error message (Alon) >>> - Make zero pages to work again (Peter Lieven) >>> - First 10 patches of RDMA support >> >> Hi; could you adjust your pullrequest scrip

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Peter Maydell
On 28 June 2013 06:27, Juan Quintela wrote: > Sorry, actually my problem was dtc, that for some reason got wrong :-( > > $ time make -j3 -C /scratch/tmp/all/make: Entering directory > `/scratch/tmp/all' > config-host.mak is out-of-date, running configure > > ERROR: DTC not present. Your options

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Juan Quintela
Peter Maydell wrote: > On 27 June 2013 11:37, Juan Quintela wrote: >> Anthony, please pull. >> >> - improve error message (Alon) >> - Make zero pages to work again (Peter Lieven) >> - First 10 patches of RDMA support > > Hi; could you adjust your pullrequest scripts to retransmit > the patches a

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-27 Thread Tomoki Sekiyama
On 6/27/13 11:01 , "Laszlo Ersek" wrote: >On 06/26/13 16:32, Laszlo Ersek wrote: >> On 06/25/13 18:03, Laszlo Ersek wrote: >>> On 06/06/13 17:06, Tomoki Sekiyama wrote: +chk(pColl->get_Count(&n)); +for (i = n - 1; i >= 0; i--) { +chk(pColl->get_Item(i, (IDispatch **)

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Eric Blake
On 06/27/2013 07:29 AM, Luiz Capitulino wrote: > On Thu, 27 Jun 2013 12:05:33 +0200 > Gerd Hoffmann wrote: > +# @device: #optional specifies framebuffer device, default: /dev/fb0 >>> >>> Actually, it will try to get the device name from an env variable first, >>> which sounds too automatic

Re: [Qemu-devel] [PATCH 2/2] fbdev: add monitor commands to enable/disable/query

2013-06-27 Thread Eric Blake
On 06/26/2013 09:56 AM, Luiz Capitulino wrote: > On Wed, 26 Jun 2013 13:38:04 +0200 > Gerd Hoffmann wrote: > >> This patch adds a fbdev monitor command to enable/disable >> the fbdev display at runtime to both qmp and hmp. >> >> +## >> +# @framebuffer-display: > > Let me bike-shed: we're trying

Re: [Qemu-devel] [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS register.

2013-06-27 Thread Anthony Liguori
Maksim Ratnikov writes: > 27.06.2013 20:33, Peter Maydell пишет: >> On 27 June 2013 14:16, Maksim Ratnikov wrote: >>> Ping? >>> I send update of my patch at April 29. Link for my patch at patchwork: >>> http://patchwork.ozlabs.org/patch/240525/ . Link for my response in >>> mailing-list: >>> h

Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

2013-06-27 Thread Petar Jovanovic
From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson [r...@twiddle.net] Sent: Thursday, June 27, 2013 8:20 PM To: Petar Jovanovic Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net Subject: Re: [Qemu-devel] [PATCH] targe

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Alex Bligh
--On 27 June 2013 16:53:40 +0200 Stefan Hajnoczi wrote: I realized I should give a bit more info to help you get started. tests/qemu-iotests/check is the script to run tests. There are currently around 55 tests which exercise operations using qemu-img(1), qemu-io(1), and sometimes by runnin

Re: [Qemu-devel] [PATCH V3 1/7] monitor: discard global variable *cur_mon in completion functions

2013-06-27 Thread Eric Blake
On 06/26/2013 09:27 PM, Wenchao Xia wrote: > Parameter *mon is added to replace *cur_mon, and readline_completion() > pass rs->mon as value, which should be initialized in readline_init() > called by monitor_init(). In short, structure ReadLineState controls > where the action would be taken now. >

Re: [Qemu-devel] [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS register.

2013-06-27 Thread Maksim Ratnikov
27.06.2013 20:33, Peter Maydell пишет: On 27 June 2013 14:16, Maksim Ratnikov wrote: Ping? I send update of my patch at April 29. Link for my patch at patchwork: http://patchwork.ozlabs.org/patch/240525/ . Link for my response in mailing-list: http://lists.nongnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [PATCH] linux-user: Fix compilation failure

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:53 PM, Peter Maydell wrote: Fix compilation failures for linux-user targets following recent migration related commits bd2fa51fcd and 43487c67. Signed-off-by: Peter Maydell --- Longer term we should probably try to disentangle migration from user-mode emulators a bit better (eg

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:20 PM, Peter Maydell wrote: On 27 June 2013 11:37, Juan Quintela wrote: Anthony, please pull. - improve error message (Alon) - Make zero pages to work again (Peter Lieven) - First 10 patches of RDMA support Hi; could you adjust your pullrequest scripts to retransmit the patc

Re: [Qemu-devel] [PATCH v12 08/15] rdma: introduce qemu_ram_foreach_block()

2013-06-27 Thread Michael R. Hines
On 06/27/2013 03:24 PM, Peter Maydell wrote: On 26 June 2013 02:35, wrote: --- a/exec.c +++ b/exec.c @@ -2630,3 +2630,12 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr) memory_region_is_romd(mr)); } #endif + +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaqu

[Qemu-devel] [PATCH] linux-user: Fix compilation failure

2013-06-27 Thread Peter Maydell
Fix compilation failures for linux-user targets following recent migration related commits bd2fa51fcd and 43487c67. Signed-off-by: Peter Maydell --- Longer term we should probably try to disentangle migration from user-mode emulators a bit better (eg hw.h should probably not pull in any of the mi

Re: [Qemu-devel] [PATCH v4] Add timestamp to error message

2013-06-27 Thread Eric Blake
On 06/27/2013 04:21 AM, Laszlo Ersek wrote: > comments below > > On 06/27/13 04:08, Seiji Aguchi wrote: >> [Issue] >> When we offer a customer support service and a problem happens >> in a customer's system, we try to understand the problem by >> comparing what the customer reports with message lo

Re: [Qemu-devel] [PATCH V2 3/7] monitor: discard global variable *info_cmds in help functions

2013-06-27 Thread Eric Blake
On 06/24/2013 06:48 AM, Wenchao Xia wrote: In the subject line, you aren't actually discarding a global variable, so much as avoiding its direct use (the global still exists). Maybe a better subject line would be: monitor: avoid direct use of global *info_cmds in help functions (2/7 has the sam

Re: [Qemu-devel] [PATCH v12 08/15] rdma: introduce qemu_ram_foreach_block()

2013-06-27 Thread Peter Maydell
On 26 June 2013 02:35, wrote: > --- a/exec.c > +++ b/exec.c > @@ -2630,3 +2630,12 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr) > memory_region_is_romd(mr)); > } > #endif > + > +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque) > +{ > +RAMBlock *block; > +

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Peter Maydell
On 27 June 2013 11:37, Juan Quintela wrote: > Anthony, please pull. > > - improve error message (Alon) > - Make zero pages to work again (Peter Lieven) > - First 10 patches of RDMA support Hi; could you adjust your pullrequest scripts to retransmit the patches as followup emails to the pullreq m

Re: [Qemu-devel] [PULL 00/12] migration queue

2013-06-27 Thread Peter Maydell
On 27 June 2013 11:37, Juan Quintela wrote: > Anthony, please pull. > > - improve error message (Alon) > - Make zero pages to work again (Peter Lieven) > - First 10 patches of RDMA support Hi. I'm afraid this broke compilation of linux-user targets: CCarm-linux-user/exec.o In file include

[Qemu-devel] [PATCH] arch_init: Fix format string by using RAM_ADDR_FMT

2013-06-27 Thread Stefan Weil
length is a ram_addr_t, so RAM_ADDR_FMT must be used instead of %ld. This fixes a recently introduced regression for w64 builds. Using RAM_ADDR_FMT also changes decimal output to sedecimal. This is good here because length and block->length should both use the same base in the error message. Sign

Re: [Qemu-devel] [PATCH] linux-user: Move cpu_clone_regs() and cpu_set_tls() into linux-user

2013-06-27 Thread Peter Maydell
On 25 June 2013 12:49, Andreas Färber wrote: > Am 25.06.2013 12:35, schrieb Peter Maydell: >> The functions cpu_clone_regs() and cpu_set_tls() are not purely CPU >> related -- they are specific to the TLS ABI for a a particular OS. >> Move them into the linux-user/ tree where they belong. > This

Re: [Qemu-devel] [PULL 2/3] virtio-ccw: Wire up ioeventfd.

2013-06-27 Thread Stefan Weil
Am 25.06.2013 18:25, schrieb Cornelia Huck: > On hosts that support ioeventfd, make use of it for host-to-guest > notifications via diagnose 500. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/css.c|2 +- > hw/s390x/css.h|1 + > hw/s390x/virtio-ccw.c | 117 > +

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

2013-06-27 Thread Richard Henderson
On 06/17/2013 03:40 PM, Petar Jovanovic wrote: > From: Petar Jovanovic > > Multiplication of Q15 fractional halfword vectors was incorrect in the > previous implementation of mipsdsp_rndq15_mul_q15_q15. It failed to take > element signs into account. This change fixes it, and it adds a test case

Re: [Qemu-devel] [PATCH] target-mips: fix mipsdsp_trunc16_sat16_round

2013-06-27 Thread Richard Henderson
On 06/17/2013 03:39 PM, Petar Jovanovic wrote: > -int64_t temp; > - > -temp = (int32_t)a + 0x8000; > +uint16_t temp; > > -if (a > (int)0x7fff8000) { > -temp = 0x7FFF; > +if (a > 0x7FFF7FFF) { > +temp = 0x7FFF; > set_DSPControl_overflow_flag(1, 2

[Qemu-devel] [PATCH v2] xen_disk: support "direct-io-safe" backend option

2013-06-27 Thread Stefano Stabellini
Support backend option "direct-io-safe". This is documented as follows in the Xen backend specification: * direct-io-safe * Values: 0/1 (boolean) * Default Value: 0 * * The underlying storage is not affected by the direct IO memory * lifetime bug. See: *

Re: [Qemu-devel] [RFC] bitops: Provide sext32() and sext64() for signextending bitfields

2013-06-27 Thread Peter Maydell
On 27 June 2013 18:58, Markus Armbruster wrote: > Peter Maydell writes: >> Does the API look right? The other approach I thought of would >> be to have functions sextract32()/sextract64() which work like >> the existing extract{32,64} but return signed (and sign >> extended) values, but providing

Re: [Qemu-devel] [RFC] bitops: Provide sext32() and sext64() for signextending bitfields

2013-06-27 Thread Markus Armbruster
Peter Maydell writes: > A common operation in instruction decoding is to take a field > from an instruction that represents a signed integer in some > arbitrary number of bits, and sign extend it into a C signed > integer type for manipulation. Provide new functions sext32() > and sext64() to abs

Re: [Qemu-devel] [PATCH 2/4] linux-user: Use existing envlist_parse_set/envlist_parse_unset interface.

2013-06-27 Thread Peter Maydell
On 29 May 2013 14:50, Thomas Schwinge wrote: > Signed-off-by: Thomas Schwinge > --- > linux-user/main.c | 18 -- > util/envlist.c|4 ++-- > 2 files changed, 6 insertions(+), 16 deletions(-) > > diff --git linux-user/main.c linux-user/main.c > index b97b8cf..a0ea161 1006

Re: [Qemu-devel] [PATCH V2 2/7] monitor: discard global variable *mon_cmds

2013-06-27 Thread Eric Blake
On 06/24/2013 06:48 AM, Wenchao Xia wrote: > New member *cmd_table is added in structure Monitor to avoid direct usage of > *mon_cmds. Now monitor have an associated command table, when global variable > *info_cmds is also discarded, structure Monitor would gain full control about > how to deal wit

Re: [Qemu-devel] [PATCH 4/4] linux-user: Restore original behavior of the -E and -U command-line options.

2013-06-27 Thread Peter Maydell
On 29 May 2013 14:50, Thomas Schwinge wrote: > Revert the change in behavior that had been introducecd in commit > fc9c54124d134dbd76338a92a91804dab2df8166 for the -E and -U command-line > options, but keep the comma-splitting for the QEMU_SET_ENV and QEMU_UNSET_ENV > environment variables. > > Si

Re: [Qemu-devel] [PATCH] user-exec.c: Set is_write correctly in the ARM cpu_signal_handler()

2013-06-27 Thread Peter Maydell
On 27 June 2013 17:59, Andreas Färber wrote: > Am 04.06.2013 15:31, schrieb Peter Maydell: >> +/* error_code is the FSR value, in which bit 11 is WnR (assuming a v6 or >> + * later processor; on v5 we will always report this as a read). >> + */ >> +is_write = extract32(uc->uc_mcont

Re: [Qemu-devel] [PATCH V2 1/7] monitor: discard global variable *cur_mon in completion functions

2013-06-27 Thread Eric Blake
On 06/24/2013 06:48 AM, Wenchao Xia wrote: > Parameter *mon is added to replace *cur_mon, and readline_completion() > pass rs->mon as value, which should be initialized in readline_init() > called by monitor_init(). In short, structure ReadLineState controls > where the action would be taken now. >

Re: [Qemu-devel] [PATCH 1/4] util/envlist: Properly forward a callback's error in envlist_parse.

2013-06-27 Thread Peter Maydell
On 29 May 2013 14:50, Thomas Schwinge wrote: > Signed-off-by: Thomas Schwinge Reviewed-by: Peter Maydell > --- > util/envlist.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git util/envlist.c util/envlist.c > index ebc06cf..cbbf7e5 100644 > --- util/envlist.c > +

Re: [Qemu-devel] [PATCH v2] linux-user: improve target_to_host_sock_type conversion

2013-06-27 Thread Peter Maydell
On 1 April 2013 16:49, Petar Jovanovic wrote: > From: Petar Jovanovic > > Previous implementation has failed to take into account different value of > SOCK_NONBLOCK on target and host, and existence of SOCK_CLOEXEC. > The same conversion has to be applied both for do_socket and do_socketpair, > s

Re: [Qemu-devel] [PATCH V2 0/7] monitor: support sub command group in auto completion and help

2013-06-27 Thread Eric Blake
On 06/24/2013 06:48 AM, Wenchao Xia wrote: > Global variable *mon_cmds and *info_cmds are not used any more, *cur_mon is > not > used in completion related functions. It is possible to create a monitor with > different command table now, but that requirement do not exist yet, so not > changed > i

Re: [Qemu-devel] [PATCH v3] Add timestamp to error message

2013-06-27 Thread Eric Blake
On 06/26/2013 04:20 PM, Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > +#include "qemu-common.h" >

Re: [Qemu-devel] [PATCH] linux-user: handle /proc/$$ like /proc/self

2013-06-27 Thread Peter Maydell
On 8 May 2013 11:31, Andreas Schwab wrote: > Some applications use /proc/$$/... (where $$ is the own pid) instead of > /proc/self/... to refer to their own proc files. Extend the interception > for open and readlink to handle this case. Also, do the same interception > in readlinkat. > > Signed-

Re: [Qemu-devel] [PATCH] hw/mips: align initrd to 64KB to avoid kernel error

2013-06-27 Thread James Hogan
On 27/06/13 09:12, Peter Maydell wrote: > On 27 June 2013 08:35, Leon Alrae wrote: >> From: James Hogan >> >> The Linux kernel can be configured to use 64KB pages, but it also >> requires initrd to be page aligned. Therefore, to be safe, align the >> initrd to 64KB using a new INITRD_PAGE_MASK ra

Re: [Qemu-devel] [PATCH] user-exec.c: Set is_write correctly in the ARM cpu_signal_handler()

2013-06-27 Thread Andreas Färber
Am 04.06.2013 15:31, schrieb Peter Maydell: > In the ARM implementation of cpu_signal_handler(), set is_write > correctly using the FSR value which the kernel passes us in the > error_code field of uc_mcontext. Since the WnR bit of the FSR was > only introduced in ARMv6, this means that v5 cores wi

Re: [Qemu-devel] [PATCH] user-exec.c: Set is_write correctly in the ARM cpu_signal_handler()

2013-06-27 Thread Peter Maydell
Ping! thanks -- PMM On 4 June 2013 14:31, Peter Maydell wrote: > In the ARM implementation of cpu_signal_handler(), set is_write > correctly using the FSR value which the kernel passes us in the > error_code field of uc_mcontext. Since the WnR bit of the FSR was > only introduced in ARMv6, this

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] char/cadence_uart: Fix reset for unattached instances

2013-06-27 Thread Peter Maydell
On 7 June 2013 05:02, wrote: > From: Peter Crosthwaite > > commit 1db8b5efe0c2b5000e50691eea61264a615f43de introduced an issue > where QEMU would segfault if you have an unattached Cadence UART. > > Fix by guarding the flush-on-reset logic on there being a qemu_chr > attachment. > > Reported-by:

Re: [Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-27 Thread Anthony Liguori
Claudio Fontana writes: > Shehbaz Jaffer wrote: > >> I want to determine the amount of screen activity taking place on VGA >> monitor/ Screen for different applications (eg. playing vlc video, normal >> typing.) >> >> When I do not start the X server, I can easily determine the screen activity

Re: [Qemu-devel] [RFC] bitops: Provide sext32() and sext64() for signextending bitfields

2013-06-27 Thread Richard Henderson
On 06/27/2013 08:47 AM, Peter Maydell wrote: > A common operation in instruction decoding is to take a field > from an instruction that represents a signed integer in some > arbitrary number of bits, and sign extend it into a C signed > integer type for manipulation. Provide new functions sext32()

Re: [Qemu-devel] [PATCH] Extend support of SMBUS(module pm_smbus.c) HST_STS register.

2013-06-27 Thread Peter Maydell
On 27 June 2013 14:16, Maksim Ratnikov wrote: > Ping? > I send update of my patch at April 29. Link for my patch at patchwork: > http://patchwork.ozlabs.org/patch/240525/ . Link for my response in > mailing-list: > http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg05850.html > Can you t

Re: [Qemu-devel] [PATCH qom-cpu v2 20/29] kvm: Change kvm_remove_all_breakpoints() argument to CPUState

2013-06-27 Thread Andreas Färber
Am 17.06.2013 18:17, schrieb Paolo Bonzini: > Il 16/06/2013 17:57, Andreas Färber ha scritto: >> Signed-off-by: Andreas Färber >> --- >> gdbstub.c| 2 +- >> include/sysemu/kvm.h | 2 +- >> kvm-all.c| 5 ++--- >> kvm-stub.c | 2 +- >> 4 files changed, 5 insertions

[Qemu-devel] [RFC] bitops: Provide sext32() and sext64() for signextending bitfields

2013-06-27 Thread Peter Maydell
A common operation in instruction decoding is to take a field from an instruction that represents a signed integer in some arbitrary number of bits, and sign extend it into a C signed integer type for manipulation. Provide new functions sext32() and sext64() to abstract away the bit manipulation.

[Qemu-devel] [PATCH] target-arm: avoid undefined behaviour when writing TTBCR

2013-06-27 Thread Peter Maydell
LPAE CPUs have more potentially valid bits in the TTBCR, and so the simple masking out of invalid bits is no longer sufficient to obtain the base address width field of the register, which is what we use to precalculate c2_mask and c2_base_mask. Explicitly extract the relevant register field rathe

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Eric Blake
On 06/27/2013 07:52 AM, Peter Lieven wrote: > .has_zero_init defaults to 1 for all formats and protocols. > > this is a dangerous default since this means that all > new added drivers need to manually overwrite it to 0 if > they do not ensure that a device is zero initialized > after bdrv_create()

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-27 Thread Laszlo Ersek
On 06/26/13 16:32, Laszlo Ersek wrote: > On 06/25/13 18:03, Laszlo Ersek wrote: >> On 06/06/13 17:06, Tomoki Sekiyama wrote: >>> +/* Unregister this module from COM+ Applications Catalog */ >>> +STDAPI COMUnregister(void) >>> +{ >>> +HRESULT hr; >>> +IUnknown *pUnknown = NULL; >>> +ICO

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 4:43 PM, Stefan Hajnoczi wrote: > On Thu, Jun 27, 2013 at 4:25 PM, Timothy Scott wrote: >> - Is there currently a testing suite/procedure for verifying new block >> drivers? > > There is a test suite in tests/qemu-iotests/. You will need to add > support for PVFS2, see

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Richard W.M. Jones
On Thu, Jun 27, 2013 at 03:52:34PM +0200, Peter Lieven wrote: > +/* save default */ A minor thing, but s/save/safe/ :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or ove

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 4:25 PM, Timothy Scott wrote: > I am working on adding block driver support for PVFS2 that will allow images > stored on PVFS2 systems to bypass the kernel module and hopefully improve > performance significantly. What performance bottlenecks are you seeing in the kernel w

[Qemu-devel] PVFS2 Block Driver Support

2013-06-27 Thread Timothy Scott
I am working on adding block driver support for PVFS2 that will allow images stored on PVFS2 systems to bypass the kernel module and hopefully improve performance significantly. I have been modeling my changes off of the GlusterFS block driver implementation. *Can you please advise on a couple of

[Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf"

2013-06-27 Thread Markus Armbruster
Commit 1da48c6 called the new member "memory" after commit 3949e59 standardized "ringbuf". Rename for consistency. However, member name "memory" is visible in QMP since 1.5. It's undocumented just like the driver name. Keep it working anyway. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Ar

[Qemu-devel] [PATCH 0/4] qemu-char: ringbuf fixes

2013-06-27 Thread Markus Armbruster
The first patch is a straightforward bug fix. The rest fix code to match documentation. The patches take pains to preserve command-line, HMP and QMP bug-compatibility. I'm not sure that's actually needed, because: * All: the documented way to use the driver never worked in any released versio

[Qemu-devel] [PATCH 2/4] Revert "chardev: Make the name of memory device consistent"

2013-06-27 Thread Markus Armbruster
This reverts commit 6a85e60cb994bd95d1537aafbff65816f3de4637. Commit 51767e7 "qemu-char: Add new char backend CirMemCharDriver" introduced a memory ring buffer character device driver named "memory". Commit 3949e59 "qemu-char: Saner naming of memchar stuff & doc fixes" changed the driver name to

[Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size

2013-06-27 Thread Markus Armbruster
Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER" assertion. Broken in commit 1da48c65. Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 63972ae..63a9

[Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf"

2013-06-27 Thread Markus Armbruster
The driver is new in 1.4, with the documented name "ringbuf". However, it's actual name is the completely undocumented "memory". Screwed up in commit 3949e59. Fix code to match documentation. Keep the undocumented name working as an alias for compatibility. Cc: qemu-sta...@nongnu.org Signed-off-

Re: [Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-27 Thread Claudio Fontana
Shehbaz Jaffer wrote: > I want to determine the amount of screen activity taking place on VGA > monitor/ Screen for different applications (eg. playing vlc video, normal > typing.) > > When I do not start the X server, I can easily determine the screen activity > by counting the number of page

[Qemu-devel] [PATCH] sd/pl181.c: Avoid undefined shift behaviour in RWORD macro

2013-06-27 Thread Peter Maydell
Add a cast to avoid potentially shifting into the sign bit of a signed value, which is undefined behaviour in C. (Detected with clang's -fsanitize=undefined.) Signed-off-by: Peter Maydell --- Not the only problem clang detects by a long shot. I don't know if we even want to try to fix the warnin

Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-27 Thread Stefan Hajnoczi
On Thu, Jun 27, 2013 at 12:06:44PM +0200, Paolo Bonzini wrote: > Il 27/06/2013 10:17, Stefan Hajnoczi ha scritto: > >>> > > Il 26/06/2013 05:59, Fam Zheng ha scritto: > >>> > > This leads to another observation: a sync:'none' block-backup job > >>> > > probably should never complete, and should ins

  1   2   >