[Qemu-devel] [PATCH 0/2] Clarify licensing terms

2013-07-31 Thread Paolo Bonzini
Here is a list of license-less files: audio/audio_pt_int.c audio/audio_win_int.c audio/paaudio.c audio/wavcapture.c audio/winwaveaudio.c block/raw.c bsd-user/bsdload.c bsd-user/elfload.c bsd-user/strace.c bsd-user/uaccess.c

[Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Paolo Bonzini
Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com Cc: Markus

[Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-07-31 Thread Paolo Bonzini
1) The GPL says that if the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. This is not true, QEMU includes parts that are v2-only. 2) Provide a default for files with no licensing information. 3) It is not

Re: [Qemu-devel] Licensing question

2013-07-31 Thread Paolo Bonzini
Il 31/07/2013 07:45, Erik de Castro Lopo ha scritto: Stefan Weil wrote: No, there is no such statement. There is an agreement that files with GPL should be GPLv2+ (not only GPLv2), but files may also use other free licenses. In file LICENSE, it is said that QEMU as a whole is released

[Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Michal Novotny
Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded to have to have this patch

[Qemu-devel] [PATCH V7 06/11] NUMA: parse guest numa nodes memory policy

2013-07-31 Thread Wanlong Gao
The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of -numa mem,, the memory policy then can be set like following: -numa node,nodeid=0,cpus=0 \ -numa node,nodeid=1,cpus=1

[Qemu-devel] [PATCH V7 07/11] NUMA: set guest numa nodes memory policy

2013-07-31 Thread Wanlong Gao
Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is

[Qemu-devel] [PATCH V7 03/11] NUMA: move numa related code to numa.c

2013-07-31 Thread Wanlong Gao
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- cpus.c | 14 --- include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 2 ++ numa.c | 65 + vl.c| 47

[Qemu-devel] [PATCH V7 09/11] NUMA: add hmp command set-mem-policy

2013-07-31 Thread Wanlong Gao
Add hmp command set-mem-policy to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mem-policy 0 policy=membind,relative=false,host-nodes=0-1 Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

[Qemu-devel] [PATCH V7 08/11] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

2013-07-31 Thread Wanlong Gao
This QMP command allows user set guest node's memory policy through the QMP protocol. The qmp-shell command is like: set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- numa.c | 62

[Qemu-devel] [PATCH V7 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-31 Thread Wanlong Gao
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- qapi-schema.json | 47 +++ 1 file changed, 47 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a51f7d2..b9b18e4 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3773,3

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the

[Qemu-devel] [PATCH V7 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

2013-07-31 Thread Wanlong Gao
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- hmp.c | 54 ++ hmp.h | 1 + monitor.c | 21 + 3 files changed, 56 insertions(+), 20 deletions(-) diff --git a/hmp.c b/hmp.c index 98d2a76..3b2f04d 100644 ---

[Qemu-devel] [PATCH V7 05/11] NUMA: Add Linux libnuma detection

2013-07-31 Thread Wanlong Gao
Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara andre.przyw...@amd.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- configure | 32

[Qemu-devel] [PATCH V7 10/11] NUMA: add qmp command query-numa

2013-07-31 Thread Wanlong Gao
Add qmp command query-numa to show guest NUMA information. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- numa.c | 69 qapi-schema.json | 36 + qmp-commands.hx | 49

Re: [Qemu-devel] [PATCH for 1.6] tci: Fix broken build (compiler warning caused by redefined macro BIT)

2013-07-31 Thread Marcel Apfelbaum
On Tue, 2013-07-30 at 22:41 +0200, Stefan Weil wrote: The definition of macro BIT in tci/tcg-target.c now conflicts with the definition of the same macro in includes qemu/bitops.h. This conflict was triggered by a recent change in the include chain of tcg.c (probably commit

[Qemu-devel] [PATCH V7 04/11] NUMA: Add numa_info structure to contain numa nodes info

2013-07-31 Thread Wanlong Gao
Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by: Andre Przywara andre.przyw...@amd.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

[Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Michal Novotny
Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Michal Novotny
On 07/31/2013 08:45 AM, Markus Armbruster wrote: Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Michal Novotny
On 07/31/2013 08:45 AM, Markus Armbruster wrote: Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-07-31 Thread Erik de Castro Lopo
Paolo Bonzini wrote: 4) Restrict GPLv2-only contributions to user mode emulation (due to code from Linux) and PCI passthrough (due to code from Neocleus). It would be nice to have that statement or something like it mentioning the linux-user/ tree added to the LICENSE file. Cheers, Erik --

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-07-31 Thread Andreas Färber
Am 31.07.2013 08:19, schrieb Paolo Bonzini: 1) The GPL says that if the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. This is not true, QEMU includes parts that are v2-only. 2) Provide a default for

Re: [Qemu-devel] [PATCH for 1.6] hw/core: Fix wrong left shift (build regression)

2013-07-31 Thread Andreas Färber
Am 31.07.2013 07:00, schrieb Stefan Weil: Shifting a long int (32 bit) by 40 bit positions won't work. Compiler message: hw/core/qdev-properties.c: In function ‘print_size’: hw/core/qdev-properties.c:1180:5: warning: left shift count = width of type Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH v2 1/2] qdev: Fix 32-bit compilation in print_size

2013-07-31 Thread Andreas Färber
Anthony, Am 30.07.2013 20:20, schrieb Richard Henderson: Signed-off-by: Richard Henderson r...@twiddle.net FWIW Reviewed-by: Andreas Färber afaer...@suse.de This is a build fix, can you please review and apply 1/2? 2/2 was outside my quick understanding so I'm not sure. ;) rth, you forgot to

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Kevin Wolf
Am 31.07.2013 um 08:19 hat Paolo Bonzini geschrieben: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf kw...@redhat.com Cc:

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

2013-07-31 Thread Kevin Wolf
Am 30.07.2013 um 19:44 hat Luiz Capitulino geschrieben: On Fri, 26 Jul 2013 20:14:06 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: Overall, I like where this is headed, but I'm not quite sure it is ready for commit as-is; looking forward to

Re: [Qemu-devel] Standard benchmarks for VMs

2013-07-31 Thread Stefan Hajnoczi
On Tue, Jul 30, 2013 at 11:27:04AM +0200, Gabriele Paciucci wrote: I'm new for this ml, sorry if this mail is not in the right place!!! I'm looking for standard benchmarks to test VMs. I have seen several presentations from IBM and Red Hat using FFSB. Is there a widely used configuration

Re: [Qemu-devel] [PATCH v2 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Ping? Has been ignored for six weeks, and now it no longer applies. Rebased version coming. *Sigh*

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a map subcommand

2013-07-31 Thread Kevin Wolf
Am 30.07.2013 um 17:22 hat Paolo Bonzini geschrieben: Il 30/07/2013 17:13, Kevin Wolf ha scritto: Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: This command dumps the metadata of an entire chain, in either tabular or JSON format. Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: On 07/31/2013 08:45 AM, Markus Armbruster wrote: Michal Novotny minov...@redhat.com writes: Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you

Re: [Qemu-devel] [RFC 0/8] arm AioContext with its own timer stuff

2013-07-31 Thread Stefan Hajnoczi
On Mon, Jul 29, 2013 at 10:58:40AM +0200, Kevin Wolf wrote: Am 26.07.2013 um 10:43 hat Stefan Hajnoczi geschrieben: On Thu, Jul 25, 2013 at 07:53:33PM +0100, Alex Bligh wrote: --On 25 July 2013 14:32:59 +0200 Jan Kiszka jan.kis...@siemens.com wrote: I would happily at a

Re: [Qemu-devel] [PATCH 2/2] KVM: s390: add floating irq controller

2013-07-31 Thread Cornelia Huck
On Mon, 29 Jul 2013 15:59:53 +0200 Jens Freimann jf...@linux.vnet.ibm.com wrote: This patch adds a floating irq controller as a kvm_device. It will be necesary for migration of floating interrupts as well as for hardening the reset code by allowing user space to explicitly remove all pending

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

2013-07-31 Thread Andreas Färber
Am 31.07.2013 08:54, schrieb Michal Novotny: there are still some code parts that are not using error_report() as well, e.g. fprintf(stderr, Error: standard VGA not available\n); in the select_vgahw() function (line 2168) or: fprintf(stderr, Failed to start VNC server on

[Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Implement interrupt mitigation for the e1000 device with the corresponding mitigation device property. Add a compat_props entry to pc-1.6 machines in order to set the mitigation property for these machines. Vincenzo Maffione (2): e1000: add interrupt mitigation support i386/pc: introducing

Re: [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols

2013-07-31 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: Protocols return raw data, so you can assume the offsets to pass through unchanged. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Not really objecting, but is this useful? In formats,

[Qemu-devel] [PATCH v5 2/2] i386/pc: introducing compat_props for pc-1.6

2013-07-31 Thread Vincenzo Maffione
PC_COMPAT_1_6 macro introduced in order to set the e1000 mitigation property off for pc-i440fx-1.6 and pc-q35-1.6 machines. Signed-off-by: Vincenzo Maffione v.maffi...@gmail.com --- hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 include/hw/i386/pc.h | 7 +++ 3 files changed,

Re: [Qemu-devel] [PATCH v3 15/19] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO

2013-07-31 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: Alternatively, this could use a discard zeroes data flag returned by bdrv_get_info. Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 8 +++- 1 file changed, 7 insertions(+),

[Qemu-devel] [PATCH] xhci: fix segfault

2013-07-31 Thread Gerd Hoffmann
Guest trying to reset a endpoint of a disconnected device resulted in xhci trying to dereference uport while being NULL, thereby crashing qemu. Fix that by adding a check. Drop unused dev variable while touching that code bit. Cc: qemu-sta...@nongnu.org Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v3 19/19] block: look for zero blocks in bs-file

2013-07-31 Thread Kevin Wolf
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 8738937..1493f22 100644 ---

Re: [Qemu-devel] [PATCH] hw/usb/redirect.c: crash in QOM cleanup

2013-07-31 Thread Gerd Hoffmann
Hi, diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index a594e95..1c62263 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1334,6 +1334,7 @@ static void usbredir_handle_destroy(USBDevice *udev) USBRedirDevice *dev = DO_UPCAST(USBRedirDevice, dev, udev);

[Qemu-devel] [PATCH] usb-redir: fix use-after-free

2013-07-31 Thread Gerd Hoffmann
Reinitialize dev-cs to NULL after deleting it, to make sure it isn't used afterwards. Reported-by: Martin Cerveny m.cerv...@computer.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/redirect.c

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-31 Thread Qiao Nuohan
Hello Luiz and Amos, My patches are waiting for introspection. But now I cannot quite catch the situation of introspection, so I hope to get some information about current state from you. It will be very appreciated. On 07/09/2013 03:36 PM, Qiao Nuohan wrote: On 07/09/2013 03:30 PM, Qiao

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

2013-07-31 Thread Fam Zheng
On Tue, 07/30 16:58, Stefan Hajnoczi wrote: On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: @@ -1518,6 +1519,9 @@ static void bdrv_move_feature_fields(BlockDriverState *bs_dest, /* dirty bitmap */ bs_dest-dirty_bitmap = bs_src-dirty_bitmap; +/*

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Andreas Färber
Am 31.07.2013 10:13, schrieb Vincenzo Maffione: Implement interrupt mitigation for the e1000 device with the corresponding mitigation device property. Add a compat_props entry to pc-1.6 machines in order to set the mitigation property for these machines. Vincenzo Maffione (2): e1000:

Re: [Qemu-devel] [PATCH v5 2/2] i386/pc: introducing compat_props for pc-1.6

2013-07-31 Thread Andreas Färber
Am 31.07.2013 10:13, schrieb Vincenzo Maffione: diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 3a0c4e3..812df4d 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -214,6 +214,13 @@ void pvpanic_init(ISABus *bus); int e820_add_entry(uint64_t, uint64_t,

Re: [Qemu-devel] [PATCH v5 1/2] e1000: add interrupt mitigation support

2013-07-31 Thread Andreas Färber
Am 31.07.2013 10:13, schrieb Vincenzo Maffione: This patch partially implements the e1000 interrupt mitigation mechanisms. Using a single QEMUTimer, it emulates the ITR register (which is the newer mitigation register, recommended by Intel) and approximately emulates RADV and TADV registers.

[Qemu-devel] [PATCH v3 0/7] Implement reference count for BlockDriverState

2013-07-31 Thread Fam Zheng
BlockDriverState lifecycle management is needed by future features such as image fleecing and blockdev-add. This series adds reference count to BlockDriverState. The first two patches clean up two odd BlockDriverState use cases, so all code uses bdrv_new() to create BlockDriverState instance.

[Qemu-devel] [PATCH v3 1/7] vvfat: use bdrv_new() to allocate BlockDriverState

2013-07-31 Thread Fam Zheng
we need bdrv_new() to properly initialize BDS, don't allocate memory manually. Signed-off-by: Fam Zheng f...@redhat.com --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index cd3b8ed..a827d91 100644 --- a/block/vvfat.c +++

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Sorry, I'm not confident with this infrastructure. So do you just want me to invert the commit order? (and do the other two little changes) Thanks, Vincenzo 2013/7/31 Andreas Färber afaer...@suse.de: Am 31.07.2013 10:13, schrieb Vincenzo Maffione: Implement interrupt mitigation for the

[Qemu-devel] [PATCH v3 5/7] migration: omit drive ref as we have bdrv_ref now

2013-07-31 Thread Fam Zheng
block-migration.c does not actually use DriveInfo anywhere. Hence it's safe to drive ref code, we really only care about referencing BDS. Signed-off-by: Fam Zheng f...@redhat.com --- block-migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block-migration.c

[Qemu-devel] [PATCH] qemu-ga: build it even if !system

2013-07-31 Thread Michael Tokarev
Move qemu-ga build check out of if softmmu.. into if tools section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using --enable-guest-agent. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- configure |8 +++- 1 file changed, 3

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

2013-07-31 Thread Michael Tokarev
31.07.2013 14:24, Michael Tokarev wrote: Move qemu-ga build check out of if softmmu.. into if tools section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using --enable-guest-agent. Actually the more I think about it... Maybe it shouldn't

Re: [Qemu-devel] [PATCH V7 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

2013-07-31 Thread Laszlo Ersek
On 07/31/13 08:42, Wanlong Gao wrote: Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- qapi-schema.json | 47 +++ 1 file changed, 47 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a51f7d2..b9b18e4 100644 ---

[Qemu-devel] [PATCH v3 2/7] iscsi: use bdrv_new() instead of stack structure

2013-07-31 Thread Fam Zheng
BlockDriverState structure needs bdrv_new() to initialize refcnt, don't allocate a local structure variable and memset to 0, becasue with coming refcnt implementation, bdrv_unref will crash if bs-refcnt not initialized to 1. Signed-off-by: Fam Zheng f...@redhat.com --- block/iscsi.c | 14

Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

2013-07-31 Thread Peter Maydell
On 31 July 2013 11:27, Michael Tokarev m...@tls.msk.ru wrote: 31.07.2013 14:24, Michael Tokarev wrote: Move qemu-ga build check out of if softmmu.. into if tools section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Stefan Hajnoczi
On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote: Sorry, I'm not confident with this infrastructure. Thanks for your efforts! Normally this change would not be necessary but you are the first person who needs a 1.6 compat property :). So do you just want me to invert the

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Andreas Färber
Am 31.07.2013 13:20, schrieb Stefan Hajnoczi: On Wed, Jul 31, 2013 at 12:19:06PM +0200, Vincenzo Maffione wrote: Sorry, I'm not confident with this infrastructure. Thanks for your efforts! Normally this change would not be necessary but you are the first person who needs a 1.6 compat

[Qemu-devel] [PATCH v3 7/7] nbd: use BlockDriverState refcnt

2013-07-31 Thread Fam Zheng
Previously, nbd calls drive_get_ref() on the drive of bs. A BDS doesn't always have associated dinfo, which nbd doesn't care either. We already have BDS ref count, so use it to make it safe for a BDS w/o blockdev. Signed-off-by: Fam Zheng f...@redhat.com --- blockdev-nbd.c | 10 +- nbd.c

Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

2013-07-31 Thread Andreas Färber
Am 31.07.2013 13:05, schrieb Peter Maydell: On 31 July 2013 11:27, Michael Tokarev m...@tls.msk.ru wrote: 31.07.2013 14:24, Michael Tokarev wrote: Move qemu-ga build check out of if softmmu.. into if tools section. We want to build qemu-ga for _guest_ even if system build isn't done. It is

[Qemu-devel] [PATCH v3 4/7] block: make bdrv_delete() static

2013-07-31 Thread Fam Zheng
Manage BlockDriverState lifecycle with refcnt, so bdrv_delete() is no longer public and should be called by bdrv_unref() if refcnt is decreased to 0. This is an identical change because effectively, there's no multiple reference of BDS now: no caller of bdrv_ref() yet, only bdrv_new() sets

Re: [Qemu-devel] usb: a problem of using libusb for usb pass through

2013-07-31 Thread Gerd Hoffmann
On 07/30/13 19:13, Hans de Goede wrote: Hi, On 07/22/2013 02:58 PM, Gerd Hoffmann wrote: On 07/16/13 10:45, Gonglei (Arei) wrote: Hi, Gerd My Qemu version is 1.5.1, and use libusb for usb pass through. I pass through a host usb device to the guest by bus number and physical port,

Re: [Qemu-devel] [edk2] SetVirtualAddressMap and NX bit

2013-07-31 Thread Laszlo Ersek
(CC'ing qemu-devel) On 07/16/13 17:12, Borislav Petkov wrote: (this time after I subscribed to the ML) Hi guys, I've been playing with mapping EFI runtime regions in a topdown manner in Linux for purposes of using EFI in a kexec'ed kernel. For that I've been using EFI BIOS built from edk2

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a map subcommand

2013-07-31 Thread Paolo Bonzini
The documentation patch contains a line like this: 0 131072 2327680 A heading line and tabs (or even better, fixed printf column widths) sounds good, but I think if it's really only for human users and not for shell scripts, we can further improve the output: Offset

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-31 Thread Laszlo Ersek
Hi Qiao, On 07/31/13 11:26, Qiao Nuohan wrote: Hello Luiz and Amos, My patches are waiting for introspection. But now I cannot quite catch the situation of introspection, so I hope to get some information about current state from you. It will be very appreciated. I wasn't aware that you've

Re: [Qemu-devel] [PATCH] usb-redir: fix use-after-free

2013-07-31 Thread Laszlo Ersek
On 07/31/13 11:21, Gerd Hoffmann wrote: Reinitialize dev-cs to NULL after deleting it, to make sure it isn't used afterwards. Reported-by: Martin Cerveny m.cerv...@computer.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c |1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH] xhci: fix segfault

2013-07-31 Thread Laszlo Ersek
On 07/31/13 11:10, Gerd Hoffmann wrote: Guest trying to reset a endpoint of a disconnected device resulted in xhci trying to dereference uport while being NULL, thereby crashing qemu. Fix that by adding a check. Drop unused dev variable while touching that code bit. Cc:

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Jeff Cody
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

2013-07-31 Thread Michael Tokarev
31.07.2013 16:03, Andreas Färber wrote: Am 31.07.2013 13:05, schrieb Peter Maydell: Actually the more I think about it... Maybe it shouldn't depend on --enable-tools either, but should be an independent option. Because it isn't really a tool. This seems to me to be unnecessarily breaking

Re: [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols

2013-07-31 Thread Paolo Bonzini
- Original Message - From: Kevin Wolf kw...@redhat.com To: Paolo Bonzini pbonz...@redhat.com Cc: qemu-devel@nongnu.org, stefa...@redhat.com, ebl...@redhat.com, p...@kamp.de Sent: Wednesday, July 31, 2013 11:12:27 AM Subject: Re: [PATCH v3 18/19] block: add default get_block_status

Re: [Qemu-devel] [PATCH v3 19/19] block: look for zero blocks in bs-file

2013-07-31 Thread Paolo Bonzini
- Original Message - From: Kevin Wolf kw...@redhat.com To: Paolo Bonzini pbonz...@redhat.com Cc: qemu-devel@nongnu.org, stefa...@redhat.com, ebl...@redhat.com, p...@kamp.de Sent: Wednesday, July 31, 2013 11:21:27 AM Subject: Re: [PATCH v3 19/19] block: look for zero blocks in

Re: [Qemu-devel] [PATCH 1/2] raw: add license header

2013-07-31 Thread Luiz Capitulino
On Wed, 31 Jul 2013 08:19:51 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig h...@lst.de Cc:

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-31 Thread Luiz Capitulino
On Wed, 31 Jul 2013 14:23:08 +0200 Laszlo Ersek ler...@redhat.com wrote: Hi Qiao, On 07/31/13 11:26, Qiao Nuohan wrote: Hello Luiz and Amos, My patches are waiting for introspection. But now I cannot quite catch the situation of introspection, so I hope to get some information about

[Qemu-devel] [PATCH v3 for 1.6 1/8] exec: Fix Xen RAM allocation with unusual options

2013-07-31 Thread Markus Armbruster
Issues: * We try to obey -mem-path even though it can't work with Xen. * To implement -machine mem-merge, we call memory_try_enable_merging(new_block-host, size). But with Xen, new_block-host remains null. Oops. Fix by separating Xen allocation from normal allocation. Acked-by: Stefano

Re: [Qemu-devel] [PATCH v2 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Laszlo Ersek
On 07/31/13 10:50, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: Ping? Has been ignored for six weeks, and now it no longer applies. Rebased version coming. *Sigh* Why haven't you been made a maintainer yet? You could have a cleanup-fubars tree and you could

Re: [Qemu-devel] [PATCH for-1.6? 04/14] gumstix: Don't enforce use of -pflash for qtest

2013-07-31 Thread Andreas Färber
Am 30.07.2013 15:20, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: Signed-off-by: Andreas Färber afaer...@suse.de I'm not sure this is heading in the right direction. What's the bigger picture here? Are we saying that all machines must be launchable without any

[Qemu-devel] [PATCH v3 for 1.6 5/8] exec: Drop incorrect dead S390 code in qemu_ram_remap()

2013-07-31 Thread Markus Armbruster
Old S390 KVM wants guest RAM mapped in a peculiar way. Commit 6b02494 implemented that. When qemu_ram_remap() got added in commit cd19cfa, its code carefully mimicked the allocation code: peculiar way if defined(TARGET_S390X) defined(CONFIG_KVM), else normal way. For new S390 KVM, we actually

[Qemu-devel] [PATCH v3 for 1.6 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-07-31 Thread Markus Armbruster
Another issue missed in commit fdec991 is -mem-path: it needs to be rejected only for old S390 KVM, not for any S390. Not that I personally care, but the ifdeffery in qemu_ram_alloc_from_ptr() annoys me. Note that this doesn't actually make -mem-path work, as the kernel doesn't (yet?) support

Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

2013-07-31 Thread Vincenzo Maffione
Ok, but it's unclear how do you prefer to create and empty PC_COMPAT_1_6 in Patch 1. If you want to keep this declaration form [...] .compat_props = (GlobalProperty[]) { PC_COMPAT_1_6, { /* end of list */ } }, [...] in the two pc_*_machine_v1_6 structs, I'm forced to define

[Qemu-devel] [PATCH v3 for 1.6 2/8] exec: Clean up fall back when -mem-path allocation fails

2013-07-31 Thread Markus Armbruster
With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate accordingly, but when it fails, it falls back to normal allocation. The fall back allocation code used to be effectively identical to the -mem-path not given code, until it started to diverge in commit 432d268. I believe the code

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-31 Thread Michael R. Hines
On 07/30/2013 11:31 AM, Orit Wasserman wrote: On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com When testing with libvirt, a simple IPv6 migration

[Qemu-devel] [PATCH v3 for 1.6 4/8] exec: Simplify the guest physical memory allocation hook

2013-07-31 Thread Markus Armbruster
Make it a generic hook rather than a KVM hook. Less code and ifdeffery. Since the only user of the hook is old S390 KVM, there's hope we can get rid of it some day. Acked-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c

[Qemu-devel] [PATCH v3 for 1.6 7/8] exec: Don't abort when we can't allocate guest memory

2013-07-31 Thread Markus Armbruster
We abort() on memory allocation failure. abort() is appropriate for programming errors. Maybe most memory allocation failures are programming errors, maybe not. But guest memory allocation failure isn't, and aborting when the user asks for more memory than we can provide is not nice. exit(1)

[Qemu-devel] [PATCH v3 for 1.6 8/8] pc_sysfw: Fix ISA BIOS init for ridiculously big flash

2013-07-31 Thread Markus Armbruster
pc_isa_bios_init() suffers integer overflow for flash larger than INT_MAX. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block/pc_sysfw.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c index 7db68f0..74a5364 100644

[Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Markus Armbruster
All I wanted to do is exit(1) instead of abort() on guest memory allocation failure [07/08]. But that lead me into a minor #ifdef bog, and here's what I brought back. Enjoy! Testing: * Christian Borntraeger reports v1 works fine under LPAR (new S390 KVM, i.e. generic allocation) and as second

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.2 Stable released

2013-07-31 Thread Miroslav Rezanina
Hi Michael, how this affect 1.5 schedule?? Is the date mentioned on http://wiki.qemu.org/Planning/1.5 still valid (just increase the build number)? Mirek Rezanina - Original Message - From: Michael Roth mdr...@linux.vnet.ibm.com To: qemu-devel@nongnu.org Cc: pmato...@redhat.com,

Re: [Qemu-devel] [PATCH v3 for 1.6 7/8] exec: Don't abort when we can't allocate guest memory

2013-07-31 Thread Andreas Färber
Am 31.07.2013 15:11, schrieb Markus Armbruster: We abort() on memory allocation failure. abort() is appropriate for programming errors. Maybe most memory allocation failures are programming errors, maybe not. But guest memory allocation failure isn't, and aborting when the user asks for

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a map subcommand

2013-07-31 Thread Kevin Wolf
Am 31.07.2013 um 14:13 hat Paolo Bonzini geschrieben: The documentation patch contains a line like this: 0 131072 2327680 A heading line and tabs (or even better, fixed printf column widths) sounds good, but I think if it's really only for human users and not for

Re: [Qemu-devel] [PATCH] acl: acl_add can't insert before last list element, fix

2013-07-31 Thread Markus Armbruster
Ping re 1.5.3 Markus Armbruster arm...@redhat.com writes: Watch this: $ upstream-qemu -nodefaults -S -vnc :0,acl,sasl -monitor stdio QEMU 1.5.50 monitor - type 'help' for more information (qemu) acl_add vnc.username drei allow acl: added rule at position 1 (qemu)

[Qemu-devel] [PATCH v3 3/7] block: implement reference count for BlockDriverState

2013-07-31 Thread Fam Zheng
Introduce bdrv_ref/bdrv_unref to manage the lifecycle of BlockDriverState. They are unused for now but will used to replace bdrv_delete() later. Signed-off-by: Fam Zheng f...@redhat.com --- block.c | 21 + include/block/block.h | 2 ++

[Qemu-devel] [PATCH v3] qemu-ga: build it even if !system

2013-07-31 Thread Michael Tokarev
Move qemu-ga build check out of if softmmu.. into its own section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using --enable-guest-agent. Additionally, give error message if guest agent is requested but not supported. Signed-off-by: Michael

[Qemu-devel] [PATCH v2] qemu-ga: build it even if !system

2013-07-31 Thread Michael Tokarev
Move qemu-ga build check out of if softmmu.. into its own section. We want to build qemu-ga for _guest_ even if system build isn't done. It is controlled separately using --enable-guest-agent. Additionally, give error message if guest agent is requested but not supported. Signed-off-by: Michael

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-31 Thread Benoît Canet
Crypto should be done by trained professionals[*]. I agree I feel uneasy to write cryptographic code. Best regards Benoît

Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-07-31 Thread Laszlo Ersek
On 07/31/13 15:11, Markus Armbruster wrote: All I wanted to do is exit(1) instead of abort() on guest memory allocation failure [07/08]. But that lead me into a minor #ifdef bog, and here's what I brought back. Enjoy! Testing: * Christian Borntraeger reports v1 works fine under LPAR (new

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-31 Thread Orit Wasserman
On 07/31/2013 04:39 PM, Michael R. Hines wrote: On 07/30/2013 11:31 AM, Orit Wasserman wrote: On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com

[Qemu-devel] [PATCH] MAINTAINERS: change Igor Mitsyanko's email address

2013-07-31 Thread Igor Mitsyanko
My email address in samsung.com domain is no longer accessible, change it to my personal gmail address. Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com --- Currently I can't send patches properly with send-email command, I can only use gmail web interface for this. I'm not sure that it would

Re: [Qemu-devel] QCOW2 cryptography and secure key handling

2013-07-31 Thread Benoît Canet
For example, current qcow2 encryption is vulnerable to a watermarking attack. http://en.wikipedia.org/wiki/Disk_encryption_theory#Cipher-block_chaining_.28CBC.29 void qcow2_encrypt_sectors(BDRVQcowState *s, int64_t sector_num, uint8_t *out_buf, const uint8_t *in_buf,

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-07-31 Thread Stefan Weil
Am 31.07.2013 08:19, schrieb Paolo Bonzini: 1) The GPL says that if the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation. This is not true, QEMU includes parts that are v2-only. 2) Provide a default for

Re: [Qemu-devel] [PATCH 2/2] LICENSE: clarify

2013-07-31 Thread Eric Blake
On 07/31/2013 10:48 AM, Stefan Weil wrote: -1) QEMU as a whole is released under the GNU General Public License +1) QEMU as a whole is released under the GNU General Public License, +version 2. I appreciate these clarifications. For point 1, I suggest ... version 2 or (at your option)

  1   2   >