Re: [Qemu-devel] [PATCH 4/6] s390x: Add I/O adapter registration.

2014-02-26 Thread Christian Borntraeger
On 25/02/14 18:25, Cornelia Huck wrote: +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) +{ +struct kvm_s390_io_adapter_req req = { +.id = id, +.type = do_map ? KVM_S390_IO_ADAPTER_MAP : KVM_S390_IO_ADAPTER_UNMAP, +.addr = map_addr, +

Re: [Qemu-devel] [PATCH 4/6] s390x: Add I/O adapter registration.

2014-02-26 Thread Cornelia Huck
On Wed, 26 Feb 2014 09:29:12 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: On 25/02/14 18:25, Cornelia Huck wrote: +int kvm_s390_io_adapter_map(uint32_t id, uint64_t map_addr, bool do_map) +{ +struct kvm_s390_io_adapter_req req = { +.id = id, +.type =

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 13:00:03 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Tue, Feb 25, 2014 at 03:15:53PM +0100, Paolo Bonzini wrote: Il 25/02/2014 11:20, Hu Tao ha scritto: There is a problem that user_creatable_complete() is called before adding object to /objects (see object_create()),

[Qemu-devel] What does these functions do?

2014-02-26 Thread Atlas Khan
qdev_init_gpio_out qdev_init_gpio_in qdev_set_legacy_instance_id these functions are from QEMUThese are used in different devices. Can any body plz tell me what does these do?

[Qemu-devel] Do not compile hw/ for SOFTMMU

2014-02-26 Thread Jun Koi
Currently hw/ is compiled in for SOFTMMU setup, but actually it is always compiled no matter what. This patch removes the related line in Makefile.objs. Signed-off-by: Jun Koi junkoi2...@gmail.com diff --git a/Makefile.objs b/Makefile.objs index 4a62913..15d75be 100644 --- a/Makefile.objs +++

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 06:57, Hu Tao ha scritto: If lines about memory polices are moved up to hostmem.c, the only thing left in ram_backend_memory_init() is calling memory_region_init_ram() to allocate memory. Then it comes a problem that when to apply memory polices? Choices: 1. apply memory polices

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 13:57:06 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Wed, Feb 19, 2014 at 10:36:57AM +0100, Igor Mammedov wrote: On Wed, 19 Feb 2014 10:03:13 +0100 Paolo Bonzini pbonz...@redhat.com wrote: 19/02/2014 08:54, Hu Tao ha scritto: Thus makes user control how to

Re: [Qemu-devel] [PATCH v3] XBZRLE: Fix qemu crash when resize the xbzrle cache

2014-02-26 Thread Gonglei (Arei)
Hi, Juan. Thanks for your review. -Original Message- From: Juan Quintela [mailto:quint...@redhat.com] Sent: Tuesday, February 25, 2014 11:25 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; Dr. David Alan Gilbert; owass...@redhat.com; chenliang (T); Huangweidong (C) Subject: Re:

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Hu Tao
On Wed, Feb 26, 2014 at 09:47:08AM +0100, Igor Mammedov wrote: On Wed, 26 Feb 2014 13:00:03 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Tue, Feb 25, 2014 at 03:15:53PM +0100, Paolo Bonzini wrote: Il 25/02/2014 11:20, Hu Tao ha scritto: There is a problem that user_creatable_complete()

Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode

2014-02-26 Thread alvise rigo
I see, but how can we know the type of migration (KVM to TCG or TCG to KVM) which is taking place only looking at the incoming data? Of course, I'm supposing that the two cases will require different handling and so that distinguish the migration type (at the destination) has to be part of the

Re: [Qemu-devel] [RFC 3/4] Add l2ctlr cp register to CPUARMState

2014-02-26 Thread alvise rigo
This was a polite way to alter the value of the register in order to not fail the migration when KVM migrates a value different from the TCG one. KVM in particular does not set the irq bit while TCG does. alvise On Tue, Feb 25, 2014 at 7:22 PM, Peter Maydell peter.mayd...@linaro.orgwrote: On

[Qemu-devel] [PATCH] translate: remove file translate-all.h

2014-02-26 Thread Xuebing Wang
This patch does below: - Move the declaration of 2 translate functions from translate-all.h into include/exec/exec-all.h - remove file translate-all.h translate-all.h = exec/exec-all.h can be done by: git grep -w translate-all.h | cut -d: -f1 | xargs sed -i

[Qemu-devel] [PATCH 1/1] block: use /var/tmp instead of /tmp for -snapshot

2014-02-26 Thread Amit Shah
If TMPDIR is not specified, the default was to use /tmp for the working copy of the block devices. Update this to /var/tmp instead, so systems using tmp-on-tmpfs don't end up inadvertently using RAM for the block device. Signed-off-by: Amit Shah amit.s...@redhat.com --- block.c | 5 +++-- 1

Re: [Qemu-devel] [PATCH v3 12/31] target-arm: Implement AArch64 TTBR*

2014-02-26 Thread Peter Maydell
On 26 February 2014 06:33, Hu Tao hu...@cn.fujitsu.com wrote: On Sat, Feb 15, 2014 at 04:07:05PM +, Peter Maydell wrote: ... diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 06953ac..7cbe69b 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -173,10 +173,8 @@ typedef struct

Re: [Qemu-devel] [PATCH v4 4/6] qdev: add get_pointer_and_free() for temporary strings

2014-02-26 Thread Igor Mammedov
On Fri, 21 Feb 2014 15:46:56 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: get_pointer() assumes the string has unspecified lifetime (at least as long as the object is alive). In some cases we can only produce a temporary string that should be freed when get_pointer() is done.

Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h

2014-02-26 Thread Peter Maydell
On 26 February 2014 09:25, Xuebing Wang xbi...@gmail.com wrote: This patch does below: - Move the declaration of 2 translate functions from translate-all.h into include/exec/exec-all.h - remove file translate-all.h translate-all.h = exec/exec-all.h can be done by: git grep -w

Re: [Qemu-devel] [RFC 2/4] Added flag in ARMCPU to track last execution mode

2014-02-26 Thread Peter Maydell
On 26 February 2014 09:16, alvise rigo a.r...@virtualopensystems.com wrote: I see, but how can we know the type of migration (KVM to TCG or TCG to KVM) which is taking place only looking at the incoming data? Of course, I'm supposing that the two cases will require different handling and so

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-02-26 Thread alvise rigo
I agree that this is a sort of workaround, but it seems to me that a proper solution is not possible without changing the ideas contemplated now in the migration code. Are we willing to accept some major changes in the code to embrace this type of migration? Thanks, alvise On Tue, Feb 25, 2014

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-02-26 Thread Peter Maydell
On 26 February 2014 10:02, alvise rigo a.r...@virtualopensystems.com wrote: I agree that this is a sort of workaround, but it seems to me that a proper solution is not possible without changing the ideas contemplated now in the migration code. Are we willing to accept some major changes in the

Re: [Qemu-devel] [RFC 3/4] Add l2ctlr cp register to CPUARMState

2014-02-26 Thread Peter Maydell
On 26 February 2014 09:17, alvise rigo a.r...@virtualopensystems.com wrote: This was a polite way to alter the value of the register in order to not fail the migration when KVM migrates a value different from the TCG one. KVM in particular does not set the irq bit while TCG does. You mean the

[Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Peter Lieven
Hi, I was wondering if it would be a good idea to set the O_DIRECT mode for the source files of a qemu-img convert process if the source is a host_device? Currently the backup of a host device is polluting the page cache. Peter

Re: [Qemu-devel] [PATCH] block/vmdk: do not report file offset for compressed extents

2014-02-26 Thread Fam Zheng
On Wed, 02/26 10:47, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/vmdk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index ff6f5ee..5fa29b0 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1146,7 +1146,7 @@

Re: [Qemu-devel] [PATCH] modules: Fix building with --enable-modules

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 06:56, Fam Zheng ha scritto: Compiling util/modules.c with modules enabled fails now. Fix it by: 1) Add #define CONFIG_MODULES with --enable-modules 2) Include qemu-common.h before #ifdef testing in module.c. Signed-off-by: Fam Zheng f...@redhat.com --- scripts/create_config |

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-02-26 Thread alvise rigo
Improvements of cpreg emulation apart, we will still need to tackle with the great amount of registers not migrated because generated by a wildcarded register; some of these registers are in fact migrated by KVM. I think that the idea of keeping a reference to the generator register (i.e. the only

Re: [Qemu-devel] [PATCH v3 31/31] target-arm: Add v8 mmu translation support

2014-02-26 Thread Peter Maydell
On 26 February 2014 03:32, Hu Tao hu...@cn.fujitsu.com wrote: On Wed, Feb 26, 2014 at 10:49:59AM +0800, Hu Tao wrote: On Sat, Feb 15, 2014 at 04:07:24PM +, Peter Maydell wrote: From: Rob Herring rob.herr...@linaro.org /* Determine whether this address is in the region controlled by

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-02-26 Thread Peter Maydell
On 26 February 2014 10:27, alvise rigo a.r...@virtualopensystems.com wrote: Improvements of cpreg emulation apart, we will still need to tackle with the great amount of registers not migrated because generated by a wildcarded register; some of these registers are in fact migrated by KVM. I

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 10:10, Igor Mammedov ha scritto: if we assume that NUMA policies apply to every hostmem derived backend, then we could realize() approach used by DEVICE. i.e. set NUMA policies in hostmem.c:hostmemory_backend_memory_init() Add parent_complete field to ram-backend class and store

Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 10:55, Peter Maydell ha scritto: On 26 February 2014 09:25, Xuebing Wang xbi...@gmail.com wrote: This patch does below: - Move the declaration of 2 translate functions from translate-all.h into include/exec/exec-all.h - remove file translate-all.h translate-all.h =

[Qemu-devel] [PATCH v4 2/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-26 Thread Will Newton
Add support for AArch32 CRC32 and CRC32C instructions added in ARMv8 and add a CPU feature flag to enable these instructions. The CRC32-C implementation used is the built-in qemu implementation and The CRC-32 implementation is from zlib. This requires adding zlib to LIBS to ensure it is linked

[Qemu-devel] [PATCH v4 1/2] include/qemu/crc32c.h: Rename include guards to match filename

2014-02-26 Thread Will Newton
Signed-off-by: Will Newton will.new...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- include/qemu/crc32c.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changes in v4: - None diff --git a/include/qemu/crc32c.h b/include/qemu/crc32c.h index 56d1c3b..dafb6a1

[Qemu-devel] [PATCH v4 0/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-26 Thread Will Newton
This series adds support for the AArch32 CRC32 instructions added in ARMv8. Will Newton (2): include/qemu/crc32c.h: Rename include guards to match filename target-arm: Add support for AArch32 ARMv8 CRC32 instructions configure | 2 +- include/qemu/crc32c.h | 4 ++--

Re: [Qemu-devel] [PATCH v4 0/2] target-arm: Add support for AArch32 ARMv8 CRC32 instructions

2014-02-26 Thread Peter Maydell
On 26 February 2014 10:46, Will Newton will.new...@linaro.org wrote: This series adds support for the AArch32 CRC32 instructions added in ARMv8. Will Newton (2): include/qemu/crc32c.h: Rename include guards to match filename target-arm: Add support for AArch32 ARMv8 CRC32 instructions

Re: [Qemu-devel] [PATCH v4 3/6] iothread: add I/O thread object

2014-02-26 Thread Igor Mammedov
On Fri, 21 Feb 2014 15:46:55 +0100 Stefan Hajnoczi stefa...@redhat.com wrote: This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 09:47, Igor Mammedov ha scritto: I'm sorry that I've forgotten to mention prerequisite path https://github.com/imammedo/qemu/commit/72a079b88e055fc690c8895a99ccbcce36f6fc1f in stage tree https://github.com/imammedo/qemu/commits/memory-hotplug-v8 Thanks, I'll add this patch to the

[Qemu-devel] [PATCH 3/5] s390x/kvm: Add missing SIGP CPU RESET order

2014-02-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The SIGP order CPU RESET was still missing in the list of our supported handler. This patch now adds a simple implementation, by using the cpu_reset() function that is already available in target-s390x/cpu.c. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 2/5] s390x/kvm: Rework SIGP INITIAL CPU RESET handler

2014-02-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com The s390_cpu_initial_reset() function had two deficiencies: First, it used an ioctl for the destination CPU, and this ioctl could block nearly forever, as long as the destination CPU was running in the SIE loop. Second, it also cleared the general

[Qemu-devel] [PATCH 1/5] s390x/cpu: Use ioctl to reset state in the kernel

2014-02-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com Some of the state in the kernel can not be reset from QEMU yet. For this we've got to use the KVM_S390_INITIAL_RESET ioctl to make sure that the state in the kernel is set to the right values during initial CPU reset, too. Signed-off-by: Thomas Huth

[Qemu-devel] [PATCH 0/5] s390x/kvm: additional fixes and cleanup

2014-02-26 Thread Christian Borntraeger
Folks, here are 5 additional patches for s390x/kvm that I want to push for 2.0. Frank Blaschka (1): s390x/kvm: Rework priv instruction handlers Thomas Huth (4): s390x/cpu: Use ioctl to reset state in the kernel s390x/kvm: Rework SIGP INITIAL CPU RESET handler s390x/kvm: Add missing SIGP

[Qemu-devel] [PATCH 5/5] s390x/ipl: Fix crash of ELF images with arbitrary entry points

2014-02-26 Thread Christian Borntraeger
From: Thomas Huth th...@linux.vnet.ibm.com When loading S390 kernels, the current code expects an ELF file with the start address 0x1. Other ELF files cause a segmentation fault. To avoid these crashes, we should get the start address from the ELF file instead of always using a hard-coded

[Qemu-devel] [PATCH 4/5] s390x/kvm: Rework priv instruction handlers

2014-02-26 Thread Christian Borntraeger
From: Frank Blaschka blasc...@linux.vnet.ibm.com The current implementation uses the second byte of the instruction to identify the instruction handler. This is not sufficient to support instructions not starting with 0xb2. This patch adds separate handlers for 0xb2, 0xb9 and 0xeb to be able to

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-26 Thread Nikunj A Dadhania
Hi Peter, Peter Maydell peter.mayd...@linaro.org writes: That'd be awesome! FWIW upstream SLOF is at the following git URL: git://github.com/aik/SLOF.git That would result in the following updates to our mirror: - [deleted] benh - [deleted] debug_mem_alloc This is

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/28] target-ppc: Altivec 2.07

2014-02-26 Thread Nikunj A Dadhania
Nikunj A Dadhania nik...@linux.vnet.ibm.com writes: Hi Peter, Peter Maydell peter.mayd...@linaro.org writes: That'd be awesome! FWIW upstream SLOF is at the following git URL: git://github.com/aik/SLOF.git That would result in the following updates to our mirror: - [deleted]

Re: [Qemu-devel] [PATCH] translate: remove file translate-all.h

2014-02-26 Thread Xuebing wang
Hi Peter/Paolo, Thanks for replying. 1) I am wondering if some slight refactoring (in the sense of superficial change of moving things around) can make tcg/translationblock/cpu/exec/memory/softmmu more understandable, especially for new engineers. My goal is to explore the possibility of

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 16:59:44 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Wed, Feb 26, 2014 at 09:47:08AM +0100, Igor Mammedov wrote: On Wed, 26 Feb 2014 13:00:03 +0800 Hu Tao hu...@cn.fujitsu.com wrote: On Tue, Feb 25, 2014 at 03:15:53PM +0100, Paolo Bonzini wrote: Il 25/02/2014

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 11:33:30 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/02/2014 10:10, Igor Mammedov ha scritto: if we assume that NUMA policies apply to every hostmem derived backend, then we could realize() approach used by DEVICE. i.e. set NUMA policies in

[Qemu-devel] #qemu-gsoc IRC channel for Google Summer of Code

2014-02-26 Thread Stefan Hajnoczi
Students and Mentors, You are invited to join QEMU's Google Summer of Code IRC channel: #qemu-gsoc on irc.oftc.net Students can interact with their mentors on #qemu-gsoc and discuss project ideas. If a mentor is unavailable on IRC, please send them an email instead:

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 13:31, Igor Mammedov ha scritto: The problem is that some backends might not be handled the same way. For example, not all backends might produce a single void*/size_t pair for the entire region. Think of a composite backend that produces a large memory region from two smaller

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Marcelo Tosatti
On Wed, Feb 26, 2014 at 01:45:38PM +0100, Paolo Bonzini wrote: Il 26/02/2014 13:31, Igor Mammedov ha scritto: The problem is that some backends might not be handled the same way. For example, not all backends might produce a single void*/size_t pair for the entire region. Think of a

[Qemu-devel] How is address of helper function for slow path calculated ?

2014-02-26 Thread Gaurav Sharma
Hi, I have been trying to trace the for how address translation is done for any load/store instructions. I was trying to emulate arm on an x86-64 machine. However, i need some clarifications : 1. During the slow path, qemu uses helper functions to translate address. 2. This is done by calling the

Re: [Qemu-devel] How is address of helper function for slow path calculated ?

2014-02-26 Thread Peter Maydell
On 26 February 2014 13:04, Gaurav Sharma gauravs.2...@gmail.com wrote: Hi, I have been trying to trace the for how address translation is done for any load/store instructions. I was trying to emulate arm on an x86-64 machine. However, i need some clarifications : 1. During the slow path, qemu

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 13:58, Marcelo Tosatti ha scritto: I'd prefer to keep backends simple, with 1:1 mapping to memory regions. I agree. However not all backends may have a mapping to a RAM memory region. A composite backend could create a container memory region whose children are other

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-26 Thread Paolo Bonzini
Il 10/02/2014 18:38, Laszlo Ersek ha scritto: +mem: initial amount of guest memory (default: +stringify(DEFAULT_RAM_SIZE) Mb)\n, I wonder if it should rather say MB -- small b has this bits connotation for me. But I could be wrong. Thanks, will fix this. Also,

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-26 Thread Laszlo Ersek
On 02/26/14 14:29, Paolo Bonzini wrote: Il 10/02/2014 18:38, Laszlo Ersek ha scritto: +mem: initial amount of guest memory (default: +stringify(DEFAULT_RAM_SIZE) Mb)\n, I wonder if it should rather say MB -- small b has this bits connotation for me. But I could be

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 13:45:38 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/02/2014 13:31, Igor Mammedov ha scritto: The problem is that some backends might not be handled the same way. For example, not all backends might produce a single void*/size_t pair for the entire region.

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 14:42, Laszlo Ersek ha scritto: When you have a QemuOpt that takes an argument, then the documentation of the default behavior usually explains the case when the QemuOpt is present, and the argument is absent. The documentation of the default behavior usually doesn't concern the

Re: [Qemu-devel] How is address of helper function for slow path calculated ?

2014-02-26 Thread Gaurav Sharma
Thanks Peter, So, the following instruction only make up the call stack for the function call : 0x2aaade72d120: mov%r14,%rdi 0x2aaade72d123: xor%edx,%edx 0x2aaade72d125: lea-0x42(%rip),%rcx# 0x2aaade72d0ea Thanks, Gaurav On Wed, Feb 26, 2014 at 6:44 PM, Peter Maydell

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 14:43, Igor Mammedov ha scritto: On Wed, 26 Feb 2014 13:45:38 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/02/2014 13:31, Igor Mammedov ha scritto: The problem is that some backends might not be handled the same way. For example, not all backends might produce a single

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 14:29:54 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 10/02/2014 18:38, Laszlo Ersek ha scritto: +mem: initial amount of guest memory (default: +stringify(DEFAULT_RAM_SIZE) Mb)\n, I wonder if it should rather say MB -- small b has this

Re: [Qemu-devel] How is address of helper function for slow path calculated ?

2014-02-26 Thread Peter Maydell
On 26 February 2014 13:46, Gaurav Sharma gauravs.2...@gmail.com wrote: Thanks Peter, So, the following instruction only make up the call stack for the function call : 0x2aaade72d120: mov%r14,%rdi 0x2aaade72d123: xor%edx,%edx 0x2aaade72d125: lea-0x42(%rip),%rcx#

[Qemu-devel] [Bug 902413] Re: qemu-i386-user on ARM host: wine hangs/spins when trying to run anything

2014-02-26 Thread Juan Melgarejo Ludeña
with QEMU expected to turn ver 2.0 in april I wonder this bug is still forgotten. Bugs list on Peter Maydell's post and Dan Kegel's have fixes commited, and I see there are alternative patches from http://patchwork.ozlabs.org/patch/45206/ and http://repo.or.cz/w/qemu/agraf.git linked from

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Igor Mammedov
On Wed, 26 Feb 2014 14:47:28 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/02/2014 14:43, Igor Mammedov ha scritto: On Wed, 26 Feb 2014 13:45:38 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 26/02/2014 13:31, Igor Mammedov ha scritto: The problem is that some backends might

[Qemu-devel] [PATCH v2 0/3] nbd: fix issues when connection breaks

2014-02-26 Thread Stefan Hajnoczi
v2: * Use qemu-iotests 083 test number to avoid conflicts [kwolf] * Test class negotiation without export name [lupine] * Test short replies from the server [lupine] The first patch ensures the nbd_receive_reply() fd handler is unregistered when the connection to the server breaks. This

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: add 083 NBD client disconnect tests

2014-02-26 Thread Stefan Hajnoczi
This new test case uses nbd-fault-injector.py to simulate broken TCP connections at each stage in the NBD protocol. This way we can exercise block/nbd-client.c's socket error handling code paths. In particular, this serves as a regression test to make sure nbd-client.c doesn't cause an infinite

[Qemu-devel] [PATCH v2 2/3] tests: add nbd-fault-injector.py utility

2014-02-26 Thread Stefan Hajnoczi
The nbd-fault-injector.py script is a special kind of NBD server. It throws away all writes and produces zeroes for reads. Given a list of fault injection rules, it can simulate NBD protocol errors and is useful for testing NBD client error handling code paths. See the patch for documentation.

[Qemu-devel] [PATCH] MAINTAINERS: drop an out of date address

2014-02-26 Thread Michael S. Tsirkin
Gleb's address seems to be out of date. Since it stayed like that for a while now, I'm guessing he's no longer interested in getting mail. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [PATCH v18 13/14] memory backend: fill memory backend ram fields

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 15:25, Igor Mammedov ha scritto: 1: 'realize' approach I suggested drawback is: assumption that all backends derived from HostMemoryBackend will inherit NUMA controls even if backend shouldn't have one (for example: fictional remote

Re: [Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory

2014-02-26 Thread Christian Borntraeger
On 24/02/14 22:30, Matthew Rosato wrote: This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots, are added to the QEMU command line memory parameter to specify the total amount of memory

Re: [Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 15:42, Christian Borntraeger ha scritto: On 24/02/14 22:30, Matthew Rosato wrote: This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots, are added to the QEMU command line memory

[Qemu-devel] [PATCH v2 5/6] NUMA: convert -numa option to use OptsVisitor

2014-02-26 Thread Igor Mammedov
From: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: - altered doc comment according to Eric Blake ebl...@redhat.com suggestions.

Re: [Qemu-devel] [PATCH v2 0/5] s390: Support for Hotplug of Standby Memory

2014-02-26 Thread Christian Borntraeger
On 26/02/14 15:45, Paolo Bonzini wrote: Il 26/02/2014 15:42, Christian Borntraeger ha scritto: On 24/02/14 22:30, Matthew Rosato wrote: This patchset adds support in s390 for a pool of standby memory, which can be set online/offline by the guest (ie, via chmem). New options, maxmem and slots,

Re: [Qemu-devel] [PATCH] s390: Storage key global access

2014-02-26 Thread Jason J. Herne
On 02/25/2014 02:34 PM, Andreas Färber wrote: Hi, Am 25.02.2014 20:15, schrieb Christian Borntraeger: On 25/02/14 15:34, Jason J. Herne wrote: Christian, at one point you mentioned that it might be helpful to see this patch in the context of the rest of the hotplug patches. If you still

Re: [Qemu-devel] [PATCH v2 1/2] block: gluster - code movements, state storage changes

2014-02-26 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 11:11:11AM -0500, Jeff Cody wrote: In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, store open_flags and filename in the gluster state storage struct, and add a NULL check in the gconf cleanup. It no longer stores open_flags

Re: [Qemu-devel] [PATCH v2 1/2] block: gluster - code movements, state storage changes

2014-02-26 Thread Jeff Cody
On Wed, Feb 26, 2014 at 03:58:40PM +0100, Stefan Hajnoczi wrote: On Mon, Feb 17, 2014 at 11:11:11AM -0500, Jeff Cody wrote: In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, store open_flags and filename in the gluster state storage struct, and add

Re: [Qemu-devel] [PATCH v2 2/2] block: gluster - add reopen support.

2014-02-26 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 11:11:12AM -0500, Jeff Cody wrote: +static int qemu_gluster_reopen_prepare(BDRVReopenState *state, + BlockReopenQueue *queue, Error **errp) +{ +int ret = 0; +BDRVGlusterReopenState *reop_s; +GlusterConf *gconf = NULL;

Re: [Qemu-devel] [PATCH v2 0/2] block: add suppoort for gluster reopen

2014-02-26 Thread Stefan Hajnoczi
On Mon, Feb 17, 2014 at 11:11:10AM -0500, Jeff Cody wrote: Changes v1-v2: Patch 1: Removed unneeded state variables 'filename' and 'open_flags' (Stefan) Patch 2: Removed unneeded reopen state variable 'open_flags' (Stefan) This series provides support

Re: [Qemu-devel] [PATCH v2 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-26 Thread Michael S. Tsirkin
On Mon, Feb 24, 2014 at 02:09:18PM +0200, Marcel Apfelbaum wrote: If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables differ from expected ones. Signed-off-by: Marcel Apfelbaum marce...@redhat.com

Re: [Qemu-devel] [PATCH V3 0/3] Fix some quorum nits after merge

2014-02-26 Thread Stefan Hajnoczi
On Sat, Feb 22, 2014 at 06:43:39PM +0100, Benoît Canet wrote: in v3: use $QEMU_IMG (Fam) apply Eric reviewed by in v2: make error optional and return strerror(-ret) [Eric] better documentation of the error string [Eric] apply Eric reviewed by Benoît Canet (3):

[Qemu-devel] [PATCH] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-02-26 Thread Paul Moore
Additional testing reveals that PulseAudio requires shmctl() and the mlock()/munlock() syscalls on some systems/configurations. As before, on systems that do require these syscalls, the problem can be seen with the following command line: # qemu -monitor stdio -sandbox on \ -device

Re: [Qemu-devel] [PATCH v2 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-26 Thread Marcel Apfelbaum
On Wed, 2014-02-26 at 17:25 +0200, Michael S. Tsirkin wrote: On Mon, Feb 24, 2014 at 02:09:18PM +0200, Marcel Apfelbaum wrote: If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl installation is OK and issue an error if the actual tables differ from

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Stefan Hajnoczi
On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source files of a qemu-img convert process if the source is a host_device? Currently the backup of a host device is polluting the page cache. Points to

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Eric Blake
On 02/26/2014 08:41 AM, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source files of a qemu-img convert process if the source is a host_device? Currently the backup of a host

Re: [Qemu-devel] [PATCH v2 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-26 Thread Marcel Apfelbaum
On Wed, 2014-02-26 at 17:52 +0200, Michael S. Tsirkin wrote: On Wed, Feb 26, 2014 at 05:39:39PM +0200, Marcel Apfelbaum wrote: On Wed, 2014-02-26 at 17:25 +0200, Michael S. Tsirkin wrote: On Mon, Feb 24, 2014 at 02:09:18PM +0200, Marcel Apfelbaum wrote: If the expected (offline) acpi

Re: [Qemu-devel] qemu-img convert cache mode for source

2014-02-26 Thread Peter Lieven
On 26.02.2014 16:41, Stefan Hajnoczi wrote: On Wed, Feb 26, 2014 at 11:14:04AM +0100, Peter Lieven wrote: I was wondering if it would be a good idea to set the O_DIRECT mode for the source files of a qemu-img convert process if the source is a host_device? Currently the backup of a host

[Qemu-devel] [PATCH RESEND] CODING_STYLE: Section about mixed declarations

2014-02-26 Thread Eduardo Habkost
We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Stefan Weil s...@weilnetz.de --- Changes v2: * s/be at beginning/be at the beginning/ --- CODING_STYLE | 7 +++ 1 file

[Qemu-devel] [PATCH v2 1/3] nbd: close socket if connection breaks

2014-02-26 Thread Stefan Hajnoczi
nbd_receive_reply() is called by the event loop whenever data is available or the socket has been closed by the remote side. This patch closes the socket when an error occurs to prevent the nbd_receive_reply() handler from being called indefinitely after the connection has failed. Note that we

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 14:50, Igor Mammedov ha scritto: It should be fixed in v3 that you were going to apply to numa branch https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02321.html Yes, applied now. Thanks, Paolo

Re: [Qemu-devel] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor

2014-02-26 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 04:49:41PM +0100, Igor Mammedov wrote: ... while at it move most of numa related code to a dedicated file so that it won't to clatter vl.c. git tree for testing: https://github.com/imammedo/qemu/commits/numa_prep_v1 Igor Mammedov (1): vl.c: fix style issue Just

Re: [Qemu-devel] [PATCH 4/6] NUMA: Add numa_info structure to contain numa nodes info

2014-02-26 Thread Michael S. Tsirkin
On Mon, Feb 17, 2014 at 04:49:45PM +0100, Igor Mammedov wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost ehabk...@redhat.com

Re: [Qemu-devel] [PATCH v8 00/17] Vhost and vhost-net support for userspace based backends

2014-02-26 Thread Michael S. Tsirkin
On Thu, Feb 13, 2014 at 01:03:11PM +0100, Antonios Motakis wrote: In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving

Re: [Qemu-devel] [PATCH 0/6] convert -numa to QemuOpts/OptsVisitor

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 17:42, Michael S. Tsirkin ha scritto: ... while at it move most of numa related code to a dedicated file so that it won't to clatter vl.c. git tree for testing: https://github.com/imammedo/qemu/commits/numa_prep_v1 Igor Mammedov (1): vl.c: fix style issue Just to clarify

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-26 Thread Fabien Chouteau
On 02/26/2014 08:56 AM, Sebastian Huber wrote: Hello, exists there someone who is able to commit this? I'm sorry Sebastian, as you probably understood the SPARC maintainer is missing which makes commit process more difficult that it used to be... Peter, as discussed in a previous mail, do

Re: [Qemu-devel] [PATCH v2 2/2] acpi-test: issue errors instead of warnings when possible

2014-02-26 Thread Michael S. Tsirkin
On Wed, Feb 26, 2014 at 05:39:39PM +0200, Marcel Apfelbaum wrote: On Wed, 2014-02-26 at 17:25 +0200, Michael S. Tsirkin wrote: On Mon, Feb 24, 2014 at 02:09:18PM +0200, Marcel Apfelbaum wrote: If the expected (offline) acpi tables loaded correctly, it is safe to assume the iasl

Re: [Qemu-devel] [PATCH 4/4] virt: Set reset-cbar on CPUs

2014-02-26 Thread Peter Maydell
On 25 February 2014 08:23, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Tue, Feb 25, 2014 at 6:24 AM, Peter Maydell peter.mayd...@linaro.org wrote: Set the reset-cbar property on CPUs used by the virt board, if they have it. This isn't necessary for correct functioning under

Re: [Qemu-devel] [PATCH 0/3] Extract non-QDicts in qdict_array_split()

2014-02-26 Thread Max Reitz
On 21.02.2014 23:32, Eric Blake wrote: On 02/21/2014 11:11 AM, Max Reitz wrote: Currently, qdict_array_split() splits a QDict like { 0.a: 42, 1: 23, 2.b: 84 } into the QList [ { a: 42 } ] with the QDict still being { 1: 23, 2.b: 84 } However, it makes more sense to create the QList

Re: [Qemu-devel] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size

2014-02-26 Thread Eduardo Habkost
On Mon, Feb 17, 2014 at 04:49:44PM +0100, Igor Mammedov wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table, then the guest will ignore the wrong ACPI table

Re: [Qemu-devel] [PATCH target-arm v2 0/7] PL330 Changes

2014-02-26 Thread Peter Maydell
On 25 February 2014 23:56, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi Peter, Some minor fixups and tweaks to PL330. changed since v1: Addressed PMM review. Thanks; applied to target-arm.next. -- PMM

[Qemu-devel] [PATCH 1/4] s390: Storage key global access

2014-02-26 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c | 3 +-- hw/s390x/s390-virtio.c | 6 +++---

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-26 Thread Peter Maydell
On 26 February 2014 16:59, Fabien Chouteau chout...@adacore.com wrote: On 02/26/2014 08:56 AM, Sebastian Huber wrote: Hello, exists there someone who is able to commit this? I'm sorry Sebastian, as you probably understood the SPARC maintainer is missing which makes commit process more

[Qemu-devel] [PATCH 4/4] s390-hotplug: Implement hot_add_cpu hook

2014-02-26 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c | 1 + target-s390x/cpu.c | 29 + target-s390x/cpu.h | 2 ++ 3

Re: [Qemu-devel] [PATCH 3/6] NUMA: check if the total numa memory size is equal to ram_size

2014-02-26 Thread Paolo Bonzini
Il 26/02/2014 18:15, Eduardo Habkost ha scritto: On Mon, Feb 17, 2014 at 04:49:44PM +0100, Igor Mammedov wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table,

  1   2   3   >