Re: [Qemu-devel] VNC viewer displays nothing with -enable-kvm but works fine without -enable-kvm

2014-03-20 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 04:02:58PM +0800, Le Tan wrote: > Hi, I used qemu-kvm-1.2.0 before. I can run qemu with kvm well. Two days > ago, I updated qemu to qemu-1.6.2, and start the qemu with the command: > qemu-system-x86_64 -m 2048 -smp 4 -hda /home/tanle/study/new.img -nographic > -vnc 162.105.1

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-03-20 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 08:27:18AM +0100, Jan Kiszka wrote: > On 2014-02-11 14:08, Samuel Thibault wrote: > > Hello, > > > > This is a respin of IPv6 in Qemu -net user mode. > > > > These patches add ICMPv6, NDP, and make UDP and TCP compatible with > > IPv6. We have made some refactoring to make

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-03-20 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 06:13:18PM +0100, Joaquim Barrera wrote: > On 28/02/14 11:43, Paolo Bonzini wrote: > >Il 28/02/2014 11:41, Joaquim Barrera ha scritto: > >>> > >> > >>Thanks for the answer. Something is still not clear to me. Are we in > >>front of a bug (that means, something that could be

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-20 Thread Stefan Hajnoczi
On Tue, Mar 18, 2014 at 01:30:44PM +, Daniel P. Berrange wrote: > On Tue, Mar 18, 2014 at 02:08:19PM +0100, Stefan Hajnoczi wrote: > > On Mon, Mar 17, 2014 at 08:48:08PM -0400, Hamilton, Peter A. wrote: > > I guess the filter would be deployed below the image format: > > qcow2 -> luks -> file >

Re: [Qemu-devel] Want to discuss about Outreach Program for Women

2014-03-20 Thread Stefan Hajnoczi
On Wed, Mar 19, 2014 at 08:34:08PM +0530, preeti soni wrote: > I want to discuss about project in which I am interested. Can you please > give me How I can do this. As early as possible. The application deadline was 19:00 UTC on 19th of March. I'm afraid it's too late. Google Summer of Code is s

Re: [Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-03-20 Thread Samuel Thibault
Stefan Hajnoczi, le Thu 20 Mar 2014 08:58:11 +0100, a écrit : > My suggestion is to split all the preparation and cleanups into a > smaller patch series that can be applied easily. > > It will make the real IPv6 series smaller and hopefully more amenable to > review. Well, I believe it's already

Re: [Qemu-devel] [PATCH v22 13/25] qed.c: replace QEMUOptionParameter with QemuOpts

2014-03-20 Thread Chun Yan Liu
>>> On 3/11/2014 at 10:24 PM, in message <20140311142451.gm7...@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi wrote: > On Mon, Mar 10, 2014 at 03:31:49PM +0800, Chunyan Liu wrote: > > diff --git a/block/qed.h b/block/qed.h > > index 5d65bea..b024751 100644 > > --- a/block/qed.h > > +++ b/b

[Qemu-devel] ide_generic: please use "probe_mask=0x3f" module parameter for probing all legacy ISA IDE ports

2014-03-20 Thread Atlas Khan
I am running a VM and giving it a qcow file as its root file system. But it is giving me following error. ide_generic: please use "probe_mask=0x3f" module parameter for probing all legacy ISA IDE ports Can any one tell me what is the kernel configuration to solve this error. if you want full out

Re: [Qemu-devel] Multiple pci buses

2014-03-20 Thread BALATON Zoltan
On Wed, 19 Mar 2014, Andreas Färber wrote: Just stumbled over a text file of our G4: --->8--- :00:0b.0 Apple Computer Inc. UniNorth AGP [106b:0020] 0001:10:0b.0 Apple Computer Inc. UniNorth PCI [106b:001f] 0001:10:0d.0 Digital Equipment Corporation DECchip 21154 [1011:0026] 0002:21:0b.0 A

Re: [Qemu-devel] [PATCH 4/5] sclp-s390: Define new SCLP codes and structures

2014-03-20 Thread Christian Borntraeger
On 16/12/13 21:51, Matthew Rosato wrote: > Define new SCLP codes and structures that will be needed for s390 memory > hotplug. > > Signed-off-by: Matthew Rosato > --- > hw/s390x/sclp.c |2 +- > include/hw/s390x/sclp.h | 46 ++ > 2 files c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Mon, 17 Mar 2014, Gerd Hoffmann wrote: C 07 Communication controller 00 Serial controller 00 8250 01 16450 02 16550 What about multi_serial_pci_init() -- should it too set prog-if like this? I'm not completely sure what the correct

Re: [Qemu-devel] [Qemu-ppc] [PATCH] mac99: Bring memory layout closer to real hardware

2014-03-20 Thread BALATON Zoltan
On Sat, 15 Mar 2014, BALATON Zoltan wrote: Try to better match the memory map of a PowerMac3,1 model by moving the pci-cfg mappings to where they are on a real machine. Also add the VGA card after the macio to let the latter be mapped from 0x8000 to match hardware. (On real hardware the graph

Re: [Qemu-devel] [PATCH v5 02/11] int128: add int128_exts64()

2014-03-20 Thread Paolo Bonzini
Il 12/03/2014 06:52, Alexey Kardashevskiy ha scritto: This adds macro to extend signed 64bit value to signed 128bit value. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * (.hi = (a >> 63) ? -1 : 0) changed to (.hi = (a < 0) ? -1 : 0) --- include/qemu/int128.h | 5 + 1 file changed,

Re: [Qemu-devel] [PATCH v5 01/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace

2014-03-20 Thread Paolo Bonzini
Il 12/03/2014 06:52, Alexey Kardashevskiy ha scritto: From: David Gibson At the moment, most AddressSpace objects last as long as the guest system in practice, but that could well change in future. In addition, for VFIO we will be introducing some private per-AdressSpace information, which mus

Re: [Qemu-devel] [PATCH v5 03/11] vfio: Fix 128 bit handling

2014-03-20 Thread Paolo Bonzini
Il 12/03/2014 06:52, Alexey Kardashevskiy ha scritto: Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU memory region with UINT64_MAX (2^64 bytes) size so int128_get64() will assert. The patch takes care of this check. The existing type1 IOMMU code is not expected to map all 64 bits

Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy

2014-03-20 Thread Paolo Bonzini
Il 12/03/2014 07:31, Fam Zheng ha scritto: +HBitmap *hbitmap_copy(const HBitmap *bitmap) +{ +int i; +HBitmap *hb = g_memdup(bitmap, sizeof(struct HBitmap)); + +for (i = HBITMAP_LEVELS; i-- > 0; ) { +hb->levels[i] = g_memdup(bitmap->levels[i], +

Re: [Qemu-devel] [PATCH v4 04/10] target-mips: get_physical_address: Add KVM awareness

2014-03-20 Thread James Hogan
On 19/03/14 16:33, Paolo Bonzini wrote: > Il 14/03/2014 13:47, James Hogan ha scritto: >> +if (kvm_enabled()) { >> +/* KVM T&E adds guest kernel segments in useg */ >> +if (real_address >= KVM_KSEG0_BASE) { >> +if (real_address < KVM_KSEG2_BASE) { >> +

Re: [Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-20 Thread James Hogan
On 19/03/14 16:39, Paolo Bonzini wrote: > Il 14/03/2014 13:47, James Hogan ha scritto: >> This patchset is based on Sanjay Lal's V1 patchset from 2nd March 2013: >> https://patchwork.kernel.org/project/kvm/list/?submitter=51991&state=*&q=qemu-devel >> >> >> I think I've addressed all the V1 feedbac

Re: [Qemu-devel] [PATCH v4 01/10] hw/mips/cputimer: Don't start periodic timer in KVM mode

2014-03-20 Thread James Hogan
On 19/03/14 16:29, Paolo Bonzini wrote: > Il 14/03/2014 13:47, James Hogan ha scritto: >> From: Sanjay Lal >> >> Compare/Count timer interrupts are handled in-kernel for KVM, so don't >> bother starting it in QEMU. >> >> Signed-off-by: Sanjay Lal >> Signed-off-by: James Hogan >> Reviewed-by: Aur

Re: [Qemu-devel] [PATCH v4 08/10] hw/mips: malta: Add KVM support

2014-03-20 Thread James Hogan
On 19/03/14 16:39, Paolo Bonzini wrote: > Il 14/03/2014 13:47, James Hogan ha scritto: >> int prom_index = 0; >> +uint64_t (*xlate_to_phys) (void *opaque, uint64_t addr); >> +uint64_t (*xlate_to_kseg0) (void *opaque, uint64_t addr); >> + >> >> #ifdef TARGET_WORDS_BIGENDIAN >> big

Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy

2014-03-20 Thread Fam Zheng
On Thu, 03/20 11:22, Paolo Bonzini wrote: > Il 12/03/2014 07:31, Fam Zheng ha scritto: > >+HBitmap *hbitmap_copy(const HBitmap *bitmap) > >+{ > >+int i; > >+HBitmap *hb = g_memdup(bitmap, sizeof(struct HBitmap)); > >+ > >+for (i = HBITMAP_LEVELS; i-- > 0; ) { > >+hb->levels[i] =

[Qemu-devel] QOM cast debug

2014-03-20 Thread Laurent Desnogues
Hello, while looking at some perf results, I saw object_dynamic_cast_assert taking more than 3% of the run time. After some digging I found out that this time can be cut by passing --disable-qom-cast-debug to configure. This was added by Paolo: commit 3556c233d931ad5ffa46a35cb25cfc057732ebb8 Au

Re: [Qemu-devel] [PATCH v5 01/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace

2014-03-20 Thread David Gibson
On Thu, Mar 20, 2014 at 11:20:09AM +0100, Paolo Bonzini wrote: > Il 12/03/2014 06:52, Alexey Kardashevskiy ha scritto: > >From: David Gibson > > > >At the moment, most AddressSpace objects last as long as the guest system > >in practice, but that could well change in future. In addition, for VFIO

[Qemu-devel] [PATCH] migration: static variables will not be reset at second migration

2014-03-20 Thread arei.gonglei
From: ChenLiang The static variables in migration_bitmap_sync will not be reset in the case of a second attempted migration. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_

Re: [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2

2014-03-20 Thread Peter Maydell
On 20 March 2014 01:48, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC queue into qemu.git master. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Alexander Graf > Cc: Alexey Kardashevskiy > Cc: Paolo Bonzini > > The following changes since commit

Re: [Qemu-devel] VNC viewer displays nothing with -enable-kvm but works fine without -enable-kvm

2014-03-20 Thread Le Tan
I have tried 1.7.0 and it doesn't work either. And I find that it doesn't work with QEMU whose version is above 1.3. Then I change the kernel from 3.11.0 to the latest release, and it works fine with QEMU 1.6.2 and 1.7.0!!! I know that qemu-kvm have been merged back into qemu after 1.2.2. So maybe

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Markus Armbruster
Paolo Bonzini writes: > This is the model file that is being used for the QEMU project's scans > on scan.coverity.com. It fixed about 30 false positives (10% of the > total) and exposed about 60 new memory leaks. > > The file is not automatically used; changes to it must be propagated > to the w

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Markus Armbruster
Paolo Bonzini writes: > Il 19/03/2014 18:32, Eric Blake ha scritto: >>> + * >>> + * Copyright (C) 2014 Red Hat, Inc. >>> + * >>> + * Authors: >>> + * Markus Armbruster >>> + * Paolo Bonzini >>> + * >>> + * This work is licensed under the terms of the GNU GPL, version 2 >>> or, at your >>> + *

Re: [Qemu-devel] [PATCH v3] kvm: add set_one_reg/get_one_reg helpers

2014-03-20 Thread Alexey Kardashevskiy
On 09/27/2013 07:08 PM, Alexey Kardashevskiy wrote: > On 09/27/2013 06:59 PM, Paolo Bonzini wrote: >> Il 27/09/2013 10:02, Alexey Kardashevskiy ha scritto: >>> On 09/19/2013 12:45 PM, Alexey Kardashevskiy wrote: This adds QEMU wrappers for KVM_SET_ONE_REG/KVM_GET_ONE_REG ioctls. >>> >>> Ping?

Re: [Qemu-devel] Raspbian in QEMU

2014-03-20 Thread Paolo Bonzini
Il 12/03/2014 21:01, Peter Maydell ha scritto: On 12 March 2014 19:41, Richard Henderson wrote: Ew. No. It would be easier to just implement setend, even if badly. Agreed. For my part, the endian-aware load/store opcodes I alluded to last August are now in. Yes, it would be fairly strai

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-20 Thread Markus Armbruster
Rusty Russell writes: > Markus Armbruster writes: >> Rusty Russell writes: >>> The litmus test: does *your* guest handle failures other than by giving >>> up on the device? If so, sure, you need to have a sane error-reporting >>> strategy. >> >> Err, isn't this a circular argument? No need fo

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-20 Thread Daniel P. Berrange
On Thu, Mar 20, 2014 at 09:23:14AM +0100, Stefan Hajnoczi wrote: > On Tue, Mar 18, 2014 at 01:30:44PM +, Daniel P. Berrange wrote: > > On Tue, Mar 18, 2014 at 02:08:19PM +0100, Stefan Hajnoczi wrote: > > > On Mon, Mar 17, 2014 at 08:48:08PM -0400, Hamilton, Peter A. wrote: > > > I guess the fil

Re: [Qemu-devel] [PATCH v2 1/2] Provide init function for ram migration

2014-03-20 Thread Gonglei (Arei)
> Subject: [PATCH v2 1/2] Provide init function for ram migration > > From: "Dr. David Alan Gilbert" > > Provide ram_mig_init (like blk_mig_init) for vl.c to initialise stuff > to do with ram migration (currently in arch_init.c). > > Signed-off-by: Dr. David Alan Gilbert > --- > arch_init.c

Re: [Qemu-devel] [PATCH v2 2/2] Init the XBZRLE.lock in ram_mig_init

2014-03-20 Thread Gonglei (Arei)
> Subject: [PATCH v2 2/2] Init the XBZRLE.lock in ram_mig_init > > From: "Dr. David Alan Gilbert" > > Initialising the XBZRLE.lock earlier simplifies the lock use. > > Based on Markus's patch in: > http://lists.gnu.org/archive/html/qemu-devel/2014-03/msg03879.html > > Signed-off-by: Dr. David

Re: [Qemu-devel] [PATCH v4 00/10] KVM Support for MIPS32 Processors

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 11:00, James Hogan ha scritto: > Just a few comments. With what version of the kernel can this be tested? KVM support was added in v3.10, including defconfigs and a CONFIG_KVM_GUEST to ensure the kernel is linked to the different address. Yes, but you still need support for CP0_

Re: [Qemu-devel] [PULL for 2.0 0/5] MinGW related patches

2014-03-20 Thread Peter Maydell
On 20 March 2014 06:29, Stefan Weil wrote: > Am 20.03.2014 07:25, schrieb Stefan Weil: >> This includes a patch for GTK (needed for MinGW, but not restricted to it) >> and most of the patches which restructure the includes for the Win API. >> I ommitted the last optional block patch. >> >> Stefan

Re: [Qemu-devel] QOM cast debug

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 11:52, Laurent Desnogues ha scritto: Hello, while looking at some perf results, I saw object_dynamic_cast_assert taking more than 3% of the run time. After some digging I found out that this time can be cut by passing --disable-qom-cast-debug to configure. This was added by Paolo

Re: [Qemu-devel] USB passthru of hub

2014-03-20 Thread Gerd Hoffmann
On Mi, 2014-03-19 at 21:52 +, Stuart Yoder wrote: > Hi Gerd, > > In the "USB 2.0 Quick Start" write-up you said about USB > passthrough: > > > (2) hostbus+hostport -- match for a specific physical port in the > > host, any device which is plugged in there gets passed to the > > gue

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-20 Thread Peter Maydell
On 20 March 2014 06:39, Markus Armbruster wrote: > Time to cease the practice. Will be hard as long as the code > is chock-full of bad examples. I've been consistently rejecting new instances of guest triggerable exit() or abort() in code review when I see them for at least the last six months t

Re: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock

2014-03-20 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Markus Armbruster spotted that the XBZRLE.lock might get initalised > multiple times in the case of a second attempted migration, and > that's undefined behaviour for pthread_mutex_init. > > This patchset is based on Mar

Re: [Qemu-devel] [PATCH v2 0/2] Stop reinit of XBZRLE.lock

2014-03-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > > From: "Dr. David Alan Gilbert" > > > > Markus Armbruster spotted that the XBZRLE.lock might get initalised > > multiple times in the case of a second attempted migration, and > > that's undefined behavi

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-20 Thread Luiz Capitulino
On Wed, 19 Mar 2014 22:58:11 +0100 Andreas Färber wrote: > Am 19.03.2014 22:03, schrieb Luiz Capitulino: > > Linux guests, when using more than 4GB of RAM, may end up using 1GB pages > > to store (kernel) data. When this happens, we're unable to debug a running > > Linux kernel with GDB: > > > >

Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace internal thread with IOThread

2014-03-20 Thread Stefan Hajnoczi
On Mon, Mar 17, 2014 at 04:52:59PM +0100, Christian Borntraeger wrote: > This causes the following bug during managedsave of s390 with a guest that > has multiple disks with dataplane. > > (gdb) bt > #0 object_deinit (type=0x0, obj=0x807e8750) at > /home/cborntra/REPOS/qemu/qom/object.c:410 > #

[Qemu-devel] [PATCH 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-03-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Make qemu_peek_buffer repatedly call fill_buffer until it gets all the data it requires, or until there is an error. At the moment, qemu_peek_buffer will try one qemu_fill_buffer if there isn't enough data waiting, however the kernel is entitled to return jus

Re: [Qemu-devel] [PATCH v2] scripts: add sample model file for Coverity Scan

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 08:32, Markus Armbruster ha scritto: +static void __write(uint8_t *buf, int len) Will the fact that you used 'int len' instead of 'size_t' bite us on 32- vs. 64-bit? Same for __read. Yeah, I copied this from address_space_rw. I'll change to ssize_t to catch negative values.

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-20 Thread Paolo Bonzini
Il 19/03/2014 22:03, Luiz Capitulino ha scritto: Linux guests, when using more than 4GB of RAM, may end up using 1GB pages to store (kernel) data. When this happens, we're unable to debug a running Linux kernel with GDB: (gdb) p node_data[0]->node_id Cannot access memory at address 0x88013ff

Re: [Qemu-devel] [PATCH RFT for-2.0-rc1] make-release: Record SeaBIOS version

2014-03-20 Thread Gerd Hoffmann
> +(cd roms/seabios && git describe --tags --long --dirty > .version) > rm -rf .git roms/*/.git dtc/.git pixman/.git Looks good. Mimics what roms/seabios/scripts/buildversion.sh is doing in case .git is present. Reviewed-by: Gerd Hoffmann cheers, Gerd

[Qemu-devel] [PATCH v3 for 2.0] update names in option tables to match with actual command-line spelling

2014-03-20 Thread Amos Kong
We want to establish a mapping between option name and option table, then we can search related option table by option name. This patch makes all the member name of QemuOptsList to match with actual command-line spelling(option name). [ Important Note ] The QemuOptsList member name values are AB

Re: [Qemu-devel] [PATCH v2 for-2.0] target-i386: x86_cpu_get_phys_page_debug(): support 1GB page translation

2014-03-20 Thread Jan Kiszka
On 2014-03-19 22:03, Luiz Capitulino wrote: > Linux guests, when using more than 4GB of RAM, may end up using 1GB pages > to store (kernel) data. When this happens, we're unable to debug a running > Linux kernel with GDB: > > (gdb) p node_data[0]->node_id > Cannot access memory at address 0x88

Re: [Qemu-devel] Raspbian in QEMU

2014-03-20 Thread François Revol
On 20/03/2014 13:36, Paolo Bonzini wrote: > Il 12/03/2014 21:01, Peter Maydell ha scritto: >> On 12 March 2014 19:41, Richard Henderson wrote: >>> Ew. No. It would be easier to just implement setend, even if badly. >> >> Agreed. >> >>> For my part, the endian-aware load/store opcodes I alluded t

Re: [Qemu-devel] [PATCH v3 8/9] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-03-20 Thread Eric Blake
On 03/17/2014 01:46 AM, Fam Zheng wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. > > There are two bitma

Re: [Qemu-devel] [PATCH v5 3/3] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-03-20 Thread Mike Day
Alexey Kardashevskiy writes: > This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from > the H_SET_MODE, for POWER8 (PowerISA 2.07) only. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day > --- > hw/ppc/spapr_hcall.c | 26 ++ > target-ppc/cpu.h

Re: [Qemu-devel] Raspbian in QEMU

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 14:08, François Revol ha scritto: > I looked at that yesterday and it took me exactly one hour... I'll > submit it for 2.1 since I'm interested (for non-work reasons) in > Raspberry Pi emulation. Just so you don't start rewriting the wheel: https://github.com/Torlus/qemu/tree/rpi

Re: [Qemu-devel] [PATCH v7 for 2.0 3/4] raw-posix: Add full image preallocation option

2014-03-20 Thread Kevin Wolf
Am 17.03.2014 um 07:53 hat Hu Tao geschrieben: > This patch adds a new option preallocation for raw format, and implements > full preallocation. > > Signed-off-by: Hu Tao > --- > block/raw-posix.c | 43 +++ > 1 file changed, 35 insertions(+), 8 deletions(-

Re: [Qemu-devel] QOM cast debug

2014-03-20 Thread Laurent Desnogues
On Thu, Mar 20, 2014 at 1:45 PM, Paolo Bonzini wrote: > Il 20/03/2014 11:52, Laurent Desnogues ha scritto: > >> Hello, >> >> while looking at some perf results, I saw object_dynamic_cast_assert >> taking more than 3% of the run time. >> >> After some digging I found out that this time can be cut b

Re: [Qemu-devel] QOM cast debug

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 14:24, Laurent Desnogues ha scritto: On Thu, Mar 20, 2014 at 1:45 PM, Paolo Bonzini wrote: Il 20/03/2014 11:52, Laurent Desnogues ha scritto: Hello, while looking at some perf results, I saw object_dynamic_cast_assert taking more than 3% of the run time. After some digging I f

Re: [Qemu-devel] [PATCH v7 for 2.0 4/4] qcow2: Add full image preallocation option

2014-03-20 Thread Kevin Wolf
Am 17.03.2014 um 07:53 hat Hu Tao geschrieben: > This adds a preallocation=full mode to qcow2 image creation, which > creates a non-sparse image file. > > Signed-off-by: Hu Tao I see that you changed the implementation from bdrv_preallocate() to bdrv_create() options in v4 after Stefan had asked

Re: [Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace internal thread with IOThread

2014-03-20 Thread Christian Borntraeger
On 20/03/14 11:13, Stefan Hajnoczi wrote: > On Mon, Mar 17, 2014 at 04:52:59PM +0100, Christian Borntraeger wrote: >> This causes the following bug during managedsave of s390 with a guest that >> has multiple disks with dataplane. >> >> (gdb) bt >> #0 object_deinit (type=0x0, obj=0x807e8750) at

Re: [Qemu-devel] [PULL for 2.0 5/5] w32: Replace Windows specific data types in common header files

2014-03-20 Thread Andreas Färber
Am 20.03.2014 07:25, schrieb Stefan Weil: > These header files are used by most QEMU source files. If they > depend on windows.h, all those source files do so, too. > > All Windows specific data types which are replaced use identical > definitions for the 32 and 64 bit Windows APIs. HANDLE, LONG >

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-20 Thread Amos Kong
On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 03/05/2014 07:36 PM, Amos Kong wrote: > >> vm_config_groups[] only contains part of the options which have > >> argument, and all options which have no argument aren't added > >> to vm_config_groups[]

Re: [Qemu-devel] n ways block filters

2014-03-20 Thread Benoît Canet
The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote : > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben: > > On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng wrote: > > > On Fri, 03/14 16:57, Benoît Canet wrote: > > >> I discussed a bit with Stefan on the list and we came to the conclusi

[Qemu-devel] [PATCH for-2.0 1/2] iothread: make IOThread struct definition public

2014-03-20 Thread Stefan Hajnoczi
Make the IOThread struct definition public so objects can be embedded in parent structs. Signed-off-by: Stefan Hajnoczi --- include/sysemu/iothread.h | 12 +++- iothread.c| 11 --- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/include/sysemu/iot

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-20 Thread Amos Kong
On Tue, Mar 11, 2014 at 10:04:56AM +0100, Markus Armbruster wrote: > Eric Blake writes: > > > On 03/07/2014 02:54 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >>> On 03/05/2014 07:36 PM, Amos Kong wrote: > vm_config_groups[] only contains part of the options which have > >>>

[Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance

2014-03-20 Thread Stefan Hajnoczi
Before IOThread was its own object, each virtio-blk device would create its own internal thread. We need to preserve this behavior for backwards compatibility when users do not specify -device virtio-blk-pci,iothread=. This patch changes how the internal IOThread object is created. Previously we

Re: [Qemu-devel] [PATCH v22 13/25] qed.c: replace QEMUOptionParameter with QemuOpts

2014-03-20 Thread Stefan Hajnoczi
On Thu, Mar 20, 2014 at 03:08:07AM -0600, Chun Yan Liu wrote: > > > >>> On 3/11/2014 at 10:24 PM, in message > <20140311142451.gm7...@stefanha-thinkpad.redhat.com>, Stefan Hajnoczi > wrote: > > On Mon, Mar 10, 2014 at 03:31:49PM +0800, Chunyan Liu wrote: > > > diff --git a/block/qed.h b/block/

[Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision

2014-03-20 Thread Stefan Hajnoczi
Christian Borntraeger noticed that the naming of the internal IOThread objects, which are created when the user does not specify an IOThread explicitly, can result in collisions. These patches make the IOThread object nameless so it cannot cause collisions. This is important when multiple datapla

Re: [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto: Christian Borntraeger noticed that the naming of the internal IOThread objects, which are created when the user does not specify an IOThread explicitly, can result in collisions. These patches make the IOThread object nameless so it cannot cause

Re: [Qemu-devel] [PATCH for-2.0 2/2] dataplane: replace iothread object_add() with embedded instance

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 15:06, Stefan Hajnoczi ha scritto: +object_initialize(&s->internal_iothread_obj, + sizeof(s->internal_iothread_obj), + TYPE_IOTHREAD); +user_creatable_complete(OBJECT(&s->internal_iothread_obj), &error_abort); Perh

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-20 Thread Amos Kong
On Thu, Mar 20, 2014 at 10:03:12PM +0800, Amos Kong wrote: > On Fri, Mar 07, 2014 at 10:54:09AM +0100, Markus Armbruster wrote: > > Eric Blake writes: > > > > > On 03/05/2014 07:36 PM, Amos Kong wrote: > > >> vm_config_groups[] only contains part of the options which have > > >> argument, and all

Re: [Qemu-devel] [PATCH for-2.0 0/2] dataplane: fix internal IOThread name collision

2014-03-20 Thread Christian Borntraeger
On 20/03/14 15:06, Stefan Hajnoczi wrote: > Christian Borntraeger noticed that the naming of the > internal IOThread objects, which are created when the user does not specify an > IOThread explicitly, can result in collisions. > > These patches make the IOThread object nameless so it cannot cause

[Qemu-devel] [RFC 7/8] pc: initialize memory hotplug address space

2014-03-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 18 -- include/hw/i386/pc.h |3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7bfd2c9..1824c3d 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1155,6 +1155,7 @@ F

[Qemu-devel] [RFC 2/8] make machine_class_init() accessible outside of vl.c

2014-03-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/core/machine.c |7 +++ include/hw/boards.h |2 ++ vl.c|7 --- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index d3ffef7..ae308f4 100644 --- a/hw/core/machine.c +++ b/

[Qemu-devel] [RFC 3/8] pc: prepare PC for custom machine state

2014-03-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 26 ++ hw/i386/pc_piix.c| 34 +- hw/i386/pc_q35.c | 10 +- include/hw/i386/pc.h | 14 ++ 4 files changed, 62 insertions(+), 22 deletions(-) diff --g

[Qemu-devel] [RFC 5/8] dimm: implement dimm device abstraction

2014-03-20 Thread Igor Mammedov
From: Vasilis Liaskovitis Each hotplug-able memory slot is a DimmDevice. All DimmDevices are attached to a new bus called DimmBus. A hot-add operation for a DIMM: - creates a new DimmDevice and attaches it to the DimmBus Hotplug operations are done through normal device_add commands. For migrat

[Qemu-devel] [RFC 6/8] pc: preallocate hotplug links for DIMMDevices

2014-03-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 33 + include/hw/i386/pc.h |6 ++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e0bc3a2..7bfd2c9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1

[Qemu-devel] [RFC 8/8] pc: make PC_MACHINE memory hotplug controller

2014-03-20 Thread Igor Mammedov
that performs mapping of DIMM into guest's address space Signed-off-by: Igor Mammedov --- hw/i386/pc.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1824c3d..1cef30d 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -14

[Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/core/hotplug.c | 30 ++ hw/core/qdev.c | 15 +++ include/hw/hotplug.h |2 ++ include/hw/qdev-core.h |6 ++ 4 files changed, 53 insertions(+), 0 deletions(-) diff --git a/hw/core/hotplug.c b

[Qemu-devel] [RFC 1/8] vl.c: extend -m option to support options for memory hotplug

2014-03-20 Thread Igor Mammedov
Add following parameters: "slots" - total number of hotplug memory slots "maxmem" - maximum possible memory "slots" and "maxmem" should go in pair and "maxmem" should be greater than "mem" for memory hotplug to be enabled. Signed-off-by: Igor Mammedov --- v3: - store maxmem & slots valus in

[Qemu-devel] [RFC 0/8] bus-less device hotplug

2014-03-20 Thread Igor Mammedov
This series is a excerpt from memory hotplug series, posted for getting an opinion on hotplug implementation for bus-less devices using link<>s as a means to provide connection between hotplugged device and hotplug controller that performs board specific actions that hot-added device ishould not be

Re: [Qemu-devel] n ways block filters

2014-03-20 Thread Kevin Wolf
Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben: > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote : > > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben: > > > On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng wrote: > > > > On Fri, 03/14 16:57, Benoît Canet wrote: > > > >> I disc

Re: [Qemu-devel] [Qemu-ppc] [PATCH v6] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-03-20 Thread Thomas Falcon
On 02/28/2014 03:32 PM, Thomas Falcon wrote: This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-o

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Michael Tokarev
10.03.2014 22:40, BALATON Zoltan wrote: > Ping! > http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix return check for KVM_GET_DIRTY_LOG ioctl

2014-03-20 Thread Michael Tokarev
19.03.2014 21:24, Mario Smarduch wrote: > > Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to > handle internal failures or no support for memory slot dirty bitmap. > Otherwise the ioctl succeeds and continues with migration. > Addresses BUG# 1294227 Thanks, applied to -tr

Re: [Qemu-devel] n ways block filters

2014-03-20 Thread Benoît Canet
The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote : > Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben: > > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote : > > > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben: > > > > On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be done for new machine types only. Paolo

Re: [Qemu-devel] [PATCH v2] sparc32 : Signed integer division overflow

2014-03-20 Thread Richard Henderson
On 03/19/2014 03:29 PM, Olivier Danet wrote: > The signed integer division -0x8000___ / -1 must be handled > separately to avoid an overflow on the QEMU host. > > Signed-off-by: Olivier Danet > --- > target-sparc/helper.c | 13 - > 1 file changed, 8 insertions(+), 5 delet

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/2] Trivial documentation updates for sun4m/PowerPC

2014-03-20 Thread Michael Tokarev
18.03.2014 01:46, Mark Cave-Ayland wrote: > Hi all, > > Here are a couple of minor documentation updates - the first is for sun4m and > is primarily concerned with documenting the new CG3 framebuffer whilst > touching > up a couple of minor errors. The second updates the documentation with respe

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] CODING_STYLE: Section about mixed declarations

2014-03-20 Thread Michael Tokarev
17.03.2014 22:26, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. Thanks, applied to -trivial. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread BALATON Zoltan
On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be done for new machine types only. Why? I tried

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 00/12] Avoid shifting left into sign bit

2014-03-20 Thread Michael Tokarev
17.03.2014 20:00, Peter Maydell wrote: > This is a set of patches which silence clang -fsanitize=undefined > warnings about shifting left into the sign bit of a signed value. > Typically this is the result of "1 << 31" and similar constructs; > the fix is to add a "U" suffix to the 1 so that we do

Re: [Qemu-devel] n ways block filters

2014-03-20 Thread Benoît Canet
The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote : > Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben: > > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote : > > > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben: > > > > On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

2014-03-20 Thread Michael Tokarev
16.03.2014 00:26, Igor Mammedov wrote: > On Thu, 06 Mar 2014 20:32:39 +0100 > Andreas Färber wrote: > >> mjt, > [...] >> Since I believe you have a track record of reviewing and queuing such >> QemuOpts conversions, can you review and take this for 2.0 please? > ping I'm really sorry for this.

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 16:01, Igor Mammedov ha scritto: +/* + * Returns path to link<> that should be set/unset on dev hotplug. + * Used for link based bussless devices hotplug. + */ +char* (*hotplug_path)(DeviceState *dev); + What about just looking up on the QOM tree until you find

Re: [Qemu-devel] [PATCH v2] sparc32 : Signed integer division overflow

2014-03-20 Thread Richard Henderson
On 03/19/2014 03:29 PM, Olivier Danet wrote: > +if ((int32_t) x0 != x0) { > +x0 = x0 < 0 ? 0x8000 : 0x7fff; > +overflow = 1; > +} Actually, there's an existing bug here that we might as well fix. ## ... the 32-bit result is sign-extended to 64 bit

Re: [Qemu-devel] [RFC 4/8] qdev: link based hotplug

2014-03-20 Thread Igor Mammedov
On Thu, 20 Mar 2014 17:12:17 +0100 Paolo Bonzini wrote: > Il 20/03/2014 16:01, Igor Mammedov ha scritto: > > +/* > > + * Returns path to link<> that should be set/unset on dev hotplug. > > + * Used for link based bussless devices hotplug. > > + */ > > +char* (*hotplug_path)(De

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4 0/2] convert -m to QemuOpts

2014-03-20 Thread Michael Tokarev
06.03.2014 13:39, Igor Mammedov wrote: > Igor Mammedov (1): > vl: convert -m to QemuOpts This patch (2/2) was mime-damaged, I had to edit it manually in order for it to apply. Please take a look at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next to verify it's okay

Re: [Qemu-devel] Want to discuss about Outreach Program for Women

2014-03-20 Thread Stefan Hajnoczi
On Thu, Mar 20, 2014 at 9:33 AM, Stefan Hajnoczi wrote: > On Wed, Mar 19, 2014 at 08:34:08PM +0530, preeti soni wrote: >> I want to discuss about project in which I am interested. Can you please >> give me How I can do this. As early as possible. > > The application deadline was 19:00 UTC on 19th

[Qemu-devel] Outreach Program for Women application deadline extended

2014-03-20 Thread Stefan Hajnoczi
Good news! The deadline for Outreach Program for Women applications to work on QEMU, KVM, or libvirt for 12 weeks this summer has been extended to March 31st 19:00 UTC: https://wiki.gnome.org/OutreachProgramForWomen/2014/MayAugust#Participating_Organizations Outreach Program for Women was started

Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible

2014-03-20 Thread Paolo Bonzini
Il 20/03/2014 17:01, BALATON Zoltan ha scritto: On Thu, 20 Mar 2014, Paolo Bonzini wrote: Il 20/03/2014 16:42, Michael Tokarev ha scritto: 10.03.2014 22:40, BALATON Zoltan wrote: Ping! http://patchwork.ozlabs.org/patch/324674/ Thanks, applied to -trivial. No, please don't; this needs to be

Re: [Qemu-devel] [PATCH 4/5] sclp-s390: Define new SCLP codes and structures

2014-03-20 Thread Matthew Rosato
On 03/20/2014 05:56 AM, Christian Borntraeger wrote: > On 16/12/13 21:51, Matthew Rosato wrote: >> Define new SCLP codes and structures that will be needed for s390 memory >> hotplug. >> >> Signed-off-by: Matthew Rosato >> --- >> hw/s390x/sclp.c |2 +- >> include/hw/s390x/sclp.h | 4

  1   2   >