Re: [Qemu-devel] Missing dependency checks in qemu build

2014-03-22 Thread Matthew Fernandez
Hi Stefan, Sorry, I should have given the specifics. I was building qemu from source in order to apply some patches beforehand. The build environment was a more or less clean install of the latest 32-bit Xubuntu. If configure currently checks for libtool, it didn't catch that we didn't have it in

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Alexey Kardashevskiy
On 03/23/2014 08:04 AM, Andreas Färber wrote: > Am 22.03.2014 21:54, schrieb Peter Maydell: >> On 22 March 2014 20:18, Andreas Färber wrote: >>> Because AFAIU >>> migration is possible without VMSD, just not with VMSD that sets >>> .unmigratable = 1. >> >> Well, the migration won't fail with an er

[Qemu-devel] [Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2014-03-22 Thread alvarez
Wow, I didn't know sb16 is not mantained anymore, in fact I tough it was one of the main "features"! I will try to do that when I have time. Maybe with a diff on both source codes will put some light on. Thank you! -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename

2014-03-22 Thread Cole Robinson
On 03/22/2014 04:06 PM, Andreas Färber wrote: > Am 12.03.2014 00:15, schrieb Cole Robinson: >> Cc: Luiz Capitulino >> Cc: Markus Armbruster >> Signed-off-by: Cole Robinson > > Given that it even had its own stub file, the commit message should > please explain why it is no longer needed and thu

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-22 Thread Cole Robinson
On 03/22/2014 02:27 PM, Andreas Färber wrote: > Am 12.03.2014 08:22, schrieb Jan Kiszka: >> On 2014-03-12 00:15, Cole Robinson wrote: >>> These errors don't seem user initiated, so forcibly printing to the >>> monitor doesn't seem right. Just print to stderr. >>> >>> Drop lprint since it's now unus

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Peter Maydell
On 22 March 2014 21:04, Andreas Färber wrote: > Am 22.03.2014 21:54, schrieb Peter Maydell: >> On 22 March 2014 20:18, Andreas Färber wrote: >>> Because AFAIU >>> migration is possible without VMSD, just not with VMSD that sets >>> .unmigratable = 1. >> >> Well, the migration won't fail with an e

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Andreas Färber
Am 22.03.2014 21:54, schrieb Peter Maydell: > On 22 March 2014 20:18, Andreas Färber wrote: >> Because AFAIU >> migration is possible without VMSD, just not with VMSD that sets >> .unmigratable = 1. > > Well, the migration won't fail with an error, but on the destination > end you'll end up with

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Peter Maydell
On 22 March 2014 20:18, Andreas Färber wrote: > Because AFAIU > migration is possible without VMSD, just not with VMSD that sets > .unmigratable = 1. Well, the migration won't fail with an error, but on the destination end you'll end up with a device in its reset state but a guest which may think

Re: [Qemu-devel] [PATCH] target-arm: Load ELF images with the correct machine type for CPU

2014-03-22 Thread Andreas Färber
Am 21.03.2014 19:44, schrieb Peter Maydell: > When trying to load an ELF file specified via -kernel, we need to > pass load_elf() the ELF machine type corresponding to the CPU we're > booting with, not the one corresponding to the softmmu binary > we happen to be running. (The two are different in

Re: [Qemu-devel] [PATCH] usb-ohci: add vmstate descriptor

2014-03-22 Thread Andreas Färber
Am 14.03.2014 06:09, schrieb Alexey Kardashevskiy: > On 03/07/2014 12:57 AM, Mike Day wrote: >> >> Alexey Kardashevskiy writes: >> >>> This adds migration support for OHCI. >>> >>> Signed-off-by: Alexey Kardashevskiy >> >> Reviewed-by: Mike Day > > Thanks! > > What is next? The USB maintainer

Re: [Qemu-devel] [PATCH 2/6] vnc: Remove default_mon usage

2014-03-22 Thread Andreas Färber
Am 12.03.2014 08:35, schrieb Gerd Hoffmann: > On Di, 2014-03-11 at 19:15 -0400, Cole Robinson wrote: >> These errors don't seem user initiated, so forcibly printing to the >> monitor doesn't seem right. Just print to stderr. >> >> Cc: Anthony Liguori >> Cc: Gerd Hoffmann >> Signed-off-by: Cole Ro

Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename

2014-03-22 Thread Andreas Färber
Am 12.03.2014 00:15, schrieb Cole Robinson: > Cc: Luiz Capitulino > Cc: Markus Armbruster > Signed-off-by: Cole Robinson Given that it even had its own stub file, the commit message should please explain why it is no longer needed and thus okay to drop. Regards, Andreas -- SUSE LINUX Product

Re: [Qemu-devel] [PATCH 3/6] error: Privatize error_print_loc

2014-03-22 Thread Andreas Färber
Am 12.03.2014 00:15, schrieb Cole Robinson: > Cc: Luiz Capitulino > Cc: Markus Armbruster > Signed-off-by: Cole Robinson > --- > include/qemu/error-report.h | 1 - > util/qemu-error.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) Looks sensible to me if otherwise unused,

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-22 Thread Andreas Färber
Am 12.03.2014 08:22, schrieb Jan Kiszka: > On 2014-03-12 00:15, Cole Robinson wrote: >> These errors don't seem user initiated, so forcibly printing to the >> monitor doesn't seem right. Just print to stderr. >> >> Drop lprint since it's now unused. >> >> Cc: Jan Kiszka >> Signed-off-by: Cole Robi

Re: [Qemu-devel] [PATCH 13/14] tcg-sparc: Fix 32-bit constant arguments tests

2014-03-22 Thread Richard Henderson
On 03/22/2014 02:48 AM, Stuart Brady wrote: >> +case 'w': >> > +ct->ct |= TCG_CT_CONST_IS32; >> > +break; > It might be neater just to expose ts->type to tcg_target_const_match(), > which the TCG target can just ignore if it wants, but that might not > belong in this series, as

[Qemu-devel] [Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2014-03-22 Thread Cole Robinson
sb16 isn't actively maintained in qemu these days, so it's unlikely this bug fix will be prioritized. that said, if you help narrow down the commit where this regressed, it will increase your chances. Finding the last working qemu version is a start. From there, consider trying a git bisect to lo

Re: [Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-22 Thread Stuart Brady
On Sat, Mar 22, 2014 at 11:25:49PM +1100, Alexey Kardashevskiy wrote: > This adds printing of all SPR registers registered for a CPU. > > This removes "SPR_" prefix from SPR name to reduce the output. > > Cc: Fabien Chouteau > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v2: > * remov

[Qemu-devel] [PATCH v6] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-03-22 Thread Alexey Kardashevskiy
This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day --- Changes: v6: * replaced "return" with "goto out"/"break" for better consistency --- hw/ppc/spapr_hcall.c | 29 +

[Qemu-devel] [PATCH v2] target-ppc: improve "info registers" by printing SPRs

2014-03-22 Thread Alexey Kardashevskiy
This adds printing of all SPR registers registered for a CPU. This removes "SPR_" prefix from SPR name to reduce the output. Cc: Fabien Chouteau Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * removed "switch (env->mmu_model)" * added "\n" if the last line has less than 4 registers ---

Re: [Qemu-devel] [PATCH 13/14] tcg-sparc: Fix 32-bit constant arguments tests

2014-03-22 Thread Stuart Brady
On Mon, Mar 17, 2014 at 11:37:55AM -0700, Richard Henderson wrote: > We need to discard garbage high bits before testing > for 32-bit I and J constraints. > > Signed-off-by: Richard Henderson > --- > tcg/sparc/tcg-target.c | 73 > +- > tcg/sparc/t

Re: [Qemu-devel] [PATCH v2 0/9] error: Misc cleanups and improvements

2014-03-22 Thread Paolo Bonzini
Il 22/03/2014 00:42, Cole Robinson ha scritto: Minor error API cleanups, and one error reporting improvement when connected to qmp (patch #5) v2: Dropped the error_printf_unless_qmp patch Added the last 4 patches, new cleanups Use error_report instead of fprintf in patch 1 and 2 Cc:

Re: [Qemu-devel] [RFC PATCH 05/12] icount: check for icount clock deadline when cpu loop exits.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic Notify events on icount clock when CPU loop exits. Signed-off-by: KONRAD Frederic --- cpus.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cpus.c b/cpus.c index ba096a3..01c48e9 100644 --- a/cpus.c ++

Re: [Qemu-devel] [RFC PATCH 07/12] timer: add cpu_icount_to_ns function.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This adds cpu_icount_to_ns function which is needed for reverse execution. It returns the time for a specific instruction. Signed-off-by: KONRAD Frederic --- cpus.c | 9 +++-- include/qemu/tim

Re: [Qemu-devel] [RFC PATCH 06/12] icount: make icount extra computed on icount clock as well.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This takes icount clock in account for icount extra computation so icount clock's timers will be triggered at the exact time. Signed-off-by: KONRAD Frederic --- cpus.c | 10 ++ 1 file changed, 10 inserti

Re: [Qemu-devel] [RFC PATCH 04/12] icount: introduce icount timer.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: @@ -154,7 +159,20 @@ int64_t cpu_get_icount(void) do { start = seqlock_read_begin(&timers_state.vm_clock_seqlock); -icount = cpu_get_icount_locked(); +icount = cpu_get_icount_locked(true); +} while (seql

Re: [Qemu-devel] [RFC PATCH 01/12] icount: put icount variables into TimerState.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This puts qemu_icount and qemu_icount_bias into TimerState structure to allow them to be migrated. Signed-off-by: KONRAD Frederic --- cpus.c | 29 - 1 file changed, 16 insertions(+),

Re: [Qemu-devel] [RFC PATCH 02/12] migration: migrate icount fields.

2014-03-22 Thread Paolo Bonzini
Il 21/03/2014 20:17, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic This fixes a bug where qemu_icount and qemu_icount_bias are not migrated. Signed-off-by: KONRAD Frederic --- cpus.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/cpu

Re: [Qemu-devel] Missing dependency checks in qemu build

2014-03-22 Thread Stefan Weil
Am 22.03.2014 01:10, schrieb Matthew Fernandez: > Hi all, > > This only came to my attention when building qemu on a colleague's > machine recently, but there are some dependencies for the build that are > not detected during the standard `configure` process. In particular, > missing autoconf was