Re: [Qemu-devel] [PATCH v2] qemu-ga: added windows support for 'guest-network-get-interfaces'

2014-10-08 Thread Kenth Andersson
I will take care of the below items as soon as I get some free time. /Kenth On 01 Oct 2014, at 19:45, Michael Roth wrote: > Quoting Kenth Andersson (2014-09-29 13:22:54) >> Implementation of guest-network-get-interfaces for windows >> >> >> Signed-off-by: Kenth Andersson > > Thanks! I've be

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Zhangjie (HZ)
Thanks for your patient answer! :-) On 2014/9/30 17:33, Michael S. Tsirkin wrote: > On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wrote: >> Hi, >> There exits packets loss when we do packet forwarding in VM, >> especially when we use dpdk to do the forwarding. By enlarging vring >> can a

Re: [Qemu-devel] [PATCH v3] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-08 Thread zhanghailiang
Hi Igor, On 2014/9/26 19:53, Igor Mammedov wrote: On Tue, 23 Sep 2014 16:11:25 +0800 zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Sig

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 03:17:56PM +0800, Zhangjie (HZ) wrote: > Thanks for your patient answer! :-) > > On 2014/9/30 17:33, Michael S. Tsirkin wrote: > > On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wrote: > >> Hi, > >> There exits packets loss when we do packet forwarding in VM, > >>

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: a single descriptor might use all of the virtqueue. In this case we wont to be able to pass the descriptor directly to linux as a single iov, since You could separate maximum request scatter/gather list size from the virtqueue size. They are

Re: [Qemu-devel] [PATCH 1/1] target-i386: prevent users from setting threads>1 for AMD CPUs

2014-10-08 Thread Paolo Bonzini
Il 08/10/2014 02:41, Wei Huang ha scritto: > I am OK with either way. The key question is: should QEMU presents > CPUIDs strictly as specified by the command line or QEMU can tweak a > little bit on behalf of end-users? For instance, if end-users say "-smp > 8,cores=2,threads=2,sockets=2", they mea

Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request

2014-10-08 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > typedef struct Visitor Visitor; > >@@ -80,6 +81,6 @@ typedef struct FWCfgState FWCfgState; > > typedef struct PcGuestInfo PcGuestInfo; > > typedef struct PostcopyPMI PostcopyPMI; > > typedef struct Range Range; > >-typedef struct Adap

Re: [Qemu-devel] [PATCH v2 37/36] qdev: device_del: search for to be unplugged device in 'peripheral' container

2014-10-08 Thread Paolo Bonzini
Il 08/10/2014 05:49, Zhu Guihua ha scritto: > when device_add pc-dimm, only 'memdev' property is necessary, but the > 'id' property is optional. > > So I execute the command as followings: > object_add memory-backend-ram,id=ram0,size=128M > device_add pc-dimm,memdev=ram0 > > Now it is impossible

Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request

2014-10-08 Thread Paolo Bonzini
Il 08/10/2014 09:49, Dr. David Alan Gilbert ha scritto: >> > :(, another redefinition, 'RAMBlock' also defined in >> > 'include/exec/cpu-all.h:314', >> > Am i miss something when compile qemu? > Interesting; I'm not seeing that problem at all (gcc 4.8.3-7) > > What compiler and flags are you usin

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Zhangjie (HZ)
MST, Thanks very much, I get it. On 2014/10/8 15:37, Michael S. Tsirkin wrote: > On Wed, Oct 08, 2014 at 03:17:56PM +0800, Zhangjie (HZ) wrote: >> Thanks for your patient answer! :-) >> >> On 2014/9/30 17:33, Michael S. Tsirkin wrote: >>> On Tue, Sep 30, 2014 at 04:36:00PM +0800, Zhangjie (HZ) wro

Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request

2014-10-08 Thread zhanghailiang
On 2014/10/8 15:49, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: typedef struct Visitor Visitor; @@ -80,6 +81,6 @@ typedef struct FWCfgState FWCfgState; typedef struct PcGuestInfo PcGuestInfo; typedef struct PostcopyPMI PostcopyPMI; typedef struc

Re: [Qemu-devel] [PATCH v4 36/47] Page request: Process incoming page request

2014-10-08 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2014/10/8 15:49, Dr. David Alan Gilbert wrote: > >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > > >>> typedef struct Visitor Visitor; > >>>@@ -80,6 +81,6 @@ typedef struct FWCfgState FWCfgState; > >>> typedef struct PcGues

Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile

2014-10-08 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > On 2014/9/29 17:41, Dr. David Alan Gilbert (git) wrote: > >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size) > >+{ > >+size_t needed_chunks, i; > >+ > >+if (qsb->size < new_size) { > >+struct iovec *new_iov; >

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Zhangjie (HZ)
On 2014/10/8 15:43, Avi Kivity wrote: >> > > You could separate maximum request scatter/gather list size from the > virtqueue size. They are totally unrelated - even now you can have a larger > request by using indirect descriptors. Yes, there is no strong correlation between virtqueue size a

Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile

2014-10-08 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: >> On 2014/9/29 17:41, Dr. David Alan Gilbert (git) wrote: > >> >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size) >> >+{ >> >+size_t needed_chunks, i; >> >+ >> >+if (qsb->size < new_s

Re: [Qemu-devel] [PATCH v4 00/47] Postcopy implementation

2014-10-08 Thread Cristian Klein
On 07 Oct 2014, at 17:12 , Dr. David Alan Gilbert wrote: > * Cristian Klein (cristian.kl...@cs.umu.se) wrote: >> On 04 Oct 2014, at 4:21 , Dr. David Alan Gilbert wrote: >> >>> >>> I've updated our github at: >>> https://github.com/orbitfp7/qemu/tree/wp3-postcopy >>> >>> to have this version.

Re: [Qemu-devel] [PATCH v3] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-08 Thread zhanghailiang
On 2014/10/8 15:28, zhanghailiang wrote: Hi Igor, On 2014/9/26 19:53, Igor Mammedov wrote: On Tue, 23 Sep 2014 16:11:25 +0800 zhanghailiang wrote: When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects t

Re: [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support

2014-10-08 Thread Cornelia Huck
On Tue, 07 Oct 2014 18:24:22 -0700 Andy Lutomirski wrote: > On 10/07/2014 07:39 AM, Cornelia Huck wrote: > > This patchset aims to get us some way to implement virtio-1 compliant > > and transitional devices in qemu. Branch available at > > > > git://github.com/cohuck/qemu virtio-1 > > > > I've

Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile

2014-10-08 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size) > >+{ > >+size_t needed_chunks, i; > >+ > >+if (qsb->size < new_size) { > >+struct iovec *new_iov; > >+size_t size_diff = new_size - qsb->size; > >+

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 04:07:47PM +0800, Zhangjie (HZ) wrote: > MST, Thanks very much, I get it. > > On 2014/10/8 15:37, Michael S. Tsirkin wrote: > > On Wed, Oct 08, 2014 at 03:17:56PM +0800, Zhangjie (HZ) wrote: > >> Thanks for your patient answer! :-) > >> > >> On 2014/9/30 17:33, Michael S. T

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: > > On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: > >a single descriptor might use all of > >the virtqueue. In this case we wont to be able to pass the > >descriptor directly to linux as a single iov, since > > > > You could separate

[Qemu-devel] [PATCH 3/3] block/parallels: fix access to not initialized memory in catalog_bitmap

2014-10-08 Thread Denis V. Lunev
found by valgrind. Command: ./qemu-img convert -f parallels -O qcow2 1.hds 1.img Invalid read of size 4 at 0x17D0EF: parallels_co_read (parallels.c:357) by 0x11FEE4: bdrv_aio_rw_vector (block.c:4640) by 0x11FFBF: bdrv_aio_readv_em (block.c:4652) by 0x11F55F: bdrv_co_readv_em (block.c:4

[Qemu-devel] [PATCH 0/3] parallels: additional iotests and a minor bugfix

2014-10-08 Thread Denis V. Lunev
Pls find here test authentic test material, i.e. parallels images with "WithoutFreeSpace" and "WithouFreSpacExt" signatures created in authentic way + a minor bug fix for access to non-initialized memory found by valgrind. Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Ha

[Qemu-devel] [PATCH 2/3] iotests: add v2 parallels sample image and simple test for it

2014-10-08 Thread Denis V. Lunev
This is simple test image for the following commit made by me. commit d25d59802021a747812472780d80a0e792078f40 Author: Denis V. Lunev Date: Mon Jul 28 20:23:55 2014 +0400 parallels: 2TB+ parallels images support Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC:

[Qemu-devel] [PATCH 1/3] iotests: replace fake parallels image with authentic one

2014-10-08 Thread Denis V. Lunev
The image was generated using http://openvz.org/Ploop utility and properly filled with the same content as original one. Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Kevin Wolf CC: Stefan Hajnoczi --- tests/qemu-iotests/076 | 10 +- tests/qemu-iotests/

Re: [Qemu-devel] [Bug 1378554] [NEW] qemu segfault in virtio_scsi_handle_cmd_req_submit on ARM 32 bit

2014-10-08 Thread Richard W.M. Jones
On Wed, Oct 08, 2014 at 01:18:04AM +0200, Paolo Bonzini wrote: > Does this work: > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > index 203e624..c6d4f2e 100644 > --- a/hw/scsi/virtio-scsi.c > +++ b/hw/scsi/virtio-scsi.c > @@ -545,11 +545,12 @@ bool virtio_scsi_handle_cmd_req_prepar

Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile

2014-10-08 Thread zhanghailiang
On 2014/10/8 17:08, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: +static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size) +{ +size_t needed_chunks, i; + +if (qsb->size < new_size) { +struct iovec *new_iov; +size_t size_diff

[Qemu-devel] [PATCH] virtio-scsi: fix use-after-free of VirtIOSCSIReq

2014-10-08 Thread Paolo Bonzini
scsi_req_continue can complete the request and cause the VirtIOSCSIReq to be freed. Fetch req->sreq just once to avoid the bug. Reported-by: Richard Jones Tested-by: Richard Jones Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 9 + 1 file changed, 5 insertions(+), 4 deletion

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: a single descriptor might use all of the virtqueue. In this case we wont to be able to pass the descriptor directly to linux as a sing

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 12:51:21PM +0300, Avi Kivity wrote: > > On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: > >On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: > >>On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: > >>>a single descriptor might use all of > >>>the virtqueue. In th

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 01:14 PM, Michael S. Tsirkin wrote: On Wed, Oct 08, 2014 at 12:51:21PM +0300, Avi Kivity wrote: On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: On 09/30/2014 12:33 PM, Michael S. Tsirkin wrote: a single descriptor mi

Re: [Qemu-devel] [PATCH v5 0/5] add description field in ObjectProperty and PropertyInfo struct

2014-10-08 Thread Gonglei
On 2014/10/8 6:22, Paolo Bonzini wrote: > Il 07/10/2014 08:33, arei.gong...@huawei.com ha scritto: >> From: Gonglei >> >> v5 -> v4: >> 1. add some improvements by Michael's suggtion, Thanks. (Michael) >> 2. add 'Reviewed-by' tag (Paolo, Michael, Eric) > > Andreas, this series depends on patche

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 01:37:25PM +0300, Avi Kivity wrote: > > On 10/08/2014 01:14 PM, Michael S. Tsirkin wrote: > >On Wed, Oct 08, 2014 at 12:51:21PM +0300, Avi Kivity wrote: > >>On 10/08/2014 12:15 PM, Michael S. Tsirkin wrote: > >>>On Wed, Oct 08, 2014 at 10:43:07AM +0300, Avi Kivity wrote: >

Re: [Qemu-devel] [PATCH 0/3] parallels: additional iotests and a minor bugfix

2014-10-08 Thread Paolo Bonzini
Il 08/10/2014 11:13, Denis V. Lunev ha scritto: > Pls find here test authentic test material, i.e. parallels images > with "WithoutFreeSpace" and "WithouFreSpacExt" signatures created > in authentic way + a minor bug fix for access to non-initialized > memory found by valgrind. > > Signed-off-by:

[Qemu-devel] [PATCH v4 01/21] target-mips: define ISA_MIPS64R6

2014-10-08 Thread Leon Alrae
Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- v2: * move new CPU definition to a separate patch --- target-mips/mips-defs.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/target-mips/mips-defs.h b/target-mips/mips-defs.h index 9dfa51

[Qemu-devel] [PATCH v4 00/21] target-mips: add MIPS64R6 Instruction Set support

2014-10-08 Thread Leon Alrae
Hi, Version 4 of the patch series with addressed more comments. Further review (especially for the remaining 3 patches #13, #14 and #21 without "Reviewed-by") will be very appreciated. The following patchset implements MIPS64 Release 6 Instruction Set. New instructions are added and also there is

[Qemu-devel] [PATCH v4 07/21] target-mips: signal RI Exception on DSP and Loongson instructions

2014-10-08 Thread Leon Alrae
Move DSP and Loongson instruction to *_legacy functions as they have been removed in R6. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- target-mips/translate.c | 195 1 file changed, 98 insertions(+), 97 deletions(-) diff --git a/targ

[Qemu-devel] [PATCH v4 08/21] target-mips: move PREF, CACHE, LLD and SCD instructions

2014-10-08 Thread Leon Alrae
The encoding of PREF, CACHE, LLD and SCD instruction changed in MIPS32R6. Additionally, the hint codes in PREF instruction greater than or equal to 24 generate Reserved Instruction Exception. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- disas/mips.c| 4 target-mip

[Qemu-devel] [PATCH v4 04/21] target-mips: move LL and SC instructions

2014-10-08 Thread Leon Alrae
The encoding of LL and SC instruction has changed in MIPS32 Release 6. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno Reviewed-by: James Hogan --- v4: * fix disas mask for ll and sc * remove unnecessary check_insn_opc_removed line --- disas/mips.c| 9 - target-mips/

[Qemu-devel] [PATCH v4 03/21] target-mips: add SELEQZ and SELNEZ instructions

2014-10-08 Thread Leon Alrae
Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno Reviewed-by: James Hogan --- v4: * remove OPC_SPECIAL35_RESERVED and OPC_SPECIAL37_RESERVED v2: * correct conditions to match instruction name --- disas/mips.c| 8 target-mips/translate.c | 18 -- 2 file

[Qemu-devel] [PATCH v4 09/21] target-mips: redefine Integer Multiply and Divide instructions

2014-10-08 Thread Leon Alrae
Use "R6_" prefix in front of all new Multiply / Divide instructions for easier differentiation between R6 and preR6. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- v2: * use tcg_gen_mul_* for cases where the high part is discarded --- disas/mips.c| 16 +++ target-mips/tr

[Qemu-devel] [PATCH v4 11/21] target-mips: Status.UX/SX/KX enable 32-bit address wrapping

2014-10-08 Thread Leon Alrae
In R6 the special behaviour for data references is also specified for Kernel and Supervisor mode. Therefore MIPS_HFLAG_UX is replaced by generic MIPS_HFLAG_AWRAP indicating enabled 32-bit address wrapping. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- v2: * set hflag indicating 32-bi

[Qemu-devel] [PATCH v4 05/21] target-mips: extract decode_opc_special* from decode_opc

2014-10-08 Thread Leon Alrae
Creating separate decode functions for special, special2 and special3 instructions to ease adding new R6 instructions and removing legacy instructions. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- target-mips/translate.c | 1678 --- 1 fil

[Qemu-devel] [PATCH v4 02/21] target-mips: signal RI Exception on instructions removed in R6

2014-10-08 Thread Leon Alrae
Signal Reserved Instruction Exception on instructions that do not exist in R6. In this commit the following groups of preR6 instructions are marked as deleted: - Floating Point Paired Single - Floating Point Compare - conditional moves / branches on FPU conditions - branch likelies - unaligned load

[Qemu-devel] [PATCH v4 10/21] target-mips: move CLO, DCLO, CLZ, DCLZ, SDBBP and free special2 in R6

2014-10-08 Thread Leon Alrae
Also consider OPC_SPIM instruction as deleted in R6 because it is overlaping with MIPS32R6 SDBBP. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- v2: * check_insn_opc_removed() moved to decode_opc_special2_legacy() --- disas/mips.c| 5 ++ target-mips/translate.c | 121 ++

[Qemu-devel] [PATCH v4 14/21] target-mips: add AUI, LSA and PCREL instruction families

2014-10-08 Thread Leon Alrae
Signed-off-by: Leon Alrae --- v3: * use sextract32 instead of open coding the bit field extraction * replace _i64 with _tl in DAHI, DATI and DAUI * fix misleading LDPC comment --- disas/mips.c| 42 ++- target-mips/translate.c | 197

[Qemu-devel] [PATCH v4 06/21] target-mips: split decode_opc_special* into *_r6 and *_legacy

2014-10-08 Thread Leon Alrae
For better code readability and to avoid 'if' statements for all R6 and preR6 instructions whose opcodes are the same - decode_opc_special* functions are split into functions with _r6 and _legacy suffixes. *_r6 functions will contain instructions which were introduced in R6. *_legacy functions wil

[Qemu-devel] [PATCH v4 18/21] target-mips: do not allow Status.FR=0 mode in 64-bit FPU

2014-10-08 Thread Leon Alrae
Status.FR bit must be ignored on write and read as 1 when an implementation of Release 6 of the Architecture in which a 64-bit floating point unit is implemented. Signed-off-by: Leon Alrae Reviewed-by: Yongbok Kim --- v3: * remove line modifying CP0_Status_rw_bitmask as this is done while defini

[Qemu-devel] [PATCH v4 15/21] softfloat: add functions corresponding to IEEE-2008 min/maxNumMag

2014-10-08 Thread Leon Alrae
Add abs argument to the existing softfloat minmax() function and define new float{32,64}_{min,max}nummag functions. minnummag(x,y) returns x if |x| < |y|, returns y if |y| < |x|, otherwise minnum(x,y) maxnummag(x,y) returns x if |x| > |y|, returns y if

[Qemu-devel] [PATCH v4 21/21] target-mips: define a new generic CPU supporting MIPS64 Release 6 ISA

2014-10-08 Thread Leon Alrae
Signed-off-by: Leon Alrae --- v3: * add comment to make it clear that the current definition of MIPS64R6-generic CPU does not contain support for all MIPS64R6 features yet. --- target-mips/translate_init.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/targe

[Qemu-devel] [PATCH v4 12/21] target-mips: add ALIGN, DALIGN, BITSWAP and DBITSWAP instructions

2014-10-08 Thread Leon Alrae
From: Yongbok Kim Signed-off-by: Yongbok Kim Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- v3: * bitswap: use gen_load_gpr instead of optimizing very unlikely case and making it less readable v2: * have separate bitswap and dbitswap helpers and use common function * use TCG_CALL_

[Qemu-devel] [PATCH v4 20/21] mips_malta: update malta's pseudo-bootloader - replace JR with JALR

2014-10-08 Thread Leon Alrae
JR has been removed in R6 and now this instruction will cause Reserved Instruction Exception. Therefore use JALR with rd=0 which is equivalent to JR. Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- hw/mips/mips_malta.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH v4 19/21] target-mips: remove JR, BLTZAL, BGEZAL and add NAL, BAL instructions

2014-10-08 Thread Leon Alrae
From: Yongbok Kim Signed-off-by: Yongbok Kim Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- disas/mips.c| 2 ++ target-mips/translate.c | 18 -- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/disas/mips.c b/disas/mips.c index 9d13bc0..d

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 01:55 PM, Michael S. Tsirkin wrote: Even more useful is getting rid of the desc array and instead passing descs inline in avail and used. You expect this to improve performance? Quite possibly but this will have to be demonstrated. The top vhost function in small packet workload

[Qemu-devel] [PATCH v4 13/21] target-mips: add compact and CP1 branches

2014-10-08 Thread Leon Alrae
From: Yongbok Kim Introduce MIPS32R6 Compact Branch instructions which do not have delay slot - they have forbidden slot instead. However, current implementation does not support forbidden slot yet. Add also BC1EQZ and BC1NEZ instructions. Signed-off-by: Yongbok Kim Signed-off-by: Leon Alrae

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 01:55 PM, Michael S. Tsirkin wrote: Inline descriptors will amortize the cache miss over 4 descriptors, and will allow the hardware to prefetch, since the descriptors are linear in memory. If descriptors are used in order (as they are with current qemu) then aren't they amortize

Re: [Qemu-devel] [PATCH v1 7/8] throttle: Add throttle group support

2014-10-08 Thread Benoît Canet
On Wed, Oct 08, 2014 at 02:53:38PM +0800, Fam Zheng wrote: > > Does this mean that after this series, all the throttle_states must be > contained inside its own throttle group? If so, we could embed ThrottleGroup > fields in ThrottleState. > > It's weird when a function called throttle_group_comp

[Qemu-devel] [PATCH v4 17/21] target-mips: add new Floating Point Comparison instructions

2014-10-08 Thread Leon Alrae
From: Yongbok Kim Signed-off-by: Yongbok Kim Signed-off-by: Leon Alrae Reviewed-by: Aurelien Jarno --- disas/mips.c| 44 +++ target-mips/helper.h| 27 +++ target-mips/op_helper.c | 111 ++ target-mips/translate.c | 206

Re: [Qemu-devel] [PATCH v11 00/34] modify boot order of guest, and take effect after rebooting

2014-10-08 Thread Gonglei
On 2014/10/7 16:00, Gonglei (Arei) wrote: > From: Gonglei > > Changes since v10: > 1. add handler for virtio-blk-pci/s390/ccw in PATCH 28. > 2. add especial bootidnex setter/getter functions for usb-storage > device in PATCH 29. > 3. add bootindex qom property for nvma and ne2k_isa device

[Qemu-devel] [PATCH v4 16/21] target-mips: add new Floating Point instructions

2014-10-08 Thread Leon Alrae
In terms of encoding MIPS32R6 MIN.fmt, MAX.fmt, MINA.fmt, MAXA.fmt replaced MIPS-3D RECIP1, RECIP2, RSQRT1, RSQRT2 instructions. In R6 all Floating Point instructions are supposed to be IEEE-2008 compliant i.e. FIR.HAS2008 always 1. However, QEMU softfloat for MIPS has not been updated yet. Signe

[Qemu-devel] qemu drive-mirror to rbd storage : no sparse rbd image

2014-10-08 Thread Alexandre DERUMIER
Hi, I'm currently planning to migrate our storage to ceph/rbd through qemu drive-mirror and It seem that drive-mirror with rbd block driver, don't create a sparse image. (all zeros are copied to the target rbd). Also note, that it's working fine with "qemu-img convert" , the rbd volume is spa

[Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error reporting

2014-10-08 Thread minyard
This version makes the error message reporting more sane and adds a error_vreport() to make that easier. It also cleans up the bool handling. This depends on the previos non-blocking socket changes, which should hopefully be in qemu soon.

[Qemu-devel] [PATCH 3/3] qemu-sockets: Add error to non-blocking connect handler

2014-10-08 Thread minyard
From: Corey Minyard An error value here would be quite handy and more consistent with the rest of the code. Corey Minyard --- include/qemu/sockets.h | 2 +- migration-tcp.c| 4 ++-- migration-unix.c | 4 ++-- qemu-char.c| 6 +++--- util/qemu-sockets.c| 19

[Qemu-devel] [PATCH 1/3] qemu-error: Add error_vreport()

2014-10-08 Thread minyard
From: Corey Minyard Needed to nicely print socket error reports. Signed-off-by: Corey Minyard --- include/qemu/error-report.h | 1 + util/qemu-error.c | 23 ++- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/include/qemu/error-report.h b/include/

[Qemu-devel] [PATCH 2/3] qemu-char: Fix reconnect socket error reporting

2014-10-08 Thread minyard
From: Corey Minyard If reconnect was set, errors wouldn't always be reported. Fix that and also only report a connect error once until a connection has been made. The primary purpose of this is to tell the user that a connection failed so they can know they need to figure out what went wrong. S

Re: [Qemu-devel] [PATCH v3] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-08 Thread Igor Mammedov
On Wed, 8 Oct 2014 16:36:25 +0800 zhanghailiang wrote: > On 2014/10/8 15:28, zhanghailiang wrote: > > Hi Igor, > > > > On 2014/9/26 19:53, Igor Mammedov wrote: > >> On Tue, 23 Sep 2014 16:11:25 +0800 > >> zhanghailiang wrote: > >> > >>> When do memory hotplug, if there is numa node, we should ad

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Michael S. Tsirkin
On Wed, Oct 08, 2014 at 01:59:13PM +0300, Avi Kivity wrote: > > On 10/08/2014 01:55 PM, Michael S. Tsirkin wrote: > Even more useful is getting rid of the desc array and instead passing > descs > inline in avail and used. > >>>You expect this to improve performance? > >>>Quite possibl

Re: [Qemu-devel] [PATCH V4 5/8] pc: Update rtc_cmos in pc_cpu_plug

2014-10-08 Thread Igor Mammedov
On Wed, 8 Oct 2014 09:12:11 +0800 Gu Zheng wrote: > Hi Igor, > > On 10/07/2014 09:01 PM, Igor Mammedov wrote: > > > On Mon, 29 Sep 2014 18:52:34 +0800 > > Gu Zheng wrote: > > > >> Update rtc_cmos in pc_cpu_plug directly instead of the notifier. > >> > >> v4: > >> -Make link property in PCMac

Re: [Qemu-devel] Memory hotplug and ancient kernels

2014-10-08 Thread Igor Mammedov
On Thu, 2 Oct 2014 18:38:33 +0400 Andrey Korolyov wrote: > Hi, > > with kernel with an obsolete version (< 3.8) DIMM configuration is not > working as defined in a boot-up values, though it is possible to add > dimm during runtime and it will be recognized just well. ACPI tables > and the of DMI

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 03:22 PM, Michael S. Tsirkin wrote: On Wed, Oct 08, 2014 at 01:59:13PM +0300, Avi Kivity wrote: On 10/08/2014 01:55 PM, Michael S. Tsirkin wrote: Even more useful is getting rid of the desc array and instead passing descs inline in avail and used. You expect this to improve perf

Re: [Qemu-devel] [PATCH V4 8/8] acpi/cpu-hotplug: introduce help function to keep bit setting in one place

2014-10-08 Thread Igor Mammedov
On Mon, 29 Sep 2014 18:52:37 +0800 Gu Zheng wrote: > Introduce help function acpi_set_local_sts() to simplify acpi_cpu_plug_cb s/help/helper/ > and acpi_cpu_hotplug_init, so that we can keep bit setting in one place. > > Signed-off-by: Gu Zheng > --- > hw/acpi/cpu_hotplug.c | 23 +++

Re: [Qemu-devel] [QA-virtio]:Why vring size is limited to 1024?

2014-10-08 Thread Avi Kivity
On 10/08/2014 03:28 PM, Avi Kivity wrote: My old presentation from 2012 or so suggested something like this. We don't need a 64 bit cookie I think - a small 16 bit one should be enough. A 16 bit cookie means you need an extra table to hold the real request pointers. With a 64-bit cookie y

[Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-08 Thread Xiaodong Gong
Now qemu only supports vhd type VHD_FIXED and VHD_DYNAMIC, so qemu can't read snapshot volume of vhd, and can't support other storage features of vhd file. This patch add read parent information in function "vpc_open", read bitmap in "vpc_read", and change bitmap in "vpc_write". Signed-off-by: Xi

Re: [Qemu-devel] [PATCH v5] Support vhd type VHD_DIFFERENCING

2014-10-08 Thread Xiaodong Gong
A little bit late for the 7 days of Nation's day, Ding xiao will review my patch. It looks like qcow2 is too popular. :) On Thu, Oct 2, 2014 at 11:36 PM, Stefan Hajnoczi wrote: > On Fri, Sep 26, 2014 at 09:43:18PM +0800, Xiaodong Gong wrote: > > Now qemu only supports vhd type VHD_FIXED and VHD_

Re: [Qemu-devel] [PATCH v2 0/3] Clean up non-blocking error reporting

2014-10-08 Thread Paolo Bonzini
Il 08/10/2014 14:11, miny...@acm.org ha scritto: > This version makes the error message reporting more sane and > adds a error_vreport() to make that easier. > > It also cleans up the bool handling. > > This depends on the previos non-blocking socket changes, which > should hopefully be in qemu s

[Qemu-devel] [Bug 498035] Re: qemu hangs on shutdown or reboot (XP guest)

2014-10-08 Thread jclariana
Hi, I have the same problem, or at least seems related. I just opened an issue on https://sourceforge.net/p/kvm/bugs/555, if needed I can post here all the details too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [RFC PATCH v2 13/23] COLO ctl: implement colo save

2014-10-08 Thread Shunsuke Kurumatani
Hi, I tried and executed this exciting patches named colo. However this patch causes abnormal termination in my environment. Although I think it's a known issue, the details and a presumed origin is described below: On 2014/09/23 18:23, Yang Hongyang wrote: > implement colo save > > Signed-off-

[Qemu-devel] [PATCH] Let user specify random seed for linux-user

2014-10-08 Thread Magnus Reftel
linux-user uses the rand function for generating the value of the AT_RANDOM elf aux vector entry, and explicitly seeds the random number generator with the current time. This makes it impossible to reproduce runs that use the AT_RANDOM bytes. This patch adds a command line option and a matching en

[Qemu-devel] [PATCH] linux-user: Let user specify random seed

2014-10-08 Thread Magnus Reftel
This patch introduces the -seed command line option and the QEMU_RAND_SEED environment variable for setting the random seed, which is used for the AT_RANDOM ELF aux entry. Signed-off-by: Magnus Reftel --- linux-user/elfload.c | 1 - linux-user/main.c| 21 + 2 files chang

Re: [Qemu-devel] [PATCH 2/2] xenfb: Add comment documentation

2014-10-08 Thread Stefano Stabellini
On Mon, 22 Sep 2014, Owen smith wrote: > Add documentation for page-ref, page-gref and event-channel. > > Signed-off-by: Owen smith thanks for the patch > xen/include/public/io/fbif.h | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/xen/include/public/io/fb

Re: [Qemu-devel] [PATCH 1/2] xenfb: Add comment documentation

2014-10-08 Thread Stefano Stabellini
On Mon, 22 Sep 2014, Owen smith wrote: > Add documentation for feature-abs-pointer, feature-no-abs-rescale, > feature-no-console, page-ref, page-gref and event-channel > > Signed-off-by: Owen smith I would suggest resending this patch series removing the new options you are introducing with 1410

Re: [Qemu-devel] [PULL 12/51] target-arm: A64: Implement DC ZVA

2014-10-08 Thread Christopher Covington
Hi Peter, On 04/17/2014 06:33 AM, Peter Maydell wrote: > Implement the DC ZVA instruction, which clears a block of memory. > The fast path obtains a pointer to the underlying RAM via the TCG TLB > data structure so we can do a direct memset(), with fallback to a > simple byte-store loop in the slo

qemu-devel@nongnu.org

2014-10-08 Thread Fabien Chouteau
From: Jiri Gaisler AMBA plug&play is used by kernels to probe available devices (Timers, UART, etc...). This is a static declaration of devices implemented in QEMU. In the future, a more advanced version could compute those information directly from the device tree. Signed-off-by: Fabien Choutea

Re: [Qemu-devel] [PATCH 1/3] qemu-error: Add error_vreport()

2014-10-08 Thread Eric Blake
On 10/08/2014 06:11 AM, miny...@acm.org wrote: > From: Corey Minyard > > Needed to nicely print socket error reports. > > Signed-off-by: Corey Minyard > --- > include/qemu/error-report.h | 1 + > util/qemu-error.c | 23 ++- > 2 files changed, 19 insertions(+), 5

Re: [Qemu-devel] [PATCH] linux-user: Let user specify random seed

2014-10-08 Thread Eric Blake
On 10/08/2014 06:13 AM, Magnus Reftel wrote: > This patch introduces the -seed command line option and the > QEMU_RAND_SEED environment variable for setting the random seed, which > is used for the AT_RANDOM ELF aux entry. > > Signed-off-by: Magnus Reftel > --- > linux-user/elfload.c | 1 - > l

Re: [Qemu-devel] [PATCH v7 1/2] dump: Propagate errors into qmp_dump_guest_memory()

2014-10-08 Thread Eric Blake
On 09/30/2014 03:20 AM, zhanghailiang wrote: > The code calls dump_error() on error, and even passes it a suitable > message. However, the message is thrown away, and its callers pass > up only success/failure. All qmp_dump_guest_memory() can do is set > a generic error. > > Propagate the errors

Re: [Qemu-devel] [PATCH v7 2/2] dump: Turn some functions to void to make code cleaner

2014-10-08 Thread Eric Blake
On 09/30/2014 03:20 AM, zhanghailiang wrote: > Functions shouldn't return an error code and an Error object at the same time. > Turn all these functions that returning Error object to void. > We also judge if a function success or fail by reference to the local_err. > > Signed-off-by: zhanghailian

Re: [Qemu-devel] [RFC PATCH v2 03/23] COLO: introduce an api colo_supported() to indicate COLO support

2014-10-08 Thread Eric Blake
On 09/23/2014 03:23 AM, Yang Hongyang wrote: > introduce an api colo_supported() to indicate COLO support, returns > true if colo supported (configured with --enable-colo). > > Signed-off-by: Yang Hongyang > --- > +++ b/include/migration/migration-colo.h > @@ -0,0 +1,18 @@ > +/* > + * COarse-gra

Re: [Qemu-devel] [PATCH v1 1/8] throttle: Extract timers from ThrottleState into a separate ThrottleTimers structure

2014-10-08 Thread Eric Blake
On 10/07/2014 07:24 AM, Benoît Canet wrote: > Group throttling will share ThrottleState between multiple bs. > As a consequence the ThrottleState will be accessed by multiple aio context. > > Timers are tied to their aio context so they must go out of the ThrottleState > structure. > > This comm

qemu-devel@nongnu.org

2014-10-08 Thread Andreas Färber
Hi, Am 08.10.2014 um 16:19 schrieb Fabien Chouteau: > From: Jiri Gaisler > > AMBA plug&play is used by kernels to probe available devices (Timers, > UART, etc...). This is a static declaration of devices implemented in > QEMU. In the future, a more advanced version could compute those > informat

[Qemu-devel] [Bug 1336192] Re: delvm does not delete snapshots on every disks

2014-10-08 Thread Étienne Buira
fixed by af957387547b05ed6dc4d84c10cca42700a7aeda ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336192 Title: delvm does not delete snapsho

[Qemu-devel] [PATCH v1.5] nbd: Fix filename generation

2014-10-08 Thread Max Reitz
Export names may be used with nbd+unix, too, fix nbd_refresh_filename() accordingly. Also, for nbd+tcp, the documented path schema is "nbd://host[:port]/export", so use it. Furthermore, as can be seen from that schema, the port is optional. That makes six single cases for how the filename can be f

[Qemu-devel] [PATCH] target-arm: add second UART to virt

2014-10-08 Thread Greg Bellows
This minor patch adds a second uart to the QEMU virt machine type. This patch is needed for separating the console output between normal and secure world environments. Greg Bellows (1): target-arm: add second UART to virt hw/arm/virt.c | 24 ++-- 1 file changed, 14 inserti

[Qemu-devel] [PATCH] target-arm: add second UART to virt

2014-10-08 Thread Greg Bellows
Added UART1 to virt to enable separate UARTs for secure/nonsecure worlds. Signed-off-by: Greg Bellows --- hw/arm/virt.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 8c6b171..0740cdc 100644 --- a/hw/arm/virt.c +

Re: [Qemu-devel] [PATCH v5 00/11] qcow2: Fix image repairing

2014-10-08 Thread Max Reitz
On 29.08.2014 23:40, Max Reitz wrote: As can be seen in the final patch of this series, there are certain cases where the current repair implementation of qcow2 actually damages the image further because it allocates new clusters for the refcount structure which overlap with existing but accordin

Re: [Qemu-devel] [PATCH v12 00/14] qemu-img: Implement commit like QMP

2014-10-08 Thread Max Reitz
On 26.08.2014 23:36, Max Reitz wrote: qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As

Re: [Qemu-devel] [PATCH 0/3] block: Fix is_allocated() for truncated images

2014-10-08 Thread Max Reitz
On 16.08.2014 20:54, Max Reitz wrote: Patch 2: The bdrv_is_allocated() functions may return a number of zero sectors e.g. if a sector beyond the image end has been queried. Respect this case in qemu-io's map implementation so it doesn't run into an infinite loop (https://bugs.launchpad.net/qemu/+

Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function

2014-10-08 Thread Greg Bellows
Unfortunately, the arm_is_secure*() functions cannot be moved either as they are used within cpu.h. Greg On 6 October 2014 16:07, Peter Maydell wrote: > On 6 October 2014 21:47, Greg Bellows wrote: > > > > > > On 6 October 2014 15:07, Peter Maydell wrote: > >> You should use is_a64() rather t

Re: [Qemu-devel] [PATCH v2 0/2] raw-posix: Fix raw_co_get_block_status()

2014-10-08 Thread Max Reitz
On 22.09.2014 17:36, Max Reitz wrote: raw_co_get_block_status() should return 0 and set *pnum to 0 after the EOF; currently it does this merely by accident, so implement it directly. Also, nb_sectors should be clamped against the image end. While doing that, centralize the generation of raw_co_g

Re: [Qemu-devel] [PATCH v3 0/7] block/qcow2: Improve zero cluster expansion

2014-10-08 Thread Max Reitz
On 15.08.2014 17:47, Max Reitz wrote: The main purpose of this series is to add a progress report to qemu-img amend. This is achieved by adding a callback function to bdrv_amend_options() - the reasons for this choice are explained in patch 1. While adapting qcow2's expand_zero_clusters_in_l1()

  1   2   >