Re: [Qemu-devel] [PULL v4 0/2] pci, pc, virtio fixes and cleanups

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 04:17:41PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 23:32:36 +0900 Peter Maydell peter.mayd...@linaro.org wrote: On 4 March 2015 at 02:07, Michael S. Tsirkin m...@redhat.com wrote: As previously, only sending incremental patches added since v3. This is

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

2015-03-04 Thread Luiz Capitulino
On Wed, 04 Mar 2015 09:16:53 +0100 Paulo Ricardo Paz Vital paulo.vi...@profitbricks.com wrote: On Tue, 2015-03-03 at 11:16 -0500, Luiz Capitulino wrote: On Tue, 03 Mar 2015 16:12:58 +0100 Paulo Ricardo Paz Vital paulo.vi...@profitbricks.com wrote: On Tue, 2015-03-03 at 09:47 -0500,

Re: [Qemu-devel] [PULL 1/1] xhci: generate a Transfer Event for each Transfer TRB with the IOC bit set

2015-03-04 Thread Laszlo Ersek
On 03/04/15 15:10, Peter Maydell wrote: On 4 March 2015 at 18:03, Laszlo Ersek ler...@redhat.com wrote: Hi Peter, sorry about poking you -- I'm aware you've been on vacation, but in http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg00174.html you said you still inteded to pull

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

2015-03-04 Thread Alexander Graf
On 04.03.15 16:07, Frank Blaschka wrote: On Wed, Mar 04, 2015 at 03:49:15PM +0100, Alexander Graf wrote: On 04.03.15 14:44, Frank Blaschka wrote: On Tue, Mar 03, 2015 at 09:38:37PM +0100, Alexander Graf wrote: On 03.03.15 14:25, Frank Blaschka wrote: On Tue, Mar 03, 2015 at 10:33:05AM

Re: [Qemu-devel] [PULL 0/4] vfio: Updates for QEMU 2.3-rc0

2015-03-04 Thread Peter Maydell
On 3 March 2015 at 04:03, Alex Williamson alex.william...@redhat.com wrote: The following changes since commit b8a173b25c887a606681fc35a46702c164d5b2d0: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2015-03-02 14:25:48 +) are available in the git

Re: [Qemu-devel] [PATCH 0/8] machine: query machine properties rather than qemu opts

2015-03-04 Thread Marcel Apfelbaum
On 02/25/2015 01:55 PM, Marcel Apfelbaum wrote: On 02/04/2015 05:43 PM, Marcel Apfelbaum wrote: Commit e79d5a6 (machine: remove qemu_machine_opts global list) removed option descriptions from the -machine QemuOptsList to avoid repeating MachineState's QOM properties. This results in a Qemu

Re: [Qemu-devel] [PATCH v2] Introduce machine specific default memory size

2015-03-04 Thread Igor Mammedov
On Wed, 04 Mar 2015 14:32:44 +0200 Marcel Apfelbaum marcel.apfelb...@gmail.com wrote: On 03/04/2015 02:21 PM, Igor Mammedov wrote: On Wed, 4 Mar 2015 16:48:05 +0530 Nikunj A Dadhania nik...@linux.vnet.ibm.com wrote: QEMU default memory of 128MB is not enough to boot sPAPR guest.

Re: [Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: export virtio_types.h

2015-03-04 Thread Eric Auger
On 03/04/2015 04:37 PM, Michael S. Tsirkin wrote: On Wed, Mar 04, 2015 at 02:16:15PM +, Eric Auger wrote: virtio_ring.h now includes virtio_types.h. update-linux-headers.sh now exports this latter. Signed-off-by: Eric Auger eric.au...@linaro.org This is already included in my tree, but

Re: [Qemu-devel] [PULL v4 0/2] pci, pc, virtio fixes and cleanups

2015-03-04 Thread Igor Mammedov
On Wed, 4 Mar 2015 23:32:36 +0900 Peter Maydell peter.mayd...@linaro.org wrote: On 4 March 2015 at 02:07, Michael S. Tsirkin m...@redhat.com wrote: As previously, only sending incremental patches added since v3. This is an update of the previous pull request. Tree was not rebased so you

Re: [Qemu-devel] [PATCH RFC 1/1] s390x/pci: Extend pci representation by new zpci device

2015-03-04 Thread Frank Blaschka
On Wed, Mar 04, 2015 at 04:25:07PM +0100, Alexander Graf wrote: On 04.03.15 16:07, Frank Blaschka wrote: On Wed, Mar 04, 2015 at 03:49:15PM +0100, Alexander Graf wrote: On 04.03.15 14:44, Frank Blaschka wrote: On Tue, Mar 03, 2015 at 09:38:37PM +0100, Alexander Graf wrote: On

[Qemu-devel] QEMU, libvirt, and KVM are participating in Outreachy May-August 2015

2015-03-04 Thread Stefan Hajnoczi
QEMU, libvirt, and KVM are participating in the Outreachy (formerly known as Outreach Program for Women) May-August 2015 round. Outreachy is a 12-week full-time paid internship for working on open source projects. We are able to participate thanks to sponsors who will be listed on the Outreachy

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 04:14:44PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 14:49:00 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 04, 2015 at 02:12:32PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 13:11:48 +0100 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: export virtio_types.h

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 02:16:15PM +, Eric Auger wrote: virtio_ring.h now includes virtio_types.h. update-linux-headers.sh now exports this latter. Signed-off-by: Eric Auger eric.au...@linaro.org This is already included in my tree, but in a different place. Pull request sent today, pls

Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support

2015-03-04 Thread Stefan Hajnoczi
On Wed, Mar 04, 2015 at 02:53:42PM +0100, Alberto Garcia wrote: On Tue, Mar 03, 2015 at 03:00:06PM -0600, Stefan Hajnoczi wrote: +throttle_group_lock(bs-throttle_state); +bdrv_throttle_group_remove(bs); +throttle_group_unlock(bs-throttle_state); + +

Re: [Qemu-devel] [RFC PATCH 01/14] docs: block replication's description

2015-03-04 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH 1/2] qemu-options.hx: improve -m description

2015-03-04 Thread Paulo Ricardo Paz Vital
On Tue, 2015-03-03 at 09:47 -0500, Luiz Capitulino wrote: Add memory hotplug options to the command-line format. Also, add a complete command-line example and improve description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx | 22 +- 1 file

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

2015-03-04 Thread Paulo Ricardo Paz Vital
On Tue, 2015-03-03 at 09:47 -0500, Luiz Capitulino wrote: This document describes how to use memory hotplug in QEMU. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- docs/memory-hotplug.txt | 76 + 1 file changed, 76 insertions(+)

[Qemu-devel] [PULL 32/47] milkymist.c: fix memory leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/lm32/milkymist.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 256c102..7f62261 100644 ---

Re: [Qemu-devel] [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 4 March 2015 at 23:35, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Doesn't seem worth changing

[Qemu-devel] [PATCH v11 0/4] machvirt dynamic sysbus device instantiation

2015-03-04 Thread Eric Auger
This patch series enables machvirt to dynamically instantiate sysbus devices from command line (using -device option). All those sysbus devices are plugged onto a platform bus. This latter device is instantiated in machvirt and takes care of the binding of children sysbus devices on a machine

Re: [Qemu-devel] Delaying -rc0?

2015-03-04 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: On Wed, Mar 04, 2015 at 12:14:21AM +0900, Peter Maydell wrote: On 4 March 2015 at 00:07, Marcel Apfelbaum mar...@redhat.com wrote: In the mean time this series depends on Igor's ACPI dynamic series that took a lot of time to review and even

[Qemu-devel] [PULL 39/47] disas/arm: Fix warnings caused by missing 'static' attribute

2015-03-04 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warnings from the Sparse static analysis tool: disas/arm.c:1552:15: warning: symbol 'last_type' was not declared. Should it be static? disas/arm.c:1553:5: warning: symbol 'last_mapping_sym' was not declared. Should it be static? disas/arm.c:1554:9: warning:

[Qemu-devel] [PULL 40/47] disas/cris: Fix warning caused by missing 'static' attribute

2015-03-04 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de Warning from the Sparse static analysis tool: disas/cris.c:1218:26: warning: symbol 'cris_cond15s' was not declared. Should it be static? Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Michael Tokarev m...@tls.msk.ru --- disas/cris.c | 2 +- 1

Re: [Qemu-devel] [PATCH] vl: Adjust the place of processing '-mon'

2015-03-04 Thread Markus Armbruster
zhanghailiang zhang.zhanghaili...@huawei.com writes: From: Xiangyou Xie xiexiang...@huawei.com If VM is configured with large size of hugepage, when startup, it will consume lots of time to zero the hugepage memory in the function 'os_mem_prealloc'. Libvirtd will wait 30 seconds for qemu to

[Qemu-devel] [PULL 36/47] gitignore: Ignore new tests

2015-03-04 Thread Michael Tokarev
From: Cole Robinson crobi...@redhat.com Signed-off-by: Cole Robinson crobi...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- tests/.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/.gitignore b/tests/.gitignore index e2e4957..0dcb618 100644 ---

[Qemu-devel] [PULL 25/47] xen: Remove xen_cmos_set_s3_resume()

2015-03-04 Thread Michael Tokarev
From: Thomas Huth th...@linux.vnet.ibm.com The function is not used anymore, and thus can be deleted. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- include/hw/xen/xen.h | 1 -

Re: [Qemu-devel] [PULL 06/47] migration/rdma: clean up qemu_rdma_dest_init a bit

2015-03-04 Thread Michael Tokarev
I'm terrible sorry for this -- I forgot to remove this patch from the trivial-patches queue. Should I re-do the pull request? 04.03.2015 20:06, Michael Tokarev wrote: Do not check for rdma-host being empty twice. This removes a large if block, so code indentation is changed. While at it,

[Qemu-devel] [PULL 03/47] xilinx_ethlite: Clean up after commit 2f991ad

2015-03-04 Thread Michael Tokarev
From: Markus Armbruster arm...@redhat.com The fall through added by the commit is clearly intentional. Mark it so. Hushes up Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by: Michael Tokarev m...@tls.msk.ru

[Qemu-devel] [PULL v2 00/46] Trivial patches for 2015-03-04

2015-03-04 Thread Michael Tokarev
This is a resend of my previous pull request, but without patch 6 migration/rdma: clean up qemu_rdma_dest_init a bit. I won't include all the other patches since they're the same, there's no need to bomb people again. Thanks, /mjt The following changes since commit

[Qemu-devel] [PULL 27/47] qemu-char: add cyrillic characters 'numerosign' to VNC keysyms

2015-03-04 Thread Michael Tokarev
From: Wang Xin wangxinxin.w...@huawei.com This patch adds missing cyrillic character 'numerosign' to the VNC keysym table, it's needed by Russian keyboard. And I get the keysym from 'X11/keysymdef.h', the current keysym table in Qemu was generated from it. Signed-off-by: Wang xin

[Qemu-devel] [PATCH v11 1/4] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-03-04 Thread Eric Auger
This new C module will be used by ARM machine files to generate platform bus node and their dynamic sysbus device tree nodes. Dynamic sysbus device node addition is done in a machine init done notifier. arm_register_platform_bus_fdt_creator does the registration of this latter and is supposed to

Re: [Qemu-devel] [PATCH 7/9] throttle: Add throttle group support

2015-03-04 Thread Alberto Garcia
On Wed, Mar 04, 2015 at 10:04:27AM -0600, Stefan Hajnoczi wrote: This pattern suggests throttle_timer_fired() should acquire the lock internally instead. The idea is that the ThrottleState code itself doesn't know anything about locks or groups. As I understood it Benoît designed

[Qemu-devel] [PATCH v11 2/4] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-03-04 Thread Eric Auger
Device tree nodes for the platform bus and its children dynamic sysbus devices are added in a machine init done notifier. To load the dtb once, after those latter nodes are built and before ROM freeze, the actual arm_load_kernel existing code is moved into a notifier notify function,

Re: [Qemu-devel] [PATCH v2] error: Replace error_report() error_free() with error_report_err()

2015-03-04 Thread Markus Armbruster
zhanghailiang zhang.zhanghaili...@huawei.com writes: This is a continuation of the work started in commit 565f65d27: error: Use error_report_err() where appropriate Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Reviewed-by: Eric Blake ebl...@redhat.com Reviewed-by: Markus

[Qemu-devel] [PULL 05/47] smbios: document cmdline options for smbios type 2-4, 17 structures

2015-03-04 Thread Michael Tokarev
From: Gabriel L. Somlo gso...@gmail.com Signed-off-by: Gabriel Somlo so...@cmu.edu Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qemu-options.hx | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index

Re: [Qemu-devel] Delaying -rc0?

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 05:48:37PM +0100, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: On Wed, Mar 04, 2015 at 12:14:21AM +0900, Peter Maydell wrote: On 4 March 2015 at 00:07, Marcel Apfelbaum mar...@redhat.com wrote: In the mean time this series depends on Igor's

[Qemu-devel] [PATCH v11 3/4] hw/arm/virt: add dynamic sysbus device support

2015-03-04 Thread Eric Auger
Allows sysbus devices to be instantiated from command line by using -device option. Machvirt creates a platform bus at init. The dynamic sysbus devices are attached to this platform bus device. The platform bus device registers a machine init done notifier whose role will be to bind the dynamic

[Qemu-devel] [PATCH v11 4/4] hw/arm/virt: change indentation in a15memmap

2015-03-04 Thread Eric Auger
Re-indent in a15memmap after VIRT_PLATFORM_BUS introduction Signed-off-by: Eric Auger eric.au...@linaro.org --- hw/arm/virt.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index c3f4c54..e22a0fa 100644 ---

[Qemu-devel] [PULL 17/47] vhost-scsi: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/scsi/vhost-scsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 11/47] qmp-commands.hx: Fix several typos

2015-03-04 Thread Michael Tokarev
From: Alberto Garcia be...@igalia.com Signed-off-by: Alberto Garcia be...@igalia.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qmp-commands.hx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qmp-commands.hx

[Qemu-devel] [PULL 37/47] e500: fix memory leak

2015-03-04 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Stefan Weil s...@weilnetz.de --- hw/ppc/e500.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 7e17d18..a8237a3 100644 --- a/hw/ppc/e500.c +++

Re: [Qemu-devel] [PATCH 1/2] fix GCC 5.0.0 logical-not-parentheses warnings

2015-03-04 Thread Radim Krčmář
2015-03-04 17:36+0300, Michael Tokarev: 20.02.2015 19:06, Radim Krčmář wrote: diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c -if (!!n-vhost_started == -(virtio_net_started(n, status) !nc-peer-link_down)) { +if ((virtio_net_started(n, status) !nc-peer-link_down)

[Qemu-devel] [PULL 12/47] block: remove superfluous '\n' around error_report/error_setg

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block/archipelago.c | 6 +++--- hw/block/nand.c | 2 +- qemu-img.c | 2 +- 3 files changed, 5

[Qemu-devel] [PULL 15/47] numa: remove superfluous '\n' around error_setg

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- numa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/numa.c b/numa.c index

[Qemu-devel] [PULL 10/47] qerror.h: Swap definitions that were not in alphabetical order

2015-03-04 Thread Michael Tokarev
From: Alberto Garcia be...@igalia.com Signed-off-by: Alberto Garcia be...@igalia.com Reviewed-by: John Snow js...@redhat.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- include/qapi/qmp/qerror.h | 6 +++--- 1 file changed, 3 insertions(+),

[Qemu-devel] [PATCH] 9pfs: remove useless return

2015-03-04 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/9pfs/virtio-9p-local.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index a183eee..d05c917 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -328,15 +328,14 @@

[Qemu-devel] [PULL 06/47] migration/rdma: clean up qemu_rdma_dest_init a bit

2015-03-04 Thread Michael Tokarev
Do not check for rdma-host being empty twice. This removes a large if block, so code indentation is changed. While at it, remove an ugly goto from the loop, replacing it with a cleaner if logic. And finally, there's no need to initialize `ret' variable since is always has a value.

[Qemu-devel] [PULL 19/47] xtensa: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/xtensa/sim.c| 2 +- hw/xtensa/xtfpga.c | 10 +- 2 files changed, 6 insertions(+), 6

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-04 Thread Igor Mammedov
On Wed, 4 Mar 2015 16:31:39 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 04, 2015 at 04:14:44PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 14:49:00 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 04, 2015 at 02:12:32PM +0100, Igor Mammedov wrote: On

[Qemu-devel] [PULL 47/47] 9pfs: remove useless return

2015-03-04 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/9pfs/virtio-9p-local.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index a183eee..d05c917 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -332,7 +332,6 @@

[Qemu-devel] [PULL 46/47] gdbstub: avoid possible NULL pointer dereference

2015-03-04 Thread Michael Tokarev
From: Paolo Bonzini pbonz...@redhat.com Coverity reports that s-chr is checked after put_packet dereferences it. Move the check earlier, consistent with the code used for user-mode emulation. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru ---

[Qemu-devel] [PULL 04/47] memsave: Improve and disambiguate error message

2015-03-04 Thread Michael Tokarev
From: Borislav Petkov b...@suse.de When requesting a size which cannot be read, the error message shows a different address which is misleading to the user and it looks like something's wrong with the address parsing. This is because the input @addr variable is incremented in the memory dumping

[Qemu-devel] [PULL 00/47] Trivial patches for 2015-03-04

2015-03-04 Thread Michael Tokarev
This is yet another trivial-patches pull request. There are many patches in there accumulated in over 3 weeks. Trivial stuff really. Please consider pulling. Thanks, /mjt The following changes since commit 576a94d8bcaa1bb07a81d9ffd2cf76095a66ad9a: vl: take iothread lock very early

[Qemu-devel] [PULL 02/47] xen-pt: fix Out-of-bounds read

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com The array length of s-real_device.io_regions[] is PCI_NUM_REGIONS - 1. Signed-off-by: Gonglei arei.gong...@huawei.com Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Michael Tokarev m...@tls.msk.ru ---

Re: [Qemu-devel] [PULL 00/69] Block patches

2015-03-04 Thread Stefan Hajnoczi
On Tue, Mar 03, 2015 at 11:52:42PM +0900, Peter Maydell wrote: On 28 February 2015 at 03:57, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Feb 27, 2015 at 6:17 PM, Stefan Hajnoczi stefa...@redhat.com wrote: Ekaterina Tumanova (5): block: add bdrv functions for geometry and

[Qemu-devel] [PULL 13/47] a9gtimer: remove superfluous '\n' around error_setg

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/timer/a9gtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/a9gtimer.c

[Qemu-devel] [PULL 5/5] docs: add memory-hotplug.txt

2015-03-04 Thread Luiz Capitulino
This document describes how to use memory hotplug in QEMU. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paulo Vital paulo.vi...@profitbricks.com --- docs/memory-hotplug.txt | 76 +

[Qemu-devel] [PULL 08/47] cutils: refine strtol error handling in parse_debug_env

2015-03-04 Thread Michael Tokarev
From: Paolo Bonzini pbonz...@redhat.com Avoid truncation of a 64-bit long to a 32-bit int, and check for errno (especially ERANGE). Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- util/cutils.c | 5

[Qemu-devel] [PULL 16/47] Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- exec.c | 2 +- hw/ide/pci.c | 2 +- hw/microblaze/boot.c | 2 +- migration/rdma.c | 2

[Qemu-devel] [PULL 21/47] arm/digic_boards: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/arm/digic_boards.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PULL 30/47] sparc/leon3.c: fix memory leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/sparc/leon3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index 751392e..e41ec0b 100644 --- a/hw/sparc/leon3.c

[Qemu-devel] [PULL 2/5] virtio-balloon: Fix balloon not working correctly when hotplug memory

2015-03-04 Thread Luiz Capitulino
From: zhanghailiang zhang.zhanghaili...@huawei.com When do memory balloon, it takes the 'ram_size' as the VM's current ram size, But 'ram_size' is the startup configured ram size, it does not take into account the hotplugged memory. As a result, the balloon result will be confused. Steps to

[Qemu-devel] [PULL 43/47] migration: Fix coding style (whitespace issues)

2015-03-04 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de * Remove trailing whitespace (fixes 9 errors from checkpatch.pl). One comment line was longer than 80 characters, so wrap it and fix a typo, too. * Replace tabs by blanks (fixes 1 error). Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Dr. David

[Qemu-devel] [PULL 28/47] qemu-char: add cyrillic key 'numerosign' to Russian keymap

2015-03-04 Thread Michael Tokarev
From: Wang Xin wangxinxin.w...@huawei.com numero sign is the number sign key of Russian keyboard layout, we get this key with 'shift + 3'. It's missing in current Russian keymap file, this patch fixes it. As number sign does not exsit in Russian keyboard layout[1][2], this patch also removes the

[Qemu-devel] [PULL 0/5] QMP queue

2015-03-04 Thread Luiz Capitulino
Hi, This pull request contains two series. A balloon series and memory hotplug doc series. The balloon series is not totally QMP related, but it has implications to libvirt when using memory hotplug. So, I'm picking it up. The second series is a memory hotplug doc improvement. This is not QMP

[Qemu-devel] [PULL 09/47] Add copyright and author after file split

2015-03-04 Thread Michael Tokarev
From: Stefan Berger stef...@linux.vnet.ibm.com Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- migration/qemu-file-buf.c | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PULL 4/5] qemu-options.hx: improve -m description

2015-03-04 Thread Luiz Capitulino
Add memory hotplug options to the command-line format. Also, add a complete command-line example and improve description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paulo Vital paulo.vi...@profitbricks.com --- qemu-options.hx

[Qemu-devel] [PULL 26/47] qapi-schema: Fix SpiceChannel docs

2015-03-04 Thread Michael Tokarev
From: Cole Robinson crobi...@redhat.com The value is called channel-type, not connection-type Signed-off-by: Cole Robinson crobi...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qapi-schema.json | 6 +++--- 1 file changed, 3

[Qemu-devel] [PULL 3/5] virtio-balloon: Add some trace events

2015-03-04 Thread Luiz Capitulino
From: zhanghailiang zhang.zhanghaili...@huawei.com Add some trace events for easier debugging Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/virtio/virtio-balloon.c | 6 ++ trace-events | 4 2 files

Re: [Qemu-devel] [PATCH V14 1/3] docs: vm generation id device's description

2015-03-04 Thread Eric Blake
On 03/03/2015 09:18 AM, Igor Mammedov wrote: From: Gal Hammer gham...@redhat.com Signed-off-by: Gal Hammer gham...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: - ammend doc since no more MMIO occupied by vmgenid s/ammend/amend/ (but this isn't part of the commit

[Qemu-devel] [PULL 20/47] tpm: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/tpm/tpm_passthrough.c | 12 ++-- tpm.c| 2 +- 2 files changed, 7 insertions(+),

[Qemu-devel] 9pfs-proxy: -retval vs errno vs -1

2015-03-04 Thread Michael Tokarev
Another interesting tidbit is in hw/9pfs/virtio-9p-proxy.c. All filesystem methods use common v9fs_request() function, which returns -errno. So far so good. Now, *all* places which call this function, does this: retval = v9fs_request(...); if (retval 0) { errno = -retval;

[Qemu-devel] Fix for bug in implementation of SYSRET instruction for x86-64

2015-03-04 Thread Bill Paul
(I tried sending this once earlier but it seems to have disappeared into the void. Apologies if it ends up showing up twice.) Hi guys. I seem to have found a bug in the helper_systet() function in target-i386/seg_helper.c. I downloaded the Intel architecture manual from here:

[Qemu-devel] [PATCH] Fix bug in implementation of SYSRET instruction for x86-64

2015-03-04 Thread Bill Paul
Hi guys. I seem to have found a bug in the helper_systet() function in target-i386/seg_helper.c. I downloaded the Intel architecture manual from here: http://www.intel.com/content/www/us/en/processors/architectures-software- developer-manuals.html And it describes the behavior of SYSRET with

Re: [Qemu-devel] [PATCH v2 01/37] blockdev: Allow creation of BDS trees without BB

2015-03-04 Thread Max Reitz
On 2015-03-04 at 08:39, Kevin Wolf wrote: Am 09.02.2015 um 18:11 hat Max Reitz geschrieben: If the id field is missing from the options given to blockdev-add, just omit the BlockBackend and create the BlockDriverState tree alone. However, if id is missing, node-name must be specified;

[Qemu-devel] [PATCH] 9pfs-local: simplify/optimize local_mapped_attr_path()

2015-03-04 Thread Michael Tokarev
Omit one unnecessary memory allocation for components of the path and create the resulting path directly given lengths of the components. This uses (char*) cast because basename() accepts a char* without const, for unknown reason. Maybe it is better to use strrchr(), but I'm not sure for various

Re: [Qemu-devel] [PATCH] advance minimum required GLib version to 2.22

2015-03-04 Thread Stefan Weil
Am 03.03.2015 um 16:28 schrieb Igor Mammedov: Signed-off-by: Igor Mammedov imamm...@redhat.com --- configure | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/configure b/configure index 7ba4bcb..db79e0a 100755 --- a/configure +++ b/configure @@ -2744,12 +2744,7 @@ fi

[Qemu-devel] 9pfs-local: open2() deletes existing data?

2015-03-04 Thread Michael Tokarev
I was looking at various interesting functions in hw/9pfs/virtio-9p-local.c and noticed local_open2() which basically tries to open a file in a filesystem, and if that is successful, it tries to set file credentials using a configured mechanism, and if that fails, it deletes the file. Now I

[Qemu-devel] 9pfs-local: the security models enum?

2015-03-04 Thread Michael Tokarev
I noticed that most file operations in hw/9pfs/virtio-9p-local.c are modelled like this: if (fs_ctx-export_flags V9FS_SM_MAPPED) { /* MAPPED version */ } else if (fs_ctx-export_flags V9FS_SM_MAPPED_FILE) { /* MAPPED_FILE version */ } else if ((fs_ctx-export_flags

Re: [Qemu-devel] vmdk: improve streamOptimized vmdk support

2015-03-04 Thread Sunil Kumar
I don't have a qemu dev test environment if that's what you mean. But I will definitely be able to take a patch and test to see if the created streamOptimized VMDK gets accepted by the ESXi server that I have here. Thanks On Tuesday, March 3, 2015 12:54 AM, Fam Zheng f...@redhat.com wrote:

Re: [Qemu-devel] [PATCH 2/9] throttle: Add throttle group infrastructure

2015-03-04 Thread Stefan Hajnoczi
On Wed, Mar 04, 2015 at 11:18:21AM +0100, Alberto Garcia wrote: On Tue, Mar 03, 2015 at 10:38:45AM -0600, Stefan Hajnoczi wrote: +qemu_mutex_init(tg-lock); +throttle_init(tg-ts); +QLIST_INIT(tg-head); +tg-refcount = 1; + +/* insert new entry in the list */

Re: [Qemu-devel] QEMU etc/e820 and fw_cfg

2015-03-04 Thread Gordan Bobic
On 2015-03-04 13:20, Gerd Hoffmann wrote: On Di, 2015-03-03 at 10:32 +, Gordan Bobic wrote: I need to pass a custom e820 map to a virtual machine for troubleshooting purposes and working around IOMMU hardware bugs. I have found references to a custom map being providable via an external

[Qemu-devel] [PULL 1/5] pc-dimm: add a function to calculate VM's current RAM size

2015-03-04 Thread Luiz Capitulino
From: zhanghailiang zhang.zhanghaili...@huawei.com The global parameter 'ram_size' does not take into account the hotplugged memory. In some codes, we use 'ram_size' as current VM's real RAM size, which is not correct. Add function 'get_current_ram_size' to calculate VM's current RAM size, it

[Qemu-devel] [PULL 18/47] vfio: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/vfio/common.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULL 22/47] vhost: Remove superfluous '\n' around error_report()

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/virtio/vhost-backend.c | 2 +- net/vhost-user.c | 4 ++-- 2 files changed, 3 insertions(+), 3

[Qemu-devel] [PULL 07/47] qemu-options: fix/document -incoming options

2015-03-04 Thread Michael Tokarev
Signed-off-by: Michael Tokarev m...@tls.msk.ru --- qemu-options.hx | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ee4b223..303d13c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3195,12 +3195,30 @@ Set

[Qemu-devel] [PULL 33/47] sysbus: fix memory leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/core/sysbus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c index 84af593..b53c351 100644 --- a/hw/core/sysbus.c

[Qemu-devel] [PULL 01/47] xen-pt: fix Negative array index read

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Coverity spot: Function xen_pt_bar_offset_to_index() may return a negative value (-1) which is used as an index to d-io_regions[] down the line. Let's pass index directly as an argument to xen_pt_bar_reg_parse(). Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH V14 2/3] pc: add a Virtual Machine Generation ID device

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 05:33:42PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 16:31:39 +0100 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Mar 04, 2015 at 04:14:44PM +0100, Igor Mammedov wrote: On Wed, 4 Mar 2015 14:49:00 +0100 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-04 Thread Eduardo Habkost
On Tue, Mar 03, 2015 at 11:55:24AM +0100, Michael Mueller wrote: On Mon, 02 Mar 2015 17:57:01 +0100 Andreas Färber afaer...@suse.de wrote: Am 02.03.2015 um 17:43 schrieb Michael Mueller: On Mon, 02 Mar 2015 14:57:21 +0100 Andreas Färber afaer...@suse.de wrote: int

[Qemu-devel] [PULL 42/47] oslib-posix: Fix compiler warning (-Wclobbered) and simplify the code

2015-03-04 Thread Michael Tokarev
From: Stefan Weil s...@weilnetz.de gcc reports this warning with -Wclobbered: util/oslib-posix.c: In function ‘os_mem_prealloc’: util/oslib-posix.c:374:49: error: argument ‘memory’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Fix this and simplify the code by using an

Re: [Qemu-devel] [PATCH 3/3] migration: Fix remaining 32 bit compiler errors

2015-03-04 Thread Stefan Weil
Please see my comments below. Am 04.03.2015 um 14:31 schrieb Dr. David Alan Gilbert: * Stefan Weil (s...@weilnetz.de) wrote: Fix type casts between pointers and 64 bit integers. Now 32 bit builds are possible again. Signed-off-by: Stefan Weil s...@weilnetz.de --- migration/rdma.c | 57

[Qemu-devel] [PULL 14/47] pl330.c: remove superfluous '\n' around error_setg

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Markus Armbruster arm...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/dma/pl330.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dma/pl330.c

[Qemu-devel] [PULL 45/47] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-03-04 Thread Michael Tokarev
From: Radim Krčmář rkrc...@redhat.com man gcc: Warn if in a loop with constant number of iterations the compiler detects undefined behavior in some statement during one or more of the iterations. Milkymist pfpu has no jump instructions, so checking for MICROCODE_WORDS instructions should

Re: [Qemu-devel] [PATCH 2/3] migration: Fix some 32 bit compiler errors

2015-03-04 Thread Stefan Weil
Am 04.03.2015 um 13:44 schrieb Dr. David Alan Gilbert: * Stefan Weil (s...@weilnetz.de) wrote: The current code won't compile on 32 bit hosts because there are lots of type casts between pointers and 64 bit integers. Fix some of them. Signed-off-by: Stefan Weil s...@weilnetz.de Please route

[Qemu-devel] [PULL 44/47] fix GCC 5.0.0 logical-not-parentheses warnings

2015-03-04 Thread Michael Tokarev
From: Radim Krčmář rkrc...@redhat.com man gcc: Warn about logical not used on the left hand side operand of a comparison. This option does not warn if the RHS operand is of a boolean type. By preferring bool over int where sensible, but without modifying any depending code, make GCC happy

[Qemu-devel] [PULL 34/47] microblaze: fix memory leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com When not assign a -dtb argument, the variable dtb_filename storage returned from qemu_find_file(), which should be freed after using. Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/microblaze/boot.c | 4

[Qemu-devel] [PULL 29/47] nbd: fix resource leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 697c021..6634a69 100644 --- a/block/nbd.c +++ b/block/nbd.c @@

[Qemu-devel] [PULL 24/47] ui/vnc: Remove vnc_stop_worker_thread()

2015-03-04 Thread Michael Tokarev
From: Thomas Huth th...@linux.vnet.ibm.com This function is not used anymore, let's remove it. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- ui/vnc-jobs.c | 13 - ui/vnc-jobs.h | 1

[Qemu-devel] [PULL 31/47] macio: fix possible memory leak

2015-03-04 Thread Michael Tokarev
From: Gonglei arei.gong...@huawei.com If ret = macio_initfn_ide() is less than 0, the timer_memory will leak the memory it points to. Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Michael Tokarev m...@tls.msk.ru --- hw/misc/macio/macio.c | 3 ++- 1 file changed, 2 insertions(+),

  1   2   3   4   >