Re: [Qemu-devel] [Consult] About SPRs information

2015-05-01 Thread Chen Gang
Hello all: At present, I met an issue (I guess, it should be my code bug), I am analyzing it which may spend quite a few time resources (checking and reconstructing the code is helpful for analyzing this issue): - It is about invalid memory access for ld operation. The related tilegx code is

Re: [Qemu-devel] [Consult] About SPRs information

2015-05-01 Thread Chen Gang
On 4/29/15 21:32, Chen Gang wrote: > On 4/29/15 05:43, Peter Maydell wrote: >> On 28 April 2015 at 22:32, Chen Gang wrote: >>> The related information for cmpexch instruction: >>> >>> Description >>> >>> Compare the 8-byte contents of the CmpValue SPR with the 8-byte >>> value in memor

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
On 05/01/2015 04:48 PM, Paolo Bonzini wrote: On 01/05/2015 21:55, John Snow wrote: Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; Wi

Re: [Qemu-devel] [RFC PATCH 02/15] qdev: store DeviceState's canonical path to use when unparenting

2015-05-01 Thread Michael Roth
Quoting Paolo Bonzini (2015-05-01 15:43:45) > > > On 01/05/2015 01:03, Michael Roth wrote: > > > > I played around with the idea of temporarilly moving unparented, unfinalized > > objects to an "orphan" container. It seemed like a fun way of tracking > > leaked > > objects, and avoids the asser

[Qemu-devel] [PATCH] MAINTAINERS: Make Stefan Berger maintainer of TPM code

2015-05-01 Thread Stefan Berger
Signed-off-by: Stefan Berger --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0b67c48..0e0f573 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -668,6 +668,12 @@ S: Maintained F: hw/ssi/* F: hw/block/m25p80.c +TPM +M: Stefan Berger +S: Ma

Re: [Qemu-devel] [PATCH RFC 19/19] qapi: New QMP command query-schema for QMP schema introspection

2015-05-01 Thread Eric Blake
On 04/02/2015 11:29 AM, Markus Armbruster wrote: > > * Implicit type definitions are made explicit, and given > auto-generated names. These names start with ':' so they don't > clash with the user's names. > > Example: a simple union implicitly defines an enumeration type for > its disc

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
On 05/01/2015 04:48 PM, Paolo Bonzini wrote: On 01/05/2015 21:55, John Snow wrote: Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; Wi

[Qemu-devel] [Bug 1450891] [NEW] VM will not resume on GlusterFS

2015-05-01 Thread Christopher Pereira
Public bug reported: oVirt uses libvirt to run QEMU. Images are passed to QEMU as files, not file descriptors. When running images from a GlusterFS, the file descriptors may get invalidated because of network problems or the glusterfs process being restarted. In this case, the VM goes into paused

[Qemu-devel] [PATCH] use bdrv_flush to provide barrier semantic in block/vdi.c for metadata updates

2015-05-01 Thread phoeagon
Looks like VDI is the only writable image format that does not use write-with-barrier(sync) when updating the metadata. A sequence of commits b0ad5a455d~078a458e077d6b0db2 fixes this for QCOW/COW/QCOW2/VPC/VMDK, but the VDI does not issue a barrier by sync after updating the metadata. This commit

Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread Paolo Bonzini
On 01/05/2015 21:55, John Snow wrote: > Where it makes sense, use the new faster primitives. > For generally small reads/writes such as for the PRDT > and FIS packets, stick with the more wasteful but > easier to debug memread/memwrite. > > For ahci-test; > With this patch: > real 0m4.802s > us

Re: [Qemu-devel] [RFC PATCH 02/15] qdev: store DeviceState's canonical path to use when unparenting

2015-05-01 Thread Paolo Bonzini
On 01/05/2015 01:03, Michael Roth wrote: > > I played around with the idea of temporarilly moving unparented, unfinalized > objects to an "orphan" container. It seemed like a fun way of tracking leaked > objects, and avoids the assert, but that got wierd pretty quickly... and > having DEVICE_DEL

[Qemu-devel] [PATCH v7 36a/39] squash: qapi: Drop dead visitor code related to nested structs

2015-05-01 Thread Eric Blake
Now that we no longer have nested structs to visit, the use of prefix strings is no longer required. Remove the code that is no longer reachable. Signed-off-by: Eric Blake --- scripts/qapi-visit.py | 49 - 1 file changed, 12 insertions(+), 37 dele

[Qemu-devel] [PATCH v7 39a/39] squash: qapi: Check for member name conflicts with a base class

2015-05-01 Thread Eric Blake
A conflict must be marked even when the two dictionaries being compared differ on whether the key is marked optional. Signed-off-by: Eric Blake --- scripts/qapi.py| 4 +++- tests/qapi-schema/flat-union-branch-clash.json | 2 +- tests/qapi-schema/struct-base-clash-

Re: [Qemu-devel] [PATCH v7 39/39] qapi: Check for member name conflicts with a base class

2015-05-01 Thread Eric Blake
On 04/29/2015 07:06 AM, Eric Blake wrote: > Our type inheritance for both 'struct' and for flat 'union' merges > key/value pairs from the base class with those from the type in > question. Although the C code currently boxes things so that there > is a distinction between which member is referred

Re: [Qemu-devel] [PATCH v7 36/39] qapi: Drop support for inline nested types

2015-05-01 Thread Eric Blake
On 04/29/2015 07:06 AM, Eric Blake wrote: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument > (see previous commit messages for more details why); but existing > use of inline nested structs conflicts with that goal.

[Qemu-devel] [PATCHv7 22a/39] squash: qapi: Unify type bypass and add tests

2015-05-01 Thread Eric Blake
Signed-off-by: Eric Blake --- This needs to be squashed into v7:22/39 to avoid a regression in QGA. If you'd rather me post a single amended patch as v8, I can do that. scripts/qapi-commands.py | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/scripts/qapi-commands.py

Re: [Qemu-devel] [PATCH v7 22/39] qapi: Unify type bypass and add tests

2015-05-01 Thread Eric Blake
On 04/29/2015 07:06 AM, Eric Blake wrote: > For a few QMP commands, we are forced to pass an arbitrary type > without tracking it properly in QAPI. Among the existing clients, > this unnamed type was spelled 'dict', 'visitor', and '**'; this > patch standardizes on '**', matching the documentation

[Qemu-devel] [PATCH v2 3/4] qtest: add memset to qtest protocol

2015-05-01 Thread John Snow
Previously, memset was just a frontend to write() and only stupidly sent the pattern many times across the wire. Let's not discuss who stupidly wrote it like that in the first place. (Hint: It was me.) Signed-off-by: John Snow --- qtest.c | 20 tests/libqtest.c |

[Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write

2015-05-01 Thread John Snow
Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test; With this patch: real0m4.802s user0m3.506s sys 0m2.393s Without this series: re

[Qemu-devel] [PATCH v2 0/4] qtest: base64 r/w and faster memset

2015-05-01 Thread John Snow
Adds new qtest protocol commands for base64 reads and writes, as well as a proper command for memset instead of faking it via write. This improves the ahci-test performance on my machine from about 14 seconds to about 4. == For convenience, this branch is available at: https://github.com/jnsnow/q

[Qemu-devel] [PATCH v2 1/4] qtest: allow arbitrarily long sends

2015-05-01 Thread John Snow
qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data, but split this off into a new function, qtest_sendf. Static data can still be sent using

[Qemu-devel] [PATCH v2 2/4] qtest: Add base64 encoded read/write

2015-05-01 Thread John Snow
For larger pieces of data that won't need to be debugged and viewing the hex nibbles is unlikely to be useful, we can encode data using base64 instead of encoding each byte as %02x, which leads to some space savings and faster reads/writes. For now, the default is left as hex nibbles in memwrite()

[Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2015-05-01 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1450881 Title: qemu-system-sparc MUTEX_HELD assert and libC lock errors Status in QE

Re: [Qemu-devel] [PATCH v2 1/2] qom: Implement object_property_add_const_link()

2015-05-01 Thread Paolo Bonzini
On 01/05/2015 16:09, Eduardo Habkost wrote: > +void object_property_add_const_link(Object *obj, const char *name, > + const char *type, Object *child, > + ObjectPropertyLinkFlags flags, > +

[Qemu-devel] [PATCH v4 07/17] hw/intc/arm_gic: Make ICCBPR/GICC_BPR banked

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler This register is banked in GICs with Security Extensions. Storing the non-secure copy of BPR in the abpr, which is an alias to the non-secure copy for secure access. ABPR itself is only accessible from secure state if the GIC implements Security Extensions. Signed-off-by: Fa

[Qemu-devel] [PATCH v4 05/17] hw/intc/arm_gic_kvm.c: Save and restore GICD_IGROUPRn state

2015-05-01 Thread Peter Maydell
Now that the GIC base class has state fields for the GICD_IGROUPRn registers, make kvm_arm_gic_get() and kvm_arm_gic_put() write and read them. This allows us to remove the check that made us fail migration if the guest had set any of the group register bits. Signed-off-by: Peter Maydell --- hw/

[Qemu-devel] [PATCH v4 04/17] hw/intc/arm_gic: Add Interrupt Group Registers

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler The Interrupt Group Registers allow the guest to configure interrupts into one of two groups, where Group0 are higher priority and may be routed to IRQ or FIQ, and Group1 are lower priority and always routed to IRQ. (In a GIC with the security extensions Group0 is Secure inte

[Qemu-devel] [PATCH v4 12/17] hw/intc/arm_gic: Change behavior of EOIR writes

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Grouping (GICv2) and Security Extensions change the behavior of EOIR writes. Completing Group0 interrupts is only allowed from Secure state. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-13-git-send-email-greg.bell...@linaro.org [PMM

[Qemu-devel] [PATCH v4 13/17] hw/intc/arm_gic: Change behavior of IAR writes

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Grouping (GICv2) and Security Extensions change the behavior of IAR reads. Acknowledging Group0 interrupts is only allowed from Secure state and acknowledging Group1 interrupts from Secure state is only allowed if AckCtl bit is set. Signed-off-by: Fabian Aggeler Signed-off-

[Qemu-devel] [PATCH v4 06/17] hw/intc/arm_gic: Make ICDDCR/GICD_CTLR banked

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler ICDDCR/GICD_CTLR is banked if the GIC has the security extensions, and the S (or only) copy has separate enable bits for Group0 and Group1 enable if the GIC implements interrupt groups. EnableGroup0 (Bit [1]) in GICv1 is architecturally IMPDEF. Since this bit (Enable Non-sec

[Qemu-devel] [PATCH v4 03/17] hw/intc/arm_gic: Switch to read/write callbacks with tx attributes

2015-05-01 Thread Peter Maydell
Switch the GIC's MMIO callback functions to the read_with_attrs and write_with_attrs functions which provide MemTxAttrs. This will allow the GIC to correctly handle secure and nonsecure register accesses. Signed-off-by: Peter Maydell --- hw/intc/arm_gic.c | 144 ++

[Qemu-devel] [PATCH v4 16/17] hw/arm/vexpress.c: Wire FIQ between CPU <> GIC

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Connect FIQ output of the GIC CPU interfaces to the CPUs. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-3-git-send-email-greg.bell...@linaro.org [PMM: minor format tweak] Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 2 ++ 1

[Qemu-devel] [PATCH v4 00/17] arm_gic: Add security and grouping support

2015-05-01 Thread Peter Maydell
This patch series adds support for GICv1 and GICv2 security extensions, as well as support for GIC interrupt grouping on GICv2. This is based on the work originally by Fabian and then by Greg. I've gone through and dealt with all the issues I raised in code review, and a few others I noticed as I

[Qemu-devel] [PATCH v4 01/17] hw/intc/arm_gic: Create outbound FIQ lines

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Create the outbound FIQ lines from the GIC to the CPUs; these are used if the GIC has security extensions or grouping support. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-2-git-send-email-greg.bell...@linaro.org [PMM: added FIQ lin

[Qemu-devel] [PATCH v4 02/17] hw/intc/arm_gic: Add Security Extensions property

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Add a QOM property which allows the GIC Security Extensions to be enabled. These are an optional part of the GICv1 and GICv2 architecture. This commit just adds the property and some sanity checks that it is only enabled on GIC revisions that support it. Signed-off-by: Fabia

[Qemu-devel] [PATCH v4 15/17] hw/arm/virt.c: Wire FIQ between CPU <> GIC

2015-05-01 Thread Peter Maydell
From: Greg Bellows Connect FIQ output of the GIC CPU interfaces to the CPUs. Signed-off-by: Greg Bellows Message-id: 1429113742-8371-4-git-send-email-greg.bell...@linaro.org [PMM: minor format tweak] Signed-off-by: Peter Maydell --- hw/arm/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff

[Qemu-devel] [PATCH v4 10/17] hw/intc/arm_gic: Restrict priority view

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler GICs with Security Extensions restrict the non-secure view of the interrupt priority and priority mask registers. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-15-git-send-email-greg.bell...@linaro.org [PMM: minor code tweaks; fixed

[Qemu-devel] [PATCH v4 09/17] hw/intc/arm_gic: Implement Non-secure view of RPR

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler For GICs with Security Extensions Non-secure reads have a restricted view on the current running priority. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-11-git-send-email-greg.bell...@linaro.org [PMM: make function static, minor comm

[Qemu-devel] [PATCH v4 17/17] hw/arm/highbank.c: Wire FIQ between CPU <> GIC

2015-05-01 Thread Peter Maydell
Connect FIQ output of the GIC CPU interfaces to the CPUs. Signed-off-by: Peter Maydell --- hw/arm/highbank.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index b2d048b..f8353a7 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -217,6 +217,7

[Qemu-devel] [PATCH v4 11/17] hw/intc/arm_gic: Handle grouping for GICC_HPPIR

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler Grouping (GICv2) and Security Extensions change the behaviour of reads of the highest priority pending interrupt register (ICCHPIR/GICC_HPPIR). Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Message-id: 1429113742-8371-12-git-send-email-greg.bell...@linaro.org [

[Qemu-devel] [PATCH v4 14/17] hw/intc/arm_gic: Add grouping support to gic_update()

2015-05-01 Thread Peter Maydell
Add support to gic_update() for determining the current IRQ and FIQ status when interrupt grouping is supported. This simply requires that instead of always raising IRQ we check the group of the highest priority pending interrupt and the GICC_CTLR.FIQEn bit to see whether we should raise IRQ or FIQ

[Qemu-devel] [PATCH v4 08/17] hw/intc/arm_gic: Make ICCICR/GICC_CTLR banked

2015-05-01 Thread Peter Maydell
From: Fabian Aggeler ICCICR/GICC_CTLR is banked in GICv1 implementations with Security Extensions or in GICv2 in independent from Security Extensions. This makes it possible to enable forwarding of interrupts from the CPU interfaces to the connected processors for Group0 and Group1. We also allo

Re: [Qemu-devel] [PATCH v2 0/3] parse 'null' literal in QMP

2015-05-01 Thread Luiz Capitulino
On Wed, 29 Apr 2015 15:35:03 -0600 Eric Blake wrote: > Here's my attempt to merge the best points of Markus' approach [1] > (patches 16-18 of that series - benefit of smaller patches and fewer > malloc calls) and my approach [2] (benefit of a testsuite addition > and more detailed commit messages

Re: [Qemu-devel] [RFC v4] monitor: add memory search commands s, sp

2015-05-01 Thread Luiz Capitulino
On Fri, 24 Apr 2015 14:39:48 +0200 hw.clau...@gmail.com wrote: > From: Claudio Fontana > > usage is similar to the commands x, xp. > > Example with string: looking for "ELF" header in memory: > > (qemu) s/100cb 0x40001000 "ELF" > searching memory area [40001000-400f5240] >

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Luiz Capitulino
On Sat, 25 Apr 2015 12:28:06 -0300 Eduardo Habkost wrote: > The QJSON code used casts to (QJSON*) directly, instead of OBJECT_CHECK. > There were even some functions using object_dynamic_cast() calls > followed by assert(), which is exactly what OBJECT_CHECK does (by > calling object_dynamic_cast

Re: [Qemu-devel] [PATCH target-arm v6 00/14] Next Generation Xilinx Zynq SoC

2015-05-01 Thread Peter Crosthwaite
Ping! On Fri, Apr 24, 2015 at 1:28 PM, Peter Crosthwaite wrote: > Hi Peter and all, > > Xilinx's next gen SoC has been announced. This series adds a SoC and > board. > > Series start with addition of ARM cortex A53 support (P1 and P2). The > Soc skeleton is then added with GIC, EMACs and UARTs ar

Re: [Qemu-devel] [PATCH v2 2/4] qapi: Drop duplicate c_fun() in favor of c_var()

2015-05-01 Thread Eric Blake
On 04/29/2015 05:04 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that the two functions are identical, we only need one of them. >> >> Signed-off-by: Eric Blake > > c_var() isn't the possible best name, but it'll do. I'm looking at using c_name() in my v3. -- Eric Blake eblak

Re: [Qemu-devel] [Qemu-block] [PATCH COLO v3 10/14] util/hbitmap: Add an API to reset all set bits in hbitmap

2015-05-01 Thread John Snow
On 04/03/2015 07:05 AM, Paolo Bonzini wrote: On 03/04/2015 12:01, Wen Congyang wrote: Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- include/qemu/hbitmap.h | 8 tests/test-hbitmap.c | 39 +++ util/hbi

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Michael Roth
Quoting Michael Roth (2015-05-01 11:19:05) > Quoting Eduardo Habkost (2015-04-29 07:55:48) > > On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: > > > On Mon, 27 Apr 2015 14:23:20 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Fär

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Michael Roth
Quoting Eduardo Habkost (2015-04-29 07:55:48) > On Wed, Apr 29, 2015 at 08:38:02AM -0400, Luiz Capitulino wrote: > > On Mon, 27 Apr 2015 14:23:20 -0300 > > Eduardo Habkost wrote: > > > > > On Sat, Apr 25, 2015 at 07:05:55PM +0200, Andreas Färber wrote: > > > > Am 25.04.2015 um 17:28 schrieb Eduar

Re: [Qemu-devel] [PATCH 3/3] target-mips: Misaligned Memory Accesses for MSA

2015-05-01 Thread Yongbok Kim
On 01/05/2015 16:43, Peter Maydell wrote: > On 1 May 2015 at 16:24, Yongbok Kim wrote: >> MIPS SIMD Architecture vector loads and stores require misalignment support. >> MSA Memory access should work as an atomic operation. Therefore, it has to >> check validity of all the addresses for the operat

Re: [Qemu-devel] [PATCH 3/3] target-mips: Misaligned Memory Accesses for MSA

2015-05-01 Thread Peter Maydell
On 1 May 2015 at 16:24, Yongbok Kim wrote: > MIPS SIMD Architecture vector loads and stores require misalignment support. > MSA Memory access should work as an atomic operation. Therefore, it has to > check validity of all the addresses for the operation. > > Signed-off-by: Yongbok Kim > --- > t

Re: [Qemu-devel] [PATCH 2/3] target-mips: Misaligned Memory Accesses for R6

2015-05-01 Thread Peter Maydell
On 1 May 2015 at 16:24, Yongbok Kim wrote: > Release 6 requires misaligned memory access support for all ordinary memory > access instructions (for example, LW/SW, LWC1/SWC1). > However misaligned support is not provided for certain special memory accesses > such as atomics (for example, LL/SC). >

[Qemu-devel] [PATCH 0/3] target-mips: Add support for misaligned accesses

2015-05-01 Thread Yongbok Kim
This patch set adds support for misaligned memory accesses in MIPS architecture Release 6 and MIPS SIMD Architecture. The behaviour, semantics, and architecture specifications of misaligned memory accesses are described in: MIPS Architecture For Programmers Volume I-A: Introduction to the MIPS64 A

[Qemu-devel] [PATCH 2/3] target-mips: Misaligned Memory Accesses for R6

2015-05-01 Thread Yongbok Kim
Release 6 requires misaligned memory access support for all ordinary memory access instructions (for example, LW/SW, LWC1/SWC1). However misaligned support is not provided for certain special memory accesses such as atomics (for example, LL/SC). In the mips_cpu_do_unaligned_access() callback, if i

[Qemu-devel] [PATCH 1/3] softmmu: Add size argument to do_unaligned_access()

2015-05-01 Thread Yongbok Kim
Pass a data size argument to do_unaligned_access(). It is unable to find if an access spans two pages without the data size in the call back function. Signed-off-by: Yongbok Kim --- include/qom/cpu.h |7 --- softmmu_template.h | 24 target-alph

[Qemu-devel] [PATCH 3/3] target-mips: Misaligned Memory Accesses for MSA

2015-05-01 Thread Yongbok Kim
MIPS SIMD Architecture vector loads and stores require misalignment support. MSA Memory access should work as an atomic operation. Therefore, it has to check validity of all the addresses for the operation. Signed-off-by: Yongbok Kim --- target-mips/op_helper.c | 30 +++

Re: [Qemu-devel] [RFC 5/5] arm: Simplify cycle counter

2015-05-01 Thread Christopher Covington
On Thu, Apr 30, 2015 at 9:24 PM, Peter Crosthwaite wrote: > On Thu, Apr 30, 2015 at 11:14 AM, Christopher Covington > wrote: >> Present a system with an instructions per cycle of exactly one. >> This makes it less likely a user will mistake the cycle counter >> values as meaningful and makes calc

Re: [Qemu-devel] [PATCH 2/6] qcow2: simplify qcow2_cache_put() and qcow2_cache_entry_mark_dirty()

2015-05-01 Thread Stefan Hajnoczi
On Thu, Apr 30, 2015 at 01:11:41PM +0300, Alberto Garcia wrote: > int qcow2_cache_put(BlockDriverState *bs, Qcow2Cache *c, void **table) > { > -int i; > +int i = (*table - c->table_array) / c->table_size; > > -for (i = 0; i < c->size; i++) { > -if (table_addr(c, i) == *table

Re: [Qemu-devel] [Qemu-block] [PATCH 1/6] qcow2: use one single memory block for the L2/refcount cache tables

2015-05-01 Thread Stefan Hajnoczi
On Thu, Apr 30, 2015 at 01:11:40PM +0300, Alberto Garcia wrote: > Qcow2Cache *qcow2_cache_create(BlockDriverState *bs, int num_tables) > { > BDRVQcowState *s = bs->opaque; > Qcow2Cache *c; > -int i; > > c = g_new0(Qcow2Cache, 1); > c->size = num_tables; > +c->table_s

Re: [Qemu-devel] [Qemu-block] [PATCH] MAINTAINERS: Add qemu-block list where missing

2015-05-01 Thread Stefan Hajnoczi
On Thu, Apr 30, 2015 at 03:15:50PM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Stefan Hajnoczi pgpZOSUrkHzxh.pgp Description: PGP signature

[Qemu-devel] [PATCH v2 1/2] qom: Implement object_property_add_const_link()

2015-05-01 Thread Eduardo Habkost
It can be used in simpler cases where a read-only property is needed. Signed-off-by: Eduardo Habkost --- include/qom/object.h | 23 +++ qom/object.c | 15 +++ 2 files changed, 38 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index

[Qemu-devel] [PATCH v2 2/2] cpu: Register QOM links at /machine/cpus[]

2015-05-01 Thread Eduardo Habkost
This will provide a predictable path for the CPU objects, and a more powerful alternative for the query-cpus QMP command, as now every QOM property on CPU objects can be easily queried. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use object_property_add_const_link() * Use "/machine/cpu

[Qemu-devel] [PATCH v2 0/2] cpu: Add /machine/cpus[] links

2015-05-01 Thread Eduardo Habkost
Changes v1 -> v2: * Implement a object_property_add_const_link() function * Use "/machine/cpus[]" instead of "/machine/cpus/" * Grab reference to object before adding link Eduardo Habkost (2): qom: Implement object_property_add_const_link() cpu: Register QOM links at /machine/cpus[] exec.c

Re: [Qemu-devel] [PATCH v3 2/2] qga/commands-posix: Return per path fstrim result

2015-05-01 Thread Justin Ossevoort
On 30-04-15 18:35, Thomas Huth wrote: On Thu, 30 Apr 2015 16:29:58 +0200 Justin Ossevoort wrote: The current guest-fstrim support only returns an error if some mountpoint was unable to be trimmed, skipping any possible additional mountpoints. The result of the TRIM operation itself is also dis

Re: [Qemu-devel] [PATCH] ui: remove check for failure of qemu_acl_init()

2015-05-01 Thread Eric Blake
On 05/01/2015 04:44 AM, Daniel P. Berrange wrote: > The qemu_acl_init() function has long since stopped being able > to return NULL, since g_malloc will abort on OOM. As such the > checks for NULL were unreachable code. > > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 8 > 1 fil

Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-05-01 Thread Eduardo Habkost
On Thu, Apr 30, 2015 at 06:51:43PM -0700, Peter Crosthwaite wrote: > On Thu, Apr 30, 2015 at 12:19 PM, Eduardo Habkost wrote: > > This will provide a predictable path for the CPU objects, and a more > > powerful alternative for the query-cpus QMP command, as now every QOM > > property on CPU objec

Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-05-01 Thread Eduardo Habkost
On Thu, Apr 30, 2015 at 10:21:55PM +0200, Andreas Färber wrote: > First I did not participate in that discussion, second nack to that > self pointer. Please hold off on this until I'm back. Andreas I suggested it 3 times before. The message mentioned in the patch has pointers to the other 2 discus

Re: [Qemu-devel] [PATCH] QJSON: Use OBJECT_CHECK

2015-05-01 Thread Eduardo Habkost
On Wed, Apr 29, 2015 at 09:18:27PM +0200, Paolo Bonzini wrote: > On 27/04/2015 19:23, Eduardo Habkost wrote: > > Also, why do we have two JSON writers in QEMU? And why do they have > > exactly the same name? > > qobject/qjson.c could use qjson.c... but then qjson.c probably should be > changed 1)

Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/

2015-05-01 Thread Eduardo Habkost
On Thu, Apr 30, 2015 at 11:47:09PM +0200, Paolo Bonzini wrote: > > > On 30/04/2015 22:21, Andreas Färber wrote: > >>+cpu->self = cobj; > >>+object_property_add_link(cpu_container, path, TYPE_CPU, &cpu->self, > >>NULL, > >>+ OBJ_PROP_LINK_UNREF_ON_RELEASE, &err

[Qemu-devel] [PATCH] ui: remove check for failure of qemu_acl_init()

2015-05-01 Thread Daniel P. Berrange
The qemu_acl_init() function has long since stopped being able to return NULL, since g_malloc will abort on OOM. As such the checks for NULL were unreachable code. Signed-off-by: Daniel P. Berrange --- ui/vnc.c | 8 1 file changed, 8 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index

[Qemu-devel] [PATCH v3 7/7] qom: don't pass string table to object_get_enum method

2015-05-01 Thread Daniel P. Berrange
Now that properties can be explicitly registered as an enum type, there is no need to pass the string table to the object_get_enum method. The object property registration already has a pointer to the string table. In changing this method signature, the hostmem backend object has to be converted t

[Qemu-devel] [PATCH v3 5/7] qom: make enum string tables const-correct

2015-05-01 Thread Daniel P. Berrange
The enum string table parameters in various QOM/QAPI methods are declared 'const char *strings[]'. This results in const warnings if passed a variable that was declared as static const char * const strings[] = { }; Add the extra const annotation to the parameters, since neither the string

[Qemu-devel] [PATCH v3 3/7] qom: create objects in two phases

2015-05-01 Thread Daniel P. Berrange
Some types of object must be created before chardevs, other types of object must be created after chardevs. As such there is no option but to create objects in two phases. This takes the decision to create as many object types as possible in the first phase, and only delay those which have a depen

[Qemu-devel] [PATCH v3 2/7] qom: document user creatable object types in help text

2015-05-01 Thread Daniel P. Berrange
The QEMU help for -object is essentially useless, just giving users the generic syntax. Move it down into its own section and introduce a nested table where each user creatable object can be documented. The existing memory-backend-file, rng-random and rng-egd object types are documented. Signed-of

[Qemu-devel] [PATCH v3 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-05-01 Thread Daniel P. Berrange
It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user creatable type). This requires quite a lot of error prone, verbose, boilerplate code to achieve. The object_new_propv / object_new_proplist construc

[Qemu-devel] [PATCH v3 6/7] qom: add a object_property_add_enum helper method

2015-05-01 Thread Daniel P. Berrange
A QOM property can be parsed as enum using the visit_type_enum() helper method, but this forces callers to use the more complex generic object_property_add() method when registering it. It also requires that users of that object have access to the string map when they want to read the property valu

[Qemu-devel] [PATCH v3 0/7] qom: misc fixes & enhancements to support TLS work

2015-05-01 Thread Daniel P. Berrange
This series contains the 7 generic QOM API fixes and enhancements that I previously posted as part of the large series refactoring and extending the TLS support in QEMU: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg02038.html I'm sending it separately, since the patches are reasonab

[Qemu-devel] [PATCH v3 1/7] qom: fix typename of 'policy' enum property in hostmem obj

2015-05-01 Thread Daniel P. Berrange
The 'policy' property was being registered with a typename of 'str', but it is in fact an enum of the 'HostMemPolicy' type. Signed-off-by: Daniel P. Berrange --- backends/hostmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/hostmem.c b/backends/hostmem.c index b

Re: [Qemu-devel] [PATCH v2 6/7] qom: add a object_property_add_enum helper method

2015-05-01 Thread Daniel P. Berrange
On Thu, Apr 30, 2015 at 04:46:37PM +0100, Daniel P. Berrange wrote: > A QOM property can be parsed as enum using the visit_type_enum() > helper method, but this forces callers to use the more complex > generic object_property_add() method when registering it. It > also requires that users of that o

Re: [Qemu-devel] [PULL 0/7] Block patches

2015-05-01 Thread Peter Maydell
On 30 April 2015 at 20:10, Kevin Wolf wrote: > The following changes since commit 06feaacfb4cfef10cc0c93d97df7bfc8a71dbc7e: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-04-30 12:04:11 +0100) > > are available in the git repository at: > > > git://r

[Qemu-devel] [PATCH 17/32] spapr_drc: initial implementation of sPAPRDRConnector device

2015-05-01 Thread David Gibson
From: Michael Roth This device emulates a firmware abstraction used by pSeries guests to manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, memory, and CPUs. It is conceptually similar to an SHPC device, complete with LED indicators to identify individual slots to physical physi