[Qemu-devel] [PULL v2 11/14] qtest: Add base64 encoded read/write

2015-05-12 Thread John Snow
For larger pieces of data that won't need to be debugged and viewing the hex nibbles is unlikely to be useful, we can encode data using base64 instead of encoding each byte as %02x, which leads to some space savings and faster reads/writes. For now, the default is left as hex nibbles in memwrite()

[Qemu-devel] [PULL v2 07/14] qtest/ahci: add flush migrate test

2015-05-12 Thread John Snow
Use blkdebug to inject an error on first flush, then attempt to flush on the first guest. When the error halts the VM, migrate to the second VM, and attempt to resume the command. Signed-off-by: John Snow Reviewed-by: Kevin Wolf Message-id: 1430417242-11859-8-git-send-email-js...@redhat.com ---

Re: [Qemu-devel] [PULL 00/14] Ide patches

2015-05-12 Thread John Snow
On 05/12/2015 11:25 AM, Peter Maydell wrote: > On 12 May 2015 at 16:22, John Snow wrote: >> On 05/12/2015 06:44 AM, Peter Maydell wrote: >>> Doesn't build on 32-bit: >>> >>> /root/qemu/qtest.c: In function ‘qtest_process_command’: >>> /root/qemu/qtest.c:519:28: error: format ‘%zu’ expects argume

[Qemu-devel] [PULL v2 03/14] libqos: Add migration helpers

2015-05-12 Thread John Snow
libqos.c: -set_context for addressing which commands go where -migrate performs the actual migration malloc.c: - Structure of the allocator is adjusted slightly with a second-tier malloc to make swapping around the allocators easy when we "migrate" the lists from the source

[Qemu-devel] [PULL v2 14/14] qtest: pre-buffer hex nibs

2015-05-12 Thread John Snow
Instead of converting each byte one-at-a-time and then sending each byte over the wire, use sprintf() to pre-compute all of the hex nibs into a single buffer, then send the entire buffer all at once. This gives a moderate speed boost to memread() and memwrite() functions. Signed-off-by: John Snow

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-12 Thread Programmingkid
On May 12, 2015, at 3:45 AM, Paolo Bonzini wrote: > On 12/05/2015 00:43, Programmingkid wrote: >> >> On May 10, 2015, at 10:54 AM, Paolo Bonzini wrote: >> >>> >>> >>> On 06/05/2015 18:40, Programmingkid wrote: When I try to use the pcspk sound hardware, QEMU freezes and uses 100% of

[Qemu-devel] [PATCH v6 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-05-12 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce 10064

[Qemu-devel] [PATCH v6 2/7] vmport_rpc: Add the object vmport_rpc

2015-05-12 Thread Don Slutz
This is the 1st part of "Add limited support of VMware's hyper-call rpc". This patch uses existing infrastructure used by vmmouse.c (provided by vmport.c) to handle the VMware backdoor command 30. One of the better on-line references is: https://sites.google.com/site/chitchatvmback/backdoor Mor

[Qemu-devel] [PATCH v6 0/7] Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
Changes v5 to v6: Rebase to master Eric Blake Returning a non-dictionary is not extensible. Added new type VmportGuestInfoValue. s/VmportGuestInfo/VmportGuestInfoKey/ s/type/struct/ Issues with examples Fixed. Changes v4 to v5: Paolo Bonzini What is VM

[Qemu-devel] [PATCH v6 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
The support included is enough to allow VMware tools to install in a guest and provide guestinfo support. guestinfo support is provided by what is known as VMware RPC support. If the guest is running VMware tools, then the "build version" of the tools is also available via the property build-numb

[Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 268 +++

Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread John Snow
On 05/12/2015 02:35 PM, Eric Blake wrote: > On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: >> Add a simple test case for qemu-iotests that covers read/write >> with encrypted qcow2 files. >> >> Signed-off-by: Daniel P. Berrange --- >> tests/qemu-iotests/131 | 69 >>

[Qemu-devel] [PATCH v6 7/7] MAINTAINERS: add VMware port

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..6945d30d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -766,6 +766,13 @@ M: Jiri Pirko S: Maintained F: hw/net/rocker/ +VMware port +M: Don Slutz +S:

[Qemu-devel] [PATCH v6 6/7] vmport: Add VMware all ring hack

2015-05-12 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit 6d99c91fc9ae27b476e89a8cc880b4a46e2375

[Qemu-devel] [PATCH v6 5/7] vmport_rpc: Add migration

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 9a32c6f..fe9cfc5 100644 --- a/hw/misc/vmpo

Re: [Qemu-devel] [Qemu-block] [PATCH 03/34] quorum: Use bdrv_open_image()

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:35PM +0200, Kevin Wolf wrote: > Besides standardising on a single interface for opening child nodes, > this simplifies the .bdrv_open() implementation of the quorum block > driver by using block layer functionality for handling BlockdevRefs. > > Signed-off-by: Kevin W

Re: [Qemu-devel] [Qemu-block] [PATCH 04/34] vmdk: Use bdrv_open_image()

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:36PM +0200, Kevin Wolf wrote: > Besides standardising on a single interface for opening child nodes, > this patch allows the user to specify options to individual extent > nodes. Overriding file names isn't possible with this yet, so it's of > limited usefulness, but s

Re: [Qemu-devel] [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:37PM +0200, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > blockdev.c| 24 > include/block/block.h | 8 > 2 files changed, 20 insertions(+), 12 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index 5eaf77

Re: [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus command

2015-05-12 Thread Eduardo Habkost
On Tue, May 12, 2015 at 07:42:17PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > On Tue, May 12, 2015 at 05:38:37PM +0200, Markus Armbruster wrote: > > [...] > >> > @@ -699,8 +701,9 @@ > >> > #data is sent to the client, the guest may no longer be halted. > >> > ## > >> >

Re: [Qemu-devel] [PATCH 2/2] s390x: Add laa and laag instructions

2015-05-12 Thread Alexander Graf
On 05/12/2015 05:53 AM, Richard Henderson wrote: On 05/07/2015 06:12 PM, Alexander Graf wrote: +static ExitStatus op_laa(DisasContext *s, DisasOps *o) +{ +TCGv_i64 m2 = tcg_temp_new_i64(); + +/* XXX should be atomic */ +tcg_gen_qemu_ld32s(m2, o->in2, get_mem_index(s)); + +/* Set

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 19:17, Paolo Bonzini wrote: > On 12/05/2015 17:32, Peter Maydell wrote: >> In order for -icount to work, it's important for the target >> translate.c code to correctly bracket any generated code which >> can "do I/O" with gen_io_start()/gen_io_end() calls. But >> does anybody kno

Re: [Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Eric Blake
On 05/12/2015 01:03 PM, Don Slutz wrote: > This adds one new inject command: > > inject-vmport-action > > And three guest info commands: > > vmport-guestinfo-set > vmport-guestinfo-get > query-vmport-guestinfo > > More details in qmp-commands.hx > > Signed-off-by: Don Slutz > --- > +/* > + *

Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread Eric Blake
On 05/12/2015 01:06 PM, John Snow wrote: >>> tests/qemu-iotests/131 | 69 >>> ++ >>> tests/qemu-iotests/131.out | 46 +++ > > Fam Zheng already has a patch on-list that uses test 131, and I think > his patch was submitted

[Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-12 Thread John Snow
Bitmaps can be in a handful of different states with potentially more to come as we tool around with migration and persistence patches. Instead of having a bunch of boolean fields, it was suggested that we just have an enum status field that will help expose the reason to management APIs why certa

Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread John Snow
On 05/12/2015 03:52 PM, Eric Blake wrote: > On 05/12/2015 01:06 PM, John Snow wrote: tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++ > >> >> Fam Zheng already has a patch on-list

Re: [Qemu-devel] [PULL v2 00/14] Ide patches

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 19:46, John Snow wrote: > The following changes since commit 968bb75c348a401b85e08d5eb1887a3e6c3185f5: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20150512' into staging (2015-05-12 > 12:11:32 +0100) > > are ava

Re: [Qemu-devel] [PATCH 14/34] qcow2: Factor out qcow2_update_options()

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Eventually we want to be able to change options at runtime. As a first > step towards that goal, separate some option handling code from the > general initialisation code in qcow2_open(). > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 135 > +++

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-12 Thread Eric Blake
On 05/12/2015 01:53 PM, John Snow wrote: > Bitmaps can be in a handful of different states with potentially > more to come as we tool around with migration and persistence patches. > > Instead of having a bunch of boolean fields, it was suggested that we > just have an enum status field that will

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-12 Thread John Snow
On 05/12/2015 04:06 PM, Eric Blake wrote: > On 05/12/2015 01:53 PM, John Snow wrote: >> Bitmaps can be in a handful of different states with potentially >> more to come as we tool around with migration and persistence >> patches. >> >> Instead of having a bunch of boolean fields, it was suggest

Re: [Qemu-devel] [PATCH 15/34] qcow2: Move qcow2_update_options() call up

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > qcow2_update_options() only updates some variables in BDRVQcowState and > doesn't really depend on other parts of it being initialised yet, so it > can be moved so that it immediately follows the other half of option > handling code in qcow2_open(). > >

[Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Alexander Graf
We're currently missing the laa and laag instructions in our emulation. In fact, we're missing the complete "interlocked-access facility 1" which is part of zEC12. However, I really only needed the laa instruction for now. Signed-off-by: Alexander Graf --- This really should implement all the o

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Richard Henderson
On 05/12/2015 01:20 PM, Alexander Graf wrote: > +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o) > +{ > +/* XXX should reserve the address */ > +in2_m2_32s(s, f, o); > +} > +#define SPEC_in2_m2_32s_atomic 0 > + > +static void in2_m2_64_atomic(DisasContext *s, Dis

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Alexander Graf
On 05/12/2015 10:27 PM, Richard Henderson wrote: On 05/12/2015 01:20 PM, Alexander Graf wrote: +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o) +{ +/* XXX should reserve the address */ +in2_m2_32s(s, f, o); +} +#define SPEC_in2_m2_32s_atomic 0 + +static void i

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Alexander Graf
On 05/12/2015 10:27 PM, Richard Henderson wrote: On 05/12/2015 01:20 PM, Alexander Graf wrote: +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o) +{ +/* XXX should reserve the address */ +in2_m2_32s(s, f, o); +} +#define SPEC_in2_m2_32s_atomic 0 + +static void i

Re: [Qemu-devel] [PATCH 16/34] qcow2: Move rest of option handling to qcow2_update_options()

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > With this commit, the handling of driver-specific options in > qcow2_open() is completely separated out into qcow2_update_options(). > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 109 > +-

Re: [Qemu-devel] [PATCH 17/34] qcow2: Leave s unchanged on qcow2_update_options() failure

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > On return, either all new options should be applied to BDRVQcowState (on > success), or all of the old setting should be preserved (on failure). s/setting/settings/ > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 52

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Richard Henderson
On 05/12/2015 01:42 PM, Alexander Graf wrote: > > But wouldn't it really be "addr2"? This is the address source for the second > argument after all. Yes, but we already abuse the name. r~

Re: [Qemu-devel] [PATCH v2] s390x: Add laa and laag instructions

2015-05-12 Thread Richard Henderson
On 05/12/2015 01:46 PM, Alexander Graf wrote: > On 05/12/2015 10:27 PM, Richard Henderson wrote: >> On 05/12/2015 01:20 PM, Alexander Graf wrote: >>> +static void in2_m2_32s_atomic(DisasContext *s, DisasFields *f, DisasOps *o) >>> +{ >>> +/* XXX should reserve the address */ >>> +in2_m2_32s

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-12 Thread Sean O. Stalley
On Tue, May 12, 2015 at 11:33:49AM +0200, Michael S. Tsirkin wrote: > On Mon, May 11, 2015 at 01:08:05PM -0700, Sean O. Stalley wrote: > > On Mon, May 11, 2015 at 09:26:08PM +0200, Michael S. Tsirkin wrote: > > > On Mon, May 11, 2015 at 11:56:44AM -0700, Sean O. Stalley wrote: > > > > PCI Enhanced

Re: [Qemu-devel] [PATCH 18/34] qcow2: Fix memory leak in qcow2_update_options() error path

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

[Qemu-devel] [PATCH] monitor: print help for command errors

2015-05-12 Thread Bandan Das
Unlike machines, humans will be (mostly) appreciative on seeing help output when a command fails due to incorrect syntax or input. By default, print output of help_cmd() to the monitor in such cases. The only exceptions are if a command does not exist or parsing failed for some other reason. Befo

Re: [Qemu-devel] [PATCH 19/34] qcow2: Make qcow2_update_options() suitable for transactions

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > Before we can allow updating options at runtime with bdrv_reopen(), we > need to split the function into prepare/commit/abort parts. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 101 > ++

Re: [Qemu-devel] [PATCH 20/34] qcow2: Support updating driver-specific options in reopen

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > For updating the cache sizes or disabling lazy refcounts there is a bit > more to do than just changing the variables, but otherwise we're all set > for changing options during bdrv_reopen(). > > Just implement the missing pieces and hook the functions u

[Qemu-devel] [PATCH v3] s390x: Add interlocked access facility 1 instructions

2015-05-12 Thread Alexander Graf
We're currently missing all instructions defined by the "interlocked-access facility 1" which is part of zEC12. This patch implements all of them except for LPD and LPDG. Signed-off-by: Alexander Graf --- v1 -> v2: - move atomic specific bits into load/store helpers, leave actual op as n

Re: [Qemu-devel] [PATCH 21/34] block: Consider all block layer options in append_open_options

2015-05-12 Thread Eric Blake
On 05/08/2015 11:21 AM, Kevin Wolf wrote: > The code already special-cased "node-name", which is currently the only > option passed in the QDict that isn't driver-specific. Generalise the > code to take all general block layer options into consideration. > > Signed-off-by: Kevin Wolf > --- > blo

[Qemu-devel] [PATCH v2 1/5] include/softmmu-semi.h: Make semihosting support 64-bit clean

2015-05-12 Thread Leon Alrae
From: "Maciej W. Rozycki" Correct addresses passed around in semihosting to use a data type suitable for both 32-bit and 64-bit targets. Signed-off-by: Maciej W. Rozycki Signed-off-by: Leon Alrae --- include/exec/softmmu-semi.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(

[Qemu-devel] [PATCH v2 4/5] target-mips: add Unified Hosting Interface (UHI) support

2015-05-12 Thread Leon Alrae
Add UHI semihosting support for MIPS. QEMU run with "-semihosting" option will alter the behaviour of SDBBP 1 instruction -- UHI operation will be called instead of generating a debug exception. Also tweak Malta's pseudo-bootloader. On CPU reset the $4 register is set to -1 if semihosting argument

[Qemu-devel] [PATCH v2 2/5] hw/mips: Do not clear BEV for MIPS malta kernel load

2015-05-12 Thread Leon Alrae
From: Matthew Fortune The BEV flag controls whether the boot exception vector is still in place when starting a kernel. When cleared the exception vector at EBASE (or hard coded address of 0x8000) is used instead. The early stages of the linux kernel would benefit from BEV still being set t

[Qemu-devel] [PATCH v2 0/5] target-mips: add UHI semihosting support

2015-05-12 Thread Leon Alrae
Hi, This patch series introduces the Unified Hosting Interface support to QEMU. This is second version which uses new -semihosting-config arg and addresses Matthew's review comments. Regards, Leon v2: * use new -semihosting arg option, thus it applies on top of https://lists.gnu.org/archive/h

[Qemu-devel] [PATCH v2 5/5] target-mips: convert host to MIPS errno values when required

2015-05-12 Thread Leon Alrae
Convert only errno values which can be returned by system calls in mips-semi.c and are not generic to all archs. Signed-off-by: Leon Alrae --- target-mips/mips-semi.c | 44 +--- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/target-mips/mi

[Qemu-devel] [PATCH v2 3/5] target-mips: remove identical code in different branch

2015-05-12 Thread Leon Alrae
Signed-off-by: Leon Alrae --- target-mips/translate.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index a41fc98..94f17a9 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -1180

Re: [Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
On 05/12/15 15:50, Eric Blake wrote: > On 05/12/2015 01:03 PM, Don Slutz wrote: >> This adds one new inject command: >> >> inject-vmport-action >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinfo-get >> query-vmport-guestinfo >>vmport-guestinfo-get key=foo >> More de

[Qemu-devel] [PATCH 0/2] configure: increase glib requirement to 2.22

2015-05-12 Thread John Snow
As discussed during the QEMU 2.3 development freeze. == For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch glib-version-fix https://github.com/jnsnow/qemu/tree/glib-version-fix This version is tagged glib-version-fix-v1: https://github.com/jnsnow/qemu/releases

[Qemu-devel] [PATCH 1/2] configure: require glib 2.22

2015-05-12 Thread John Snow
This provides g_ptr_array_new_with_free_func, as well as a few other functions that we've been hacking around in glib-compat.h. Cleaning up the compatibility headers will come later. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- configure | 7 +-- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH 2/2] glib: remove stale compat functions

2015-05-12 Thread John Snow
Since we're bumping the version to 2.22+, remove the now-stale compat functions. Signed-off-by: John Snow --- include/glib-compat.h | 35 --- 1 file changed, 35 deletions(-) diff --git a/include/glib-compat.h b/include/glib-compat.h index 28d9f15..318e000 100644

[Qemu-devel] GSoC 2015: Enabling Mac OS 9 support in QEMU

2015-05-12 Thread Cormac O'Brien
Hi all, My name is Cormac O'Brien and I'm one of QEMU's student developers for Google Summer of Code 2015. My project goal is to have Mac OS 9 running on both the g3beige and mac99 machines by the end of the summer (it currently doesn't boot on either). I'll be working with Alexander Graf and Mark

[Qemu-devel] GSoC 2015 (Mac OS 9 support) report, week 2

2015-05-12 Thread Alexander Graf
[This Week] - Investigate MOL device tree further - There is also an interesting dump of what seems to be a MOL tree at http://josejx.net/mol/mol-stable/mollib/oftrees/oftree.nw.old (which has a commented out entry for "AAPL,debug" set to -1). The interesting parts I see he

[Qemu-devel] [PATCH 0/1] ahci: do not remap clb/fis unconditionally

2015-05-12 Thread John Snow
This continues the IOMMU fix from 2.3, where we should not attempt to remap the CLB or FIS RX buffers if the AHCI device is currently running. The same applies to migration: keep our mitts off these registers unless the device is supposed to be on. Does not impact backwards compatibility for the

[Qemu-devel] [PATCH 1/1] ahci: do not remap clb/fis unconditionally

2015-05-12 Thread John Snow
This continues the IOMMU fix from 2.3, where we should not attempt to remap the CLB or FIS RX buffers if the AHCI device is currently running. The same applies to migration: keep our mitts off these registers unless the device is supposed to be on. Does not impact backwards compatibility for the

[Qemu-devel] [PATCH 1/6] pci-assign: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/i386/kvm/pci-assign.c | 39 +-- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index 9db7c77..74d22f4 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/

[Qemu-devel] [PATCH 3/6] piix4: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/isa/piix4.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index d9522b1..2c59e91 100644 --- a/hw/isa/piix4.c +++ b/hw/isa/piix4.c @@ -34,6 +34,10 @@ typedef struct PIIX4State { PCIDevi

[Qemu-devel] [PATCH 5/6] xen_pt: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Cc: Stefano Stabellini Signed-off-by: Gonglei --- hw/xen/xen_pt.c | 10 +- hw/xen/xen_pt.h | 4 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index d095c08..6674974 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c

[Qemu-devel] [PATCH 2/6] piix: piix3 QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/pci-host/piix.c | 57 +- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 723836f..f0fe4a1 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-ho

[Qemu-devel] [PATCH 4/6] wdt_i6300esb: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/watchdog/wdt_i6300esb.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c index 4ebdbb8..cfa2b1b 100644 --- a/hw/watchdog/wdt_i6300esb.c +++ b/hw/watchdog/wdt_i63

[Qemu-devel] [PATCH 6/6] vt82c686: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/isa/vt82c686.c | 47 --- 1 file changed, 32 insertions(+), 15 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index b8197b1..bb6f6df 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@

Re: [Qemu-devel] [PATCH v3] s390x: Add interlocked access facility 1 instructions

2015-05-12 Thread Richard Henderson
On 05/12/2015 02:50 PM, Alexander Graf wrote: > We're currently missing all instructions defined by the "interlocked-access > facility 1" which is part of zEC12. This patch implements all of them except > for LPD and LPDG. > > Signed-off-by: Alexander Graf > > --- > > v1 -> v2: > > - move at

[Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Fam Zheng
Before, we only yield after initializing dirty bitmap, where the QMP command would return. That may take very long, and guest IO will be blocked. Add sleep points like the later mirror iterations. Signed-off-by: Fam Zheng --- block/mirror.c | 13 - 1 file changed, 12 insertions(+),

[Qemu-devel] [PATCH 0/6] pci/isa: QOMify

2015-05-12 Thread arei.gonglei
From: Gonglei Because DO_UPCAST() is long deprecated, let me do some cleanup work. Please review, thanks Cc: Michael S. Tsirkin Cc: Paolo Bonzini Gonglei (6): pci-assign: QOMify piix: piix3 QOMify piix4: QOMify wdt_i6300esb: QOMify xen_pt: QOMify vt82c686: QOMify hw/i386/kvm/p

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-12 Thread Programmingkid
On May 12, 2015, at 3:45 AM, Paolo Bonzini wrote: > On 12/05/2015 00:43, Programmingkid wrote: >> >> On May 10, 2015, at 10:54 AM, Paolo Bonzini wrote: >> >>> >>> >>> On 06/05/2015 18:40, Programmingkid wrote: When I try to use the pcspk sound hardware, QEMU freezes and uses 100% of

[Qemu-devel] Serial port passthrough for arm kvm

2015-05-12 Thread Lennart Sorensen
We are trying to pass a serial port through to an arm guest on kvm and the serial port is working for passing data, but is not setting the baud rate when the guest changes it. If I change the baud rate of the port from the host, then the baud rate is set correctly and data is passed through just f

Re: [Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Fam Zheng
On Tue, 05/12 13:52, Kevin Wolf wrote: > Am 12.05.2015 um 08:09 hat Fam Zheng geschrieben: > > For zero write, callers pass in NULL qiov (qemu-io "write -z" or > > scsi-disk "write same"). > > > > Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case > > for this bug, but it still

Re: [Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Fam Zheng
On Tue, 05/12 13:18, Stefan Hajnoczi wrote: > On Tue, May 12, 2015 at 02:09:31PM +0800, Fam Zheng wrote: > > +static int coroutine_fn bdrv_co_do_zero_pwritev(BlockDriverState *bs, > > +int64_t offset, > > +

[Qemu-devel] [PATCH v7 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-05-12 Thread Fam Zheng
v7: Add Kevin's rev-by in patch 1 and 3. Address Stefan's and Kevin's comments on patch 2: - Don't duplicate tracked_request_begin and tracked_request_end; - Don't forget to remove debug printf; - Call qemu_vfree unconditionally; - Don't serialize aligned part of the zero write

[Qemu-devel] [PATCH v7 1/3] Revert "block: Fix unaligned zero write"

2015-05-12 Thread Fam Zheng
This reverts commit fc3959e4669a1c2149b91ccb05101cfc7ae1fc05. The core write code already handles the case, so remove this duplication. Because commit 61007b316 moved the touched code from block.c to block/io.c, the change is manually reverted. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajno

[Qemu-devel] [PATCH v7 3/3] qemu-iotests: Test unaligned sub-block zero write

2015-05-12 Thread Fam Zheng
Test zero write in byte range 512~1024 for 4k alignment. Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf --- tests/qemu-iotests/033 | 13 + tests/qemu-iotests/033.out | 30 ++ 2 files changed, 43 insertions(+) diff --gi

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Wen Congyang
On 05/13/2015 11:11 AM, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. Do you have such case to reproduce it? If the disk image is too larger, and I think qemu doesn't cache al

[Qemu-devel] [PATCH v7 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Fam Zheng
For zero write, callers pass in NULL qiov (qemu-io "write -z" or scsi-disk "write same"). Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler fix would be in bdrv_co_do_pwritev which is the NULL dereference poi

[Qemu-devel] [PATCH] iscsi: Remove pointless runtime check of macro value

2015-05-12 Thread Fam Zheng
raw_bsd already has QEMU_BUILD_BUG_ON(BDRV_SECTOR_SIZE != 512), so iscsi should relax. Signed-off-by: Fam Zheng --- block/iscsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 8fca1d3..14e97a6 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1323

Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send

2015-05-12 Thread Jason Wang
On Thu, Apr 30, 2015 at 6:32 PM, Paolo Bonzini wrote: On 30/04/2015 10:59, Jason Wang wrote: +/* If !can_send, we will want to disable the read poll, but we still + * need the send completion callback to enable it again, which is a + * sign of peer becomi

Re: [Qemu-devel] [PATCH 0/4] semihosting: clean up and add --semihosting-config arg

2015-05-12 Thread Liviu Ionescu
> On 06 May 2015, at 19:12, Leon Alrae wrote: > > ... I'm going to follow up with UHI > patch series only. I don't have anything set up to test other > semihosting interfaces, thus I don't plan to do any changes in these > areas in near future. Therefore feel free to send your ARM semihosting >

Re: [Qemu-devel] [PATCH 1/1] Add support for PCI Enhanced Allocation "BARs"

2015-05-12 Thread Michael S. Tsirkin
On Tue, May 12, 2015 at 02:23:07PM -0700, Sean O. Stalley wrote: > On Tue, May 12, 2015 at 11:33:49AM +0200, Michael S. Tsirkin wrote: > > On Mon, May 11, 2015 at 01:08:05PM -0700, Sean O. Stalley wrote: > > > On Mon, May 11, 2015 at 09:26:08PM +0200, Michael S. Tsirkin wrote: > > > > On Mon, May 1

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Fam Zheng
On Wed, 05/13 13:17, Wen Congyang wrote: > On 05/13/2015 11:11 AM, Fam Zheng wrote: > > Before, we only yield after initializing dirty bitmap, where the QMP > > command would return. That may take very long, and guest IO will be > > blocked. > > Do you have such case to reproduce it? If the disk i

Re: [Qemu-devel] Supporting multiple CPU AddressSpaces and memory transaction attributes

2015-05-12 Thread Edgar E. Iglesias
On Tue, May 12, 2015 at 03:47:00PM +0100, Peter Maydell wrote: > Resurrecting a six month old thread (and starting with > a big long quote for context): > > On 8 September 2014 at 12:53, Peter Maydell wrote: > > On 7 September 2014 02:47, Edgar E. Iglesias > > wrote: > >> On Thu, Sep 04, 2014 a

[Qemu-devel] [PATCH v1 00/18] arm: Steps towards EL2 support round 3

2015-05-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Hi, This is round 3 of our series towards support for EL2 for AArch64. This series depends on Gregs exception target el infrastructure patch series that is not yet upstream. P0 - P2 are fixes without dependencies. P3 is probably something that should be fixed in Gregs

[Qemu-devel] [PATCH v1 01/18] target-arm: Correct accessfn for CNTP_{CT}VAL_EL0

2015-05-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 752a1da..20c4abb 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1381,6 +1381,7

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-12 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 12/05/2015 17:32, Peter Maydell wrote: > > In order for -icount to work, it's important for the target > > translate.c code to correctly bracket any generated code which > > can "do I/O" with gen_io_start()/ge

[Qemu-devel] [PATCH v1 02/18] target-arm: Correct accessfn for CNTV_TVAL_EL0

2015-05-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 20c4abb..7139ed2 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1392,6 +1392,7 @@ static const A

[Qemu-devel] [PATCH v1 03/18] target-arm: Remove unneeded '+'

2015-05-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 7139ed2..a4bab78 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1277,7 +1277,7 @

<    1   2   3