Re: [Qemu-devel] [Qemu-stable] About qemu-kvm branch

2015-09-15 Thread Fam Zheng
On Tue, 09/15 14:51, tseng gogo wrote: > Hi , > > Sorry in advance that I am not sure that if I ask this question here is > appropriate. I am new to use KVM and want to do some research in qemu-kvm > live migration. > > In my environment, I install centos 7.0 with rpm install qemu-kvm > 1

[Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support

2015-09-15 Thread Yuanhan Liu
Hi, Here is the updated patch set for enabling vhost-user multiple queue. This patch set introduces 2 more vhost user messages: VHOST_USER_GET_QUEUE_NUM, for querying how many queues the backend supports, and VHOST_USER_SET_VRING_ENABLE, for enabling/disabling a specific virt queue. Both of the

[Qemu-devel] [PATCH 3/7] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE

2015-09-15 Thread Yuanhan Liu
Quote from Michael: We really should rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE. Suggested-by: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 4 ++-- hw/net/vhost_net.c | 2 +- hw/virtio/vhost-user.c | 6 +++--- linux-headers/linux/vhost.h

[Qemu-devel] [PATCH 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement

2015-09-15 Thread Yuanhan Liu
So that we could let vhost_user_call to handle extented requests, such as VHOST_USER_GET/SET_PROTOCOL_FEATURES, instead of invoking vhost_user_read/write and constructing the msg again by ourself. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost-user.c | 38 ++

[Qemu-devel] [PATCH 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-09-15 Thread Yuanhan Liu
This is for querying how many queues the backend supports if it has mq support(when VHOST_USER_PROTOCOL_F_MQ flag is set from the quried protocol features). vhost_net_get_max_queues() is the interface to export that value, and to tell if the backend supports # of queues user requested, which is do

[Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang This patch is initially based a patch from Nikolay Nikolaev. Here is the latest version for adding vhost-user multiple queue support, by creating a nc and vhost_net pair for each queue. Qemu exits if find that the backend can't support number of requested queues(by provid

[Qemu-devel] [PATCH 1/2] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang This patch is initially based a patch from Nikolay Nikolaev. Here is the latest version for adding vhost-user multiple queue support, by creating a nc and vhost_net pair for each queue. What differs from last version is that this patch addresses two major concerns from Mi

[Qemu-devel] [PATCH 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang Add a new message, VHOST_USER_SET_VRING_ENABLE, to enable or disable a specific virt queue, which is similar to attach/detach queue for tap device. virtio driver on guest doesn't have to use max virt queue pair, it could enable any number of virt queue ranging from 1 to ma

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-15 Thread Gerd Hoffmann
> > Therefore, I'm not sure whether deleting the buffer is right here. Maybe > > OpenGL uses reference counting here, too, so it remembers that the > > buffer is still in use by the VAO, and so the glDeleteBuffers() > > operation will only decrease its refcount, but not actually end up > > deleting

[Qemu-devel] [PATCH 5/7] vhost: introduce vhost_backend_get_vq_index method

2015-09-15 Thread Yuanhan Liu
Minusing the idx with the base(dev->vq_index) for vhost-kernel, and then adding it back for vhost-user doesn't seem right. Here introduces a new method vhost_backend_get_vq_index() for getting the right vq index for following vhost messages calls. Suggested-by: Jason Wang Signed-off-by: Yuanhan L

[Qemu-devel] [PATCH 2/7] vhost-user: add protocol feature negotiation

2015-09-15 Thread Yuanhan Liu
From: "Michael S. Tsirkin" Support a separate bitmask for vhost-user protocol features, and messages to get/set protocol features. Invoke them at init. No features are defined yet. v2: leverage vhost_user_call for request handling -- Yuanhan Liu Signed-off-by: Michael S. Tsirkin Signed-off-b

Re: [Qemu-devel] [PATCH RFC 2/4] arm64: kvm: enable trapping of read access to regs in TID3 group

2015-09-15 Thread Tushar Jagad
Hi Shannon, On Tue, Sep 15, 2015 at 12:23:57PM +0800, Shannon Zhao wrote: > > > On 2015/9/9 16:38, Tushar Jagad wrote: > > This patch modifies the HCR_GUEST_FLAGS to enable trapping of > > non secure read to registers under the HCR_EL2.TID3 group to EL2. > > > > We emulate the accesses to capabil

Re: [Qemu-devel] [PATCH 12/17] target-openrisc: Enable m[tf]spr from user mode

2015-09-15 Thread Bastian Koppelmann
On 09/14/2015 07:11 PM, Richard Henderson wrote: On 09/13/2015 01:34 AM, Bastian Koppelmann wrote: Looking at the article, user mode seems to be optional, so I'm not against it, but it does look weird. How does ork1sim do it? It's haphazard. There are checks for supervisor in the l_mtspr and

Re: [Qemu-devel] [PATCH 5/9] virtio-gpu: add 3d mode and virgl rendering support.

2015-09-15 Thread Gerd Hoffmann
Hi, > > +virtio_gpu_cleanup_mapping_iov(res_iovs, num_iovs); > > Is res_iovs leaked here? Oops, yes. Moving the iov release to virtio_gpu_cleanup_mapping_iov (so things is symmetrical to virtio_gpu_create_mapping_iov which allocates it), that'll fix it. > > +pixels = s->current_curso

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or inet socket. It do

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 10:36 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Gonglei >>> --- >>> blockdev.c | 47 ++ >>> qapi/block

Re: [Qemu-devel] [PATCH RFC 2/4] arm64: kvm: enable trapping of read access to regs in TID3 group

2015-09-15 Thread Shannon Zhao
On 2015/9/15 15:18, Tushar Jagad wrote: > > Hi Shannon, > > On Tue, Sep 15, 2015 at 12:23:57PM +0800, Shannon Zhao wrote: >> >> >> On 2015/9/9 16:38, Tushar Jagad wrote: >>> This patch modifies the HCR_GUEST_FLAGS to enable trapping of >>> non secure read to registers under the HCR_EL2.TID3 gro

Re: [Qemu-devel] [PATCH 6/9] sdl2/opengl: add opengl context and scanout support

2015-09-15 Thread Gerd Hoffmann
Hi, > > +scon->scanout_mode = scanout; > > +if (!scon->scanout_mode) { > > +if (scon->fbo_id) { > > +glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, > > + GL_COLOR_ATTACHMENT0_EXT, > > + GL_TEXTUR

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:49 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 10:36 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c | 47 ++

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:37 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 11:47 PM, Eric Blake wrote: >>> On 09/14/2015 08:27 AM, Markus Armbruster wrote: Wen Congyang writes: > The NBD driver needs: filename, path or (host, port, exportname). > It checks which

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-09-15 Thread Vasiliy Tolstov
2015-06-15 10:07 GMT+03:00 Denis V. Lunev : > _PING_ Any news about this feature? I'm need to run inside guest some scripts and want non blocking exec, so this feature very useful for me. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-15 Thread Markus Armbruster
John Snow writes: > We're supposed to abort on transfers like this, unless we fill > Word 125 of our IDENTIFY data with a default transfer size, which > we don't currently do. > > This is an ATA error, not a SCSI/ATAPI one. > See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. Reading... yes, that's wha

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix issue for checking ptr in different address spaces in TARGET_CMSG_NXTHDR

2015-09-15 Thread Peter Maydell
On 15 September 2015 at 04:01, wrote: > From: Chen Gang > > After fix this issue, qemu can run i386 wine notepad.exe successfully. > But the initialization performance is not quite well. > > Signed-off-by: Chen Gang > --- > linux-user/syscall.c | 30 +- > linux

Re: [Qemu-devel] [PATCH v11 4/5] cpu/apic: drop icc bus/bridge

2015-09-15 Thread Igor Mammedov
On Tue, 15 Sep 2015 08:52:34 +0800 Zhu Guihua wrote: > > On 09/14/2015 09:18 PM, Igor Mammedov wrote: > > On Wed, 2 Sep 2015 17:36:21 +0800 > > Zhu Guihua wrote: > > > >> From: Chen Fan > >> > >> After CPU hotplug has been converted to BUS-less hot-plug infrastructure, > >> the only function I

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Kevin Wolf
Am 14.09.2015 um 20:49 hat John Snow geschrieben: > On 09/14/2015 02:43 PM, Michael Tokarev wrote: > > 14.09.2015 21:04, John Snow wrote: > >> On 09/11/2015 02:56 AM, Michael Tokarev wrote: > >>> 09.09.2015 19:28, John Snow wrote: > We're a little too lenient with what we'll let an ATAPI drive

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-09-15 Thread Vasiliy Tolstov
2015-09-15 11:15 GMT+03:00 Denis V. Lunev : > we have discussed new approach on KVM forum > with a bit reduced set (guest-pipe-open/close > code should not be in the first version) and in > progress with a rework. I think that I'll post new version > at the end of this week or next week. Ok, i'm

Re: [Qemu-devel] [PATCH 3/9] ui/console: add opengl context and scanout support interfaces.

2015-09-15 Thread Paolo Bonzini
On 09/09/2015 13:20, Gerd Hoffmann wrote: > +typedef void *qemu_gl_context; > + > +struct qemu_gl_params { > +int major_ver; > +int minor_ver; > +}; > + Please use QEMUGLContext and QEMUGLParams (with a typedef for the latter). Paolo

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-09-15 Thread Denis V. Lunev
On 09/15/2015 11:02 AM, Vasiliy Tolstov wrote: 2015-06-15 10:07 GMT+03:00 Denis V. Lunev : _PING_ Any news about this feature? I'm need to run inside guest some scripts and want non blocking exec, so this feature very useful for me. we have discussed new approach on KVM forum with a bit redu

Re: [Qemu-devel] [PATCH 5/9] virtio-gpu: add 3d mode and virgl rendering support.

2015-09-15 Thread Paolo Bonzini
On 09/09/2015 13:20, Gerd Hoffmann wrote: > + * This work is licensed under the terms of the GNU GPL, version 2. > + * See the COPYING file in the top-level directory. > + */ GPLv2-only contributions are not allowed anymore, please upgrade this file and hw/display/virtio-gpu*.c to v2+. Paolo

[Qemu-devel] [PATCH] pci-assign: do not include sys/io.h

2015-09-15 Thread Paolo Bonzini
This file does not exist on bionic libc and the functions it defines are in fact not used by pci-assign.c. Remove it. Reported-by: Houcheng Lin Signed-off-by: Paolo Bonzini --- hw/i386/kvm/pci-assign.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pc

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Alberto Garcia
On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: >> +{ 'command': 'x-child-add', >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > This is probably not future-proof and only made for the special case > of quorum. Specifically, one thing I'm missing is some way to specfiy > what kind

Re: [Qemu-devel] [PATCH] ppc/spapr: Allow VIRTIO_VGA

2015-09-15 Thread Gerd Hoffmann
On Di, 2015-09-15 at 15:51 +1000, Benjamin Herrenschmidt wrote: > It works fine with the Linux driver out of the box Do you actually want the vga compatibility bits on pseries? There also is virtio-gpu-pci (same thing as virtio-vga but without vga compatibility), which should already be enabled o

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Kevin Wolf
Am 15.09.2015 um 10:56 hat Alberto Garcia geschrieben: > On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: > > >> +{ 'command': 'x-child-add', > >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > > > This is probably not future-proof and only made for the special case > > of quorum. Sp

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

2015-09-15 Thread Gonglei
On 2015/9/15 14:33, Gonglei wrote: > On 2015/9/15 9:16, Gonglei wrote: >> On 2015/9/14 17:28, Paolo Bonzini wrote: >>> >>> >>> On 14/09/2015 10:01, Gonglei (Arei) wrote: [2015-09-11 13:42:44] domain is rebooting qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188: regi

[Qemu-devel] [PATCH 7/9] ioapic_internal.h: added more constants

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- include/hw/i386/ioapic_internal.h | 5 + 1 file changed, 5 insertions(+) diff --git a/incl

[Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. For command name uses "apic-local" because it has to be grouped with command "apic-io". (qemu) info apic-local apic.lvt00-timer 000300fd i

[Qemu-devel] [PATCH 4/9] apic_internal.h: fix formatting and drop unused consts

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzi

[Qemu-devel] [PATCH 1/9] apic_internal.h: move apic_get_bit(), apic_set_bit() to apic_internal.h

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin It's necessary to work with bitmap isr, tmr, irr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- hw/intc/apic.c | 16 include/hw/i386/apic_internal.h | 16 +

[Qemu-devel] [PATCH 2/9] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- hw/intc/apic.c

[Qemu-devel] [PATCH 9/9] hmp: implemented io apic dump state for TCG

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info apic-io" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- hw/intc/ioapic.c | 12 include/hw/i386/pc.h | 1 + target-i386/monitor.c | 2 ++ 3 files c

[Qemu-devel] [PATCH 3/9] apic_internal.h: added more constants

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin These constants are needed for optimal access to bit fields local apic registers without magic numbers. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- include/hw/i386/apic_internal.h | 54

[Qemu-devel] [PATCH 8/9] hmp: added io apic dump state

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query io apic state, may be usefull after guest crashes to understand IRQ routing in guest. Implementation is only for kvm here. The dump will look like (qemu) info apic-io ioapic ID=00 IRR= SEL=18 ioapic 00 000100ff: int=ff delmod=0:

[Qemu-devel] [PATCH 5/9] monitor: make monitor_fprintf and mon_get_cpu externally visible

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin monitor_fprintf and mon_get_cpu will be used in the target-specific monitor, so it is advisable to make it external. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini --- disas.c | 10 -- in

[Qemu-devel] [PATCH v2 0/9] hmp command IO- and Local APIC dump state

2015-09-15 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info apic-local apic.lvt00-timer 000300fd int=fd .H.EMP delmod=0:Fixed apic.lvt00-thermal 0001 int=00 .H.EM. delmod=0:Fixed apic.lvt

Re: [Qemu-devel] [Qemu-block] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Kevin Wolf
Am 15.09.2015 um 11:20 hat Kevin Wolf geschrieben: > Am 15.09.2015 um 10:56 hat Alberto Garcia geschrieben: > > On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: > > > > >> +{ 'command': 'x-child-add', > > >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > > > > > This is probably not

Re: [Qemu-devel] [PULL v2 00/23] Block layer patches

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 16:25, Kevin Wolf wrote: > The following changes since commit 2b750d9d261bda7f75b39dfc1e1e5f22502929d5: > > Merge remote-tracking branch 'remotes/aurel/tags/pull-sh4-next-20150913' > into staging (2015-09-14 10:46:38 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] target-mips: fix corner case in TLBWR causing QEMU to hang

2015-09-15 Thread Leon Alrae
On 14/09/15 20:21, Aurelien Jarno wrote: > Note that this patch conflicts with the following one, that we might > want to merge, even if the whole series is not ready: > > https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg01171.html Indeed, we should merge that patch as well. Thanks, Leon

Re: [Qemu-devel] [PATCH pic32 v3 02/16] pic32: use LCG algorithm for generated random index of TLBWR instruction

2015-09-15 Thread Leon Alrae
On 06/07/15 07:14, Serge Vakulenko wrote: > The LFSR algorithm, used for generating random TLB indexes for TLBWR > instruction, > was inclined to produce a degenerate sequence in some cases. > For example, for 16-entry TLB size and Wired=1, it gives: 15, 6, 7, 2, > 7, 2, 7, 2, 7, 2, 7, 2, 7, 2, 7,

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix issue for checking ptr in different address spaces in TARGET_CMSG_NXTHDR

2015-09-15 Thread Chen Gang
yes, foe me, they are the same. :-) Thanks. > From: peter.mayd...@linaro.org > Date: Tue, 15 Sep 2015 09:10:40 +0100 > Subject: Re: [PATCH] linux-user/syscall.c: Fix issue for checking ptr in > different address spaces in TARGET_CMSG_NXTHDR > To: gang.chen.5...@gmail.com > CC: riku.voi...@iki.f

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Stefano Stabellini
On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { > > -rc = pread(config_fd, (uint8_t *)&val, len, pos); > > +rc = read(config_fd, (ui

Re: [Qemu-devel] [PATCH v16 16/35] host-utils: Add revbit functions

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > include/qemu/host-utils.h | 77 > +++ > 1 file changed, 77 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v16 17/35] target-arm: Use new revbit functions

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-arm/helper-a64.c | 15 +-- > target-arm/helper.c | 12 +--- > 2 files changed, 2 insertions(+), 25 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > The crc instructions are omitted from this set. > > Signed-off-by: Richard Henderson > --- > target-tilegx/helper.c| 10 +++ > target-tilegx/helper.h| 2 ++ > target-tilegx/translate.c | 68 >

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
CC Konrad On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 19:15, Stefano Stabellini wrote: > > + > > +switch (reg->size) { > > +case 1: rc = xen_host_pci_get_byte(&s->real_device, offset, > > (uint8_t *)&val); > > A bit ugly, and it relies on the host being little endia

[Qemu-devel] [PATCH PULL v2 00/11] Extract TLS handling code from VNC server

2015-09-15 Thread Daniel P. Berrange
The following changes since commit 007e620a7576e4ce2ea6955541e87d8ae8ed32ae: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2015-09-14 18:51:09 +0100) are available in the git repository at: git://github.com/berrange/qemu.git tags/vnc-crypto-v8-for-upstream fo

[Qemu-devel] [PATCH PULL v2 04/11] qom: allow QOM to be linked into tools binaries

2015-09-15 Thread Daniel P. Berrange
The qom objects are currently added to common-obj-y which is only linked into the system emulators. The later crypto patches will depend on QOM infrastructure and will also be used from tools binaries. Thus the QOM objects are moved into a new qom-obj-y variable which can be referenced when linking

[Qemu-devel] [PATCH PULL v2 07/11] crypto: introduce new module for TLS x509 credentials

2015-09-15 Thread Daniel P. Berrange
Introduce a QCryptoTLSCredsX509 class which is used to manage x509 certificate TLS credentials. This will be the preferred credential type offering strong security characteristics Example CLI configuration: $QEMU -object tls-creds-x509,id=tls0,endpoint=server,\ dir=/path/to/creds/

[Qemu-devel] [PATCH PULL v2 01/11] qapi: allow override of default enum prefix naming

2015-09-15 Thread Daniel P. Berrange
The camel_to_upper() method applies some heuristics to turn a mixed case type name into an all-uppercase name. This is used for example, to generate enum constant name prefixes. The heuristics don't also generate a satisfactory name though. eg { 'enum': 'QCryptoTLSCredsEndpoint', 'data': ['

[Qemu-devel] [PATCH PULL v2 05/11] crypto: introduce new base module for TLS credentials

2015-09-15 Thread Daniel P. Berrange
Introduce a QCryptoTLSCreds class to act as the base class for storing TLS credentials. This will be later subclassed to provide handling of anonymous and x509 credential types. The subclasses will be user creatable objects, so instances can be created & deleted via 'object-add' and 'object-del' QM

[Qemu-devel] [PATCH PULL v2 09/11] crypto: introduce new module for handling TLS sessions

2015-09-15 Thread Daniel P. Berrange
Introduce a QCryptoTLSSession object that will encapsulate all the code for setting up and using a client/sever TLS session. This isolates the code which depends on the gnutls library, avoiding #ifdefs in the rest of the codebase, as well as facilitating any possible future port to other TLS librar

[Qemu-devel] [PATCH PULL v2 02/11] tests: remove repetition in unit test object deps

2015-09-15 Thread Daniel P. Berrange
Most of the unit tests have identical sets of object deps. For example all block unit tests need to depend on $(block-obj-y) libqemuutil.a libqemustub.a Currently each unit test repeats this list of test deps. This list of deps will grow as future patches add more modules to the build, so define

[Qemu-devel] [PATCH PULL v2 08/11] crypto: add sanity checking of TLS x509 credentials

2015-09-15 Thread Daniel P. Berrange
If the administrator incorrectly sets up their x509 certificates, the errors seen at runtime during connection attempts are very obscure and difficult to diagnose. This has been a particular problem for people using openssl to generate their certificates instead of the gnutls certtool, because the

[Qemu-devel] [PATCH PULL v2 10/11] ui: fix return type for VNC I/O functions to be ssize_t

2015-09-15 Thread Daniel P. Berrange
Various VNC server I/O functions return 'long' and then also pass this to a method accepting 'int'. All these should be ssize_t to match the signature of read/write APIs and thus avoid potential for integer truncation / wraparound. Signed-off-by: Daniel P. Berrange Reviewed-by: Eric Blake --- u

[Qemu-devel] [PATCH PULL v2 03/11] crypto: move crypto objects out of libqemuutil.la

2015-09-15 Thread Daniel P. Berrange
Future patches will be adding more crypto related APIs which rely on QOM infrastructure. This creates a problem, because QOM relies on library constructors to register objects. When you have a file in a static .a library though which is only referenced by a constructor the linker is dumb and will d

[Qemu-devel] [PATCH PULL v2 06/11] crypto: introduce new module for TLS anonymous credentials

2015-09-15 Thread Daniel P. Berrange
Introduce a QCryptoTLSCredsAnon class which is used to manage anonymous TLS credentials. Use of this class is generally discouraged since it does not offer strong security, but it is required for backwards compatibility with the current VNC server implementation. Simple example CLI configuration:

[Qemu-devel] [PATCH PULL v2 11/11] ui: convert VNC server to use QCryptoTLSSession

2015-09-15 Thread Daniel P. Berrange
Switch VNC server over to using the QCryptoTLSSession object for the TLS session. This removes the direct use of gnutls from the VNC server code. It also removes most knowledge about TLS certificate handling from the VNC server code. This has the nice effect that all the CONFIG_VNC_TLS conditionals

Re: [Qemu-devel] [PATCH v3] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-15 Thread Amit Shah
On (Tue) 15 Sep 2015 [14:26:06], David Gibson wrote: > On Mon, Sep 14, 2015 at 08:32:36AM +0200, Thomas Huth wrote: > > On 14/09/15 04:15, David Gibson wrote: > > > On Fri, Sep 11, 2015 at 11:17:01AM +0200, Thomas Huth wrote: > > >> The PAPR interface defines a hypercall to pass high-quality > > >>

Re: [Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-15 Thread Paolo Bonzini
On 15/09/2015 11:23, Denis V. Lunev wrote: > From: Pavel Butsykin > > Added the hmp command to query local apic registers state, may be > usefull after guest crashes to understand IRQ routing in guest. > > For command name uses "apic-local" because it has to be grouped with > command "apic-io"

Re: [Qemu-devel] [PATCH] migration: Use g_new() & friends where that makes obvious sense

2015-09-15 Thread Amit Shah
On (Mon) 14 Sep 2015 [13:51:31], Markus Armbruster wrote: > g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, > for two reasons. One, it catches multiplication overflowing size_t. > Two, it returns T * rather than void *, which lets the compiler catch > more type errors. > > T

Re: [Qemu-devel] [PULL 0/4] update to 35c53797 to 4e03af8

2015-09-15 Thread Gerd Hoffmann
On Do, 2015-09-03 at 14:32 +0100, Peter Maydell wrote: > On 3 September 2015 at 14:02, Gerd Hoffmann wrote: > > Hi, > > > > Here comes the ipxe update pull. Thanks to Stefan all bits are upstream > > now. Also upstream has a named configuration for qemu. That simplifies > > the whole process,

[Qemu-devel] [PULL 0/6] gtk: misc grab tweaks, locale fix.

2015-09-15 Thread Gerd Hoffmann
(2015-09-14 18:51:09 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-gtk-20150915-1 for you to fetch changes up to 2cb5d2a47c655331bcf0ab16bab8fe4701182c58: gtk: use setlocale() for LC_MESSAGES only (2015-09-15 12:2

[Qemu-devel] [PULL 6/6] gtk: use setlocale() for LC_MESSAGES only

2015-09-15 Thread Gerd Hoffmann
From: Alberto Garcia The QEMU code is not internationalized and assumes that it runs under the C locale, but if we use the GTK+ UI we'll end up importing the locale settings from the environment. This can break things, such as the JSON generator and iotest 120 in locales that use a decimal comma.

[Qemu-devel] [PULL 3/6] gtk: trace input grab reason

2015-09-15 Thread Gerd Hoffmann
Add a reason to grab calls and trace points, so it is easier to debug grab related ui issues. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- trace-events | 3 ++- ui/gtk.c | 26 +- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/tra

Re: [Qemu-devel] [PATCH 8/9] hmp: added io apic dump state

2015-09-15 Thread Paolo Bonzini
On 15/09/2015 11:23, Denis V. Lunev wrote: > > Implementation is only for kvm here. The dump will look like > (qemu) info apic-io > ioapic ID=00 IRR= SEL=18 > ioapic 00 000100ff: int=ff delmod=0:Fixed P.H.EM dest=0 > ioapic 01 03000993: int=93 delmod=1:LowPri L.H.E. dest

[Qemu-devel] [PULL 1/6] gtk: check for existing grabs in gd_grab_{pointer, keyboard}

2015-09-15 Thread Gerd Hoffmann
If a grab is already active for our window, do nothing. If a grab is already active for another window, release it. Cleanup some checks and ungrab calls in the code which are not needed any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- ui/gtk.c | 25

[Qemu-devel] [PULL 5/6] gtk: don't grab input when entering fullscreen.

2015-09-15 Thread Gerd Hoffmann
Kick off all grabbing logic from fullscreen mode. In the current state it seems to create more problems than it solves. Try running qemu/gtk fullscreen on one head of a multihead host for example ... There probably was a reason the grab-on-fullscreen logic was added in the first place. So pleas

[Qemu-devel] [PULL 4/6] gtk: set free_scale when setting zoom_fit

2015-09-15 Thread Gerd Hoffmann
free_scale field tracks zoom-fit menu toggle state, so we should keep them in sync ... Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- ui/gtk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/gtk.c b/ui/gtk.c index 322d112..2629d97 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@

[Qemu-devel] [PULL 2/6] gtk: move gd_update_caption calls to gd_{grab, ungrab}_{pointer, keyboard}

2015-09-15 Thread Gerd Hoffmann
Then we don't have to pair the grab/ungrab calls with update_caption calls any more because things happen automatically ;) Signed-off-by: Gerd Hoffmann Reviewed-by: Marc-André Lureau --- ui/gtk.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c in

Re: [Qemu-devel] [PATCH RFC 0/3] Checkpoint-assisted migration proposal

2015-09-15 Thread Amit Shah
Hi, On (Fri) 17 Apr 2015 [14:12:59], Bohdan Trach wrote: > From: Bohdan Trach > > This patchset contains a checkpoint-assisted migration feature as > proposed earlier on this list [1]. It allows reusing existing memory > snapshots of guests to speed up migration of VMs between physical > hosts.

Re: [Qemu-devel] [PATCH 1/5] migration/ram.c: Use RAMBlock rather than MemoryRegion

2015-09-15 Thread Amit Shah
On (Thu) 13 Aug 2015 [11:51:30], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > RAM migration mainly works on RAMBlocks but in a few places > uses data from MemoryRegions to access the same information that's > already held in RAMBlocks; clean it up just to avoid the > M

Re: [Qemu-devel] [PATCH COLO-Frame v9 00/32] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2015-09-15 Thread zhanghailiang
Ping again ... On 2015/9/2 16:22, zhanghailiang wrote: This is the 9th version of COLO. Please Note that, this version is very different from the previous versions. since we have decided to realize proxy in qemu, which based on slirp in qemu. We dropped all the original colo proxy related part.

Re: [Qemu-devel] [PATCH v16 02/35] linux-user: Support tilegx architecture in linux-user

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > From: Chen Gang > > Add main working flow feature, system call processing feature, and elf64 > tilegx binary loading feature, based on Linux kernel tilegx 64-bit > implementation. > > [rth: Moved all of the implementation of atomic instruc

Re: [Qemu-devel] [PATCH v7 09/26] qapi: De-duplicate enum code generation

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:40PM +0200, Markus Armbruster wrote: > Duplicated in commit 21cd70d. Yes, we can't import qapi-types, but > that's no excuse. Move the helpers from qapi-types.py to qapi.py, and > replace the duplicates in qapi-event.py. > > The generated event enumeration type's lo

Re: [Qemu-devel] [PATCH v16 32/35] target-tilegx: Handle atomic instructions

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > +static void do_exch(CPUTLGState *env, bool quad, bool cmp) > +{ > +target_ulong addr; > +target_long val, sprval; > + > +start_exclusive(); > + > +addr = env->atomic_srca; > +i

Re: [Qemu-devel] [PATCH v7 10/26] qapi-event: Eliminate global variable event_enum_value

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:41PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-event.py | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com

Re: [Qemu-devel] [PATCH v7 12/26] qapi: Replace dirty is_c_ptr() by method c_null()

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:43PM +0200, Markus Armbruster wrote: > is_c_ptr() looks whether the end of the C text for the type looks like > a pointer. Works, but is fragile. > > We now have a better tool: use QAPISchemaType method c_null(). The > initializers for non-pointers become prettier:

Re: [Qemu-devel] [edk2] Windows does not support DataTableRegion at all [was: docs: describe QEMU's VMGenID design]

2015-09-15 Thread Laszlo Ersek
On 09/14/15 23:12, Bill Paul wrote: [snip -- see my other email too] > Also, if you want to talk business cases, I'm assuming that somewhere > Microsoft claims ACPI compliance. Correct; this page: states

Re: [Qemu-devel] [edk2] Windows does not support DataTableRegion at all [was: docs: describe QEMU's VMGenID design]

2015-09-15 Thread Laszlo Ersek
On 09/14/15 19:23, Walz, Michael C wrote: > Who are the Microsoft representatives in the ASWG? Shouldn't this > conversation be happening with them? I asked my colleague Al Stone @RH for help; he said he'd bring this up at the next ASWG meeting. Thank you Al, and thank you Michael for the suggest

Re: [Qemu-devel] [PATCH v7 13/26] qapi: Clean up after recent conversions to QAPISchemaVisitor

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use mor

Re: [Qemu-devel] [PATCH v7 14/26] qapi-visit: Rearrange code a bit

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:45PM +0200, Markus Armbruster wrote: > Move gen_visit_decl() to a better place. Inline > generate_visit_struct_body(). > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-visit.py | 50 ---

Re: [Qemu-devel] [PATCH v7 15/26] qapi-commands: Rearrange code

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:46PM +0200, Markus Armbruster wrote: > Rename gen_marshal_input() to gen_marshal(), because the generated > function marshals both arguments and results. > > Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and > move the other variable declarations t

Re: [Qemu-devel] [PATCH v7 16/26] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO()

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:47PM +0200, Markus Armbruster wrote: > These functions marshal both input and output. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > docs/qapi-code-gen.txt| 4 +- > docs/writing-qmp-commands.txt | 8 +- > monitor.c

Re: [Qemu-devel] [PATCH v7 17/26] qapi: De-duplicate parameter list generation

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:48PM +0200, Markus Armbruster wrote: > Generated qapi-event.[ch] lose line breaks. No change otherwise. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > scripts/qapi-commands.py | 11 ++- > scripts/qapi-event.py| 18 +++---

Re: [Qemu-devel] [PATCH v7 00/11] Fix exceptions handling for MIPS, PowerPC, and i386

2015-09-15 Thread Aurelien Jarno
On 2015-09-14 15:55, Richard Henderson wrote: > On 07/10/2015 02:56 AM, Pavel Dovgalyuk wrote: > >Pavel Dovgalyuk (11): > > softmmu: add helper function to pass through retaddr > > softmmu: remove now unused functions > > cpu-exec: introduce loop exit with restore function > > Th

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Paolo Bonzini
On 15/09/2015 11:55, Stefano Stabellini wrote: > On Mon, 14 Sep 2015, Paolo Bonzini wrote: >> > On 10/09/2015 12:29, Stefano Stabellini wrote: >>> > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { >>> > > +return -errno; >>> > > +} >>> > > do { >>> > > -rc = pread(co

Re: [Qemu-devel] [PATCH v7 18/26] qapi-commands: De-duplicate output marshaling functions

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:49PM +0200, Markus Armbruster wrote: > gen_marshal_output() uses its parameter name only for name of the > generated function. Name it after the type being marshaled instead of > its caller, and drop duplicates. > > Saves 7 copies of qmp_marshal_output_int() in qemu-

Re: [Qemu-devel] [PATCH v16 35/35] target-tilegx: Handle v1shl, v1shru, v1shrs

2015-09-15 Thread Peter Maydell
On 14 September 2015 at 23:43, Richard Henderson wrote: > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 2/5] Split out end of migration code from migration_thread

2015-09-15 Thread Amit Shah
On (Thu) 13 Aug 2015 [11:51:31], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The code that gets run at the end of the migration process > is getting large, and I'm about to add more for postcopy. > Split it into a separate function. > > Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/15/2015 03:37 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/14/2015 11:47 PM, Eric Blake wrote: On 09/14/2015 08:27 AM, Markus Armbruster wrote: > Wen Congyang writes: > >> The NBD driver needs: filename, path or (host, port, ex

Re: [Qemu-devel] [PATCH v7 19/26] qapi: Improve built-in type documentation

2015-09-15 Thread Daniel P. Berrange
On Mon, Sep 14, 2015 at 07:57:50PM +0200, Markus Armbruster wrote: > Clarify how they map to JSON. Add how they map to C. Fix the > reference to StringInputVisitor. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > docs/qapi-code-gen.txt | 29 ++---

  1   2   3   4   >