Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

> My understanding of the config file you proposed is that it would allow the > configuration of a whitelist, so changes to the config very could result in > *less* strict of a filter, not always more. No. Any time an administrator wants a syscall that is not enabled in the sandbox, they either

Re: [Qemu-devel] [PATCH] e1000: use alias for default model

On 09/28/2015 04:57 PM, Markus Armbruster wrote: > Jason Wang writes: > >> Instead of using a new type for default model (82540em), using an >> alias for this to avoid bit duplication. > Suggest to rephrase as > > Instead of duplicating the "e1000-82540em" device model

[Qemu-devel] [PATCH v6 06/16] qapi: Avoid assertion failure on union 'type' collision

The previous commit added two tests that triggered an assertion failure. It's fairly straightforward to avoid the failure by just outright forbidding the collision between a union's tag values and its discriminator name (including the implicit name 'kind' supplied for simple unions [*]).

Re: [Qemu-devel] [PATCH v5 11/46] qapi: Don't use info as witness of implicit object type

On 09/28/2015 06:43 AM, Markus Armbruster wrote: > Eric Blake writes: > >> A future patch will enable error reporting from the various >> check() methods. But to report an error on an implicit type, >> we'll need to associate a location with the type (the same >> location as

Re: [Qemu-devel] [PATCH v2] Add argument filters to the seccomp sandbox

On Monday, September 28, 2015 05:34:53 PM Namsun Ch'o wrote: > > To be clear, I'm not suggesting "--enable-syscalls=foo,bar,...", what I'm > > suggesting is a decomposition of the current filter list into blocks of > > syscalls that are needed to enable specific functionality. For example, > > if

Re: [Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

I sent the patch some days ago and received no response. I have no idea if this means the patch is not Ok or just no one had interest in it... Sincerely. Guangmu Zhu -- FreeWriterMetadata() should be called if GatherWriterMetadata() succeeded.

[Qemu-devel] [PATCH v6 05/16] qapi: Test for various name collisions

Expose some weaknesses in the generator: we don't always forbid the generation of structs that contain multiple members that map to the same C name. This has already been marked FIXME in qapi.py in commit d90675f, but having more tests will make sure future patches produce desired behavior. This

[Qemu-devel] [PATCH v6 10/16] qapi: Consistent generated code: prefer error 'err'

We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is patch 1/4, focusing on naming the local error variable 'err' rather than 'local_err'. No change

[Qemu-devel] [PATCH v6 04/16] qapi: Clean up qapi.py per pep8

Silence pep8, and make pylint a bit happier. Just style cleanups, plus killing a useless comment in camel_to_upper(); no semantic changes. Signed-off-by: Eric Blake --- v6: split off non-style changes, add in ordereddict.py, and rework the camel_to_upper conditional ---

[Qemu-devel] [PATCH v6 00/16] post-introspection cleanups, subset A

Finally no pending prerequisites; this is based on current qemu.git. Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv6a and I plan forcefully update my branch with the rest of the v5 series tomorrow, at:

Re: [Qemu-devel] [PATCH v5 00/46] post-introspection cleanups, and qapi-ify netdev_add

On 09/28/2015 07:07 AM, Markus Armbruster wrote: > I think the first ten patches are a about as large a bite as we can chew > and commit quickly. If you split them off, I can try to get them in > quickly, and in parallel continue reviewing the rest of your series. Done. Well, the first 10

[Qemu-devel] [PATCH v6 08/16] qapi: Test use of 'number' within alternates

Add some testsuite exposure for use of a 'number' as part of an alternate. The current state of the tree has a few bugs exposed by this: our input parser depends on the ordering of how the qapi schema declared the alternate, and the parser does not accept integers for a 'number' in an alternate

Re: [Qemu-devel] Problems on vlan-based vnics!

On 09/28/2015 07:52 PM, cauchy-love wrote: > hi stefan. >I have setup a VM on a server with two NICs (eth0 and eth1). eth0 is > connected with vlan22 and eth1 is connected with vlan33. I then added eth0.22 > to br2 and eth1.33 to br3. after that tap2 and tap3 were added to br2 and > br3

[Qemu-devel] [PATCH v6 02/16] qapi: Improve 'include' error message

Use of '"...%s" % include' to print non-strings can lead to ugly messages, such as this (if the .json change is applied without the qapi.py change): Expected a file name (string), got: OrderedDict() Better is to just omit the actual non-string value in the message. Signed-off-by: Eric Blake

[Qemu-devel] [PATCH v6 03/16] qapi: Invoke exception superclass initializer

pylint recommends that every exception class should explicitly invoke the superclass __init__, even though things seem to work fine without it. Signed-off-by: Eric Blake --- v6: split off of 2/26 --- scripts/qapi.py | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v5 12/46] qapi: Track location that created an implicit type

On 09/28/2015 06:56 AM, Markus Armbruster wrote: > Eric Blake writes: > >> A future patch will enable error detection in the various >> QapiSchema check() methods. But since all errors have to >> have an associated 'info' location, we need a location to >> be associated with

Re: [Qemu-devel] [PATCH 2/3] target-i386: initialize vcpu's TSC rate to the value from KVM

On Tue, Sep 29, 2015 at 09:23:39AM +0800, Haozhong Zhang wrote: > On Mon, Sep 28, 2015 at 01:17:44PM -0300, Eduardo Habkost wrote: > > On Mon, Sep 28, 2015 at 01:38:30PM +0800, Haozhong Zhang wrote: > > > When creating a vcpu, we initialize its TSC rate to the value from > > > KVM (through ioctl

Re: [Qemu-devel] [PATCH 2/3] target-i386: initialize vcpu's TSC rate to the value from KVM

On Mon, Sep 28, 2015 at 01:17:44PM -0300, Eduardo Habkost wrote: > On Mon, Sep 28, 2015 at 01:38:30PM +0800, Haozhong Zhang wrote: > > When creating a vcpu, we initialize its TSC rate to the value from > > KVM (through ioctl KVM_GET_TSC_KHZ). > > > > Signed-off-by: Haozhong Zhang

[Qemu-devel] [PATCH v6 11/16] qapi: Consistent generated code: prefer visitor 'v'

We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is patch 2/4, focusing on naming the local visitor variable 'v' rather than 'm'. Related objects,

Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications

On Mon, Sep 28, 2015 at 10:59:03AM +0200, Paolo Bonzini wrote: > > > On 26/09/2015 08:54, David Gibson wrote: > > On Fri, Sep 25, 2015 at 02:04:14PM +0200, Paolo Bonzini wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 > >> > >> > >> > >> On 25/09/2015 13:33, David Gibson wrote: >

[Qemu-devel] [PATCH v6 16/16] qapi: Share gen_visit_fields()

Consolidate the code between visit, command marshalling, and event generation that iterates over the members of a struct. It reduces code duplication in the generator, so that a future patch can reduce the size of generated code while touching only one instead of three locations. There are no

[Qemu-devel] [PATCH v6 12/16] qapi: Consistent generated code: prefer common labels

We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is patch 3/4, focusing on naming the goto labels 'out' (not 'clean') and 'out_obj' (not 'out_end').

[Qemu-devel] [Bug 1500175] Re: unable to init msix vectors

None of QEMU's ARM boards automatically boot a bios image shipped with QEMU. You must provide one explicitly, or else use the 'built in bootloader" with -kernel. (I'm not aware of any rom image that would work on QEMU versatilepb and load a kernel off a disk image, so in practice -kernel is what

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

On 09/28/2015 03:32 PM, Jeff Cody wrote: > I guess that makes sense. What about the case when the target is a raw > device without zero init? There is no backing file... Of course, perhaps > in the raw case the user should be using sync==full anyways. > >> >> 2) even with mode == "existing"

Re: [Qemu-devel] [PATCH 3/3] kvm-all: notice KVM of vcpu's TSC rate after migration

On Mon, Sep 28, 2015 at 01:37:34PM -0300, Eduardo Habkost wrote: > On Mon, Sep 28, 2015 at 01:38:31PM +0800, Haozhong Zhang wrote: > > When a vcpu is created in KVM, its TSC rate is initially identical to > > the host TSC rate. If its state is migrated to a vcpu on another > > machine (target

[Qemu-devel] [PATCH v6 01/16] qapi: Sort qapi-schema tests

Recent changes to qapi have provided quite a bit of churn in the makefile, because we are inconsistent on what order test names appear in, and on whether to re-wrap the list of tests or just add arbitrary line lengths. Writing the list in a sorted fashion, one test per line, will make future

[Qemu-devel] [PATCH v6 07/16] qapi: Add tests for empty unions

The documentation claims that alternates are useful for allowing two types, although nothing enforces this. Meanwhile, it is silent on whether empty unions are allowed. In practice, the generated code will compile, in part because we have a 'void *data' branch; but attempting to visit such a

[Qemu-devel] [PATCH v6 09/16] qapi: Reuse code for flat union base validation

Rather than open-code the check for a valid base type, we should reuse the common functionality. This allows for consistent error messages, and also makes it easier for a later patch to turn on support for inline anonymous base structures. Test flat-union-inline is updated to test only one

[Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage

We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This patch makes no difference to the generated code, but rather focuses on reducing the number of

[Qemu-devel] [PATCH v6 15/16] qapi: Share gen_err_check()

qapi-commands had a nice helper gen_err_check(), but did not use it everywhere. In fact, using it in more places makes it easier to reduce the lines of code used in appending an error check in generated code (previously required a multi-line mcgen(), which didn't add any use of parameterization),

[Qemu-devel] [PATCH v6 13/16] qapi: Consistent generated code: prefer common indentation

We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is patch 4/4, focusing on adjusting gen_visit_union() to use the same indentation as other

Re: [Qemu-devel] [PATCH v5 12/46] qapi: Track location that created an implicit type

Eric Blake writes: > A future patch will enable error detection in the various > QapiSchema check() methods. But since all errors have to > have an associated 'info' location, we need a location to > be associated with all implicit types. Easiest is to reuse > the location

Re: [Qemu-devel] [PATCH 16/16] block: Remove bdrv_swap()

On Thu 17 Sep 2015 03:48:20 PM CEST, Kevin Wolf wrote: > bdrv_swap() is unused now. Remove it and all functions that have > no other users than bdrv_swap(). In particular, this removes the > .bdrv_rebind callbacks from block drivers. > > Signed-off-by: Kevin Wolf Reviewed-by:

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers

Hi, On Thu, Sep 03, 2015 at 07:27:26AM +0200, Jonathan Neuschäfer wrote: > Currently, __target_cmsg_nxthdr compares a pointer derived from > target_cmsg against the msg_control field of target_msgh (through > subtraction). This failed for me when emulating i386 code under x86_64, > because

[Qemu-devel] [RFC PATCH 5/6] kvm_arm: Implement support for ITS emulation by KVM

This patch relies on new kernel API which is not released yet. Signed-off-by: Pavel Fedin --- hw/intc/Makefile.objs | 1 + hw/intc/arm_gicv3_its_kvm.c | 88 + 2 files changed, 89 insertions(+) create mode 100644

[Qemu-devel] [RFC PATCH 4/6] kvm: Implement passing device ID to MSI routing functions

Routing add/update functions now take additional PCIDevice pointer. Also, in order to provide backwards compatibility with older kernels, a new kvm_msi_flags global variable is provided, and machines, wishing to use new MSI features, must set appropriates flags in it. Signed-off-by: Pavel Fedin

[Qemu-devel] MTTCG sync-up call summary 28/09/2015

Here follows a slightly abbreviated form of my notes for the sync-up call. Please reply if anything is missing on unclear ;-) - Alvise has posted v5 addressing Paolo's comments - bitmap addresses TLB size issues - consensus we can go with Alvise's and build on them with ideas from Emilo's

[Qemu-devel] [PATCH] target-tilegx: Check zero dest register for ld instructions

From: Chen Gang At present, qemu x86_64 host backend can not remove the related dummy instructions. Even the worse, sometimes, it will generate the incorrect instructions which will cause segment fault for prefetch_l3 instruction. Signed-off-by: Chen Gang

Re: [Qemu-devel] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category

On 26/09/15 18:22, Laurent Vivier wrote: > macio-ide is an IDE controller, so add it > to the storage category. > > Signed-off-by: Laurent Vivier > --- > hw/ide/macio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ide/macio.c b/hw/ide/macio.c > index

Re: [Qemu-devel] [PATCH 09/10][TRIVIAL] macio-nvram: add to misc category

On 26/09/15 18:22, Laurent Vivier wrote: > The macio nvram is a non volatile RAM, so add it > the misc category. > > Signed-off-by: Laurent Vivier > --- > hw/nvram/mac_nvram.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/nvram/mac_nvram.c

Re: [Qemu-devel] [PATCH 10/10][TRIVIAL] openpic: add to misc category

On 26/09/15 18:22, Laurent Vivier wrote: > openpic is a programmable interrupt controller, so > add it to the misc category. > > Signed-off-by: Laurent Vivier > --- > hw/intc/openpic.c | 1 + > hw/intc/openpic_kvm.c | 1 + > 2 files changed, 2 insertions(+) > > diff

Re: [Qemu-devel] [PATCH 03/10][TRIVIAL] escc: add to input category

On 26/09/15 18:22, Laurent Vivier wrote: > ESCC is a serial port controller, so add it > to the input category. > > Signed-off-by: Laurent Vivier > --- > hw/char/escc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/char/escc.c b/hw/char/escc.c > index

[Qemu-devel] [PATCH 1/1] migration: fix deadlock

Release qemu global mutex before call synchronize_rcu(). synchronize_rcu() waiting for all readers to finish their critical sections. There is at least one critical section in which we try to get QGM (critical section is in address_space_rw() and prepare_mmio_access() is trying to aquire QGM).

Re: [Qemu-devel] [PATCH 08/16] block: Manage backing file references in bdrv_set_backing_hd()

On Thu 17 Sep 2015 03:48:12 PM CEST, Kevin Wolf wrote: > --- a/block/stream.c > +++ b/block/stream.c > @@ -55,28 +55,7 @@ static int coroutine_fn stream_populate(BlockDriverState > *bs, > static void close_unused_images(BlockDriverState *top, BlockDriverState > *base, >

Re: [Qemu-devel] [PATCH 12/16] block: Introduce parents list

On Thu 17 Sep 2015 03:48:16 PM CEST, Kevin Wolf wrote: > @@ -1090,6 +1090,7 @@ static BdrvChild *bdrv_attach_child(BlockDriverState > *parent_bs, > }; > > QLIST_INSERT_HEAD(_bs->children, child, next); > +QLIST_INSERT_HEAD(_bs->parents, child, next_parent); > > return

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

On Mon, Jul 13, 2015 at 01:08:02PM -0700, Meador Inge wrote: > On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > > > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h > On second thought, I was following an existing pattern in 'main.c'. Really > fixing

Re: [Qemu-devel] [PATCH 2/2] linux-user: remove MAX_ARG_PAGES limit

On Mon, Sep 14, 2015 at 09:37:10PM +0200, Stefan Bruens wrote: > On Thursday 03 September 2015 18:27:20 Peter Maydell wrote: > > On 2 September 2015 at 02:38, Stefan Brüns > wrote: > > > Instead of creating a temporary copy for the whole environment and > > > the

[Qemu-devel] [RFC PATCH 0/6] vITS support

This series introduces support for in-kernel GICv3 ITS emulation. It is based on kernel API which is not released yet, therefore i post it as an RFC. However, if respective maintainers think this is appropriate, infrastructure-related parts of this set (patch N1 and parts of patch N4) can be

Re: [Qemu-devel] [PATCH 4/5] disk_deadlines: add control of requests time expiration

* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Fri, Sep 25, 2015 at 01:34:22PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > > On Tue, Sep 08, 2015 at 04:48:24PM +0200, Kevin Wolf wrote: > > > > Am 08.09.2015 um 16:23 hat Denis V. Lunev

Re: [Qemu-devel] [PATCH v5 00/46] post-introspection cleanups, and qapi-ify netdev_add

I think the first ten patches are a about as large a bite as we can chew and commit quickly. If you split them off, I can try to get them in quickly, and in parallel continue reviewing the rest of your series.

Re: [Qemu-devel] [PATCH 0/4] linux-user: CLI cleanup

On Mon, Jul 06, 2015 at 11:03:37AM -0700, mead...@codesourcery.com wrote: > From: Meador Inge > > This patch series fixes a few nits in the Linux > usermode driver to make the general behavior less > surprising (proper error codes, --foo options, and > -help) and to

Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline

On 09/27/15 00:55, Gabriel L. Somlo wrote: > Allow users to provide custom fw_cfg blobs with ascii string > payloads specified directly on the qemu command line. > > Suggested-by: Jordan Justen > Suggested-by: Laszlo Ersek > Signed-off-by: Gabriel

Re: [Qemu-devel] [PATCH v2] linux-user: add name_to_handle_at/open_by_handle_at

On Tue, Sep 01, 2015 at 10:27:33PM +0200, Laurent Vivier wrote: > This patch allows to run example given by open_by_handle_at(2): > > The following shell session demonstrates the use of these two programs: > >$ echo 'Can you please think about it?' > cecilia.txt >$

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

On 28/09/2015 05:29, Jeff Cody wrote: > This only occurs under two conditions: > > 1. 'mode' != "existing" > 2. bdrv_has_zero_init(target) == NULL > I'm not sure if mode != "existing" actually matters. I think what actually matters is sync == "full". The reasons are: 1) with sync

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

Paolo Bonzini writes: > On 28/09/2015 10:11, Markus Armbruster wrote: >> >> For most of the devices my patch marks, we have a pretty good idea on >> what's wrong with them. spapr-rng is among the exceptions. You believe >> it's actually "the macio object". Which one?

Re: [Qemu-devel] [PATCH 01/10][TRIVIAL] adb: add to input category

On 26/09/15 18:22, Laurent Vivier wrote: > The Apple Desktop Bus is used to connect a keyboard and a mouse, > so add it to the input category. > > Signed-off-by: Laurent Vivier > --- > hw/input/adb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/input/adb.c

Re: [Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable

On 26/09/2015 18:15, Eric Blake wrote: > On 09/25/2015 02:37 AM, Shraddha Barke wrote: >> Compress lines and remove the variable. >> > >> +++ b/target-ppc/kvm.c >> @@ -1782,8 +1782,7 @@ uint32_t kvmppc_get_tbfreq(void) >> >> ns++; >> >> -retval = atoi(ns); >> -return retval; >>

Re: [Qemu-devel] [PATCH 07/10][TRIVIAL] uninorth: add to bridge category

On 26/09/15 18:22, Laurent Vivier wrote: > Uninorth is the mac99 PCI host controller, so add > it to the bridge category. > > Signed-off-by: Laurent Vivier > --- > hw/pci-host/uninorth.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/pci-host/uninorth.c

Re: [Qemu-devel] [RFC PATCH v3] os-android: Add support to android platform

On 24/09/2015 15:21, Houcheng Lin wrote: > +if [ "$android" = "yes" ] ; then > + LIBS="-lglib-2.0 -lgthread-2.0 -lz -lpixman-1 -lintl -liconv -lc $LIBS" > + libs_qga="-lglib-2.0 -lgthread-2.0 -lz -lpixman-1 -lintl -liconv -lc" > +fi This change should not be necessary. > +#define

[Qemu-devel] [PATCH] target-i386: add ABM to Haswell* and Broadwell* CPU models

ABM is only implemented as a single instruction set by AMD; all AMD processors support both instructions or neither. Intel considers POPCNT as part of SSE4.2, and LZCNT as part of BMI1, but Intel also uses AMD's ABM flag to indicate support for both POPCNT and LZCNT. It has to be added to Haswell

Re: [Qemu-devel] [PATCH 4/5] disk_deadlines: add control of requests time expiration

On Fri, Sep 25, 2015 at 01:34:22PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@gmail.com) wrote: > > On Tue, Sep 08, 2015 at 04:48:24PM +0200, Kevin Wolf wrote: > > > Am 08.09.2015 um 16:23 hat Denis V. Lunev geschrieben: > > > > On 09/08/2015 04:05 PM, Kevin Wolf wrote: > >

Re: [Qemu-devel] [PATCH repost 0/4] add mitigation against buffer overflows

On 27/09/2015 12:14, Michael S. Tsirkin wrote: > Multiple places in QEMU map guest memory, then access it > directly. Unfortunately since we are using C, there's always > a chance that we'll miss a bounds check when we do this. > This has a potential to corrupt QEMU memory. > > As a mitigation

Re: [Qemu-devel] [PATCH 04/10][TRIVIAL] grackle: add to bridge category

On 26/09/15 18:22, Laurent Vivier wrote: > Grackle is the PCI host controller of oldworld powermac, > so add it to the bridge category. > > Signed-off-by: Laurent Vivier > --- > hw/pci-host/grackle.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH repost 2/4] oslib: allocate PROT_NONE pages on top of RAM

On 27/09/2015 12:14, Michael S. Tsirkin wrote: > -if (total > size) { > -munmap(ptr + size, total - size); > +if (total > size + getpagesize()) { > +munmap(ptr + size + getpagesize(), total - size - getpagesize()); > } > Please add a comment here, also noting that

Re: [Qemu-devel] [PATCH v5 11/46] qapi: Don't use info as witness of implicit object type

Eric Blake writes: > A future patch will enable error reporting from the various > check() methods. But to report an error on an implicit type, > we'll need to associate a location with the type (the same > location as the top-level entity that is causing the creation > of

Re: [Qemu-devel] [PATCH 02/10][TRIVIAL] cmd646: add to storage category

On 26/09/15 18:22, Laurent Vivier wrote: > cmd646 is an IDE controller, so add it to the > storage category. > > Signed-off-by: Laurent Vivier > --- > hw/ide/cmd646.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c > index

Re: [Qemu-devel] Agenda items for today's MTTCG call

On 28.09.2015 11:19, Alex Bennée wrote: > User-agent: mu4e 0.9.12; emacs 24.5.50.4 > Hi, > > It's been a while since we last synced up via phone call so could I add > the following items for discussion: > > 1. Status of Alvise and Fred's trees > 2. Any cross-pollination ideas between Alvise's

Re: [Qemu-devel] [PATCH 08/10][TRIVIAL] macio: add to bridge category

On 26/09/15 18:22, Laurent Vivier wrote: > macio is a bridge between the PCI bus and the Mac nvram, > IDE controller and PIC, so add it to the bridge category. > > Signed-off-by: Laurent Vivier > --- > hw/misc/macio/macio.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add

On 28/09/2015 11:31, Markus Armbruster wrote: >> However, while changing the command to >> > >> > { 'command': 'netdev_add', 'data': 'Netdev', 'box': true, 'gen': false } >> > >> > for better introspection, you should keep 'gen':'false' and the manual >> > implementation based on

Re: [Qemu-devel] ARM CPU affinities

Hello! > NB that as the comment says KVM currently imposes its own numbering > anyway -- if you care about that you need to get the kernel to > support having userspace tell it about affinity numbering. Yes. You cannot set MPIDR values for the KVM, because upon reset they are reverted to

Re: [Qemu-devel] [PATCH 1/1] migration: fix deadlock

On 28/09/2015 13:41, Denis V. Lunev wrote: > Release qemu global mutex before call synchronize_rcu(). > synchronize_rcu() waiting for all readers to finish their critical > sections. There is at least one critical section in which we try > to get QGM (critical section is in address_space_rw()

Re: [Qemu-devel] [PATCH 10/16] block/io: Make bdrv_requests_pending() public

On Thu 17 Sep 2015 03:48:14 PM CEST, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c| 2 +- > include/block/block_int.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://server1[:port]/testvol/a.img Assuming we have have

Re: [Qemu-devel] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category

On 09/26/2015 12:22 PM, Laurent Vivier wrote: > macio-ide is an IDE controller, so add it > to the storage category. > > Signed-off-by: Laurent Vivier > --- > hw/ide/macio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ide/macio.c b/hw/ide/macio.c > index

Re: [Qemu-devel] [PATCH 1/3] block: allow creation of detached dirty bitmaps

Am 28.09.2015 um 05:29 hat Jeff Cody geschrieben: > This allows the creation of detached dirty bitmaps, so that the > block driver dirty bitmaps can be used without inserting the > bitmap into the dirty bitmap list for a BDS. > > To free a bitmap that was created "detached = true", call >

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

Am 28.09.2015 um 05:29 hat Jeff Cody geschrieben: > During mirror, if the target device does not have support zero > initialization, a mirror may result in a corrupt image. > > For instance, on mirror to a host device with format = raw, whatever > random data is on the target device will still be

[Qemu-devel] [PATCH v2] iotests: disable core dumps in test 061

Commit 934659c460 disabled the supression of segmentation faults in bash tests. The new output of test 061, however, assumes that a core dump will be produced if a program aborts. This is not necessarily the case because core dumps can be disabled using ulimit. Since we cannot guarantee that

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

On 28 September 2015 at 15:35, Markus Armbruster wrote: > That's a memory_region_init_io(), so I should search for that pattern, > too. Any memory_region_init*() in fact, I guess. >300 hits :( You can ignore all the ones which are in board models or non-qdevified devices,

Re: [Qemu-devel] [PATCH] trace/simple: Fix warning and wrong trace file name for MinGW

Am 28.09.2015 um 17:06 schrieb Eric Blake: > On 09/28/2015 02:26 AM, Stefan Weil wrote: > >>> Can you explain why osdep.h's >>> >>> #define FMT_pid "%" PRId64 >>> >>> is appropriate for Windows? >> Don't blame me for any strangeness which you might find in Windows. :-) >> >> Mingw-w64

Re: [Qemu-devel] [PATCH v2] iotests: disable core dumps in test 061

On 28.09.2015 16:23, Alberto Garcia wrote: > Commit 934659c460 disabled the supression of segmentation faults in > bash tests. The new output of test 061, however, assumes that a core > dump will be produced if a program aborts. This is not necessarily the > case because core dumps can be disabled

Re: [Qemu-devel] ARM CPU affinities

Hello! > I've been thinking about picking this work up. Let me confirm first that > Pavel hasn't already, because, iirc, he was the last to look into it. > Pavel? I am here. Yes, i did not do anything else with this. The problem is in the kernel; every time vCPU is reset, it resets its MPIDR

Re: [Qemu-devel] [PATCH 2/3] block: mirror - split out part of mirror_run()

Am 28.09.2015 um 05:29 hat Jeff Cody geschrieben: > This is code relocation, to pull the part of mirror_run() that > calls mirror_iteration out into a separate function. > > Signed-off-by: Jeff Cody > --- > block/mirror.c | 206 >

[Qemu-devel] Test

Hello! I have some strange problems, my emails don't make it to the list. Please ignore this, i am self-testing. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia

Re: [Qemu-devel] [PATCH] trace/simple: Fix warning and wrong trace file name for MinGW

On 09/28/2015 02:26 AM, Stefan Weil wrote: >> Can you explain why osdep.h's >> >> #define FMT_pid "%" PRId64 >> >> is appropriate for Windows? > > Don't blame me for any strangeness which you might find in Windows. :-) > > Mingw-w64 sys/types.h defines pid_t to be either an int or an

Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu cmdline

On Mon, Sep 28, 2015 at 03:30:28PM +0200, Laszlo Ersek wrote: > On 09/27/15 00:55, Gabriel L. Somlo wrote: > > Allow users to provide custom fw_cfg blobs with ascii string > > payloads specified directly on the qemu command line. > > > > Suggested-by: Jordan Justen > >

Re: [Qemu-devel] ARM CPU affinities

On Mon, Sep 28, 2015 at 10:13:15AM +0100, Peter Maydell wrote: > On 27 September 2015 at 22:28, Peter Crosthwaite > wrote: > > Hi Peter, > > > > I am looking at this: > > > > static void arm_cpu_initfn(Object *obj) > > { > > ... > > Aff1 = cs->cpu_index /

Re: [Qemu-devel] [PATCH 3/3] block: mirror - zero unallocated target sectors when zero init not present

Am 28.09.2015 um 05:29 hat Jeff Cody geschrieben: > During mirror, if the target device does not have support zero > initialization, a mirror may result in a corrupt image. I think you want to check this sentence. ("During mirror [...], a mirror may result [...]") > For instance, on mirror to a

Re: [Qemu-devel] [PATCH RFC V4 4/4] Add virt-v3 machine that uses GIC-500

Thanks, I'll fix it and submit together with with the changes required by Peter. Best regards, S.P. On Thursday, September 24, 2015, Christopher Covington wrote: > On 09/24/2015 02:03 PM, Christopher Covington wrote: > > Hi, > > > > On 09/17/2015 01:38 PM, Shlomo

Re: [Qemu-devel] [PATCH 2/3] block: mirror - split out part of mirror_run()

On 28/09/2015 05:29, Jeff Cody wrote: > This is code relocation, to pull the part of mirror_run() that > calls mirror_iteration out into a separate function. > > Signed-off-by: Jeff Cody > --- > block/mirror.c | 206 >

Re: [Qemu-devel] [Qemu-block] [PATCH 1/3] block: allow creation of detached dirty bitmaps

On Sun, Sep 27, 2015 at 11:29:16PM -0400, Jeff Cody wrote: > This allows the creation of detached dirty bitmaps, so that the > block driver dirty bitmaps can be used without inserting the > bitmap into the dirty bitmap list for a BDS. > > To free a bitmap that was created "detached = true", call

Re: [Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting

On 09/28/2015 02:38 AM, Markus Armbruster wrote: >>> +++ b/docs/qmp/qmp-spec.txt >>> @@ -175,6 +175,11 @@ The format of asynchronous events is: >>> For a listing of supported asynchronous events, please, refer to the >>> qmp-events.txt file. >>> >>> +Some events are rate-limited to at most

Re: [Qemu-devel] [PATCH v5 05/46] qapi: Test use of 'number' within alternates

Eric Blake writes: > On 09/24/2015 10:29 AM, Markus Armbruster wrote: > > + > +/* FIXME: Order of alternate should not affect semantics */ Inhowfar does it affect semantics? Or asked differently: what exactly is wrong with this test now? >

Re: [Qemu-devel] [PATCH 01/18] iothread: release iothread around aio_poll

On 28/09/2015 11:50, Stefan Hajnoczi wrote: > On Thu, Aug 06, 2015 at 03:35:59PM +0200, Paolo Bonzini wrote: >> This is the first step towards having fine-grained critical sections in >> dataplane threads, which resolves lock ordering problems between >> address_space_* functions (which need the

[Qemu-devel] [PATCH] target-arm: Add MDCR_EL2

Signed-off-by: Sergey Fedorov --- This patch is a prerequisite for a debug exception routing patch: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg03542.html target-arm/cpu-qom.h | 1 + target-arm/cpu.c | 1 + target-arm/cpu.h | 1 +

Re: [Qemu-devel] [PATCH 01/18] iothread: release iothread around aio_poll

On Thu, Aug 06, 2015 at 03:35:59PM +0200, Paolo Bonzini wrote: > This is the first step towards having fine-grained critical sections in > dataplane threads, which resolves lock ordering problems between > address_space_* functions (which need the BQL when doing MMIO, even > after we complete

Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices

On 28 September 2015 at 10:17, Thomas Huth wrote: > By the way, there are some more spots like this in the code, e.g. in > pxa2xx_fir_instance_init() in hw/arm/pxa2xx.c ... That's an oversight from when it was converted to qdev, I think, and could be fixed. -- PMM

[Qemu-devel] [PATCH v2 2/2] pc: memhp: force gaps between DIMM's GPA

mapping DIMMs non contiguously allows to workaround virtio bug reported earlier: http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html in this case guest kernel doesn't allocate buffers that can cross DIMM boundary keeping each buffer local to a DIMM. Suggested-by: Michael S.

Re: [Qemu-devel] [PATCH 03/18] qemu-thread: introduce QemuLockCnt

On 28/09/2015 12:15, Stefan Hajnoczi wrote: > On Thu, Aug 06, 2015 at 03:36:01PM +0200, Paolo Bonzini wrote: >> > +int qemu_lockcnt_count(QemuLockCnt *lockcnt); > Why use int here when the counter field is unsigned? Nice catch, will fix. Paolo

Re: [Qemu-devel] [PATCH 02/18] aio: rename bh_lock to list_lock

On Thu, Aug 06, 2015 at 03:36:00PM +0200, Paolo Bonzini wrote: > This will be used for AioHandlers too. There is going to be little > or no contention, so it is better to reuse the same lock. > > Signed-off-by: Paolo Bonzini > --- > async.c | 16

[Qemu-devel] [PATCH v2 2/2] target-arm: Fix CPU breakpoint handling

A QEMU breakpoint match is not definitely an architectural breakpoint match. If an exception is generated unconditionally during translation, it is hardly possible to ignore it in the debug exception handler. Generate a call to a helper to check CPU breakpoints and raise an exception only if any

  1   2   3   >