Ping...
On 10/16/2015 04:57 PM, Wen Congyang wrote:
> If quorum's child is broken, we can use mirror job to replace it.
> But sometimes, the user only need to remove the broken child, and
> add it later when the problem is fixed.
>
> It is based on the Kevin's bdrv_swap() related patch:
>
Implement SizeOf term which is used by NVDIMM _DSM method in later patch
Reviewed-by: Igor Mammedov
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 8
include/hw/acpi/aml-build.h | 1 +
2 files changed, 9
Implement DeRefOf term which is used by NVDIMM _DSM method in later patch
Reviewed-by: Igor Mammedov
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 8
include/hw/acpi/aml-build.h | 1 +
2 files changed, 9
This patchset can be found at:
https://github.com/xiaogr/qemu.git nvdimm-v6
It is based on pci branch on Michael's tree and the top commit is:
commit 6f96a31a06c2a1 (tests: re-enable vhost-user-test).
Changelog in v6:
- changes from Stefan's comments:
1) fix code style of struct naming
Implement CreateField term which is used by NVDIMM _DSM method in later patch
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 13 +
include/hw/acpi/aml-build.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/hw/acpi/aml-build.c
A base device, dimm, is abstracted from pc-dimm, so that we can
build nvdimm device based on dimm in the later patch
Signed-off-by: Xiao Guangrong
---
default-configs/i386-softmmu.mak | 1 +
default-configs/ppc64-softmmu.mak | 1 +
- hostmem-file.c is compiled only if CONFIG_LINUX is enabled so that is
unnecessary to do the same check in the source file
- the interface, HostMemoryBackendClass->alloc(), is not called many
times, do not need to check if the memory-region is initialized
Signed-off-by: Xiao Guangrong
pc_existing_dimms_capacity() can be static since it is not used out of
pc-dimm.c and drop the pc_ prefix to prepare the work which abstracts
dimm device type from pc-dimm
Signed-off-by: Xiao Guangrong
---
hw/mem/pc-dimm.c | 73
Rename qmp_pc_dimm_device_list.c to qmp_dimm_device_list.c
Signed-off-by: Xiao Guangrong
---
stubs/Makefile.objs | 2 +-
stubs/{qmp_pc_dimm_device_list.c => qmp_dimm_device_list.c} | 0
2 files changed, 1 insertion(+), 1
It's not used any more
Signed-off-by: Xiao Guangrong
---
include/hw/mem/pc-dimm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index d83bf30..11a8937 100644
--- a/include/hw/mem/pc-dimm.h
+++
On 30 October 2015 at 06:52, Peter Crosthwaite
wrote:
> Ping^3
>
> This has been on list for a very long time without 3rd party review.
> Can I send a PULL?
I would prefer not to take a new unreviewed feature
in softfreeze for 2.5...
thanks
-- PMM
On 2015/10/29 22:41, Peter Maydell wrote:
> We now have a qemu-arm mailing list for ARM patches and discussion,
> so add an L: entry for it to the various ARM related entries in
> MAINTAINERS.
>
> Signed-off-by: Peter Maydell
Reviewed-by: Shannon Zhao
Currently file_ram_alloc() is designed for hugetlbfs, however, the memory
of nvdimm can come from either raw pmem device eg, /dev/pmem, or the file
locates at DAX enabled filesystem
So this patch let it work on any kind of path
Signed-off-by: Xiao Guangrong
---
Rename:
pc-dimm.c => dimm.c
pc-dimm.h => dimm.h
It prepares the work which abstracts dimm device type for both pc-dimm and
nvdimm
Signed-off-by: Xiao Guangrong
---
hw/Makefile.objs | 2 +-
hw/acpi/ich9.c | 2 +-
Currently, file_ram_alloc() only works on directory - it creates a file
under @path and do mmap on it
This patch tries to allow it to work on file directly, if @path is a
directory it works as before, otherwise it treats @path as the target
file then directly allocate memory from it
It avoid explicit Mutex and will be used by NVDIMM ACPI
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 26 --
include/hw/acpi/aml-build.h | 1 +
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git
Add NVDIMM maintainer
Signed-off-by: Xiao Guangrong
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3144113..865c0cf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -907,6 +907,13 @@ M: Jiri Pirko
Function 6 is used to set Namespace Label Data
Signed-off-by: Xiao Guangrong
---
hw/acpi/nvdimm.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 8c27b25..5c8be41 100644
---
Ping^3
This has been on list for a very long time without 3rd party review.
Can I send a PULL?
Regards,
Peter
On Wed, Oct 14, 2015 at 11:42 AM, Alistair Francis
wrote:
> Ping^2
>
> On Thu, Aug 27, 2015 at 2:47 PM, Alistair Francis
>
NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT)
Currently, we only support PMEM mode. Each device has 3 structures:
- SPA structure, defines the PMEM region info
- MEM DEV structure, it has the @handle which is used to associate specified
ACPI NVDIMM device we will
__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method)
Function 0 is a query function. We do not support any function on root
device and only 3 functions are support for NVDIMM device, Get Namespace
Label Size, Get Namespace Label Data and Set Namespace Label Data, that
means we
FIT buffer is not completely mapped into guest address space, so a new
function, Read FIT, function index 0x, is reserved by QEMU to
read the piece of FIT buffer. The buffer is concatenated before _FIT
return
Refer to docs/specs/acpi-nvdimm.txt for detailed design
Signed-off-by: Xiao
NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices
There is a root device under \_SB and specified NVDIMM devices are under the
root device. Each NVDIMM device has _ADR which returns its handle used to
associate MEMDEV structure in NFIT
We reserve handle 0 for root device. In this patch,
QEMU keeps the state of memory of dimm device during live migration,
however, it is not enough for nvdimm device as its memory does not
contain its label data, so that we should protect the whole backend
memory instead
Signed-off-by: Xiao Guangrong
---
This patch is generated by this script:
find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
| xargs sed -i "s/PC_DIMM/DIMM/g"
find ./ -name "*.[ch]" -o -name "*.json" -o -name "trace-events" -type f \
| xargs sed -i "s/PCDIMM/DIMM/g"
find ./ -name "*.[ch]" -o -name
nvdimm need check if the backend memory is large enough to contain label
data and init its memory region when the device is realized, so introduce
realize callback which is called after common dimm has been realize
Signed-off-by: Xiao Guangrong
---
hw/mem/dimm.c
Luiz Capitulino writes:
> On Thu, 29 Oct 2015 17:23:43 +0100
> Markus Armbruster wrote:
>
>> Luiz Capitulino writes:
>>
>> > On Thu, 29 Oct 2015 12:15:09 +0100
>> > Markus Armbruster wrote:
>> >
>> >> Leak
The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2015-10-29 09:49:52 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-30
for you
It describes the basic concepts of NVDIMM ACPI and the interface
between QEMU and the ACPI BIOS
Signed-off-by: Xiao Guangrong
---
docs/specs/acpi_nvdimm.txt | 179 +
1 file changed, 179 insertions(+)
create mode 100644
Curretly, the memory region of backed memory is directly mapped to
guest's address space, however, it is not true for nvdimm device
This patch let dimm device realize this fact and use
DIMMDeviceClass->get_memory_region method to get the mapped memory
region
Signed-off-by: Xiao Guangrong
Introduce "nvdimm" device which is based on dimm device type
128K memory region which is the minimum namespace label size
required by NVDIMM Namespace Spec locates at the end of
backend memory device is reserved for label data
We can use "-m 1G,maxmem=100G,slots=10 -object memory-backend-file,
A page staring from 0xFF0 and IO port 0x0a18 - 0xa1b in guest are
reserved for NVDIMM ACPI emulation, refer to docs/specs/acpi_nvdimm.txt
for detailed design
A parameter, 'nvdimm-support', is introduced for PIIX4_PM and ICH9-LPC
that controls if nvdimm support is enabled, it is true on
Check if the input Arg3 is valid then store it into dsm_in if needed
Signed-off-by: Xiao Guangrong
---
hw/acpi/nvdimm.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index
Introduce a parameter, named "reserve-label-data", if it is
false which indicates that QEMU does not reserve any region
on the backend memory to support label data. It is a
'label-less' NVDIMM device mode that linux will use whole
memory on the device as a single namesapce
This is useful for the
The tests for device type "ide_cd" should only be tested for the pc
platform.
The default device id of hard disk on the s390 platform differs to that
of the x86 platform. A new variable device_id is defined and "virtio0"
set for the s390 platform. A x86 platform specific output file is also
Be easier to read, and be slightly shorter.
Suggested-By: Sascha Silbe
Reviewed-by: Sascha Silbe
Signed-off-by: Bo Tu
---
tests/qemu-iotests/common.config | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Now, s390-virtio-ccw is default machine and s390-ccw.img is default boot
loader. If the s390-virtio-ccw machine finds no device to load from and
errors out, then emits a panic and exits the vm. This breaks test cases
068 for s390x.
Adding the parameter of "-no-shutdown" for s390-ccw-virtio will
Ever since qemu-iotest 120 was introduced, its expected output didn't
include the output from the built-in VNC server:
QA output created by 120
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
QMP_VERSION
+VNC server running on `::1:5900'
{"return": {}}
wrote 65536/65536 bytes at
Eric Blake writes:
> On 10/29/2015 12:27 PM, Markus Armbruster wrote:
>>> Sounds like we have some quadratic (or worse) scaling in the parser.
>>> Worth fixing some day, but I also agree that we don't have to tackle it
>>> in this series.
>>
>> I believe it's linear with a
Peter Maydell writes:
> On 29 October 2015 at 14:32, Markus Armbruster wrote:
>> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce:
>>
>> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>> staging
There are three places use the some logic to get the page size on
the file path or file fd
This patch introduces qemu_file_get_page_size() to unify the code
Signed-off-by: Xiao Guangrong
---
include/qemu/osdep.h | 1 +
target-ppc/kvm.c | 21
Implement ObjectType which is used by NVDIMM _DSM method in
later patch
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 8
include/hw/acpi/aml-build.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/hw/acpi/aml-build.c
Implement Concatenate term which is used by NVDIMM _DSM method
in later patch
Signed-off-by: Xiao Guangrong
---
hw/acpi/aml-build.c | 14 ++
include/hw/acpi/aml-build.h | 1 +
2 files changed, 15 insertions(+)
diff --git
Use the whole file size if @size is not specified which is useful
if we want to directly pass a file to guest
Signed-off-by: Xiao Guangrong
---
backends/hostmem-file.c | 48
1 file changed, 44 insertions(+), 4
Function 5 is used to get Namespace Label Data
Signed-off-by: Xiao Guangrong
---
hw/acpi/nvdimm.c | 63
1 file changed, 63 insertions(+)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index
Function 4 is used to get Namespace label size
Signed-off-by: Xiao Guangrong
---
hw/acpi/nvdimm.c | 87 +++-
1 file changed, 86 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
On 29 October 2015 at 20:16, Soren Brinkmann wrote:
> Add BANK_ #defines to index banked registers.
>
> Suggested-by: Peter Maydell
> Signed-off-by: Soren Brinkmann
> ---
> v2:
> - move #defines from cpu.h to
On Fri, Oct 30, 2015 at 1:24 PM, Peter Maydell wrote:
> On 28 October 2015 at 23:02, Jean-Christophe Dubois
> wrote:
>> i.MX25 SOC has a different CCM device than i.MX31.
>>
>> Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows
>>
On 27 October 2015 at 04:02, Peter Crosthwaite
wrote:
> This patch series adds bare-minimum Allwinner SATA support.
>
> P1 is a trivial to help debug AHCI.
>
> Changed since RFC:
> Addressed Beniamino review.
> Rebased to avoid bad deps (John Snow review)
>
> Regards,
On 10/30/2015 05:37 PM, Peter Maydell wrote:
> On 30 October 2015 at 21:34, John Snow wrote:
>>
>>
>> On 10/30/2015 05:33 PM, Peter Crosthwaite wrote:
>>> On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell
>>> wrote:
On 27 October 2015 at 04:02,
On 30 October 2015 at 21:24, Peter Crosthwaite
wrote:
> On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell
> wrote:
>> The other question is what happens on a board like this if
>> the user says -enable-kvm -cpu cortex-a15 ? Does that get us
>>
On 30 October 2015 at 20:03, Eric Blake wrote:
> On 10/30/2015 01:47 PM, Peter Maydell wrote:
>> On 30 October 2015 at 15:42, Markus Armbruster wrote:
>
>>> char: Convert to new qapi union layout
>
>> Hi; I'm afraid this doesn't build on w32:
>>
>>
On 30 October 2015 at 05:35, Peter Crosthwaite
wrote:
> Firstly, enable monitor mode and PSCI, both are which are features of
> this board.
>
> In addition to PSCI, this board also uses SMC for cache maintainence
> ops. This means we need a secure monitor to catch
This series looks good, up to Peter if is qualifies for 2.5. It was
clearly on list well before soft freeze and really my tardiness as to
why it is late with review. So I'll make a case for inclusion.
It does seem to be missing a cover, and/or the in-reply-to looks a bit
strange. Maybe patches
On 30 October 2015 at 19:45, Eric Blake wrote:
> Loaded question in response to
> https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg06988.html, but
> posting as a new thread to call attention to it:
>
> Libvirt uses libyajl to parse and format JSON. Would it be worth
>
Missing CC of Alistair for STM32F205.
On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver
wrote:
> Change armv7m_init to return the DeviceState* for the NVIC.
> This allows access to all GPIO blocks, not just the IRQ inputs.
> Move qdev_get_gpio_in() calls out of
On Fri, Oct 30, 2015 at 2:10 PM, Peter Maydell wrote:
> On 30 October 2015 at 05:35, Peter Crosthwaite
> wrote:
>> Firstly, enable monitor mode and PSCI, both are which are features of
>> this board.
>>
>> In addition to PSCI, this board also
On 24 October 2015 at 13:21, Dmitry Osipenko wrote:
> Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
>
> V2: Fixed changing periodic timer counter value "on the fly". I added a
> test to the gist to cover that issue.
>
> V3: Fixed starting the timer
On 28 October 2015 at 23:02, Jean-Christophe Dubois
wrote:
> i.MX25 SOC has a different CCM device than i.MX31.
>
> Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows
> Linux to work on top of the i.MX25 emultion but this is not correct.
>
> Furthermore,
On Fri, Oct 30, 2015 at 3:04 PM, Peter Maydell wrote:
> On 30 October 2015 at 21:24, Peter Crosthwaite
> wrote:
>> On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell
>> wrote:
>>> The other question is what happens on
On 10/30/2015 06:41 PM, Stefan Hajnoczi wrote:
On Wed, Oct 28, 2015 at 06:01:02PM +0300, Denis V. Lunev wrote:
+int rfifolock_is_locked(RFifoLock *r);
Please use bool instead of int.
diff --git a/util/rfifolock.c b/util/rfifolock.c
index afbf748..8ac58cb 100644
--- a/util/rfifolock.c
+++
On 30 October 2015 at 05:34, Peter Crosthwaite
wrote:
> Hi,
>
> This adds support for machine-specific primary boot blobs. This can be
> used to install little bits of firmware or boot code without having
> to throw the whole QEMU bootloader out and BYO (with device
From: Chen Gang
Originally, tilegx qemu only implement prefetch instructions in pipe x1,
did not implement them in pipe y2.
Signed-off-by: Chen Gang
Signed-off-by: Richard Henderson
---
target-tilegx/translate.c | 22
)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-tile-20151030
for you to fetch changes up to 2a080ce26682f35517b0e20f4ad10559e9270b5d:
target-tilegx: Implement prefetch instructions in pipe y2 (2015-10-22
07:51:49 -1000
On 30.10.2015 20:25, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu-io from a bash subshell,
> in order to catch segfaults. This method is incompatible with the
> current valgrind_qemu_io() bash function.
>
> Move the valgrind usage into the exec subshell in
On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver
wrote:
> Implement the SYSRESETREQ bit of the AIRCR register
> for armv7-m (ie. cortex-m3) to trigger a GPIO out.
>
> Signed-off-by: Michael Davidsaver
Reviewed-by: Peter Crosthwaite
On 30 October 2015 at 21:34, John Snow wrote:
>
>
> On 10/30/2015 05:33 PM, Peter Crosthwaite wrote:
>> On Fri, Oct 30, 2015 at 2:28 PM, Peter Maydell
>> wrote:
>>> On 27 October 2015 at 04:02, Peter Crosthwaite
>>> wrote:
On 30 October 2015 at 21:40, John Snow wrote:
> On 10/30/2015 05:37 PM, Peter Maydell wrote:
>> Given the diffstat, are you planning to take this through
>> the IDE tree? I'm happy for you to do that, I can just take
>> this off my to-review list then :-)
> If nobody has
On 10/29/2015 12:31 AM, Xiao Guangrong wrote:
> These instructions are used by NVDIMM drivers and the specification
> locates at:
> https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf
>
> There instructions are available on Skylake Server
>
> Signed-off-by: Xiao Guangrong
31.10.2015 00:52, Peter Maydell пишет:
On 24 October 2015 at 13:21, Dmitry Osipenko wrote:
Changelog for ARM MPTimer QEMUTimer to ptimer conversion:
V2: Fixed changing periodic timer counter value "on the fly". I added a
test to the gist to cover that issue.
"arm: stellaris: " prefix in subject line.
On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver
wrote:
> Add GPIO in for the stellaris board which calls
> qemu_system_reset_request() on reset request.
>
> Signed-off-by: Michael Davidsaver
Otherwise,
On 30.10.2015 20:25, Jeff Cody wrote:
> Commit 934659c switched the iotests to run qemu and qemu-nbd from a bash
> subshell, in order to catch segfaults. Unfortunately, this means the
> process PID cannot be captured via '$!'. We stopped killing qemu and
> qemu-nbd processes, leaving a lot of
On Fri, Oct 30, 2015 at 2:14 PM, Peter Maydell wrote:
> On 30 October 2015 at 20:59, Peter Crosthwaite
> wrote:
>> On Fri, Oct 30, 2015 at 1:49 PM, Peter Maydell
>> wrote:
>>> I thought you were planning to have
On 30 October 2015 at 17:37, Peter Maydell wrote:
> On 30 October 2015 at 14:19, Markus Armbruster wrote:
>> Peter Maydell writes:
>>> I get an error on 64-bit ARM running the ivshmem tests:
>>>
>>> TEST:
v2:
* Use find(1) to catch all tracetool *.py files [Lluís]
Note: I used find -name instead of find -path for better POSIX compliance
Issues with trace/Makefile.objs:
1. Generated code is not recreated when patches modify scripts/tracetool/*.py.
Typically such patches also modify
The Makefile uses intermediate timestamp files to avoid rebuilding if
tracetool output is unchanged.
Timestamps are implemented incorrectly. This was fixed for rules.mak in
commit 4b25966ab976f3a7fd9008193b2defcc82f8f04d ("rules.mak: cleanup
config generation rules") but never fixed in
On 29/10/15 17:17, Yongbok Kim wrote:
> Correct updating XContext.Region field on mmu exceptions.
> If Config3.CTXTC = 0 then the R field of XContext has to be updated
> with the value of bits 63..62 of the virtual address upon a TLB
> exception.
> Also fixed the below line which overs 80
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 61a8f2c..8ee1266 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -618,8 +618,12 @@ static int vnc_height(VncDisplay *vd)
Signed-off-by: Gerd Hoffmann
---
ui/vnc-jobs.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index fd9ed39..12389cc 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -185,6 +185,9 @@ void
Signed-off-by: Gerd Hoffmann
---
ui/vnc-jobs.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 329d13e..fd9ed39 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -29,6 +29,7 @@
#include "vnc.h"
#include
From: Peter Lieven
the idea behind this patch is to allow the buffer to shrink, but
make this a seldom operation. The buffers average size is measured
exponentionally smoothed with am alpha of 1/128.
Signed-off-by: Peter Lieven
Signed-off-by: Gerd Hoffmann
On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote:
> Hi Yongbok,
>
> On Tue, Oct 27, 2015 at 05:12:35PM +, Yongbok Kim wrote:
> > Add part of GCR Block which Linux Kernel utilises and it is enough
> > to bring the GIC up.
> > It defines full 32 Kbytes address space allocated for GCR
On Fri, Oct 30, 2015 at 12:09:57PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Peter Lieven
> ---
> include/qemu/buffer.h | 12
> util/buffer.c | 11 +++
> 2 files changed, 23 insertions(+)
Reviewed-by:
On 30 October 2015 at 11:40, James Hogan wrote:
> On Fri, Oct 30, 2015 at 12:36:07AM +, James Hogan wrote:
>> Hi Yongbok,
>>
>> > +case GCR_GIC_BASE_OFS:
>> > +return gcr->gic_base;
>
> Note also, that this is a read-write register. It starts undefined and
Hi,
[ context for spice folks: patch was added to qemu increasing usb-audio
default buffer size ]
> > What bothers me is that you have no qualms about making latency on
> > everyone's system worse.
>
> How do you know it makes sound on other people's systems worse? If you have
> actually
From: Peter Lieven
Signed-off-by: Peter Lieven
Signed-off-by: Gerd Hoffmann
---
util/buffer.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/util/buffer.c b/util/buffer.c
index ae2907e..31f1d9f 100644
---
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c | 4
1 file changed, 4 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 49e8f3a..cb1954c 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -722,10 +722,6 @@ static void vnc_dpy_switch(DisplayChangeListener *dcl,
On Do, 2015-10-29 at 16:55 +0100, Markus Armbruster wrote:
> v2:
> * Trivially rebased
>
> Markus Armbruster (4):
> ui: Use g_new() & friends where that makes obvious sense
> audio: Use g_new() & friends where that makes obvious sense
> qxl: Use g_new() & friends where that makes obvious
For now, only high-level review.
The main cost of sorting is interface complexity: we need to specify
which things are sorted, and what the sorting order is (see your TODO
below). Once we've done so, we can't go back.
There's also implementation complexity, but your patch shows it's low
enough
On Fr, 2015-10-30 at 12:13 +0100, Gerd Hoffmann wrote:
> Do you want me pick this up or send a pull request yourself?
Oh, I see you have trivial cc'ed. scratch the question then ;)
On Fri, Oct 30, 2015 at 12:09:58PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Peter Lieven
> ---
> include/qemu/buffer.h | 10 ++
> util/buffer.c | 14 ++
> 2 files changed, 24 insertions(+)
>
> diff
On Fri, Oct 30, 2015 at 12:09:59PM +0100, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Peter Lieven
> ---
> include/qemu/buffer.h | 10 ++
> util/buffer.c | 16
> 2 files changed, 26 insertions(+)
On Fri, Oct 30, 2015 at 01:55:54PM +0800, Xiao Guangrong wrote:
> This patchset can be found at:
> https://github.com/xiaogr/qemu.git nvdimm-v6
>
> It is based on pci branch on Michael's tree and the top commit is:
> commit 6f96a31a06c2a1 (tests: re-enable vhost-user-test).
>
> Changelog
On Fri, Oct 30, 2015 at 01:56:21PM +0800, Xiao Guangrong wrote:
> static uint64_t
> nvdimm_dsm_read(void *opaque, hwaddr addr, unsigned size)
> {
> -return 0;
> +AcpiNVDIMMState *state = opaque;
> +MemoryRegion *dsm_ram_mr = >ram_mr;
> +NvdimmDsmIn *in;
> +GArray *out;
> +
Patches that change tracetool can break the build if old build output
files are lying around.
This happens because the Makefile does not specify dependencies on
tracetool. The build will use old object files that do not match the
current source code.
Signed-off-by: Stefan Hajnoczi
On Fri, Oct 30, 2015 at 12:06:29PM +0800, Fam Zheng wrote:
> To comply with aio_{disable,enable}_external, we always use ppoll when
> aio_external_disabled() is true.
All file descriptors are added to the epoll fd. Does that mean epoll
will report the same fds again after we come out of
On 30 October 2015 at 08:10, Markus Armbruster wrote:
> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2015-10-29 09:49:52 +)
>
> are available in the git
Signed-off-by: Gerd Hoffmann
Reviewed-by: Peter Lieven
---
ui/vnc-jobs.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
index 2e6c15f..329d13e 100644
--- a/ui/vnc-jobs.c
+++ b/ui/vnc-jobs.c
@@ -54,7 +54,6 @@ struct
Signed-off-by: Gerd Hoffmann
---
include/qemu/buffer.h | 10 ++
util/buffer.c | 20 +++-
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h
index 1358df1..0a69b3a 100644
---
Signed-off-by: Gerd Hoffmann
Reviewed-by: Peter Lieven
---
include/qemu/buffer.h | 12
util/buffer.c | 11 +++
2 files changed, 23 insertions(+)
diff --git a/include/qemu/buffer.h b/include/qemu/buffer.h
index b380cec..0710e16
1 - 100 of 276 matches
Mail list logo