Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > This patch gives a mechanism to provide all the server addresses, which are in > repli

Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring

2015-11-12 Thread Bandan Das
Gerd Hoffmann writes: > On Mo, 2015-11-09 at 18:12 -0500, Bandan Das wrote: >> Gerd Hoffmann writes: >> >> > On Di, 2015-11-03 at 19:00 -0500, Bandan Das wrote: >> >> +/* Add a new watch asap so as to not lose events >> >> */ >> > >> > This comment sounds like there is a rac

Re: [Qemu-devel] [PATCH 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c

Re: [Qemu-devel] [PATCH 3/4] block/gluster: using new qapi schema

2015-11-12 Thread Eric Blake
On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch adds GlusterConf to qapi/block-core.json > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 104 > +-- > qapi/block-core.json | 60 ++

Re: [Qemu-devel] [PATCH 0/4] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Eric Blake
[adding qemu-block] On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > This release is rebased on qemu master branch. > In this series of patches 1/4 and 2/4 are unchanged. According to scripts/get-maintainer.pl, this series should have cc'd qemu-bl...@nongnu.org. I don't know if anyone on

[Qemu-devel] [PATCH v2 0/2] Minor cleanups when parsing the "iommu" option

2015-11-12 Thread Bandan Das
Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx. v2: 2/2: use error_report for the warning message Bandan Das (2): q35: Check propery to determine if iommu is

[Qemu-devel] [PATCH v2 1/2] q35: Check propery to determine if iommu is set

2015-11-12 Thread Bandan Das
The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das --- hw/core/machine.c | 5 - hw/pci-host/q35.c | 2 +- include/hw/boards.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/core/machine.c b/hw/cor

[Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
There's no indication of any sort that i440fx doesn't support "iommu=on"" Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..ffcb846 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/pii

Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Eric Blake
On 11/12/2015 03:55 PM, Bandan Das wrote: > There's no indication of any sort that i440fx doesn't support > "iommu=on"" > > Signed-off-by: Bandan Das > --- > hw/pci-host/piix.c | 5 + > 1 file changed, 5 insertions(+) > > @@ -301,6 +302,10 @@ static void i440fx_pcihost_realize(DeviceState

Re: [Qemu-devel] [PATCH v4 0/5] handle vhost reset/start/stop correctly

2015-11-12 Thread Yuanhan Liu
On Thu, Nov 12, 2015 at 04:44:19PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 12, 2015 at 10:08:15PM +0800, Yuanhan Liu wrote: > > On Thu, Nov 12, 2015 at 03:33:41PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 11, 2015 at 09:24:36PM +0800, Yuanhan Liu wrote: > > > > > > > > Patch 1 rena

Re: [Qemu-devel] [PATCH v3 1/3] target-i386: add a subsection for migrating vcpu's TSC rate

2015-11-12 Thread Haozhong Zhang
On 11/11/15 22:27, Haozhong Zhang wrote: > On 11/11/15 12:16, Eduardo Habkost wrote: [...] > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > index 2f8f396..858ed69 100644 > > > --- a/hw/i386/pc_q35.c > > > +++ b/hw/i386/pc_q35.c > > > @@ -385,6 +385,7 @@ static void pc_q35_2_4_machine_op

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: > Commit 6c6f312d added a new test, but did not mark it for > exclusion in .gitignore. > > Signed-off-by: Eric Blake > --- > > Yeah, I know this affects only non-VPATH builds, which we don't > recommend, but we might as well be consiste

Re: [Qemu-devel] [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 04:37:08PM +0100, Kevin Wolf wrote: > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2015-11-12 14:15:32 +) > > are available in the git repositor

Re: [Qemu-devel] [Qemu-block] [PULL v3 00/43] Block layer patches (Stefan's tree)

2015-11-12 Thread Stefan Hajnoczi
On Thu, Nov 12, 2015 at 05:26:43PM +0100, Alberto Garcia wrote: > On Thu, Nov 12, 2015 at 04:37:08PM +0100, Kevin Wolf wrote: > > The following changes since commit 17e50a72a3aade0eddfebc012a5d7bdd40a03573: > > > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' > > into s

Re: [Qemu-devel] [v2 1/2] cutils: add avx2 instruction optimization

2015-11-12 Thread Li, Liang Z
> > This patch use the ifunc mechanism to select the proper function when > > running, for platform supports AVX2, excute the AVX2 instructions, > > else, excute the original code. > > > > Signed-off-by: Liang Li > > --- > > include/qemu-common.h | 28 +++-- > > util/Makefile.objs

Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device

2015-11-12 Thread Cao jin
On 11/12/2015 07:51 PM, Michael S. Tsirkin wrote: On Wed, Nov 11, 2015 at 06:34:27PM +0800, Cao jin wrote: From: Chen Fan Since we support multi-function hotplug. the function 0 indicate the closure of the slot, so we have the chance to do the check. Signed-off-by: Chen Fan --- hw/pci/pc

Re: [Qemu-devel] [PATCH] tests: Ignore test-blockjob-txn

2015-11-12 Thread Eric Blake
On 11/12/2015 07:27 PM, Stefan Hajnoczi wrote: > On Thu, Nov 12, 2015 at 11:33:48AM -0700, Eric Blake wrote: >> Commit 6c6f312d added a new test, but did not mark it for >> exclusion in .gitignore. >> >> Signed-off-by: Eric Blake >> --- >> >> Yeah, I know this affects only non-VPATH builds, which

[Qemu-devel] [PATCH for-2.5 v2] tests: Ignore recent test binaries

2015-11-12 Thread Eric Blake
Commits 6c6f312d and bd797fc1 added new tests (test-blockjob-txn and test-timed-average, respectively), but did not mark them for exclusion in .gitignore. Signed-off-by: Eric Blake --- v2: retitle; also ignore test-timed-average tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [Qemu-devel] [PULL v2 00/15] Tracing patches

2015-11-12 Thread Stefan Hajnoczi
On Wed, Nov 11, 2015 at 11:20:52AM +, Peter Maydell wrote: > On 11 November 2015 at 07:34, Stefan Hajnoczi wrote: > > v2: > > * Fixed missing log.py file when merging "trace: convert stderr backend to > > log" [Peter] > > > > The following changes since commit a77067f6ac9b17beefea506ce5f5140

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Thu, Nov 12, 2015 at 10:40:11AM +0100, Thomas Huth wrote: > On 12/11/15 09:09, Thomas Huth wrote: > > On 11/11/15 18:16, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the kernel for handling. > >> If the memory address in er

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: > > > On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: > > On 11/11/15 18:16, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the kernel for handling. >

[Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-12 Thread Programmingkid
On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: > Message: 3 > Date: Thu, 12 Nov 2015 22:24:08 +0100 > From: Herv? Poussineau > To: qemu-devel@nongnu.org > Cc: "open list:Old World" , Herv? Poussineau > > Subject: [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize >

Re: [Qemu-devel] [PATCH] nand: fix address overflow

2015-11-12 Thread Peter Crosthwaite
On Tue, Nov 10, 2015 at 7:09 AM, Paolo Bonzini wrote: > > > On 10/11/2015 14:25, Rabin Vincent wrote: >> The shifts of the address mask and value shift beyond 32 bits when there >> are 5 address cycles. >> >> Signed-off-by: Rabin Vincent >> --- >> hw/block/nand.c |4 ++-- >> 1 file changed,

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Friday 13 November 2015 07:28 AM, David Gibson wrote: > On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: >>> On 11/11/15 18:16, Aravinda Prasad wrote: Memory error such as bit flips that cannot be corrected

Re: [Qemu-devel] [PATCH v13 3/3] block/gluster: add support for multiple gluster servers

2015-11-12 Thread Jeff Cody
On Thu, Nov 12, 2015 at 11:23:35AM -0500, Jeff Cody wrote: > On Thu, Nov 12, 2015 at 05:04:02AM -0500, Prasanna Kumar Kalever wrote: > > On Tuesday, November 10, 2015 9:37:20 PM, Eric Blake wrote: > > > > > > On 11/10/2015 02:09 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to sp

Re: [Qemu-devel] [PATCH v11 20/28] qapi: Forbid case-insensitive clashes

2015-11-12 Thread Eric Blake
On 11/11/2015 07:53 AM, Markus Armbruster wrote: > Eric Blake writes: > >> In general, designing user interfaces that rely on case >> distinction is poor practice. Another benefit of enforcing >> a restriction against case-insensitive clashes is that we >> no longer have to worry about the situa

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread David Gibson
On Fri, Nov 13, 2015 at 10:23:20AM +0530, Aravinda Prasad wrote: > > > On Friday 13 November 2015 07:28 AM, David Gibson wrote: > > On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: > >> > >> > >> On Thursday 12 November 2015 01:39 PM, Thomas Huth wrote: > >>> On 11/11/15 18:16, Ar

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Aravinda Prasad
On Friday 13 November 2015 11:27 AM, David Gibson wrote: > On Fri, Nov 13, 2015 at 10:23:20AM +0530, Aravinda Prasad wrote: >> >> >> On Friday 13 November 2015 07:28 AM, David Gibson wrote: >>> On Thu, Nov 12, 2015 at 11:53:45PM +0530, Aravinda Prasad wrote: On Thursday 12 November

Re: [Qemu-devel] [PATCH v2 2/2] i.MX: Add i.MX25 CCM driver

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 4:02 PM, Jean-Christophe Dubois wrote: > The i.MX25 CCM device is different from the i.MX31 one. > > So for now the emulation was not correct even if linux was working OK > on top of the i.MX25 emulation. > > We add an i.MX25 specific CCM driver and use it in the i.MX25 SOC

Re: [Qemu-devel] [PATCH v2 1/2] i.MX: rework CCM driver.

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 4:02 PM, Jean-Christophe Dubois wrote: > The CCM drive is in fact specific to the i.MX31. We need to add an i.MX25 > CCM driver. > > As a first step, we split the CCM driver into 2 parts: > 1) A common/utility part that allow to compute an manipulate clock freq for >any

Re: [Qemu-devel] [PATCH] i.MX: add support for lower and upper interrupt in GPIO.

2015-11-12 Thread Peter Crosthwaite
On Wed, Oct 28, 2015 at 12:10 AM, Jean-Christophe DUBOIS wrote: > Le 27/10/2015 23:41, Peter Crosthwaite a écrit : > > > > On Tue, Oct 27, 2015 at 3:32 PM, Jean-Christophe Dubois > wrote: >> >> The i.MX6 GPIO device supports 2 interrupts instead of one. >> >> * 1 for the lower 16 GPIOs. >> * 1 fo

[Qemu-devel] [PATCH v3 1/2] q35: Check propery to determine if iommu is set

2015-11-12 Thread Bandan Das
The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das --- hw/core/machine.c | 5 - hw/pci-host/q35.c | 2 +- include/hw/boards.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/core/machine.c b/hw/cor

[Qemu-devel] [PATCH v3 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
There's no indication of any sort that i440fx doesn't support "iommu=on" Reviewed-by: Eric Blake Signed-off-by: Bandan Das --- hw/pci-host/piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 7b2fbf9..715208b 100644 --- a/hw/pci-host/piix

[Qemu-devel] [PATCH v3 0/2] Minor cleanups when parsing the "iommu" option

2015-11-12 Thread Bandan Das
Small cleanup changes. The first removes the helper function by directly checking the property and the second adds a error message if user tries to use "-machine iommu=on" with i440fx. v3: error_report does not need a \n! v2: 2/2: use error_report for the warning message Bandan Das (2): q35: C

Re: [Qemu-devel] [PATCH v2 2/2] i440fx: print an error message if user tries to enable iommu

2015-11-12 Thread Bandan Das
Eric Blake writes: > On 11/12/2015 03:55 PM, Bandan Das wrote: >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das >> --- >> hw/pci-host/piix.c | 5 + >> 1 file changed, 5 insertions(+) >> > >> @@ -301,6 +302,10 @@ static void i4

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-11-12 Thread Peter Crosthwaite
Hi Christian, Sorry about the delayed response. On Tue, Oct 27, 2015 at 3:30 AM, Christian Pinto < c.pi...@virtualopensystems.com> wrote: > > > On 25/10/2015 22:38, Peter Crosthwaite wrote: > > On Thu, Oct 22, 2015 at 2:21 AM, Christian > Pinto wrote: > > Hello Peter, > > > On 07/10/2015 17:48

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-12 Thread Thomas Huth
On 13/11/15 02:57, David Gibson wrote: > On Thu, Nov 12, 2015 at 10:40:11AM +0100, Thomas Huth wrote: >> On 12/11/15 09:09, Thomas Huth wrote: >>> On 11/11/15 18:16, Aravinda Prasad wrote: [...] +qemu_mutex_lock(&spapr->mc_in_progress); >>> >>> Using a mutex here is definitely wrong. The k

[Qemu-devel] [PATCH 2/2] vhost: don't send RESET_OWNER at stop

2015-11-12 Thread Yuanhan Liu
First of all, RESET_OWNER message is sent incorrectly, as it's sent before GET_VRING_BASE. And the reset message would let the later call get nothing correct. And, sending SET_VRING_ENABLE at stop, which has already been done, makes more sense than RESET_OWNER. Signed-off-by: Yuanhan Liu --- hw

[Qemu-devel] [PATCH 1/2] vhost: let SET_VRING_ENABLE message depends on protocol feature

2015-11-12 Thread Yuanhan Liu
But not depend on PROTOCOL_F_MQ feature bit. So that we could use SET_VRING_ENABLE to sign the backend on stop, even if MQ is disabled. That's reasonable, since we will have one queue pair at least. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental

2015-11-12 Thread Gerd Hoffmann
On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote: > The x-input-send-event command was introduced in 2.2 with mention > that it is experimental, but now that several releases have elapsed > without any changes, it would be nice to document why that was done > and should still remain experimental

Re: [Qemu-devel] [PATCH v2 7/7] spice: Initialization stubs on qemu-spice.h

2015-11-12 Thread Gerd Hoffmann
On Do, 2015-11-12 at 17:02 -0200, Eduardo Habkost wrote: > This reduces the number of CONFIG_SPICE #ifdefs in vl.c. > > Cc: Gerd Hoffmann > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Move stubs to qemu-spice.h, as the header file already > had a separate section for !CONFIG_S

Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos

2015-11-12 Thread Markus Armbruster
Michael Tokarev writes: > 12.11.2015 20:53, Andreas Färber wrote: >> Am 06.11.2015 um 13:43 schrieb Michael Tokarev: >>> From: Cao jin >>> >>> Also change the misleading definition of macro OBJECT_CLASS_CHECK >>> >>> Signed-off-by: Cao jin >>> Signed-off-by: Michael Tokarev >> >> Michael, ple

[Qemu-devel] [PULL v3 00/15] Tracing patches

2015-11-12 Thread Stefan Hajnoczi
v3: * Include "exec/log.h" from translate-a64.c [Peter] v2: * Add missing log.py file [Peter] The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +) are available in the git reposi

<    1   2   3   4