Re: [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions

On 11/12/15 01:11, David Gibson wrote: > The functions for migrating the hash page table on pseries machine type > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate eror code. Change these s/eror/error/ > to use

Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

On 12/04/2015 05:44 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Another problem is that libvirt can not detect this failure at all as it uses HMP for this

Re: [Qemu-devel] [PATCH COLO-Frame v11 27/39] COLO failover: Shutdown related socket fd when do failover

On 2015/12/11 17:18, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: On 2015/12/11 4:03, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If the net connection between COLO's two sides is broken while colo/colo

Re: [Qemu-devel] [PATCH 08/11] pseries: Clean up error handling in spapr_rtas_register()

On 11/12/15 01:11, David Gibson wrote: > The errors detected in this function indicate problems with the rest of > the machine type code, rather than configuration or runtime problems. > > Use error_setg() and _abort instead of explicit fprintf() and exit(). > > Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH 0/7] igd passthrough chipset tweaks

On Tue, 8 Dec 2015, Gerd Hoffmann wrote: > Hi, > > We have some code in our tree to support pci passthrough of intel > graphics devices (igd) on xen, which requires some chipset tweaks > for (a) the host bridge and (b) the lpc/isa-bridge to meat the > expectations of the guest driver. For kvm

Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > Before this patch, if sosendto fails, udp_input is executed as if the > packet was sent, recording the packet for icmp errors, which does not > makes sense since the packet was not actually sent, errors

Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

Thomas Huth, on Fri 11 Dec 2015 12:54:14 +0100, wrote: > > @@ -5,7 +5,7 @@ > > * terms and conditions of the copyright. > > */ > > > > -//#define DEBUG 1 > > +#define DEBUG 1 > > Please don't enable the debug code by default. Oops, sorry, that wasn't meant to be included in the patch

Re: [Qemu-devel] [PATCH v3 0/9] Introduce I/O channels framework

On 11/12/2015 11:53, Daniel P. Berrange wrote: > Ping, unless anyone wants to review this further I'll send a pull > request for it once 2.6 opens up, so I can focus on getting the > other dependant patch series reviewed & merged in 2.6 too. Yes, please do. Paolo

Re: [Qemu-devel] [PATCH 08/11] qjson: Simplify by using json-output-visitor

On 11/12/2015 00:53, Eric Blake wrote: > Instead of rolling our own limited JSON outputter, we can just > wrap the more full-featured JSON output Visitor. > > This slightly changes the output (different spacing), but the > result is still equivalent JSON contents. > > Signed-off-by: Eric Blake

Re: [Qemu-devel] [PATCH 01/11] qapi: Rename qjson.h to qobject-json.h

On 11/12/2015 00:53, Eric Blake wrote: > We have two different JSON visitors in the tree; and having both > named 'qjson.h' can cause include confusion. Rename the qapi > version. > > Kill trailing whitespace in the renamed tests/check-qobject-json.c > to keep checkpatch.pl happy. > >

Re: [Qemu-devel] [PATCH 0/7] igd passthrough chipset tweaks

Actually CC'ing xen-devel On Fri, 11 Dec 2015, Stefano Stabellini wrote: > On Tue, 8 Dec 2015, Gerd Hoffmann wrote: > > Hi, > > > > We have some code in our tree to support pci passthrough of intel > > graphics devices (igd) on xen, which requires some chipset tweaks > > for (a) the host

Re: [Qemu-devel] [PATCH COLO-Frame v11 23/39] COLO: Implement failover work for Primary VM

On 2015/12/11 17:22, Dr. David Alan Gilbert wrote: * Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote: On 2015/12/11 2:34, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: For PVM, if there is failover request from users. The colo thread will exit the

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

Sent from my iPhone > On 11 Dec 2015, at 11:10, Jason Wang wrote: > > > >> On 12/09/2015 11:28 PM, P J P wrote: >> Hello Jason, Dmitry, >> >> +-- On Tue, 8 Dec 2015, P J P wrote --+ >> | |1) VMXNET3_CMD_QUIESCE_DEV >> | >> | IIUC, it is used to pause the device

Re: [Qemu-devel] [PATCH 11/16] pc: Simplify signature of xen_load_linux()

On Tue, 1 Dec 2015, Eduardo Habkost wrote: > We don't need the FWCfgState return value and the PcGuestInfo > parameter. > > Signed-off-by: Eduardo Habkost Reviewed-by: Stefano Stabellini > hw/i386/pc.c | 5 + >

Re: [Qemu-devel] [PATCH 2/7] pc: move igd support code to igd.c

On Tue, 8 Dec 2015, Gerd Hoffmann wrote: > Pure code motion, except for dropping instance_size for > TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set, > we can inherit it from TYPE_I440FX_PCI_DEVICE). > > Signed-off-by: Gerd Hoffmann Acked-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH 06/11] pseries: Improve error handling in find_unknown_sysbus_device()

On 11/12/15 01:11, David Gibson wrote: > Use error_setg() to return an error instead of using an explicit exit(). > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH COLO-Frame v11 25/39] COLO: implement default failover treatment

On 2015/12/11 3:01, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: If we detect some error in colo, we will wait for some time, hoping users also detect it. If users don't issue failover command. We will go into default failover procedure, which the PVM

Re: [Qemu-devel] [PATCH v3 0/9] Introduce I/O channels framework

Ping, unless anyone wants to review this further I'll send a pull request for it once 2.6 opens up, so I can focus on getting the other dependant patch series reviewed & merged in 2.6 too. Regards, Daniel On Wed, Nov 18, 2015 at 06:42:43PM +, Daniel P. Berrange wrote: > This series of

Re: [Qemu-devel] net: vmxnet3: memory leakage issue

Hello Jason, +-- On Fri, 11 Dec 2015, Jason Wang wrote --+ | I think it's possible for attacker. Better wait for Dmitry's answer for | this. Okay. | > +/* Verify if device is active */ | > +if (s->device_active) { | > +VMW_CFPRN("Vmxnet3 device is active"); | > +

Re: [Qemu-devel] [PATCH 1/7] pc: wire up TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE for !xen

On Wed, 9 Dec 2015, Eduardo Habkost wrote: > On Tue, Dec 08, 2015 at 03:07:22PM +0100, Gerd Hoffmann wrote: > > rename pc_xen_hvm_init_pci to pc_i440fx_init_pci, > > use it for both xen and non-xen init. > > > > Signed-off-by: Gerd Hoffmann > > --- > > hw/i386/pc_piix.c | 11

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > My fix (84e7b80a) replaced the last_sent_block update that I'd > removed earlier; however it was too aggressive in the xbzrle case. > > save_xbzrle_page might return '0' to mean

Re: [Qemu-devel] [PATCH 05/11] pseries: Cleanup error handling in spapr_vga_init()

On 11/12/15 01:11, David Gibson wrote: > Use error_setg() to return an error rather than an explicit exit(). > Previously it was an exit(0) instead of a non-zero exit code, which was > simply a bug. > > Also improve the error message. > > Signed-off-by: David Gibson

Re: [Qemu-devel] [PATCH 07/11] pseries: Cleanup error handling in spapr_kvm_type()

On 11/12/15 01:11, David Gibson wrote: > Use error_setg() and _fatal instead of an explicit exit(). > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >

Re: [Qemu-devel] [PATCH 09/11] pseries: Clean up error handling in xics_system_init()

On 11/12/15 01:11, David Gibson wrote: > Use the error handling infrastructure to pass an error out from > try_create_xics() instead of assuming _abort - the caller is in a > better position to decide on error handling policy. > > Signed-off-by: David Gibson > --- >

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

Peter Maydell wrote: D> On 10 December 2015 at 16:31, Dr. David Alan Gilbert (git) > wrote: >> From: "Dr. David Alan Gilbert" >> >> My fix (84e7b80a) replaced the last_sent_block update that I'd >> removed earlier; however it

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > > +switch (iph->ip_v) { > > +case IPVERSION: > > if (iph->ip_dst.s_addr == 0) { > > /* 0.0.0.0 can not be a destination address, something went wrong, > > * avoid making it worse */ > > That indentation looks

Re: [Qemu-devel] [PATCH 08/11] qjson: Simplify by using json-output-visitor

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 11/12/2015 14:42, Eric Blake wrote: >>> compiles and is pretty much a 1:1 translation from the qjson.c >>> API to the visitor API (using this patch as a guide). Feel >>> free to include it and remove qjson.c. Alternatively, you can >>> leave

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote: > Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe > it would be nicer to do it in one go instead (after splitting off the > arp_requested renaming)? Please discuss about it with the people who asked for it. I won't

Re: [Qemu-devel] [PATCH 01/11] ppc: Cleanup error handling in ppc_set_compat()

On 12/10/2015 05:11 PM, David Gibson wrote: > Current ppc_set_compat() returns -1 for errors, and also (unconditionally) > reports an error message. The caller in h_client_architecture_support() > may then report it again using an outdated fprintf(). > > Clean this up by using the modern error

[Qemu-devel] How does TCG gen host code for a TB?

I want to trace a bug in tcg, which for me, at some point, generate infinite loop TB chains, that's unexpected. and I've found the final TB(head, since they're chaining) which run in an infinite loop, and I know a very weird trick to 'disable' this bug, so I would like to track the tcg-ops for

[Qemu-devel] [RFC PATCH 1/3] linux-headers: Update VFIO headers from linux-next tag ToBeFilled

Syncup VFIO related linux headers from linux-next tree using scripts/update-linux-headers.sh. Integrate two VFIO-PCI ioctl flags: - VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED - VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP Signed-off-by: Yongji Xie --- linux-headers/linux/vfio.h |4

[Qemu-devel] [Qemu-trivial][PATCH] trace: reflect the file name change

Some functions was moved from block.c to block/io.c, so the trace-events file should reflect that change. Signed-off-by: Qinghua Jin --- trace-events | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/trace-events b/trace-events index 2fce98e..bec1aa1

[Qemu-devel] [PATCH V2] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

A server can respond different to both methods, or can block one of the two. Signed-off-by: Boris Schrijver Reviewed-by: John Snow --- V2: Impovements over V1: - Don't check for CURLE_WRITE_ERROR, on success CURLE_OK will be returned. - Use

Re: [Qemu-devel] [PATCH 02/11] pseries: Cleanup error handling of spapr_cpu_init()

On 12/10/2015 05:11 PM, David Gibson wrote: > Currently spapr_cpu_init() is hardcoded to handle any errors as fatal. > That works for now, since it's only called from initial setup where an > error here means we really can't proceed. > > However, we'll want to handle this more flexibly for cpu

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

On 11 December 2015 at 12:52, Peter Maydell wrote: > On 11 December 2015 at 12:25, Juan Quintela wrote: >> Peter Maydell wrote: >>> This sounds like we should probably put this into 2.5; I'm happy >>> to do so if it gets

Re: [Qemu-devel] [PATCH 08/11] qjson: Simplify by using json-output-visitor

On 12/11/2015 04:10 AM, Paolo Bonzini wrote: > > > On 11/12/2015 00:53, Eric Blake wrote: >> Instead of rolling our own limited JSON outputter, we can just >> wrap the more full-featured JSON output Visitor. >> >> This slightly changes the output (different spacing), but the >> result is still

Re: [Qemu-devel] [Qemu-block] [PATCH V2] qemu-img / curl: When fetching Content-Size use GET instead of HEAD.

[adding qemu-devel; per http://wiki.qemu.org/Contribute/SubmitAPatch, ALL patches must include qemu-devel, even if they are also copying other sublists] On 12/11/2015 01:40 AM, Boris Schrijver wrote: > A server can respond different to both methods, or can block one of the two. > >

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 15:01, Samuel Thibault wrote: > Just to explain. > > I'm fine with revamping the patches, provided that we eventually > converge somewhere. > > What I'm afraid of is that splitting patches in yet more many pieces, > revamping the code yet more (moving code into their own functions,

Re: [Qemu-devel] [PATCH] Fix xbzrle vs last_sent_block update

On 11 December 2015 at 12:25, Juan Quintela wrote: > Peter Maydell wrote: >> This sounds like we should probably put this into 2.5; I'm happy >> to do so if it gets review by tomorrow afternoon and Juan/Amit >> agree. > > Yeap, did the review by.

Re: [Qemu-devel] How does TCG gen host code for a TB?

On 11 December 2015 at 03:43, Valerón JC wrote: > I want to trace a bug in tcg, which for me, at some point, generate infinite > loop TB chains, that's unexpected. and I've found the final TB(head, since > they're chaining) which run in an infinite loop, and I know a

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 14:38, Thomas Huth wrote: > On 11/12/15 01:15, Samuel Thibault wrote: >> From: Guillaume Subiron >> >> Basically, this patch replaces "arp" by "resolution" every time "arp" >> means "mac resolution" and not specifically ARP. >> >> Some indentation problems are

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Just to explain. I'm fine with revamping the patches, provided that we eventually converge somewhere. What I'm afraid of is that splitting patches in yet more many pieces, revamping the code yet more (moving code into their own functions, etc.) will only make the patch series look even bigger

Re: [Qemu-devel] How does TCG gen host code for a TB?

On 11.12.2015 06:43, Valerón JC wrote: > I want to trace a bug in tcg, which for me, at some point, generate > infinite loop TB chains, that's unexpected. and I've found the final > TB(head, since they're chaining) which run in an infinite loop, and I > know a very weird trick to 'disable' this

Re: [Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch replaces foreign and local address/port couples in Socket > structure by 2 sockaddr_storage which can be casted in sockaddr_in. > Direct access to address and port is still possible thanks to

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: > So maybe it's better to do smaller steps instead: Would it for example > make sense to split the whole series into two parts - first a series > that does all the preparation and cleanup patches. And then once that > has been reviewed and

[Qemu-devel] [RFC PATCH 0/3] vfio/pci: Add support for mmapping sub-page MMIO BARs and MSI-X table

This patch set adds support for two VFIO-PCI ioctl flags: VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED and VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP. Note that the kernel bits of this two flags are not in upstream and posted as . VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED indicates that platform support all PCI MMIO BARs to

[Qemu-devel] [PATCH] Keep pty slave file descriptor open until the master is closed

I have experienced a minor difficulty using QEMU with the "-serial pty" option: If a process opens the slave pts device, writes data to it, then immediately closes it, the data doesn't reliably get delivered to the emulated serial port. This seems to be because a read of the master pty device

[Qemu-devel] [RFC PATCH 2/3] vfio/pci: Add support for mmapped sub-page MMIO BARs

The VFIO-PCI ioctl flag VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED indicates platform support all PCI MMIO BARs to be page aligned and sub-page(size < PAGE_SIZE) MMIO BARs can be mmapped. But this has an issue for these mmapped sub-page MMIO BARs - KVM would not allow to create memory slot for them via

Re: [Qemu-devel] [PATCH for-2.5?] qemu-iotests: Reduce racy output in 028

On 11 December 2015 at 03:27, Eric Blake wrote: > On my machine, './check -qcow2 028' was failing about 80% of the time, > due to a race in how many times the repeated attempts to run 'info > block-jobs' could occur before the job was done, showing up as a > failure of fewer

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > Basically, this patch replaces "arp" by "resolution" every time "arp" > means "mac resolution" and not specifically ARP. > > Some indentation problems are solved in functions that will be modified > in

Re: [Qemu-devel] [PATCH v7 13/31] qapi: Drop unused 'kind' for struct/enum visit

On 12/07/2015 08:55 PM, Eric Blake wrote: > visit_start_struct() and visit_type_enum() had a 'kind' argument > that was usually set to either the stringized version of the > corresponding qapi type name, or to NULL (although some clients > didn't even get that right). But nothing ever used the

Re: [Qemu-devel] [PATCH 06/16] acpi: Save PCMachineState on AcpiBuildState

On Wed, Dec 09, 2015 at 08:37:16PM +0100, Igor Mammedov wrote: > On Tue, 8 Dec 2015 20:44:38 +0200 > Marcel Apfelbaum wrote: > > On 12/08/2015 07:59 PM, Eduardo Habkost wrote: > > > On Mon, Dec 07, 2015 at 05:39:29PM +0200, Marcel Apfelbaum wrote: > > >> On 12/02/2015

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

On Wed, 9 Dec 2015, Ian Campbell wrote: > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > index 5e324ef..c96d974 100644 > > --- a/hw/display/xenfb.c > > +++ b/hw/display/xenfb.c > > @@ -104,9 +104,8 @@ static int

[Qemu-devel] [RFC PATCH 3/3] vfio/pci: Add support for mmapping MSI-X table

The VFIO-PCI ioctl VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP flag indicate that platform support mmapping MSI-X table. With this flag set, we skip some MSI-X table check so that QEMU can mmap MSI-X table successfully. And we also raise the priority of mmap memory region in case of overlap with MSI-X/PBA

[Qemu-devel] tcg/tcg.c ifndef USE_LIVENESS_ANALYSIS code won't compile

Hi; I noticed while grepping through code that the version of tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS won't compile because it's still referring to the no-longer-existent TCGContext::gen_opc_buf. Richard, I think this was probably broken as part of your changes to

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 14:43, Thomas Huth wrote: > On 11/12/15 14:38, Thomas Huth wrote: >> On 11/12/15 01:15, Samuel Thibault wrote: >>> From: Guillaume Subiron >>> >>> Basically, this patch replaces "arp" by "resolution" every time "arp" >>> means "mac resolution" and not specifically

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

On Mon, 7 Dec 2015, Jan Beulich wrote: > >>> On 07.12.15 at 15:56, wrote: > > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >>> On 07.12.15 at 13:45, wrote: > >> > On Tue, 24 Nov 2015, Jan Beulich wrote: > >> >> Now that the

[Qemu-devel] [PATCH] checkpatch: Detect newlines in error_report and other error functions

We don't want newlines embedded in error messages. This seems to be a common problem with new code so let's try to catch it with checkpatch. This does not catch the newline when it is in a multiline statement. This is quite a bit more difficult and can be handled as follow on work.

[Qemu-devel] [PATCH 08/10] hw/sd/pxa2xx_mmci: Update to use new SDBus APIs

Now the PXA2xx MMCI device is QOMified itself, we can update it to use the SDBus APIs to talk to the SD card. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 80 +++-- 1 file changed, 66 insertions(+), 14

[Qemu-devel] [PATCH 06/10] sdhci_sysbus: Create SD card device in users, not the device itself

Move the creation of the SD card device from the sdhci_sysbus device itself into the boards that create these devices. This allows us to remove the cannot_instantiate_with_device_add notation because we no longer call drive_get_next in the device model. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 10/10] hw/sd/pxa2xx_mmci: Add reset function

Add a reset function to the pxa2xx_mmci device; previously it had no handling for system reset at all. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/sd/pxa2xx_mmci.c

[Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: blockdev: Mark {insert, remove}-medium experimental (2015-12-11 15:39:29 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-12-11 for you to fetch

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

On 11 December 2015 at 17:01, Stefano Stabellini wrote: > On Fri, 11 Dec 2015, Peter Maydell wrote: >> On 11 December 2015 at 16:52, Stefano Stabellini >> wrote: >> If this was intended for 2.5 you have missed the boat. > > I

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 11/12/15 15:55, Samuel Thibault wrote: > Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: >> So maybe it's better to do smaller steps instead: Would it for example >> make sense to split the whole series into two parts - first a series >> that does all the preparation and cleanup patches.

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 12/11/2015 08:23 AM, Max Reitz wrote: > While in the long term we want throttling to be its own block filter > BDS, in the short term we want it to be part of the BB instead of a BDS; > even in the long term we may want legacy throttling to be automatically > tied to the BB. > >

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 11 December 2015 at 15:43, Max Reitz wrote: > On 2015-12-11 at 16:40, Peter Maydell wrote: >> >> On 11 December 2015 at 15:30, Eric Blake wrote: >>> >>> On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

On Fri, 11 Dec 2015, Ian Campbell wrote: > On Fri, 2015-12-11 at 14:26 +, Stefano Stabellini wrote: > > On Wed, 9 Dec 2015, Ian Campbell wrote: > > > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > > > index

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

On Fri, 11 Dec 2015, Jan Beulich wrote: > >>> On 11.12.15 at 15:33, wrote: > > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >>> On 07.12.15 at 15:56, wrote: > >> > On Mon, 7 Dec 2015, Jan Beulich wrote: > >> >> >>> On 07.12.15 at

[Qemu-devel] [PATCH 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

This series attempts to QOMify sd.c (the actual SD card model), including a proper QOM bus between the controller and the card. This series removes the experimental x-drive property on sdhci-pci; the syntax for using that device changes: instead of using the x-drive property: -device

[Qemu-devel] [PATCH 04/10] hw/sd: Add QOM bus which SD cards plug in to

Add a QOM bus for SD cards to plug in to. Note that since sd_enable() is used only by one board and there only as part of a broken implementation, we do not provide it in the SDBus API (but instead add a warning comment about the old function). Whoever converts OMAP and the nseries boards to QOM

[Qemu-devel] [PATCH 02/10] hw/sd/sd.c: QOMify

Turn the SD card into a QOM device. This conversion only changes the device itself; the various functions which are effectively methods on the device are not touched at this point. Signed-off-by: Peter Maydell --- hw/sd/sd.c | 99

[Qemu-devel] [PATCH 03/10] hw/sd/sd.c: Convert sd_reset() function into Device reset method

Convert the sd_reset() function into a proper Device reset method. Signed-off-by: Peter Maydell --- hw/sd/sd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 7c79217..b4a5a62 100644 --- a/hw/sd/sd.c +++

[Qemu-devel] [PULL 1/1] xen_disk: treat "vhd" as "vpc"

The Xen toolstack uses "vhd" to specify a disk in VHD format, however the name of the driver in QEMU is "vpc". Replace "vhd" with "vpc", so that QEMU can find the right driver to use for it. Signed-off-by: Stefano Stabellini --- hw/block/xen_disk.c |3 +++

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

On Fri, 11 Dec 2015, Peter Maydell wrote: > On 11 December 2015 at 16:52, Stefano Stabellini > wrote: > > The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: > > > > blockdev: Mark {insert, remove}-medium experimental (2015-12-11

[Qemu-devel] [PATCH 01/10] hw/sd/sdhci.c: Remove x-drive property

The following commits will remove support for the old sdhci-pci command line syntax using the x-drive property: -device sdhci-pci,x-drive=mydrive -drive id=mydrive,[...] and replace it with an explicit sd device: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive (This is OK

[Qemu-devel] [PATCH 07/10] hw/sd/pxa2xx_mmci: convert to SysBusDevice object

Convert the pxa2xx_mmci device to be a sysbus device. In this commit we only change the device itself, and leave the interface to the SD card using the old non-SDBus APIs. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 73

[Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

Update the SDHCI code to use the new SDBus APIs. This commit introduces the new command line options required to connect a disk to sdhci-pci: -device sdhci-pci -drive id=mydrive,[...] -device sd,drive=mydrive Signed-off-by: Peter Maydell --- hw/sd/sdhci.c |

[Qemu-devel] [PATCH 09/10] hw/sd/pxa2xx_mmci: Convert to VMStateDescription

Convert the pxa2xx_mmci device from manual save/load functions to a VMStateDescription structure. This is a migration compatibility break. Signed-off-by: Peter Maydell --- hw/sd/pxa2xx_mmci.c | 148 1 file changed,

Re: [Qemu-devel] [PULL 0/1] tags/xen-2015-12-11

On 11 December 2015 at 16:52, Stefano Stabellini wrote: > The following changes since commit 6e0abc251dd4f8eba1f53656dfede12e5840e83b: > > blockdev: Mark {insert, remove}-medium experimental (2015-12-11 15:39:29 > +) > > are available in the git repository

Re: [Qemu-devel] [Xen-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

On Fri, 2015-12-11 at 16:44 +, Stefano Stabellini wrote: >   > It is not possible to do this at runtime. I think we should do this at > compile time because in any case it is not supported to run a QEMU built > for a given Xen version on a different Xen version. I am currently working pretty

[Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

While in the long term we want throttling to be its own block filter BDS, in the short term we want it to be part of the BB instead of a BDS; even in the long term we may want legacy throttling to be automatically tied to the BB. blockdev-insert-medium and blockdev-remove-medium do not retain

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

On Fri, 2015-12-11 at 14:26 +, Stefano Stabellini wrote: > On Wed, 9 Dec 2015, Ian Campbell wrote: > > On Thu, 2015-12-03 at 11:23 +, Ian Campbell wrote: > > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > > > index 5e324ef..c96d974 100644 > > > --- a/hw/display/xenfb.c > > > +++

Re: [Qemu-devel] How does TCG gen host code for a TB?

Peter and Sergey, Thank you so much for your help and explanation. I appreciate your helps very much. Sent from Mail for Windows 10 From: Sergey Fedorov Sent: Friday, December 11, 2015 10:21 PM To: Valerón JC;qemu-devel@nongnu.org Subject: Re: [Qemu-devel] How does TCG gen host code for a TB?

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

Laszlo Ersek, on Fri 11 Dec 2015 16:40:32 +0100, wrote: > > Sounds good, ... then I'd suggest to sent the preparation patches > > separately next time and get them accepted first. > > And then the next reviewer will say, "nice, but it would be even nicer > to see what *motivates* these

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch makes solookup() compatible with varying address families. Also, > this function was only compatible with TCP. Having the socket list in > argument, it is now compatible with UDP too. Finally,

Re: [Qemu-devel] [PATCH 11/11] pseries: Clean up error reporting in htab migration functions

On 12/10/2015 05:11 PM, David Gibson wrote: > The functions for migrating the hash page table on pseries machine type > (htab_save_setup() and htab_load()) can report some errors with an > explicit fprintf() before returning an appropriate eror code. Change these > to use error_report() instead.

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 2015-12-11 at 16:40, Peter Maydell wrote: On 11 December 2015 at 15:30, Eric Blake wrote: On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium +x-blockdev-remove-medium -- Formatting nit, but not worth holding this up (as it is

Re: [Qemu-devel] [PATCH 03/11] pseries: Clean up hash page table allocation error handling

On 12/10/2015 05:11 PM, David Gibson wrote: > The spapr_alloc_htab() and spapr_reset_htab() functions currently handle > all errors with error_setg(_abort, ...). That's correct for > spapr_reset_htab() - if anything goes wrong there, there's really nothing > we can do about it. For

[Qemu-devel] [PATCH for-2.5 0/1] blockdev: Mark {insert, remove}-medium experimental

Hello Peter, After having talked about the current status of the block layer today, Markus, Kevin and me agreed to mark the newly introduced QMP commands blockdev-insert-medium and blockdev-remove-medium experimental after all (due to possible interference of its current status with future

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

On 11 December 2015 at 15:30, Eric Blake wrote: > On 12/11/2015 08:23 AM, Max Reitz wrote: >> >> SQMP >> -blockdev-remove-medium >> +x-blockdev-remove-medium >> -- > > Formatting nit, but not worth holding this up (as it is really our last > chance to get

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

meta On 12/11/15 16:09, Thomas Huth wrote: > On 11/12/15 15:55, Samuel Thibault wrote: >> Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: >>> So maybe it's better to do smaller steps instead: Would it for example >>> make sense to split the whole series into two parts - first a series >>>

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

>>> On 11.12.15 at 15:33, wrote: > On Mon, 7 Dec 2015, Jan Beulich wrote: >> >>> On 07.12.15 at 15:56, wrote: >> > On Mon, 7 Dec 2015, Jan Beulich wrote: >> >> >>> On 07.12.15 at 13:45, wrote:

Re: [Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

On 11/12/15 01:15, Samuel Thibault wrote: > From: Guillaume Subiron > > This patch simply adds a sa_family_t argument to remove the hardcoded > "AF_INET" in the call of qemu_socket(). > > Signed-off-by: Guillaume Subiron > Signed-off-by: Samuel

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

On 12/11/2015 08:40 AM, Laszlo Ersek wrote: > meta > > On 12/11/15 16:09, Thomas Huth wrote: >> On 11/12/15 15:55, Samuel Thibault wrote: >>> Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: So maybe it's better to do smaller steps instead: Would it for example make sense to split

Re: [Qemu-devel] [PATCH 05/10] hw/sd/sdhci.c: Update to use SDBus APIs

On 11 December 2015 at 19:01, Kevin O'Connor wrote: > On Fri, Dec 11, 2015 at 04:37:06PM +, Peter Maydell wrote: >> Update the SDHCI code to use the new SDBus APIs. >> >> This commit introduces the new command line options required >> to connect a disk to sdhci-pci: >> >>

Re: [Qemu-devel] [PATCH v3 3/4] target-tilegx: Add double floating point implementation

On 12/11/15 05:17, Richard Henderson wrote: > On 12/10/2015 06:15 AM, Chen Gang wrote: >> +#define TILEGX_F_MAN_HBIT (1ULL << 59) > ... >> +static uint64_t fr_to_man(float64 d) >> +{ >> +uint64_t val = get_f64_man(d) << 7; >> + >> +if (get_f64_exp(d)) { >> +val |=

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On 12/11/2015 04:40 PM, Programmingkid wrote: > I guess the commit message is a little out of date. How about this: > > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a

Re: [Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

Hello, Thomas, this is the last refactoring patch which doesn't have a review yet, right? Samuel Samuel Thibault, on Fri 11 Dec 2015 01:15:17 +0100, wrote: > From: Guillaume Subiron > > This patch factorizes some duplicate code into a new function, > sotranslate_out().

Re: [Qemu-devel] [Qemu-block] ping [PATCH v11] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

On Dec 11, 2015, at 5:00 PM, Jeff Cody wrote: > On Thu, Dec 10, 2015 at 09:39:51AM -0500, Programmingkid wrote: >> https://patchwork.ozlabs.org/patch/550295/ >> >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be

Re: [Qemu-devel] [PATCH] target-*: Get rid of "PC advancement" trick

On 12/10/2015 10:47 AM, Sergey Fedorov wrote: The "PC advancement" trick was used just after recognizing that a breakpoint exception was going to be generated. This trick has had two points: 1. Guarantee that tb->size isn't zero: there are many places where it's expected to be non-zero.

  1   2   >