Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

On Wed, Apr 27, 2016 at 04:31:13PM +0200, Radim Krčmář wrote: [...] > >> > I am still looking into guest part codes. Although the above patch > >> > should solve the issue, there are still issues in guest codes when > >> > IR is enabled: > >> > > >> > - mismatched "vector" in IOAPIC entry and

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

On Fri, Apr 01, 2016 at 01:16:21PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > docs/specs/vhost-user.txt | 15 +++ > hw/virtio/vhost-user.c| 16

Re: [Qemu-devel] [PATCH 2/2] Debug : Add error messages before a call to debug().

Hi Eric, Thank you for the review. On Wed, Apr 27, 2016 at 9:30 PM, Eric Blake wrote: > On 04/14/2016 09:02 PM, Prerna Saxena wrote: > > Qemu code has abort() calls in various places which raises a SIGABRT; > > This patch adds error messages before (most)calls to abort(), so

Re: [Qemu-devel] [PATCH 04/18] char: add wait support for reconnect

On Fri, Apr 01, 2016 at 01:16:14PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Until now, 'wait' was solely used for listening sockets. However, it can > also be useful for 'reconnect' socket kind, where the first open must > succeed

Re: [Qemu-devel] Hang with migration multi-thread compression under high load

> I've been testing various features of migration and have hit a problem with > the multi-thread compression. It works fine when I have 2 or more threads, > but if I tell it to only use a single thread, then it almost always hangs > > I'm doing a migration between 2 guests on the same machine

Re: [Qemu-devel] post-copy is broken?

> -Original Message- > From: Andrea Arcangeli [mailto:aarca...@redhat.com] > Sent: Wednesday, April 27, 2016 10:48 PM > To: Li, Liang Z > Cc: Dr. David Alan Gilbert; Kirill A. Shutemov; > kirill.shute...@linux.intel.com; > Amit Shah; qemu-devel@nongnu.org; quint...@redhat.com; linux- >

Re: [Qemu-devel] Hang with migration multi-thread compression under high load

> On Wed, Apr 27, 2016 at 03:29:30PM +0100, Dr. David Alan Gilbert wrote: > > ccing in Liang Li > > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > for some reason it isn't shown in the stack thrace for thread > > > 1 above, when initially connecting GDB it says the main thread is > >

Re: [Qemu-devel] [Query] Does Linux & Qemu support KVM for ARM32 guest on ARM64 host

On 2016/4/28 9:50, RAVINDRA KUMAR SANDE wrote: > > What I did : > 1) Just for investigation, I took a ARMv8 ( OdroidC2 ) board > 2) I compiled Linux 3.14 with KVM support for this ARMv8 ( OdroidC2 ) > board, with modification replacing meson_timer by arm timer in its dts > file. > Why Linux

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Wed, 04/27 13:18, Jason Dillaman wrote: > On Tue, Apr 26, 2016 at 7:20 PM, Fam Zheng wrote: > > On Tue, 04/26 10:42, Jason Dillaman wrote: > >> On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > >> > On Fri, 04/22 21:57, Jason Dillaman wrote: > >> >> Since

Re: [Qemu-devel] [PATCH qemu v15 14/17] spapr_iommu, vfio, memory: Notify IOMMU about starting/stopping being used by VFIO

On Wed, Apr 27, 2016 at 07:14:15PM +1000, Alexey Kardashevskiy wrote: > On 04/27/2016 04:39 PM, David Gibson wrote: > >On Thu, Apr 21, 2016 at 02:22:01PM +1000, Alexey Kardashevskiy wrote: > >>On 04/21/2016 01:59 PM, David Gibson wrote: > >>>On Wed, Apr 20, 2016 at 07:15:15PM +1000, Alexey

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

On Apr 27, 2016, at 2:34 AM, Thomas Huth wrote: > On 26.04.2016 22:19, Programmingkid wrote: >> >> On Apr 26, 2016, at 4:12 PM, Thomas Huth wrote: >> >>> On 26.04.2016 21:25, Programmingkid wrote: On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: > *

[Qemu-devel] [PATCH v15 19/23] qapi: Split visit_end_struct() into pieces

As mentioned in previous patches, we want to call visit_end_struct() functions unconditionally, so that visitors can release resources tied up since the matching visit_start_struct() without also having to worry about error priority if more than one error occurs. Even though error_propagate() can

[Qemu-devel] [PATCH v15 22/23] qapi: Simplify semantics of visit_next_list()

The semantics of the list visit are somewhat baroque, with the following pseudocode when FooList is used: start() for (prev = head; cur = next(prev); prev = ) { visit(>value) } Note that these semantics (advance before visit) requires that the first call to next() return the list head, while

[Qemu-devel] [PATCH v15 23/23] qapi: Change visit_type_FOO() to no longer return partial objects

Returning a partial object on error is an invitation for a careless caller to leak memory. We already fixed things in an earlier patch to guarantee NULL if visit_start fails ("qapi: Guarantee NULL obj on input visitor callback error"), but that does not help the case where visit_start succeeds

[Qemu-devel] [PATCH v15 21/23] qapi: Fix string input visitor handling of invalid list

As shown in the previous commit, the string input visitor was treating bogus input as an empty list rather than an error. Fix parse_str() to set errp, then the callers to exit early if an error was reported. Also, make sure the error message for visit_type_uint64() gracefully handles a NULL

[Qemu-devel] [PATCH v15 20/23] tests/string-input-visitor: Add negative integer tests

From: Markus Armbruster Add two negative tests, one for int and one for int16List. The latter exposes a bug: nonsensical input results in an empty list instead of an error. Signed-off-by: Markus Armbruster Message-Id:

[Qemu-devel] [PATCH v15 15/23] qmp: Support explicit null during visits

Implement the new type_null() callback for the qmp input and output visitors. While we don't yet have a use for this in QAPI input (the generator will need some tweaks first), some potential usages have already been discussed on the list. Meanwhile, the output visitor could already output explicit

[Qemu-devel] [PATCH v15 17/23] qmp: Add qmp_output_visitor_reset()

Add a new qmp_output_visitor_reset(), to make it easier for a caller to reset all state while still reusing an existing visitor, regardless of whether the previous visit was successfully completed. Then use it in the testsuite. The tests needing patching were found by tightening asserts in the

Re: [Qemu-devel] [RFC for-2.7 01/11] qdt: IEEE1275-style device tree utility code

On Wed, Apr 27, 2016 at 09:28:57AM +0200, Markus Armbruster wrote: > Thomas Huth writes: > > > On 27.04.2016 08:43, Markus Armbruster wrote: > >> David Gibson writes: > >> > >>> On Tue, Apr 26, 2016 at 01:00:06PM +0200, Thomas Huth wrote: >

[Qemu-devel] [PATCH v15 13/23] tests: Add check-qnull

Add a new test, for checking reference counting of qnull(). As part of the new file, move a previous reference counting change added in commit a861564 to a more logical place. Note that while most of the check-q*.c leave visitor stuff to the test-qmp-*-visitor.c, in this case we actually want the

[Qemu-devel] [PATCH v15 11/23] qmp-input: Refactor when list is advanced

In the QMP input visitor, visiting a list traverses two objects: the QAPI GenericList of the caller (which gets advanced in visit_next_list() regardless of this patch), and the QList input that we are converting to QAPI. For consistency with QDict visits, we want to consume elements from the

[Qemu-devel] [PATCH v15 12/23] qapi: Document visitor interfaces, add assertions

The visitor interface for mapping between QObject/QemuOpts/string and QAPI is scandalously under-documented, making changes to visitor core, individual visitors, and users of visitors difficult to coordinate. Among other questions: when is it safe to pass NULL, vs. when a string must be provided;

[Qemu-devel] [PATCH v15 04/23] qmp-input: Clean up stack handling

Management of the top of stack was a bit verbose; creating a temporary variable and adding some comments makes the existing code more legible before the next few patches improve things. No semantic changes other than asserting that we are always visiting a QObject, and not a NULL value. In

[Qemu-devel] [PATCH v15 01/23] qapi-visit: Add visitor.type classification

We have three classes of QAPI visitors: input, output, and dealloc. Currently, all implementations of these visitors have one thing in common based on their visitor type: the implementation used for the visit_type_enum() callback. But since we plan to add more such common behavior, in relation to

[Qemu-devel] [PATCH v15 16/23] spapr_drc: Expose 'null' in qom-get when there is no fdt

Now that the QMP output visitor supports an explicit null output, we should utilize it to make it easier to diagnose the difference between a missing fdt ('null') vs. a present-but-empty one ('{}'). (Note that this reverts the behavior of commit ab8bf1d, taking us back to the behavior of commit

[Qemu-devel] [PATCH v15 08/23] monitor: Let generated code validate arguments

Having to manually call out the set of expected arguments in qmp-commands.hx, in addition to what is already in *.json, is tedious and prone to error. The only reason we use .args_type is for checking if there is any excess arguments or incorrectly typed arguments during qmp_check_client_args(),

[Qemu-devel] [PATCH v15 05/23] qapi: Use strict QMP input visitor in more places

Rather than having two separate ways to create a QMP input visitor, where the safer approach has the more verbose name, it is better to consolidate things into a single function where the caller must explicitly choose whether to be strict or to ignore excess input. Use strict mode in more places

[Qemu-devel] [PATCH v15 02/23] qapi: Guarantee NULL obj on input visitor callback error

Our existing input visitors were not very consistent on errors in a function taking 'TYPE **obj' (that is, start_struct(), start_alternate(), next_list(), type_str(), and type_any()). While all of them set '*obj' to allocated storage on success, it was not obvious whether '*obj' was guaranteed

[Qemu-devel] [PATCH v15 10/23] qmp-input: Require struct push to visit members of top dict

Don't embed the root of the visit into the stack of current containers being visited. That way, we no longer get confused on whether the first visit of a dictionary is to the dictionary itself or to one of the members of the dictionary, based on whether the caller passed name=NULL; and makes the

[Qemu-devel] [PATCH v15 07/23] qapi-commands: Wrap argument visit in visit_start_struct

The qmp-input visitor was allowing callers to play rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict; among the culprit callers was the generated marshal code on the 'arguments' dictionary of a QMP command. But we are

[Qemu-devel] [PATCH v15 18/23] qmp: Tighten output visitor rules

Tighten assertions in the QMP output visitor, so that: - qmp_output_get_qobject() can only be called after pairing a visit_end_* for every visit_start_* (rather than allowing it on a partially built object) - qmp_output_get_qobject() cannot be called unless at least one visit_type_* or

[Qemu-devel] [PATCH v15 09/23] qom: Wrap prop visit in visit_start_struct

The qmp-input visitor was allowing callers to play rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict; the final such culprit was the QOM code for converting to and from object properties. But we are about to tighten the

[Qemu-devel] [PATCH v15 14/23] qapi: Add visit_type_null() visitor

Right now, qmp-output-visitor happens to produce a QNull result if nothing is actually visited between the creation of the visitor and the request for the resulting QObject. A stronger protocol would require that a QMP output visit MUST visit something. But to still be able to produce a JSON

[Qemu-devel] [PATCH v15 00/23] qapi visitor cleanups (post-introspection cleanups subset E)

2.7 material; hopefully this iteration is close enough for Markus to stick it in his qapi-next staging branch, so we can move on to my other pending series. Based on master, with no prerequisite patches. Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git

[Qemu-devel] [PATCH v15 06/23] qmp-input: Don't consume input when checking has_member

Commit e8316d7 mistakenly passed consume=true within qmp_input_optional() when checking if an optional member was present, but the mistake was silently ignored since the code happily let us extract a member more than once. Fix qmp_input_optional() to not consume anything, then tighten up the

[Qemu-devel] [PATCH v15 03/23] qmp: Drop dead command->type

Ever since QMP was first added back in commit 43c20a43, we have never had any QmpCommandType other than QCT_NORMAL. It's pointless to carry around the cruft. Signed-off-by: Eric Blake --- v15: no change v14: no change v13: no change v12: new patch ---

[Qemu-devel] [PATCH] target-mips: Fix RDHWR exception host PC

Commit b00c72180c36 ("target-mips: add PC, XNP reg numbers to RDHWR") changed the rdhwr helpers to use check_hwrena() to check the register being accessed is enabled in CP0_HWREna when used from user mode. If that check fails an EXCP_RI exception is raised at the host PC calculated with GETPC().

Re: [Qemu-devel] [PATCH v14 19/19] qapi: Change visit_type_FOO() to no longer return partial objects

On 04/15/2016 08:49 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Returning a partial object on error is an invitation for a careless >> caller to leak memory. As no one outside the testsuite was actually >> relying on these semantics, it is cleaner to just document

Re: [Qemu-devel] [PATCH v14 18/19] qapi: Simplify semantics of visit_next_list()

On 04/22/2016 05:35 AM, Markus Armbruster wrote: static void -start_list(Visitor *v, const char *name, Error **errp) +start_list(Visitor *v, const char *name, GenericList **list, size_t size, + +parse_str(siv, ); +if (err) { +*list = NULL;

Re: [Qemu-devel] [PATCH 2/4] Postcopy: Add stats on page requests

On 04/27/2016 01:08 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > On the source, add a count of page requests received from the > destination. > > Signed-off-by: Dr. David Alan Gilbert > --- > hmp.c

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, 2016-04-27 at 21:17 +0300, Michael S. Tsirkin wrote: > > > Because it's a dirty hack in the *wrong* place. > > No one came up with a better one so far :( Seriously? Take a look at drivers/iommu/intel-iommu.c. It has quirks for all kinds of shitty devices that have to be put in

[Qemu-devel] [PATCH 4/4] tests: fix libqtest socket timeouts

From: Andrea Arcangeli I kept getting timeouts and unix socket accept failures under high load, the patch fixes it. Signed-off-by: Andrea Arcangeli --- tests/libqtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 2/4] Postcopy: Add stats on page requests

From: "Dr. David Alan Gilbert" On the source, add a count of page requests received from the destination. Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 4 +++ include/migration/migration.h | 2 ++ migration/migration.c

[Qemu-devel] [PATCH 3/4] test: Postcopy

From: "Dr. David Alan Gilbert" This is a postcopy test (x86 only) that actually runs the guest and checks the memory contents. The test runs from an x86 boot block with the hex embedded in the test; the source for this is: ... .code16 .org 0x7c00 .file

[Qemu-devel] [PATCH 0/4] postcopy (& 1 test) patch for 2.7

From: "Dr. David Alan Gilbert" Hi, This is a small set of postcopy changes, the largest of which is an x86 test for postcopy. Andrea's libqtest change came about from running my test under very heavy load. The test includes a self contained migration workload that

[Qemu-devel] [PATCH 1/4] Postcopy: Avoid 0 length discards

From: "Dr. David Alan Gilbert" The discard code in migration/ram.c would send request for zero length discards in the case where no discards were needed. It doesn't appear to have had any bad effect. Signed-off-by: Dr. David Alan Gilbert ---

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

Quoting Igor Mammedov (2016-04-27 09:34:53) > On Wed, 27 Apr 2016 15:59:52 +0200 > Thomas Huth wrote: > > > On 27.04.2016 15:37, Igor Mammedov wrote: > > > On Tue, 26 Apr 2016 16:03:37 -0500 > > > Michael Roth wrote: > > > > > >> Quoting Igor

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 04:15:35PM +0100, David Woodhouse wrote: > On Wed, 2016-04-27 at 18:05 +0300, Michael S. Tsirkin wrote: > > > > I really don't get it. > > > > There's exactly one device that works now and needs the work-around and > > so that we need to support, and that is virtio. It

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Tue, Apr 26, 2016 at 7:20 PM, Fam Zheng wrote: > On Tue, 04/26 10:42, Jason Dillaman wrote: >> On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: >> > On Fri, 04/22 21:57, Jason Dillaman wrote: >> >> Since this cannot automatically recover from a crashed QEMU

Re: [Qemu-devel] Wiki account request

Am 27.04.2016 um 19:33 schrieb Bastian Koppelmann: > Hi, > > can someone create an account (username: kbastian) on the qemu wiki for > me, such that I can update the changelog regularly for TriCore? > > Thanks, > Bastian Done. Cheers Stefan

[Qemu-devel] Wiki account request

Hi, can someone create an account (username: kbastian) on the qemu wiki for me, such that I can update the changelog regularly for TriCore? Thanks, Bastian

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

On Wed, 27 Apr 2016 16:39:58 +0200 Pradeep Kiruvale wrote: > On 27 April 2016 at 10:38, Alberto Garcia wrote: > > > On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote: > > > > > Thanks for the reply. I am still in the early phase, I

Re: [Qemu-devel] [PATCH for-2.6 2/3] replay: Fix dangling location bug in replay_configure()

On Wed, Apr 27, 2016 at 04:29:08PM +0200, Markus Armbruster wrote: > replay_configure() pushes and pops a Location with automatic storage > duration. Except it fails to pop when -icount parameter "rr" isn't > given. cur_loc then points to unused stack space, and will most > likely get clobbered

Re: [Qemu-devel] [PATCH v5] qemu-img: check block status of backing file when converting.

On 27.04.2016 18:04, Ren Kimura wrote: > When converting images, check the block status of its backing file chain > to avoid needlessly reading zeros. > > Signed-off-by: Ren Kimura > --- > qemu-img.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] Block: Cleanup vvfat.c to remove dead code.

Prerna Saxena writes: > Commit 43dc2a64 replaced assert() with abort(), but didnt remove statements > that followed these calls. So current code still has return values set after > a call to abort(). Such statements will never execute and need to be cleaned > up. > >

[Qemu-devel] [PATCH v5] qemu-img: check block status of backing file when converting.

When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura --- qemu-img.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

Re: [Qemu-devel] [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled

On Wed, Apr 27, 2016 at 05:57:30PM +0200, Andrea Arcangeli wrote: > couldn't do a fix as cleaner as this one for 4.6. ehm "cleaner then" If you've suggestions for a better name than PageTransCompoundMap I can respin a new patch though, I considered "CanMap" but I opted for the short version.

Re: [Qemu-devel] [PATCH 2/2] Debug : Add error messages before a call to debug().

On 04/14/2016 09:02 PM, Prerna Saxena wrote: > Qemu code has abort() calls in various places which raises a SIGABRT; > This patch adds error messages before (most)calls to abort(), so that > it is easier to determine why QEMU died. The subject line says you are adding messages before debug(), but

Re: [Qemu-devel] [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled

On Wed, Apr 27, 2016 at 06:18:34PM +0300, Kirill A. Shutemov wrote: > Okay, I see. > > But do we really want to make PageTransCompoundMap() visiable beyond KVM > code? It looks like too KVM-specific. Any other secondary MMU notifier manager (KVM is just one of the many MMU notifier users) will

Re: [Qemu-devel] [RFC PATCH resend 00/11] Make CoMutex/CoQueue/CoRwlock thread-safe

On Tue, Apr 26, 2016 at 11:54:19AM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 15, 2016 at 01:31:55PM +0200, Paolo Bonzini wrote: > > [this time including the mailing list] > > > > This is yet another tiny bit of the multiqueue work, this time affecting > > the synchronization infrastructure for

Re: [Qemu-devel] Working on AF_VSOCK packet capture

On Tue, Apr 26, 2016 at 04:44:25PM +, Gerard wrote: > My name is Gerard Garcia and I have been funded by GSOC16 to work on a > device driver to allow capturing host/guest traffic through AF_VSOCK > sockets: http://qemu-project.org/Features/VirtioVsock > > I'll mostly work on the Linux kernel

Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface

On 04/27/2016 03:52 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/bochs.c | 46 +- > 1 file changed, 29 insertions(+), 17 deletions(-) > > static void bochs_close(BlockDriverState *bs) > @@ -267,7 +279,7 @@ static

Re: [Qemu-devel] [PATCH 05/17] block: Introduce .bdrv_co_preadv/pwritev BlockDriver function

On 04/27/2016 03:52 AM, Kevin Wolf wrote: > Many parts of the block layer are already byte granularity. The block > driver interface, however, was still missing an interface that allows > making use of this. This patch introduces a new BlockDriver interface, > which is based on coroutines,

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

Peter Maydell writes: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before

Re: [Qemu-devel] [PATCH 2/2] Debug : Add error messages before a call to debug().

On Fri, Apr 15, 2016 at 08:32:54AM +0530, Prerna Saxena wrote: > diff --git a/block/block-backend.c b/block/block-backend.c > index d74f670..0aa8692 100644 > --- a/block/block-backend.c > +++ b/block/block-backend.c > @@ -407,6 +407,7 @@ BlockBackend *blk_by_legacy_dinfo(DriveInfo *dinfo) >

Re: [Qemu-devel] [PATCH for-2.6 3/3] qom: -object error messages lost location, restore it

"Daniel P. Berrange" writes: > On Wed, Apr 27, 2016 at 04:29:09PM +0200, Markus Armbruster wrote: >> qemu_opts_foreach() runs its callback with the error location set to >> the option's location. Any errors the callback reports use the >> option's location automatically. >>

Re: [Qemu-devel] [RFC 00/11] Current MTTCG kvm-unit-test patches

On Wed, Apr 27, 2016 at 04:09:00PM +0100, Alex Bennée wrote: > > Andrew Jones writes: > > > On Fri, Feb 26, 2016 at 01:15:22PM +, Alex Bennée wrote: > >> Hi, > >> > >> Some of these patches have been posted before and previous patches > >> have already been accepted

Re: [Qemu-devel] [PATCH for-2.6 3/3] qom: -object error messages lost location, restore it

On 04/27/2016 08:29 AM, Markus Armbruster wrote: > qemu_opts_foreach() runs its callback with the error location set to > the option's location. Any errors the callback reports use the > option's location automatically. > > Commit 90998d5 moved the actual error reporting from "inside" >

Re: [Qemu-devel] [PATCH v3 for-2.7 0/8] blockdev: (Nearly) free clean-up work

Am 08.04.2016 um 19:10 hat Max Reitz geschrieben: > After a lot has been restructed in the block layer in the past, we can > now reap at least one of the fruits: Make bdrv_open() return a BDS! > > > This series depends on the following series/patches: > - Revert "block: Forbid I/O throttling on

Re: [Qemu-devel] [PATCH 1/2] Block: Cleanup vvfat.c to remove dead code.

On Fri, Apr 15, 2016 at 08:32:53AM +0530, Prerna Saxena wrote: > Commit 43dc2a64 replaced assert() with abort(), but didnt remove statements > that followed these calls. So current code still has return values set after > a call to abort(). Such statements will never execute and need to be cleaned

Re: [Qemu-devel] [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled

On Wed, Apr 27, 2016 at 04:59:57PM +0200, Andrea Arcangeli wrote: > On Wed, Apr 27, 2016 at 04:50:30PM +0300, Kirill A. Shutemov wrote: > > I know nothing about kvm. How do you protect against pmd splitting between > > get_user_pages() and the check? > > get_user_pages_fast() runs fully lockless

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 7:54 AM, Michael S. Tsirkin wrote: > On Wed, Apr 27, 2016 at 07:43:07AM -0700, Andy Lutomirski wrote: >> On Wed, Apr 27, 2016 at 7:38 AM, Michael S. Tsirkin wrote: >> > On Wed, Apr 27, 2016 at 07:31:43AM -0700, Andy Lutomirski wrote: >>

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, 2016-04-27 at 18:05 +0300, Michael S. Tsirkin wrote: > > I really don't get it. > > There's exactly one device that works now and needs the work-around and > so that we need to support, and that is virtio. It happens to have > exactly the same issue on all platforms. False. We have

Re: [Qemu-devel] [PATCH v4 1/1] qemu-img: check block status of backing file when converting.

Aha. I realized what bdrv_get_block_status_above(bs, NULL...) meant. Sorry for many times resendings. I'll fix it next time then. Ren

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 04:58:51PM +0200, Joerg Roedel wrote: > On Wed, Apr 27, 2016 at 05:54:57PM +0300, Michael S. Tsirkin wrote: > > Point is, QEMU is not the only virtio implementation out there. > > So we can't know no virtio implementations have an IOMMU as long as > > linux supports this

Re: [Qemu-devel] [RFC 00/11] Current MTTCG kvm-unit-test patches

Andrew Jones writes: > On Fri, Feb 26, 2016 at 01:15:22PM +, Alex Bennée wrote: >> Hi, >> >> Some of these patches have been posted before and previous patches >> have already been accepted upstream so I'm tagging this as a new RFC >> series. >> >> This is a series of

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 04:56:32PM +0200, Joerg Roedel wrote: > On Wed, Apr 27, 2016 at 05:34:30PM +0300, Michael S. Tsirkin wrote: > > On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote: > > > QEMU can choose to bypass IOMMU for one device and not the other. > > IOMMU in QEMU isn't

Re: [Qemu-devel] [PATCH for-2.7 3/9] s390x/ipl: Extend the IplParameterBlock struct

On Wed, 27 Apr 2016 15:43:45 +0200 Christian Borntraeger wrote: > On 04/25/2016 05:18 PM, Cornelia Huck wrote: > > > > +union { > > +IplBlockCcw ccw; > > +IplBlockCcw fcp; > > you later fix this up in patch > s390x/ipl: Provide ipl

Re: [Qemu-devel] [PATCH for-2.6 2/3] replay: Fix dangling location bug in replay_configure()

On 04/27/2016 08:29 AM, Markus Armbruster wrote: > replay_configure() pushes and pops a Location with automatic storage > duration. Except it fails to pop when -icount parameter "rr" isn't > given. cur_loc then points to unused stack space, and will most > likely get clobbered in short order. >

Re: [Qemu-devel] Hang with migration multi-thread compression under high load

On Wed, Apr 27, 2016 at 03:29:30PM +0100, Dr. David Alan Gilbert wrote: > ccing in Liang Li > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > for some reason it isn't shown in the stack thrace for thread > > 1 above, when initially connecting GDB it says the main thread > > is at: > > >

Re: [Qemu-devel] [PATCH v9 10/11] qemu-iotests: test overlapping block-stream operations

On Wed 27 Apr 2016 03:48:26 PM CEST, Max Reitz wrote: >> +# Attach the drive to the VM >> +self.vm = iotests.VM() >> +self.vm.add_drive("blkdebug::" + self.imgs[-1], ','.join(opts)) > > Any special reason for blkdebug? For me it works just fine without. Oh, I think it's

Re: [Qemu-devel] [PATCH 1/1] mm: thp: kvm: fix memory corruption in KVM with THP enabled

On Wed, Apr 27, 2016 at 04:50:30PM +0300, Kirill A. Shutemov wrote: > I know nothing about kvm. How do you protect against pmd splitting between > get_user_pages() and the check? get_user_pages_fast() runs fully lockless and unpins the page right away (we need a get_user_pages_fast without the

Re: [Qemu-devel] [PATCH v9 05/11] block: allow block jobs in any arbitrary node

On Wed 27 Apr 2016 02:30:55 PM CEST, Max Reitz wrote: >> @@ -3694,18 +3696,18 @@ static BlockJob *find_block_job(const char *device, >> AioContext **aio_context, >> >> *aio_context = NULL; >> >> -blk = blk_by_name(device); >> -if (!blk) { >> +bs =

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 05:54:57PM +0300, Michael S. Tsirkin wrote: > Point is, QEMU is not the only virtio implementation out there. > So we can't know no virtio implementations have an IOMMU as long as > linux supports this IOMMU. > virtio always used physical addresses since it was born and if

Re: [Qemu-devel] [PATCH v6 01/10] qom: add helpers for UserCreatable object types

On Wed, Apr 27, 2016 at 06:43:43AM -0600, Eric Blake wrote: > On 04/27/2016 03:58 AM, Daniel P. Berrange wrote: > > On Wed, Apr 27, 2016 at 11:26:23AM +0200, Markus Armbruster wrote: > >> This commit regresses error message quality from > >> > >> $ qemu-system-x86_64 -nodefaults -display none

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 05:34:30PM +0300, Michael S. Tsirkin wrote: > On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote: > QEMU can choose to bypass IOMMU for one device and not the other. > IOMMU in QEMU isn't involved when it's bypassed. And it is QEMU's task to tell the OS, right?

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

On 27 April 2016 at 10:38, Alberto Garcia wrote: > On Wed, Apr 27, 2016 at 09:29:02AM +0200, Pradeep Kiruvale wrote: > > > Thanks for the reply. I am still in the early phase, I will let you > > know if any changes are needed for the APIs. > > > > We might also have to

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 07:43:07AM -0700, Andy Lutomirski wrote: > On Wed, Apr 27, 2016 at 7:38 AM, Michael S. Tsirkin wrote: > > On Wed, Apr 27, 2016 at 07:31:43AM -0700, Andy Lutomirski wrote: > >> On Wed, Apr 27, 2016 at 7:23 AM, Joerg Roedel wrote: > >> > On

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 04:23:32PM +0200, Joerg Roedel wrote: > On Wed, Apr 27, 2016 at 04:37:04PM +0300, Michael S. Tsirkin wrote: > > One correction: it's a feature of the device in the system. > > There could be a mix of devices bypassing and not > > bypassing the IOMMU. > > No, it really is

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 7:38 AM, Michael S. Tsirkin wrote: > On Wed, Apr 27, 2016 at 07:31:43AM -0700, Andy Lutomirski wrote: >> On Wed, Apr 27, 2016 at 7:23 AM, Joerg Roedel wrote: >> > On Wed, Apr 27, 2016 at 04:37:04PM +0300, Michael S. Tsirkin wrote: >> >>

Re: [Qemu-devel] [PATCH for-2.6 3/3] qom: -object error messages lost location, restore it

On Wed, Apr 27, 2016 at 04:29:09PM +0200, Markus Armbruster wrote: > qemu_opts_foreach() runs its callback with the error location set to > the option's location. Any errors the callback reports use the > option's location automatically. > > Commit 90998d5 moved the actual error reporting from

Re: [Qemu-devel] post-copy is broken?

Hello Liang, On Mon, Apr 18, 2016 at 10:33:14AM +, Li, Liang Z wrote: > If the THP is disabled, no fails. > And your test was always passed, even when real post-copy was failed. > > In my env, the output of > 'cat /sys/kernel/mm/transparent_hugepage/enabled' is: > > [always] ... >

Re: [Qemu-devel] [PATCH 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev

Am 27.04.2016 um 16:34 hat Eric Blake geschrieben: > On 04/27/2016 03:52 AM, Kevin Wolf wrote: > > It used to be an internal helper function just for implementing > > bdrv_co_do_readv/writev(), but now that it's a public interface, it > > deserves a name without "do" in it. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH for-2.6 1/3] QemuOpts: Fix qemu_opts_foreach() dangling location regression

On 04/27/2016 08:29 AM, Markus Armbruster wrote: > qemu_opts_foreach() pushes and pops a Location with automatic storage > duration. Except it fails to pop when @func() returns non-zero. > cur_loc then points to unused stack space, and will most likely get > clobbered in short order. > >

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 07:31:43AM -0700, Andy Lutomirski wrote: > On Wed, Apr 27, 2016 at 7:23 AM, Joerg Roedel wrote: > > On Wed, Apr 27, 2016 at 04:37:04PM +0300, Michael S. Tsirkin wrote: > >> One correction: it's a feature of the device in the system. > >> There could be a

Re: [Qemu-devel] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev() interface

Am 27.04.2016 um 16:17 hat Stefan Hajnoczi geschrieben: > On Wed, Apr 27, 2016 at 11:52:40AM +0200, Kevin Wolf wrote: > > @@ -703,6 +712,7 @@ static int vdi_co_write(BlockDriverState *bs, > > VdiHeader *header = (VdiHeader *) block; > > uint8_t *base; > > uint64_t

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

On Wed, 27 Apr 2016 15:59:52 +0200 Thomas Huth wrote: > On 27.04.2016 15:37, Igor Mammedov wrote: > > On Tue, 26 Apr 2016 16:03:37 -0500 > > Michael Roth wrote: > > > >> Quoting Igor Mammedov (2016-04-26 02:52:36) > >>> On Tue, 26 Apr 2016

Re: [Qemu-devel] [PATCH 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev

On 04/27/2016 03:52 AM, Kevin Wolf wrote: > It used to be an internal helper function just for implementing > bdrv_co_do_readv/writev(), but now that it's a public interface, it > deserves a name without "do" in it. > > Signed-off-by: Kevin Wolf > --- > block/block-backend.c

Re: [Qemu-devel] [PATCH V2 RFC] fixup! virtio: convert to use DMA api

On Wed, Apr 27, 2016 at 7:23 AM, Joerg Roedel wrote: > On Wed, Apr 27, 2016 at 04:37:04PM +0300, Michael S. Tsirkin wrote: >> One correction: it's a feature of the device in the system. >> There could be a mix of devices bypassing and not >> bypassing the IOMMU. > > No, it really

Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface

Am 27.04.2016 um 16:06 hat Stefan Hajnoczi geschrieben: > On Wed, Apr 27, 2016 at 11:52:36AM +0200, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > block/bochs.c | 46 +- > > 1 file changed, 29 insertions(+), 17

  1   2   3   >