Re: [Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_subi_tl(cpu_sp, cpu_sp, 4); +tcg_gen_qemu_st_tl(src1, cpu_sp, ctx->memidx, MO_UL); You need to delay the write to the stack pointer until after the store, otherwise sp will have the incorrect contents if the page is not writable.

Re: [Qemu-devel] [PATCH RFC v1 09/29] target-arc: NEG, ABS, NOT

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_movcond_tl(TCG_COND_GEU, rslt, src1, ctx->msb32, src1, t0); Better as a signed comparison vs zero. r~

Re: [Qemu-devel] [PATCH RFC v1 07/29] target-arc: MAX, MIN

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +int arc_gen_MAX(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) +{ +if (ctx->opt.f) { +arc_gen_CMP(ctx, src1, src2); +} + +tcg_gen_movcond_tl(TCG_COND_GEU, dest, src1, src2, src1, src2); These are supposed to be signed comparis

[Qemu-devel] [PATCH v3] Add resolutions via the command-line

2016-09-20 Thread G 3
Add the ability to add resolutions from the command-line. This patch works by looking for a property called 'resolutions' in the options node of OpenBIOS. If it is found all the resolutions are parsed and loaded. Example command-line: -prom-env resolutions=512x342,640x480,800x600,1024x600,12

Re: [Qemu-devel] [PATCH RFC v1 06/29] target-arc: EX, LD, ST, SYNC, PREFETCH

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: Signed-off-by: Michael Rolnik --- target-arc/translate-inst.c | 230 target-arc/translate-inst.h | 10 ++ 2 files changed, 240 insertions(+) diff --git a/target-arc/translate-inst.c b/target-arc/transla

Re: [Qemu-devel] [PATCH RFC v1 04/29] target-arc: AND, OR, XOR, BIC, TST

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +int arc_gen_AND(DisasCtxt *ctx, TCGv dest, TCGv src1, TCGv src2) +{ +TCGv rslt = dest; + +if (TCGV_EQUAL(dest, src1) || TCGV_EQUAL(dest, src2)) { +rslt = tcg_temp_new_i32(); +} + +tcg_gen_and_tl(rslt, src1, src2); + +if (c

Re: [Qemu-devel] [PATCH RFC v1 03/29] target-arc: SUB, SUB1, SUB2, SUB3, SBC, RSUB, CMP

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +static void gen_sub_Cf(TCGv dest, TCGv src1, TCGv src2) +{ +TCGv t1 = tcg_temp_new_i32(); +TCGv t2 = tcg_temp_new_i32(); +TCGv t3 = tcg_temp_new_i32(); + +tcg_gen_not_tl(t1, src1); /* t1 = ~src1 */ +

Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +#define CPU_IMM(env)((env)->r[62]) +#define CPU_PCL(env)((env)->r[63]) You don't need to represent these as actual registers. These are better considered placeholder regnums to be filled in with actual values during translation. +stru

Re: [Qemu-devel] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The option whether or not to use a native AIO interface really isn't a > generic option for all drivers, but only applies to the native file > protocols. This patch moves the option in blockdev-add to the > appropriate places (raw-posix and raw-win32). >

Re: [Qemu-devel] [PATCH 2/7] block/qapi: Use separate options type for curl driver

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > We're going to add an option to the file drivers which doesn't apply to > the curl drivers, so give them a separate option type. > > Signed-off-by: Kevin Wolf > --- > qapi/block-core.json | 25 ++--- > 1 file changed, 18 insertions(

Re: [Qemu-devel] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add()

2016-09-20 Thread Eric Blake
On 09/20/2016 04:08 PM, Kevin Wolf wrote: > The TODO comment has been addressed a while ago and this is now checked > in raw-posix, so we don't have to special case this in blockdev-add any > more. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 15 --- > tests/qem

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Greg Kurz
On Fri, 16 Sep 2016 04:33:36 -0400 Pradeep Jagadeesh wrote: > Uses throttling APIs to limit I/O bandwidth and number of operations on the > fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, Please find some comments below. > fsdev/Makefile.objs | 1 + > fsdev/

Re: [Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch()

2016-09-20 Thread Marc-André Lureau
- Original Message - > Hi Alberto > > - Original Message - > > On Mon, Sep 12, 2016 at 01:19:10PM +0400, Marc-André Lureau wrote: > > > Replace the old manual dispatch and validation code by the generic one > > > provided by qapi common code. > > > > > > Note that it is now poss

Re: [Qemu-devel] [PATCH v2 11/11] block: Remove BB interface from blockdev-add/del

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > With this patch, blockdev-add always works on a node level, i.e. it > creates a BDS, but no BB. Consequently, x-blockdev-del doesn't need the > 'device' option any more, but 'node-name' becomes mandatory. How close are we to promoting x-blockdev-del out

Re: [Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch()

2016-09-20 Thread Marc-André Lureau
Hi Alberto - Original Message - > On Mon, Sep 12, 2016 at 01:19:10PM +0400, Marc-André Lureau wrote: > > Replace the old manual dispatch and validation code by the generic one > > provided by qapi common code. > > > > Note that it is now possible to call the following commands that used t

Re: [Qemu-devel] [PATCH v2] add resolutions via command-line

2016-09-20 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 09:51 -0400, G 3 wrote: >  > > Is it worth renaming this to make it obvious that it is your > > (non-optimal) replacement, intentionally because you don't want to > > use > > the libc version? > > I originally thought about adding a prefix to all my functions. Ben   > what do

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

2016-09-20 Thread Greg Kurz
On Tue, 20 Sep 2016 11:02:07 +0200 Pradeep Jagadeesh wrote: > Hi Alberto, > Hi, > Thanks for having look at the patch. > My replies are inline. > > On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: > > > > Hi, > > > > first of all, sorry for the late reply! Here are my comments:

Re: [Qemu-devel] KVM-PR is broken with current QEMU

2016-09-20 Thread Benjamin Herrenschmidt
On Tue, 2016-09-20 at 13:44 +0200, Thomas Huth wrote: > > Seems like KVM PR is using the "degraded" ISA variants (without the > 1TB > segments), but the new POWERPC_MMU_64K flag has not been added to > those. > Has this been done on purpose, or was this just by accident? > I can make KVM PR workin

Re: [Qemu-devel] [PATCH v2 10/11] qemu-iotests/141: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/141 | 24 ++-- > tests/qemu-iotests/141.out | 2

Re: [Qemu-devel] [PATCH v2 08/11] qemu-iotests/124: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/124 | 17 ++--- > 1 file changed, 10 insertions(+), 7 delet

Re: [Qemu-devel] [PATCH v2 09/11] qemu-iotests/139: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/139 | 178 > +++-- > tests

[Qemu-devel] [PATCH 5/7] block: Use 'detect-zeroes' option for 'blockdev-change-medium'

2016-09-20 Thread Kevin Wolf
Instead of modifying the new BDS after it has been opened, use the newly supported 'detect-zeroes' option in bdrv_open_common() so that all requirements are checked (detect-zeroes=unmap requires discard=unmap). Signed-off-by: Kevin Wolf --- block/block-backend.c | 9 - blockdev.

[Qemu-devel] [PATCH 7/7] block: Remove qemu_root_bds_opts

2016-09-20 Thread Kevin Wolf
The remaining options in qemu_root_bds_opts (aio and copy-on-read) aren't used any more, the QAPI schema doesn't contain them. Therefore all the code processing qemu_root_bds_opts options is dead and can be removed. Signed-off-by: Kevin Wolf --- blockdev.c | 54 +-

[Qemu-devel] [PATCH 1/7] block: Drop aio/cache consistency check from qmp_blockdev_add()

2016-09-20 Thread Kevin Wolf
The TODO comment has been addressed a while ago and this is now checked in raw-posix, so we don't have to special case this in blockdev-add any more. Signed-off-by: Kevin Wolf --- blockdev.c | 15 --- tests/qemu-iotests/087.out | 2 +- 2 files changed, 1 insertion(+)

[Qemu-devel] [PATCH 2/7] block/qapi: Use separate options type for curl driver

2016-09-20 Thread Kevin Wolf
We're going to add an option to the file drivers which doesn't apply to the curl drivers, so give them a separate option type. Signed-off-by: Kevin Wolf --- qapi/block-core.json | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/qapi/block-core.json b/

Re: [Qemu-devel] [PATCH] rules.mak: quiet-command: Split command name and args to print

2016-09-20 Thread Peter Maydell
On 20 September 2016 at 20:03, Eric Blake wrote: > On 09/20/2016 01:34 PM, Peter Maydell wrote: >> The quiet-command make rule currently takes two arguments: >> the command and arguments to run, and a string to print if >> the V flag is not set (ie we are not being verbose). >> By convention, the

Re: [Qemu-devel] [PATCH v2 06/11] qemu-iotests/117: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/117 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Rev

Re: [Qemu-devel] [PATCH v2 07/11] qemu-iotests/118: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/118 | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > Re

Re: [Qemu-devel] [PATCH v16 07/16] hw/ptimer: Add "continuous trigger" policy

2016-09-20 Thread Dmitry Osipenko
On 20.09.2016 20:21, Peter Maydell wrote: > On 7 September 2016 at 14:22, Dmitry Osipenko wrote: >> Currently, periodic timer that has load = delta = 0 performs trigger >> on timer reload and stops, printing a "period zero" error message. >> Introduce new policy that makes periodic timer to contin

[Qemu-devel] [PATCH 3/7] block/qapi: Move 'aio' option to file driver

2016-09-20 Thread Kevin Wolf
The option whether or not to use a native AIO interface really isn't a generic option for all drivers, but only applies to the native file protocols. This patch moves the option in blockdev-add to the appropriate places (raw-posix and raw-win32). We still have to keep the flag BDRV_O_NATIVE_AIO fo

Re: [Qemu-devel] [PATCH v16 05/16] hw/ptimer: Add "wraparound after one period" policy

2016-09-20 Thread Dmitry Osipenko
On 20.09.2016 20:20, Peter Maydell wrote: > On 7 September 2016 at 14:22, Dmitry Osipenko wrote: >> Currently, periodic counter wraps around immediately once counter reaches >> "0", this is wrong behaviour for some of the timers, resulting in one period >> being lost. Add new ptimer policy that pr

[Qemu-devel] [PATCH 6/7] block: Move 'discard' option to bdrv_open_common()

2016-09-20 Thread Kevin Wolf
This enables its use for nested child nodes. The compatibility between the 'discard' and 'detect-zeroes' setting is checked in bdrv_open_common() now as the former setting isn't available before calling bdrv_open() any more. Signed-off-by: Kevin Wolf --- block.c | 17 ++

[Qemu-devel] [PATCH 4/7] block: Parse 'detect-zeroes' in bdrv_open_common()

2016-09-20 Thread Kevin Wolf
Amonst others, this means that you can now use the 'detect-zeroes' option for non-top-level nodes in blockdev-add, like the QAPI schema promises. Signed-off-by: Kevin Wolf --- block.c| 33 + blockdev.c | 9 + 2 files changed, 34 insertions(+), 8 delet

[Qemu-devel] [PATCH v2 10/12] vfio/pci: Remove vfio_msix_early_setup returned value

2016-09-20 Thread Eric Auger
The returned value is not used anymore by the caller, vfio_realize since the error now is stored in the error object. So let's remove it. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c

[Qemu-devel] [PATCH 0/7] block: Make more blockdev-add options work

2016-09-20 Thread Kevin Wolf
This series moves a few more options from flags to the appropriate place. This doesn't only result in cleaner code, but also allows using these options in nested node definitions. After this series, bds_tree_init() is only a thin wrapper around bdrv_open() which sets the right defaults for cache m

[Qemu-devel] [PATCH v2 11/12] vfio/pci: Remove vfio_populate_device returned value

2016-09-20 Thread Eric Auger
The returned value (either -errno or -1) is not used anymore by the caller, vfio_realize, since the error now is stored in the error object. So let's remove it. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2 12/12] vfio/pci: Handle host oversight

2016-09-20 Thread Eric Auger
In case the end-user calls qemu with -vfio-pci option without passing either sysfsdev or host property value, the device is interpreted as :00:00.0. Let's create a specific error message to guide the end-user. Signed-off-by: Eric Auger --- hw/vfio/pci.c | 11 +++ 1 file changed, 11 i

[Qemu-devel] [PATCH v2 08/12] vfio: Pass an error object to vfio_get_device

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. Signed-off-by: Eric Auger --- hw/vfio/common.c | 13 +++-- hw/vfio/pci.c | 3 +-- hw/vfio/platform.c| 5 ++--- include/hw/vfio/vfio-common.h | 2 +- 4 files changed, 11 insertio

[Qemu-devel] [PATCH v2 09/12] vfio/pci: Conversion to realize

2016-09-20 Thread Eric Auger
This patch converts VFIO PCI to realize function. Also original initfn errors now are propagated using QEMU error objects. All errors are formatted with the same pattern: "vfio: %s: the error description" Signed-off-by: Eric Auger --- v1 -> v2: - correct error_setg_errno with positive error va

[Qemu-devel] [PATCH v2 07/12] vfio: Pass an error object to vfio_get_group

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. Signed-off-by: Eric Auger --- v2: creation --- hw/vfio/common.c | 20 +++- hw/vfio/pci.c | 3 +-- hw/vfio/platform.c| 11 --- include/hw/vfio/vfio-common.h | 2

[Qemu-devel] [PATCH v2 06/12] vfio/pci: Pass an error object to vfio_pci_igd_opregion_init

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. In vfio_probe_igd_bar4_quirk, simply report the error without propagating. Transform vfio_pci_igd_opregion_init into a void function. The -EINVAL returned value only is used in vfio_initfn and during migration to realize, this wil

Re: [Qemu-devel] [PATCH RFC v1 02/29] target-arc: ADC, ADD, ADD1, ADD2, ADD3

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: > Signed-off-by: Michael Rolnik > --- > target-arc/Makefile.objs| 1 + > target-arc/translate-inst.c | 170 > > target-arc/translate-inst.h | 30 > 3 files changed, 201 insertions(+) > cre

[Qemu-devel] [PATCH v2 05/12] vfio/pci: Pass an error object to vfio_add_capabilities

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The error is cascaded downto vfio_add_std_cap and then vfio_msi(x)_setup, vfio_setup_pcie_cap. vfio_add_ext_cap does not return anything else than 0 so let's transform it into a void function. Also use pci_add_capability2 which ta

[Qemu-devel] [PATCH v2 04/12] vfio/pci: Pass an error object to vfio_intx_enable

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The error object is propagated downto vfio_intx_enable_kvm vfio_intx_update which calls vfio_intx_enable_kvm and vfio_msi_disable_common/vfio_pci_post_reset which calls vfio_intx_enable do not propagate the error and simply call e

[Qemu-devel] [PATCH v2 00/12] Convert VFIO-PCI to realize

2016-09-20 Thread Eric Auger
This series converts VFIO-PCI to realize. It also aims at improving the error reporting in case of QMP hot-plug. Before the series, a device_add failure would have reported: {"error": {"class": "GenericError", "desc": "Device initialization failed"}}. Now the actual error cause is reported. Git

[Qemu-devel] [PATCH v2 02/12] vfio/pci: Pass an error object to vfio_populate_device

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The returned value will be removed later on. The case where error recovery cannot be enabled is not converted into an error object but directly reported through error_report, as before. Populating an error instead would cause the f

[Qemu-devel] [PULL v4 8/8] iotest 055: refactor and speed up

2016-09-20 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Source disk is created and filled with test data before each test case. Instead initialize it once for the whole unit. Test disk filling patterns are merged into one pattern. Also TestSetSpeed used different image_len for source and target (by mistake) - this

[Qemu-devel] [PULL v4 4/8] blockdev: Add dynamic generation of module_block.h

2016-09-20 Thread Max Reitz
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Stefan Hajn

[Qemu-devel] [PATCH v2 03/12] vfio/pci: Pass an error object to vfio_msix_early_setup

2016-09-20 Thread Eric Auger
Pass an error object to prepare for migration to VFIO-PCI realize. The returned value will be removed later on. We now format an error in case of reading failure for - the MSIX flags - the MSIX table, - the MSIX PBA. Signed-off-by: Eric Auger --- v1 -> v2: - this patch now comes before the act

[Qemu-devel] [PATCH v2 01/12] vfio/pci: Use local error object in vfio_initfn

2016-09-20 Thread Eric Auger
To prepare for migration to realize, let's use a local error object in vfio_initfn. Also let's use the same error prefix for all error messages. On top of the 1-1 conversion, we start using a common error prefix for all error messages. We also introduce a similar warning prefix which will be used

[Qemu-devel] [PULL v4 6/8] blockdev: Modularize nfs block driver

2016-09-20 Thread Max Reitz
From: Colin Lord Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi Message-id: 1471008424-16465-5-git-send-email-cl...@redhat.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- block/Makefile.objs | 1 + configur

[Qemu-devel] [PULL v4 7/8] commit: get the overlay node before manipulating the backing chain

2016-09-20 Thread Max Reitz
From: Alberto Garcia The 'block-commit' command has a 'top' parameter to specify the topmost node from which the data is going to be copied. [E] <- [D] <- [C] <- [B] <- [A] In this case if [C] is the top node then this is the result: [E] <- [B] <- [A] [B] must be modified so its backing

[Qemu-devel] [PULL v4 1/8] qemu-img: add the 'dd' subcommand

2016-09-20 Thread Max Reitz
From: Reda Sallahi This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. For the start, this implements the bs, if, of and count options and requires both if and of to be specified (no stdin/stdout if not specified) and doesn't support tty, pipes, etc. The image format must be s

[Qemu-devel] [PULL v4 3/8] blockdev: prepare iSCSI block driver for dynamic loading

2016-09-20 Thread Max Reitz
From: Colin Lord This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-id: 1471008424-16465-2-git-s

[Qemu-devel] [PULL v4 2/8] qemu-img: add skip option to dd

2016-09-20 Thread Max Reitz
From: Reda Sallahi This adds the skip option which allows qemu-img dd to skip a number of blocks before copying the input. A test case was added to test the skip option. Signed-off-by: Reda Sallahi Message-id: 20160810141609.32727-1-fullma...@gmail.com Signed-off-by: Max Reitz --- qemu-img-c

[Qemu-devel] [PULL v4 5/8] blockdev: Add dynamic module loading for block drivers

2016-09-20 Thread Max Reitz
From: Marc Mari Extend the current module interface to allow for block drivers to be loaded dynamically on request. The only block drivers that can be converted into modules are the drivers that don't perform any init operation except for registering themselves. In addition, only the protocol dr

[Qemu-devel] [PULL v4 0/8] Block layer patches

2016-09-20 Thread Max Reitz
The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: build-sys: fix make install regression (2016-09-20 11:32:43 +0100) are available in the git repository at: git://github.com/XanClic/qemu.git tags/pull-block-2016-09-20 for you to fetch changes up to 819cec0114eeca8

Re: [Qemu-devel] [PATCH] tcg: try sti when moving a constant into a dead memory temp

2016-09-20 Thread Richard Henderson
On 09/15/2016 06:16 AM, Paolo Bonzini wrote: > This comes from free from unifying tcg_reg_alloc_mov and > tcg_reg_alloc_movi's handling of TEMP_VAL_CONST. It triggers > often on moves to cc_dst, such as the following translation > of "sub $0x3c,%esp": > > before: after:

Re: [Qemu-devel] [PATCH 0/2] Produce better termination message

2016-09-20 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: cover.1474383125.git.mpriv...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] Produce better termination

Re: [Qemu-devel] [PATCH v2 05/11] qemu-iotests/087: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > The test cases that test conflicts between the 'id' option to > blockdev-add and existing block devices or the 'node-name' of

Re: [Qemu-devel] [PATCH v2 04/11] qemu-iotests/081: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/081 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewe

Re: [Qemu-devel] [PATCH v2 03/11] qemu-iotests/071: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/071 | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH v2 02/11] qemu-iotests/067: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > In order to keep the test meaningful, some instances of query-block that > want to check whether the node still exists and wou

Re: [Qemu-devel] [PATCH v2 01/11] qemu-iotests/041: Avoid blockdev-add with id

2016-09-20 Thread Eric Blake
On 09/20/2016 08:03 AM, Kevin Wolf wrote: > We want to remove the 'id' option for blockdev-add. This removes one > user of the option and makes it use only node names. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/041 | 71 > +++--- > 1 fil

Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo

2016-09-20 Thread Thorsten Kohfeldt
Am 20.09.2016 um 20:46 schrieb Laszlo Ersek: On 09/20/16 20:23, Thorsten Kohfeldt wrote: Am 20.09.2016 um 02:51 schrieb Laszlo Ersek: I think it would make sense to work from the pre-rendered FlatView, if the information you can get out of it covers your needs. I assume you know by now th

Re: [Qemu-devel] [PULL v3 0/8] Block layer patches

2016-09-20 Thread Max Reitz
On 2016-09-20 at 13:47, Peter Maydell wrote: On 19 September 2016 at 22:45, Max Reitz wrote: The following changes since commit 33e1666b4289313306371fee0740f5c85517e406: Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-09-19' into staging (2016-09-19 18:06:52 +0100) are ava

[Qemu-devel] [PULL 00/13] AVR target

2016-09-20 Thread Richard Henderson
github.com/rth7680/qemu.git tags/pull-avr-20160920 for you to fetch changes up to ed250c0f1f42c06aa653d48f7f5b190972d541fe: target-avr: Merge translate-inst.inc.c into translate.c (2016-09-16 14:20:20 -0700)

Re: [Qemu-devel] [PATCH 00/25] Patch Round-up for stable 2.6.2, freeze on 2016-08-26

2016-09-20 Thread Eric Blake
On 09/20/2016 02:26 PM, Michael Roth wrote: > Quoting Eric Blake (2016-09-20 12:41:32) >> On 09/20/2016 12:05 PM, Michael Roth wrote: >>> Hi everyone, >>> >>> The following new patches are queued for QEMU stable v2.6.2: >> >> What happened to the usual shortlog? > > Sorry, didn't realize it was mi

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/25] Patch Round-up for stable 2.6.2, freeze on 2016-08-26

2016-09-20 Thread Michael Roth
Quoting Michael Roth (2016-09-20 12:05:16) > Hi everyone, > > The following new patches are queued for QEMU stable v2.6.2: > > https://github.com/mdroth/qemu/commits/stable-2.6-staging > > The release is planned for 2016-08-29: > > http://wiki.qemu.org/Planning/2.6 > > Please respond here

Re: [Qemu-devel] [PATCH 00/25] Patch Round-up for stable 2.6.2, freeze on 2016-08-26

2016-09-20 Thread Michael Roth
Quoting Eric Blake (2016-09-20 12:41:32) > On 09/20/2016 12:05 PM, Michael Roth wrote: > > Hi everyone, > > > > The following new patches are queued for QEMU stable v2.6.2: > > What happened to the usual shortlog? Sorry, didn't realize it was missing until about 2 seconds after I fired it off to

Re: [Qemu-devel] [PATCH v10 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-20 Thread Michael S. Tsirkin
On Tue, Sep 20, 2016 at 05:46:01PM +0800, Gonglei wrote: > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). The virtio crypto device can provide > five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. Only CIPHER, MAC, HASH, AEAD are docu

Re: [Qemu-devel] [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

2016-09-20 Thread Eduardo Habkost
On Tue, Sep 20, 2016 at 01:25:06PM -0500, Eric Blake wrote: > On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > > Add a new optional field to query-cpu-definitions schema: > > "unavailable-features". It will contain a list of QOM properties > > that prevent the CPU model from running in the current

Re: [Qemu-devel] [PATCH] rules.mak: quiet-command: Split command name and args to print

2016-09-20 Thread Eric Blake
On 09/20/2016 01:34 PM, Peter Maydell wrote: > The quiet-command make rule currently takes two arguments: > the command and arguments to run, and a string to print if > the V flag is not set (ie we are not being verbose). > By convention, the string printed is of the form > " NAME some args". Un

[Qemu-devel] [PATCH] tcg update

2016-09-20 Thread Richard Henderson
+0100) are available in the git repository at: git://github.com/rth7680/qemu.git tags/pull-tcg-20160920 for you to fetch changes up to ebb90a005da67147245cd38fb04a965a87a961b7: tcg/i386: Extend TARGET_PAGE_MASK to the proper type (2016-09-20 11:45:30 -0700

[Qemu-devel] [PATCH] tcg/i386: Extend TARGET_PAGE_MASK to the proper type

2016-09-20 Thread Richard Henderson
TARGET_PAGE_MASK, as defined, has type "int". We need to extend that to the proper target width before oring in an "unsigned". Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/

Re: [Qemu-devel] [PULL v3 01/18] tcg: Support arbitrary size + alignment

2016-09-20 Thread Richard Henderson
On 09/20/2016 03:16 AM, Bharata B Rao wrote: > This breaks ppc64 emulation on x86 pretty early during boot. > > Quiescing Open Firmware ... > Booting Linux via __start() @ 0x0040 ... > > Thread 4 "qemu-system-ppc" received signal SIGSEGV, Segmentation fault. > [Switching to Thread 0x7

Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo

2016-09-20 Thread Laszlo Ersek
On 09/20/16 20:23, Thorsten Kohfeldt wrote: > > Am 20.09.2016 um 02:51 schrieb Laszlo Ersek: >> I think it would make sense to work from the pre-rendered FlatView, >> if the information you can get out of it covers your needs. > > I assume you know by now that I do _not_ feel that it covers my n

Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo

2016-09-20 Thread Thorsten Kohfeldt
Am 20.09.2016 um 09:56 schrieb Paolo Bonzini: ... dumping the flat-view would give you something much simpler: -0009 (RW): pc.ram 000a-000b (RW): vga-lowmem 000c-000f (R-): pc.ram @ 000c 0010-00

[Qemu-devel] [PATCH] rules.mak: quiet-command: Split command name and args to print

2016-09-20 Thread Peter Maydell
The quiet-command make rule currently takes two arguments: the command and arguments to run, and a string to print if the V flag is not set (ie we are not being verbose). By convention, the string printed is of the form " NAME some args". Unfortunately to get nicely lined up output all the strin

Re: [Qemu-devel] [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

2016-09-20 Thread Eric Blake
On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > Add a new optional field to query-cpu-definitions schema: > "unavailable-features". It will contain a list of QOM properties > that prevent the CPU model from running in the current host. > > Cc: David Hildenbrand > Cc: Michael Mueller > Cc: Chris

Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo

2016-09-20 Thread Thorsten Kohfeldt
Am 20.09.2016 um 02:51 schrieb Laszlo Ersek: On 09/20/16 02:16, Thorsten Kohfeldt wrote: Am 15.09.2016 um 11:52 schrieb Paolo Bonzini: On 07/09/2016 02:48, Thorsten Kohfeldt wrote: From: Thorsten Kohfeldt Date: Wed, 31 Aug 2016 22:43:14 +0200 Subject: [PATCH] hmp: Improve 'info mtree' with

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-20 Thread Alistair Francis
On Tue, Sep 20, 2016 at 10:41 AM, Peter Maydell wrote: > On 20 September 2016 at 15:54, Alistair Francis > wrote: >> This work is based on the original work by Li Guang with extra >> features added by Peter C and myself. >> >> The idea of this loader is to allow the user to load multiple images >

Re: [Qemu-devel] [PATCH for-2.8 v4 0/6] Add support for Cadence GEM priority queues

2016-09-20 Thread Alistair Francis
On Tue, Sep 20, 2016 at 10:30 AM, Peter Maydell wrote: > On 19 September 2016 at 19:16, Alistair Francis > wrote: >> On Mon, Sep 19, 2016 at 11:08 AM, Peter Maydell >> wrote: >>> On 28 July 2016 at 20:00, Alistair Francis >>> wrote: This patch series adds initial priority queue suppo

Re: [Qemu-devel] [PATCH 10/30] qmp-commands: move 'query-events' doc to schema

2016-09-20 Thread Eric Blake
On 09/13/2016 08:01 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/qmp-commands.txt | 28 > qapi-schema.json | 19 ++- > 2 files changed, 18 insertions(+), 29 deletions(-) Through patch 10, Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH 02/30] qmp-commands: move 'query-name' doc to schema

2016-09-20 Thread Eric Blake
On 09/13/2016 08:01 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/qmp-commands.txt | 14 -- > qapi-schema.json | 12 +--- > 2 files changed, 9 insertions(+), 17 deletions(-) > > +++ b/qapi-schema.json > @@ -102,9 +102,9 @@ > # > # Guest

Re: [Qemu-devel] [PATCH v3 17/18] trace: pass trace-events to tracetool as a positional param

2016-09-20 Thread Lluís Vilanova
Daniel P Berrange writes: > On Mon, Sep 19, 2016 at 08:18:51PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > Instead of reading the contents of 'trace-events' from stdin, >> > accept the filename as a positional parameter. This also >> > allows for reading from multiple files,

Re: [Qemu-devel] [PATCH] hw/arm: Fix Integrator/CP memsz initialization

2016-09-20 Thread Peter Maydell
On 19 September 2016 at 20:54, Jakub Jermář wrote: > > * Do not assume memsz is already initialized in integratorcm_init > * Calculate memsz directly from MachineState > * Get rid of the now unused memsz property > > Signed-off-by: Jakub Jermar Thanks for this patch; this is definitely a bug but

Re: [Qemu-devel] [PATCH v3 13/18] trace: dynamically allocate event IDs at runtime

2016-09-20 Thread Lluís Vilanova
Daniel P Berrange writes: > On Mon, Sep 19, 2016 at 08:05:12PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > Instead of having the code generator assign event IDs and >> > event VCPU IDs, assign them when the events are registered >> > at runtime. This will allow us allow code

[Qemu-devel] [V5 6/6] hw/iommu: share common code between IOMMUs

2016-09-20 Thread David Kiarie
Enabling interrupt remapping with kernel_irqchip=on should result in an error for both VT-d and AMD-Vi Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 9 - hw/i386/x86-iommu.c | 8 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/i386/intel_iommu.c b/h

Re: [Qemu-devel] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands

2016-09-20 Thread Eric Blake
On 09/20/2016 06:38 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the external > API, > we already converted all block layer QMP commands on the node level to accept > node names instead of BlockBackend names. This series converts the second > part, > devic

Re: [Qemu-devel] [PATCH 1/2v2] [RESENT-INLINE] Use libtool instead of ar to create static libraries on Darwin.

2016-09-20 Thread Peter Maydell
On 14 September 2016 at 08:30, Michael Tokarev wrote: > 03.05.2016 04:10, Christopher Friedt wrote: >> >> Currently, at least on Mac OS X 10.11.4 (El Capitan), Qemu fails to build >> for a few reasons. >> >> One of those reasons is that Apple's ld (at least ld64) does not properly >> process archi

[Qemu-devel] [V5 2/6] hw/i386: enforce SID verification

2016-09-20 Thread David Kiarie
Platform devices are now able to make interrupt request with explicit SIDs hence remove unnecesary check for invalid SID. Signed-off-by: David Kiarie --- hw/i386/intel_iommu.c | 72 - include/hw/i386/x86-iommu.h | 1 - 2 files changed, 32 insert

Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: improve lxvw4x implementation

2016-09-20 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Mon, Sep 19, 2016 at 04:06:40PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> > [ Unknown signature status ] >> > On Mon, Sep 19, 2016 at 04:19:34PM +1000, David Gibson wrote: >> >> On Fri, Sep 16, 2016 at 04:21:48PM +0530, Ni

Re: [Qemu-devel] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray

2016-09-20 Thread Eric Blake
On 09/20/2016 06:38 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the What you have works, but still feels a bit awkward to this native speaker. You could get away with the shorter: In order to remove the need for BlockBackend names... Up to you if you wa

[Qemu-devel] [V5 0/6] AMD IOMMU interrupt remapping

2016-09-20 Thread David Kiarie
Hello all, This patchset mainly adds AMD IOMMU interrupt remapping logic to Qemu. Doing that I have solved an existing issue where platform devices are not able to make interrupt requests with and explicit SID. This series is based on the previously sent AMD IOMMU patchset and is available he

[Qemu-devel] [V5 5/6] hw/acpi: report IOAPIC on IVRS

2016-09-20 Thread David Kiarie
Report IOAPIC via IVRS which effectively allows linux AMD-Vi driver to enable interrupt remapping Signed-off-by: David Kiarie --- hw/i386/acpi-build.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index c20bc71..c9bee8f 100644 --- a/hw/i386/acp

[Qemu-devel] [PATCH 04/25] virtio: decrement vq->inuse in virtqueue_discard()

2016-09-20 Thread Michael Roth
From: Stefan Hajnoczi virtqueue_discard() moves vq->last_avail_idx back so the element can be popped again. It's necessary to decrement vq->inuse to avoid "leaking" the element count. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Cornel

Re: [Qemu-devel] [PATCH 01/30] qmp-commands: move 'add_client' doc to schema

2016-09-20 Thread Eric Blake
On 09/13/2016 08:01 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > docs/qmp-commands.txt | 18 -- > qapi-schema.json | 8 > 2 files changed, 8 insertions(+), 18 deletions(-) > > diff --git a/docs/qmp-commands.txt b/docs/qmp-commands.txt We

[Qemu-devel] [V5 4/6] hw/iommu: AMD IOMMU interrupt remapping

2016-09-20 Thread David Kiarie
Introduce AMD IOMMU interrupt remapping and hook it onto the existing interrupt remapping infrastructure Signed-off-by: David Kiarie --- hw/i386/amd_iommu.c | 206 +++- hw/i386/amd_iommu.h | 2 +- 2 files changed, 206 insertions(+), 2 deletions(-

Re: [Qemu-devel] [PATCH for-2.8 v4 0/6] Add support for Cadence GEM priority queues

2016-09-20 Thread Peter Maydell
On 19 September 2016 at 19:16, Alistair Francis wrote: > On Mon, Sep 19, 2016 at 11:08 AM, Peter Maydell > wrote: >> On 28 July 2016 at 20:00, Alistair Francis >> wrote: >>> >>> This patch series adds initial priority queue support to the Cadence GEM >>> device. This is based on original work b

<    1   2   3   4   5   >