[Qemu-devel] [PATCH 12/15] xen: Rename xen_be_evtchn_event

2016-10-03 Thread Emil Condrea
Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_pvdev.c | 2 +- include/hw/xen/xen_pvdev.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff -

[Qemu-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions

2016-10-03 Thread Emil Condrea
The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 49 - hw/xen/xen_pvdev.c | 51 +

[Qemu-devel] [PATCH 06/15] xen: Move evtchn functions to xen_pvdev.c

2016-10-03 Thread Emil Condrea
The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 35 --- hw/xen/xen_pvdev.c | 35 +++ include/hw/xen/xen_b

[Qemu-devel] [PATCH 05/15] xen: Move xenstore_update to xen_pvdev.c

2016-10-03 Thread Emil Condrea
* xenstore_update -> xen_pvdev.c * xenstore_update_fe -> xen_frontend.c Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 43 +-- hw/xen/xen_frontend.c | 18 ++ hw/xen/xen_pvdev.c| 24

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-03 Thread Cédric Le Goater
On 10/04/2016 02:22 AM, David Gibson wrote: > On Mon, Oct 03, 2016 at 01:23:27PM +0200, Cédric Le Goater wrote: >> On 09/29/2016 07:27 AM, David Gibson wrote: >>> On Wed, Sep 28, 2016 at 08:51:28PM +0200, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- tests/Makefile.includ

[Qemu-devel] [PATCH 01/15] xen: Fix coding style errors

2016-10-03 Thread Emil Condrea
Fixes the following errors: * ERROR: line over 90 characters * ERROR: code indent should never use tabs * ERROR: space prohibited after that open square bracket '[' * ERROR: do not initialise statics to 0 or NULL * ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Emil Condrea --- hw/char/

[Qemu-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c

2016-10-03 Thread Emil Condrea
Its purpose is to store frontend related functions. Signed-off-by: Quan Xu Signed-off-by: Emil Condrea --- hw/block/xen_disk.c | 1 + hw/display/xenfb.c| 1 + hw/net/xen_nic.c | 1 + hw/usb/xen-usb.c | 1 + hw/xen/Makefile.objs | 2 +

[Qemu-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed

2016-10-03 Thread Emil Condrea
xen_be_frontend_changed -> xen_fe_frontend_changed Signed-off-by: Emil Condrea --- hw/xen/xen_backend.c | 2 +- hw/xen/xen_frontend.c | 4 ++-- include/hw/xen/xen_frontend.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_

[Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings

2016-10-03 Thread Emil Condrea
Fixes: * WARNING: line over 80 characters Signed-off-by: Emil Condrea --- hw/block/xen_disk.c | 3 ++- hw/char/xen_console.c| 6 -- hw/display/xenfb.c | 30 -- hw/net/xen_nic.c | 12 hw/xen/xen_backend.c

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-03 Thread Greg Kurz
On Tue, 4 Oct 2016 11:22:23 +1100 David Gibson wrote: > On Mon, Oct 03, 2016 at 01:23:27PM +0200, Cédric Le Goater wrote: > > On 09/29/2016 07:27 AM, David Gibson wrote: > > > On Wed, Sep 28, 2016 at 08:51:28PM +0200, Laurent Vivier wrote: > > >> Signed-off-by: Laurent Vivier > > >> --- > >

[Qemu-devel] [PATCH 00/15] Refactor common part of xen backend and frontend

2016-10-03 Thread Emil Condrea
This patch series was splitted from QEMU:Xen stubdom vTPM for HVM virtual machine http://markmail.org/message/fkix7g3a5zdj7lvr It contains a reorganization of xen backend and frontend functions together with code style fixes. Common functions shared by backends and frontends are moved to xen_pvde

[Qemu-devel] [PATCH V3] hw/iommu: Fix problems reported by Coverity scan

2016-10-03 Thread David Kiarie
Signed-off-by: David Kiarie --- hw/i386/amd_iommu.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 023de52..47b79d9 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -143,10 +143,10 @@ static

[Qemu-devel] [PATCH V3] Coverity Fix

2016-10-03 Thread David Kiarie
The following patch fixes a few issues reported by Coverity in the file hw/i386/amd_iommu.c V3 includes fixes and suggestions from Paolo and Stefan. David Kiarie (1): hw/iommu: Fix problems reported by Coverity scan hw/i386/amd_iommu.c | 22 +- 1 file changed, 13 insertio

Re: [Qemu-devel] [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-10-03 Thread Kevin O'Connor
On Tue, Sep 27, 2016 at 02:00:08PM +0200, Gerd Hoffmann wrote: > On Fr, 2016-07-15 at 10:35 -0400, Kevin O'Connor wrote: > > On Fri, Jul 15, 2016 at 01:49:49PM +0200, Gerd Hoffmann wrote: > > > > Finally, one high level observation is that we know there are a number > > > > of quirks in various vga

Re: [Qemu-devel] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic

2016-10-03 Thread John Snow
On 10/03/2016 08:57 PM, Jeff Cody wrote: On Fri, Sep 30, 2016 at 06:00:41PM -0400, John Snow wrote: BlockJobs will begin hiding their state in preparation for some refactorings anyway, so let's internalize the user_pause mechanism instead of leaving it to callers to correctly manage. Signed-o

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-03 Thread David Gibson
On Mon, Oct 03, 2016 at 04:03:14PM +0200, Greg Kurz wrote: > On Mon, 3 Oct 2016 13:23:27 +0200 > Cédric Le Goater wrote: > > > On 09/29/2016 07:27 AM, David Gibson wrote: > > > On Wed, Sep 28, 2016 at 08:51:28PM +0200, Laurent Vivier wrote: > > >> Signed-off-by: Laurent Vivier > > >> --- > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-03 Thread David Gibson
On Mon, Oct 03, 2016 at 01:23:27PM +0200, Cédric Le Goater wrote: > On 09/29/2016 07:27 AM, David Gibson wrote: > > On Wed, Sep 28, 2016 at 08:51:28PM +0200, Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier > >> --- > >> tests/Makefile.include | 1 + > >> tests/libqos/pci-pc.c| 2

Re: [Qemu-devel] [PATCH] spapr: fix check of cpu alias name in spapr_get_cpu_core_type()

2016-10-03 Thread David Gibson
On Mon, Oct 03, 2016 at 08:44:22PM +0530, Bharata B Rao wrote: > On Mon, Oct 03, 2016 at 02:13:20PM +0200, Greg Kurz wrote: > > If the user passes an alias name and a property to -cpu, QEMU fails to > > find the CPU definition and exits. > > > > $ qemu-system-ppc64 -cpu POWER8E,compat=power7 > > q

Re: [Qemu-devel] [PATCH v2 03/11] Blockjobs: Internalize user_pause logic

2016-10-03 Thread Jeff Cody
On Fri, Sep 30, 2016 at 06:00:41PM -0400, John Snow wrote: > BlockJobs will begin hiding their state in preparation for some > refactorings anyway, so let's internalize the user_pause mechanism > instead of leaving it to callers to correctly manage. > > Signed-off-by: John Snow > --- > block/io.

[Qemu-devel] [PATCH qemu] sysemu: support up to 1024 vCPUs

2016-10-03 Thread Alexey Kardashevskiy
From: Greg Kurz Some systems can already provide more than 255 hardware threads. Bumping the QEMU limit to 1024 seems reasonable: - it has no visible overhead in top; - the limit itself has no effect on hot paths. Signed-off-by: Greg Kurz Signed-off-by: Alexey Kardashevskiy --- include/sysem

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Edgar E. Iglesias
On Mon, Oct 03, 2016 at 10:32:40PM +0530, Rutuja Shah wrote: > ++ stefan Sorry for the typo. > Regards > Rutuja Shah > > > On Mon, Oct 3, 2016 at 10:26 PM, wrote: > > From: Rutuja Shah > > > > This patch allocates memory for txbuf array on the heap rather than the > > stack. > > As a result,

Re: [Qemu-devel] [PATCH v1 1/1] docs/generic-loader: Add restrictions and ToDos

2016-10-03 Thread Eric Blake
On 10/03/2016 03:42 PM, Alistair Francis wrote: >>> An example of loading an ELF file which CPU0 will boot is shown below: >>> -device loader,file=./images/boot.elf,cpu-num=0 >>> + >>> +Restrictions and ToDos >>> +- >> >> Might be worth it to have the --- line up with the

Re: [Qemu-devel] [PATCH v1 1/1] docs/generic-loader: Add restrictions and ToDos

2016-10-03 Thread Alistair Francis
On Mon, Oct 3, 2016 at 1:35 PM, Eric Blake wrote: > On 10/03/2016 03:18 PM, Alistair Francis wrote: >> Add a list of known restrictions and future work that will fix these >> restrictions. >> >> Signed-off-by: Alistair Francis >> --- >> >> docs/generic-loader.txt | 7 +++ >> 1 file changed,

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 18:56, rutu.shah...@gmail.com wrote: > From: Rutuja Shah > > This patch allocates memory for txbuf array on the heap rather than the stack. > As a result, the stack frame size is reduced. > > Signed-off-by: Rutuja Shah > --- > hw/dma/xilinx_axidma.c | 4 +++- > 1 file changed,

Re: [Qemu-devel] [PATCH v1 1/1] docs/generic-loader: Add restrictions and ToDos

2016-10-03 Thread Eric Blake
On 10/03/2016 03:18 PM, Alistair Francis wrote: > Add a list of known restrictions and future work that will fix these > restrictions. > > Signed-off-by: Alistair Francis > --- > > docs/generic-loader.txt | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/generic-loader.txt b

[Qemu-devel] Baremetal Netduino2 -- cannot output on UARTs 2-4

2016-10-03 Thread Seth K
I have made a bare metal "Hello World" program for the Netduino2. I have pushed it here: https://github.com/skintigh/baremetal_netduino2 It should output "Test 1/4" to USART 1, "Test 2/4" to USART 2, "Test 3/4" to USART 3 and "Test 4/4" to UART 4. What actually happens in QEMU is only the first

[Qemu-devel] [PATCH v1 1/1] docs/generic-loader: Add restrictions and ToDos

2016-10-03 Thread Alistair Francis
Add a list of known restrictions and future work that will fix these restrictions. Signed-off-by: Alistair Francis --- docs/generic-loader.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/generic-loader.txt b/docs/generic-loader.txt index 8fcb550..305cbc8 100644 --- a/docs/ge

Re: [Qemu-devel] [libvirt] QMP stubs: how to return "not implemented" errors?

2016-10-03 Thread Eric Blake
On 10/03/2016 02:04 PM, Eduardo Habkost wrote: > Hi, > > When adding new QMP commands that are implemented by > arch-specific code, we have been adding stubs that report > QERR_UNSUPPORTED (see stubs/arch-query-cpu-model-expansion.c for > an example). > > 3.1) Removing the command from query-com

Re: [Qemu-devel] QMP stubs: how to return "not implemented" errors?

2016-10-03 Thread Jiri Denemark
On Mon, Oct 03, 2016 at 16:04:42 -0300, Eduardo Habkost wrote: > Hi, > > When adding new QMP commands that are implemented by > arch-specific code, we have been adding stubs that report > QERR_UNSUPPORTED (see stubs/arch-query-cpu-model-expansion.c for > an example). > > But we are using GenericE

Re: [Qemu-devel] [PATCH v4 13/35] tcg: Add atomic helpers

2016-10-03 Thread Alex Bennée
Richard Henderson writes: > Add all of cmpxchg, op_fetch, fetch_op, and xchg. > Handle both endian-ness, and sizes up to 8. > Handle expanding non-atomically, when emulating in serial. > > Signed-off-by: Richard Henderson > --- > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index 291d50b..65e366

Re: [Qemu-devel] [PATCH v4 00/35] cmpxchg-based emulation of atomics

2016-10-03 Thread Alex Bennée
Richard Henderson writes: > Rebased on top of Paolo's safe-work series, which means > that we now have cpu_exec_step_atomic for system mode as > well as linux-user. This should fix the problems with > atomic access to notdirty pages that have been reported. Sorry it has taken me so long to get

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

2016-10-03 Thread Rafael David Tinoco
Yes, definitely. Check this: /** * @qemu_chr_fe_set_msgfds: * * For backends capable of fd passing, set an array of fds to be passed with * the next send operation. * A subsequent call to this function before calling a write function will * result in overwriting the fd array with the new val

Re: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together

2016-10-03 Thread Jianjun Duan
I will address the style issues together with any other possible comments. The build test failed on code not in my patches. Thanks, Jianjun On 10/03/2016 11:24 AM, Jianjun Duan wrote: > Hi all, >The previous patches seem to get buried deep somewhere. I am sending the > lated rebased version.

[Qemu-devel] [PULL 1/2] target-i386: Report known CPUID[EAX=0xD, ECX=0]:EAX bits as migratable

2016-10-03 Thread Eduardo Habkost
A regression was introduced by commit 96193c22a "target-i386: Move xsave component mask to features array": all CPUID[EAX=0xD,ECX=0]:EAX bits were being reported as unmigratable because they don't have feature names defined. This broke "-cpu host" because it enables only migratable features by defa

Re: [Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array

2016-10-03 Thread Eduardo Habkost
On Mon, Oct 03, 2016 at 05:42:36PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 27, 2016 at 05:12:24PM -0300, Eduardo Habkost wrote: > > This will reuse the existing check/enforce logic in > > x86_cpu_filter_features() to check the xsave component bits > > against GET_SUPPORTED_CPUID. > > > > Re

[Qemu-devel] [PULL 2/2] target-i386: Correct family/model/stepping for Opteron_G3

2016-10-03 Thread Eduardo Habkost
From: Evgeny Yakovlev Current CPU definition for AMD Opteron third generation includes features like SSE4a and LAHF_LM support in emulated CPUID. These features are present in K8 rev.E or K10 CPUs and later. However, current G3 family and model describe 2nd generation K8 cores instead. This is i

[Qemu-devel] [PULL 0/2] x86 fixes

2016-10-03 Thread Eduardo Habkost
The following changes since commit c5d128ffeb5357df1ea3e6de0c13b3d6a09f6064: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20160927' into staging (2016-09-30 23:45:56 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-pull-request for

Re: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together

2016-10-03 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1475519097-27611-1-git-send-email-du...@linux.vnet.ibm.com Subject: [Qemu-devel] [QEMU PATCH v5 0/6]

Re: [Qemu-devel] Getting Started with Outreachy (Was: (no subject))

2016-10-03 Thread Stefan Hajnoczi
On Mon, Oct 3, 2016 at 6:57 PM, Shreya Shrivastava wrote: >>> I am interested in applying for Outreachy 2016 December- March round by >>> contributing to VIRTIO 1.0 support in libqos project for Qemu. >>> >>> Kindly let me know how to get started with this project. Hi, The project is about addin

[Qemu-devel] QMP stubs: how to return "not implemented" errors?

2016-10-03 Thread Eduardo Habkost
Hi, When adding new QMP commands that are implemented by arch-specific code, we have been adding stubs that report QERR_UNSUPPORTED (see stubs/arch-query-cpu-model-expansion.c for an example). But we are using GenericError for that, and this prevents clients from reliably checking if the command

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

2016-10-03 Thread Rafael David Tinoco
Hello Daniel, > On Oct 03, 2016, at 14:55, Daniel P. Berrange wrote: > >> Well, it unlinks the file but the references are still there while the >> descriptor isn't closed by this process, or by the one that receives the >> descriptor (that is why is the "unlink" so early). >> >> If you check v

Re: [Qemu-devel] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict()

2016-10-03 Thread Eric Blake
On 09/28/2016 03:55 PM, Max Reitz wrote: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring us to test each option whethe

Re: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together

2016-10-03 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1475519097-27611-1-git-send-email-du...@linux.vnet.ibm.com Subject: [Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together === TEST SCRIPT BE

[Qemu-devel] [QEMU PATCH v5 6/6] migration: spapr: migrate pending_events of spapr state

2016-10-03 Thread Jianjun Duan
In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event can be finished on the

Re: [Qemu-devel] [PATCH 3/3] target-arm: Comments to mark location of pending work for 56 bit addresses

2016-10-03 Thread Tom Hanson
On 09/30/2016 05:24 PM, Peter Maydell wrote: > On 30 September 2016 at 15:46, Tom Hanson wrote: >> On 09/29/2016 07:27 PM, Peter Maydell wrote: >> ... This work was not done at this time since the changes could not be tested with current CPU models. Comments have been added to flag the

[Qemu-devel] [QEMU PATCH v5 5/6] migration: spapr: migrate ccs_list in spapr state

2016-10-03 Thread Jianjun Duan
ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target guest, or the source guest could have not yet fi

[Qemu-devel] [QEMU PATCH v5 3/6] migration: extend VMStateInfo

2016-10-03 Thread Jianjun Duan
Current migration code cannot handle some data structures such as QTAILQ in qemu/queue.h. Here we extend the signatures of put/get in VMStateInfo so that customized handling is supported. Signed-off-by: Jianjun Duan --- hw/net/vmxnet3.c| 18 ++--- hw/nvram/eeprom93xx.c | 6

[Qemu-devel] [QEMU PATCH v5 1/6] migration: alternative way to set instance_id in SaveStateEntry

2016-10-03 Thread Jianjun Duan
In QOM(QEMU Object Model) migrated objects are identified with instance_id which is calculated automatically using their path in the QOM composition tree. For some objects, this path could change from source to target in migration. To migrate such objects, we need to make sure the instance_id does

[Qemu-devel] [QEMU PATCH v5 0/6] migration: ensure hotplug and migration work together

2016-10-03 Thread Jianjun Duan
Hi all, The previous patches seem to get buried deep somewhere. I am sending the lated rebased version. Comments are welcome. v5: - Rebased to David's ppc-for-2.8. Previous versions are: v4: - Introduce a way to set customized instance_id in SaveStateEntry. Use it to set instance_id for

[Qemu-devel] [QEMU PATCH v5 2/6] migration: spapr_drc: defined VMStateDescription struct

2016-10-03 Thread Jianjun Duan
To manage hotplug/unplug of dynamic resources such as PCI cards, memory, and CPU on sPAPR guests, a firmware abstraction known as a Dynamic Resource Connector (DRC) is used to assign a particular dynamic resource to the guest, and provide an interface for the guest to manage configuration/removal o

[Qemu-devel] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-03 Thread Jianjun Duan
Currently we cannot directly transfer a QTAILQ instance because of the limitation in the migration code. Here we introduce an approach to transfer such structures. In our approach such a structure is tagged with VMS_LINKED. We then modified vmstate_save_state and vmstate_load_state so that when VMS

Re: [Qemu-devel] backup notifier fail policy

2016-10-03 Thread John Snow
On 10/03/2016 09:11 AM, Stefan Hajnoczi wrote: On Fri, Sep 30, 2016 at 09:59:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 30.09.2016 20:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! Please, can somebody explain me, why we fail guest request in case of io error in write notifier? I th

[Qemu-devel] VNC - broken initial resolution

2016-10-03 Thread Gerhard Wiesinger
Hello, Since the last update (git log 3b71ec8..c5d128f) it looks like that the inital resolution via VNC is broken. E.g. after connecting seabios screen is not the typical text resolution but a lot larger than it should be. Any ideas? Anyone can reproduce it? Thnx. Ciao, Gerhard -- h

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

2016-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2016 at 03:41:10PM -, Rafael David Tinoco wrote: > Sorry, I was only able to come back to this today. > > > On Sep 27, 2016, at 09:18, Daniel Berrange <1626...@bugs.launchpad.net> > > wrote: > > > >> There are numerous people relying on older kernels in openstack > >> deploy

[Qemu-devel] Aspirant for Outreachy 2016 December- Marc

2016-10-03 Thread Shreya Shrivastava
HI , I am interested in applying for Outreachy 2016 December- March round by contributing to VIRTIO 1.0 support in libqos project for Qemu. Kindly let me know how to get started with this project. Shreya Shrivastava

[Qemu-devel] Getting Started with Outreachy (Was: (no subject))

2016-10-03 Thread John Snow
Please actually write a subject! On 10/02/2016 02:47 AM, Shreya Shrivastava wrote: HI , I am interested in applying for Outreachy 2016 December- March round by contributing to VIRTIO 1.0 support in libqos project for Qemu. Kindly let me know how to get started with this project. Shreya Shriv

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-10-03 Thread Rafael David Tinoco
Hello Marc, > On Sep 27, 2016, at 08:13, Marc-André Lureau wrote: > >>> On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: >>> We should not have QEMU creating unpredictabile filenames in the >>> first place - any filenames should be determined by libvirt >>> explicitly. >> >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 1/6] libqos: add PPC64 PCI support

2016-10-03 Thread Cédric Le Goater
On 10/03/2016 04:03 PM, Greg Kurz wrote: > On Mon, 3 Oct 2016 13:23:27 +0200 > Cédric Le Goater wrote: > >> On 09/29/2016 07:27 AM, David Gibson wrote: >>> On Wed, Sep 28, 2016 at 08:51:28PM +0200, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- tests/Makefile.include

Re: [Qemu-devel] [PATCH v12 2/2] docs: Add a generic loader explanation document

2016-10-03 Thread Alistair Francis
On Thu, Sep 29, 2016 at 10:36 PM, Markus Armbruster wrote: > Alistair Francis writes: > >> On Thu, Sep 29, 2016 at 2:24 AM, Markus Armbruster wrote: >>> Alistair Francis writes: >>> Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V11: - Fix corrections

Re: [Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread Rutuja Shah
++ stefan Sorry for the typo. Regards Rutuja Shah On Mon, Oct 3, 2016 at 10:26 PM, wrote: > From: Rutuja Shah > > This patch allocates memory for txbuf array on the heap rather than the stack. > As a result, the stack frame size is reduced. > > Signed-off-by: Rutuja Shah > --- > hw/dma/xilin

Re: [Qemu-devel] [PATCH 3/3] target-arm: Comments to mark location of pending work for 56 bit addresses

2016-10-03 Thread Tom Hanson
On 09/30/2016 05:24 PM, Peter Maydell wrote: 3 comments added in same file to identify cases in a switch. >>> >>> This should be a separate patch, because it is unrelated to the >>> tagged address stuff. >> >> As part of that same conversation you suggested adding these >> comments rather than

[Qemu-devel] [PATCH] Reducing stack frame size in stream_process_mem2s()

2016-10-03 Thread rutu . shah . 26
From: Rutuja Shah This patch allocates memory for txbuf array on the heap rather than the stack. As a result, the stack frame size is reduced. Signed-off-by: Rutuja Shah --- hw/dma/xilinx_axidma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/dma/xilinx_axidma.c b/h

Re: [Qemu-devel] [PULL 14/20] target-i386: Move xsave component mask to features array

2016-10-03 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 05:12:24PM -0300, Eduardo Habkost wrote: > This will reuse the existing check/enforce logic in > x86_cpu_filter_features() to check the xsave component bits > against GET_SUPPORTED_CPUID. > > Reviewed-by: Richard Henderson > Signed-off-by: Eduardo Habkost > --- > target-

[Qemu-devel] [PATCH v2 2/4] tests/docker: test-build script

2016-10-03 Thread Alex Bennée
Much like test-quick but only builds. This is useful for some of the build targets like ThreadSanitizer that don't yet pass "make check". Signed-off-by: Alex Bennée --- tests/docker/test-build | 18 ++ 1 file changed, 18 insertions(+) create mode 100755 tests/docker/test-build

Re: [Qemu-devel] [PATCH v4 04/13] cryptodev: introduce a new cryptodev backend

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 04:25:43PM +0800, Gonglei wrote: > +/* Max number of symetrical sessions */ s/symetrical/symmetric/ But why does the comment say "symetrical" when the constant name MAX_NUM_SESSIONS seems to be a global limit for *all* sessions (not just symmetric)? > +#define MAX_NUM_SES

[Qemu-devel] [PATCH v2 3/4] tests/docker: make test-mingw honour TARGET_LIST

2016-10-03 Thread Alex Bennée
The other builders honour this variable, so should the mingw build. Signed-off-by: Alex Bennée --- tests/docker/test-mingw | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw index c03757a..51e9c0b 100755 --- a/tests/docker/tes

[Qemu-devel] [PATCH v2 4/4] tests/docker/Makefile.include: add a generic docker-run target

2016-10-03 Thread Alex Bennée
This re-factors the docker makefile to include a docker-run target which can be controlled entirely from environment variables specified on the make command line. This allows us to run against any given docker image we may have in our repository, for example: make docker-run TEST="test-quick"

[Qemu-devel] [PATCH v2 0/4] generic docker run patches

2016-10-03 Thread Alex Bennée
Hi Fam, I've re-based the series for the generic run target. The aim being to allow a developer to run tests against any generic docker target even if it is not in the list of approved targets: make docker-run TEST=test-quick IMAGE=debian:arm64 \ EXECUTABLE=./aarch64-linux-user/qemu-aarch64

[Qemu-devel] [PATCH v2 1/4] tests/docker: add travis dockerfile

2016-10-03 Thread Alex Bennée
This target grabs the latest Travis containers from their repository at quay.io and then installs QEMU's build dependencies. With this it is possible to run on broadly the same setup as they have on travis-ci.org. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/travis.docker | 6 ++

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Alex Bennée
Emilio G. Cota writes: > On Mon, Oct 03, 2016 at 10:32:55 +0100, Alex Bennée wrote: > (snip) >> However the series as a whole does have value. As you can see from the >> other patches there are some real races being picked up by the sanitizer >> which only really become visible when a) you remov

Re: [Qemu-devel] [PATCH v4 03/13] virtio-crypto: introduce virtio_crypto.h

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 04:25:42PM +0800, Gonglei wrote: > Introdue the virtio_crypto.h which follows s/Introdue/Introduce/ signature.asc Description: PGP signature

[Qemu-devel] [PATCH 1/2] async: add aio_bh_schedule_oneshot

2016-10-03 Thread Paolo Bonzini
qemu_bh_delete is already clearing bh->scheduled at the same time as it's setting bh->deleted. Since it's not using any memory barriers, there is no synchronization going on for bh->deleted, and this makes the bh->deleted checks superfluous in aio_compute_timeout, aio_bh_poll and aio_ctx_check. J

[Qemu-devel] [PATCH 2/2] block: use aio_bh_schedule_oneshot

2016-10-03 Thread Paolo Bonzini
This simplifies bottom half handlers by removing calls to qemu_bh_delete and thus removing the need to stash the bottom half pointer in the opaque datum. Signed-off-by: Paolo Bonzini --- block/archipelago.c | 5 + block/blkdebug.c | 7 +-- block/blkverify.c | 8 ++-- bl

Re: [Qemu-devel] [PATCH v4 01/13] cryptodev: introduce cryptodev backend interface

2016-10-03 Thread Daniel P. Berrange
On Mon, Oct 03, 2016 at 05:10:48PM +0100, Stefan Hajnoczi wrote: > On Wed, Sep 28, 2016 at 04:25:40PM +0800, Gonglei wrote: > > diff --git a/backends/cryptodev.c b/backends/cryptodev.c > > new file mode 100644 > > index 000..a15904b > > --- /dev/null > > +++ b/backends/cryptodev.c > > @@ -0,0 +

[Qemu-devel] [PATCH 0/2] block: introduce and use aio_bh_schedule_oneshot

2016-10-03 Thread Paolo Bonzini
This simplifies a bit using the bottom half API in the common case of one-shot bottom halves, that are created once per usage. This patch comes from the multiqueue series. Paolo Paolo Bonzini (2): async: add aio_bh_schedule_oneshot block: use aio_bh_schedule_oneshot async.c |

Re: [Qemu-devel] [PATCH v4 02/13] cryptodev: add symmetric algorithm operation stuff

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 04:25:41PM +0800, Gonglei wrote: > This patch add session operation and crypto operation s/add/adds/ > stuff in the cryptodev backend, including function > pointers and correpsonding structures. s/correpsonding/corresponding/ > +/** > + * QCryptoCryptoDevBackendSymOpInfo

Re: [Qemu-devel] [PATCH v4 01/13] cryptodev: introduce cryptodev backend interface

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 04:25:40PM +0800, Gonglei wrote: > diff --git a/backends/cryptodev.c b/backends/cryptodev.c > new file mode 100644 > index 000..a15904b > --- /dev/null > +++ b/backends/cryptodev.c > @@ -0,0 +1,175 @@ > +/* > + * QEMU Crypto Device Implement s/Implement/Implementation/

Re: [Qemu-devel] [PATCH v3 1/8] apic: add global apic_get_class()

2016-10-03 Thread Eduardo Habkost
On Fri, Sep 30, 2016 at 06:10:06PM +0200, Radim Krčmář wrote: > Every configuration has only up to one APIC class and we'll be extending > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. > > This patch will break compilatio

Re: [Qemu-devel] [PATCH v11 1/2] virtio-crypto: Add virtio crypto device specification

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 05:08:24PM +0800, Gonglei wrote: > +For scatter/gather list support, a buffer can be represented by > virtio_crypto_iovec structure. > + > +The structure is defined as follows: > + > +\begin{lstlisting} > +struct virtio_crypto_iovec { > +/* Guest physical address */ > +

Re: [Qemu-devel] [PATCH v2 1/1] target-i386: Correct family/model/stepping for Opteron_G3

2016-10-03 Thread Eduardo Habkost
On Mon, Oct 03, 2016 at 02:50:02PM +0300, Denis V. Lunev wrote: > From: Evgeny Yakovlev > > Current CPU definition for AMD Opteron third generation includes > features like SSE4a and LAHF_LM support in emulated CPUID. These > features are present in K8 rev.E or K10 CPUs and later. However, > curr

Re: [Qemu-devel] [Bug 1626972] Re: [PATCH] util: secure memfd_create fallback mechanism

2016-10-03 Thread Rafael David Tinoco
Sorry, I was only able to come back to this today. > On Sep 27, 2016, at 09:18, Daniel Berrange <1626...@bugs.launchpad.net> wrote: > >> There are numerous people relying on older kernels in openstack >> deployments - sometimes with specific drivers (ovswitch, dpdk, >> infiniband) holding kerne

Re: [Qemu-devel] [PATCH v4 04/12] block/nbd: Use qdict_put()

2016-10-03 Thread Eric Blake
On 09/28/2016 03:55 PM, Max Reitz wrote: > Instead of inlining this nice macro (i.e. resorting to > qdict_put_obj(..., QOBJECT(...))), use it. > > Signed-off-by: Max Reitz > --- > block/nbd.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > Reviewed-by: Eric Blake Hmm

Re: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong

2016-10-03 Thread Emilio G. Cota
On Mon, Oct 03, 2016 at 10:32:55 +0100, Alex Bennée wrote: (snip) > However the series as a whole does have value. As you can see from the > other patches there are some real races being picked up by the sanitizer > which only really become visible when a) you remove the noise of the > "false" posi

Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options

2016-10-03 Thread Eric Blake
On 10/02/2016 02:13 PM, Tomáš Golembiovský wrote: > Added two new options 'offset' and 'size'. This makes it possible to use > only part of the file as a device. This can be used e.g. to limit the > access only to single partition in a disk image or use a disk inside a > tar archive (like OVA). >

Re: [Qemu-devel] [PATCH 01/12] virtio: add VIRTIO_DEF_DEVICE_VMSD macro

2016-10-03 Thread Paolo Bonzini
On 03/10/2016 15:34, Halil Pasic wrote: > Hi Paolo, > > I'm sorry, but I do not get it quite yet, or more exactly I have the > feeling I did not manage to bring my point over. So I will try with > more details. > > On 10/03/2016 01:29 PM, Paolo Bonzini wrote: >> >> >> On 03/10/2016 12:36, Halil

Re: [Qemu-devel] [PATCH 2/6] nbd: set name for all I/O channels created

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 04:16:56PM +0100, Daniel P. Berrange wrote: > Ensure that all I/O channels created for NBD are given names > to distinguish their respective roles. > > Signed-off-by: Daniel P. Berrange > --- > block/nbd.c| 1 + > blockdev-nbd.c | 3 +++ > nbd/client.c | 1 + > nbd/

Re: [Qemu-devel] [PATCH 4/6] migration: set name for all I/O channels created

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 04:16:58PM +0100, Daniel P. Berrange wrote: > Ensure that all I/O channels created for migration are given names > to distinguish their respective roles. > > Signed-off-by: Daniel P. Berrange > --- > migration/exec.c | 2 ++ > migration/fd.c| 2 ++ > migratio

Re: [Qemu-devel] [PATCH 5/6] vnc: set name for all I/O channels created

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 04:16:59PM +0100, Daniel P. Berrange wrote: > Ensure that all I/O channels created for VNC are given names > to distinguish their respective roles. > > Signed-off-by: Daniel P. Berrange > --- > ui/vnc-auth-vencrypt.c | 1 + > ui/vnc-ws.c| 3 +++ > ui/vnc.c

Re: [Qemu-devel] [PATCH 6/6] main: set names for main loop sources created

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 04:17:00PM +0100, Daniel P. Berrange wrote: > The main loop creates two generic sources for the AIO > and IO handler systems. > > Signed-off-by: Daniel P. Berrange > --- > main-loop.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc

Re: [Qemu-devel] [PATCH 3/6] char: set name for all I/O channels created

2016-10-03 Thread Stefan Hajnoczi
On Fri, Sep 30, 2016 at 04:16:57PM +0100, Daniel P. Berrange wrote: > Ensure that all I/O channels created for character devices > are given names to distinguish their respective roles. > > Signed-off-by: Daniel P. Berrange > --- > qemu-char.c | 77 >

Re: [Qemu-devel] [PATCH] spapr: fix check of cpu alias name in spapr_get_cpu_core_type()

2016-10-03 Thread Bharata B Rao
On Mon, Oct 03, 2016 at 02:13:20PM +0200, Greg Kurz wrote: > If the user passes an alias name and a property to -cpu, QEMU fails to > find the CPU definition and exits. > > $ qemu-system-ppc64 -cpu POWER8E,compat=power7 > qemu-system-ppc64: Unable to find sPAPR CPU Core definition > > This happen

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Shrink image size by specified offset

2016-10-03 Thread Eric Blake
On 10/03/2016 08:50 AM, Tomáš Golembiovský wrote: >> Additional context: >> >> off_t dev_offset = 0; >> >> off_t fd_size; >> >>> >>> +if (dev_offset >= fd_size) { >>> +error_report("Offset (%lu) has to be smaller than the image size >>> (%lu)", >>> + dev_o

Re: [Qemu-devel] [PATCH v5 00/20] Refactor trace to allow modular build

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:03PM +0100, Daniel P. Berrange wrote: > These patches were previously posted as part of my giant > trace events modular build series > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg01714.html > v2: https://lists.gnu.org/archive/html/qemu-devel/201

Re: [Qemu-devel] [PATCH v5 20/20] trace: introduce a formal group name for trace events

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:23PM +0100, Daniel P. Berrange wrote: > The declarations in the generated-tracers.h file are > assuming there's only ever going to be one instance > of this header, as they are not namespaced. When we > have one header per event group, if a single source > file needs t

Re: [Qemu-devel] [PATCH v5 19/20] trace: pass trace-events to tracetool as a positional param

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:22PM +0100, Daniel P. Berrange wrote: > Instead of reading the contents of 'trace-events' from stdin, > accept the filename as a positional parameter. This also > allows for reading from multiple files, though this facility > is not used at this time. > > Reviewed-by:

Re: [Qemu-devel] [PATCH v5 18/20] trace: push reading of events up a level to tracetool main

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:21PM +0100, Daniel P. Berrange wrote: > Move the reading of events out of the 'tracetool.generate' > method and into tracetool.main, so that the latter is not > tied to generating from a single source of events. > > Reviewed-by: Lluís Vilanova > Signed-off-by: Daniel

Re: [Qemu-devel] [PATCH v5 17/20] trace: rename _read_events to read_events

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:20PM +0100, Daniel P. Berrange wrote: > The _read_events method is used by callers outside of > its module, so should be a public method, not private. > > Reviewed-by: Lluís Vilanova > Signed-off-by: Daniel P. Berrange > --- > scripts/simpletrace.py| 6 +++

Re: [Qemu-devel] [PATCH v5 16/20] trace: get rid of generated-events.h/generated-events.c

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:19PM +0100, Daniel P. Berrange wrote: > Currently the generated-events.[ch] files contain the > event dstates, constants and TraceEvent structs, while the > generated-tracers.[ch] files contain the actual trace > probe logic. With the removal of usage of the event enum

Re: [Qemu-devel] [PATCH v5 15/20] trace: dynamically allocate event IDs at runtime

2016-10-03 Thread Stefan Hajnoczi
On Wed, Sep 28, 2016 at 02:08:18PM +0100, Daniel P. Berrange wrote: > Instead of having the code generator assign event IDs and > event VCPU IDs, assign them when the events are registered > at runtime. This will allow code to be generated from > individual trace-events without having to figure out

Re: [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

2016-10-03 Thread Maxime Coquelin
On 09/29/2016 10:21 PM, Michael S. Tsirkin wrote: On Thu, Sep 29, 2016 at 10:05:22PM +0200, Maxime Coquelin wrote: > > > On 09/29/2016 07:57 PM, Michael S. Tsirkin wrote: > > On Thu, Sep 29, 2016 at 05:30:53PM +0200, Maxime Coquelin wrote: > ... > > > > > > Before enabling anything by defau

  1   2   3   >