Re: [Qemu-devel] [RFC v3 2/3] vhost-net: Notify the backend about the host MTU

On 12/06/2016 07:31 PM, Aaron Conole wrote: Maxime Coquelin writes: This patch provides a way for virtio-net to notify the backend about the host MTU set by the user. Cc: Michael S. Tsirkin Cc: Aaron Conole Signed-off-by:

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Wed, Dec 07, 2016 at 02:09:16PM +0800, Lan Tianyu wrote: > On 2016年12月06日 18:59, Peter Xu wrote: > > On Tue, Dec 06, 2016 at 04:27:39PM +0800, Lan Tianyu wrote: > > > > [...] > > > >>> > User space driver(E.G DPDK) also can enable/disable > IOVA for device dynamically. > >>> > >>>

Re: [Qemu-devel] Booting my laptop with images from Qemu advent calendar

On 06.12.2016 23:42, Oscar A wrote: > Hello dear all, > > I just started to get interested in operative systems, booting, and > virtual machines, and found this project, which is very nice. I have > a question. For instance, take the Hanoi´s towers image of yesterday. > > I want to boot my

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On 2016年12月06日 18:59, Peter Xu wrote: > On Tue, Dec 06, 2016 at 04:27:39PM +0800, Lan Tianyu wrote: > > [...] > >>> User space driver(E.G DPDK) also can enable/disable IOVA for device dynamically. >>> >>> Could you provide more detailed (or any pointer) on how to do that? I >>> did try

[Qemu-devel] [PATCH for-2.9 1/2] intel_iommu: check validity for GAW bits in CE

Currently vt-d Context Entry (CE) only allows 39/48 bits address width. If guest software configured more than that, we complain and force shrink to the maximum supported, which is 48bits. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 12 +++-

[Qemu-devel] [PATCH for-2.9 2/2] intel_iommu: extend supported guest aw to 48 bits

Previously vt-d codes only supports 39 bits iova address width. It won't be hard to extend it to 48 bits. After enabling this, we should be able to map larger iova addresses. To check whether 48 bits aw is enabled, we can grep in the guest dmesg with line: "dmar: Host address width 48"

[Qemu-devel] [PATCH for-2.9 0/2] VT-d extend GAW to 48 bits

The first patch did some check to make sure the CE GAW bits are always valid (it can overflow in old codes, I see it dangerous). The second patch extended VT-d GAW (Guest Address Width) from 39 bits to 48 bits. Please review. Thanks, Peter Xu (2): intel_iommu: check validity for GAW bits in

[Qemu-devel] [PATCH 2/2] target-arm: Fix aarch64 disas_ldst_single_struct

We add s->be_data within do_vec_ld/st. Adding it here means that we have the wrong bits set in SIZE for a big-endian host, leading to g_assert_not_reached in write_vec_element and read_vec_element. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 4 ++-- 1

[Qemu-devel] [PATCH 1/2] target-arm: Fix aarch64 vec_reg_offset

Since CPUARMState.vfp.regs is not 16 byte aligned, the ^ 8 fixup used for a big-endian host doesn't do what's intended. Fix this by adding in the vfp.regs offset after computing the inter-register offset. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 3 ++-

[Qemu-devel] [PATCH 0/2] target-arm aarch64 big-endian fixes

I ran Alex's risu tests on an s390x host, and ran into two problems not related to the s390 backend. r~ Richard Henderson (2): target-arm: Fix aarch64 disas_ldst_single_struct target-arm: Fix aarch64 vec_reg_offset target-arm/translate-a64.c | 7 --- 1 file changed, 4 insertions(+),

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Tue, Dec 06, 2016 at 06:30:47PM +0100, Andrea Bolognani wrote: > On Fri, 2016-12-02 at 15:18 +1100, David Gibson wrote: > > > So, would the PCIe Root Bus in a pseries guest behave > > > differently than the one in a q35 or mach-virt guest? > >  > > Yes.  I had a long discussion with BenH and

Re: [Qemu-devel] [libvirt] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Mon, Dec 05, 2016 at 03:54:49PM -0500, Laine Stump wrote: > (Sorry for any duplicates. I sent it from the wrong address the first time) > > On 12/01/2016 11:18 PM, David Gibson wrote: > > On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: > > > On Wed, 2016-11-23 at 16:00 +1100,

Re: [Qemu-devel] Meeting notes on -blockdev, dynamic backend reconfiguration

On Mon, 12/05 13:03, Markus Armbruster wrote: > == Basic dynamic reconfiguration operation == > > The basic operation is "replace child". > > Beware of race conditions. Consider: > > BB > | > mirror-filter > | > BDS > > Add a throttle filter under BB

Re: [Qemu-devel] ui/egl-helpers.c license and reuse

> > From: John Snow [mailto:js...@redhat.com] > Sent: Wednesday, December 07, 2016 12:18 AM > To: Frediano Ziglio; Qemu-devel > Cc: Gerd Hoffmann; Peter Maydell; Gonglei (Arei); Cole Robinson > Subject: Re: [Qemu-devel] ui/egl-helpers.c license and reuse > > > > On 12/06/2016 10:47 AM, Frediano

[Qemu-devel] [PATCH for-2.9 v2] virtio-crypto: zeroize the key material before free

Common practice with sensitive information (key material, passwords, etc). Prevents sensitive information from being exposed by accident later in coredumps, memory disclosure bugs when heap memory is reused, etc. Sensitive information is sometimes also held in mlocked pages to prevent it being

Re: [Qemu-devel] Virtual Machine Generation ID

Hi Michael, I’m well on my way to implementing this, but I am really new to the QEMU code base and am struggling with some concepts. Please see below: > On Oct 5, 2016, at 6:29 PM, Michael S. Tsirkin wrote: > > On Tue, Oct 04, 2016 at 03:51:40PM -0700, Ed Swierk wrote: >> On

Re: [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

On 12/07/2016 09:02 AM, Stefano Stabellini wrote: Hello Zhang, Are the corresponding libxl patches already in xen.git? If so, could you please mention the commits; if not, could you please add a link to the corresponding patches? OK~~ Corresponding libxl patches already in xen.git. Commit

[Qemu-devel] [PATCH for-2.9] cryptodev: remove single-DES support in cryptodev

Single-DES is obsolete and it's broken/useless for decades, we should remove it in cryptodev, as suggested by Daniel. Guest who wants to use this obsolete cipher alg will use its built-in implementation instead. Signed-off-by: Longpeng(Mike) ---

Re: [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

Hello Zhang, Are the corresponding libxl patches already in xen.git? If so, could you please mention the commits; if not, could you please add a link to the corresponding patches? Thanks! - Stefano On Thu, 1 Dec 2016, Zhang Chen wrote: > Xen COLO depend on qemu COLO replication function. > So,

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

Hi Eric, On 2016/12/6 3:15, Eric Blake wrote: > On 12/05/2016 02:59 AM, Longpeng(Mike) wrote: >> This patch add standart DES support. > > s/standart/standard/ > >> >> Signed-off-by: Longpeng(Mike) >> --- > >> +++ b/qapi/crypto.json >> @@ -75,7 +75,7 @@ >> { 'enum':

Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

> > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Wednesday, December 07, 2016 4:18 AM > To: Eric Blake > Cc: Michael S. Tsirkin; Gonglei (Arei); qemu-devel@nongnu.org; Daniel P. > Berrange > Subject: Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key > material before

Re: [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

On Tue, Dec 06, 2016 at 05:52:26PM +0100, Laszlo Ersek wrote: > Mark, Artyom, do the sun4u machines support any kind of migration, given > that they are not versioned? > > Alex, David, do the mac_newworld / mac_oldworld machines support > migration, given that they are not versioned? I don't

[Qemu-devel] [PATCH] target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns

Hi. While qemu's behaviour matches what one would expect from reading the docs, it does not match what I'm seeing on h/w. Can anyone else confirm what the correct behaviour is here? --- The syscall and sysret instructions behave a bit differently: TF is checked after the instruction completes.

Re: [Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

On Tue, Dec 6, 2016 at 11:43 AM, Richard Henderson wrote: > On 12/06/2016 09:13 AM, Doug Evans wrote: >> @@ -7104,6 +7104,10 @@ static target_ulong disas_insn(CPUX86State *env, >> DisasContext *s, >> gen_update_cc_op(s); >> gen_jmp_im(pc_start - s->cs_base); >>

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 12/06/2016 04:23 PM, Max Reitz wrote: > On 06.12.2016 23:18, Eric Blake wrote: >> On 12/06/2016 04:14 PM, Max Reitz wrote: >>> On 06.12.2016 23:12, Eric Blake wrote: On 12/06/2016 04:00 PM, Max Reitz wrote: >> Tested by setting up an NBD server with export 'foo', then invoking:

Re: [Qemu-devel] [PATCH v3 5/5] tests: Add coverage for recent block geometry fixes

On 02.12.2016 20:22, Eric Blake wrote: > Use blkdebug's new geometry constraints to emulate setups that > have caused recent regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away portions >

Re: [Qemu-devel] [PATCH v3 4/5] blkdebug: Add ability to override unmap geometries

On 02.12.2016 20:22, Eric Blake wrote: > Make it easier to simulate various unusual hardware setups (for > example, recent commits 3482b9b and b8d0a98 affect the Dell > Equallogic iSCSI with its 15M preferred and maximum unmap and > write zero sizing, or b2f95fe deals with the Linux loopback >

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 06.12.2016 23:18, Eric Blake wrote: > On 12/06/2016 04:14 PM, Max Reitz wrote: >> On 06.12.2016 23:12, Eric Blake wrote: >>> On 12/06/2016 04:00 PM, Max Reitz wrote: >>> > Tested by setting up an NBD server with export 'foo', then invoking: > $ ./qemu-io > qemu-io> open -o

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 12/06/2016 04:14 PM, Max Reitz wrote: > On 06.12.2016 23:12, Eric Blake wrote: >> On 12/06/2016 04:00 PM, Max Reitz wrote: >> Tested by setting up an NBD server with export 'foo', then invoking: $ ./qemu-io qemu-io> open -o driver=blkdebug blkdebug::nbd://localhost:10809/foo >>

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 06.12.2016 23:12, Eric Blake wrote: > On 12/06/2016 04:00 PM, Max Reitz wrote: > >>> Tested by setting up an NBD server with export 'foo', then invoking: >>> $ ./qemu-io >>> qemu-io> open -o driver=blkdebug blkdebug::nbd://localhost:10809/foo > > By the way, I'd LOVE to know if there is a way

Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

On 12/06/2016 04:10 PM, Max Reitz wrote: > On 02.12.2016 20:22, Eric Blake wrote: >> Rather than store into a local variable, the copy to the struct >> if the value is valid, then reporting errors otherwise, > > It is rather difficult to part this sentence starting from "the copy". That's

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 12/06/2016 04:00 PM, Max Reitz wrote: >> Tested by setting up an NBD server with export 'foo', then invoking: >> $ ./qemu-io >> qemu-io> open -o driver=blkdebug blkdebug::nbd://localhost:10809/foo By the way, I'd LOVE to know if there is a way to write a qemu-io command line that would do

Re: [Qemu-devel] [PATCH v3 3/5] blkdebug: Simplify override logic

On 02.12.2016 20:22, Eric Blake wrote: > Rather than store into a local variable, the copy to the struct > if the value is valid, then reporting errors otherwise, It is rather difficult to part this sentence starting from "the copy". > it

Re: [Qemu-devel] [PATCH v3 2/5] blkdebug: Add pass-through write_zero and discard support

On 02.12.2016 20:22, Eric Blake wrote: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. It also allows us to inject errors on > those operations, just like we can for read/write/flush. >

Re: [Qemu-devel] [PATCH] qcow2: Discard/zero clusters by byte count

On 12/06/2016 03:31 PM, Max Reitz wrote: >>> >>> The only alternative I can come up with would be "qcow2_write_zeroes"; >>> that at least solves the first issue I have with this, but not the >>> second one... >> >> Maybe qcow2_cluster_zeroize() and qcow2_cluster_discard()? > > I think

[Qemu-devel] [Bug 1646610] Re: "Assertion `!r->req.sg' failed." during live migration with VirtIO

Thanks Thomas. Will do. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1646610 Title: "Assertion `!r->req.sg' failed." during live migration with VirtIO Status in QEMU: Incomplete Bug

Re: [Qemu-devel] [PATCH] qcow2: Discard/zero clusters by byte count

On 06.12.2016 22:26, Eric Blake wrote: > On 12/06/2016 03:01 PM, Max Reitz wrote: >> On 03.12.2016 19:19, Eric Blake wrote: >>> Passing a byte offset, but sector count, when we ultimately >>> want to operate on cluster granularity, is madness. Clean up >>> the interfaces to take byte offset and

Re: [Qemu-devel] [PATCH v3 1/5] blkdebug: Sanity check block layer guarantees

On 02.12.2016 20:22, Eric Blake wrote: > Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment > any I/O to fit within device boundaries. Additionally, when using a > minimum alignment of 4k, we want to ensure the block layer does proper > read-modify-write rather than requesting

Re: [Qemu-devel] [PATCH] qcow2: Discard/zero clusters by byte count

On 12/06/2016 03:01 PM, Max Reitz wrote: > On 03.12.2016 19:19, Eric Blake wrote: >> Passing a byte offset, but sector count, when we ultimately >> want to operate on cluster granularity, is madness. Clean up >> the interfaces to take byte offset and count. Rename >> qcow2_discard_clusters() and

[Qemu-devel] [Bug 1646610] Re: "Assertion `!r->req.sg' failed." during live migration with VirtIO

OK. QEMU version 2.3 is not maintained by the QEMU project any more. Can you reproduce it with the latest version (release candidate of 2.8 preferably, or at least 2.7)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [RFC PATCH 2/3] tcg: Reuse hashed pc value

Reuse the hashed pc value instead of calculating it again. Signed-off-by: Pranith Kumar --- cpu-exec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index f4a00f5047..13cb15de0e 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@

Re: [Qemu-devel] [PATCH] qcow2: Discard/zero clusters by byte count

On 03.12.2016 19:19, Eric Blake wrote: > Passing a byte offset, but sector count, when we ultimately > want to operate on cluster granularity, is madness. Clean up > the interfaces to take byte offset and count. Rename > qcow2_discard_clusters() and qcow2_zero_clusters() to the > shorter

[Qemu-devel] [RFC PATCH 3/3] tcg: Explicitly unlock tb_lock

Signed-off-by: Pranith Kumar --- exec.c | 2 ++ hw/i386/kvmvapic.c | 1 + translate-all.c| 3 +++ 3 files changed, 6 insertions(+) diff --git a/exec.c b/exec.c index 46e2044b1f..f49088b259 100644 --- a/exec.c +++ b/exec.c @@ -2115,11 +2115,13 @@ static

[Qemu-devel] [RFC PATCH 1/3] tcg: Release tb_lock in the order acquired

We acquire mmap lock and tb lock in one order and release them in a different order. This does not need to be that way. This patch was inspired by a previous patch by Emilio G. Cota (https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg03785.html). Signed-off-by: Pranith Kumar

[Qemu-devel] [RFC PATCH 0/3] tcg: tb lock updates

Hello, Please find a few minor tb lock updates in the MTTCG series. The main motivation was to remove tb_lock_reset() and explicitly unlock the tb_lock wherever possible so that reset() can be removed. This is not possible yet since we take interrupts and exit the execution loop with the tb lock

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 05:48:00PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] qapi: Document introduction of gluster's 'debug' option

On Tue, Dec 06, 2016 at 12:20:20PM -0600, Eric Blake wrote: > We intentionally renamed 'debug-level' to 'debug' in the QMP > schema for 'blockdev-add' related to gluster, in order to > match the command line (commit 1a417e46). However, since > 'debug-level' was visible in 2.7, that means that we

Re: [Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

On Tue, Dec 06, 2016 at 06:07:09PM +, Peter Maydell wrote: > A bug (1647683) was reported showing a crash when removing > breakpoints. The reproducer was bisected to 3359baad when tb_flush > was finally made thread safe. While in MTTCG the locking in > breakpoint_invalidate would have

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.8] qapi: Document DEVICE_TRAY_MOVED addition

On Tue, Dec 06, 2016 at 10:03:45AM -0600, Eric Blake wrote: > Commit 2d76e72 failed to add a versioning tag to 'id'. > > I audited all qapi*.json files from v2.7.0 to the current > state of the tree, and didn't find any other additions where > we failed to use a version tag. > > Signed-off-by:

Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

On Tue, Dec 06, 2016 at 01:30:12PM -0600, Eric Blake wrote: > On 12/06/2016 01:22 PM, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:33:37PM +, Stefan Hajnoczi wrote: > >> On Tue, Dec 06, 2016 at 03:40:49PM +0200, Michael S. Tsirkin wrote: > >>> On Tue, Dec 06, 2016 at 05:29:13PM

[Qemu-devel] [PATCH for-2.8 1/2] monitor: fix object_del for command-line-created objects

Currently objects specified on the command-line are only partially cleaned up when 'object_del' is issued in either HMP or QMP: the object itself is fully finalized, but the QemuOpts are not removed. This results in the following behavior: x86_64-softmmu/qemu-system-x86_64 -monitor stdio \

[Qemu-devel] [PATCH for-2.8 2/2] tests: check-qom-proplist: add checks for cmdline-created objects

check-qom-proplist originally added tests for verifying that object-creation helpers object_new_with_{props,propv} behaved in similar fashion to the "traditional" method involving setting each individual property separately after object creation rather than in via a single call. Another similar

[Qemu-devel] [PATCH for-2.8 0/2] Fixes/tests for hmp_object_del()

I'm tagging this as for-2.8 since there was interest expressed in getting this fixed with the 2.8 timeframe: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg05488.html https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00607.html I should note however that the issue noted in

Re: [Qemu-devel] [PATCH] tests: Ignore test-char binary

On Mon, Dec 05, 2016 at 06:52:41PM +0800, Lin Ma wrote: > Commit ea3af47d added test for chardev unit tests, but didn't add > the name of generated binary in .gitignore. > > Signed-off-by: Lin Ma > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) Thanks, I have

Re: [Qemu-devel] [PATCH] tests/.gitignore: Ignore test-char

On Mon, Nov 07, 2016 at 12:59:25PM +0800, Changlong Xie wrote: > Signed-off-by: Changlong Xie > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan signature.asc

Re: [Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

Peter Maydell writes: > A bug (1647683) was reported showing a crash when removing > breakpoints. The reproducer was bisected to 3359baad when tb_flush > was finally made thread safe. While in MTTCG the locking in > breakpoint_invalidate would have prevented any

Re: [Qemu-devel] [PATCH] x86: Fix eflags tracking for syscall insn

On 12/06/2016 09:13 AM, Doug Evans wrote: > @@ -7104,6 +7104,10 @@ static target_ulong disas_insn(CPUX86State *env, > DisasContext *s, > gen_update_cc_op(s); > gen_jmp_im(pc_start - s->cs_base); > gen_helper_syscall(cpu_env, tcg_const_i32(s->pc - pc_start)); > +

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec

[Qemu-devel] [PATCH v2 7/7] target-ppc: Implement bcdtrunc. instruction

bcdutrunc. Decimal unsigned truncate. Works like bcdtrunc. with unsigned BCD numbers. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 39 +

[Qemu-devel] [PATCH v2 5/7] target-ppc: Implement bcdsr. instruction

bcdsr.: Decimal shift and round. This instruction works like bcds. however, when performing right shift, 1 will be added to the result if the last digit was >= 5. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 +

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > > > On Tue, Dec

[Qemu-devel] [PATCH v2 6/7] target-ppc: Implement bcdtrunc. instruction

bcdtrunc.: Decimal integer truncate. Given a BCD number in vrb and the number of bytes to truncate in vra, the return register will have vrb with such bits truncated. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 +

[Qemu-devel] [PATCH v2 4/7] target-ppc: Implement bcdus. instruction

bcdus.: Decimal unsigned shift. This instruction works like bcds. but considers only unsigned BCDs (no sign in least meaning 4 bits). Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 43

[Qemu-devel] [PATCH v2 1/7] target-ppc: Implement bcd_is_valid function

A function to check if all digits of a given BCD number is valid is here presented because more instructions will need to reuse the same code. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/int_helper.c | 27 --- 1 file changed, 20

[Qemu-devel] [PATCH v2 2/7] target-ppc: Implement unsigned quadword left/right shift and unit tests

This commit implements functions to right and left shifts and the unittest for them. Such functions is needed due to instructions that requires them. Today, there is already a right shift implementation in int128.h but it's for signed numbers. Signed-off-by: Jose Ricardo Ziviani

[Qemu-devel] [PATCH v2 3/7] target-ppc: Implement bcds. instruction

bcds.: Decimal shift. Given two registers vra and vrb, this instruction shift the vrb value by vra bits into the result register. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 38

[Qemu-devel] [PATCH v2 0/7] POWER9 TCG enablements - BCD functions - final part

v2: - bcd[s,sr,us] uses 1 byte for shifting instead of 4 bytes - left/right functions in host-utils are out of CONFIG_INT128 - fixes overflowing issue in left shift and added a testcase This serie contains 5 new instructions for POWER9 ISA3.0, left/right shifts for unsigned quadwords and a

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > > Since commit

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > > -device

Re: [Qemu-devel] [PATCH v2 1/2] vfio iommu type1: Fix size argument to vfio_find_dma() during DMA UNMAP.

On Tue, 6 Dec 2016 23:56:54 +0530 Kirti Wankhede wrote: > Passing zero for the size to vfio_find_dma() isn't compatible with > matching the start address of an existing vfio_dma. Doing so triggers a > corner case. In vfio_find_dma(), when the start address is equal to >

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > > types because

[Qemu-devel] [RFC for-2.8] machine: Convert abstract typename on compat_props to subclass names

On Tue, Dec 06, 2016 at 05:19:52PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > > types because

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

On 12/06/2016 01:22 PM, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 05:33:37PM +, Stefan Hajnoczi wrote: >> On Tue, Dec 06, 2016 at 03:40:49PM +0200, Michael S. Tsirkin wrote: >>> On Tue, Dec 06, 2016 at 05:29:13PM +0800, Gonglei wrote: Zeroize the memory of

Re: [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

On Tue, 6 Dec 2016, Igor Mammedov wrote: > > First, to my knowledge, Xen does not use fw_cfg. The following call > > chains depend on (!xen_enabled()): > maybe not, it's just grep gave me: > xen_load_linux() -> fw_cfg_init_io() > maybe it's dead code now [...] > > > > pc_init1() |

Re: [Qemu-devel] [PATCH for-2.8] virtio-crypto: zeroize the key material before free

On Tue, Dec 06, 2016 at 05:33:37PM +, Stefan Hajnoczi wrote: > On Tue, Dec 06, 2016 at 03:40:49PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:29:13PM +0800, Gonglei wrote: > > > Zeroize the memory of CryptoDevBackendSymOpInfo structure pointed > > > for key material

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

[Qemu-devel] [PATCH v3 3/3] ui: add support for mice with extra/side buttons

Adds input event generation for BTN_SIDE and BTN_EXTRA events to gtk and input-linux methods. Signed-off-by: Fabian Lesniak --- ui/gtk.c | 4 ui/input-linux.c | 6 ++ 2 files changed, 10 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index

[Qemu-devel] [PATCH v3 2/3] ps2: add support for mice with extra/side buttons

This enables the ps2 controller to process mouse events for buttons 4 and 5. Additionally, distinct definitions for the ps2 mouse button state are introduced. The legacy definitions from console.h are not used anymore. Signed-off-by: Fabian Lesniak --- hw/input/ps2.c

[Qemu-devel] [PATCH v3 0/3] add support for mice with extra/side buttons

This patch implements event handling for 5-button ps/2 mice and appropriate event generation for gtk and input-linux input methods. As Gerd suggested, it is now split into three parts and introduces distinct ps2 mouse button definitions instead of using the legacy ones from console.h. Please

[Qemu-devel] [PATCH v3 1/3] qapi: add support for mice with extra/side buttons

Adds "side" and "extra" values to enum InputButton. The naming was borrowed from evdev since it is more descriptive than "button4" and "button5". Signed-off-by: Fabian Lesniak --- qapi-schema.json | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

[Qemu-devel] [Bug 1646610] Re: "Assertion `!r->req.sg' failed." during live migration with VirtIO

Hi Thomas, Thanks for looking. We're using version 2.3.0. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1646610 Title: "Assertion `!r->req.sg' failed." during live migration with VirtIO Status

Re: [Qemu-devel] [RFC v3 2/3] vhost-net: Notify the backend about the host MTU

Maxime Coquelin writes: > This patch provides a way for virtio-net to notify the > backend about the host MTU set by the user. > > Cc: Michael S. Tsirkin > Cc: Aaron Conole > Signed-off-by: Maxime Coquelin

[Qemu-devel] [PATCH v2 2/2] vfio iommu: Fix size argument to vfio_find_dma() in pin_pages/unpin_pages

Passing zero for the size to vfio_find_dma() isn't compatible with matching the start address of an existing vfio_dma. Doing so triggers a corner case. In vfio_find_dma(), when the start address is equal to dma->iova and size is 0, check for the end of search range makes it to take wrong side of

[Qemu-devel] [PATCH v2 1/2] vfio iommu type1: Fix size argument to vfio_find_dma() during DMA UNMAP.

Passing zero for the size to vfio_find_dma() isn't compatible with matching the start address of an existing vfio_dma. Doing so triggers a corner case. In vfio_find_dma(), when the start address is equal to dma->iova and size is 0, check for the end of search range makes it to take wrong side of

Re: [Qemu-devel] [PATCH v2 1/2] vfio iommu type1: Fix size argument to vfio_find_dma() during DMA UNMAP.

On 12/6/2016 11:08 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 22:43:30 +0530 > Kirti Wankhede wrote: > >> vfio_dma keeps track of address range from (dma->iova + 0) to >> (dma->iova + dma->size - 1), while vfio_find_dma() search logic looks for >> range from

[Qemu-devel] [PATCH for-2.8] qapi: Document introduction of gluster's 'debug' option

We intentionally renamed 'debug-level' to 'debug' in the QMP schema for 'blockdev-add' related to gluster, in order to match the command line (commit 1a417e46). However, since 'debug-level' was visible in 2.7, that means that we should document that 'debug' was not available until 2.8. The

[Qemu-devel] [kvm-unit-tests PATCH v14 4/5] arm: pmu: Check cycle count increases

From: Christopher Covington Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, even for the smallest delta of two subsequent reads. Signed-off-by: Christopher Covington Signed-off-by: Wei Huang --- arm/pmu.c | 66

[Qemu-devel] [kvm-unit-tests PATCH v14 1/5] arm: rename cp15.h to sysreg.h

To prepare for future support of ARMv8 system register, rename cp15.h file to sysreg.h, with _ASMARM_CP15_H_ renamed to _ASMARM_SYSREG_H_ in header file. Signed-off-by: Wei Huang --- arm/cstart.S | 2 +- lib/arm/asm/{cp15.h => sysreg.h} | 6 +++--- 2 files

Re: [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

On Tue, 6 Dec 2016 17:46:51 +0100 Laszlo Ersek wrote: > On 12/06/16 12:49, Igor Mammedov wrote: > > On Thu, 1 Dec 2016 18:06:20 +0100 > > Laszlo Ersek wrote: > > > >> Accordingly, generalize the "file_slots" minimum calculation in > >>

[Qemu-devel] [PATCH 2/3] hw/intc/arm_gicv3: Remove incorrect usage of fieldoffset

In the ARMCPRegInfo definitions for the GICv3 CPU interface registers, we were trying to use .fieldoffset to specify the locations of data fields within the GICv3CPUState struct. This is completely broken, because .fieldoffset is for offsets into the CPUARMState struct. We didn't notice because we

[Qemu-devel] [kvm-unit-tests PATCH v14 3/5] arm: Add PMU test

From: Christopher Covington Beginning with a simple sanity check of the control register, add a unit test for the ARM Performance Monitors Unit (PMU). Signed-off-by: Christopher Covington Signed-off-by: Wei Huang ---

[Qemu-devel] [PATCH 1/3] target-arm: Log AArch64 exception returns

We already log exception entry; add logging of the AArch64 exception return path as well. Signed-off-by: Peter Maydell --- target-arm/op_helper.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index

[Qemu-devel] [kvm-unit-tests PATCH v14 2/5] arm: Add support for read_sysreg() and write_sysreg()

This patch adds two new macros to support read/write operations of ARMv7 and ARMv8 system registers. As part of the change, xstr() is revised to support variable arguments. With it, ARMv7 system register can be defined with __ACCESS_CP15() or __ACCESS_CP15_64() depending if it is 32-bit or 64-bit.

[Qemu-devel] [kvm-unit-tests PATCH v14 0/5] ARM PMU tests

Changes from v13: * Rename cp15.h to sysreg.h for ARMv7 and add a new file sysreg.h for ARMv8 * Add macros for read_sysreg() and write_sysreg(). CP15 registers can be defined with __ACCESS_CP15() or __ACCESS_CP15_64(). sysreg.h (ARMv8) was from Drew's GIC testing code, which can be leveraged

[Qemu-devel] [PATCH for-2.8] exec.c: Fix breakpoint invalidation race

A bug (1647683) was reported showing a crash when removing breakpoints. The reproducer was bisected to 3359baad when tb_flush was finally made thread safe. While in MTTCG the locking in breakpoint_invalidate would have prevented any problems, but currently tb_lock() is a NOP for system

[Qemu-devel] [kvm-unit-tests PATCH v14 5/5] arm: pmu: Add CPI checking

From: Christopher Covington Calculate the numbers of cycles per instruction (CPI) implied by ARM PMU cycle counter values. The code includes a strict checking facility intended for the -icount option in TCG mode in the configuration file. Signed-off-by: Christopher

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

On Tue, 06 Dec 2016 18:50:47 +0100 Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property >

[Qemu-devel] [PATCH 3/3] hw/intc/arm_gicv3: Don't signal Pending+Active interrupts to CPU

The GICv3 requires that we only signal Pending interrupts to the CPU. This category does not include Pending+Active interrupts, which means we need to check whether the interrupt is Active in the gicr_int_pending() and gicd_int_pending() functions. Interrupts are rarely in the Active+Pending

  1   2   3   >