Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Markus Armbruster
Eric Blake writes: > On 02/02/2017 01:42 PM, Markus Armbruster wrote: > >> >> === Structured values === >> >> The dotted key convention messes with KEY syntax to permit structured >> values. Works, but the more conventional way to support structured >> values is a syntax for structured values.

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> = Introduction = >> > > > >> = Structured option argument syntax = >> >> == JSON == >> >> The obvious way to provide the expressiveness of JSON on the command >> line is JSON. Easy enough[2]. However, besid

Re: [Qemu-devel] [PATCH v5 03/18] vfio: allow to notify unmap for very large region

2017-02-02 Thread Peter Xu
On Tue, Jan 31, 2017 at 02:35:00PM +1100, David Gibson wrote: > On Tue, Jan 24, 2017 at 09:32:07AM -0700, Alex Williamson wrote: > > On Tue, 24 Jan 2017 18:25:56 +0800 > > Peter Xu wrote: > > > > > Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big > > > region. This can be leve

[Qemu-devel] [PATCH 1/3] kvm/ioapic: dump real object instead of a fake one

2017-02-02 Thread Peter Xu
When we do "info ioapic" for kvm ioapic, we were building up a temporary ioapic object. Let's fetch the real one and update correspond to the real object as well. This fixes printing uninitialized version field in ioapic_print_redtbl(). Reported-by: Peter Maydell Suggested-by: Paolo Bonzini Sig

[Qemu-devel] [PATCH 3/3] kvm/ioapic: correct kvm ioapic version

2017-02-02 Thread Peter Xu
Signed-off-by: Peter Xu --- hw/i386/kvm/ioapic.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 716d59a..98ca480 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -143,6 +143,11 @@ static void kvm_ioapic_realize(DeviceState

[Qemu-devel] [PATCH 2/3] ioapic: fix error report value of def version

2017-02-02 Thread Peter Xu
It should be 0x20, rather than 0x11. Signed-off-by: Peter Xu --- hw/intc/ioapic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 9047b89..37c4386 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -408,13 +408,15 @@ static

[Qemu-devel] [PATCH 0/3] kvm/ioapic: some tiny tweaks

2017-02-02 Thread Peter Xu
This series fixes the issue pointed out by PMM in thread: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg06323.html Along with other two patches to make the version more accurate. Thanks, Peter Xu (3): kvm/ioapic: dump real object instead of a fake one ioapic: fix error report va

Re: [Qemu-devel] [PULL 23/35] x86: ioapic: dump version for "info ioapic"

2017-02-02 Thread Peter Xu
On Mon, Jan 30, 2017 at 02:33:32PM -0500, Paolo Bonzini wrote: > > > On 30/01/2017 09:07, Peter Maydell wrote: > > On 20 January 2017 at 13:31, Paolo Bonzini wrote: > >> From: Peter Xu > >> > >> Signed-off-by: Peter Xu > >> Message-Id: <1483952153-7221-3-git-send-email-pet...@redhat.com> > >>

Re: [Qemu-devel] [RFC/RFT PATCH 0/7] cpu-exec: simplify cpu_exec and remove some icount special cases

2017-02-02 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 31/01/2017 01:05, Pavel Dovgalyuk wrote: > > Hi, Paolo! > > > > Thanks for refactoring. > > I tested these patches with icount record/replay on i386 machine. > > It works, but the following changes should be a

Re: [Qemu-devel] [PATCH 3/3] spapr: make cpu core unplug follow expected hotunplug call flow

2017-02-02 Thread Bharata B Rao
On Thu, Feb 02, 2017 at 04:02:35PM +0100, Igor Mammedov wrote: > spapr_core_unplug() were essentially spapr_core_unplug_request() > handler that requested CPU removal and registered callback > which did actual cpu core removali but it was called from > spapr_machine_device_unplug() which is intende

Re: [Qemu-devel] [PATCH 1/3] spapr: cpu core: separate child threads destruction from machine state operations

2017-02-02 Thread Bharata B Rao
On Thu, Feb 02, 2017 at 04:02:33PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/ppc/spapr_cpu_core.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > I would mention explicitly that we are adding core unrealizefn and doing threads' destruction

[Qemu-devel] [PATCH] xhci: fix event queue IRQ handling

2017-02-02 Thread Gerd Hoffmann
The qemu xhci emulation doesn't handle the ERDP_EHB flag correctly. When the host adapter queues a new event the ERDP_EHB flag is set. The flag is cleared (via w1c) by the guest when it updates the ERDP (event ring dequeue pointer) register to notify the host adapter which events it has fetched.

Re: [Qemu-devel] [PATCH 3/3] colo-compare: use notifier to notify inconsistent packets comparing

2017-02-02 Thread Jason Wang
On 2017年01月24日 22:05, zhanghailiang wrote: It's a good idea to use notifier to notify COLO frame of inconsistent packets comparing. Signed-off-by: Zhang Chen Signed-off-by: zhanghailiang --- net/colo-compare.c | 24 ++-- net/colo-compare.h | 2 ++ 2 files changed, 24

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-02 Thread Jason Wang
On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing To make it clearer, we rename 'timer_

Re: [Qemu-devel] [PATCH] colo-compare: sort TCP packet queue by sequence number

2017-02-02 Thread Jason Wang
On 2017年01月24日 16:53, Zhang Chen wrote: Improve efficiency of TCP packet comparison. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian --- net/colo-compare.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 9bfc736..5

Re: [Qemu-devel] [RFC PATCH v2 0/2] softfloat: Add round-to-odd rounding mode

2017-02-02 Thread Bharata B Rao
Peter, On Fri, Jan 27, 2017 at 01:33:31PM +0530, Bharata B Rao wrote: > > Changes in v2: > - > - Do odd or even for the right precision bit in 64bit rounding. (Peter > Maydell) > - Handle the overflow case correctly in 64bit rounding. (Peter Maydell) Does this version of round-to-od

Re: [Qemu-devel] [PATCH] net: e1000e: fix dead code in e1000e_write_packet_to_guest

2017-02-02 Thread Jason Wang
On 2017年01月26日 18:10, Paolo Bonzini wrote: Because is_first is declared inside a loop, it is always true. The store is dead, and so is the "else" branch of "if (is_first)". is_last is okay though. Reported by Coverity. Signed-off-by: Paolo Bonzini --- hw/net/e1000e_core.c | 2 +- 1 file

[Qemu-devel] [RESEND PATCH v2] docs: add document to explain the usage of vNVDIMM

2017-02-02 Thread Haozhong Zhang
Signed-off-by: Haozhong Zhang Reviewed-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi --- Changes since v1: * explicitly state the block window mode is not supported (Stefan Hajnoczi) * typo fix: label_size ==> label-size (David Alan Gilbert) --- docs/nvdimm.txt | 124 +

Re: [Qemu-devel] new developer

2017-02-02 Thread Fam Zheng
On Wed, 02/01 17:41, Shubham Kumar wrote: > Sir > > I'm a third year Indian engineering student looking for experience in open > source development. I read about QEMU and I want to be a contributor for this > organisation.Can you guide me where exactly to start since I'm new to this ?? > Thanks in

Re: [Qemu-devel] [PATCH] hw/pxb-pcie: fix PCI Express hotplug support

2017-02-02 Thread Michael S. Tsirkin
On Fri, Feb 03, 2017 at 12:44:17AM +0200, Marcel Apfelbaum wrote: > On 02/03/2017 12:34 AM, Michael S. Tsirkin wrote: > > On Fri, Feb 03, 2017 at 12:05:52AM +0200, Marcel Apfelbaum wrote: > > > Add the missing osc method for pxb-pcie devices > > > > > > Signed-off-by: Marcel Apfelbaum > > > --- >

Re: [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202

2017-02-02 Thread David Gibson
On Wed, Feb 01, 2017 at 11:41:40PM -0800, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202 > Message-id:

Re: [Qemu-devel] [PATCH] hw/pxb-pcie: fix PCI Express hotplug support

2017-02-02 Thread Marcel Apfelbaum
On 02/03/2017 12:34 AM, Michael S. Tsirkin wrote: On Fri, Feb 03, 2017 at 12:05:52AM +0200, Marcel Apfelbaum wrote: Add the missing osc method for pxb-pcie devices Signed-off-by: Marcel Apfelbaum --- Note: The patch is based on the fact that Q35's osc method is quite generic. Thanks, Marcel

Re: [Qemu-devel] [PATCH] hw/pxb-pcie: fix PCI Express hotplug support

2017-02-02 Thread Michael S. Tsirkin
On Fri, Feb 03, 2017 at 12:05:52AM +0200, Marcel Apfelbaum wrote: > Add the missing osc method for pxb-pcie devices > > Signed-off-by: Marcel Apfelbaum > --- > > Note: The patch is based on the fact that Q35's osc method is quite generic. > > Thanks, > Marcel > > hw/i386/acpi-build.c | 5

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-02 Thread Marcel Apfelbaum
On 02/03/2017 12:13 AM, Gerd Hoffmann wrote: On Do, 2017-02-02 at 16:20 +0100, Andrea Bolognani wrote: On Thu, 2017-02-02 at 16:42 +0200, Marcel Apfelbaum wrote: [...] I personally don't use them because every time I try, I find something with no config support Is that so? Can you pl

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-02 Thread Gerd Hoffmann
On Do, 2017-02-02 at 16:20 +0100, Andrea Bolognani wrote: > On Thu, 2017-02-02 at 16:42 +0200, Marcel Apfelbaum wrote: > [...] > > > +[device "ich9-pcie-port-1"] > > > > I would use the new generic root port. > > This sample configuration (q35-emulated.cfg) is supposed to > match physical hardwar

Re: [Qemu-devel] [PATCH] tci: Remove invalid assertions

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 09:10:26PM +0100, Stefan Weil wrote: > Am 02.02.2017 um 21:00 schrieb Eric Blake: > > On 02/02/2017 01:56 PM, Stefan Weil wrote: > > > tb_jmp_insn_offset and tb_jmp_reset_offset are pointers > > > and cannot be used with ARRAY_SIZE. > > > > > > Signed-off-by: Stefan Weil >

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Gerd Hoffmann
On Do, 2017-02-02 at 16:35 +0100, Andrea Bolognani wrote: > On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > > +++ b/docs/q35-emulated.cfg > > > > > > +# 00:01.0 VGA compatible controller > > > > > > +[device "video"] > > > + driver = "VGA" > > > + bus = "pcie.0" > > > + addr = "0

[Qemu-devel] [PATCH] hw/pxb-pcie: fix PCI Express hotplug support

2017-02-02 Thread Marcel Apfelbaum
Add the missing osc method for pxb-pcie devices Signed-off-by: Marcel Apfelbaum --- Note: The patch is based on the fact that Q35's osc method is quite generic. Thanks, Marcel hw/i386/acpi-build.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-bui

Re: [Qemu-devel] [PATCH] qga: ignore EBUSY when freezing a filesystem

2017-02-02 Thread Paolo Bonzini
On 31/01/2017 07:36, Peter Lieven wrote: > the current implementation fails if we try to freeze an > already frozen filesystem. This can happen if a filesystem > is mounted more than once (e.g. with a bind mount). > > Suggested-by: Christian Theune > Cc: qemu-sta...@nongnu.org > Signed-off-by:

[Qemu-devel] [Bug 1661386] [NEW] Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-02-02 Thread Matwey V. Kornilov
Public bug reported: Hello, I see the following when try to run qemu from master as the following: # ./x86_64-softmmu/qemu-system-x86_64 --version QEMU emulator version 2.8.50 (v2.8.0-1006-g4e9f524) Copyright (c) 2003-2016 Fabrice Bellard and the QEMU Project developers # ./x86_64-softmmu/qemu-

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Ketan Nilangekar
On 2/2/17, 12:57 PM, "Ketan Nilangekar" wrote: On 2/2/17, 2:15 AM, "Daniel P. Berrange" wrote: On Thu, Feb 02, 2017 at 10:07:28AM +, Stefan Hajnoczi wrote: > On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > > Patch for secure imp

[Qemu-devel] regarding codebase

2017-02-02 Thread Shubham Kumar
Sir I'm having difficulty in understanding the codebase of QEMU .There seem to have hundreds of code files and header files in the directory and I'm unable to figure out the functionality of each file.Is there any way to understand the function of each file ?? Regards Shubham Kumar

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Ketan Nilangekar
On 2/2/17, 2:15 AM, "Daniel P. Berrange" wrote: On Thu, Feb 02, 2017 at 10:07:28AM +, Stefan Hajnoczi wrote: > On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > > Patch for secure implementation in libqnio is available for review here: > > > > https://

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

2017-02-02 Thread Ketan Nilangekar
On 2/2/17, 2:07 AM, "Stefan Hajnoczi" wrote: On Wed, Feb 01, 2017 at 11:59:53PM +, Ketan Nilangekar wrote: > Patch for secure implementation in libqnio is available for review here: > > https://github.com/VeritasHyperScale/libqnio/pull/12 > > libqnio client initial

Re: [Qemu-devel] [PATCH v2] q35: Improve sample configuration files

2017-02-02 Thread Marcel Apfelbaum
On 02/02/2017 05:20 PM, Andrea Bolognani wrote: On Thu, 2017-02-02 at 16:42 +0200, Marcel Apfelbaum wrote: [...] +[device "ich9-pcie-port-1"] I would use the new generic root port. This sample configuration (q35-emulated.cfg) is supposed to match physical hardware as closely as possible, so

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > = Introduction = > > = Structured option argument syntax = > > == JSON == > > The obvious way to provide the expressiveness of JSON on the command > line is JSON. Easy enough[2]. However, besides not being compatible, > it's rather heavy on s

Re: [Qemu-devel] [PATCH] tci: Remove invalid assertions

2017-02-02 Thread Eric Blake
On 02/02/2017 02:10 PM, Stefan Weil wrote: > Am 02.02.2017 um 21:00 schrieb Eric Blake: >> On 02/02/2017 01:56 PM, Stefan Weil wrote: >>> tb_jmp_insn_offset and tb_jmp_reset_offset are pointers >>> and cannot be used with ARRAY_SIZE. >>> >> mst posted an alternative patch: >> https://lists.gnu.org

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Eric Blake
On 02/02/2017 01:42 PM, Markus Armbruster wrote: > > === Structured values === > > The dotted key convention messes with KEY syntax to permit structured > values. Works, but the more conventional way to support structured > values is a syntax for structured values. > > An obvious one is to u

Re: [Qemu-devel] regarding QEMU cloning

2017-02-02 Thread Peter Maydell
On 2 February 2017 at 19:45, Shubham Kumar wrote: > I'm unable to clone QEMU using this command on my terminal > " git clone git://git.qemu-project.org/qemu.git ". > The error I'm receiving is >" fatal: unable to access > 'https://git.qemu-project.org/qemu.git/': Received HTTP code 5

[Qemu-devel] [PATCH 3/9] armv7m: Rewrite NVIC to not use any GIC code

2017-02-02 Thread Peter Maydell
From: Michael Davidsaver Despite some superficial similarities of register layout, the M-profile NVIC is really very different from the A-profile GIC. Our current attempt to reuse the GIC code means that we have significant bugs in our NVIC. Implement the NVIC as an entirely separate device, to

[Qemu-devel] [PATCH 1/9] armv7m: Rename nvic_state to NVICState

2017-02-02 Thread Peter Maydell
Rename the nvic_state struct to NVICState, to match our naming conventions. Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c inde

[Qemu-devel] [PATCH 2/9] armv7m: Implement reading and writing of PRIGROUP

2017-02-02 Thread Peter Maydell
Add a state field for the v7M PRIGROUP register and implent reading and writing it. The current NVIC doesn't honour the values written, but the new version will. Signed-off-by: Peter Maydell --- hw/intc/armv7m_nvic.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH] tci: Remove invalid assertions

2017-02-02 Thread Stefan Weil
Am 02.02.2017 um 21:00 schrieb Eric Blake: On 02/02/2017 01:56 PM, Stefan Weil wrote: tb_jmp_insn_offset and tb_jmp_reset_offset are pointers and cannot be used with ARRAY_SIZE. Signed-off-by: Stefan Weil --- tcg/tci/tcg-target.inc.c | 2 -- 1 file changed, 2 deletions(-) mst posted an alte

[Qemu-devel] [PATCH 4/9] armv7m: Fix condition check for taking exceptions

2017-02-02 Thread Peter Maydell
The M profile condition for when we can take a pending exception or interrupt is not the same as that for A/R profile. The code originally copied from the A/R profile version of the cpu_exec_interrupt function only worked by chance for the very simple case of exceptions being masked by PRIMASK. Re

Re: [Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Eric Blake
On 02/02/2017 01:42 PM, Markus Armbruster wrote: quick comment before I reply to the overall message... > Arbitrary nesting with dotted key convention: > > -drive driver=qcow2,file.driver=gluster, >file.volume=testvol,file.path=/path/a.qcow2,file.debug=9, >file.serve

[Qemu-devel] [PATCH 5/9] arm: gic: Remove references to NVIC

2017-02-02 Thread Peter Maydell
From: Michael Davidsaver Now that the NVIC is its own separate implementation, we can clean up the GIC code by removing REV_NVIC and conditionals which use it. Signed-off-by: Michael Davidsaver Signed-off-by: Peter Maydell --- hw/intc/gic_internal.h | 7 ++- hw/intc/arm_gic.c|

[Qemu-devel] [PATCH 6/9] armv7m: Escalate exceptions to HardFault if necessary

2017-02-02 Thread Peter Maydell
From: Michael Davidsaver The v7M exception architecture requires that if a synchronous exception cannot be taken immediately (because it is disabled or at too low a priority) then it should be escalated to HardFault (and the HardFault exception is then taken). Implement this escalation logic. Si

[Qemu-devel] [PATCH 9/9] armv7m: VECTCLRACTIVE and VECTRESET are UNPREDICTABLE

2017-02-02 Thread Peter Maydell
From: Michael Davidsaver The VECTCLRACTIVE and VECTRESET bits in the AIRCR are both documented as UNPREDICTABLE if you write a 1 to them when the processor is not halted in Debug state (ie stopped and under the control of an external JTAG debugger). Since we don't implement Debug state or emulate

[Qemu-devel] [PATCH 8/9] armv7m: Simpler and faster exception start

2017-02-02 Thread Peter Maydell
From: Michael Davidsaver All the places in armv7m_cpu_do_interrupt() which pend an exception in the NVIC are doing so for synchronous exceptions. We know that we will always take some exception in this case, so we can just acknowledge it immediately, rather than returning and then immediately bei

[Qemu-devel] [PATCH 0/9] Rewrite NVIC to not depend on the GIC

2017-02-02 Thread Peter Maydell
This patchset is the revamp of the NVIC code from Michael Davidsaver's patchset of a year ago. Despite some superficial similarities of register layout, the M-profile NVIC is really very different from the A-profile GIC. Our current attempt to reuse the GIC code means that we have significant bug

[Qemu-devel] [PATCH 7/9] armv7m: Remove unused armv7m_nvic_acknowledge_irq() return value

2017-02-02 Thread Peter Maydell
Having armv7m_nvic_acknowledge_irq() return the new value of env->v7m.exception and its one caller assign the return value back to env->v7m.exception is pointless. Just make the return type void instead. Signed-off-by: Peter Maydell --- target/arm/cpu.h | 2 +- hw/intc/armv7m_nvic.c | 4 +--

Re: [Qemu-devel] [PATCH] tci: Remove invalid assertions

2017-02-02 Thread Eric Blake
On 02/02/2017 01:56 PM, Stefan Weil wrote: > tb_jmp_insn_offset and tb_jmp_reset_offset are pointers > and cannot be used with ARRAY_SIZE. > > Signed-off-by: Stefan Weil > --- > tcg/tci/tcg-target.inc.c | 2 -- > 1 file changed, 2 deletions(-) mst posted an alternative patch: https://lists.gnu.

[Qemu-devel] [PATCH] tci: Remove invalid assertions

2017-02-02 Thread Stefan Weil
tb_jmp_insn_offset and tb_jmp_reset_offset are pointers and cannot be used with ARRAY_SIZE. Signed-off-by: Stefan Weil --- tcg/tci/tcg-target.inc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tcg/tci/tcg-target.inc.c b/tcg/tci/tcg-target.inc.c index 26ee9b1664..b6a15569f8 100644 --- a/t

[Qemu-devel] regarding QEMU cloning

2017-02-02 Thread Shubham Kumar
sir I'm unable to clone QEMU using this command on my terminal " git clone git://git.qemu-project.org/qemu.git ". The error I'm receiving is " fatal: unable to access 'https://git.qemu-project.org/qemu.git/': Received HTTP code 503 from proxy after CONNECT". I have tried many soluti

[Qemu-devel] Non-flat command line option argument syntax

2017-02-02 Thread Markus Armbruster
= Introduction = If you're familiar with prior discussion of non-flat arguments for -object and -blockdev, you can probably skip ahead to "= Structured option argument syntax =". Structured option arguments use KEY=VALUE,... syntax. Goes back many years (at least to commit 7c9d8e0, Nov 2005). S

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Pekka Enberg
Hi, On 02/02/2017 19.48, Ard Biesheuvel wrote: $ git grep -C5 -ni 0x1DE7EC7EDBADC0DE arch/arm64/kvm/sys_regs.h-105-static inline void reset_unknown(struct kvm_vcpu *vcpu, arch/arm64/kvm/sys_regs.h-106- const struct sys_reg_desc *r) arch/arm64/kvm/sys_regs.h-107-{ arch/a

[Qemu-devel] [PATCH] usb: ccid: check ccid apdu length

2017-02-02 Thread P J P
From: Prasad J Pandit CCID device emulator uses Application Protocol Data Units(APDU) to exchange command and responses to and from the host. The length in these units couldn't be greater than 65536. Add check to ensure the same. It'd also avoid potential integer overflow in emulated_apdu_from_gu

Re: [Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

2017-02-02 Thread Emilio G. Cota
Just noticed the message above mistakenly sat in my outbox for nearly 2 months. Just flushed it, so do not be surprised by its original date. Sorry for the noise, Emilio

[Qemu-devel] tci build failure (was Re: [PULL v5 00/22] virtio, vhost, pci: fixes, features)

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 04:25:34PM +, Peter Maydell wrote: > On 2 February 2017 at 13:56, Peter Maydell wrote: > > On 31 January 2017 at 20:18, Michael S. Tsirkin wrote: > >> virtio, vhost, pci: fixes, features > >> > >> generic pci root port support > >> disable shpc by default > >> safer ve

Re: [Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

2017-02-02 Thread Emilio G. Cota
On Tue, Nov 29, 2016 at 12:46:59 +0100, Paolo Bonzini wrote: > A QemuLockCnt comprises a counter and a mutex, with primitives > to increment and decrement the counter, and to take and release the > mutex. It can be used to do lock-free visits to a data structure > whenever mutexes would be too hea

Re: [Qemu-devel] [PULL v5 00/22] virtio, vhost, pci: fixes, features

2017-02-02 Thread Stefan Weil
Am 02.02.2017 um 17:25 schrieb Peter Maydell: On 2 February 2017 at 13:56, Peter Maydell wrote: On 31 January 2017 at 20:18, Michael S. Tsirkin wrote: virtio, vhost, pci: fixes, features generic pci root port support disable shpc by default safer version of ARRAY_SIZE and QEMU_BUILD_BUG_ON f

Re: [Qemu-devel] [PULL 00/10] Tracing patches

2017-02-02 Thread Peter Maydell
On 1 February 2017 at 13:44, Stefan Hajnoczi wrote: > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-30 10:23:20 +) > > are available in the git repository at: > > gi

[Qemu-devel] [PULL 2/5] xen-platform: add support for unplugging NVMe disks...

2017-02-02 Thread Stefano Stabellini
From: Paul Durrant ...not just IDE and SCSI. This patch allows the Xen tool-stack to fully support of NVMe as an emulated disk type. See [1] for the relevant tool-stack patch discussion. [1] https://lists.xen.org/archives/html/xen-devel/2017-01/msg01225.html Signed-off-by: Paul Durrant Review

[Qemu-devel] [PULL 4/5] MAINTAINERS: Update xen-devel mailing list address

2017-02-02 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Acked-by: Stefano Stabellini --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a428cb2..baea7c7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -323,7 +323,7 @@ Guest CPU Cores (X

[Qemu-devel] [PULL 1/5] xen-platform: re-structure unplug_disks

2017-02-02 Thread Stefano Stabellini
From: Paul Durrant The current code is poorly structured and potentially leads to multiple config space reads when one is sufficient. Also the UNPLUG_ALL_IDE_DISKS flag is mis-named since it also results in SCSI disks being unplugged. This patch renames the flag and re-structures the code to be

[Qemu-devel] [PULL 5/5] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

2017-02-02 Thread Stefano Stabellini
From: Juergen Gross The error exits of xen_pv_find_xendev() free the new xen-device via g_free() which is wrong. As the xen-device has been initialized as qdev it must be removed via qdev_unplug(). This bug has been introduced with commit 3a6c9172ac5951e6dac2b3f6 ("xen: create qdev for each bac

[Qemu-devel] [PULL 3/5] xen-platform: add missing disk unplug option

2017-02-02 Thread Stefano Stabellini
From: Paul Durrant The Xen HVM unplug protocol [1] specifies a mechanism to allow guests to request unplug of 'aux' disks (which is stated to mean all IDE disks, except the primary master). This patch adds support for that unplug request. NOTE: The semantics of what happens if unplug of all disk

[Qemu-devel] [PULL 0/5] xen-20170202

2017-02-02 Thread Stefano Stabellini
emu-dm.git tags/xen-20170202 for you to fetch changes up to e9dcbc86d614018923e26e31319b0a54c9e5abac: xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev() (2017-02-02 10:23:53 -0800) Xen

Re: [Qemu-devel] [PATCH v2] xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev()

2017-02-02 Thread Stefano Stabellini
On Thu, 2 Feb 2017, Juergen Gross wrote: > On 01/02/17 21:20, Peter Maydell wrote: > > On 1 February 2017 at 19:37, Stefano Stabellini > > wrote: > >> Hi Peter, > >> > >> do you think this is acceptable? > > > > The set of operations here is basically what I suggested > > in review of v1, so I t

[Qemu-devel] [patch 1/2] kvm: sync linux headers

2017-02-02 Thread Marcelo Tosatti
Sync linux headers. Signed-off-by: Marcelo Tosatti --- linux-headers/asm-x86/kvm.h |5 + linux-headers/asm-x86/kvm_para.h | 13 - linux-headers/linux/kvm.h|8 ++-- linux-headers/linux/kvm_para.h |7 +++ 4 files changed, 30 insertions(+), 3 de

[Qemu-devel] [patch 2/2] kvm: introduce cpu flag to enable cpu frequency changes via hypercall

2017-02-02 Thread Marcelo Tosatti
Guests with DPDK, whose vcpus run isolated on physical CPUs, want to control the frequency of such physical CPUs. Introduce a allow-freq-hc CPU flag to enable such hypercalls. Signed-off-by: Marcelo Tosatti --- target/i386/cpu.c |1 + target/i386/cpu.h |6 ++ target/i386/

[Qemu-devel] [patch 0/2] qemu support for kvm cpu freq hypercalls

2017-02-02 Thread Marcelo Tosatti
Add a new cpu flag to allow vCPUs to perform frequency change hypercalls from userspace. See the kernel patchseries for more details.

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Laszlo Ersek
On 02/02/17 18:48, Ard Biesheuvel wrote: >>> ESR 0x0200 FAR 0x1DE7EC7EDBADC0DE >>> > > > $ git grep -C5 -ni 0x1DE7EC7EDBADC0DE > arch/arm64/kvm/sys_regs.h-105-static inline void reset_unknown(struct > kvm_vcpu *vcpu, > arch/arm64/kvm/sys_regs.h-106- const

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Ard Biesheuvel
On 2 February 2017 at 15:50, Laszlo Ersek wrote: > Adding Ard, just in case... > > I have one (half-)comment re: GICv3: > > On 02/02/17 15:44, Pekka Enberg wrote: >> Hi, >> >> Has anyone been able to successfully run QEMU/KVM under Raspberry Pi 3? >> >> I have installed 64-bit Fedora 24 by Gerd Ho

Re: [Qemu-devel] [RFC][PATCH] qemu-img: make convert async

2017-02-02 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [RFC][PATCH] qemu-img: make convert async Message-id: 1486051604-32310-1-git-send-email...@

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 05:16:25PM +, Richard W.M. Jones wrote: > Socket activation (sometimes known as systemd socket activation) > allows an Internet superserver to pass a pre-opened listening socket > to the process, instead of having qemu-nbd open a socket itself. This > is done via the LI

[Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-02 Thread Richard W.M. Jones
Socket activation (sometimes known as systemd socket activation) allows an Internet superserver to pass a pre-opened listening socket to the process, instead of having qemu-nbd open a socket itself. This is done via the LISTEN_FDS and LISTEN_PID environment variables, and a standard file descripto

[Qemu-devel] [PATCH v2] qemu-nbd: Implement socket activation.

2017-02-02 Thread Richard W.M. Jones
v2: - A few small fixed identified by Dan Berrange. The original cover letter is below. Rich. Socket activation (sometimes known as systemd socket activation) allows an Internet superserver to pass a pre-opened listening socket to the process, instead of having qemu-nbd open a socket itself.

[Qemu-devel] VirtIO issues after 83d768b5640946b7da55ce8335509df297e2c7cd

2017-02-02 Thread Brian Rak
We recently upgraded to qemu 2.8.0, and noticed a bunch of issues with various non-linux operating systems. I was able to bisect this down to 83d768b5640946b7da55ce8335509df297e2c7cd being the commit that breaks things (0687c37c5eeef8580b31cc6e1202d874833ae38a which is immediately prior still

Re: [Qemu-devel] [RFC][PATCH] qemu-img: make convert async

2017-02-02 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [RFC][PATCH] qemu-img: make convert async Message-id: 1486051604-32310-1-git-send-email...@kamp.de === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH 2/2] postcopy: Recover block devices on early failure

2017-02-02 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > An early postcopy failure can be recovered from as long as we know > we haven't sent the command to run the destination. > We have to undo the bdrv_inactivate_all by calling > bdrv_invalidate_cache_all > > Note that I'm no

Re: [Qemu-devel] [PATCH 1/2] Postcopy: Reset state to avoid cleanup assert

2017-02-02 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > On a destination host with no userfault support an incoming > postcopy would cause the state to enter ADVISE before > it realised there was no support, and because it was in ADVISE > state it would perform a cleanup at the

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Peter Maydell
On 2 February 2017 at 15:52, Ard Biesheuvel wrote: > How is this supposed to work? RPI3 does not have a GIC at all, but a > proprietary interrupt controller that is not supported by KVM The idea is that (with the relevant not-yet-in-master patchsets) you can fall back to "use a userspace interrup

Re: [Qemu-devel] [PULL v5 00/22] virtio, vhost, pci: fixes, features

2017-02-02 Thread Peter Maydell
On 2 February 2017 at 13:56, Peter Maydell wrote: > On 31 January 2017 at 20:18, Michael S. Tsirkin wrote: >> virtio, vhost, pci: fixes, features >> >> generic pci root port support >> disable shpc by default >> safer version of ARRAY_SIZE and QEMU_BUILD_BUG_ON >> fixes and cleanups all over the

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

2017-02-02 Thread Michael S. Tsirkin
On Tue, Jan 31, 2017 at 04:04:58PM +, Phil Dennis-Jordan wrote: > > On Tue, 31 Jan 2017 at 16:41, Igor Mammedov wrote: > > On Tue, 31 Jan 2017 16:58:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 31, 2017 at 03:31:46PM +0100, Phil Dennis-Jordan wrote: > > > On 18

Re: [Qemu-devel] [PULL 0/3] s390x fixes

2017-02-02 Thread Peter Maydell
On 1 February 2017 at 09:04, Christian Borntraeger wrote: > Peter, > > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-30 10:23:20 +) > > are available in the git reposi

[Qemu-devel] [RFC][PATCH] qemu-img: make convert async

2017-02-02 Thread Peter Lieven
this is something I have been thinking about for almost 2 years now. we heavily have the following two use cases when using qemu-img convert. a) reading from NFS and writing to iSCSI for deploying templates b) reading from iSCSI and writing to NFS for backups In both processes we use libiscsi and

Re: [Qemu-devel] [PULL 0/1] Block patches

2017-02-02 Thread Peter Maydell
On 1 February 2017 at 13:24, Stefan Hajnoczi wrote: > The following changes since commit a0def594286d9110a6035e02eef558cf3cf5d847: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-01-30 10:23:20 +) > > are available in the git repository at: > > gi

Re: [Qemu-devel] [qcow2] how to avoid qemu doing lseek(SEEK_DATA/SEEK_HOLE)?

2017-02-02 Thread Stephane Chazelas
2017-02-02 16:23:53 +0100, Laszlo Ersek: [...] > You didn't mention what qcow2 features you use -- vmstate, snapshots, > backing files (chains of them), compression? > > Since commit 2928abce6d1d only modifies "block/qcow2.c", you could > switch / convert the images to "raw". "raw" still benefits

Re: [Qemu-devel] [PATCH v2 1/1] qemu-char: socket backend: disconnect on write error

2017-02-02 Thread Denis V. Lunev
On 02/02/2017 04:18 PM, Denis V. Lunev wrote: > From: Anton Nefedov > > Socket backend read handler should normally perform a disconnect, however > the read handler may not get a chance to run if the frontend is not ready > (qemu_chr_be_can_write() == 0). > > This means that in virtio-serial front

[Qemu-devel] [PATCH 2/2] postcopy: Recover block devices on early failure

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" An early postcopy failure can be recovered from as long as we know we haven't sent the command to run the destination. We have to undo the bdrv_inactivate_all by calling bdrv_invalidate_cache_all Note that I'm not using ms->block_inactive because once we've sent th

[Qemu-devel] [PATCH 0/2] Postcopy fixes

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, These are a couple of postcopy fixes for failure paths; The first is a pretty harmless assert, it happens on the destination when it discovers that it's got an incoming postcopy but it can't support it - it was going to exit anyway. The second is more useful

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > +++ b/docs/q35-emulated.cfg > >  > > +#   00:01.0 VGA compatible controller > >  > > +[device "video"] > > +  driver = "VGA" > > +  bus = "pcie.0" > > +  addr = "02.0" >  > Here is a address mismatch ;) >  > Otherwise looks all fine to me.

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Ard Biesheuvel
On 2 February 2017 at 15:50, Laszlo Ersek wrote: > Adding Ard, just in case... > > I have one (half-)comment re: GICv3: > How is this supposed to work? RPI3 does not have a GIC at all, but a proprietary interrupt controller that is not supported by KVM > On 02/02/17 15:44, Pekka Enberg wrote: >

[Qemu-devel] [PATCH 1/2] Postcopy: Reset state to avoid cleanup assert

2017-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" On a destination host with no userfault support an incoming postcopy would cause the state to enter ADVISE before it realised there was no support, and because it was in ADVISE state it would perform a cleanup at the end. Since there was no support the cleanup func

Re: [Qemu-devel] KVM/QEMU on Raspberry Pi 3

2017-02-02 Thread Laszlo Ersek
Adding Ard, just in case... I have one (half-)comment re: GICv3: On 02/02/17 15:44, Pekka Enberg wrote: > Hi, > > Has anyone been able to successfully run QEMU/KVM under Raspberry Pi 3? > > I have installed 64-bit Fedora 24 by Gerd Hoffmann on the hardware: > > https://www.kraxel.org/blog/20

[Qemu-devel] [PULL 0/4] cirrus: multiple bugfixes, including CVE-2017-2615 fix.

2017-02-02 Thread Gerd Hoffmann
nzini/tags/for-upstream' into staging (2017-01-30 10:23:20 +) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20170202-2 for you to fetch changes up to 62d4c6bd5263bb8413a06c80144fc678df6dfb64: cirrus: fix oob access issue (CVE-2017-2615) (2017-02-0

Re: [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running

2017-02-02 Thread Mark Cave-Ayland
On 02/02/17 14:20, Laurent Vivier wrote: > I think adding the the PPCTimebase field and the VMSTATE_PPC_TIMEBASE_V > macro to the PMac machines should fix your issue. > > Do you have a test case I can try? > > Laurent Hi Laurent, Yes I'd say that is required, although I still think you need to

Re: [Qemu-devel] [PATCH v3] q35: Improve sample configuration files

2017-02-02 Thread Andrea Bolognani
On Thu, 2017-02-02 at 15:55 +0100, Gerd Hoffmann wrote: > > +++ b/docs/q35-emulated.cfg > >  > > +#   00:01.0 VGA compatible controller > >  > > +[device "video"] > > +  driver = "VGA" > > +  bus = "pcie.0" > > +  addr = "02.0" >  > Here is a address mismatch ;) Oh, wait, I realize where the misma

[Qemu-devel] [PATCH 3/3] spapr: make cpu core unplug follow expected hotunplug call flow

2017-02-02 Thread Igor Mammedov
spapr_core_unplug() were essentially spapr_core_unplug_request() handler that requested CPU removal and registered callback which did actual cpu core removali but it was called from spapr_machine_device_unplug() which is intended for actual object removal. Commit (cf632463 spapr: Memory hot-unplug

  1   2   3   >