Re: [Qemu-devel] [PATCH 1/2] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

On 02/15/2017 02:59 AM, David Gibson wrote: > I don't think I'll want to merge until the full picture is addressed. > However, I'm fine with posting incomplete versions for earlier review > - just label them RFC and note in the 0/N comment that there's more > work to be done to complete the picture

[Qemu-devel] [RFC] virtio-fc: draft idea of virtual fibre channel HBA

Hi all, We know that libvirt can create fibre channels vHBA on host based on npiv, and present the LUNs to guest. I'd like to implement a virtual fibre channel HBA for qemu, I havn't investigate it deeply yet. The idea presents a fc vHBA in guest, interact with remote fc switch through npiv, Th

[Qemu-devel] [PATCH] target-ppc: Add quad precision muladd instructions

xsmaddqp: VSX Scalar Multiply-Add Quad-Precision xsmaddqpo: VSX Scalar Multiply-Add Quad-Precision using round to Odd xsnmaddqp: VSX Scalar Negative Multiply-Add Quad-Precision xsnmaddqpo: VSX Scalar Negative Multiply-Add Quad-Precision using round to Odd xsmsubqp: VSX Scalar Multiply-Subtra

Re: [Qemu-devel] [PATCH] usb: ohci: limit the number of link eds

Hello Gerd, Ping... 2017-02-07 18:23 GMT+08:00 Li Qiang : > From: Li Qiang > > The guest may builds an infinite loop with link eds. This patch > limit the number of linked ed to avoid this. > > Signed-off-by: Li Qiang > --- > hw/usb/hcd-ohci.c | 9 - > 1 file changed, 8 insertions(+),

[Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

From: Ben Warren Also usable by upcoming VM Generation ID tests Signed-off-by: Ben Warren --- tests/acpi-utils.h | 75 tests/bios-tables-test.c | 72 +- 2 files changed, 76 insertions(+), 71 dele

Re: [Qemu-devel] [PATCH] usb: ehci: fix memory leak in ehci

Ping... 2017-02-08 10:42 GMT+08:00 Li Qiang : > From: Li Qiang > > In usb_ehci_init function, it initializes 's->ipacket', but there > is no corresponding function to free this. As the ehci can be hotplug > and unplug, this will leak host memory leak. In order to make the > hierarchy clean, we s

Re: [Qemu-devel] [PATCH] usb: ohci: fix error return code in servicing iso td

Ping... 2017-02-07 19:15 GMT+08:00 Li Qiang : > From: Li Qiang > > It should return 1 if an error occurs when reading iso td. > This will avoid an infinite loop issue in ohci_service_ed_list. > > Signed-off-by: Li Qiang > --- > hw/usb/hcd-ohci.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

[Qemu-devel] [PATCH v6 0/7] Add support for VM Generation ID

From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This patch set has dependencies on new guest functionality, in particular the

[Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

From: Ben Warren This is similar to the existing 'add pointer' functionality, but instead of instructing the guest (BIOS or UEFI) to patch memory, it instructs the guest to write the pointer back to QEMU via a writeable fw_cfg file. Signed-off-by: Ben Warren --- hw/acpi/bios-linker-loader.c

[Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. Any time the GUID changes, an ACPI notify event is sent to the guest The user interface is a simple device with one parameter: - guid (string, must be "auto" or in UUID format

[Qemu-devel] [PATCH v6 7/7] tests: Add unit tests for the VM Generation ID feature

From: Ben Warren The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. * test that changing the GUID at runtime via the monitor is reflected in the guest. * test that the "auto" argument to the GUID generates a different, and correct GUI

[Qemu-devel] [PATCH v6 3/7] ACPI: Add vmgenid blob storage to the build tables

From: Ben Warren This allows them to be centrally initialized and destroyed The "AcpiBuildTables.vmgenid" array will be used to construct the "etc/vmgenid" fw_cfg blob. Its contents will be linked into fw_cfg after being built on the pc_machine_done() -> acpi_setup() -> acpi_build() call path,

[Qemu-devel] [PATCH v6 5/7] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Ben Warren --- hmp-commands-i

[Qemu-devel] [PATCH v6 2/7] docs: VM Generation ID device description

From: Ben Warren This patch is based off an earlier version by Gal Hammer (gham...@redhat.com) Requirements section, ASCII diagrams and overall help provided by Laszlo Ersek (ler...@redhat.com) Signed-off-by: Gal Hammer Signed-off-by: Ben Warren Reviewed-by: Laszlo Ersek --- docs/specs/vmge

Re: [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

Hello Alistair, +-- On Tue, 14 Feb 2017, Alistair Francis wrote --+ | On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: | > From: Prasad J Pandit | > | > In the SDHCI protocol, the transfer mode register value | > is used during multi block transfer to check if block count | > register is enabled

[Qemu-devel] [Bug 1068900] Re: Thread cancellation broken in app-level emulation

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1068900 Title: Thread canc

[Qemu-devel] [Bug 906221] Re: USBDEVFS_CLEAR_HALT stall with USB-CDROM qemu-1.0

[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/906221 Title: USBDEVFS_CLE

[Qemu-devel] [PULL 4/5] net: imx: limit buffer descriptor count

From: Prasad J Pandit i.MX Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in bd.flags. Set an upper lim

[Qemu-devel] [PULL 3/5] colo-compare: sort TCP packet queue by sequence number

From: Zhang Chen Improve efficiency of TCP packet comparison. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Jason Wang --- net/colo-compare.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index 4962976..1

[Qemu-devel] [PULL 2/5] net: e1000e: fix dead code in e1000e_write_packet_to_guest

From: Paolo Bonzini Because is_first is declared inside a loop, it is always true. The store is dead, and so is the "else" branch of "if (is_first)". is_last is okay though. Reported by Coverity. Signed-off-by: Paolo Bonzini Reviewed-by: Dmitry Fleytman Signed-off-by: Jason Wang --- hw/ne

[Qemu-devel] [PULL 0/5] Net patches

The following changes since commit 5dae13cd71f0755a1395b5a4cde635b8a6ee3f58: Merge remote-tracking branch 'remotes/rth/tags/pull-or-20170214' into staging (2017-02-14 09:55:48 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-reques

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 14, 2017 at 07:02:32PM -0800, ashish mittal wrote: > On Tue, Feb 14, 2017 at 2:34 PM, ashish mittal wrote: > > On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: > >> On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > >>> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote

[Qemu-devel] [PULL 1/5] net: Mark 'vlan' parameter as deprecated

From: Thomas Huth The 'vlan' parameter is a continuous source of confusion for the users, many people mix it up with the more common term VLAN (the link layer packet encapsulation), and even if they realize that the QEMU 'vlan' is rather some kind of network hub emulation, there is still a high r

[Qemu-devel] [PULL 5/5] net: e1000e: fix an infinite loop issue

From: Li Qiang This issue is like the issue in e1000 network card addressed in this commit: e1000: eliminate infinite loops on out-of-bounds transfer start. Signed-off-by: Li Qiang Reviewed-by: Dmitry Fleytman Signed-off-by: Jason Wang --- hw/net/e1000e_core.c | 7 ++- 1 file changed, 6

Re: [Qemu-devel] [PATCH] ppc/xics: fix XICSStateClass parent class

On Tue, Feb 14, 2017 at 07:25:07AM +0100, Cédric Le Goater wrote: > On 02/14/2017 02:58 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 10:33:24AM +0100, Cédric Le Goater wrote: > >> XICSState inherits from SysBusDevice and so the object class should > >> inherit from SysBusDeviceClass. > >> >

Re: [Qemu-devel] iommu emulation

On Wed, Feb 15, 2017 at 10:52:43AM +0800, Peter Xu wrote: [...] > > > > > > Then, I *think* above assertion you encountered would fail only if > > > prev == 0 here, but I still don't quite sure why was that happening. > > > Btw, could you paste me your "lspci -vvv -s 00:03.0" result in your L1 >

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

Hi Philippe, I rebased on the latest master, but the only difference between that patch and the emailed patch was the commit hash. I’m using master at git://git.qemu.org/qemu.git (latest commit 5dae13c). It seems to cleanly apply on my end… is there a different repo I should be working against,

Re: [Qemu-devel] [PATCH v3] Makefile: avoid leaving the temporary QEMU_PKGVERSION header file

On Wed, 02/15 10:40, Lin Ma wrote: > By commit 67a1de0d, When we perform 'git pull && make && sudo make install', > In 'make' stage a qemu-version.h.tmp will be generated. If the content of > qemu-version.h.tmp and qemu-version.h aren't consistent, The > qemu-version.h.tmp > will be renamed to qem

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

On 2017年02月14日 15:33, Hailiang Zhang wrote: On 2017/2/14 12:08, Jason Wang wrote: On 2017年02月14日 10:32, Hailiang Zhang wrote: Hi Jason, I think the better way is notify the comparing thread and let it do the releasing. You probably need similar mechanism to notify from comparing th

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 14, 2017 at 2:34 PM, ashish mittal wrote: > On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: >> On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >>> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >>> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote:

Re: [Qemu-devel] [PATCH] osdep.h: pull in sys/sysmacros.h for major/minor/makedev

On 10 Feb 2017 09:04, Peter Maydell wrote: > I still think that it's a shame that glibc is breaking > compatibility with where these macros have always been > kept on every OS that's implemented them back to 2BSD... i don't think that characterization is accurate. if it were, autoconf wouldn't ha

Re: [Qemu-devel] iommu emulation

On Tue, Feb 14, 2017 at 07:50:39AM -0500, Jintack Lim wrote: [...] > > > >> > I misunderstood what you said? > > > > > > > > I failed to understand why an vIOMMU could help boost performance. :( > > > > Could you provide your command line here so that I can try to > > > > reproduce? > > > > > > S

[Qemu-devel] [PATCH v3] Makefile: avoid leaving the temporary QEMU_PKGVERSION header file

By commit 67a1de0d, When we perform 'git pull && make && sudo make install', In 'make' stage a qemu-version.h.tmp will be generated. If the content of qemu-version.h.tmp and qemu-version.h aren't consistent, The qemu-version.h.tmp will be renamed to qemu-version.h. Because of the target FORCE, The

Re: [Qemu-devel] [PATCH 1/2] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

On Tue, Feb 14, 2017 at 03:52:09PM +0100, Cédric Le Goater wrote: > On 02/14/2017 08:04 AM, Cédric Le Goater wrote: > > On 02/14/2017 06:02 AM, David Gibson wrote: > >> On Mon, Feb 13, 2017 at 03:09:16PM +0100, Cédric Le Goater wrote: > >>> Today, the ICS (Interrupt Controller Source) object is cre

Re: [Qemu-devel] [PATCH 1/2] ppc/xics: remove set_nr_irqs() handler from XICSStateClass

On Tue, Feb 14, 2017 at 08:04:42AM +0100, Cédric Le Goater wrote: > On 02/14/2017 06:02 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 03:09:16PM +0100, Cédric Le Goater wrote: > >> Today, the ICS (Interrupt Controller Source) object is created and > >> realized by the init and realize routine

Re: [Qemu-devel] [RFC] virtio-pci: Allow PCIe virtio devices on root bus

On Tue, Feb 14, 2017 at 02:53:08PM +0200, Marcel Apfelbaum wrote: > On 02/14/2017 06:15 AM, David Gibson wrote: > > On Mon, Feb 13, 2017 at 12:14:23PM +0200, Marcel Apfelbaum wrote: > > > On 02/13/2017 06:33 AM, David Gibson wrote: > > > > On Sun, Feb 12, 2017 at 09:05:46PM +0200, Marcel Apfelbaum

Re: [Qemu-devel] [PATCH v3 3/3] .shippable.yml: new CI provider

On Tue, 02/14 15:56, Alex Bennée wrote: > > May I propose we merge 'docker testing' section of MAINTAINERS into 'build > > and > > test automation' section? I don't know as much about travis (and shippable) > > but > > I'm totally fine if you want to have docker tests under your umbrella, and > >

Re: [Qemu-devel] [PATCH 25/25] qcow2-bitmap: improve check_constraints_on_bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Add detailed error messages. > yay > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 63 > ++-- > 1 file changed, 41 insertions(+), 22 deletions(-) > > d

Re: [Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Remove persistent bitmap from the storage on block-dirty-bitmap-remove. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > blockdev.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [Qemu-devel] [PATCH 23/25] qcow2: add .bdrv_remove_persistent_dirty_bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_remove_persistent_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-bitmap.c | 41 + > block/qcow2.c|

Re: [Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Interface for removing persistent bitmap from its storage. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/dirty-bitmap.c | 18 ++ > include/block/block_int.h| 3 +

Re: [Qemu-devel] [PATCH 1/2] ide: core: add cleanup function

On 02/09/2017 08:22 PM, Li Qiang wrote: > Hello John, > > 2017-02-10 3:42 GMT+08:00 John Snow >: > > > > On 02/09/2017 02:04 AM, Li Qiang wrote: > > As the pci ahci can be hotplug and unplug, in the ahci unrealize > > function it should free all the resou

Re: [Qemu-devel] [PATCH] vmstate-static-checker: update white list with spapr_pci

On Tue, Feb 14, 2017 at 02:33:31PM +0100, Laurent Vivier wrote: > To fix migration between 2.7 and 2.8, some fields have > been renamed and managed with the help of a PHB property > (pre_2_8_migration): > > 5c4537b spapr: Fix 2.7<->2.8 migration of PCI host bridge > > So we need to add them t

Re: [Qemu-devel] [PATCH v2 1/3] migration: add MigrationState arg for ram_save_/compressed_/page()

On 02/03/2017 12:23 PM, Pavel Butsykin wrote: Cosmetic patch. The use of ms variable instead of migrate_get_current() looks nicer, especially when there reuse. Signed-off-by: Pavel Butsykin Reviewed-by: Philippe Mathieu-Daudé --- migration/ram.c | 15 --- 1 file changed, 8 ins

Re: [Qemu-devel] [PATCH 21/25] qcow2-bitmap: refcounts

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Calculate refcounts for qcow2 bitmaps. It is needed for qcow2's qemu-img > check implementation. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-bitmap.c | 76 > ++

Re: [Qemu-devel] [PATCH] Add PowerPC 32-bit guest memory dump support

Hi Mike, I failed to apply your patch on master: error: patch failed: target/ppc/Makefile.objs:1 error: target/ppc/Makefile.objs: patch does not apply error: patch failed: target/ppc/arch_dump.c:1 error: target/ppc/arch_dump.c: patch does not apply error: patch failed: target/ppc/cpu.h:1225 erro

Re: [Qemu-devel] [PATCH 13/24] tests/test-cutils: Cover qemu_strtosz() around range limits

On 02/14/2017 04:26 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 61 > +++-- > 1 file changed, 59 insertions(+), 2 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-

Re: [Qemu-devel] [PATCH RFC v2 0/2] block: Crude initial implementation of -blockdev

Markus Armbruster writes: > This is based on "[PATCH 00/24] QemuOpts util/cutils: Fix and clean up > number conversions". > > v2: Support KEY=VALUE,... syntax as well. Forgot to mention: the thing collapses when KEY has a type other than string. There's one reason this is marked RFC...

Re: [Qemu-devel] [PATCH 20/25] qcow2-refcount: rename inc_refcounts() and make it public

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > This is needed for the following patch, which will introduce refcounts > checking for qcow2 bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-refcount.c | 53 > ++

Re: [Qemu-devel] [PATCH 19/25] iotests: test qcow2 persistent dirty bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/165 | 89 > ++ > tests/qemu-iotests/165.out | 5 +++ > tests/qemu-iotests/group | 1

Re: [Qemu-devel] [PATCH 12/24] tests/test-cutils: Cover qemu_strtosz() with trailing crap

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 19 +++ > 1 file changed, 19 insertions(+) > Reviewed-by: Eric Blake > diff --git a/tests/test-cutils.c b/tests/test-cutils.c > index 3dcd4c1..ec65d27 100644 > ---

[Qemu-devel] [PATCH v3] register: fix incorrect read mask

The register_read() and register_write() functions expect a bitmask argument. To avoid duplicated code, a new inlined function register_enabled_mask() is introduced. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- v3: clarify functions affected in the commit message. v

Re: [Qemu-devel] [PATCH 11/24] tests/test-cutils: Cover qemu_strtosz() invalid input

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 24 > 1 file changed, 24 insertions(+) > Perhaps you could also add a test of "-". Either way, Reviewed-by: Eric Blake -- Eric Blake eblake redhat co

Re: [Qemu-devel] [PATCH 18/25] qmp: add x-debug-block-dirty-bitmap-sha256

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/dirty-bitmap.c | 5 + > blockdev.c | 29 + > include/block/dirty-bitmap.h | 2 ++ > inclu

Re: [Qemu-devel] [PATCH 17/25] qmp: add autoload parameter to block-dirty-bitmap-add

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Optional. Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > Reviewed-by: Max Reitz > --- > blockdev.c | 18 -- > qapi/block-core.json | 6 +- > 2 fil

Re: [Qemu-devel] [PATCH 16/25] qmp: add persistent flag to block-dirty-bitmap-add

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > Reviewed-by: Max Reitz > --- > blockdev.c | 18 +

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish Mittal >> >> >> >> Source code for the q

Re: [Qemu-devel] [PATCH 10/24] tests/test-cutils: Add missing qemu_strtosz()... endptr checks

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 37 ++--- > 1 file changed, 26 insertions(+), 11 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvi

Re: [Qemu-devel] regarding bug name : -hda FAT:. limited to 504MBytes

Hi, On 14.02.2017 22:38, Shubham Kumar wrote: > Since the problem seems like the used FAT-16 file system , > Will it solve the problem if I change the code of vvfat.c for FAT-32 file > system to increase acceptable file size ? As far as I know, FAT16 can already support up to 4GB file systems

Re: [Qemu-devel] [PATCH 15/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_can_store_new_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-bitmap.c | 40 > block/qcow2.c| 1 +

[Qemu-devel] [RFC] Pointers for implementing AArch64 PMU instruction counter?

I am interested in implementing an instruction counter to augment the ongoing (mostly cycle-counter) PMU work on AArch64. The icount infrastructure seems like the logical source for the instruction counts, but I have a couple of implementation-related questions: 1. It looks like cpu_get_icount_raw

Re: [Qemu-devel] [PATCH 09/24] QemuOpts: Fix to reject numbers that overflow uint64_t

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > parse_option_number() fails to check for overflow after strtoull(). > Has always been broken. Fix that. > > Signed-off-by: Markus Armbruster > --- > tests/test-qemu-opts.c | 14 ++ > util/qemu-option.c | 11 --- > 2 file

Re: [Qemu-devel] [PATCH v14 00/24] qcow2: persistent dirty bitmaps

On 02/14/2017 01:02 PM, John Snow wrote: > > > On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> > > Hi! :) > >> There is a new update of qcow2-bitmap series - v14. >> > > Having the cover letter be 00/24 but including 25 patches confuses the > patch scraping tool a goo

Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Reorder check_strtox_error() to make it obvious that we always store > through a non-null @endptr. > > Transform > > if (some error) { > error case ... > err = value for error case; > } else { > normal case ... >

[Qemu-devel] regarding bug name : -hda FAT:. limited to 504MBytes

Since the problem seems like the used FAT-16 file system , Will it solve the problem if I change the code of vvfat.c for FAT-32 file system to increase acceptable file size ? Regards Shubham Kumar

Re: [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol()

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Name same things the same, different things differently. > > * qemu_strtol()'s parameter @nptr is called @p in > check_strtox_error(). Rename the latter. > > * qemu_strtol()'s parameter @endptr is called @next in > check_strtox_error(). Ren

Re: [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull()

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > The name qemu_strtoll() suggests conversion to long long, but it > actually converts to int64_t. Rename to qemu_strtoi64(). > > The name qemu_strtoull() suggests conversion to unsigned long long, > but it actually converts to uint64_t. Rename to

Re: [Qemu-devel] [PATCH 05/24] util/cutils: Rewrite documentation of qemu_strtol() & friends

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Fixes the following documentation bugs: > > * Fails to document that null @nptr is safe. > > * Fails to document that we return -EINVAL when no conversion could be > performed (commit 47d4be1). > > * Confuses long long with int64_t, and unsign

Re: [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Use unsigned comparisons to check the result of qemu_strtoul() and > strtoull(). > > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 60 > ++--- > 1 file changed, 30 insertions(+),

Re: [Qemu-devel] [PATCH 14/25] block: add bdrv_can_store_new_dirty_bitmap

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > This will be needed to check some restrictions before making bitmap > persistent in qmp-block-dirty-bitmap-add (this functionality will be > added by future patch) > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Re

Re: [Qemu-devel] [RFC PATCH V3] qemu-img: make convert async

Am 14.02.2017 um 21:43 hat Peter Lieven geschrieben: > Von: Kevin Wolf > An: Peter Lieven > Kopie: , , , > > Gesendet: 14.02.2017 17:20 > Betreff: Re: [RFC PATCH V3] qemu-img: make convert async > > > Am 14.02.2017 um 14:39 hat Peter Lieven geschrieben: > > this is something I have bee

Re: [Qemu-devel] [RFC PATCH V3] qemu-img: make convert async

[meta-comment] On 02/14/2017 02:43 PM, Peter Lieven wrote: > > > > > Von: Kevin Wolf > An: Peter Lieven > Kopie: , , > , > Gesendet: 14.02.2017 17:20 > Betreff: Re: [RFC PATCH V3] qemu-img: make convert async > > Am 14.02.2017 um 14:39 hat Peter Lieven geschrieben: >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >> From: Ashish Mittal > >> > >> Source code for the qnio library that this code loads can be downloaded > >> fr

Re: [Qemu-devel] [RFC PATCH V3] qemu-img: make convert async

Von: Kevin Wolf An: Peter Lieven Kopie: , , , Gesendet: 14.02.2017 17:20 Betreff: Re: [RFC PATCH V3] qemu-img: make convert async Am 14.02.2017 um 14:39 hat Peter Lieven geschrieben: > this is something I have been thinking about for almost 2 years now. > we heavily h

Re: [Qemu-devel] [PATCH 03/24] tests/test-cutils: Add missing qemu_strtol()... endptr checks

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/test-cutils.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/tests/test-cutils.c b/tests/test-cutils.c > index 20b0f59..71681dc 100644 > --- a/tests/test-cutils.c > +++ b/tes

Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Plenty of code relies on QemuOpt member @str not being null, including > qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to > qemu_opt_foreach(). > > > Assert member @str isn't null, so that misuse is caught right away. > > Simpli

Re: [Qemu-devel] [PATCH 01/24] tests/test-qemu-opts: Cover qemu_opts_parse()

On 02/14/2017 04:25 AM, Markus Armbruster wrote: > The new tests demonstrate a few bugs, all clearly marked. > > Signed-off-by: Markus Armbruster > --- > tests/test-qemu-opts.c | 294 > - > 1 file changed, 292 insertions(+), 2 deletions(-) > > +

[Qemu-devel] [Bug 760956] Re: Open Solaris 2009 Doesn't Boot

The URLs don't work any more, and according to Stefan's comment, this was likely not a bug, so I'm closing this ticket now (feel free to open it again if you don't agree). ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] [Qemu-block] [PATCH] backup: allow target without .bdrv_get_info

On 02/14/2017 09:05 AM, Fam Zheng wrote: >> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this >> problem. >> But until it is not realized, we need allow backup to nbd target due to >> backward >> compatibility. >> >> Furthermore, is it entirely ok to disallow backup if bds

Re: [Qemu-devel] [PATCH v2 00/16] Postcopy: Hugepage support

* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Hi David, > > Thank your, now it's clear. > > On Mon, Feb 13, 2017 at 06:16:02PM +, Dr. David Alan Gilbert wrote: > > * Alexey Perevalov (a.pereva...@samsung.com) wrote: > > > Hello David! > > > > Hi Alexey, > > > > > I have checked you

[Qemu-devel] [PATCH v5 6/7] blkdebug: Add ability to override unmap geometries

Make it easier to simulate various unusual hardware setups (for example, recent commits 3482b9b and b8d0a98 affect the Dell Equallogic iSCSI with its 15M preferred and maximum unmap and write zero sizing, or b2f95fe deals with the Linux loopback block device having a max_transfer of 64k), by allowi

[Qemu-devel] [PATCH v5 5/7] blkdebug: Simplify override logic

Rather than store into a local variable, then copy to the struct if the value is valid, then reporting errors otherwise, it is simpler to just store into the struct and report errors if the value is invalid. This however requires that the struct store a 64-bit number, rather than a narrower type.

[Qemu-devel] [PATCH v5 7/7] tests: Add coverage for recent block geometry fixes

Use blkdebug's new geometry constraints to emulate setups that have caused recent regression fixes: write zeroes asserting when running through a loopback block device with max-transfer smaller than cluster size, and discard rounding away portions of requests not aligned to preferred boundaries. A

[Qemu-devel] [PATCH v5 4/7] blkdebug: Add pass-through write_zero and discard support

In order to test the effects of artificial geometry constraints on operations like write zero or discard, we first need blkdebug to manage these actions. It also allows us to inject errors on those operations, just like we can for read/write/flush. We can also test the contract promised by the bl

[Qemu-devel] [PATCH v5 2/7] qcow2: Discard/zero clusters by byte count

Passing a byte offset, but sector count, when we ultimately want to operate on cluster granularity, is madness. Clean up the external interfaces to take both offset and count as bytes, while still keeping the assertion added previously that the caller must align the values to a cluster. Then rena

[Qemu-devel] [PATCH v5 3/7] blkdebug: Sanity check block layer guarantees

Commits 04ed95f4 and 1a62d0ac updated the block layer to auto-fragment any I/O to fit within device boundaries. Additionally, when using a minimum alignment of 4k, we want to ensure the block layer does proper read-modify-write rather than requesting I/O on a slice of a sector. Let's enforce that t

[Qemu-devel] [PATCH v5 1/7] qcow2: Assert that cluster operations are aligned

qcow2_discard_clusters() is set up to silently ignore sub-cluster head or tail on unaligned requests. However, it is easy to audit the various callers: qcow2_snapshot_create() has always passed aligned data since the call was introduced in 1ebf561; qcow2_co_pdiscard() has passed aligned clusters s

[Qemu-devel] [PATCH v5 0/7] add blkdebug tests

Available as a tag at: git fetch git://repo.or.cz/qemu/ericb.git nbd-blkdebug-v5 v4 was: https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg02834.html Since then: - Rebase to master - Address comments from Max 001/7:[] [--] 'qcow2: Assert that cluster operations are aligned' 002/7:[003

Re: [Qemu-devel] [PATCH 13/25] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: > From: Prasad J Pandit > > In the SDHCI protocol, the transfer mode register value > is used during multi block transfer to check if block count > register is enabled and should be updated. Transfer mode > register could be set such that, block coun

Re: [Qemu-devel] [PATCH v4 1/4] sd: sdhci: mask transfer mode register value

On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: > From: Prasad J Pandit > > In SDHCI protocol, the transfer mode register is defined > to be of 6 bits. Mask its value with '0x0037' so that an > invalid value could not be assigned. > > Signed-off-by: Prasad J Pandit Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH 0/2] qemu-iotest tweaks

Am 14.02.2017 um 17:21 hat Jeff Cody geschrieben: > Some minor qemu-iotest tweaks. > > The second patch makes it easier to add some upcoming protocols such as VXHS, > that do not support .bdrv_create. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v14 00/24] qcow2: persistent dirty bitmaps

On 02/14/2017 11:59 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > Hi! :) > There is a new update of qcow2-bitmap series - v14. > Having the cover letter be 00/24 but including 25 patches confuses the patch scraping tool a good deal. Also, can you include the "v14" in the patch emails t

[Qemu-devel] [Bug 764252] Re: wishlist: kirkwood support

My offer from comment #3 to review code if anybody wants to submit it still stands, but given the amount of work required to implement a model of a new SoC in QEMU I'm not surprised nobody's ever taken me up on it. -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [PATCH v4 4/4] sd: sdhci: Remove block count enable check in single block transfers

From: Prasad J Pandit In SDHCI protocol, the 'Block count enable' bit of the Transfer Mode register is relevant only in multi block transfers. We need not check it in single block transfers. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 6 +- 1 file changed, 1 insertion(+), 5 deletion

[Qemu-devel] [PATCH v4 3/4] sd: sdhci: conditionally invoke multi block transfer

From: Prasad J Pandit In sdhci_write invoke multi block transfer if it is enabled in the transfer mode register 's->trnmod'. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index f8220c0..8a

[Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer

From: Prasad J Pandit In the SDHCI protocol, the transfer mode register value is used during multi block transfer to check if block count register is enabled and should be updated. Transfer mode register could be set such that, block count register would not be updated, thus leading to an infinit

[Qemu-devel] [PATCH v4 0/4] sd: sdhci: correct transfer mode register usage

From: Prasad J Pandit Hello, In SDHCI protocol, the 'Block Count Enable' bit of the Transfer Mode register is used to control 's->blkcnt' value. This bit is not relevant in single block transfers. Also, Transfer Mode register value could be set such that 's->blkcnt' would not see an update durin

[Qemu-devel] [PATCH v4 1/4] sd: sdhci: mask transfer mode register value

From: Prasad J Pandit In SDHCI protocol, the transfer mode register is defined to be of 6 bits. Mask its value with '0x0037' so that an invalid value could not be assigned. Signed-off-by: Prasad J Pandit --- hw/sd/sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Update per: use

[Qemu-devel] [Bug 764252] Re: wishlist: kirkwood support

For the record, I still regularly use a Kirkwood device (a QNAP NAS). Being able to compile software for it in qemu would be handy once in a while, though it's not a high priority for me. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU

  1   2   3   >