Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-28 Thread Hailiang Zhang
On 2017/7/29 1:17, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: COLOMode is defined in the QAPI schema, but not used there. Of the stuff QAPI generates for it only the typedef is actually used. Use of QAPI is pointless and only complicates things, so don't. Hmm

Re: [Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-28 Thread Liu, Changpeng
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, July 28, 2017 6:36 PM > To: Liu, Changpeng > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; fel...@nutanix.com; > m...@redhat.com > Subject: Re: [PATCH 1/2] vhost-user-blk: introduce a new vhost-us

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-28 Thread Kevin O'Connor
On Fri, Jul 28, 2017 at 04:20:10PM +0200, Laszlo Ersek wrote: > On 07/27/17 22:40, Kevin O'Connor wrote: > > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > >> The tables that QEMU provides are not ACPI 1.0 compatible since commit > >> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0)

[Qemu-devel] 'make help' generate unrelated files

2017-07-28 Thread Philippe Mathieu-Daudé
Is it necessary to generate this files to run 'make help'? $ ./configure [...] $ make help CHK version_gen.h UPD version_gen.h DEP util.c CHK version_gen.h GEN qmp-commands.h GEN qapi-types.h GEN qapi-visit.h GEN qapi-event.h GEN qmp-

Re: [Qemu-devel] [PATCH 16/47] MAINTAINERS: add missing entry for gdb

2017-07-28 Thread Philippe Mathieu-Daudé
On 07/28/2017 09:00 AM, Paolo Bonzini wrote: On 28/07/2017 07:35, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9670a3901a..653c2a1db1 100644 --- a/MAINTAINERS +++ b/MAIN

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

2017-07-28 Thread Philippe Mathieu-Daudé
On 07/28/2017 08:56 PM, Alistair Francis wrote: On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC because I'm not sure m25p80 fits. MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts

2017-07-28 Thread Philippe Mathieu-Daudé
On 07/28/2017 08:50 AM, Paolo Bonzini wrote: On 28/07/2017 08:24, Fam Zheng wrote: On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 224890643d..7854792765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1537,6 +1537,12 @@ Checkpatch S: Odd Fixes

[Qemu-devel] tb_invalidate_phys_range and tb_invalidate_phys_page_range

2017-07-28 Thread Emilio G. Cota
While working on the removal of tb_lock, I stumbled upon the following. Commit 77a8f1a51 ("linux-user: Fix stale tbs after mmap") introduced tb_invalidate_phys_range(), which we now have in accel/tcg/translate-all.c [ patchwork thread here: https://patchwork.ozlabs.org/patch/158556/ ] This functi

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-07-28 Thread Philippe Mathieu-Daudé
Hi Alistair, On 07/28/2017 07:16 PM, Alistair Francis wrote: Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -ty

Re: [Qemu-devel] [PATCH 39/47] MAINTAINERS: add missing SSI entries

2017-07-28 Thread Alistair Francis
On Thu, Jul 27, 2017 at 10:36 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because I'm not sure m25p80 fits. > > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 54e35fdab9..83597fca4e 100644 > --- a

[Qemu-devel] make check-help not working

2017-07-28 Thread Philippe Mathieu-Daudé
I'm a bit lost with this error: (master)$ make check-help V=1 cc -nostdlib -o check-help.mo cc: fatal error: no input files compilation terminated. rules.mak:115: recipe for target 'check-help.mo' failed make: *** [check-help.mo] Error 1 Phil.

Re: [Qemu-devel] host side todo list for virtio rdma

2017-07-28 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 07:02:55PM +0100, Dr. David Alan Gilbert wrote: > OK, does it seem silly for a message to go all the way to the host > kernel to then have to go back down to QEMU to be turned back into verbs > to go back upto the host kernel? This is how most IO works except vhost. If it'

[Qemu-devel] [PATCH v3 3/5] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-28 Thread Aleksandr Bezzubikov
On PCI init PCI bridges may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with a special vendor-specific PCI capability. Signed-off-by: Aleksandr Bezzubikov --- hw/pci/pci_bridge.c | 37 +

[Qemu-devel] [PATCH v3 1/3] pci: refactor pci_find_capapibilty to get bdf as the first argument instead of the whole pci_device

2017-07-28 Thread Aleksandr Bezzubikov
Refactor pci_find_capability function to get bdf instead of a whole pci_device* as the only necessary field for this function is still bdf. Reviewed-by: Marcel Apfelbaum Signed-off-by: Aleksandr Bezzubikov --- src/fw/pciinit.c| 4 ++-- src/hw/pci.c| 25 + s

[Qemu-devel] [PATCH v3 5/5] docs: update documentation considering PCIE-PCI bridge

2017-07-28 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- docs/pcie.txt| 46 ++ docs/pcie_pci_bridge.txt | 121 +++ 2 files changed, 147 insertions(+), 20 deletions(-) create mode 100644 docs/pcie_pci_bridge.txt diff --git a/docs/pcie.txt b

[Qemu-devel] [PATCH v3 2/3] pci: add QEMU-specific PCI capability structure

2017-07-28 Thread Aleksandr Bezzubikov
On PCI init PCI bridge devices may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with special vendor-specific PCI capability. This capability is intended to be used only for Red Hat PCI bridges, i.e. QEMU cooperation. Signed-off

[Qemu-devel] [PATCH v3 4/5] hw/pci: add QEMU-specific PCI capability to Generic PCI Express Root Port

2017-07-28 Thread Aleksandr Bezzubikov
From: Aleksandr Bezzubikov To enable hotplugging of a newly created pcie-pci-bridge, we need to tell firmware (SeaBIOS in this case) to reserve additional buses for pcie-root-port, that allows us to hotplug pcie-pci-bridge into this root port. The number of buses to reserve is provided to the dev

[Qemu-devel] [PATCH 4/4] docker: add centos7 image

2017-07-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/centos7.docker | 31 +++ 1 file changed, 31 insertions(+) create mode 100644 tests/docker/dockerfiles/centos7.docker diff --git a/tests/docker/dockerfiles/centos7.docker b/tests/docker/dockerfiles/ce

[Qemu-devel] [PATCH v3 0/5] Generic PCIE-PCI Bridge

2017-07-28 Thread Aleksandr Bezzubikov
This series introduces a new device - generic PCI Express to PCI bridge, and also makes all necessary changes to enable hotplug of the bridge itself and any device into the bridge. Changes v2->v3: (0). 'do_not_use' capability field flag is still _not_ in here since we haven't come to consesus on

[Qemu-devel] [PATCH v3 2/5] hw/pci: introduce pcie-pci-bridge device

2017-07-28 Thread Aleksandr Bezzubikov
Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the DMI-to-PCI Bridge in an overwhelming majority of use-cases. Signed-off-by: Aleksandr Bezzubikov --- hw/pci-bridge/Makefile

[Qemu-devel] [PATCH v3 1/5] hw/i386: allow SHPC for Q35 machine

2017-07-28 Thread Aleksandr Bezzubikov
Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6b7bade..2ab32f9 100644 --- a/hw/i386/acpi-build.c +++ b/hw

[Qemu-devel] [PATCH v3 3/3] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-28 Thread Aleksandr Bezzubikov
In case of Red Hat Generic PCIE Root Port reserve additional buses, which number is provided in a vendor-specific capability. Signed-off-by: Aleksandr Bezzubikov --- src/fw/pciinit.c | 37 +++-- src/hw/pci_ids.h | 3 +++ src/types.h | 2 ++ 3 files changed,

[Qemu-devel] [PATCH 2/4] docker: add Xen libs to centos6 image

2017-07-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/centos6.docker | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker index 9b91e832c2..8588a12eab 100644 --- a/tests/docker/dockerf

[Qemu-devel] [PATCH 1/4] docker: use one package per line in CentOS config

2017-07-28 Thread Philippe Mathieu-Daudé
This ease rebase/cherry-pick, also it is faster to visually find if a package is here. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/centos6.docker | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/docker/dockerfiles/centos6.docker

[Qemu-devel] [PATCH v3 0/3] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-28 Thread Aleksandr Bezzubikov
Now PCI bridges get a bus range number on a system init, basing on currently plugged devices. That's why when one wants to hotplug another bridge, it needs his child bus, which the parent is unable to provide (speaking about virtual device). The suggested workaround is to have vendor-specific cap

[Qemu-devel] [PATCH 0/4] docker: improve code coverage on CentOS images

2017-07-28 Thread Philippe Mathieu-Daudé
This series installs more packages to docker images to extend CI code coverage. Debian already have those but these images are only used on Shippable. Extending CentOS images could improve patchew, and local user not custom to Debian. The first idea was to add Suse images but only OpenSUSE 13.2 i

[Qemu-devel] [PATCH 3/4] docker: install more packages on CentOS to extend code coverage

2017-07-28 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/centos6.docker | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/docker/dockerfiles/centos6.docker b/tests/docker/dockerfiles/centos6.docker index 8588a12eab..f6aae13f29 100644 --- a/tests/docker/dockerfiles/c

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-28 Thread Michael S. Tsirkin
On Tue, Jul 25, 2017 at 07:10:33PM +0300, Marcel Apfelbaum wrote: > On 25/07/2017 17:09, Alexander Bezzubikov wrote: > > 2017-07-25 16:53 GMT+03:00 Michael S. Tsirkin : > > > On Tue, Jul 25, 2017 at 04:50:49PM +0300, Alexander Bezzubikov wrote: > > > > 2017-07-25 16:43 GMT+03:00 Michael S. Tsirkin

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-28 Thread Michael S. Tsirkin
On Tue, Jul 25, 2017 at 02:49:49PM +0300, Marcel Apfelbaum wrote: > On 25/07/2017 0:58, Michael S. Tsirkin wrote: > > On Tue, Jul 25, 2017 at 12:41:12AM +0300, Alexander Bezzubikov wrote: > > > 2017-07-24 23:46 GMT+03:00 Michael S. Tsirkin : > > > > On Sun, Jul 23, 2017 at 05:13:11PM +0300, Marcel

Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-28 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 03:58:58PM +0200, Laszlo Ersek wrote: > On 07/27/17 11:39, Marcel Apfelbaum wrote: > > On 27/07/2017 2:28, Michael S. Tsirkin wrote: > >> On Thu, Jul 27, 2017 at 12:54:07AM +0300, Alexander Bezzubikov wrote: > >>> 2017-07-26 22:43 GMT+03:00 Michael S. Tsirkin : > On Sun

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-28 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 12:39:54PM +0300, Marcel Apfelbaum wrote: > On 27/07/2017 2:28, Michael S. Tsirkin wrote: > > On Thu, Jul 27, 2017 at 12:54:07AM +0300, Alexander Bezzubikov wrote: > > > 2017-07-26 22:43 GMT+03:00 Michael S. Tsirkin : > > > > On Sun, Jul 23, 2017 at 01:15:41AM +0300, Aleksan

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-28 Thread Michael S. Tsirkin
On Thu, Jul 27, 2017 at 10:50:11AM +0800, Wei Wang wrote: > > > > OK I thought this over. While we might need these new APIs in > > > > the future, I think that at the moment, there's a way to implement > > > > this feature that is significantly simpler. Just add each s/g > > > > as a separate inpu

Re: [Qemu-devel] [PATCH v2 0/5] More warning reporting fixed

2017-07-28 Thread Alistair Francis
On Fri, Jul 28, 2017 at 3:37 PM, wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH v2 0/5] More warning reporting fixed >

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-28 Thread Michael S. Tsirkin
On Fri, Jul 28, 2017 at 04:25:19PM +0800, Wei Wang wrote: > On 07/12/2017 08:40 PM, Wei Wang wrote: > > Add a new feature, VIRTIO_BALLOON_F_SG, which enables to > > transfer a chunk of ballooned (i.e. inflated/deflated) pages using > > scatter-gather lists to the host. > > > > The implementation o

[Qemu-devel] [Bug 1707274] Re: Segfaults inside QEMU

2017-07-28 Thread DocMAX
OK, i think it was my mistake. The VM accidently used the same swap partition as the host. ** Changed in: qemu Assignee: (unassigned) => DocMAX (docmax) ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH v2 for 2.10 8/8] docs: fix broken paths to docs/spin/

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs/ to docs/devel/ on ac06724a71, some references were not updated. Signed-off-by: Philippe Mathieu-Daudé --- docs/spin/aio_notify.promela| 6 +++--- docs/spin/aio_notify_accept.promela | 4 ++-- docs/spin/aio_notify_bug.promela| 4 ++-- docs/spin/tcg-exclusiv

[Qemu-devel] [PATCH v2 for 2.10 7/8] docs: fix broken paths to docs/specs/ivshmem-spec.txt

2017-07-28 Thread Philippe Mathieu-Daudé
When this file was rewritten/renamed in fdee2025dd, a reference path was not updated. Signed-off-by: Philippe Mathieu-Daudé --- docs/specs/pci-ids.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/pci-ids.txt b/docs/specs/pci-ids.txt index 95adee07d6..bb99a0257e

[Qemu-devel] [PATCH v2 for 2.10 5/8] docs: fix broken paths to docs/devel/tracing.txt

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs/ to docs/devel/ on ac06724a71, no references were updated. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- audio/trace-events | 2 +- block/trace-events | 2 +- chardev/trace-events| 2 +- crypto/trace-event

[Qemu-devel] [PATCH v2 for 2.10 3/8] docs: fix broken paths to docs/devel/qapi-code-gen.txt

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs to docs/interop on ac06724a71, a couple of references were not updated. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/writing-qmp-commands.txt | 2 +- include/qapi/visitor.h | 2 +- qapi/introspect.json| 2 +- qapi/qapi-util.c

[Qemu-devel] [PATCH v2 for 2.10 2/8] docs: fix broken paths to docs/interop/qcow2.txt

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs to docs/interop on d59157ea05, a reference path was not updated. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kevin Wolf --- docs/qcow2-cache.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt inde

[Qemu-devel] [PATCH v2 for 2.10 1/8] docs: fix broken paths to docs/interop dir

2017-07-28 Thread Philippe Mathieu-Daudé
From: Cleber Rosa With the move of some docs to docs/interop on d59157e, a couple of references were not updated. Signed-off-by: Cleber Rosa [PMD: fixed a typo and another reference of docs/interop/qmp-spec.txt] Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- docs/devel/wri

[Qemu-devel] [PATCH v2 for 2.10 6/8] docs: fix broken paths to docs/config/ich9-ehci-uhci.cfg

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs/ to docs/devel/ on ac06724a71, a reference path was not updated. Signed-off-by: Philippe Mathieu-Daudé --- docs/usb2.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/usb2.txt b/docs/usb2.txt index b9e7548073..09df45b5b1 100644 --- a/docs/usb

[Qemu-devel] [PATCH v2 for 2.10 0/8] docs: fix broken paths

2017-07-28 Thread Philippe Mathieu-Daudé
Hi Michael, you already applied this series to -trivial, however I updated the commits message, not requested but not a heavy task to do neither. Since you didn't not sent PR yet, if you mind can you take those instead? Else it's not a big deal. Thanks! v2: - fixed what I misunderstood Eric said,

[Qemu-devel] [PATCH v2 for 2.10 4/8] docs: fix broken paths to docs/devel/atomics.txt

2017-07-28 Thread Philippe Mathieu-Daudé
With the move of some docs/ to docs/devel/ on ac06724a71, a couple of references were not updated. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/lockcnt.txt | 2 +- include/qemu/atomic.h | 4 ++-- tcg/README | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Stefano Stabellini
On Fri, 28 Jul 2017, Olaf Hering wrote: > g_malloc0_n is available since glib-2.24. To allow build with older glib > versions use the generic g_new0, which is already used in many other > places in the code. > > Fixes commit 3284fad728 ("xen-disk: add support for multi-page shared rings") > > Sig

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Stefano Stabellini
On Fri, 28 Jul 2017, Philippe Mathieu-Daudé wrote: > Hi Olaf, > > On 07/28/2017 10:11 AM, Olaf Hering wrote: > > g_malloc0_n is available since glib-2.24. To allow build with older glib > > versions use the generic g_new0, which is already used in many other > > places in the code. > > Can you pr

[Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-07-28 Thread Alistair Francis
Convert any remaining uses of fprintf(stderr, "warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i 's|fprintf(.*".*warning[,:] |warn_report("|Ig'

[Qemu-devel] [PATCH v2 4/5] Convert multi-line fprintf() to warn_report()

2017-07-28 Thread Alistair Francis
Convert all the multi-line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using these commands: find ./* -type f -exec sed -i \ 'N; {s|fprintf(.*".*warning

Re: [Qemu-devel] [PATCH v2 0/5] More warning reporting fixed

2017-07-28 Thread Alistair Francis
On Fri, Jul 28, 2017 at 3:14 PM, Alistair Francis wrote: > This series expands on my previous series by converting more existing > prints to use warn_report() instead of error_report() or fprintf(). > > V2: > - Fixup auto CC logic so everyone is CCed + Markus who got dropped off the cover letter

[Qemu-devel] [PATCH v2 2/5] Convert remaining error_report() to warn_report()

2017-07-28 Thread Alistair Francis
In a previous patch (3dc6f8693694a649a9c83f1e2746565b47683923) we converted uses of error_report("warning:"... to use warn_report() instead. This was to help standardise on a single method of printing warnings to the user. There appears to have been some cases that slipped through in patch sets ap

[Qemu-devel] [PATCH v2 3/5] Convert single line fprintf() to warn_report()

2017-07-28 Thread Alistair Francis
Convert all the single line uses of fprintf(stderr, "warning:"..."\n"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings were changed using this command: find ./* -type f -exec sed -i \ 's|fprintf(.*".*warning[,:]

[Qemu-devel] [PATCH v2 1/5] hw/i386: Improve some of the warning messages

2017-07-28 Thread Alistair Francis
Signed-off-by: Alistair Francis Suggested-by: Eduardo Habkost Cc: Eduardo Habkost --- V3: - Improve the messages hw/i386/acpi-build.c | 15 ++- hw/i386/pc.c | 7 +++ hw/i386/pc_q35.c | 8 +--- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2 0/5] More warning reporting fixed

2017-07-28 Thread Alistair Francis
This series expands on my previous series by converting more existing prints to use warn_report() instead of error_report() or fprintf(). V2: - Fixup auto CC logic so everyone is CCed Alistair Francis (5): hw/i386: Improve some of the warning messages Convert remaining error_report() to warn

Re: [Qemu-devel] [PATCH for-2.10 7/7] qemu-iotests/059: Fix leaked image files

2017-07-28 Thread Jeff Cody
On Fri, Jul 28, 2017 at 03:14:52PM +0200, Kevin Wolf wrote: > qemu-iotests 059 left a whole lot of image files behind in the scratch > directory because VMDK creates additional files for extents and cleaning > them up requires the original image intact (it parses qemu-img info > output to find all

Re: [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images

2017-07-28 Thread Jeff Cody
On Fri, Jul 28, 2017 at 03:14:46PM +0200, Kevin Wolf wrote: > qemu-iotests 041 left quorum_snapshot.img and target.img behind in the > scratch directory. Make sure to clean up after completing the tests. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/041 | 4 +++- > 1 file changed, 3 i

[Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

2017-07-28 Thread Anatol Pomozov
Hi I am looking at x86 multiboot code and trying to add "ELF section header" info feature. This will let target to learn more about booted binary and its sections. I have a draft here https://github.com/anatol/qemu/commit/ad943a6eb78feee048b6bb2a1e5f49f5b686e24c My understanding is that qemu mul

Re: [Qemu-devel] [PATCH for-2.10 6/7] qemu-iotests/063: Fix leaked image

2017-07-28 Thread Jeff Cody
On Fri, Jul 28, 2017 at 03:14:51PM +0200, Kevin Wolf wrote: > qemu-iotests 063 left t.raw.raw1 behind in the scratch directory because > it used the wrong suffix. Make sure to clean it up after completing the > test. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/063 | 4 +--- > 1 file

Re: [Qemu-devel] [PATCH for-2.10 5/7] qemu-iotests/162: Fix leaked temporary files

2017-07-28 Thread Jeff Cody
On Fri, Jul 28, 2017 at 03:14:50PM +0200, Kevin Wolf wrote: > qemu-iotests 162 left qemu-nbd.pid behind in the scratch directory, and > potentially a file called '42' in the current directory. Make sure to > clean it up after completing the tests. > > Signed-off-by: Kevin Wolf > --- > tests/qemu

Re: [Qemu-devel] [PATCH for-2.10 3/7] qemu-iotests/141: Fix image cleanup

2017-07-28 Thread Jeff Cody
On Fri, Jul 28, 2017 at 03:14:48PM +0200, Kevin Wolf wrote: > qemu-iotests 141 attempted to use brace expansion to remove all images > with a single command. However, for this to work, the braces shouldn't > be quoted. > > With this fix, the tests correctly cleans up its scratch images. > > Signe

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Peter Maydell
On 28 July 2017 at 21:49, Philippe Mathieu-Daudé wrote: > Hi Olaf, > > On 07/28/2017 10:11 AM, Olaf Hering wrote: >> >> g_malloc0_n is available since glib-2.24. To allow build with older glib >> versions use the generic g_new0, which is already used in many other >> places in the code. > > > Can

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Kani, Toshimitsu
On Fri, 2017-07-28 at 13:45 -0600, Ross Zwisler wrote: > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > > wrote: : > > Do you need that informationin e820? Linux effectively ignores > > type-7. As long as the range is treated as

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Philippe Mathieu-Daudé
Hi Olaf, On 07/28/2017 10:11 AM, Olaf Hering wrote: g_malloc0_n is available since glib-2.24. To allow build with older glib versions use the generic g_new0, which is already used in many other places in the code. Can you provide information about which distrib/release/version/[packages?] you

[Qemu-devel] [Bug 1707297] [NEW] qemu became more picky parsing -m option

2017-07-28 Thread John Florian
Public bug reported: With qemu-kvm-2.9.0-3.fc26.x86_64 I am no longer to specify the memory size using something like "-m 1.0GiB" but with qemu- kvm-2.7.1-7.fc25.x86_64 I could without any problem. I now get an error message like: qemu-system-x86_64: -m 1.0GiB: Parameter 'size' expects a

Re: [Qemu-devel] [PATCH for-2.10 2/2] target/s390x: Fix CSST for 16-byte store

2017-07-28 Thread Philippe Mathieu-Daudé
On 07/28/2017 03:50 PM, Richard Henderson wrote: Found by Coverity. "Found by Coverity (CID 1378273)." Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ta

Re: [Qemu-devel] [PATCH 38/47] MAINTAINERS: update docs/interop/ entries

2017-07-28 Thread John Snow
On 07/28/2017 02:16 AM, Fam Zheng wrote: On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 23de632424..54e35fdab9 100644 --- a/MAIN

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Dan Williams
On Fri, Jul 28, 2017 at 12:45 PM, Ross Zwisler wrote: > On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: >> On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler [..] > [ Adding Linda & Toshi to see if they have an opinion. ] > > I guess maybe we don't need it. Yep, /proc/iomem looks good:

Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

2017-07-28 Thread Eric Blake
On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/check_maintainer.sh | 21 + > 1 file changed, 21 insertions(+) > create mode 100755 scripts/check_maintainer.sh > > +echo "Incorrect MAINTAINERS paths:" 1>&2 > +egr

[Qemu-devel] Call for testers for various versions of Windows

2017-07-28 Thread Programmingkid
I have made a page that keeps track of anyone who wishes to be a tester for a particular version of Windows. Here is the page: http://wiki.qemu.org/Testing/Windows If there is a version of Window you would like to help test in QEMU, please contact me with the email address you wish to use and t

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Ross Zwisler
On Fri, Jul 28, 2017 at 11:11:10AM -0700, Dan Williams wrote: > On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler > wrote: > > I've been using the virtualized NVDIMM support in QEMU for testing, and I > > noticed that the physical addresses used by the virtual NVDIMMs aren't > > present > > in the g

Re: [Qemu-devel] [RFC PATCH 47/47] script to find outdated entry in MAINTAINERS

2017-07-28 Thread Eric Blake
On 07/28/2017 11:26 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> +# This script checks MAINTAINERS consistency > > Consistency? I think you mean coverage. Indeed - consistency implies even more, such as all email addresses

[Qemu-devel] [Bug 1707274] Re: Segfaults inside QEMU

2017-07-28 Thread DocMAX
** Description changed: I'm running a server with QEMU emulator version 2.9.0. Although i gave the machine plenty RAM it begins segfaulting some processes after some hours which ends in a complete crash. - This is the commandline from libvirt and i also attached the QEMU log: - - /usr/bi

Re: [Qemu-devel] [PATCH for-2.10 0/7] qemu-iotests: Fix leaked temporary file fixes

2017-07-28 Thread Eric Blake
On 07/28/2017 08:14 AM, Kevin Wolf wrote: > This fixes leaked temporary files that are created during successful > runs of qemu-iotests for qcow2, raw and vmdk. More file leaks exist for > failing or interrupted tests, but this is something for another day. > > Kevin Wolf (7): > qemu-iotests/041

Re: [Qemu-devel] [PATCH for-2.10 7/7] qemu-iotests/059: Fix leaked image files

2017-07-28 Thread Eric Blake
On 07/28/2017 08:14 AM, Kevin Wolf wrote: > qemu-iotests 059 left a whole lot of image files behind in the scratch > directory because VMDK creates additional files for extents and cleaning > them up requires the original image intact (it parses qemu-img info > output to find all extent files), but

[Qemu-devel] [Bug 1707274] [NEW] Segfaults inside QEMU

2017-07-28 Thread DocMAX
Public bug reported: I'm running a server with QEMU emulator version 2.9.0. Although i gave the machine plenty RAM it begins segfaulting some processes after some hours which ends in a complete crash. I can't see something special in the log when the segfaults begins. 2017-07-28 11:45:01.027+000

[Qemu-devel] [Bug 1707274] Re: Segfaults inside QEMU

2017-07-28 Thread DocMAX
** Attachment added: "server.log.1" https://bugs.launchpad.net/qemu/+bug/1707274/+attachment/4923250/+files/server.log.1 ** Description changed: - I'm running a server with QEMU emulator version 2.9.0. Although i gave the machine plenty RAM it begins segfaulting some processes after some hou

Re: [Qemu-devel] [PATCH for-2.10 1/7] qemu-iotests/041: Fix leaked scratch images

2017-07-28 Thread Eric Blake
On 07/28/2017 08:14 AM, Kevin Wolf wrote: > qemu-iotests 041 left quorum_snapshot.img and target.img behind in the > scratch directory. Make sure to clean up after completing the tests. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/041 | 4 +++- > 1 file changed, 3 insertions(+), 1 de

Re: [Qemu-devel] [PATCH for-2.10 2/7] qemu-iotests: Remove blkdebug.conf after tests

2017-07-28 Thread Eric Blake
On 07/28/2017 08:14 AM, Kevin Wolf wrote: > qemu-iotests 074 and 179 left a blkdebug.conf behind the scratch s/behind/behind in/ > directory. Make sure to clean up after completing the tests. > > Signed-off-by: Kevin Wolf > --- -- Eric Blake, Principal Software Engineer Red Hat, Inc.

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Eric Blake
On 07/28/2017 08:11 AM, Olaf Hering wrote: > g_malloc0_n is available since glib-2.24. To allow build with older glib s/is/is only/ > versions use the generic g_new0, which is already used in many other > places in the code. > > Fixes commit 3284fad728 ("xen-disk: add support for multi-page shar

Re: [Qemu-devel] [PULL 4/5] block: Skip implicit nodes in query-block/blockstats

2017-07-28 Thread Peter Maydell
On 24 July 2017 at 15:32, Kevin Wolf wrote: > Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > nodes above the top layer of mirror and commit block jobs. The > assumption made there was that since libvirt doesn't do node-level > management of the block layer yet, it shoul

Re: [Qemu-devel] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd

2017-07-28 Thread Eric Blake
On 07/28/2017 01:53 PM, Markus Armbruster wrote: > Eric Blake writes: > >> Now that we have the qmp_cmd() helper, we can further simplify >> some of the tests by using it. >> >> Signed-off-by: Eric Blake >> --- >> } >> -resp = qmp("{'execute': 'qom-list-types'," >> - " 'a

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-28 Thread Eric Blake
On 07/28/2017 01:32 PM, Markus Armbruster wrote: > Eric Blake writes: > >> We have two flavors of vararg usage in qtest; make it clear that >> qmp() has different semantics than hmp(), and let the compiler >> enforce that hmp() is used correctly. However, qmp() (and friends) >> only accept a subs

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-07-28 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > Add #if defined(CONFIG_VNC) in generated code, and adjust the > qmp/hmp code accordingly. > > Signed-off-by: Marc-André Lureau > diff --git a/hmp.c b/hmp.c > index fd80dce758..9454c634bd 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -605,6 +60

Re: [Qemu-devel] [PATCH v3 01/12] qobject: Accept "%"PRId64 in qobject_from_jsonf()

2017-07-28 Thread Eric Blake
On 07/28/2017 01:13 PM, Markus Armbruster wrote: >> Finally, update configure to barf on any libc that uses yet >> another form of PRId64 that we have not yet coded for, so that we >> can once again update json-lexer.c to cater to those quirks (my >> guess? we might see %jd next) (on the bright si

Re: [Qemu-devel] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd

2017-07-28 Thread Markus Armbruster
Eric Blake writes: > Now that we have the qmp_cmd() helper, we can further simplify > some of the tests by using it. > > Signed-off-by: Eric Blake > --- > tests/device-introspect-test.c | 3 +-- > tests/ide-test.c | 2 +- > tests/libqos/libqos.c | 5 +++-- > tests/libq

Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

2017-07-28 Thread Eric Blake
On 07/28/2017 01:45 PM, Markus Armbruster wrote: > Eric Blake writes: > >> When interpolating a QMP command from the testsuite, we have >> a very common pattern that the command to be executed is a >> string constant, while the arguments may need to be crafted >> from qobject_from_jsonf() or even

[Qemu-devel] [PATCH for-2.10 1/2] tcg/arm: Fix runtime overalignment test

2017-07-28 Thread Richard Henderson
Patch 85aa80813dd changed the IF emitting the TST instruction, but failed to change the ?: converting CMP to CMPEQ, so the result of the TST is ignored. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-t

[Qemu-devel] [PATCH for-2.10 0/2] Two quick tcg-ish fixes

2017-07-28 Thread Richard Henderson
One found by Coverity and one found while working on some code destined for 2.11. r~ Richard Henderson (2): tcg/arm: Fix runtime overalignment test target/s390x: Fix CSST for 16-byte store target/s390x/mem_helper.c | 1 + tcg/arm/tcg-target.inc.c | 2 +- 2 files changed, 2 insertions(+),

[Qemu-devel] [PATCH for-2.10 2/2] target/s390x: Fix CSST for 16-byte store

2017-07-28 Thread Richard Henderson
Found by Coverity. Reported-by: Paolo Bonzini Signed-off-by: Richard Henderson --- target/s390x/mem_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index cdc78aa3d4..c71dce4b1e 100644 --- a/target/s390x/mem_helper.c +++ b/target

Re: [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

2017-07-28 Thread Markus Armbruster
Eric Blake writes: > When interpolating a QMP command from the testsuite, we have > a very common pattern that the command to be executed is a > string constant, while the arguments may need to be crafted > from qobject_from_jsonf() or even by hand. Make it easier to > craft the arguments withou

Re: [Qemu-devel] [PATCH for 2.10 2/8] docs: fix broken paths to docs/interop/qcow2.txt

2017-07-28 Thread Eric Blake
On 07/27/2017 08:25 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé The commit message in 1/8 was a lot nicer, in referring to which commit broke the linkage. (When backporting patches, a very common thing to do is 'git log' and then grep for the commit id being backpor

Re: [Qemu-devel] [PATCH for 2.10 0/8] docs: fix broken paths

2017-07-28 Thread Eric Blake
On 07/27/2017 08:25 PM, Philippe Mathieu-Daudé wrote: > Hi, following Cleber Rosa example I cleaned more invalid references. > > Eric said this can wait 2.11, however these patches don't change any code > generated, I think the 2.10 users deserve an up-to-date doc :p I think what I said was: this

Re: [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-28 Thread Markus Armbruster
Eric Blake writes: > We have two flavors of vararg usage in qtest; make it clear that > qmp() has different semantics than hmp(), and let the compiler > enforce that hmp() is used correctly. However, qmp() (and friends) > only accept a subset of printf flags look-alikes (namely, those > that our

Re: [Qemu-devel] [PATCH v5 3/3] hmp: introduce 'info memory-size-summary' command

2017-07-28 Thread Eric Blake
On 07/28/2017 07:10 AM, Vadim Galitsyn wrote: > This command is an equivalent of QMP command query-memory-size-summary. > It provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amoun

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-07-28 Thread Eric Blake
On 07/28/2017 07:10 AM, Vadim Galitsyn wrote: > Command above provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amount of memory that was hot-plugged. > If target does not have

Re: [Qemu-devel] [PATCH v2 1/1] monitor: improve tracing in handle_qmp_command

2017-07-28 Thread Eric Blake
On 07/28/2017 12:01 PM, Markus Armbruster wrote: > "Denis V. Lunev" writes: > >> Calculate req_json only if trace_handle_qmp_command enabled. >> >> Signed-off-by: Denis V. Lunev >> CC: Stefan Hajnoczi >> CC: Lluís Vilanova >> CC: Dr. David Alan Gilbert >> CC: Markus Armbruster >> --- > Conf

Re: [Qemu-devel] [PATCH v3 01/12] qobject: Accept "%"PRId64 in qobject_from_jsonf()

2017-07-28 Thread Markus Armbruster
Eric Blake writes: > Commit 1792d7d0 was written because PRId64 expands to non-portable > crap for some libc, and we had testsuite failures on Mac OS as a > result. This in turn makes it difficult to rely on the obvious > conversions of 64-bit values into JSON, requiring things such as > casting

Re: [Qemu-devel] QEMU NVDIMM as type 7 in e820 table

2017-07-28 Thread Dan Williams
On Fri, Jul 28, 2017 at 11:04 AM, Ross Zwisler wrote: > I've been using the virtualized NVDIMM support in QEMU for testing, and I > noticed that the physical addresses used by the virtual NVDIMMs aren't present > in the guest's e820 table. > > Here is the e820 table on my QEMU instance where I hav

Re: [Qemu-devel] [PATCH 0/3] Don't QAPI without need

2017-07-28 Thread Eric Blake
On 07/28/2017 08:45 AM, Markus Armbruster wrote: > These are pretty trivial, probably simplest if I take them through my > tree. > > Markus Armbruster (3): > replay: Define ReplayMode without QAPI > COLO: Define COLOMode without QAPI > block: Remove unused BlockDeviceMapEntry > Reviewed-by

Re: [Qemu-devel] [PATCH 3/3] block: Remove unused BlockDeviceMapEntry

2017-07-28 Thread Eric Blake
On 07/28/2017 08:45 AM, Markus Armbruster wrote: > BlockDeviceMapEntry has never been used. It was added in commit > facd6e2 "so that it is published through the introspection mechanism." > What exactly introspecting types that aren't used for anything could > accomplish isn't clear. What "intros

Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-28 Thread Eric Blake
On 07/28/2017 12:17 PM, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> COLOMode is defined in the QAPI schema, but not used there. Of the >> stuff QAPI generates for it only the typedef is actually used. Use of >> QAPI is pointless and only complicates things, s

  1   2   3   4   >