Re: [Qemu-devel] [PATCH v5 13/17] migration: Create thread infrastructure for multifd recv side

2017-08-08 Thread Peter Xu
On Tue, Aug 08, 2017 at 01:41:13PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jul 17, 2017 at 03:42:34PM +0200, Juan Quintela wrote: > > >> +static void multifd_recv_page(uint8_t *address, uint16_t fd_num) > >> +{ > >> +int thread_count; > >> +

Re: [Qemu-devel] [PATCH] ppc/spapr: fix unicast H_SIGNAL_SYS_RESET

2017-08-08 Thread David Gibson
On Wed, Aug 09, 2017 at 03:07:19PM +1000, Nicholas Piggin wrote: > On Wed, 9 Aug 2017 14:05:46 +1000 > David Gibson wrote: > > > On Wed, Aug 09, 2017 at 03:59:36AM +1000, Nicholas Piggin wrote: > > > Unicast H_SIGNAL_SYS_RESET does not find the target CPU if it > > >

[Qemu-devel] [PATCH v3 1/1] ppc: spapr: Make VCPU ID handling private to SPAPR

2017-08-08 Thread Sam Bobroff
The concept of a VCPU ID that differs from the CPU's index (cpu->cpu_index) exists only within SPAPR machines so, move the functions ppc_get_vcpu_id() and ppc_get_cpu_by_vcpu_id() into spapr.c and rename them appropriately. Signed-off-by: Sam Bobroff --- Changes in v3:

[Qemu-devel] [PATCH v3 0/1] Cleanup cpu_dt_id

2017-08-08 Thread Sam Bobroff
Just the one minor change in this version. Patch set changelog follows: == Version 2 -> version 3: == Patch 1/1: ppc: spapr: Make VCPU ID handling private to SPAPR * Implemented spapr_find_cpu() using spapr_vcpu_id() rather than direct access to vcpu_id. == Version 1 -> version

Re: [Qemu-devel] [PATCH] 9pfs: fix dependencies

2017-08-08 Thread Thomas Huth
On 08.08.2017 18:26, Greg Kurz wrote: > On Tue, 8 Aug 2017 17:38:27 +0200 > Cornelia Huck wrote: > >> Nothing in fsdev/ or hw/9pfs/ depends on pci; it should rather depend >> on CONFIG_VIRTFS and on the presence of an appropriate virtio transport >> device. >> >> Let's

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-08-08 Thread David Gibson
On Tue, Aug 08, 2017 at 01:40:08PM -0600, Alex Williamson wrote: > On Thu, 27 Jul 2017 12:50:42 +0100 > "Daniel P. Berrange" wrote: > > > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > >

Re: [Qemu-devel] [PATCH] ppc/spapr: fix unicast H_SIGNAL_SYS_RESET

2017-08-08 Thread Nicholas Piggin
On Wed, 9 Aug 2017 14:05:46 +1000 David Gibson wrote: > On Wed, Aug 09, 2017 at 03:59:36AM +1000, Nicholas Piggin wrote: > > Unicast H_SIGNAL_SYS_RESET does not find the target CPU if it > > is not the current CPU. > > > > Signed-off-by: Nicholas Piggin

[Qemu-devel] [PATCH 1/2] tests/boot-sector: Do not overwrite the x86 buffer on other architectures

2017-08-08 Thread Thomas Huth
Re-using the boot_sector code buffer from x86 for other architectures is not very nice, especially if we add more architectures later. It's also ugly that the test uses a huge pre-initialized array - the size of the executable is very huge due to this array. So let's use a separate buffer for each

[Qemu-devel] [PATCH for-2.11 0/2] Improvements for the pxe tester

2017-08-08 Thread Thomas Huth
The first patch improves the buffer handling in the pxe tester a little bit by allocating a separate buffer on the heap for each architecture. This also gets rid of the huge pre-initialized array in the tester, shrinking the size of the executable by half of a megabyte! The second patch adds s390x

[Qemu-devel] [PATCH 2/2] tests/pxe: Check virtio-net-ccw on s390x

2017-08-08 Thread Thomas Huth
Now that we've got a firmware that can do TFTP booting on s390x (i.e. the pc-bios/s390-netboot.img), we can enable the PXE tester for this architecture, too. Signed-off-by: Thomas Huth --- tests/Makefile.include | 1 + tests/boot-sector.c| 20

Re: [Qemu-devel] [PATCH] ppc/spapr: fix unicast H_SIGNAL_SYS_RESET

2017-08-08 Thread David Gibson
On Wed, Aug 09, 2017 at 03:59:36AM +1000, Nicholas Piggin wrote: > Unicast H_SIGNAL_SYS_RESET does not find the target CPU if it > is not the current CPU. > > Signed-off-by: Nicholas Piggin > --- > > Unfortunately this slipped through without my noticing because the > Linux

Re: [Qemu-devel] [for-2.10 PATCH 3/3] spapr: error out if PHB fails to setup PCI DRCs

2017-08-08 Thread David Gibson
On Tue, Aug 08, 2017 at 11:18:35AM +0200, Greg Kurz wrote: > On Tue, 8 Aug 2017 16:16:36 +1000 > David Gibson wrote: > > > On Mon, Aug 07, 2017 at 07:25:03PM +0200, Greg Kurz wrote: > > > It is currently possible to start QEMU with two PHBs without using the > > >

Re: [Qemu-devel] [PATCH v2 1/1] ppc: spapr: Make VCPU ID handling private to SPAPR

2017-08-08 Thread David Gibson
On Wed, Aug 09, 2017 at 10:02:44AM +1000, Sam Bobroff wrote: > On Tue, Aug 08, 2017 at 04:24:01PM +1000, David Gibson wrote: > > On Mon, Aug 07, 2017 at 04:33:29PM +1000, Sam Bobroff wrote: > > > The concept of a VCPU ID that differs from the CPU's index > > > (cpu->cpu_index) exists only within

Re: [Qemu-devel] [PATCH for-2.11] rcu: init globals only once

2017-08-08 Thread Peter Xu
On Tue, Aug 08, 2017 at 09:09:23AM -0500, Eric Blake wrote: > On 08/08/2017 02:49 AM, Peter Xu wrote: > >> This doesn't work for error-checking mutexes: rcu_init_child has a > >> different PID than the parent, so the mutexes aren't unlocked. It's > >> also true that right now we don't use

Re: [Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons

2017-08-08 Thread Michael S. Tsirkin
On Wed, Aug 09, 2017 at 12:47:50AM +0200, Marc-André Lureau wrote: > qemu uses wheel-up/down button events for mouse wheel input, however > linux applications typically want REL_WHEEL events. > > This fixes wheel with linux guests. Tested with X11/wayland, and > windows virtio-input driver. > >

[Qemu-devel] [PULL 5/5] libqtest: always set up signal handler for SIGABRT

2017-08-08 Thread Michael S. Tsirkin
From: Jens Freimann Currently abort handlers only work for the first test function in a testcase, because the list of abort handlers is not properly cleared when qtest_quit() is called. qtest_quit() only deletes the kill_qemu_hook but doesn't completely clear the

[Qemu-devel] [PULL 2/5] Revert "cpu: add APIs to allocate/free CPU environment"

2017-08-08 Thread Michael S. Tsirkin
This reverts commit e2a7f28693aea7e194ec1435697ec4feb24f8a6f. This was not supposed to go upstream yet. Reverting. Signed-off-by: Michael S. Tsirkin --- include/qom/cpu.h | 31 --- qom/cpu.c | 34 -- 2 files

[Qemu-devel] [PULL 0/5] pc, vhost: fixes for rc3

2017-08-08 Thread Michael S. Tsirkin
The following changes since commit 54affb3a3623b1d36c95e34faa722a5831323a74: Update version for v2.10.0-rc2 release (2017-08-08 19:07:46 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

[Qemu-devel] [PULL 4/5] libvhost-user: quit when no more data received

2017-08-08 Thread Michael S. Tsirkin
From: Jens Freimann End processing of messages when VHOST_USER_NONE is received. Without this we run into a vubr_panic() call and get "PANIC: Unhandled request: 0" Signed-off-by: Jens Freimann Reviewed-by: Michael S. Tsirkin

[Qemu-devel] [PULL 1/5] acpi-test: update expected DSDT files

2017-08-08 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/q35/DSDT| Bin 7782 -> 7782 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 7799 -> 7799 bytes tests/acpi-test-data/q35/DSDT.cphp | Bin 8245 -> 8245 bytes tests/acpi-test-data/q35/DSDT.ipmibt | Bin 7857 ->

[Qemu-devel] [PULL 3/5] net: fix -netdev socket, fd= for UDP sockets

2017-08-08 Thread Michael S. Tsirkin
From: Jens Freimann This patch fixes -netdev socket,fd= for UDP sockets Currently -netdev socket,fd=<...> results in qemu: error: specified mcastaddr "127.0.0.1" (0x7f01) does not contain a multicast address qemu-system-x86_64: -netdev socket,id=n1,fd=3:

Re: [Qemu-devel] [PATCH v2 0/4] i386/kvm: advertise Hyper-V frequency MSRs

2017-08-08 Thread Marcelo Tosatti
On Mon, Aug 07, 2017 at 10:56:59AM +0200, Ladi Prosek wrote: > This is the QEMU part of the changes required for nested Hyper-V to read > timestamps with RDTSC + TSC page. Without exposing the frequency MSRs, > Windows with the Hyper-V role enabled use the much slower > HV_X64_MSR_TIME_REF_COUNT

Re: [Qemu-devel] [PATCH 0/9] IDE: replace printfs with tracing

2017-08-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170808183306.27474-1-js...@redhat.com Subject: [Qemu-devel] [PATCH 0/9] IDE: replace printfs with tracing Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread Michael S. Tsirkin
On Tue, Aug 08, 2017 at 04:59:02PM -0700, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Message-id:

Re: [Qemu-devel] Qemu and 32 PCIe devices

2017-08-08 Thread Laszlo Ersek
On 08/08/17 17:51, Laszlo Ersek wrote: > On 08/08/17 12:39, Marcin Juszkiewicz wrote: >> Anyway, beyond the things written in that comment, there is one very >> interesting symptom that makes me think another (milder?) bottleneck >> could be in QEMU: >> >> When having a large number of PCI(e)

Re: [Qemu-devel] [PATCH v3 0/3] Vmstate-static-checker.py fix upstream

2017-08-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1502124810-6930-1-git-send-email-dve...@redhat.com Subject: [Qemu-devel] [PATCH v3 0/3] Vmstate-static-checker.py fix upstream Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v6 00/19] Multifd

2017-08-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170808162224.32419-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/19] Multifd Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v2 1/1] ppc: spapr: Make VCPU ID handling private to SPAPR

2017-08-08 Thread Sam Bobroff
On Tue, Aug 08, 2017 at 04:24:01PM +1000, David Gibson wrote: > On Mon, Aug 07, 2017 at 04:33:29PM +1000, Sam Bobroff wrote: > > The concept of a VCPU ID that differs from the CPU's index > > (cpu->cpu_index) exists only within SPAPR machines so, move the > > functions ppc_get_vcpu_id() and

Re: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170808203900.7661-1-jfreim...@redhat.com Subject: [Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase

Re: [Qemu-devel] [PATCH 0/3] Vmstate-static-checker.py fix upstream

2017-08-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1502134806-13669-1-git-send-email-dve...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] Vmstate-static-checker.py fix upstream Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH] target/i386: set rip_offset for further SSE instructions

2017-08-08 Thread Joseph Myers
It turns out that my recent fix to set rip_offset when emulating some SSE4.1 instructions needs generalizing to cover a wider class of instructions. Specifically, every instruction in the sse_op_table7 table, coming from various instruction set extensions, has an 8-bit immediate operand that

Re: [Qemu-devel] [PATCH v6 00/19] Multifd

2017-08-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170808162629.32493-1-quint...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/19] Multifd Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names

2017-08-08 Thread Pranith Kumar
On Mon, Aug 7, 2017 at 7:07 AM, Eric Blake wrote: > On 08/05/2017 01:52 PM, Pranith Kumar wrote: >> FYI, >> >> This commit breaks the build with gcc-7: >> >> CC block/vvfat.o >> qemu/block/vvfat.c: In function ‘read_directory’: >> qemu/block/vvfat.c:605:37: error:

Re: [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-08 Thread Philippe Mathieu-Daudé
On 08/08/2017 05:00 PM, Eric Blake wrote: On 08/08/2017 01:32 PM, John Snow wrote: Out with the old, in with the new. Signed-off-by: John Snow --- hw/ide/piix.c | 11 hw/ide/trace-events | 33 hw/ide/via.c

Re: [Qemu-devel] [PATCH] target/alpha: Switch to do_transaction_failed() hook

2017-08-08 Thread Richard Henderson
On 08/08/2017 05:42 AM, Peter Maydell wrote: > Switch the alpha target from the old unassigned_access hook > to the new do_transaction_failed hook. This allows us to > resolve a ??? in the old hook implementation. > > The only part of the alpha target that does physical > memory accesses is

[Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons

2017-08-08 Thread Marc-André Lureau
qemu uses wheel-up/down button events for mouse wheel input, however linux applications typically want REL_WHEEL events. This fixes wheel with linux guests. Tested with X11/wayland, and windows virtio-input driver. Signed-off-by: Marc-André Lureau ---

Re: [Qemu-devel] [PATCH for-2.10? v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread Michael S. Tsirkin
On Tue, Aug 08, 2017 at 04:05:56PM -0500, Eric Blake wrote: > On 08/08/2017 03:38 PM, Jens Freimann wrote: > > This implements a testcase for pxe-test using the vhost-user interface. > > Spawn a > > vhost-user-bridge process and connect it to the qemu process. > > > > To make the testcase work

[Qemu-devel] [Bug 1709170] Re: QEMU fails to honor O_TMPFILE

2017-08-08 Thread Thiago Macieira
It was a Yocto 2.0 sysroot running on an Ubuntu 16.04 host. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1709170 Title: QEMU fails to honor O_TMPFILE Status in QEMU: New Bug description:

Re: [Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

2017-08-08 Thread Cleber Rosa
On 08/08/2017 05:13 PM, Eric Blake wrote: > On 08/08/2017 03:53 PM, Cleber Rosa wrote: >> Most QMP commands and returns in the QAPI schema documentation >> are valid "JSON-based wire format". A few examples are either >> malformed, or contain comments. >> >> This fixes all the examples command

Re: [Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

2017-08-08 Thread Eric Blake
On 08/08/2017 03:53 PM, Cleber Rosa wrote: > Most QMP commands and returns in the QAPI schema documentation > are valid "JSON-based wire format". A few examples are either > malformed, or contain comments. > > This fixes all the examples command and return data, making them > proper JSON, as

Re: [Qemu-devel] [PATCH for-2.10? v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread Eric Blake
On 08/08/2017 03:38 PM, Jens Freimann wrote: > This implements a testcase for pxe-test using the vhost-user interface. Spawn > a > vhost-user-bridge process and connect it to the qemu process. > > To make the testcase work we need to apply a few patches before the actual > testcase: > - Patch 1

[Qemu-devel] [PATCH 0/1] QAPI schema: turn example commands/returns into proper JSON

2017-08-08 Thread Cleber Rosa
The QAPI schema documentation sections contain examples of QMP input and output. These are supposed to follow the "JSON-based" wire protocol, but in practice, there are a few data structure problems and also documentation. This turns all inputs and outputs into parseable JSON-like data. Besides

[Qemu-devel] [PATCH 1/1] QAPI schema: turn example commands/returns into proper JSON

2017-08-08 Thread Cleber Rosa
Most QMP commands and returns in the QAPI schema documentation are valid "JSON-based wire format". A few examples are either malformed, or contain comments. This fixes all the examples command and return data, making them proper JSON, as they would be received and generated by QEMU's QMP

Re: [Qemu-devel] [PATCH 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-08-08 Thread Eric Blake
On 08/08/2017 01:33 PM, John Snow wrote: > Goodbye, printfs. > Hello, fancy printfs. > > Signed-off-by: John Snow > --- > hw/ide/atapi.c| 64 > +-- > hw/ide/trace-events | 19 ++ >

[Qemu-devel] [PATCH v2 4/5] libqtest: always set up signal handler for SIGABRT

2017-08-08 Thread Jens Freimann
Currently abort handlers only work for the first test function in a testcase, because the list of abort handlers is not properly cleared when qtest_quit() is called. qtest_quit() only deletes the kill_qemu_hook but doesn't completely clear the abrt_hooks list. The effect is that

[Qemu-devel] [PATCH v2 3/5] libvhost-user: quit when no more data received

2017-08-08 Thread Jens Freimann
From: Jens Freimann End processing of messages when VHOST_USER_NONE is received. Without this we run into a vubr_panic() call and get "PANIC: Unhandled request: 0" Signed-off-by: Jens Freimann --- contrib/libvhost-user/libvhost-user.c | 4 +++- 1

[Qemu-devel] [PATCH v2 5/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread Jens Freimann
From: Jens Freimann Add a PXE testcase tunneling traffic through vhost-user-bridge process. Create a vhost-user-bridge process and connect it to qemu via a socket. Signed-off-by: Jens Freimann --- tests/Makefile.include | 4 +- tests/pxe-test.c

[Qemu-devel] [PATCH v2 1/5] tests/vhost-user-bridge: disable debug output by default

2017-08-08 Thread Jens Freimann
From: Jens Freimann vhost-user-bridge prints out a lot of information, including dumps of all transmitted data. When called from a testcase this output clutters the actual test results, so let's make the default no debug output. Reviewed-by: Maxime Coquelin

[Qemu-devel] [PATCH v2 2/5] net: fix -netdev socket, fd= for UDP sockets

2017-08-08 Thread Jens Freimann
This patch fixes -netdev socket,fd= for UDP sockets Currently -netdev socket,fd=<...> results in qemu: error: specified mcastaddr "127.0.0.1" (0x7f01) does not contain a multicast address qemu-system-x86_64: -netdev socket,id=n1,fd=3: Device 'socket' could not be initialized To

[Qemu-devel] [PATCH v2 0/5] tests/pxe-test: add testcase using vhost-user-bridge

2017-08-08 Thread Jens Freimann
This implements a testcase for pxe-test using the vhost-user interface. Spawn a vhost-user-bridge process and connect it to the qemu process. To make the testcase work we need to apply a few patches before the actual testcase: - Patch 1 disables debug output of vhost-user-bridge - Patch 2 fixes

Re: [Qemu-devel] [PATCH v4] tests: Avoid non-portable 'echo -ARG'

2017-08-08 Thread Eric Blake
On 08/08/2017 09:48 AM, Kevin Wolf wrote: >>> Not completely sure why, but this broke the test with whitespace changes >>> like this: >>> >>> -=== Running test case: mmap.elf -m 1.1M === >>> +=== Running test case: mmap.elf -m1.1M === >> >> I guess that means I'm not regularly running

Re: [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread John Snow
On 08/08/2017 04:30 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. > > Is that because the trace would fire so frequently in normal usage that > it will

[Qemu-devel] [PATCH for-2.11 v2 5/5] Remove scripts/qmp/qmp

2017-08-08 Thread Eduardo Habkost
The only purpose of scripts/qmp/qmp was the ability to run QMP commands non-interactively. Now it is possible to run qmp-shell non-interactively by providing a QMP command a command-line argument, making scripts/qmp/qmp obsolete. Reviewed-by: Stefan Hajnoczi Tested-by: John

[Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-08 Thread Eduardo Habkost
This is useful for testing QMP commands in scripts. Example usage, combined with 'jq' for filtering the results: $ ./scripts/qmp/qmp-shell /tmp/qmp qom-list path=/ | jq -r .return[].name machine type chardevs backend $ Signed-off-by: Eduardo Habkost --- Changes

[Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-08 Thread Eduardo Habkost
It makes command-line parsing and generation of help text much simpler. The optparse module is deprecated since Python 2.7, but argparse is not available in Python 2.6 (the minimum Python version required for building QEMU). Signed-off-by: Eduardo Habkost --- Changes v1 ->

[Qemu-devel] [PATCH for-2.11 v2 3/5] qmp-shell: execute_cmdargs() method

2017-08-08 Thread Eduardo Habkost
This will allow us to execute a command that was already split in a list. Reviewed-by: Stefan Hajnoczi Tested-by: John Snow Reviewed-by: John Snow Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * (none) ---

[Qemu-devel] [PATCH for-2.11 v2 2/5] qmp-shell: Pass split cmdargs to __build_cmd()

2017-08-08 Thread Eduardo Habkost
This will allow us to implement a method to run a command that is already split in a list. Reviewed-by: Stefan Hajnoczi Tested-by: John Snow Reviewed-by: John Snow Signed-off-by: Eduardo Habkost --- Changes v1 ->

[Qemu-devel] [PATCH for-2.11 v2 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp

2017-08-08 Thread Eduardo Habkost
This series adds the ability to run QMP commands non-interactively to qmp-shell, and deletes scripts/qmp/qmp. Changes v1 -> v2: * Use optparse module instead of argparse. optparse is deprecated since Python 2.7, but argparse is not available on Python 2.6, the minimum Python version required

Re: [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread Eric Blake
On 08/08/2017 03:30 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. > > Is that because the trace would fire so frequently in normal usage that > it will drown

Re: [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread Eric Blake
On 08/08/2017 01:33 PM, John Snow wrote: > To be used sparingly, but still interesting in the case of small > firmwares designed to reproduce bugs in QEMU IDE. Is that because the trace would fire so frequently in normal usage that it will drown the user in noise? > > Signed-off-by: John Snow

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Eric Blake
On 08/08/2017 03:24 PM, Eric Blake wrote: > On 08/08/2017 03:10 PM, Philippe Mathieu-Daudé wrote: >>> Technically, POSIX says (and 'man 2 open' agrees, modulo the fact that >>> Linux still lacks O_SEARCH) that you MUST provide one of the 5 access >>> modes (they are O_RDONLY, O_RDWR, O_WRONLY,

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Eric Blake
On 08/08/2017 03:10 PM, Philippe Mathieu-Daudé wrote: >> Technically, POSIX says (and 'man 2 open' agrees, modulo the fact that >> Linux still lacks O_SEARCH) that you MUST provide one of the 5 access >> modes (they are O_RDONLY, O_RDWR, O_WRONLY, O_EXEC, and O_SEARCH; >> although POSIX allows

[Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc2 is now available

2017-08-08 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.10 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.10.0-rc2.tar.xz

[Qemu-devel] [PATCH] target/i386: fix pmovsx/pmovzx in-place operations

2017-08-08 Thread Joseph Myers
The SSE4.1 pmovsx* and pmovzx* instructions take packed 1-byte, 2-byte or 4-byte inputs and sign-extend or zero-extend them to a wider vector output. The associated helpers for these instructions do the extension on each element in turn, starting with the lowest. If the input and output are the

Re: [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread John Snow
On 08/08/2017 04:10 PM, Eric Blake wrote: > On 08/08/2017 01:33 PM, John Snow wrote: >> To be used sparingly, but still interesting in the case of small >> firmwares designed to reproduce bugs in QEMU IDE. >> >> Signed-off-by: John Snow >> --- >> hw/ide/core.c | 12

Re: [Qemu-devel] [PATCH v4 4/5] hw/pci: add QEMU-specific PCI capability to the Generic PCI Express Root Port

2017-08-08 Thread Michael S. Tsirkin
On Tue, Aug 08, 2017 at 11:10:58PM +0300, Aleksandr Bezzubikov wrote: > 2017-08-08 22:54 GMT+03:00 Michael S. Tsirkin : > > On Sat, Aug 05, 2017 at 11:27:37PM +0300, Aleksandr Bezzubikov wrote: > >> To enable hotplugging of a newly created pcie-pci-bridge, > >> we need to tell

Re: [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-08 Thread John Snow
On 08/08/2017 04:00 PM, Eric Blake wrote: > On 08/08/2017 01:32 PM, John Snow wrote: >> Out with the old, in with the new. >> >> Signed-off-by: John Snow >> --- > >> hw/ide/piix.c | 11 >> hw/ide/trace-events | 33 >>

Re: [Qemu-devel] [PATCH v4 4/5] hw/pci: add QEMU-specific PCI capability to the Generic PCI Express Root Port

2017-08-08 Thread Aleksandr Bezzubikov
2017-08-08 22:54 GMT+03:00 Michael S. Tsirkin : > On Sat, Aug 05, 2017 at 11:27:37PM +0300, Aleksandr Bezzubikov wrote: >> To enable hotplugging of a newly created pcie-pci-bridge, >> we need to tell firmware (SeaBIOS in this case) > > Why SeaBIOS is this case? > It is the

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Philippe Mathieu-Daudé
On 08/08/2017 04:34 PM, Eric Blake wrote: On 08/08/2017 01:48 PM, Philippe Mathieu-Daudé wrote: +fd = openat_file(dirfd, name, O_RDONLY | O_PATH, 0); since you use O_PATH, you can drop O_RDONLY. Technically, POSIX says (and 'man 2 open' agrees, modulo the fact that Linux still lacks

Re: [Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread Eric Blake
On 08/08/2017 01:33 PM, John Snow wrote: > To be used sparingly, but still interesting in the case of small > firmwares designed to reproduce bugs in QEMU IDE. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 12 +++- > 1 file changed, 11 insertions(+), 1

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-08 Thread Michael S. Tsirkin
On Mon, Aug 07, 2017 at 09:52:24AM -0600, Alex Williamson wrote: > I wonder if it has something to do > with the link speed/width advertised on the switch port. I don't think > the endpoint can actually downshift the physical link, so lspci on the > host should probably still show the full

Re: [Qemu-devel] [PATCH 2/9] IDE: Add register hints to tracing

2017-08-08 Thread Eric Blake
On 08/08/2017 01:32 PM, John Snow wrote: > Name the registers for tracing purposes. > > Signed-off-by: John Snow > --- > hw/ide/core.c | 88 > + > hw/ide/trace-events | 4 +-- > 2 files changed, 70 insertions(+), 22

Re: [Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-08 Thread Eric Blake
On 08/08/2017 01:32 PM, John Snow wrote: > Out with the old, in with the new. > > Signed-off-by: John Snow > --- > hw/ide/piix.c | 11 > hw/ide/trace-events | 33 > hw/ide/via.c | 10 +++- Hmm - should we

Re: [Qemu-devel] [PATCH v4 4/5] hw/pci: add QEMU-specific PCI capability to the Generic PCI Express Root Port

2017-08-08 Thread Michael S. Tsirkin
On Sat, Aug 05, 2017 at 11:27:37PM +0300, Aleksandr Bezzubikov wrote: > To enable hotplugging of a newly created pcie-pci-bridge, > we need to tell firmware (SeaBIOS in this case) Why SeaBIOS is this case? > to reserve > additional buses or IO/MEM/PREF space for pcie-root-port. > Additional bus

Re: [Qemu-devel] [PATCH for-2.10 0/3] qdev/vfio: defer DEVICE_DEL to avoid races with libvirt

2017-08-08 Thread Alex Williamson
On Thu, 27 Jul 2017 12:50:42 +0100 "Daniel P. Berrange" wrote: > On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > > On 27 July 2017 at 02:30, Michael Roth wrote:

Re: [Qemu-devel] acpi-test: Warning! DSDT mismatch

2017-08-08 Thread Michael S. Tsirkin
On Tue, Aug 08, 2017 at 08:38:18PM +0200, Thomas Huth wrote: > On 08.08.2017 17:35, Michael S. Tsirkin wrote: > > On Tue, Aug 08, 2017 at 04:48:26PM +0200, Thomas Huth wrote: > >> On 05.08.2017 22:27, Aleksandr Bezzubikov wrote: > >>> Unmask previously masked SHPC feature in _OSC method. > >>> >

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Eric Blake
On 08/08/2017 01:48 PM, Philippe Mathieu-Daudé wrote: >> +fd = openat_file(dirfd, name, O_RDONLY | O_PATH, 0); > > since you use O_PATH, you can drop O_RDONLY. Technically, POSIX says (and 'man 2 open' agrees, modulo the fact that Linux still lacks O_SEARCH) that you MUST provide one of the

Re: [Qemu-devel] [PATCH 2/4] IDE: test flush on empty CDROM

2017-08-08 Thread John Snow
On 08/08/2017 03:20 PM, Eric Blake wrote: > On 08/08/2017 12:57 PM, John Snow wrote: >> From: Kevin Wolf >> >> Signed-off-by: Kevin Wolf >> Signed-off-by: John Snow >> --- >> tests/ide-test.c | 19 +++ >> 1 file changed,

Re: [Qemu-devel] [PATCH v4 5/5] docs: update documentation considering PCIE-PCI bridge

2017-08-08 Thread Aleksandr Bezzubikov
2017-08-08 18:11 GMT+03:00 Laszlo Ersek : > one comment below > > On 08/05/17 22:27, Aleksandr Bezzubikov wrote: > >> +Capability layout (defined in include/hw/pci/pci_bridge.h): >> + >> +uint8_t id; Standard PCI capability header field >> +uint8_t next; Standard

Re: [Qemu-devel] [PATCH 2/4] IDE: test flush on empty CDROM

2017-08-08 Thread Eric Blake
On 08/08/2017 12:57 PM, John Snow wrote: > From: Kevin Wolf > > Signed-off-by: Kevin Wolf > Signed-off-by: John Snow > --- > tests/ide-test.c | 19 +++ > 1 file changed, 19 insertions(+) > > +static void

Re: [Qemu-devel] [PATCH 1/4] IDE: Do not flush empty CDROM drives

2017-08-08 Thread Eric Blake
On 08/08/2017 12:57 PM, John Snow wrote: > The block backend changed in a way that flushing empty CDROM drives > is now an error. Amend IDE to avoid doing so until the root problem > can be addressed for 2.11. > > Reported-by: Kieron Shorrock > Signed-off-by: John

[Qemu-devel] [Bug 1357175] Re: qemu fails to build on powerpc64

2017-08-08 Thread Justin Hibbits
It looks like this has been fixed in the intervening 3 years. I just tried building head on FreeBSD/powerpc64, and was successful. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1357175 Title:

Re: [Qemu-devel] slirp: question about using SMB on windows host with linux guest

2017-08-08 Thread FONNEMANN Mark
Michael- OK, I was confused until reading your email but I have now been able to get it to work. Unfortunately, I find that it is *very* unreliable when trying to mount the share; It only works sometimes. See attached screenshot. Do you have any suggestions on how to fix this problem? I

[Qemu-devel] [Bug 1357175] Re: qemu fails to build on powerpc64

2017-08-08 Thread Justin Hibbits
It looks like this has been fixed in the intervening 3 years. I just tried building head on FreeBSD/powerpc64, and was successful. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1357175 Title:

Re: [Qemu-devel] [PATCH v5 10/17] migration: Create ram_multifd_page

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> "Dr. David Alan Gilbert" wrote: > >> > * Juan Quintela (quint...@redhat.com) wrote: > > ... > > >> > My feeling,

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Eric Blake
On 08/08/2017 12:28 PM, Greg Kurz wrote: > This function has to ensure it doesn't follow a symlink that could be used > to escape the virtfs directory. This could be easily achieved if fchmodat() > on linux honored the AT_SYMLINK_NOFOLLOW flag as described in POSIX, but > it doesn't. > > The

Re: [Qemu-devel] [PATCH] 9pfs: fix dependencies

2017-08-08 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Message-id: 20170808153827.427-1-coh...@redhat.com Subject: [Qemu-devel] [PATCH] 9pfs: fix dependencies Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with

Re: [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS

2017-08-08 Thread John Snow
On 08/08/2017 02:34 PM, Paolo Bonzini wrote: > > > - Original Message - >> From: "John Snow" >> To: qemu-bl...@nongnu.org >> Cc: kw...@redhat.com, qemu-devel@nongnu.org, dgilb...@redhat.com, >> stefa...@redhat.com, pbonz...@redhat.com, >> p...@redhat.com, "John

Re: [Qemu-devel] [for-2.10 PATCH] 9pfs: local: fix fchmodat_nofollow() limitations

2017-08-08 Thread Philippe Mathieu-Daudé
Hi Greg, is this also related to CVE-2016-9602? On 08/08/2017 02:28 PM, Greg Kurz wrote: This function has to ensure it doesn't follow a symlink that could be used to escape the virtfs directory. This could be easily achieved if fchmodat() on linux honored the AT_SYMLINK_NOFOLLOW flag as

Re: [Qemu-devel] [PATCH 3/4] block-backend: shift in-flight counter to BB from BDS

2017-08-08 Thread Paolo Bonzini
- Original Message - > From: "John Snow" > To: qemu-bl...@nongnu.org > Cc: kw...@redhat.com, qemu-devel@nongnu.org, dgilb...@redhat.com, > stefa...@redhat.com, pbonz...@redhat.com, > p...@redhat.com, "John Snow" > Sent: Tuesday, August 8, 2017

[Qemu-devel] [PATCH 6/9] AHCI: Replace DPRINTF with trace-events

2017-08-08 Thread John Snow
There are a few hangers-on that will be dealt with individually in forthcoming patches. Signed-off-by: John Snow --- hw/ide/ahci.c | 157 +++- hw/ide/trace-events | 52 - 2 files changed, 119 insertions(+),

[Qemu-devel] [PATCH 1/9] IDE: replace DEBUG_IDE with tracing system

2017-08-08 Thread John Snow
Out with the old, in with the new. Signed-off-by: John Snow --- Makefile.objs | 1 + hw/ide/cmd646.c | 10 +++- hw/ide/core.c | 65 +++ hw/ide/pci.c | 17 -

[Qemu-devel] [PATCH 2/9] IDE: Add register hints to tracing

2017-08-08 Thread John Snow
Name the registers for tracing purposes. Signed-off-by: John Snow --- hw/ide/core.c | 88 + hw/ide/trace-events | 4 +-- 2 files changed, 70 insertions(+), 22 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c

Re: [Qemu-devel] acpi-test: Warning! DSDT mismatch

2017-08-08 Thread Thomas Huth
On 08.08.2017 17:35, Michael S. Tsirkin wrote: > On Tue, Aug 08, 2017 at 04:48:26PM +0200, Thomas Huth wrote: >> On 05.08.2017 22:27, Aleksandr Bezzubikov wrote: >>> Unmask previously masked SHPC feature in _OSC method. >>> >>> Signed-off-by: Aleksandr Bezzubikov >>>

[Qemu-devel] [PATCH 8/9] AHCI: pretty-print FIS to buffer instead of stderr

2017-08-08 Thread John Snow
The current FIS printing routines dump the FIS to screen. adjust this such that it dumps to buffer instead, then use this ability to have FIS dump mechanisms via trace-events instead of compiled defines. Signed-off-by: John Snow --- hw/ide/ahci.c | 54

[Qemu-devel] [PATCH 5/9] IDE: replace DEBUG_AIO with trace events

2017-08-08 Thread John Snow
Signed-off-by: John Snow --- hw/ide/atapi.c| 5 + hw/ide/core.c | 17 ++--- hw/ide/trace-events | 3 +++ include/hw/ide/internal.h | 7 +-- 4 files changed, 19 insertions(+), 13 deletions(-) diff --git a/hw/ide/atapi.c

[Qemu-devel] [PATCH 7/9] AHCI: Rework IRQ constants

2017-08-08 Thread John Snow
Create a new enum so that we can name the IRQ bits, which will make debugging them a little nicer if we can print them out. Not handled in this patch, but this will make it possible to get a nice debug printf detailing exactly which status bits are set, as it can be multiple at any given time. As

[Qemu-devel] [PATCH 9/9] AHCI: remove DPRINTF macro

2017-08-08 Thread John Snow
Signed-off-by: John Snow --- hw/ide/ahci.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1a4d4db..ce2010c 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -34,17 +34,8 @@ #include "hw/ide/pci.h" #include

[Qemu-devel] [PATCH 4/9] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events

2017-08-08 Thread John Snow
Goodbye, printfs. Hello, fancy printfs. Signed-off-by: John Snow --- hw/ide/atapi.c| 64 +-- hw/ide/trace-events | 19 ++ include/hw/ide/internal.h | 1 - 3 files changed, 42 insertions(+), 42

[Qemu-devel] [PATCH 3/9] IDE: add tracing for data ports

2017-08-08 Thread John Snow
To be used sparingly, but still interesting in the case of small firmwares designed to reproduce bugs in QEMU IDE. Signed-off-by: John Snow --- hw/ide/core.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

  1   2   3   4   >