Re: [Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-16 Thread Dou Liyang
Hi Igor, I tested this patch with following guests: 1. RHEL 6.5 with Linux 2.6.32 2. RHEL 7.0 with Linux 3.10.0 3. Fedora 23 with Linux 4.13.0-rc5 4. window 2003 service 5. window 7 6. window 10 Thanks, dou. At 08/16/2017 09:45 AM, Dou Liyang wrote: Currently, Using the fisrt node

[Qemu-devel] [PATCH for-2.11] intel_iommu: fix missing BQL in pt fast path

2017-08-16 Thread Peter Xu
In vtd_switch_address_space() we did the memory region switch, however it's possible that the caller of it has not taken the BQL at all. Make sure we have it. CC: Paolo Bonzini CC: Jason Wang CC: Michael S. Tsirkin Signed-off-by: Peter

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-16 Thread Markus Armbruster
Markus Armbruster writes: [...] > Out of review brainpower for today. Hope to resume tomorrow. > > [...] Nope, I'm giving up on this one. Please split it for reviewability. Suggested split: 1. Preparatory refactoring for step 2, step by step 2. Frontend part: accept and

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-16 Thread Markus Armbruster
Lukáš Doktor writes: > Dne 16.8.2017 v 18:58 Markus Armbruster napsal(a): >> Lukáš Doktor writes: >> >>> Dne 15.8.2017 v 14:31 Markus Armbruster napsal(a): Lukáš Doktor writes: > No actual code changes, just several

[Qemu-devel] [FIX PATCH v1] spapr: Allow configure-connector to be called multiple times

2017-08-16 Thread Bharata B Rao
In case of in-kernel memory hot unplug, when the guest is not able to remove all the LMBs that are requested for removal, it will add back any LMBs that have been successfully removed. The DR Connectors of these LMBs wouldn't have been unconfigured and hence the addition of these LMBs will result

[Qemu-devel] [PATCH] hw/ppc/spapr_rtc: Mark the RTC device with user_creatable = false

2017-08-16 Thread Thomas Huth
QEMU currently aborts unexpectedly when a user tries to do something like this: $ qemu-system-ppc64 -nographic -S -nodefaults -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add spapr-rtc,id=spapr-rtc (qemu) device_del spapr-rtc **

Re: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

2017-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170817043102.6322-1-f4...@amsat.org Subject: [Qemu-devel] [PATCH 0/8] QOMify MIPS cpu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline

Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

2017-08-16 Thread Markus Armbruster
John Snow writes: > On 08/14/2017 05:57 PM, Eduardo Habkost wrote: >> Example output when using "-machine q35": >> >> { >> "available": true, >> "count": 1, >> "device-types": [ >> "ide-device" >> ], >> "hotpluggable": false, >> "opts": [ >>

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws

2017-08-16 Thread Markus Armbruster
John Snow writes: [...] > On 07/20/2017 03:53 AM, Markus Armbruster wrote: >> blockdev-add and migrate-set-parameters overload empty strings to mean >> something entirely different. See my memo "qapi: Stop abusing >> "special" values for something entirely different" for

[Qemu-devel] [PATCH 7/8] mips: replace cpu_mips_init() with cpu_generic_init()

2017-08-16 Thread Philippe Mathieu-Daudé
From: Igor Mammedov now cpu_mips_init() reimplements subset of cpu_generic_init() tasks, so just drop it and use cpu_generic_init() directly. Signed-off-by: Igor Mammedov Reviewed-by: Hervé Poussineau Signed-off-by: Philippe

[Qemu-devel] [PATCH 8/8] mips: update mips_cpu_list() to use object_class_get_list()

2017-08-16 Thread Philippe Mathieu-Daudé
while here, move it from translate_init.c to helper.c Signed-off-by: Philippe Mathieu-Daudé --- target/mips/helper.c | 46 target/mips/translate_init.c | 10 -- 2 files changed, 46 insertions(+), 10 deletions(-) diff

[Qemu-devel] [PATCH 4/8] mips: call cpu_mips_realize_env() from mips_cpu_realizefn()

2017-08-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 3 +++ target/mips/translate.c | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 68bf423e9d..e3ef835599 100644 --- a/target/mips/cpu.c +++

[Qemu-devel] [PATCH 5/8] mips: MIPSCPU model subclasses

2017-08-16 Thread Philippe Mathieu-Daudé
From: Igor Mammedov Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov Signed-off-by: Philippe Mathieu-Daudé [PMD: use internal.h, use

[Qemu-devel] [RFC PATCH 6/8] !fixup mips: now than MIPSCPU is QOMified, mark it abstract

2017-08-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index f99cfbde7e..84b6f8bf68 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -219,7 +219,7 @@ static

[Qemu-devel] [PATCH 3/8] mips: split cpu_mips_realize_env() out of cpu_mips_init()

2017-08-16 Thread Philippe Mathieu-Daudé
so it can be used in mips_cpu_realizefn() in the next commit Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 1 + target/mips/translate.c | 19 --- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/target/mips/internal.h

[Qemu-devel] [PATCH 2/8] mips: introduce internal.h and cleanup cpu.h

2017-08-16 Thread Philippe Mathieu-Daudé
no logical change, only code movement (and fix a comment typo). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.h| 354 + target/mips/internal.h | 362 +++

[Qemu-devel] [PATCH 1/8] mips: move hw/mips/cputimer.c to target/mips/

2017-08-16 Thread Philippe Mathieu-Daudé
This timer is a required part of the MIPS32/MIPS64 System Control coprocessor (CP0). Moving it with the other architecture related files will allow an opaque use of CPUMIPSState* in the next commit (introduce "internal.h"). also remove it from 'user' targets, remove an unnecessary include.

[Qemu-devel] [PATCH 0/8] QOMify MIPS cpu

2017-08-16 Thread Philippe Mathieu-Daudé
Hi, While working with the mips codebase I had to QOMify it. I then read Igor's series "complete cpu QOMification" [1] and after some IRC chat I suggested Igor to rebase his series on mine to avoid code moving forward then back. Since most of Igor's series is reviewed I'm posting this a week

[Qemu-devel] [PATCH] tests/docker: Clean up paths

2017-08-16 Thread Fam Zheng
The 'run' script already creats src, build and install directories under $TEST_DIR, use it in common.rc. Also the tests always run from $QEMU_SRC/tests/docker, so use a relative $CMD string. Signed-off-by: Fam Zheng --- tests/docker/common.rc | 5 + tests/docker/run

Re: [Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

2017-08-16 Thread Wanpeng Li
Cc Chandu, On 8/16/17 1:00 AM, Brijesh Singh wrote: > Add a new base CPU model called 'EPYC' to model processors from AMD EPYC > family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). > > The following features bits have been added/removed compare to Opteron_G5 > > Added: monitor, movbe,

Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses

2017-08-16 Thread Philippe Mathieu-Daudé
On 07/14/2017 10:51 AM, Igor Mammedov wrote: QOMfy cpu models handling introducing propper cpu types for each cpu model. Signed-off-by: Igor Mammedov --- with this and conversion of features to properties, it would be possible to replace cpu_sparc_init() with

Re: [Qemu-devel] [PATCH 02/28] mips: MIPSCPU model subclasses

2017-08-16 Thread Philippe Mathieu-Daudé
Hi Igor, On 07/15/2017 06:48 PM, Philippe Mathieu-Daudé wrote: On 07/14/2017 10:51 AM, Igor Mammedov wrote: Register separate QOM types for each mips cpu model, so it would be possible to reuse generic CPU creation routines. Signed-off-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-16 Thread Wei Wang
Add a new vq to report hints of guest free pages to the host. Signed-off-by: Wei Wang Signed-off-by: Liang Li --- drivers/virtio/virtio_balloon.c | 167 +++- include/uapi/linux/virtio_balloon.h | 1 + 2 files

[Qemu-devel] [PATCH v14 4/5] mm: support reporting free page blocks

2017-08-16 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. Signed-off-by: Wei

[Qemu-devel] [PATCH v14 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-16 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages are transferred to the host one by one. Here is

[Qemu-devel] [PATCH v14 2/5] lib/xbitmap: add xb_find_next_bit() and xb_zero()

2017-08-16 Thread Wei Wang
xb_find_next_bit() is used to find the next "1" or "0" bit in the given range. xb_zero() is used to zero the given range of bits. Signed-off-by: Wei Wang Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko

[Qemu-devel] [PATCH v14 0/5] Virtio-balloon Enhancement

2017-08-16 Thread Wei Wang
This patch series enhances the existing virtio-balloon with the following new features: 1) fast ballooning: transfer ballooned pages between the guest and host in chunks using sgs, instead of one by one; and 2) free_page_vq: a new virtqueue to report guest free pages to the host. The second

[Qemu-devel] [PATCH v14 1/5] lib/xbitmap: Introduce xbitmap

2017-08-16 Thread Wei Wang
From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits, and this commit adds the bare bones -- xb_set_bit(), xb_clear_bit() and xb_test_bit().

Re: [Qemu-devel] [PATCH v3 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-08-16 Thread Sam Bobroff
On Wed, Aug 16, 2017 at 02:41:59PM +0530, Aravinda Prasad wrote: > This series of patches adds support for FWNMI in PowerKVM guests. > > Memory error such as bit flips that cannot be corrected > by hardware is passed on to the kernel for handling > by raising machine check exception (an NMI).

Re: [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-16 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170817024746.5961-1-f...@redhat.com Subject: [Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH RFC v2 09/10] Makefile: Add rules to run vm tests

2017-08-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 41 + 3 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 tests/vm/Makefile.include diff --git

[Qemu-devel] [PATCH RFC v2 06/10] tests: Add FreeBSD image

2017-08-16 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vm/freebsd diff --git

[Qemu-devel] [PATCH RFC v2 05/10] tests: Add ubuntu.i386 image

2017-08-16 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+) create mode 100755

[Qemu-devel] [PATCH RFC v2 10/10] MAINTAINERS: Add tests/vm entry

2017-08-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b12d..0ed607d003 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1881,6 +1881,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: tests/docker/

[Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-16 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the

[Qemu-devel] [PATCH RFC v2 08/10] tests: Add OpenBSD image

2017-08-16 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 46 ++ 1 file changed, 46 insertions(+) create mode 100755 tests/vm/openbsd diff --git

[Qemu-devel] [PATCH RFC v2 07/10] tests: Add NetBSD image

2017-08-16 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/netbsd | 45 + 1 file changed, 45 insertions(+) create mode 100755 tests/vm/netbsd diff --git

[Qemu-devel] [PATCH RFC v2 01/10] gitignore: Ignore vm test images

2017-08-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..693e2f3009 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,8 @@ /vscclient /vhost-user-scsi /fsdev/virtfs-proxy-helper

[Qemu-devel] [PATCH RFC v2 03/10] qemu.py: Add "wait()" method

2017-08-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index e5f314efdb..20c9cd6139 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -144,6 +144,13 @@ class QEMUMachine(object):

[Qemu-devel] [PATCH RFC v2 02/10] qemu.py: Add variable vga type

2017-08-16 Thread Fam Zheng
Some guests behave differently when no VGA is detected. Add a variable to allow override the "none" default. Signed-off-by: Fam Zheng --- scripts/qemu.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/qemu.py b/scripts/qemu.py index

[Qemu-devel] [PATCH RFC v2 00/10] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-08-16 Thread Fam Zheng
v2: - Add docstring. [Stefan] - Call self._load_io_lod. [Stefan] - Use "info usernet" and dynamic ssh_port forwarding. [Stefan] - Add image checksum. - Use os.rename() and os.makedirs(). [Stefan] - Fix NetBSD URL. [Kamil] Build tests in one 32 bit Linux guest and three BSD

Re: [Qemu-devel] [PATCHv3 00/02] Replace the COLO comparing thread with IOThread

2017-08-16 Thread Zhang Chen
On 08/16/2017 05:14 PM, Wang yong wrote: From: Wang Yong Note: This series is based on the patch of "qemu-iothread: IOThread supports theGMainContext event loop". You'd better put the patch on this patch set, make it easy to review. Thanks Zhang Chen It's a

Re: [Qemu-devel] [PATCH v3 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-08-16 Thread David Gibson
What's with the extra spaces in the subject line? On Wed, Aug 16, 2017 at 02:42:21PM +0530, Aravinda Prasad wrote: > This patch adds support in QEMU to handle "ibm,nmi-register" > and "ibm,nmi-interlock" RTAS calls. > > The machine check notification address is saved when the > OS issues

Re: [Qemu-devel] [PATCH v3 5/5] ppc: spapr: Enable FWNMI capability

2017-08-16 Thread David Gibson
On Wed, Aug 16, 2017 at 02:42:48PM +0530, Aravinda Prasad wrote: > Enable the KVM capability KVM_CAP_PPC_FWNMI so that > the KVM causes guest exit with NMI as exit reason > when it encounters a machine check exception on the > address belonging to a guest. Without this capability > enabled, KVM

Re: [Qemu-devel] [PATCH v3 4/5] target/ppc: Handle NMI guest exit

2017-08-16 Thread David Gibson
On Wed, Aug 16, 2017 at 02:42:39PM +0530, Aravinda Prasad wrote: > Memory error such as bit flips that cannot be corrected > by hardware are passed on to the kernel for handling. > If the memory address in error belongs to guest then > guest kernel is responsible for taking suitable action. >

[Qemu-devel] 答复: Re: [PATCHv3 00/02] Replace the COLO comparing thread with IOThread

2017-08-16 Thread wang.yong155
>> From: Wang Yong >> >> Note: This series is based on >> the patch of "qemu-iothread: >> IOThread supports theGMainContext event >> loop".>The syntax for patchew to pick up the dependency automatically: >Based-on:

Re: [Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-16 Thread Lan Tianyu
On 2017年08月16日 19:21, Paolo Bonzini wrote: > On 16/08/2017 02:22, Lan Tianyu wrote: >> Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU >> check for Xen here when vcpu number is more than 255. > > I think you still need to do a check for vIOMMU being enabled. Yes, this will be done

Re: [Qemu-devel] [PATCH v3 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-08-16 Thread David Gibson
On Wed, Aug 16, 2017 at 02:42:13PM +0530, Aravinda Prasad wrote: > Receive updates from SLOF about the updated rtas-base. > A separate patch for SLOF [1] adds functionality to invoke > a private HCALL whenever OS issues instantiate-rtas with > a new rtas-base. > > This is required as QEMU needs

Re: [Qemu-devel] [FIX PATCH v0] spapr: Allow configure-connector to be called multiple times for LMBs

2017-08-16 Thread David Gibson
On Wed, Aug 16, 2017 at 05:05:36PM +0530, Bharata B Rao wrote: > In case of in-kernel memory hot unplug, when the guest is not able > to remove all the LMBs that are requested for removal, it will add back > any LMBs that have been successfully removed. The DR Connectors of > these LMBs wouldn't

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-08-16 Thread George Kraft
I think I hit this problem trying to use qemu-s390x-static in the s390x/ubuntu:16.04 docker image. Running qemu-s390x-static 2.9.0 on binaries in that image (e.g. /bin/echo) results in a hang. I've noticed that doing the same in a s390x/debian:jessie image does NOT have the same problem. No hang.

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-16 Thread G 3
On Aug 15, 2017, at 6:27 PM, Paolo Bonzini wrote: On 15/08/2017 20:46, Programmingkid wrote: On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: On 13/08/2017 21:13, Programmingkid wrote: Lately I found out that Windows NT 4.0 seems to work well with the 486 and

Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

2017-08-16 Thread John Snow
On 08/14/2017 05:57 PM, Eduardo Habkost wrote: > Example output when using "-machine q35": > > { > "available": true, > "count": 1, > "device-types": [ > "ide-device" > ], > "hotpluggable": false, > "opts": [ > { "option": "unit", "values": 0 }, > {

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws

2017-08-16 Thread John Snow
On 08/16/2017 05:41 PM, Eric Blake wrote: > On 08/16/2017 04:34 PM, John Snow wrote: >> Looks like this series got no replies (maybe a failure of my mail >> filtering?) but it has since been merged, so purely for my own selfish >> purposes; > > No replies to v2 due to the fact that the

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws

2017-08-16 Thread Eric Blake
On 08/16/2017 04:34 PM, John Snow wrote: > Looks like this series got no replies (maybe a failure of my mail > filtering?) but it has since been merged, so purely for my own selfish > purposes; No replies to v2 due to the fact that the differences from v1 were trivial enough to keep R-b from that

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] tests/multiboot: Fix whitespace failure

2017-08-16 Thread John Snow
No replies that I can see, but merged as: 01a02ec4f6b6a12df7acfb6ad820b384b48cbf70 tests/multiboot: Fix whitespace failure Thanks On 08/08/2017 10:34 AM, Eric Blake wrote: > Commit b43671f8 accidentally broke run_test.sh within tests/multiboot; > due to a subtle change in whitespace. > > These

[Qemu-devel] [Bug 1576347] Re: Only one NVMe device is usable in Windows (10) guest

2017-08-16 Thread Sergey Blagodurov
Trying it on Windows 10 guest and QEMU 2.8.0 has the same issue. However, I noticed that: Supplying 1 NVMe drive -> Win10 sees it. Supplying 2 NVMe drives -> Win10 sees only one of them. Supplying 3 NVMe drives -> Win10 sees only two of them. So I still have been able to create a ReFS

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/10] Correct two minor QMP interface design flaws

2017-08-16 Thread John Snow
Looks like this series got no replies (maybe a failure of my mail filtering?) but it has since been merged, so purely for my own selfish purposes; Merged upstream as: 01fa55982692fb51a16049b63b571651a1053989 migration: Use JSON null instead of "" to reset parameter to default

Re: [Qemu-devel] [PATCH 26/28] openrisc: replace cpu_openrisc_init() with cpu_generic_init()

2017-08-16 Thread Stafford Horne
On Fri, Jul 14, 2017 at 03:52:17PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov > --- > CC: Jia Liu > CC: Stafford Horne > --- > target/openrisc/cpu.h

Re: [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing

2017-08-16 Thread Eric Blake
On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: > A bit more refactoring and fixing before BLOCK_STATUS series. > I've tried to make individual patches simple enough, so there are > a lot of them. Is your BLOCK_STATUS series something that is in good enough shape to post a preliminary

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] Add shrink image for qcow2

2017-08-16 Thread John Snow
Over a month with no replies and we're nearing the next QEMU release. If this patchset is still applicable, can you rebase and resend for 2.11? --js On 07/14/2017 11:37 AM, Pavel Butsykin wrote: > This patch add shrinking of the image file for qcow2. As a result, this allows > us to reduce the

Re: [Qemu-devel] [Qemu-block] [PATCH v5 00/25] block: Fix some filename generation issues

2017-08-16 Thread John Snow
Bump for 2.11; I assume this needs to be rebased and resent, yes? On 06/21/2017 08:50 AM, Max Reitz wrote: > [If you have read the cover letter in x \in [v2, v4], there is nothing > new here; feel free to skip to the bottom to read the changes from v4.] > > There are some issues regarding

Re: [Qemu-devel] [PATCH RFC 4/9] tests: Add vm test lib

2017-08-16 Thread Fam Zheng
On Wed, 08/16 09:55, Stefan Hajnoczi wrote: > On Wed, Aug 16, 2017 at 03:20:59PM +0800, Fam Zheng wrote: > > +class BaseVM(object): > > +GUEST_USER = "qemu" > > +GUEST_PASS = "qemupass" > > +ROOT_PASS = "qemupass" > > + > > +# The script to run in the guest that builds QEMU > > +

Re: [Qemu-devel] [PATCH RFC 3/9] qemu.py: Add "wait()" method

2017-08-16 Thread Fam Zheng
On Wed, 08/16 09:32, Stefan Hajnoczi wrote: > On Wed, Aug 16, 2017 at 03:20:58PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/qemu.py | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/scripts/qemu.py b/scripts/qemu.py > > index

Re: [Qemu-devel] [PATCH v5 0/8] KASLR kernel dump support

2017-08-16 Thread Michael S. Tsirkin
On Mon, Aug 07, 2017 at 08:16:10PM +0200, Marc-André Lureau wrote: > Recent linux kernels enable KASLR to randomize phys/virt memory > addresses. This series aims to provide enough information in qemu > dumps so that crash utility can work with randomized kernel too (it > hasn't been tested on

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] block: use internal filter node in backup

2017-08-16 Thread Manos Pitsidianakis
On Wed, Aug 16, 2017 at 02:25:44PM +0100, Stefan Hajnoczi wrote: On Tue, Aug 15, 2017 at 11:18:53AM +0300, Manos Pitsidianakis wrote: block/backup.c currently uses before write notifiers on the targeted node. We can create a filter node instead to intercept write requests for the backup job on

Re: [Qemu-devel] [PATCH 28/28] ppc: replace cpu_ppc_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:19PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 24/28] lm32: replace cpu_lm32_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:15PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 26/28] openrisc: replace cpu_openrisc_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:17PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 27/28] unicore32: replace uc32_cpu_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:18PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 25/28] moxie: replace cpu_moxie_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:16PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 23/28] x86: replace cpu_x86_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:14PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 20/28] sh4: replace cpu_sh4_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:11PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 22/28] cris: replace cpu_cris_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:13PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 19/28] tricore: replace cpu_tricore_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:10PM +0200, Igor Mammedov wrote: > it's just a wrapper, drop it and use cpu_generic_init() directly > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 18/28] xtensa: replace cpu_xtensa_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:09PM +0200, Igor Mammedov wrote: > call xtensa_irq_init() at realize time which makes > cpu_xtensa_init() like generic cpu creation function. > As result we can replace it with cpu_generic_init() > which does the same job, reducing code duplication a bit. > >

Re: [Qemu-devel] [PATCH 17/28] tilegx: replace cpu_tilegx_init() with cpu_generic_init()

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:52:08PM +0200, Igor Mammedov wrote: > cpu_tilegx_init() always falls back to TYPE_TILEGX_CPU object > regardless of cpu_model. Put fallback logic into > tilegx_cpu_class_by_name() which would translate any cpu_model > into TYPE_TILEGX_CPU class and replace

Re: [Qemu-devel] [PATCH 08/28] x86: extract legacy cpu features format parser

2017-08-16 Thread Eduardo Habkost
On Fri, Jul 14, 2017 at 03:51:59PM +0200, Igor Mammedov wrote: > Move cpu_model +-feat parsing into a separate file so that it > could be reused later for parsing similar format of sparc target > > Signed-off-by: Igor Mammedov > --- > CC: Riku Voipio >

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Markus Armbruster
Eric Blake writes: > On 08/16/2017 11:13 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> > >>> >>> Conclusion: no consensus, yet. >> >> All right, let's start over and try to resolve the impasse and/or >> misunderstanding. >> >> Type

Re: [Qemu-devel] [PATCH v6 3/3] hmp: introduce 'info memory_size_summary' command

2017-08-16 Thread Dr. David Alan Gilbert
* Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: > This command is an equivalent of QMP command query-memory-size-summary. > It provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * plugged-memory -

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-16 Thread Lukáš Doktor
Dne 16.8.2017 v 18:58 Markus Armbruster napsal(a): > Lukáš Doktor writes: > >> Dne 15.8.2017 v 14:31 Markus Armbruster napsal(a): >>> Lukáš Doktor writes: >>> No actual code changes, just several pylint/style fixes and docstring clarifications.

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Eric Blake
On 08/16/2017 11:13 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> >> Conclusion: no consensus, yet. > > All right, let's start over and try to resolve the impasse and/or > misunderstanding. > > Type BlockIOThrottle lives in qapi/block-core.json, and is used

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-16 Thread Markus Armbruster
Lukáš Doktor writes: > Dne 15.8.2017 v 14:31 Markus Armbruster napsal(a): >> Lukáš Doktor writes: >> >>> No actual code changes, just several pylint/style fixes and docstring >>> clarifications. >>> >>> Signed-off-by: Lukáš Doktor

Re: [Qemu-devel] [PATCH v6 18/19] migration: Transfer pages over new channels

2017-08-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We switch for sending the page number to send real pages. > > Signed-off-by: Juan Quintela > > -- > > Remove the HACK bit, now we have the function that calculates the size > of a page exported. > --- > migration/migration.c

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-16 Thread G 3
On Aug 15, 2017, at 6:27 PM, Paolo Bonzini wrote: On 15/08/2017 20:46, Programmingkid wrote: On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: On 13/08/2017 21:13, Programmingkid wrote: Lately I found out that Windows NT 4.0 seems to work well with the 486 and

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote: >> > It's not "moving it back", it's keeping it where it is. But I see no big > problem with moving it to a common file either. I'd rather

[Qemu-devel] [PATCH v2 3/3] Add new functions for whitelisting and their calls

2017-08-16 Thread dverma
The 'check_updated_properties' function keeps track of properties that were added/removed from fields across qemu versions. The 'check_updated_sizes' function reduces false positives generated especially while testing backward migration by keeping a list of common size/version changes. The

[Qemu-devel] [PATCH v2 2/3] Update the existing whitelist

2017-08-16 Thread dverma
Appended newer fields and introduced new names in the whitelist Changes v1->v2: 1. Fix patchew warnings about exceeding 80 characters Signed-off-by: Deepak Verma --- scripts/vmstate-static-checker.py | 22 -- 1 file changed, 20 insertions(+), 2

[Qemu-devel] [PATCH v2 1/3] Fix format and styles; make code more pythonic

2017-08-16 Thread dverma
- Format fixes, cleaned up the print statement - Style fixes, e.g. changed "if not x in y" to "if x not in y" - Improved variable names Changes v1->v2: 1. Fix patchew warnings about exceeding 80 characters Signed-off-by: Deepak Verma --- scripts/vmstate-static-checker.py |

[Qemu-devel] [PATCH v2 0/3] Vmstate-static-checker.py fix upstream

2017-08-16 Thread dverma
This is an update to the script vmstate-static-checker.py. The whitelist has been updated and newer functions have been added to reduce the false positives generated by the script while testing migration. The code has been cleaned and updated to follow PEP8 guidelines. Changes v1->v2: 1. Fix

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-16 Thread Lukáš Doktor
Dne 15.8.2017 v 14:31 Markus Armbruster napsal(a): > Lukáš Doktor writes: > >> No actual code changes, just several pylint/style fixes and docstring >> clarifications. >> >> Signed-off-by: Lukáš Doktor >> --- >> scripts/qemu.py | 76 >>

Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

2017-08-16 Thread Marc-André Lureau
Hi - Original Message - > On 08/02/2017 05:07 PM, Marc-André Lureau wrote: > > >> > >> Rather than leave this untested time-bomb in place, rip it out. > > >> > >> Signed-off-by: Eric Blake > > > > I think it used to work in a vm (as qemu-ga user), but I don't mind

Re: [Qemu-devel] [PATCH] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

2017-08-16 Thread Eric Blake
On 08/02/2017 05:07 PM, Marc-André Lureau wrote: >> >> Rather than leave this untested time-bomb in place, rip it out. >> >> Signed-off-by: Eric Blake > > I think it used to work in a vm (as qemu-ga user), but I don't mind to revert > it if we need it back: > >

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-16 Thread Markus Armbruster
Marc-André Lureau writes: > Add 'if' c-preprocessor condition on top-level schema elements: > struct, enum, union, alternate, command, event. An example would be useful here. Your cover letter has nice ones, would be a shame not to preserve them for posterity in

Re: [Qemu-devel] [PATCH] hw/watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable

2017-08-16 Thread Cornelia Huck
On Wed, 16 Aug 2017 16:08:48 +0200 Thomas Huth wrote: > QEMU currently aborts when the user tries to hot-unplug a diag288 > device: > > $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio > QEMU 2.9.92 monitor - type 'help' for more information > (qemu) device_add

[Qemu-devel] [PATCH] hw/watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable

2017-08-16 Thread Thomas Huth
QEMU currently aborts when the user tries to hot-unplug a diag288 device: $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add diag288,id=x (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-16 Thread Richard Henderson
On 08/16/2017 01:26 AM, Cornelia Huck wrote: > Prefer to use the tcg accelarator if it is available: This is our only > real smoke test for tcg, and fast enough to use it for that. > > Fixes: 480bc11e6 ("boot-serial-test: fallback to kvm accelerator") > Reported-by: Richard Henderson

Re: [Qemu-devel] [PATCH 2/2] backup: QEMU Backup Tool

2017-08-16 Thread Stefan Hajnoczi
On Fri, Aug 11, 2017 at 06:34:00PM +0530, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and > incremental disk backups on running VMs. It is intended as a > reference implementation for management stack and backup developers > to see QEMU's backup features in

Re: [Qemu-devel] Crash when deleting the diag288 watchdog

2017-08-16 Thread Cornelia Huck
On Wed, 16 Aug 2017 15:36:42 +0200 Thomas Huth wrote: > On 16.08.2017 11:23, Cornelia Huck wrote: > > On Wed, 16 Aug 2017 07:05:37 +0200 > > Thomas Huth wrote: > > > >> Hi, > >> > >> I recently noticed that QEMU abort()s if you try to remove the diag288 >

Re: [Qemu-devel] [PATCH 1/2] Add manpage for QEMU Backup Tool

2017-08-16 Thread Stefan Hajnoczi
On Fri, Aug 11, 2017 at 06:33:59PM +0530, Ishani Chugh wrote: > +@item qemu-backup guest add --guest guestname --qmp socketpath [--tcp] Is --tcp still necessary? I thought you decided to use unix:/tcp: socketpath syntax. signature.asc Description: PGP signature

Re: [Qemu-devel] Crash when deleting the diag288 watchdog

2017-08-16 Thread Thomas Huth
On 16.08.2017 11:23, Cornelia Huck wrote: > On Wed, 16 Aug 2017 07:05:37 +0200 > Thomas Huth wrote: > >> Hi, >> >> I recently noticed that QEMU abort()s if you try to remove the diag288 >> watchdog. For example: >> >> $ qemu-system-s390x -nographic -nodefaults -S -monitor

  1   2   >