Re: [Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

2017-09-05 Thread Daniel P. Berrange
On Tue, Sep 05, 2017 at 11:52:15AM +0200, Kevin Wolf wrote: > Am 31.08.2017 um 13:05 hat Daniel P. Berrange geschrieben: > > Signed-off-by: Daniel P. Berrange > > --- > > block/crypto.c | 32 > > 1 file changed, 16 insertions(+), 16 deletions(-) > > I'm actually

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: blacklist 194 with the luks driver

2017-09-05 Thread Stefan Hajnoczi
On Fri, Sep 01, 2017 at 11:54:34AM +0100, Daniel P. Berrange wrote: > The 194 test has alot of code that assumes a simple image file. Rewriting > this to work with luks is possible, but non-trivial, so blacklist the > luks format for now. > > Signed-off-by: Daniel P. Berrange > --- > tests/qemu-

Re: [Qemu-devel] [PATCH v6 13/29] libqos: Use explicit QTestState for pci operations

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > Now that the QPCIBus tracks QTestState, use that state instead > of an implicit reliance on global_qtest. > > Signed-off-by: Eric Blake > --- > tests/libqos/pci-pc.c| 47 --- > tests/libqos/pci-spapr.c | 20

Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups

2017-09-05 Thread Stefan Hajnoczi
On Fri, Sep 01, 2017 at 01:28:16PM +0200, Amador Pahim wrote: Please update the patches with Reviewed-bys from past revisions so I know which patches I've already reviewed. If someone has posted a R-b then it should be included in the next revision unless you substantially modify that patch. Tha

Re: [Qemu-devel] [PATCH v6 10/29] libqtest: Topologically sort functions

2017-09-05 Thread Markus Armbruster
Thomas Huth writes: > On 01.09.2017 20:03, Eric Blake wrote: >> Put static functions prior to public ones, in part so that >> improvements to qtest_start() can benefit from the static >> helpers without needing forward references. Code motion, with >> no semantic change. >> >> Signed-off-by: Er

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

2017-09-05 Thread Thomas Huth
On 05.09.2017 11:53, Markus Armbruster wrote: > Thomas Huth writes: > >> On 01.09.2017 20:03, Eric Blake wrote: >>> It doesn't matter if things are unsorted, but finding stuff in a list >>> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than >>> en_US.UTF-8). >>> >>> Signed-of

Re: [Qemu-devel] [PATCH 1/1] block: add block device shared field

2017-09-05 Thread Stefan Hajnoczi
On Fri, Sep 01, 2017 at 08:10:54PM +, Brian Steffens wrote: > This adds a boolean option called 'shared' to block devices. It defaults > to off/false. When enabled for a particular block device, the 'shared' option > causes the block migration code to skip over syncing of that device. This > al

[Qemu-devel] [RFC PATCH] tests: Add a device_add/del HMP test

2017-09-05 Thread Thomas Huth
People tend to forget to mark internal devices with "user_creatable = false or hotpluggable = false, and these devices can crash QEMU if added via the HMP monitor. So let's add a test to run through all devices and that tries to add them blindly (without arguments) to see whether this could crash t

Re: [Qemu-devel] [PATCH v6 08/29] libqtest: Let socket_send() compute length

2017-09-05 Thread Markus Armbruster
Thomas Huth writes: > On 01.09.2017 20:03, Eric Blake wrote: >> Rather than make multiple callers call strlen(), it's easier if >> socket_send() itself can compute a length via strlen() if none >> was provided (caller passes -1). Callers that can get at the >> length more efficiently are left th

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

2017-09-05 Thread Markus Armbruster
Thomas Huth writes: > On 01.09.2017 20:03, Eric Blake wrote: >> It doesn't matter if things are unsorted, but finding stuff in a list >> is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than >> en_US.UTF-8). >> >> Signed-off-by: Eric Blake >> --- >> tests/.gitignore | 30

Re: [Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 10:37, Peter Maydell wrote: > and test-listen fails on my x86-64 Linux box: OpenBSD fails too, but only starting at thread 124, and it fails like this for all the tests whereas Linux only failed on the ipv6 test: TEST: tests/test-listen... (pid=12010) /socket/listen-seri

Re: [Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

2017-09-05 Thread Kevin Wolf
Am 31.08.2017 um 13:05 hat Daniel P. Berrange geschrieben: > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 32 > 1 file changed, 16 insertions(+), 16 deletions(-) I'm actually not sure about this one. Anything that is left after patch 3 is probably n

Re: [Qemu-devel] [PATCH v2 3/3] s390x/pci: add iommu replay callback

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午5:28, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:58 +0200 Yi Min Zhao wrote: Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaningless loops calli

Re: [Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05

2017-09-05 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/berrange/qemu tags/pull-qio-20170905-1 > > for you to fetch changes up to 33fb97121573985b4a57306b8abdb9dd992061fa: > > io: fix check for handshake com

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 11:34 AM, Alberto Garcia wrote: On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote: a) Declare an Error, pass it _and then handle it_ (if you don't handle it, you're leaking it): Here you have no other way to know if qmp_query_fsdev_io_throttle() fails, so you should ch

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Alberto Garcia
On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote: >> a) Declare an Error, pass it _and then handle it_ (if you don't >>handle it, you're leaking it): >> >> Here you have no other way to know if qmp_query_fsdev_io_throttle() >> fails, so you should choose (a). >> > OK, I will pass NU

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 10:35, Philippe Mathieu-Daudé wrote: > I'm not sure this kind of mistake happens often enough, but it might worth > add a such test in checkpatch.pl (easier to say than to implement :p) It doesn't run automatically, but you can run scripts/clean-includes on your new files t

Re: [Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05

2017-09-05 Thread Daniel P. Berrange
ags/x86-and-machine-pull-request' into staging > > (2017-09-01 17:28:54 +0100) > > > > are available in the git repository at: > > > > git://github.com/berrange/qemu tags/pull-qio-20170905-1 > > > > for you to fetch changes up to 33fb97121573985b4a

Re: [Qemu-devel] [PATCH v2 19/54] qapi: add #if/#endif helpers

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > Add helpers to generate #if/#endif and wrap visitor methods generating > code. Used in the following patches. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi.py | 51 +++ > 1 file changed, 51 insertions(+) > >

Re: [Qemu-devel] [PATCH v2 20/54] qapi-introspect: modify to_qlit() to take an optional suffix

2017-09-05 Thread Markus Armbruster
Marc-André Lureau writes: > The following patch is going to break list entries with #if/#endif, so > they should have the trailing ',' as suffix. > > Signed-off-by: Marc-André Lureau > --- > scripts/qapi-introspect.py | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --gi

[Qemu-devel] [PATCH 2/2] i386/cpu/hyperv: support over 64 vcpus for windows guests

2017-09-05 Thread Gonglei
Starting with Windows Server 2012 and Windows 8, if CPUID.4005.EAX contains a value of -1, Windows assumes specific limit to the number of VPs. In this case, Windows Server 2012 guest VMs may use more than 64 VPs, up to the maximum supported number of processors applicable to the specific Windo

Re: [Qemu-devel] [PATCH v4] block: document semantics of bdrv_co_preadv|pwritev

2017-09-05 Thread Kevin Wolf
Am 31.08.2017 um 12:54 hat Daniel P. Berrange geschrieben: > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Eric Blake > Signed-off-by: Daniel P. Berrange Thanks, applied to the block branch. Kevin

[Qemu-devel] [PULL v1 0/2] Merge QEMU crypto 2017/09/05

2017-09-05 Thread Daniel P. Berrange
ll-qcrypto-20170905-1 for you to fetch changes up to 23c1595b0297e6ca8f37559af6f0b8533aa1fd99: crypto: fix test cert generation to not use SHA1 algorithm (2017-09-04 10:45:19 +0100) Merge QEMU crypto 201

[Qemu-devel] [Bug 1714750] Re: 2.10.0 cannot be installed on case-insensitive file system

2017-09-05 Thread ilovezfs
Thanks for taking care of that @ubuntu-weilnetz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1714750 Title: 2.10.0 cannot be installed on case-insensitive file system Status in QEMU: New Bug d

[Qemu-devel] [PATCH 0/2] Support over 64 vcpus for windows guests

2017-09-05 Thread Gonglei
Pls see the detail of patches. Gonglei (2): pc: add 2.11 machine type i386/cpu/hyperv: support over 64 vcpus for windows guests hw/i386/pc_piix.c| 15 --- hw/i386/pc_q35.c | 13 +++-- include/hw/i386/pc.h | 8 target/i386/cpu.c| 1 + target/i386/cpu

Re: [Qemu-devel] [PULL] qemu-sparc updates

2017-09-05 Thread Peter Maydell
On 4 September 2017 at 18:51, Mark Cave-Ayland wrote: > Hi Peter, > > Here is the first patchset in preparation for updating the sun4u machine PCI > topology. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 2b483739791b33c46e6084b51edcf62107058ae1: > > Merge remote-tr

Re: [Qemu-devel] [PATCH v6 12/29] libqos: Track QTestState with QPCIBus

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > When initializing a QPCIBus, track which QTestState the bus is > associated with (so that a later patch can then explicitly use > that test state for all communication on the bus, rather than > blindly relying on global_qtest). Update the initialization > f

[Qemu-devel] [PATCH 1/2] pc: add 2.11 machine type

2017-09-05 Thread Gonglei
CC: "Michael S. Tsirkin" CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost Signed-off-by: Gonglei --- hw/i386/pc_piix.c| 15 --- hw/i386/pc_q35.c | 13 +++-- include/hw/i386/pc.h | 3 +++ 3 files changed, 26 insertions(+), 5 deletions(-) diff --git a/hw

Re: [Qemu-devel] [PATCH 1/2] iotests: rewrite 192 to use _launch_qemu to fix LUKS support

2017-09-05 Thread Kevin Wolf
Am 01.09.2017 um 16:22 hat Eric Blake geschrieben: > On 09/01/2017 05:54 AM, Daniel P. Berrange wrote: > > The LUKS driver requires extra args to QEMU to setup passwords. > > The _launch_qemu function takes care of this, so convert the > > test to use this function and use correct -drive syntax > >

Re: [Qemu-devel] [PATCH v3 00/14] add support for Hypervisor.framework in QEMU

2017-09-05 Thread Stefan Hajnoczi
On Mon, Sep 04, 2017 at 10:59:43PM -0500, Sergio Andrés Gómez del Real wrote: > This patchset didn't address every issue, so it won't be the definite > version. This series is fairly large and I don't want to review the same unresolved issues multiple times. I'll skip this revision and review aga

Re: [Qemu-devel] [PATCH 03/11] hw/misc: add missing includes

2017-09-05 Thread Philippe Mathieu-Daudé
On 05/08/2017 08:56 PM, Eric Blake wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/unimp.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/hw/misc/unimp.h b/include/hw/misc/unimp.h index 3462d85836..353ee19abf 100644 --- a/include/hw/misc/unimp.h +++ b/include/

[Qemu-devel] [PULL v1 2/2] crypto: fix test cert generation to not use SHA1 algorithm

2017-09-05 Thread Daniel P. Berrange
GNUTLS 3.6.0 marked SHA1 as untrusted for certificates. Unfortunately the gnutls_x509_crt_sign() method we are using to create certificates in the test suite is fixed to always use SHA1. We must switch to a different method and explicitly ask for SHA256. Reviewed-by: Eric Blake Signed-off-by: Dan

Re: [Qemu-devel] [PATCH v2 2/3] s390x/pci: fixup ind_offset of msix routing entry

2017-09-05 Thread Cornelia Huck
On Fri, 1 Sep 2017 06:22:57 +0200 Yi Min Zhao wrote: > The guest uses the mpcifc instruction to register the aibvo of a zpci > device, which is the starting offset of indicators in the indicator > area and thus remains constant. Each msix vector is an offset from the > aibvo. When we map a msix

[Qemu-devel] [PULL v1 8/9] io: add new qio_channel_{readv, writev, read, write}_all functions

2017-09-05 Thread Daniel P. Berrange
These functions wait until they are able to read / write the full requested data buffer(s). Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/channel.h | 90 +++ io/channel.c | 94 ++

[Qemu-devel] [PULL v1 1/2] tests: fix incorrect size_t format in benchmark-crypto

2017-09-05 Thread Daniel P. Berrange
From: Philippe Mathieu-Daudé $ make check-speed tests/benchmark-crypto-hash.c: In function 'test_hash_speed': tests/benchmark-crypto-hash.c:44:5: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t' [-Werror=format=] g_print("Testing chunk_size %

Re: [Qemu-devel] [PATCH v2 3/3] s390x/pci: add iommu replay callback

2017-09-05 Thread Cornelia Huck
On Fri, 1 Sep 2017 06:22:58 +0200 Yi Min Zhao wrote: > Let's introduce iommu replay callback for s390 pci iommu memory region. > Currently we don't need any dma mapping replay. So let it return > directly. This implementation will avoid meaningless loops calling > translation callback. > > Revi

Re: [Qemu-devel] [PATCH v6 11/29] libqtest: Inline qtest_query_target_endianness()

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > There was only one caller; it's easier to inline things. > > Signed-off-by: Eric Blake > --- > tests/libqtest.c | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 5

[Qemu-devel] [PULL v1 5/9] sockets: Handle race condition between binds to the same port

2017-09-05 Thread Daniel P. Berrange
From: Knut Omang If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 17:21:52 +0800 Yi Min Zhao wrote: > 在 2017/9/5 下午5:15, Cornelia Huck 写道: > > On Tue, 5 Sep 2017 17:08:14 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/9/5 下午4:50, Cornelia Huck 写道: > >>> On Tue, 5 Sep 2017 16:44:37 +0800 > >>> Yi Min Zhao wrote: > >>> > 在 2017/9/

[Qemu-devel] [PULL v1 1/9] io: fix temp directory used by test-io-channel-tls test

2017-09-05 Thread Daniel P. Berrange
The test-io-channel-tls test was mistakenly using two of the same directories as test-crypto-tlssession. This causes a sporadic failure when using make -j$BIGNUM. Reported-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- tests/test-io-channel

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Stefan Hajnoczi
On Mon, Sep 04, 2017 at 06:19:00PM +0100, Peter Maydell wrote: > Nobody has mentioned AIX host support on the mailing list for years, > and we have no test systems for it so it is most likely broken. > We've advertised in configure for two releases now that we plan > to drop support for this host O

[Qemu-devel] [PULL v1 6/9] util: remove the obsolete non-blocking connect

2017-09-05 Thread Daniel P. Berrange
From: Cao jin The non-blocking connect mechanism is obsolete, and it doesn't work well in inet connection, because it will call getaddrinfo first and getaddrinfo will blocks on DNS lookups. Since commit e65c67e4 & d984464e, the non-blocking connect of migration goes through QIOChannel in a differ

[Qemu-devel] [PULL v1 7/9] io: fix typo in docs comment for qio_channel_read

2017-09-05 Thread Daniel P. Berrange
Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- include/io/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel.h b/include/io/channel.h index db9bb022a1..54f3dc252f 100644 --- a/include/io/channel.h +++ b/include/io/channel.h @@ -299,7 +

[Qemu-devel] [PULL v1 9/9] io: fix check for handshake completion in TLS test

2017-09-05 Thread Daniel P. Berrange
The TLS I/O channel test had mistakenly used && instead of || when checking for handshake completion. As a result it could terminate the handshake process before it had actually completed. This was harmless before but changes in GNUTLS 3.6.0 exposed this bug and caused the test suite to fail. Revi

[Qemu-devel] [PULL v1 3/9] sockets: factor out a new try_bind() function

2017-09-05 Thread Daniel P. Berrange
From: Knut Omang A refactoring step to prepare for the problem exposed by the test-listen test in the previous commit. Simplify and reorganize the IPv6 specific extra measures and move it out of the for loop to increase code readability. No semantic changes. Signed-off-by: Knut Omang Reviewed-

[Qemu-devel] [PULL v1 2/9] tests: Add test-listen - a stress test for QEMU socket listen

2017-09-05 Thread Daniel P. Berrange
From: Knut Omang There's a potential race condition between multiple bind()'s attempting to bind to the same port, which occasionally allows more than one bind to succeed against the same port. When a subsequent listen() call is made with the same socket only one will succeed. The current QEMU

[Qemu-devel] [PULL v1 4/9] sockets: factor out create_fast_reuse_socket

2017-09-05 Thread Daniel P. Berrange
From: Knut Omang Another refactoring step to prepare for fixing the problem exposed with the test-listen test in the previous commit Signed-off-by: Knut Omang Reviewed-by: Daniel P. Berrange Signed-off-by: Daniel P. Berrange --- util/qemu-sockets.c | 15 --- 1 file changed, 12 in

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午5:15, Cornelia Huck 写道: On Tue, 5 Sep 2017 17:08:14 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:50, Cornelia Huck 写道: On Tue, 5 Sep 2017 16:44:37 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: PCIDev

[Qemu-devel] [PULL v1 0/9] Merge QEMU I/O 2017/09/05

2017-09-05 Thread Daniel P. Berrange
s/pull-qio-20170905-1 for you to fetch changes up to 33fb97121573985b4a57306b8abdb9dd992061fa: io: fix check for handshake completion in TLS test (2017-09-05 10:20:28 +0100) Merge QEMU I/O 201

Re: [Qemu-devel] [PATCH v6 10/29] libqtest: Topologically sort functions

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > Put static functions prior to public ones, in part so that > improvements to qtest_start() can benefit from the static > helpers without needing forward references. Code motion, with > no semantic change. > > Signed-off-by: Eric Blake > --- > tests/libqt

Re: [Qemu-devel] [PATCH] tests: Do not include lutil on SunOS

2017-09-05 Thread Peter Maydell
On 5 September 2017 at 00:46, Kamil Rytarowski wrote: > On 04.09.2017 11:32, Peter Maydell wrote: >> My assumption is that the issue is that Solaris doesn't >> have a -lutil (it's helpful to quote the linker or >> compiler error message for this kind of patch to clarify >> what the failure is that

Re: [Qemu-devel] [PATCH v4 0/6] docker: Add test-block

2017-09-05 Thread Stefan Hajnoczi
On Tue, Sep 05, 2017 at 10:56:08AM +0800, Fam Zheng wrote: > Based-on: 20170905021201.25684-1-f...@redhat.com > ([PATCH v6 00/12] tests: Add VM based build tests (for non-x86_64 and/or > non-Linux)) > > A few tweaks to the docker images and running commands allow us to run > qemu-iotests in the fe

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 17:08:14 +0800 Yi Min Zhao wrote: > 在 2017/9/5 下午4:50, Cornelia Huck 写道: > > On Tue, 5 Sep 2017 16:44:37 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/9/5 下午4:29, Cornelia Huck 写道: > >>> On Fri, 1 Sep 2017 06:22:56 +0200 > >>> Yi Min Zhao wrote: > >>> > PCIDevic

Re: [Qemu-devel] [PATCH v2 17/19] s390x: CPU hot unplug via device_del cannot work

2017-09-05 Thread Christian Borntraeger
On 09/04/2017 05:43 PM, David Hildenbrand wrote: > device_del on a CPU will currently do nothing. Let's emmit an error > telling that this is will never work (there is no architecture support > on s390x). Error message copied from ppc. > > (qemu) device_del cpu1 > device_del cpu1 > CPU hot unplug

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 11:07 AM, Alberto Garcia wrote: On Tue 05 Sep 2017 10:28:02 AM CEST, Pradeep Jagadeesh wrote: +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) +{ +Error *err = NULL; +IOThrottleList *fsdev_list, *info; +fsdev_list = qmp_query_fsdev_io_throttle(&err); + +

Re: [Qemu-devel] [PATCH v6 09/29] libqtest: Use qemu_strtoul()

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > This will keep checkpatch happy when the next patch does code motion. > Fix the include order to match HACKING when adding the needed header. > > Signed-off-by: Eric Blake > Reviewed-by: Philippe Mathieu-Daudé > --- > tests/libqtest.c | 19 +

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午4:50, Cornelia Huck 写道: On Tue, 5 Sep 2017 16:44:37 +0800 Yi Min Zhao wrote: 在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Alberto Garcia
On Tue 05 Sep 2017 10:28:02 AM CEST, Pradeep Jagadeesh wrote: >>> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) >>> +{ >>> +Error *err = NULL; >>> +IOThrottleList *fsdev_list, *info; >>> +fsdev_list = qmp_query_fsdev_io_throttle(&err); >>> + >>> +for (info = fsde

Re: [Qemu-devel] qdev_get_machine() can return something non-NULL but not TYPE_MACHINE

2017-09-05 Thread Peter Maydell
On 4 September 2017 at 20:38, Igor Mammedov wrote: > On Mon, 4 Sep 2017 17:36:59 +0100 > Peter Maydell wrote: > >> I just got bitten by qdev_get_machine()'s behaviour on the user-only >> emulators, where it can return something that isn't NULL and isn't >> an instance of TYPE_MACHINE either. > us

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

2017-09-05 Thread Kevin Wolf
Am 05.09.2017 um 10:54 hat Fam Zheng geschrieben: > On Tue, 09/05 10:44, Kevin Wolf wrote: > > Am 30.08.2017 um 12:06 hat Fam Zheng geschrieben: > > > This fixes the assertion due to op blockers added by BMDS: > > > > > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' > > > f

Re: [Qemu-devel] [PATCH v4] docs: add qemu-block-drivers(7) man page

2017-09-05 Thread Kevin Wolf
Am 04.09.2017 um 18:26 hat Stefan Hajnoczi geschrieben: > Block driver documentation is available in qemu-doc.html. It would be > convenient to have documentation for formats, protocols, and filter > drivers in a man page. > > Extract the relevant part of qemu-doc.html into a new file called > do

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Greg Kurz
On Tue, 5 Sep 2017 10:28:02 +0200 Pradeep Jagadeesh wrote: > On 9/5/2017 9:53 AM, Alberto Garcia wrote: > > On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote: > > > >> +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) > >> +{ > >> +Error *err = NULL; > >> +IOT

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

2017-09-05 Thread Fam Zheng
On Tue, 09/05 10:44, Kevin Wolf wrote: > Am 30.08.2017 um 12:06 hat Fam Zheng geschrieben: > > This fixes the assertion due to op blockers added by BMDS: > > > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > > > Reproducer: simply start block migration and quit Q

Re: [Qemu-devel] [PATCH v2 04/19] s390x: rename s390-virtio.h to s390-virtio-hcall.h

2017-09-05 Thread Christian Borntraeger
On 09/04/2017 05:43 PM, David Hildenbrand wrote: > The only interface left, so let's properly rename it. > > Reviewed-by: Thomas Huth > Signed-off-by: David Hildenbrand Acked-by: Christian Borntraeger > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > hw/s390x/s390-virtio-hcal

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Cornelia Huck
On Tue, 5 Sep 2017 16:44:37 +0800 Yi Min Zhao wrote: > 在 2017/9/5 下午4:29, Cornelia Huck 写道: > > On Fri, 1 Sep 2017 06:22:56 +0200 > > Yi Min Zhao wrote: > > > >> PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). > >> So we don't need to store zpci idx in msix message data

[Qemu-devel] [PATCH] acpi/vmgenid: change device category to misc

2017-09-05 Thread Yoni Bettan
Moved vmgenid from uncategorized to misc category in QEMU help menu Signed-off-by: Yoni Bettan --- hw/acpi/vmgenid.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c index a32b847fe0..876723a4ce 100644 --- a/hw/acpi/vmgenid.c +++ b/hw/acpi/vmgenid.c @@ -2

Re: [Qemu-devel] [PATCH] block: Cleanup BMDS in bdrv_close_all

2017-09-05 Thread Kevin Wolf
Am 30.08.2017 um 12:06 hat Fam Zheng geschrieben: > This fixes the assertion due to op blockers added by BMDS: > > block.c:3248: bdrv_delete: Assertion `bdrv_op_blocker_is_empty(bs)' failed. > > Reproducer: simply start block migration and quit QEMU before it ends. > > Cc: qemu-sta...@nongnu.org

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Yi Min Zhao
在 2017/9/5 下午4:29, Cornelia Huck 写道: On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id t

Re: [Qemu-devel] [PATCH v2 1/3] s390x/pci: remove idx from msix msg data

2017-09-05 Thread Cornelia Huck
On Fri, 1 Sep 2017 06:22:56 +0200 Yi Min Zhao wrote: > PCIDevice pointer has been a parameter of kvm_arch_fixup_msi_route(). > So we don't need to store zpci idx in msix message data to find out the > specific zpci device. Instead, we could use pci device id to find its > corresponding zpci devi

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 9:53 AM, Alberto Garcia wrote: On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote: +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) +{ +Error *err = NULL; +IOThrottleList *fsdev_list, *info; +fsdev_list = qmp_query_fsdev_io_throttle(&err); + +

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Thomas Huth
On 05.09.2017 10:04, Daniel P. Berrange wrote: > On Mon, Sep 04, 2017 at 08:09:17PM +0200, Thomas Huth wrote: >> On 04.09.2017 19:19, Peter Maydell wrote: >>> Nobody has mentioned AIX host support on the mailing list for years, >>> and we have no test systems for it so it is most likely broken. >>>

Re: [Qemu-devel] [PATCH v6 08/29] libqtest: Let socket_send() compute length

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > Rather than make multiple callers call strlen(), it's easier if > socket_send() itself can compute a length via strlen() if none > was provided (caller passes -1). Callers that can get at the > length more efficiently are left that way. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Daniel P. Berrange
On Mon, Sep 04, 2017 at 08:09:17PM +0200, Thomas Huth wrote: > On 04.09.2017 19:19, Peter Maydell wrote: > > Nobody has mentioned AIX host support on the mailing list for years, > > and we have no test systems for it so it is most likely broken. > > We've advertised in configure for two releases no

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

2017-09-05 Thread Cornelia Huck
On Thu, 31 Aug 2017 12:41:05 +0200 Halil Pasic wrote: > On 08/31/2017 11:19 AM, Cornelia Huck wrote: > > On Wed, 30 Aug 2017 18:36:02 +0200 > > Halil Pasic wrote: > > > >> According to the POP a start subchannel instruction (SSCH) returning with > >> cc 1 implies that the subchannel was statu

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Greg Kurz
On Mon, 4 Sep 2017 18:19:00 +0100 Peter Maydell wrote: > Nobody has mentioned AIX host support on the mailing list for years, > and we have no test systems for it so it is most likely broken. > We've advertised in configure for two releases now that we plan > to drop support for this host OS, an

Re: [Qemu-devel] [PATCH for 2.10 v2 0/6] Various docker fixes

2017-09-05 Thread Alex Bennée
Fam Zheng writes: > On Tue, 07/25 14:34, Alex Bennée wrote: >> Hi, >> >> Phillipe pointed out a few anomalies with the travis.docker image >> during review which has led to a couple more patches. As they are bug >> fixes I didn't race to get a pull-req out today for hard-freeze. I >> will roll a

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Alberto Garcia
On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote: > +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) > +{ > +Error *err = NULL; > +IOThrottleList *fsdev_list, *info; > +fsdev_list = qmp_query_fsdev_io_throttle(&err); > + > +for (info = fsdev_list; info;

Re: [Qemu-devel] [PATCH] .dir-locals.el: Explicitly set indentation level

2017-09-05 Thread Markus Armbruster
Thiago Jung Bauermann writes: > At least in some configurations, setting c-file-style is not enough to > conform to the QEMU coding style, so explicitly set c-basic-offset as well. > > Signed-off-by: Thiago Jung Bauermann > --- > > My emacs was using indentation level of 8 spaces and this patch

Re: [Qemu-devel] [Help] Windows2012 as Guest 64+cores on KVM Halts

2017-09-05 Thread Gonglei (Arei)
> -Original Message- > From: Vadim Rozenfeld [mailto:vroze...@redhat.com] > Sent: Tuesday, September 05, 2017 2:33 PM > To: Gonglei (Arei); Paolo Bonzini > Cc: Hangaohuai; Yan Vugenfirer; qemu-devel@nongnu.org; > k...@vger.kernel.org; Radim Krcmar > Subject: Re: [Qemu-devel] [Help] Windows

Re: [Qemu-devel] [PATCH v2 00/19] s390x cleanups and CPU hotplug via device_add

2017-09-05 Thread Christian Borntraeger
I think we certainly want to have device_add as well (as long as the old interface stays for a while). Adding Matt. Can you have a look at the cpu hotplug bits? On 09/04/2017 05:42 PM, David Hildenbrand wrote: > The first patches are a bunch of cleanups. I decided to go the > extra mile and imp

Re: [Qemu-devel] [PATCH v6 05/29] numa-test: Use hmp()

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > Don't open-code something that has a convenient helper available. > > Signed-off-by: Eric Blake > Reviewed-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé > --- > tests/numa-test.c | 21 +++-- > 1 file changed, 3 insertions(

Re: [Qemu-devel] [PATCH v6 03/29] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > Back when the test was introduced, in commit 62c39b307, the > test was set up to run qemu-ga directly on the host performing > the test, and defaults to limiting itself to safe commands. At > the time, it was envisioned that setting QGA_TEST_SIDE_EFFECTING

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Thomas Huth
On 05.09.2017 09:16, Markus Armbruster wrote: > Peter Maydell writes: > >> On 4 September 2017 at 19:09, Thomas Huth wrote: >>> On 04.09.2017 19:19, Peter Maydell wrote: Nobody has mentioned AIX host support on the mailing list for years, and we have no test systems for it so it is mos

Re: [Qemu-devel] [PATCH v6 02/29] tests: Sort .gitignore

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > It doesn't matter if things are unsorted, but finding stuff in a list > is easier when it is sorted. (Sorted under LC_ALL=C rules, rather than > en_US.UTF-8). > > Signed-off-by: Eric Blake > --- > tests/.gitignore | 30 +++--- > 1

Re: [Qemu-devel] [PATCH] configure: Drop AIX host support

2017-09-05 Thread Markus Armbruster
Peter Maydell writes: > On 4 September 2017 at 19:09, Thomas Huth wrote: >> On 04.09.2017 19:19, Peter Maydell wrote: >>> Nobody has mentioned AIX host support on the mailing list for years, >>> and we have no test systems for it so it is most likely broken. >>> We've advertised in configure for

Re: [Qemu-devel] [PATCH v6 21/29] qmp-test: Drop dependence on global_qtest

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Although qmp-test does not > maintain parallel qtest connections, it was the last test > assigning

Re: [Qemu-devel] [PATCH v6 22/29] tests/boot-sector: Drop dependence on global_qtest

2017-09-05 Thread Thomas Huth
On 01.09.2017 20:03, Eric Blake wrote: > As a general rule, we prefer avoiding implicit global state > because it makes code harder to safely copy and paste without > thinking about the global state. Adjust the helper code to > use explicit state instead, and update all callers. > > Fix some trai

<    1   2   3   4