Re: [Qemu-devel] [PATCH 1/3] grackle: convert to trace-events

2018-01-26 Thread David Gibson
On Fri, Jan 26, 2018 at 09:20:27AM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Applied to ppc-for-2.12. > --- > hw/pci-host/grackle.c| 13 ++--- > hw/pci-host/trace-events | 3 +++ > 2 files changed, 5 insertions(+), 11

Re: [Qemu-devel] [PATCH 2/3] uninorth: convert to trace-events

2018-01-26 Thread David Gibson
On Fri, Jan 26, 2018 at 09:20:28AM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Applied to ppc-for-2.12. > --- > hw/pci-host/trace-events | 6 ++ > hw/pci-host/uninorth.c | 24 +--- > 2 files changed, 11

Re: [Qemu-devel] [PATCH 3/3] input: add missing newline from trace-events

2018-01-26 Thread David Gibson
On Fri, Jan 26, 2018 at 09:20:29AM +, Mark Cave-Ayland wrote: > This was accidentally omitted from 77cb0f5aaf "Split adb.c into adb.c, > adb-mouse.c > and adb-kbd.c". > > Signed-off-by: Mark Cave-Ayland Applied to ppc-for-2.12. > --- > hw/input/trace-events

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread no-reply
Hi, This series failed docker-build@min-glib build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180126120306.19225-1-marcandre.lur...@redhat.com Subject: [Qemu-devel] [PATCH v3]

[Qemu-devel] [Bug 1399191] Re: Large VHDX image size

2018-01-26 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1399191 Title: Large VHDX

[Qemu-devel] [RFC v3 14/14] iotests: test manual job dismissal

2018-01-26 Thread John Snow
RFC: The error returned by a job creation command when that device already has a job attached has become misleading; "Someone should do something about that!" Signed-off-by: John Snow --- tests/qemu-iotests/056 | 241 +

Re: [Qemu-devel] [PATCH] linux-user: Fix sched_getaffinity mask size

2018-01-26 Thread Samuel Thibault
Laurent Vivier, on ven. 26 janv. 2018 21:34:38 +0100, wrote: > Le 26/01/2018 à 19:36, Samuel Thibault a écrit : > > We properly computed the capped mask size to be put to the application > > buffer, but didn't actually it. Also, we need to return the capped mask > > size instead of 0 on success. >

[Qemu-devel] [RFC v3 12/14] blockjobs: add block-job-finalize

2018-01-26 Thread John Snow
Signed-off-by: John Snow --- block/trace-events | 1 + blockdev.c | 14 ++ blockjob.c | 72 +++- include/block/blockjob.h | 17 qapi/block-core.json | 18 5

[Qemu-devel] [RFC v3 13/14] blockjobs: Expose manual property

2018-01-26 Thread John Snow
Expose the "manual" property via QAPI for the backup-related jobs. As of this commit, this allows the management API to request the "concluded" and "dismiss" semantics for backup jobs. Signed-off-by: John Snow --- blockdev.c| 14 ++

[Qemu-devel] [RFC v3 10/14] blockjobs: Add waiting event

2018-01-26 Thread John Snow
For jobs that are stuck waiting on others in a transaction, it would be nice to know that they are no longer "running" in that sense, but instead are waiting on other jobs in the transaction. Jobs that are "waiting" in this sense cannot be meaningfully altered any longer as they have left their

[Qemu-devel] [RFC v3 08/14] blockjobs: add commit, abort, clean helpers

2018-01-26 Thread John Snow
The completed_single function is getting a little mucked up with checking to see which callbacks exist, so let's factor them out. Signed-off-by: John Snow --- blockjob.c | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [RFC v3 07/14] blockjobs: ensure abort is called for cancelled jobs

2018-01-26 Thread John Snow
Presently, even if a job is canceled post-completion as a result of a failing peer in a transaction, it will still call .commit because nothing has updated or changed its return code. The reason why this does not cause problems currently is because backup's implementation of .commit checks for

[Qemu-devel] [RFC v3 09/14] blockjobs: add prepare callback

2018-01-26 Thread John Snow
Some jobs, upon finalization, may need to perform some work that can still fail. If these jobs are part of a transaction, it's important that these callbacks fail the entire transaction. Thus, we allow for a new callback in addition to commit/abort/clean that allows us the opportunity to have

[Qemu-devel] [RFC v3 05/14] blockjobs: add block_job_dismiss

2018-01-26 Thread John Snow
For jobs that have reached their terminal state, prior to having their last reference put down (meaning jobs that have completed successfully, unsuccessfully, or have been canceled), allow the user to dismiss the job's lingering status report via block-job-dismiss. This gives management APIs the

[Qemu-devel] [RFC v3 06/14] blockjobs: add CONCLUDED state

2018-01-26 Thread John Snow
add a new state "CONCLUDED" that identifies a job that has ceased all operations. The wording was chosen to avoid any phrasing that might imply success, error, or cancellation. The task has simply ceased all operation and can never again perform any work. ("finished", "done", and "completed"

[Qemu-devel] [RFC v3 11/14] blockjobs: add PENDING status and event

2018-01-26 Thread John Snow
For jobs utilizing the new manual workflow, we intend to prohibit them from modifying the block graph until the management layer provides an explicit ACK via block-job-finalize to move the process forward. To distinguish this runstate from "ready" or "waiting," we add a new "pending" event.

[Qemu-devel] [RFC v3 02/14] blockjobs: Add status enum

2018-01-26 Thread John Snow
We're about to add several new states, and booleans are becoming unwieldly and difficult to reason about. To this end, add a new "status" field and add our existing states in a redundant manner alongside the bools they are replacing: UNDEFINED: Placeholder, default state. CREATED: replaces

[Qemu-devel] [RFC v3 01/14] blockjobs: add manual property

2018-01-26 Thread John Snow
This property will be used to opt-in to the new BlockJobs workflow that allows a tighter, more explicit control over transitions from one runstate to another. Signed-off-by: John Snow --- block/backup.c | 20 ++-- block/commit.c | 2

[Qemu-devel] [RFC v3 04/14] blockjobs: RFC add block_job_verb permission table

2018-01-26 Thread John Snow
Which commands are appropriate for jobs in which state is also somewhat burdensome to keep track of. Introduce a verbs table that, as of this RFC patch, does nothing but serve as a declaration of intent. (At the very least, it forced me to consider all of the possibilities.) If this idea seems

[Qemu-devel] [RFC v3 00/14] blockjobs: add explicit job management

2018-01-26 Thread John Snow
For jobs that complete when a monitor isn't looking, there's no way to tell what the job's final return code was. We need to allow jobs to remain in the list until queried for reliable management. Furthermore, it's not viable to have graph changes when the monitor isn't looking either. We need at

[Qemu-devel] [RFC v3 03/14] blockjobs: add state transition table

2018-01-26 Thread John Snow
The state transition table has mostly been implied. We're about to make it a bit more complex, so let's make the STM explicit instead. Perform state transitions with a function that for now just asserts the transition is appropriate. undefined: May only transition to 'created'. created: May only

Re: [Qemu-devel] [Bug 1737194] Windows NT 4.0 fails to boot from qcow2 installation

2018-01-26 Thread John Arbuckle
I have installed Windows 95 OSR 2.5 in QEMU using the qcow2 format. So far there hasn't been any major problems that prevent Windows from booting. I downloaded the ISO file from here: https://winworldpc.com/product/windows-95/osr-3 Used this floppy boot image to boot QEMU:

Re: [Qemu-devel] [PATCH] 9pfs: Correctly handle cancelled requests

2018-01-26 Thread Stefano Stabellini
On Tue, 23 Jan 2018, Greg Kurz wrote: > From: Keno Fischer > > # Background > > I was investigating spurious non-deterministic EINTR returns from > various 9p file system operations in a Linux guest served from the > qemu 9p server. > > ## EINTR, ERESTARTSYS and the

[Qemu-devel] [PATCH] spapr_pci: fix MSI/MSIX selection

2018-01-26 Thread Greg Kurz
In various place we don't correctly check if the device supports MSI or MSI-X. This can cause devices to be advertised with MSI support, even if they only support MSI-X (like virtio-pci-* devices for example): ethernet@0 { ibm,req#msi = <0x1>; <--- wrong!

[Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

2018-01-26 Thread John Arbuckle
Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. This combination may not be very fun for the user to have to enter, so we now enable the user to specify their own key(s) as the ungrab key(s). The list of keys that can be used is found in the file qapi/ui.json under

[Qemu-devel] [PATCH 5/5] target/i386: Remove generic SMT thread check

2018-01-26 Thread Babu Moger
Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger --- target/i386/cpu.c | 13 - 1 file changed, 8

[Qemu-devel] [PATCH 4/5] target/i386: Enable TOPOEXT feature on AMD EPYC CPU

2018-01-26 Thread Babu Moger
Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. These are supported via CPUID_8000_001E extended functions. Signed-off-by: Babu Moger --- target/i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 2/5] target/i386: Populate AMD Processor Cache Information

2018-01-26 Thread Babu Moger
From: Stanislav Lanci Adds information about cache size and topology from cpuid 0x801D leaf for different cache types on AMD processors. Signed-off-by: Stanislav Lanci Signed-off-by: Babu Moger --- target/i386/cpu.c | 76

[Qemu-devel] [PATCH 3/5] target/i386: Add support for CPUID_8000_001E for AMD

2018-01-26 Thread Babu Moger
From: Stanislav Lanci Populate threads/core_id/apic_ids/socket_id when CPUID_EXT3_TOPOEXT feature is supported. This is required to support hyperthreading feature on AMD CPUS. These are supported via CPUID_8000_001E extended functions. Signed-off-by: Stanislav Lanci

[Qemu-devel] [PATCH 0/5] Enable TOPOEXT to support hyperthreading on AMD CPU

2018-01-26 Thread Babu Moger
These series enable TOPOEXT feature on AMD CPU. These are required to support hyperthreading on kvm guests. Stanislav Lanci posted few patches earlier. https://patchwork.kernel.org/patch/10040903/ Rebased his patches with few changes. 1. Spit the patches into two, separating cpuid functions

[Qemu-devel] [PATCH 1/5] target/i386: Fix instruction cache associativity for AMD

2018-01-26 Thread Babu Moger
Per Processor Programming Reference, CPUID_Fn8005_EDX should report L1 instruction cache associativity as 4(way) instead of 2(way). Signed-off-by: Babu Moger --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c

Re: [Qemu-devel] [PATCH] linux-user: Fix sched_getaffinity mask size

2018-01-26 Thread Laurent Vivier
Le 26/01/2018 à 19:36, Samuel Thibault a écrit : > We properly computed the capped mask size to be put to the application > buffer, but didn't actually it. Also, we need to return the capped mask > size instead of 0 on success. > > Signed-off-by: Samuel Thibault >

[Qemu-devel] [PATCH 1/3] grackle: convert to trace-events

2018-01-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/pci-host/grackle.c| 13 ++--- hw/pci-host/trace-events | 3 +++ 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 3caf1ccb37..033588b7d2 100644 ---

Re: [Qemu-devel] [PATCH] monitor: Remove legacy "-mon default=on" parameter

2018-01-26 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 22/01/2018 20:35, Dr. David Alan Gilbert wrote: > > * Thomas Huth (th...@redhat.com) wrote: > >> The "default" parameter of the "-mon" option is useless since > >> QEMU v2.4.0, and marked as deprecated since QEMU v2.8.0. That > >> should have been

Re: [Qemu-devel] [PATCH v3 30/39] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > expand_zero_clusters_in_l1() expands zero clusters as a necessary step > to downgrade qcow2 images to a version that doesn't support metadata > zero clusters. This function takes an L1 table (which may or may not > be active) and iterates over all

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 26 January 2018 at 15:47, Wei Huang wrote: > > > > > > On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: > >> * Wei Huang (w...@redhat.com) wrote: > >>> innerloop: > >>> /* clean cache because el2 might still

Re: [Qemu-devel] [PATCH v3 29/39] qcow2: Prepare expand_zero_clusters_in_l1() for adding L2 slice support

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > Adding support for L2 slices to expand_zero_clusters_in_l1() needs > (among other things) an extra loop that iterates over all slices of > each L2 table. > > Putting all changes in one patch would make it hard to read because > all semantic changes

Re: [Qemu-devel] [PATCH v3 28/39] qcow2: Read refcount before L2 table in expand_zero_clusters_in_l1()

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > At the moment it doesn't really make a difference whether we call > qcow2_get_refcount() before of after reading the L2 table, but if we > want to support L2 slices we'll need to read the refcount first. > > This patch simply changes the order of

Re: [Qemu-devel] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > qcow2_update_snapshot_refcount() increases the refcount of all > clusters of a given snapshot. In order to do that it needs to load all > its L2 tables and iterate over their entries. Since we'll be loading > L2 slices instead of full tables we need

Re: [Qemu-devel] [PATCH v3 26/39] qcow2: Prepare qcow2_update_snapshot_refcount() for adding L2 slice support

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > Adding support for L2 slices to qcow2_update_snapshot_refcount() needs > (among other things) an extra loop that iterates over all slices of > each L2 table. > > Putting all changes in one patch would make it hard to read because > all semantic

[Qemu-devel] [PATCH] block: Simplify bdrv_can_write_zeroes_with_unmap()

2018-01-26 Thread Eric Blake
We don't need the can_write_zeroes_with_unmap field in BlockDriverInfo, because it is redundant information with supported_zero_flags & BDRV_REQ_MAY_UNMAP. Note that BlockDriverInfo and supported_zero_flags are both per-device settings, rather than global state about the driver as a whole, which

Re: [Qemu-devel] [PATCH v2 09/11] target/arm: Decode aa64 armv8.3 fcmla

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 07:29, Richard Henderson wrote: > On 01/15/2018 10:18 AM, Peter Maydell wrote: >>> +void HELPER(gvec_fcmlah)(void *vd, void *vn, void *vm, >>> + void *vfpst, uint32_t desc) >>> +{ >>> +uintptr_t opr_sz =

Re: [Qemu-devel] [PATCH 2/5] lockable: add QemuLockable

2018-01-26 Thread Fam Zheng
On Fri, Jan 26, 2018 at 1:59 AM, Paolo Bonzini wrote: > QemuLockable is a polymorphic lock type that takes an object and > knows which function to use for locking and unlocking. The > implementation could use C11 _Generic, but since the support is > not very widespread I am

Re: [Qemu-devel] [PATCH v2 1/2] i386: Add Intel Processor Trace feature support

2018-01-26 Thread Eduardo Habkost
On Fri, Jan 26, 2018 at 02:25:50AM +0800, Luwei Kang wrote: > From: Chao Peng > > Expose Intel Processor Trace feature to guest. > > In order to make this feature migration-safe, new feature word > information "FEAT_INTEL_PT_EBX" and "FEAT_INTEL_PT_ECX" be added. >

Re: [Qemu-devel] [PATCH v2 09/11] target/arm: Decode aa64 armv8.3 fcmla

2018-01-26 Thread Richard Henderson
On 01/26/2018 02:07 AM, Peter Maydell wrote: >> The SVE pseudocode for the same operation is clearer than that in the main >> ARM >> ARM, and is nearer to what I used: >> >> for e = 0 to elements-1 >> if ElemP[mask, e, esize] == '1' then >> pair = e - (e MOD 2); // index of first

Re: [Qemu-devel] [PATCH v3] tpm: add CRB device

2018-01-26 Thread Stefan Berger
On 01/26/2018 07:03 AM, Marc-André Lureau wrote: tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS and

[Qemu-devel] [PULL 1/5] tpm: Set the flags of the CMD_INIT command to 0

2018-01-26 Thread Stefan Berger
The flags of the CMD_INIT control channel command were not initialized properly. Fix this and set to 0. Signed-off-by: Stefan Berger Reviewed-by: Marc-André Lureau --- hw/tpm/tpm_emulator.c | 4 +++- 1 file changed, 3 insertions(+), 1

[Qemu-devel] [PULL 5/5] tpm: add CRB device

2018-01-26 Thread Stefan Berger
From: Marc-André Lureau tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) Interface as defined in TCG PC Client Platform TPM Profile (PTP) Specification Family “2.0” Level 00 Revision 01.03 v22. The PTP allows device implementation to switch between TIS

[Qemu-devel] [PULL 2/5] tpm: lookup cancel path under tpm device class

2018-01-26 Thread Stefan Berger
From: Marc-André Lureau Since Linux commit 313d21eeab9282e, tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau

[Qemu-devel] [PULL 4/5] tpm: report backend request error

2018-01-26 Thread Stefan Berger
From: Marc-André Lureau Use an Error** for request to let the caller handle error reporting. This will also allow to inform the frontend of a backend error. Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Berger

[Qemu-devel] [PULL 3/5] tpm: replace GThreadPool with AIO threadpool

2018-01-26 Thread Stefan Berger
From: Marc-André Lureau The TPM backend uses a GThreadPool to handle IO in a seperate thread. However, GThreadPool isn't integrated with Qemu main loops, making it unnecessarily complicated to deal with. Qemu has a AIO threadpool, that is better integrated with

[Qemu-devel] [PULL 0/5] Merge tpm 2018/01/26

2018-01-26 Thread Stefan Berger
The patches in this pull request fix a bug in the initialization of a variable, adapt the cancel path used by the passthrough device to the sysfs path of more recent versions of the Linux kernel, and do some other cleanups preparing for support of migration. Finally, we add the CRB interface

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-26 Thread Paolo Bonzini
On 26/01/2018 10:19, Thomas Huth wrote: > Last July, Eric Blake wrote a nice summary for newcomers about what > QEMU has to do to emulate devices for the guests. So far, we missed > to integrate this somewhere into the QEM web site or wiki, so let's > publish this now as a nice blog post for the

Re: [Qemu-devel] [PULL 07/13] linux-user: Fix sched_get/setaffinity conversion

2018-01-26 Thread Samuel Thibault
Peter Maydell, on ven. 26 janv. 2018 18:23:02 +, wrote: > On 23 January 2018 at 14:48, Laurent Vivier wrote: > > From: Samuel Thibault > > > > sched_get/setaffinity linux-user syscalls were missing conversions for > > little/big endian, which

[Qemu-devel] [PATCH] linux-user: Fix sched_getaffinity mask size

2018-01-26 Thread Samuel Thibault
We properly computed the capped mask size to be put to the application buffer, but didn't actually it. Also, we need to return the capped mask size instead of 0 on success. Signed-off-by: Samuel Thibault --- linux-user/syscall.c | 7 ++- 1 file changed, 6

Re: [Qemu-devel] [PATCH] migration/savevm.c: do not fail when len > MAX_VM_CMD_PACKAGED_SIZE

2018-01-26 Thread Daniel Henrique Barboza
On 01/26/2018 11:11 AM, Dr. David Alan Gilbert wrote: * Daniel Henrique Barboza (danie...@linux.vnet.ibm.com) wrote: MAX_VM_CMD_PACKAGED_SIZE is a constant used in qemu_savevm_send_packaged and loadvm_handle_cmd_packaged to determine whether a package is too big to be sent or received.

Re: [Qemu-devel] [RFC 0/2] virtio-vhost-user: add virtio-vhost-user device

2018-01-26 Thread Stefan Hajnoczi
On Thu, Jan 25, 2018 at 06:19:13PM +0800, Wei Wang wrote: > On 01/24/2018 07:40 PM, Stefan Hajnoczi wrote: > > On Tue, Jan 23, 2018 at 09:06:49PM +0800, Wei Wang wrote: > > > On 01/23/2018 07:12 PM, Stefan Hajnoczi wrote: > > > > On Mon, Jan 22, 2018 at 07:09:06PM +0800, Wei Wang wrote: > > > > >

Re: [Qemu-devel] [PULL 07/13] linux-user: Fix sched_get/setaffinity conversion

2018-01-26 Thread Peter Maydell
On 23 January 2018 at 14:48, Laurent Vivier wrote: > From: Samuel Thibault > > sched_get/setaffinity linux-user syscalls were missing conversions for > little/big endian, which is hairy since longs may not be the same size > either. > > For

Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-01-17

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 18:08, Eduardo Habkost wrote: [lots of quoted text] Could you folks try to trim down the quoted text when you're replying to this thread, please? Every time somebody replies to this thread and leaves the original pull request email quoted in it it flags

[Qemu-devel] [PULL v2 8/9] xlnx-zynqmp-pmu: Connect the IPI device to the PMU

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis Signed-off-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/microblaze/xlnx-zynqmp-pmu.c | 31

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 5a6b5091.8030...@hisilicon.com Subject: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH v2] migration: change blocktime type to uint32_t

2018-01-26 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Initially int64_t was used, but on PowerPC architecture, > clang doesn't have atomic_*_8 function, so it produces > link time error. > > QEMU is working with time as with 64bit value, but by > fact 32 bit is enough with CLOCK_REALTIME. In this

Re: [Qemu-devel] [PULL 0/8] x86 queue, 2018-01-17

2018-01-26 Thread Eduardo Habkost
On Fri, Jan 26, 2018 at 10:28:52AM -0600, Michael Roth wrote: > Quoting Eduardo Habkost (2018-01-25 19:29:50) > > On Tue, Jan 23, 2018 at 03:33:56PM -0600, Michael Roth wrote: > > > Quoting Eduardo Habkost (2018-01-23 13:31:18) > > > > On Tue, Jan 23, 2018 at 12:15:27PM -0600, Michael Roth wrote:

Re: [Qemu-devel] [PATCH v10.5 11/20] target/arm: Align vector registers

2018-01-26 Thread Richard Henderson
On 01/26/2018 01:52 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> Reviewed-by: Alex Bennée >> Reviewed-by: Philippe Mathieu-Daudé >> Signed-off-by: Richard Henderson >> --- >>

[Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread Wei Xu
If the user pressed some keys in the console during the guest booting, the console will be hanged after entering the shell. Because in the above case the pl011_can_receive will return 0 that the pl011_receive will not be called. That means no interruption will be injected in to the kernel and the

Re: [Qemu-devel] [PATCH 1/1] nbd: implement bdrv_get_info callback

2018-01-26 Thread Eric Blake
On 01/26/2018 06:39 AM, Edgar Kaziakhmedov wrote: > PIng > > So, let me know if I need to make any changes in patch > > On 1/18/18 1:09 PM, Paolo Bonzini wrote: >> On 18/01/2018 12:51, Edgar Kaziakhmedov wrote: >>> +static int nbd_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) >>> +{ >>> + 

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread Wei Xu
Hi Peter, On 2018/1/26 17:15, Peter Maydell wrote: > On 26 January 2018 at 17:05, Wei Xu wrote: >> On 2018/1/26 16:36, Peter Maydell wrote: >>> If the user presses keys before interrupts are enabled, >>> what ought to happen is: >>> * we put the key in the FIFO, and update

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread Wei Xu
Hi Peter, On 2018/1/26 16:36, Peter Maydell wrote: > On 26 January 2018 at 16:00, Wei Xu wrote: >> If the user pressed some keys in the console during the guest booting, >> the console will be hanged after entering the shell. >> Because in the above case the

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max)

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 17:54, Eduardo Habkost wrote: > On Fri, Jan 26, 2018 at 11:02:24AM +, Peter Maydell wrote: >> None of those are things we'd want to expose to the user, really >> (except maybe 'cfgend'): they're all intended for the QEMU board >> or SoC code that

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 17:33, Wei Xu wrote: > On 2018/1/26 17:15, Peter Maydell wrote: >> The pl011 code should call qemu_set_irq(..., 1) when the >> guest enables interrupts on the device by writing to the int_enabled >> (UARTIMSC) register. That will be a 0-to-1 level

[Qemu-devel] [PULL 5/7] hw: convert the escc device to keycodemapdb

2018-01-26 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange Message-id:

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max)

2018-01-26 Thread Eduardo Habkost
On Fri, Jan 26, 2018 at 11:02:24AM +, Peter Maydell wrote: > On 26 January 2018 at 10:42, Eduardo Habkost wrote: > > On Thu, Jan 25, 2018 at 02:41:50PM +, Peter Maydell wrote: > >> I'm not sure if we actually support command line setting/unsetting > >> of features for

[Qemu-devel] [PULL v2 0/9] Xilinx queue

2018-01-26 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180125' into staging (2018-01-25 17:04:47 +) are available in the git repository at:

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Wei Huang
On 01/26/2018 10:39 AM, Peter Maydell wrote: > On 26 January 2018 at 15:47, Wei Huang wrote: >> >> >> On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: >>> * Wei Huang (w...@redhat.com) wrote: innerloop: /* clean cache because el2 might still cache guest

Re: [Qemu-devel] [PULL v2 0/9] Xilinx queue

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 10:22, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The following changes since commit 2077fef91d5eb8e3745a84fabd87a5ee7d2b535d: > > Merge remote-tracking branch >

Re: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations

2018-01-26 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180126045742.5487-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PATCH v11 00/20] tcg: generic vector operations === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

Re: [Qemu-devel] [PATCH v10.5 11/20] target/arm: Align vector registers

2018-01-26 Thread Alex Bennée
Richard Henderson writes: > Reviewed-by: Alex Bennée > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 2 +- > 1 file changed, 1

Re: [Qemu-devel] [PATCH v3 3/5] target/arm: Add SVE to migration state

2018-01-26 Thread Alex Bennée
Richard Henderson writes: > Save the high parts of the Zregs and all of the Pregs. > The ZCR_ELx registers are migrated via the CP mechanism. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée >

Re: [Qemu-devel] [PATCH v2 3/6] qapi: add nbd-server-remove

2018-01-26 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > 17.01.2018 19:03, Eric Blake wrote: > > On 01/17/2018 09:51 AM, Vladimir Sementsov-Ogievskiy wrote: > > > > > > > I have a script (for managing libvirt guest, but it can be adopted for > > > > > qemu or even used for qemu

[Qemu-devel] [PULL 7/7] hw: convert virtio-input-hid device to keycodemapdb

2018-01-26 Thread Gerd Hoffmann
From: "Daniel P. Berrange" Replace the keymap_qcode table with automatically generated tables. Missing entries in keymap_qcode now fixed: Q_KEY_CODE_ASTERISK -> KEY_KPASTERISK Q_KEY_CODE_KP_MULTIPLY -> KEY_KPASTERISK Q_KEY_CODE_STOP -> KEY_STOP Q_KEY_CODE_AGAIN ->

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/6] target/arm: Query host CPU features on-demand at instance init

2018-01-26 Thread Philippe Mathieu-Daudé
On 12/07/2017 03:14 PM, Peter Maydell wrote: > Currently we query the host CPU features in the class init function > for the TYPE_ARM_HOST_CPU class, so that we can later copy them > from the class object into the instance object in the object > instance init function. This is awkward for

[Qemu-devel] [PULL 8/8] nbd: implement bdrv_get_info callback

2018-01-26 Thread Eric Blake
From: Edgar Kaziakhmedov Since mirror job supports efficient zero out target mechanism (see in mirror_dirty_init()), implement bdrv_get_info to make it work over NBD. Such improvement will allow using the largest chunk possible and will decrease the number of

Re: [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo before enabled the interruption

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 17:05, Wei Xu wrote: > On 2018/1/26 16:36, Peter Maydell wrote: >> If the user presses keys before interrupts are enabled, >> what ought to happen is: >> * we put the key in the FIFO, and update the int_level flags >> * when the FIFO is full,

Re: [Qemu-devel] [Qemu-block] [PATCH] block/mirror: fix fail to cancel when VM has heavy BLK IO

2018-01-26 Thread John Snow
On 01/24/2018 02:16 PM, Eric Blake wrote: > On 01/24/2018 12:17 AM, Liang Li wrote: >> We found that when doing drive mirror to a low speed shared storage, >> if there was heavy BLK IO write workload in VM after the 'ready' event, >> drive mirror block job can't be canceled immediately, it would

Re: [Qemu-devel] [Qemu-arm] [PATCH 0/6] arm: support -cpu max (and gic-version=max)

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 10:42, Eduardo Habkost wrote: > On Thu, Jan 25, 2018 at 02:41:50PM +, Peter Maydell wrote: >> I'm not sure if we actually support command line setting/unsetting >> of features for Arm CPUs -- is there a command line option to >> get QEMU to print the

[Qemu-devel] [PULL 0/8] NBD patches through 26 Jan

2018-01-26 Thread Eric Blake
The following changes since commit e607bbee553cfe73072870cef458cfa4e78133e2: Merge remote-tracking branch 'remotes/edgar/tags/edgar/xilinx-next-2018-01-26.for-upstream' into staging (2018-01-26 14:24:25 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git

Re: [Qemu-devel] [PATCH v2 1/4] vhost: add traces for memory listeners

2018-01-26 Thread Michael S. Tsirkin
On Mon, Jan 22, 2018 at 02:02:41PM +0800, Peter Xu wrote: > Trace these operations on two memory listeners. It helps to verify the > new memory listener fix, and good to keep them there. > > Signed-off-by: Peter Xu I'm not sure what this have to do with vfio, but anyway:

[Qemu-devel] [PULL 4/8] iotest 147: add cases to test new @name parameter of nbd-server-add

2018-01-26 Thread Eric Blake
From: Vladimir Sementsov-Ogievskiy Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-Id: <20180119135719.24745-4-vsement...@virtuozzo.com> Signed-off-by: Eric Blake ---

Re: [Qemu-devel] [PATCH v3 19/39] qcow2: Update get_cluster_table() to support L2 slices

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > This patch updates get_cluster_table() to return L2 slices instead of > full L2 tables. > > The code itself needs almost no changes, it only needs to call > offset_to_l2_slice_index() instead of offset_to_l2_index(). This patch > also renames all

[Qemu-devel] [PATCH v2 1/1] migration/savevm.c: set MAX_VM_CMD_PACKAGED_SIZE to 1ul << 32

2018-01-26 Thread Daniel Henrique Barboza
MAX_VM_CMD_PACKAGED_SIZE is a constant used in qemu_savevm_send_packaged and loadvm_handle_cmd_packaged to determine whether a package is too big to be sent or received. qemu_savevm_send_packaged is called inside postcopy_start (migration/migration.c) to send the MigrationState in a single blob to

Re: [Qemu-devel] [Bug 1737194] Re: Windows NT 4.0 fails to boot from qcow2 installation

2018-01-26 Thread John Arbuckle
> On Jan 26, 2018, at 9:51 AM, David Lindsay wrote: > > Hi John & others: > > (3 separate things.) > > 1: Image formats > > Regarding qcow, unfortunately there is no change if I use this format. > > - Windows 3.1 initially hung at "Starting MS-DOS..."; upon restart it >

[Qemu-devel] [PATCH v11 01/20] tcg: Allow multiple word entries into the constant pool

2018-01-26 Thread Richard Henderson
This will be required for storing vector constants. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/tcg-pool.inc.c | 115 +++-- 1 file changed, 93 insertions(+), 22

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

2018-01-26 Thread Eric Blake
On 01/26/2018 06:40 AM, Paolo Bonzini wrote: > On 26/01/2018 10:19, Thomas Huth wrote: >> Last July, Eric Blake wrote a nice summary for newcomers about what >> QEMU has to do to emulate devices for the guests. So far, we missed >> to integrate this somewhere into the QEM web site or wiki, so

Re: [Qemu-devel] [PATCH V1 1/1] tests: Add migration test for aarch64

2018-01-26 Thread Peter Maydell
On 26 January 2018 at 15:47, Wei Huang wrote: > > > On 01/25/2018 02:05 PM, Dr. David Alan Gilbert wrote: >> * Wei Huang (w...@redhat.com) wrote: >>> innerloop: >>> /* clean cache because el2 might still cache guest data under KVM */ >>> dc civac, x2 >> >>

[Qemu-devel] [PATCH v2] Fix build on ppc platform in migration/postcopy-ram.c

2018-01-26 Thread Alexey Perevalov
This is a second version: - comment from David about casting David was right, I tried to find it in standard, but it was implicitly described for me, so part of standard: 1. When a value with integer type is converted to another integer type other than _Bool, if the value can be

[Qemu-devel] [PULL v2 2/9] xlnx-zynqmp-pmu: Initial commit of the ZynqMP PMU

2018-01-26 Thread Edgar E. Iglesias
From: Alistair Francis The Xilinx ZynqMP SoC has two main processing systems in it. The ARM processing system (which is already modeled in QEMU) and the MicroBlaze Power Management Unit (PMU). This is the inital work for adding support for the PMU. The PMU

[Qemu-devel] [PATCH 2/3] uninorth: convert to trace-events

2018-01-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/pci-host/trace-events | 6 ++ hw/pci-host/uninorth.c | 24 +--- 2 files changed, 11 insertions(+), 19 deletions(-) diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events index

Re: [Qemu-devel] [PATCH v3 16/39] qcow2: Prepare l2_allocate() for adding L2 slice support

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > Adding support for L2 slices to l2_allocate() needs (among other > things) an extra loop that iterates over all slices of a new L2 table. > > Putting all changes in one patch would make it hard to read because > all semantic changes would be mixed

Re: [Qemu-devel] [PATCH v3 18/39] qcow2: Refactor get_cluster_table()

2018-01-26 Thread Eric Blake
On 01/26/2018 08:59 AM, Alberto Garcia wrote: > After the previous patch we're now always using l2_load() in > get_cluster_table() regardless of whether a new L2 table has to be > allocated or not. > > This patch refactors that part of the code to use one single l2_load() > call. > >

Re: [Qemu-devel] [PATCH v2 3/4] vfio: listener unregister before unset container

2018-01-26 Thread Alex Williamson
On Mon, 22 Jan 2018 14:02:43 +0800 Peter Xu wrote: > After next patch, listener unregister will need the container to be > alive. Let's move this unregister phase to be before unset container, > since that operation will free the backend container in kernel, > otherwise we'll

  1   2   3   >