Re: [Qemu-devel] [PATCH 03/18] Include qapi/error.h exactly where needed

Eric Blake writes: > On 01/30/2018 04:21 AM, Markus Armbruster wrote: >> This cleanup makes the number of objects depending on qapi/error.h >> drop from 1910 (out of 4739) to 1612 in my "build everything" tree. >> >> Signed-off-by: Markus Armbruster >> ---

Re: [Qemu-devel] [PATCH 02/18] Drop superfluous includes of qapi-types.h

Eric Blake writes: > On 01/30/2018 04:21 AM, Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- > >> +++ b/tests/test-clone-visitor.c >> @@ -11,7 +11,6 @@ >> >> #include "qemu-common.h" >> #include "qapi/clone-visitor.h" >> -#include

Re: [Qemu-devel] [PATCH 01/18] Clean up includes

BALATON Zoltan writes: > On Tue, 30 Jan 2018, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with the change >> to

Re: [Qemu-devel] [PATCH 1/3] s390x/pci: fixup the code walking IOMMU tables

On 30.01.2018 10:47, Yi Min Zhao wrote: > Current s390x PCI IOMMU code is lack of flags' checking, including: > 1) protection bit > 2) table length > 3) table offset > 4) intermediate tables' invalid bit > 5) format control bit > > This patch introduces a new struct named S390IOTLBEntry, and

Re: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180131072445.22783-1-...@ozlabs.ru Subject: [Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [RFC PATCH qemu v6] vfio-pci: Allow mmap of MSIX BAR

This makes use of a new VFIO_REGION_INFO_CAP_MSIX_MAPPABLE capability which tells that a region with MSIX data can be mapped entirely, i.e. the VFIO PCI driver won't prevent MSIX vectors area from being mapped. With this change, all BARs are mapped in a single chunk and MSIX vectors are emulated

Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load routine

+-- On Thu, 25 Jan 2018, Gerd Hoffmann wrote --+ | Ok, finally queueed up v1 for merge. Okay, cool. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

Re: [Qemu-devel] SDL2 UI behavior of switching views

Hi, > I think it does not have to be runtime switchable in the sense that the > setting does not need to be changable during run (like in gtk) because we > don't have a UI for changing it anyway. It's enough to have an option to > decide it once at startup, in case that's easier to implement.

Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time

On 30.01.2018 11:21, Markus Armbruster wrote: > We have awfully many "touch it, recompile the world" headers. Right > now, I count about fifty that are prerequisites of more than half the > objects in my "build everything" tree. Could you maybe share the list of these 50 headers? ... cleaning

[Qemu-devel] [PATCH v4 5/6] hostmem: add more information in error messages

When there are multiple memory backends in use, including the object type name, ID and the property name in the error message can help users to locate the error. Signed-off-by: Haozhong Zhang Suggested-by: "Dr. David Alan Gilbert" Reviewed-by:

[Qemu-devel] [PATCH v4 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition can guarantee the persistence of guest write to the backend file without other QEMU actions (e.g., periodic fsync() by QEMU). A set of QEMU_RAM_SYNC_{AUTO,ON,OFF} flags are added to qemu_ram_mmap(): -

[Qemu-devel] [PATCH v4 2/6] exec: switch qemu_ram_alloc_from_{file, fd} to the 'flags' parameter

As more flag parameters besides the existing 'share' are going to be added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a 'flags' parameters in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang --- exec.c | 15

[Qemu-devel] [PATCH v4 0/6] nvdimm: support MAP_SYNC for memory-backend-file

Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at

[Qemu-devel] [PATCH v4 1/6] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

As more flag parameters besides the existing 'shared' are going to be added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Suggested-by: "Michael S. Tsirkin"

[Qemu-devel] [PATCH v4 3/6] memory: switch memory_region_init_ram_from_file() to 'flags' parameter

As more flag parameters besides the existing 'share' are going to be added to memory_region_init_ram_from_file(), let's switch 'share' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang --- backends/hostmem-file.c | 3

[Qemu-devel] [PATCH v4 6/6] hostmem-file: add 'sync' option

This option controls whether QEMU mmap(2) the memory backend file with MAP_SYNC flag, which can fully guarantee the guest write persistence to the backend, if MAP_SYNC flag is supported by the host kernel (Linux kernel 4.15 and later) and the backend is a file supporting DAX (e.g., file on

[Qemu-devel] [PATCH] Add a git-publish configuration file

git-publish [1] is a convenient tool to send patches and has been popular among QEMU developers. Recently it has been made available in Fedora official repo thanks to Stefan's work. One nice feature of the tool is a per-project configuration with profiles, especially in which the cccmd option is

Re: [Qemu-devel] MTTCG External Halt

On 30/01/2018 18:56, Alistair Francis wrote: > > I don't have a good solution though, as setting CPU_INTERRUPT_RESET > doesn't help (that isn't handled while we are halted) and > async_run_on_cpu()/run_on_cpu() doesn't reliably reset the CPU when we > want. > > I've ever tried pausing all CPUs

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

Hi Paolo, Thank you for the correction! Greatly appreciated and it worked. I tested all combinations of Linux host using virtual Socket-CAN and pcm3680 and mioe3680 client QEmu Linux environments using Linux Socket-CAN drivers, sending and receiving from each-other (all combinations;

[Qemu-devel] [PATCH] virtio-gpu: disallow vIOMMU

virtio-gpu has special code path that bypassed vIOMMU protection. So for now let's disable iommu_platform for the device until we fully support that (if needed). After the patch, both virtio-vga and virtio-gpu won't allow to boot with iommu_platform parameter set. CC: Gerd Hoffmann

[Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

To make our efforts on QEMU testing easier to consume by contributors, let's add a document. For example, Patchew reports build errors on patches that should be relatively easy to reproduce with a few steps, and it is much nicer if there is such a documentation that it can refer to. This focuses

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 6:36 PM, Alex Bennée wrote: > Fam Zheng writes: >> +Prerequisites >> +- >> + >> +Install "docker" with the system package manager and start the Docker >> service >> +on your development machine, then make sure you have

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 7:04 PM, Stefan Hajnoczi wrote: > On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: > > Thanks for writing this! > > I have only reviewed some parts in detail. Thanks for the review! I've made all the fixes (except for the buses spelling. :).

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 10:51 PM, Eric Blake wrote: > On 01/28/2018 09:31 PM, Fam Zheng wrote: >> To make our efforts on QEMU testing easier to consume by contributors, >> let's add a document. For example, Patchew reports build errors on >> patches that should be relativly

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

Hi Pavel, Paolo, I tried to rerun my environment to test however it seems the interface has changed a little and my standard program options cause complaints. Unfortunately I don’t have too much time to dig through at the moment. My standard startup command is: $

[Qemu-devel] [PATCH] pc: correct misspelled CPU model-id for pc 2.2

Signed-off-by: Wang Xin diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index bb49165..635c8b2 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -617,7 +617,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); #define

[Qemu-devel] [Bug 1746394] [NEW] No provider of glEGLImageTargetTexture2DOES found with NVIDIA proprietary driver

Public bug reported: https://github.com/anholt/libepoxy/issues/148 ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1746394 Title:

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

On 30/01/2018 20:08, Paolo Bonzini wrote: > On 30/01/2018 19:13, Deniz Eren wrote: >> Hi Pavel, Paolo, >> >> I tried to rerun my environment to test however it seems the interface has >> changed a little and my standard program options cause complaints. >> Unfortunately I don’t have too much

Re: [Qemu-devel] [RFC PATCH v5 13/24] kvm: remove BQL lock/unlock

On 23/01/2018 03:54, Pavel Dovgalyuk wrote: > @@ -1861,7 +1861,6 @@ int kvm_cpu_exec(CPUState *cpu) > return EXCP_HLT; > } > > -qemu_mutex_unlock_iothread(); > cpu_exec_start(cpu); > do { > MemTxAttrs attrs; So this means that kvm_cpu_exec is now called

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

On 30/01/2018 19:13, Deniz Eren wrote: > Hi Pavel, Paolo, > > I tried to rerun my environment to test however it seems the interface has > changed a little and my standard program options cause complaints. > Unfortunately I don’t have too much time to dig through at the moment. > > My standard

Re: [Qemu-devel] MTTCG External Halt

On Fri, Jan 5, 2018 at 6:23 PM, Alistair Francis wrote: > On Thu, Jan 4, 2018 at 3:08 AM, Alex Bennée wrote: >> >> Alistair Francis writes: >> >>> Hey guys, I'm super stuck with an ugly MTTCG issue and was wondering >>> if

Re: [Qemu-devel] [PATCH v6 02/23] exec: add ram_debug_ops support

On 1/30/18 4:37 PM, Edgar E. Iglesias wrote: > On Tue, Jan 30, 2018 at 04:34:37PM -0600, Brijesh Singh wrote: >> >> On 1/30/18 3:59 PM, Edgar E. Iglesias wrote: >>> On Mon, Jan 29, 2018 at 11:41:11AM -0600, Brijesh Singh wrote: Currently, the guest memory access for the debug purpose is

Re: [Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

Hi Anatol and Kevin. Even though I am new to Qemu, I have a patch to deliver for multiboot.c (as you know) and so I feel familiar enough to do a review of this patch.  One comment is probably more for maintainers. Comments inline... On 01/29/18 12:43, Anatol Pomozov wrote: Using C structs

Re: [Qemu-devel] [PATCH 2/4] multiboot: load elf sections and section headers

Hi Anatol. I have one comment about sections.c headers (and didn't really look further in that file), and start.S. Comments inline... On 01/29/18 12:43, Anatol Pomozov wrote: Multiboot may load section headers and all sections (even those that are not part of any segment) to target memory.

Re: [Qemu-devel] [qemu-web PATCH] Add "Understanding QEMU devices" blog post

On 29/01/2018 12:27, Thomas Huth wrote: > On 26.01.2018 15:46, Eric Blake wrote: >> On 01/26/2018 06:40 AM, Paolo Bonzini wrote: >>> On 26/01/2018 10:19, Thomas Huth wrote: Last July, Eric Blake wrote a nice summary for newcomers about what QEMU has to do to emulate devices for the

Re: [Qemu-devel] [PATCH] vcpu: create vcpu thread with QEMU_THREAD_DETACHED mode

On 28/01/2018 05:14, CheneyLin wrote: >> This is dangerous, it risks introducing use-after-free bugs in the vCPU >> thread. Can you instead add a qemu_thread_join call where the vCPU goes >> away (e.g. unrealize, I'm not sure)? > > 1. If another thread calls qemu_thread_join, it will block until

Re: [Qemu-devel] [PATCH] qemu-options.hx: Remove confusing spaces in parameter listings

On 30/01/2018 10:36, Thomas Huth wrote: > The spaces between the parameters in the chardev and tpmdev sections > are rather confusing than helpful, and prevent that the lists can be > copy-n-pasted easily for real usage. We also don't use such spaces > in other sections in the documentation, e.g.

Re: [Qemu-devel] [PATCH v6 02/23] exec: add ram_debug_ops support

On Tue, Jan 30, 2018 at 04:34:37PM -0600, Brijesh Singh wrote: > > > On 1/30/18 3:59 PM, Edgar E. Iglesias wrote: > > On Mon, Jan 29, 2018 at 11:41:11AM -0600, Brijesh Singh wrote: > >> Currently, the guest memory access for the debug purpose is performed > >> using the memcpy(). Lets extend the

Re: [Qemu-devel] [PATCH v6 02/23] exec: add ram_debug_ops support

On 1/30/18 3:59 PM, Edgar E. Iglesias wrote: > On Mon, Jan 29, 2018 at 11:41:11AM -0600, Brijesh Singh wrote: >> Currently, the guest memory access for the debug purpose is performed >> using the memcpy(). Lets extend the 'struct MemoryRegion' to include >> ram_debug_ops callbacks. The

[Qemu-devel] [Bug 1186984] Re: large -initrd can wrap around in memory causing memory corruption

The answer is I don't know. Closing this bug seems correct unless someone can reproduce the original problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1186984 Title: large -initrd can wrap

Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support

On 1/30/18 3:46 PM, Brijesh Singh wrote: > > On 1/30/18 11:49 AM, Dr. David Alan Gilbert wrote: >> * Brijesh Singh (brijesh.si...@amd.com) wrote: >>> AMD EPYC processors support memory encryption feature. The feature >>> is reported through CPUID 8000_001F[EAX]. >>> >>> Fn8000_001F [EAX]: >>>

Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

Hello Paolo, thanks much for conversion to acceptable QOM model. On Tuesday 30 of January 2018 15:15:22 Paolo Bonzini wrote: > On 25/01/2018 22:33, Pavel Pisa wrote: > > Hello Paolo, > > > > thanks for suggestions. I understand and fully agree with your > > request to switch to QOM. I have

Re: [Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event

On 1/30/18 2:08 PM, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.si...@amd.com) wrote: >> During machine creation we encrypted the guest bios image, the >> LAUNCH_MEASURE command can be used to retrieve the measurement of >> the encrypted memory region. Emit the SEV_MEASUREMENT event

Re: [Qemu-devel] [PATCH v6 02/23] exec: add ram_debug_ops support

On Mon, Jan 29, 2018 at 11:41:11AM -0600, Brijesh Singh wrote: > Currently, the guest memory access for the debug purpose is performed > using the memcpy(). Lets extend the 'struct MemoryRegion' to include > ram_debug_ops callbacks. The ram_debug_ops can be used to override > memcpy() with

Re: [Qemu-devel] [PATCH v6 01/23] memattrs: add debug attribute

On Mon, Jan 29, 2018 at 11:41:10AM -0600, Brijesh Singh wrote: > Extend the MemTxAttrs to include 'debug' flag. The flag can be used as > general indicator that operation was triggered by the debugger. > > Later in the patch series we set the debug=1 when issuing a memory access > from the

Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support

On 1/30/18 11:49 AM, Dr. David Alan Gilbert wrote: > * Brijesh Singh (brijesh.si...@amd.com) wrote: >> AMD EPYC processors support memory encryption feature. The feature >> is reported through CPUID 8000_001F[EAX]. >> >> Fn8000_001F [EAX]: >> Bit 0 Secure Memory Encryption (SME) supported >>

Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time

Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180130102202.28519-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH 00/18] Clean up

[Qemu-devel] [Bug 1186984] Re: large -initrd can wrap around in memory causing memory corruption

Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1186303] Re: virtual fat do not working in qemu 1.5.0

Triaging old bug tickets... Have you ever bisected the problem? Can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of

[Qemu-devel] [Bug 1084148] Re: Qt5 Beta 1 QProcess start and execute causes segmentation fault on armhf

Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

On 01/30/2018 03:18 PM, John Snow wrote: > > > On 01/30/2018 03:38 AM, Liang Li wrote: >> When doing drive mirror to a low speed shared storage, if there was heavy >> BLK IO write workload in VM after the 'ready' event, drive mirror block job >> can't be canceled immediately, it would keep

Re: [Qemu-devel] [PATCH v3] scripts/make-release: Don't archive .git files

On 30.01.2018 20:33, Cole Robinson wrote: > As was last done in 379e21c25, we don't want .git files for > submodules here, which we aren't presently doing for capstone and > keycodemapdb. > > Rather than delete the offending files before archiving, ask tar > to --exclude=.git > > Signed-off-by:

Re: [Qemu-devel] [PATCH v2 00/13] blockjob: refactor mirror_throttle

ping; I won't respin for patchew until this gets looked over again, sorry :) On 01/19/2018 03:58 PM, John Snow wrote: > mirror_throttle attempts to make sure we yield every so often when we're > doing operations that may not otherwise be as cooperative as we'd like. > > This pattern is useful

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

On 01/30/2018 03:38 AM, Liang Li wrote: > When doing drive mirror to a low speed shared storage, if there was heavy > BLK IO write workload in VM after the 'ready' event, drive mirror block job > can't be canceled immediately, it would keep running until the heavy BLK IO > workload stopped in

Re: [Qemu-devel] SDL2 UI behavior of switching views

On Tue, 30 Jan 2018, Gerd Hoffmann wrote: SDL1 has a single window for all consoles. SDL2 has one window for each console. Fixed. Not switchable, neither for SDL1 nor for SDL2. It sure is possible to make it runtime switchable, but I expect it is more much difficuilt to code up when compared

Re: [Qemu-devel] [PATCH] block/mirror: change the semantic of 'force' of block-job-cancel

On 01/30/2018 03:38 AM, Liang Li wrote: > When doing drive mirror to a low speed shared storage, if there was heavy > BLK IO write workload in VM after the 'ready' event, drive mirror block job > can't be canceled immediately, it would keep running until the heavy BLK IO > workload stopped in

Re: [Qemu-devel] [PATCH v6 18/23] sev: emit the SEV_MEASUREMENT event

* Brijesh Singh (brijesh.si...@amd.com) wrote: > During machine creation we encrypted the guest bios image, the > LAUNCH_MEASURE command can be used to retrieve the measurement of > the encrypted memory region. Emit the SEV_MEASUREMENT event so that > libvirt can grab the measurement value as soon

[Qemu-devel] [Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

Can you post your commandline for the MSDOS 6.22 issue? NT is known to have a few problems and may be out of scope for what I can help with, but I was under the assumption that MSDOS 6.22 was well-behaved in QEMU. Commandline and steps to reproduce the error may be helpful (any particularly kind

Re: [Qemu-devel] [PATCH v4 0/4] ivshmem: MSI bug fixes

On 30/01/2018 13:30, Markus Armbruster wrote: > Paolo, care to merge these fixes? Ok, will do. Paolo

Re: [Qemu-devel] [PATCH v5] chardev/char-socket: add POLLHUP handler

On 25/01/2018 08:51, Klim Kireev wrote: > The following behavior was observed for QEMU configured by libvirt > to use guest agent as usual for the guests without virtio-serial > driver (Windows or the guest remaining in BIOS stage). > > In QEMU on first connect to listen character device socket >

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

No worries at all Paolo. I was just making sure I didn’t miss something. We have been working on some minor fixups/perf improvements on our end and I will submit those patches after this merges. I figured it would be easier because they will be very small and isolated so easier to review moving

Re: [Qemu-devel] [RFC 0/4] Allow custom socket option in socket_listen and socket_connect

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1517253224-14361-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [RFC 0/4] Allow custom socket option in socket_listen and socket_connect === TEST SCRIPT

[Qemu-devel] [PATCH v3] scripts/make-release: Don't archive .git files

As was last done in 379e21c25, we don't want .git files for submodules here, which we aren't presently doing for capstone and keycodemapdb. Rather than delete the offending files before archiving, ask tar to --exclude=.git Signed-off-by: Cole Robinson --- v2: Use

Re: [Qemu-devel] [PATCH v2 0/4] Updates based on feedback.

On 29/01/2018 14:58, Justin Terry (VM) wrote: > Hi All, > > Is there any additional feedback I can address here to help out the process? > Please let me know. Nothing specifically (it didn't help that most of last week I was sick!). From my point of view, I just need to review the changes you

Re: [Qemu-devel] [PATCH v2 0/4] memory/vfio: notify region_del() when unregister listeners

On 22/01/2018 01:02, Peter Xu wrote: > v2 > - add begin() hooks [Paolo] > - move vfio patch to front [Paolo] > - one more patch for arm devlistener unregister [Paolo] > - one more patch for vhost traces > - removing RFC tag > > This series fixes bug reported here: > >

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: check for NULL BlockDriverState

On 01/30/2018 10:56 AM, Kevin Wolf wrote: > Am 30.01.2018 um 13:38 hat Stefan Hajnoczi geschrieben: >> On Mon, Jan 29, 2018 at 04:41:07PM +0100, Kevin Wolf wrote: >>> Am 24.01.2018 um 12:31 hat Stefan Hajnoczi geschrieben: On Mon, Jan 22, 2018 at 09:01:49AM -0600, Mark Kanda wrote: >

[Qemu-devel] 4.14 linux kernel vs postcopy migration

Hi, It looks like the 4.14 linux kernel has something which breaks postcopy; 4.13 and 4.15 both seem OK, but both Peter and myself ran into problems with double faults after postcopy migration on a Fedora 27 host, and I've recreated the same problem on upstream kernels from v4.14.0 through

Re: [Qemu-devel] [PATCH 00/18] Clean up includes to reduce compile time

On 01/30/2018 07:21 AM, Markus Armbruster wrote: > We have awfully many "touch it, recompile the world" headers. Right > now, I count about fifty that are prerequisites of more than half the > objects in my "build everything" tree. > > Some of them are that way by necessity. Many of them are

Re: [Qemu-devel] [PATCH v4 0/4] ivshmem: MSI bug fixes

Paolo, care to merge these fixes?

Re: [Qemu-devel] [PATCH] qemu-options.hx: Remove confusing spaces in parameter listings

On 01/30/2018 04:36 AM, Thomas Huth wrote: The spaces between the parameters in the chardev and tpmdev sections are rather confusing than helpful, and prevent that the lists can be copy-n-pasted easily for real usage. We also don't use such spaces in other sections in the documentation, e.g.

Re: [Qemu-devel] [PATCH 18/18] Move include qemu/option.h from qemu-common.h to actual users

On 01/30/2018 04:22 AM, Markus Armbruster wrote: > qemu-common.h includes qemu/option.h, but most places that include the > former don't actually need the latter. Drop the include, and add it > to the places that actually need it. > > While there, drop superfluous includes of both headers. > >

Re: [Qemu-devel] [PATCH 17/18] Drop superfluous includes of qapi/qmp/qjson.h

On 01/30/2018 04:22 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > balloon.c | 1 - > block/nbd.c | 1 - > block/quorum.c | 1 - > blockjob.c | 1 - >

Re: [Qemu-devel] [PATCH v5] cocoa.m: Add ability for user to specify mouse ungrab key

> On Jan 30, 2018, at 7:18 AM, Gerd Hoffmann wrote: > > On Fri, Jan 26, 2018 at 04:47:31PM -0500, John Arbuckle wrote: >> Currently the ungrab keys for the Cocoa and GTK interface are Control-Alt-g. > > SDL is the same now, for consistency. > >> This combination may not be

Re: [Qemu-devel] [PATCH 16/18] Drop superfluous includes of qapi/qmp/dispatch.h

On 01/30/2018 04:22 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 1 - > qga/main.c| 1 - > tests/test-qmp-commands.c | 1 - > 3 files changed, 3 deletions(-) Reviewed-by: Eric Blake --

Re: [Qemu-devel] [PATCH 15/18] Include qapi/qmp/qnull.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > target/ppc/translate.c | 1 - > target/ppc/translate_init.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Blake -- Eric Blake,

Re: [Qemu-devel] [PATCH 14/18] Include qapi/qmp/qnum.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/check-qlit.c | 1 - > 1 file changed, 1 deletion(-) Not much to this one :) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat,

Re: [Qemu-devel] [PATCH 13/18] Include qapi/qmp/qbool.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block.c| 1 - > block/blkdebug.c | 1 - > block/curl.c | 1 - > block/qcow2.c | 1 - > block/quorum.c

Re: [Qemu-devel] [PULL v5 00/43] hppa-softmmu

On 30 January 2018 at 04:46, Richard Henderson wrote: > Changes since v4: > * Fix format warnings for 32-bit host. > > > r~ > > > The following changes since commit 30d9fefe1aca1e92c785214aa9201fd7c2287d56: > > Merge remote-tracking branch >

Re: [Qemu-devel] [PATCH 12/18] Include qapi/qmp/qstring.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc

Re: [Qemu-devel] [PATCH v6 05/23] target/i386: add memory encryption feature cpuid support

* Brijesh Singh (brijesh.si...@amd.com) wrote: > AMD EPYC processors support memory encryption feature. The feature > is reported through CPUID 8000_001F[EAX]. > > Fn8000_001F [EAX]: > Bit 0 Secure Memory Encryption (SME) supported > Bit 1 Secure Encrypted Virtualization (SEV) supported >

Re: [Qemu-devel] [PATCH 10/18] Include qapi/qmp/qlist.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > This cleanup makes the number of objects depending on qapi/qmp/qlist.h > drop from 4548 (out of 4739) to 16 in my "build everything" tree. > > Signed-off-by: Markus Armbruster > --- > +++ b/tests/check-qdict.c > @@ -9,9 +9,11

Re: [Qemu-devel] [PATCH 11/18] Include qapi/qmp/qdict.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > This cleanup makes the number of objects depending on qapi/qmp/qdict.h > drop from 4547 (out of 4739) to 368 in my "build everything" tree. > For qapi/qmp/qobject.h, the number drops from 4549 to 390. > > Signed-off-by: Markus Armbruster

Re: [Qemu-devel] [PATCH v4 09/14] pci: Add support for Designware IP block

On Tue, Jan 30, 2018 at 5:18 AM, Marcel Apfelbaum wrote: > Hi Andrei, > > Sorry for letting you wait, > I have some comments/questions below. > > > On 16/01/2018 3:37, Andrey Smirnov wrote: >> >> Add code needed to get a functional PCI subsytem when using in >>

[Qemu-devel] [PULL 04/10] tests: virtio-9p: wait for completion in the test code

In order to test request cancellation, we will need to send multiple requests and wait for the associated replies. Since we poll the ISR to know if a request completed, we may have several replies to parse when we detect ISR was set to 1. This patch moves the waiting out of the reply parsing

[Qemu-devel] [PULL 09/10] tests: virtio-9p: add FLUSH operation test

The idea is to send a victim request that will possibly block in the server and to send a flush request to cancel the victim request. This patch adds two test to verifiy that: - the server does not reply to a victim request that was actually cancelled - the server replies to the flush request

[Qemu-devel] [PULL 01/10] 9pfs: drop v9fs_register_transport()

No good reasons to do this outside of v9fs_device_realize_common(). Signed-off-by: Greg Kurz Reviewed-by: Stefano Stabellini --- hw/9pfs/9p.c | 6 +- hw/9pfs/9p.h | 10 ++ hw/9pfs/virtio-9p-device.c | 8 ++--

[Qemu-devel] [PULL 08/10] libqos/virtio: return length written into used descriptor

When a 9p request is flushed (ie, cancelled) by the guest, the device is expected to simply mark the request as used, without sending a 9p reply (ie, without writing anything into the used buffer). To be able to test this, we need access to the length written by the device into the used

[Qemu-devel] [PULL 07/10] tests: virtio-9p: add WRITE operation test

Trivial test of a successful write. Signed-off-by: Greg Kurz (groug, handle potential overflow when computing request size) Reviewed-by: Stefan Hajnoczi --- hw/9pfs/9p-synth.c | 11 + hw/9pfs/9p-synth.h | 1 + tests/virtio-9p-test.c | 62

[Qemu-devel] [PULL 10/10] tests/virtio-9p: explicitly handle potential integer overflows

Signed-off-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- tests/virtio-9p-test.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/tests/virtio-9p-test.c

[Qemu-devel] [PULL 03/10] tests: virtio-9p: move request tag to the test functions

It doesn't really makes sense to hide the request tag from the test functions. It prevents to test the 9p server behavior when passed a wrong tag (ie, still in use or different from P9_NOTAG for a version request). Also the spec says that a tag is reusable as soon as the corresponding request was

[Qemu-devel] [PULL 00/10] 9p patches for 2.12 20180130

The following changes since commit 30d9fefe1aca1e92c785214aa9201fd7c2287d56: Merge remote-tracking branch 'remotes/kraxel/tags/input-20180129-v2-pull-request' into staging (2018-01-29 15:52:27 +) are available in the git repository at: https://github.com/gkurz/qemu.git

[Qemu-devel] [PULL 02/10] 9pfs: Correctly handle cancelled requests

From: Keno Fischer # Background I was investigating spurious non-deterministic EINTR returns from various 9p file system operations in a Linux guest served from the qemu 9p server. ## EINTR, ERESTARTSYS and the linux kernel When a signal arrives that the Linux kernel

[Qemu-devel] [PULL 06/10] tests: virtio-9p: add LOPEN operation test

Trivial test of a successful open. Signed-off-by: Greg Kurz Reviewed-by: Stefan Hajnoczi --- hw/9pfs/9p-synth.c | 5 + hw/9pfs/9p-synth.h | 1 + tests/virtio-9p-test.c | 47 +++ 3 files changed, 53

[Qemu-devel] [PULL 05/10] tests: virtio-9p: use the synth backend

The purpose of virtio-9p-test is to test the virtio-9p device, especially the 9p server state machine. We don't really care what fsdev backend we're using. Moreover, if we want to be able to test the flush request or a device reset with in-flights I/O, it is close to impossible to achieve with a

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

On Tue, Jan 30, 2018 at 04:22:33PM +0100, Gerd Hoffmann wrote: > Hi, > > > > Well, display configuration is going to be rewritten, and while that is > > > in flight adding new config options isn't a good idea b/c things will > > > conflict ... > > I'm wondering how extensive this rewrite is

Re: [Qemu-devel] [PATCH RFC 1/2] s390x/tcg: wire up pci instructions

On Tue, 30 Jan 2018 14:00:12 +0100 David Hildenbrand wrote: > On 29.01.2018 17:52, Cornelia Huck wrote: > > On s390x, pci support is implemented via a set of instructions > > (no mmio). Unfortunately, none of them are documented in the > > PoP; the code is based upon the

Re: [Qemu-devel] [PATCH 09/18] Include qapi/qmp/qobject.h exactly where needed

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc

Re: [Qemu-devel] [PATCH 08/18] qdict qlist: Make most helper macros functions

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > The macro expansions of qdict_put_TYPE() and qlist_append_TYPE() need > qbool.h, qnull.h, qnum.h and qstring.h to compile. We include qnull.h > and qnum.h in the headers, but not qbool.h and qstring.h. Works, > because we include those wherever

Re: [Qemu-devel] [PATCH 07/18] Eliminate qapi/qmp/types.h

On 01/30/2018 04:21 AM, Markus Armbruster wrote: > qapi/qmp/types.h is a convenience header to include a number of > qapi/qmp/ headers. Since we rarely need all of the headers > qapi/qmp/types.h includes, we bypass it most of the time. Most of the > places that use it don't need all the headers,

  1   2   3   >