Hi,
This series failed docker-quick@centos6 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20180323034356.72130-1-ha...@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 0/1] iote
On Thu, Mar 22, 2018 at 01:00:19PM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Mar 9, 2018 at 10:00 AM, Peter Xu wrote:
> > For those monitors who have enabled IO thread, we'll offload the
> > responding procedure into IO thread. The main reason is that chardev is
> > not thread safe, and w
On Thu, Mar 22, 2018 at 11:22:14AM +0100, Marc-André Lureau wrote:
> Hi
>
> On Fri, Mar 9, 2018 at 10:00 AM, Peter Xu wrote:
> > Having "allow-oob" to true for a command does not mean that this command
> > will always be run in out-of-band mode. The out-of-band quick path will
> > only be execut
Hi all,
I have noticed that the decoding part in ARM/A32 does not verify the
opcodes for SWP instructions. The opcode field ([23:20]) for SWP
instructions should be 0 or 4, and QEMU does not check against these
values.
Other opcode values less than 8 are Undefined within the encoding
space of syc
On 03/21/2018 02:04 PM, Zhang Chen wrote:
Hi Suiheng,
I made a new guest image and retest it, and got the same bug from latest branch.
I found that after the COLO checkpoint begin, the secondary guest always send
reset request to Qemu like someone still push the reset button in the guest.
And
Hi,
This patch is to fix iotest case 185 and based on the latest commit
d522e0bd18364 --- "gitmodules: Use the QEMU mirror of qemu-palcode".
Thanks!
Change Log (v2):
* Recover the change on the call to bdrv_drain_all but don't resume the
yielded jobs according to Stefan Hajnoczi's comment.
* Cha
Test case 185 failed since commit 4486e89c219 --- "vl: introduce vm_shutdown()".
It's because of the newly introduced function vm_shutdown calls bdrv_drain_all,
which is called later by bdrv_close_all. bdrv_drain_all resumes the jobs
that doubles the speed and offset is doubled.
Some jobs' status a
On 03/22/2018 03:09 PM, Max Filippov wrote:
> Change #include to #include "xtensa-isa.h" in imported
> files to make references to local files consistent.
>
> Signed-off-by: Max Filippov
Reviewed-by: Philippe Mathieu-Daudé
> ---
> target/xtensa/import_core.sh | 1 +
> 1 file changed, 1 inser
On 03/22/2018 05:37 PM, Max Filippov wrote:
> On Thu, Mar 22, 2018 at 12:16 PM, Eric Blake wrote:
>> On 03/22/2018 01:09 PM, Max Filippov wrote:
>>>
>>> Fix definitions of existing cores and core importing script.
>>
>> This mentions the script...
>> ...but only touches .c files.
>
> Yeah, I init
On Thu, Mar 22, 2018 at 05:12:26PM +0100, Laurent Vivier wrote:
> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> accel/tcg/translate-all.c | 5 +-
> block/quorum.c | 6 +--
On 03/15/2018 10:34 AM, Peter Maydell wrote:
> If the GIC has the security extension support enabled, then a
> non-secure access to ICC_PMR must take account of the non-secure
> view of interrupt priorities, where real priorities 0..0x7f
> are secure-only and not visible to the non-secure guest, an
On 03/22/2018 06:58 PM, Laurent Vivier wrote:
> move all prologue specific parts to
> prologue.inc.c in arch directory
>
> Signed-off-by: Laurent Vivier
Reviewed-by: Philippe Mathieu-Daudé
> ---
> linux-user/aarch64/prologue.inc.c| 21 ++
> linux-user/alpha/prologue.inc.c | 9 +
>
Hi Laurent,
On 03/22/2018 01:12 PM, Laurent Vivier wrote:
> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> accel/tcg/translate-all.c | 5 +-
> block/quorum.c | 6 +--
> hw
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180322215833.7713-1-laur...@vivier.eu
Subject: [Qemu-devel] [PATCH for 2.13 0/5] linux-user: move arch specific parts
to arch directories
=== TEST SCRIPT BEGIN ===
#!/bin/
"Richard W.M. Jones" writes:
> DJ, am I remembering correctly that you tried the test case on the
> HiFive evaluation board and it didn't demonstrate the bug?
I tested it on the vc707 board, without seeing the bug.
I can test other test cases if needed, I've got the board running Fedora
at the m
On Thu, Mar 22, 2018 at 3:17 PM, DJ Delorie wrote:
> "Richard W.M. Jones" writes:
> > DJ, am I remembering correctly that you tried the test case on the
> > HiFive evaluation board and it didn't demonstrate the bug?
>
> I tested it on the vc707 board, without seeing the bug.
>
> I can test other
On Thu, Mar 22, 2018 at 02:06:24PM -0700, Michael Clark wrote:
> On Mon, Mar 19, 2018 at 2:39 PM, Michael Clark wrote:
> > On Mon, Mar 19, 2018 at 12:42 PM, Richard W.M. Jones
> > wrote:
> >> Did you see the problem with restoring floating point registers on
> >> context switch? The test case is
instead of calling setup_frame() conditionnaly to a list of knowm targets,
define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function
and call it only if the macro is defined
Signed-off-by: Laurent Vivier
---
linux-user/aarch64/signal.inc.c| 1 +
linux-user/alpha/signal.inc.c
move all prologue specific parts to
prologue.inc.c in arch directory
Signed-off-by: Laurent Vivier
---
linux-user/aarch64/prologue.inc.c| 21 ++
linux-user/alpha/prologue.inc.c | 9 +
linux-user/arm/prologue.inc.c| 23 ++
linux-user/cris/prologue.inc.c | 19 ++
linux-
Some files like signal.c are really hard to read
because all architectures are mixed in the same
file.
This series moves from signal.c these parts to
the architecture dedicated directories in linux-user.
Moerover, this allows to compare easier functions
between architectures (it helps to debug pro
Signed-off-by: Laurent Vivier
---
linux-user/signal.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 2c08ca14cf..514145b299 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -253,17 +253,15 @@ int do_sigproc
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: qemu (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1749393
Title:
sbrk
Instead of using "1.0" as the system version of SMBIOS, we should use
mc->name for mach-virt machine type to be consistent other architectures.
With this patch, "dmidecode -t 1" (e.g., "-M virt-2.12,accel=kvm") will
show:
Handle 0x0100, DMI type 1, 27 bytes
System Information
M
On Wed, Mar 21, 2018 at 05:22:07PM +0200, Michael S. Tsirkin wrote:
> Our rule right now is to use <> for external headers,
> "" for internal ones. The idea was to avoid conflicts
> between e.g. a system file named and an
> internal one by the same name.
>
> Unfortunately we use -I compiler flag
On Mon, Mar 19, 2018 at 2:39 PM, Michael Clark wrote:
>
>
> On Mon, Mar 19, 2018 at 12:42 PM, Richard W.M. Jones
> wrote:
>
>> On Mon, Mar 19, 2018 at 11:35:51AM -0700, Michael Clark wrote:
>> > The RISC-V post-merge spec conformance and cleanup series has had a lot
>> of
>> > testing. I've been
Hi Peter,
On 03/22/2018 03:29 PM, Peter Maydell wrote:
> On 22 March 2018 at 14:23, Andrew Jones wrote:
>> On Thu, Mar 15, 2018 at 01:34:41PM +, Peter Maydell wrote:
>>> If the GIC has the security extension support enabled, then a
>>> non-secure access to ICC_PMR must take account of the non
On Thu, Mar 22, 2018 at 12:16 PM, Eric Blake wrote:
> On 03/22/2018 01:09 PM, Max Filippov wrote:
>>
>> Fix definitions of existing cores and core importing script.
>
> This mentions the script...
> ...but only touches .c files.
Yeah, I initially did it in a single patch, but then split it into
t
On 22/03/2018 20:29, Michael S. Tsirkin wrote:
> On Wed, Mar 21, 2018 at 05:22:03PM +0100, Kevin Wolf wrote:
>>> It's all still very much a non-standard convention and so less robust
>>> than prefixing file name with a project-specifix prefix.
>> I've always had the impression that it's by far the
This is now fixed on master, as of
3be2e41b3323169852dca11ffe6ff772c33e5aaa.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1740219
Title:
static linux-user ARM emulation has several-second startup
Yeah I have a use case, before a last sync on a storage migration we suspend a
VM -> send the last diffs -> mount the new storage server and after that we
change a symlink -> call reopen -> check if all file descriptors are changed
before resuming the VM.
Dion
> Op 22 mrt. 2018 om 18:39 heeft
In commit 244a5668106297378391b768e7288eb157616f64 another
file descriptor to BDRVRawState is added. When we try to issue the
reopen command only s->fd is reopened; lock_fd could still hold an old
file descriptor "possibly" pointing to another file.
- change raw_reopen_prepare so it checks use_loc
On Thu, Mar 22, 2018 at 02:42:55PM -0500, Eric Blake wrote:
> On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote:
> > Make sure all generated files go into qemu-build subdirectory.
> > We can then include them like this:
> > #include "qemu-build/trace.h"
> >
> > This serves two purposes:
> > - mak
On Thu, Mar 22, 2018 at 14:41:05 +0800, Richard Henderson wrote:
(snip)
> Another thought re all of the soft_is_normal || soft_is_zero checks that
> you're
> performing. I think it would be nice if we could work with
> float*_unpack_canonical so that we don't have to duplicate work. E.g.
>
> /*
On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote:
Make sure all generated files go into qemu-build subdirectory.
We can then include them like this:
#include "qemu-build/trace.h"
This serves two purposes:
- make it easy to detect which files are in the source
directory (a bit more work for
On 03/22/2018 02:10 PM, Peter Maydell wrote:
[snip lots of good advice]
Code review isn't only about "does this behave as the
secification requires". It can also catch:
* simple logic bugs
* places where the code is more complicated than it needs to be
* style issues
* places where a QE
On Wed, Mar 21, 2018 at 05:22:03PM +0100, Kevin Wolf wrote:
> > It's all still very much a non-standard convention and so less robust
> > than prefixing file name with a project-specifix prefix.
>
> I've always had the impression that it's by far the most common
> convention, to the point that I'd
Make sure all generated files go into qemu-build subdirectory.
We can then include them like this:
#include "qemu-build/trace.h"
This serves two purposes:
- make it easy to detect which files are in the source
directory (a bit more work for writers, easier for readers)
- reduce chances of confl
On 19 March 2018 at 16:25, Stefan Hajnoczi wrote:
> On Mon, Mar 19, 2018 at 01:17:43PM +, Peter Maydell wrote:
>> We have a mirror of the qemu-palcode repository on
>> git.qemu.org; use that instead of the upstream github,
>> in line with our general policy of keeping and using
>> a mirror for
On 22 March 2018 at 19:12, Eric Blake wrote:
> Or if we don't patch the false negative, you can bypass checkpatch with an
> ugly hack:
>
> return 0 + (...) | (...);
>
> (I'm NOT going to do that bypass - it's too ugly for my taste)
Yeah, that's definitely not something we should be doing.
checkpa
On 03/22/2018 01:09 PM, Max Filippov wrote:
Hello,
this series adds .inc. to the names of non-top level xtensa core-specific
files and fixes script import_core.sh so that it does it automatically.
It also adds a fixup to the script that changes #include
to #include "xtensa-isa.h".
Max Filippov
On 03/22/2018 01:09 PM, Max Filippov wrote:
Fix definitions of existing cores and core importing script.
This mentions the script...
Signed-off-by: Max Filippov
---
target/xtensa/core-dc232b.c | 4 ++--
target/xtensa/core-dc232b/{gdb-config.c =>
On 03/22/2018 01:09 PM, Max Filippov wrote:
Add .inc. to the names of files imported from configuration overlay in
the import_core.sh script to follow the rule of naming non-top level
source files.
Signed-off-by: Max Filippov
---
target/xtensa/import_core.sh | 8
1 file changed, 4 i
On 03/22/2018 01:00 PM, Peter Maydell wrote:
On 22 March 2018 at 17:57, wrote:
Checking PATCH 4/4: Remove unnecessary variables for function return value...
ERROR: return is not a function, parentheses are not required
#251: FILE: target/mips/dsp_helper.c:3281:
+return (temp[1] << 63) | (t
On 22 March 2018 at 18:26, Michael Clark wrote:
> Besides some trivial cleanups (erroneous comments, dead-code), and the cpu
> init work we were asked to work on by Peter Maydell, the focus of the
> changes are specification conformance. e.g. cases where we were trapping on
> CSR accesses when we
On Thu, Mar 22, 2018 at 02:13:58PM +0100, Vitaly Kuznetsov wrote:
> We can also expose Hyper-V frequency MSRs when reenlightenment feature is
> enabled and TSC frequency is known, Hyper-V on KVM will provide stable TSC
> page clocksources to its guests.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
>
On Thu, Mar 22, 2018 at 02:13:58PM +0100, Vitaly Kuznetsov wrote:
> We can also expose Hyper-V frequency MSRs when reenlightenment feature is
> enabled and TSC frequency is known, Hyper-V on KVM will provide stable TSC
> page clocksources to its guests.
>
> Signed-off-by: Vitaly Kuznetsov
> ---
>
On Thu, Mar 22, 2018 at 04:58:03PM +0300, Roman Kagan wrote:
> On Thu, Mar 22, 2018 at 10:22:18AM -0300, Eduardo Habkost wrote:
> > On Thu, Mar 22, 2018 at 04:00:14PM +0300, Roman Kagan wrote:
> > > On Wed, Mar 21, 2018 at 05:19:24PM -0300, Eduardo Habkost wrote:
> > > > On Wed, Mar 21, 2018 at 07:
On 22 March 2018 at 14:23, Andrew Jones wrote:
> On Thu, Mar 15, 2018 at 01:34:41PM +, Peter Maydell wrote:
>> If the GIC has the security extension support enabled, then a
>> non-secure access to ICC_PMR must take account of the non-secure
>> view of interrupt priorities, where real prioritie
V1-V2
accidentally appeared __nocheck after rebase
this patch set also rebased after latest pull request
This patch set includes patches which were reverted by commit
ee86981bd, due to build problem on 32 powerpc/arm architecture.
Also it includes patch to fix build
([PATCH v4] migration:
On Thu, Mar 22, 2018 at 2:56 AM, Philippe Mathieu-Daudé
wrote:
> Hi Michael,
>
> On 03/20/2018 07:25 PM, Michael Clark wrote:
> > The following changes since commit f1a63fcfcd92c88be8942b5ae71aef
> 9749a4f135:
> >
> > Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +)
> >
> > ar
On 22 March 2018 at 18:18, Max Filippov wrote:
> Signed-off-by: Max Filippov
> ---
> linux-user/xtensa/syscall.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> delete mode 100644 linux-user/xtensa/syscall.h
>
> diff --git a/linux-user/xtensa/syscall.h b/linux-user/xtensa/syscall.h
> d
Postcopy total blocktime is available on destination side only.
But query-migrate was possible only for source. This patch
adds ability to call query-migrate on destination.
To be able to see postcopy blocktime, need to request postcopy-blocktime
capability.
The query-migrate command will show fol
Right now it could be used on destination side to
enable vCPU blocktime calculation for postcopy live migration.
vCPU blocktime - it's time since vCPU thread was put into
interruptible sleep, till memory page was copied and thread awake.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Alexey P
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in
case this feature is provided by kernel.
PostcopyBlocktimeContext is encapsulated inside postcopy-ram.c,
due to it being a postcopy-only feature.
Also it defines PostcopyBlocktimeContext's instance live time.
Information from P
Signed-off-by: Max Filippov
---
linux-user/xtensa/syscall.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 linux-user/xtensa/syscall.h
diff --git a/linux-user/xtensa/syscall.h b/linux-user/xtensa/syscall.h
deleted file mode 100644
index e69de29bb2d1..
--
2.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Alexey Perevalov
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
docs/devel/migration.rst | 14 ++
1 file changed, 14 insertions(+)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index e32b087..9342a8
This patch provides blocktime calculation per vCPU,
as a summary and as a overlapped value for all vCPUs.
This approach was suggested by Peter Xu, as an improvements of
previous approch where QEMU kept tree with faulted page address and cpus bitmask
in it. Now QEMU is keeping array with faulted pa
This patch just requests blocktime calculation,
and check it in case when UFFD_FEATURE_THREAD_ID feature is set
on the host.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Alexey Perevalov
Reviewed-by: Juan Quintela
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 16
Change #include to #include "xtensa-isa.h" in imported
files to make references to local files consistent.
Signed-off-by: Max Filippov
---
target/xtensa/import_core.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/xtensa/import_core.sh b/target/xtensa/import_core.sh
index 58a42987d
Add .inc. to the names of files imported from configuration overlay in
the import_core.sh script to follow the rule of naming non-top level
source files.
Signed-off-by: Max Filippov
---
target/xtensa/import_core.sh | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/targe
Fix definitions of existing cores and core importing script.
Signed-off-by: Max Filippov
---
target/xtensa/core-dc232b.c | 4 ++--
target/xtensa/core-dc232b/{gdb-config.c => gdb-config.inc.c} | 0
target/xtensa/core-dc232b/{xtensa-modules.c => x
Hello,
this series adds .inc. to the names of non-top level xtensa core-specific
files and fixes script import_core.sh so that it does it automatically.
It also adds a fixup to the script that changes #include
to #include "xtensa-isa.h".
Max Filippov (3):
target/xtensa: add .inc. to non-top le
On 22 March 2018 at 17:57, wrote:
> Checking PATCH 4/4: Remove unnecessary variables for function return value...
> ERROR: return is not a function, parentheses are not required
> #251: FILE: target/mips/dsp_helper.c:3281:
> +return (temp[1] << 63) | (temp[0] >> 1);
This looks like a bug in
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180322161226.29796-1-lviv...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from
scripts/coccinelle
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=ba
On 21 March 2018 at 14:41, Kevin Wolf wrote:
> The following changes since commit f1a63fcfcd92c88be8942b5ae71aef9749a4f135:
>
> Update version for v2.12.0-rc0 release (2018-03-20 19:04:22 +)
>
> are available in the git repository at:
>
> git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
On 22 March 2018 at 17:30, Eric Blake wrote:
> I'm less certain of whether our Coccinelle scripts have easy ways to exclude
> specific files. We already have scripts/cocci-macro-file.h to help
> Coccinelle not choke on some our existing files, but I'm not sure if
> Coccinelle has a config-file li
[ Cc: qemu-block ]
Am 22.03.2018 um 18:20 hat Dion Bosschieter geschrieben:
> In commit 244a5668106297378391b768e7288eb157616f64 another
> file descriptor to BDRVRawState is added. When we try to issue the
> reopen command only s->fd is reopened; lock_fd could still hold an old
> file descriptor "
Marcelo Tosatti writes:
> On Tue, Mar 20, 2018 at 06:34:59PM +0100, Vitaly Kuznetsov wrote:
>> KVM recently gained support for Hyper-V Reenlightenment MSRs which are
>> required to make KVM-on-Hyper-V enable TSC page clocksource to its guests
>> when INVTSC is not passed to it (and it is not pass
On 03/22/2018 12:19 PM, Max Filippov wrote:
These files were autogenerated, fixing them doesn't make much sense.
Good to know. They have been already updated by a couple of patches:
8f0a3716e4 Clean up includes
d8e39b7062 Use #include "..." for our own headers, <...> for others
Perhaps impor
On Thu, Mar 22, 2018 at 10:23 AM, Peter Maydell
wrote:
> On 22 March 2018 at 17:19, Max Filippov wrote:
>> Ok, I can add a fixup that changes #include to #include
>> "xtensa-isa.h".
>> Adding #include "qemu/osdep.h" there seems pointless to me.
>
> Every top level .c file must start with includi
On 22 March 2018 at 17:19, Max Filippov wrote:
> Ok, I can add a fixup that changes #include to #include
> "xtensa-isa.h".
> Adding #include "qemu/osdep.h" there seems pointless to me.
Every top level .c file must start with including osdep.h.
Other headers that it might include rely on that.
It
On Thu, Mar 22, 2018 at 9:58 AM, Laurent Vivier wrote:
> On 22/03/2018 17:51, Max Filippov wrote:
>> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
>>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> target/xtensa/core-
On Tue, Mar 20, 2018 at 06:34:59PM +0100, Vitaly Kuznetsov wrote:
> KVM recently gained support for Hyper-V Reenlightenment MSRs which are
> required to make KVM-on-Hyper-V enable TSC page clocksource to its guests
> when INVTSC is not passed to it (and it is not passed by default in Qemu
> as it e
On Thu, Mar 22, 2018 at 9:59 AM, Eric Blake wrote:
> On 03/22/2018 11:51 AM, Max Filippov wrote:
>>
>> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier
>> wrote:
>>>
>>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> target/xt
On 03/22/2018 11:51 AM, Max Filippov wrote:
On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
target/xtensa/core-dc232b/xtensa-modules.c | 56 ++
target/xten
On 22/03/2018 17:51, Max Filippov wrote:
> On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
>> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> target/xtensa/core-dc232b/xtensa-modules.c | 56
>> ++
On Thu, Mar 22, 2018 at 9:12 AM, Laurent Vivier wrote:
> Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> target/xtensa/core-dc232b/xtensa-modules.c | 56
> ++
> target/xtensa/core-dc233c/xtensa-modules.c
Le 22/03/2018 à 12:13, Laurent Vivier a écrit :
> Le 22/03/2018 à 12:07, Peter Maydell a écrit :
>> On 22 March 2018 at 11:05, Peter Maydell wrote:
>>> On 22 March 2018 at 10:36, Laurent Vivier wrote:
It goes wrong in this part:
+ */
+if (is_write && info->si_signo ==
On 03/22/2018 11:12 AM, Laurent Vivier wrote:
I've re-run some scripts from the coccinelle directory,
and they have found some problems.
This series fixes them.
Laurent Vivier (4):
error: Strip trailing '\n' from error string arguments (again again)
error: Remove NULL checks on error_prop
22.03.2018 19:19, Eric Blake wrote:
On 03/22/2018 10:43 AM, Vladimir Sementsov-Ogievskiy wrote:
+# Returns: error on one of the following conditions:
+# - the server is not running
+# - export is not found
+# - bitmap is not found
+# - bitmap is disabled
On 03/22/2018 11:12 AM, Laurent Vivier wrote:
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
+++ b/hw/arm/exynos4210.c
@@ -156,12 +156,7 @@ void exynos4210_write_secondary(ARMCPU *cpu,
static uint64_t exynos4210_calc_affinity(int cpu)
On 22/03/2018 16:28, Stefan Hajnoczi wrote:
> co_queue_wakeup is currently implemented in a recursive fashion. Pathological
> patterns of aio_co_enter() between coroutines can cause stack exhaustion.
>
> This patch series implements co_queue_wakeup iteratively and avoids stack
> exhaustion.
>
>
On Mon, Mar 19, 2018 at 03:15:31PM +0800, Tiwei Bie wrote:
> This patch set does some small extensions to vhost-user protocol
> to support VFIO based accelerators, and makes it possible to get
> the similar performance of VFIO based PCI passthru while keeping
> the virtio device emulation in QEMU.
On 03/22/2018 11:12 AM, Laurent Vivier wrote:
I've re-run some scripts from the coccinelle directory,
and they have found some problems.
This series fixes them.
Laurent Vivier (4):
error: Strip trailing '\n' from error string arguments (again again)
This is user-visible, so appropriate dur
* Laurent Vivier (lviv...@redhat.com) wrote:
> Re-run Coccinelle script scripts/coccinelle/qobject.cocci
>
> Signed-off-by: Laurent Vivier
> ---
> block/nvme.c | 11 +--
> monitor.c| 2 +-
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/block/nvme.c b/block/nvme
On 03/22/2018 10:43 AM, Vladimir Sementsov-Ogievskiy wrote:
+# Returns: error on one of the following conditions:
+# - the server is not running
+# - export is not found
+# - bitmap is not found
+# - bitmap is disabled
+# - bitmap is locked
Do
On Mon, Mar 19, 2018 at 03:15:37PM +0800, Tiwei Bie wrote:
> This patch does some small extensions to vhost-user protocol to
> support VFIO based accelerators, and makes it possible to get the
> similar performance of VFIO based PCI passthru while keeping the
> virtio device emulation in QEMU.
>
>
Re-run Coccinelle script scripts/coccinelle/qobject.cocci
Signed-off-by: Laurent Vivier
---
block/nvme.c | 11 +--
monitor.c| 2 +-
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/nvme.c b/block/nvme.c
index 8bca57aae6..c4f3a7bc94 100644
--- a/block/nvme.c
+++ b
Re-run Coccinelle script scripts/coccinelle/err-bad-newline.cocci,
and found new error_report() occurences with '\n'.
Signed-off-by: Laurent Vivier
---
target/i386/hvf/hvf.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/target/i386/hvf/hvf.c b/tar
Re-run Coccinelle script scripts/coccinelle/return_directly.cocci
Signed-off-by: Laurent Vivier
---
accel/tcg/translate-all.c | 5 +-
block/quorum.c | 6 +--
hw/arm/exynos4210.c| 7 +--
hw/block/vhost
I've re-run some scripts from the coccinelle directory,
and they have found some problems.
This series fixes them.
Laurent Vivier (4):
error: Strip trailing '\n' from error string arguments (again again)
error: Remove NULL checks on error_propagate() calls
qdict: remove useless cast
Remov
Re-run Coccinelle patch
scripts/coccinelle/error_propagate_null.cocci
Signed-off-by: Laurent Vivier
---
io/channel-websock.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/io/channel-websock.c b/io/channel-websock.c
index ec48a305f0..e6608b969d 100644
--- a/io/channel-web
On 22.03.2018 10:41, Marc-André Lureau wrote:
> Hi
>
> On Thu, Mar 22, 2018 at 6:42 AM, Thomas Huth wrote:
>> On 21.03.2018 12:52, Marc-André Lureau wrote:
[...]
>>> diff --git a/qmp.c b/qmp.c
>>> index d8f80cb04e..14972b78df 100644
>>> --- a/qmp.c
>>> +++ b/qmp.c
>>> @@ -601,20 +601,6 @@ CpuMode
Public bug reported:
My vmxnet3 network driver (in a closed source custom OS) is unable to
send network packets that are structured as follows: Ethernet-
Header(IPv6-Header(ESP(encrypted data))). I can verify that the packet
is sent in the VM but is dropped in qemu. I first encountered this
proble
21.03.2018 20:33, Eric Blake wrote:
On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
qapi/block.json | 27 +++
blockdev-nbd.c | 23 +++
2 files changed, 50 insertions(+)
diff --git a/qap
Check that two coroutines can queue each other repeatedly without
hitting stack exhaustion.
Switch to qemu_init_main_loop() in main() because coroutines use
qemu_get_aio_context() - they don't know about test-aio's ctx variable.
Signed-off-by: Stefan Hajnoczi
---
tests/test-aio.c | 65 +
QSIMPLEQ_CONCAT(a, b) joins a = a + b. The new QSIMPLEQ_PREPEND(a, b)
API joins a = b + a.
Signed-off-by: Stefan Hajnoczi
---
include/qemu/queue.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/qemu/queue.h b/include/qemu/queue.h
index aa270d2b38..59fd1203a1 100644
--- a/in
21.03.2018 19:57, Eric Blake wrote:
On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
[...]
+
+#define NBD_STATE_DIRTY 1
Does this belong better in nbd.h, alongside NBD_STATE_HOLE? (And
defining it as (1 << 0) might be nicer, too
co_queue_wakeup is currently implemented in a recursive fashion. Pathological
patterns of aio_co_enter() between coroutines can cause stack exhaustion.
This patch series implements co_queue_wakeup iteratively and avoids stack
exhaustion.
This issue was originally reported with qemu-img convert b
qemu_aio_coroutine_enter() is (indirectly) called recursively when
processing co_queue_wakeup. This can lead to stack exhaustion.
This patch rewrites co_queue_wakeup in an iterative fashion (instead of
recursive) with bounded memory usage to prevent stack exhaustion.
qemu_co_queue_run_restart()
1 - 100 of 198 matches
Mail list logo
