[Qemu-devel] [PATCH] qemu-pr-helper: Actually allow users to specify pidfile

Due to wrong specification of arguments to getopt_long() any attempt to set pidfile resulted in: 1) the default to be leaked 2) the @pidfile variable to be set to NULL (because optarg is NULL without this patch). Signed-off-by: Michal Privoznik --- scsi/qemu-pr-helper.c |

[Qemu-devel] [PATCH] ccid-card: include libcacard.h only

When trying to build with latest libcacard-2.5.1, I hit the following error: In file included from hw/usb/ccid-card-passthru.c:12:0: /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only can be included directly" [-Werror=cpp] #warning "Only can be included directly" Signed-off-by:

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

On 03/21/2018 02:06 AM, Michael Clark wrote: > Okay, so this would move byte swapping into TCG generic code instead of the > TCG > backend, unless the backend explicitly supports load/store with byte swap?  Yes. r~

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

Hi all, On 23 March 2018 at 13:27, Laszlo Ersek wrote: > Adding Ard and Marc, and keeping the context undisturbed for his sake. > Comments at the bottom. > > On 03/23/18 13:25, Gerd Hoffmann wrote: >> Hi, >> >> Ok folks, here is a experimental patch series for a legacy free

Re: [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180323225739.17329-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH] monitor: fix expected qmp_capabilities error description regression

On Fri, Mar 23, 2018 at 04:56:34PM -0500, Eric Blake wrote: [...] > > > > > > > Works for me (fwiw, I'll probably need the replace "hack" again, > > because in the RFC series I am about to send, the code is factored out > > / generalized in qmp-dispatch), but that works in the meantime, please

Re: [Qemu-devel] [PATCH for 2.13 v2 14/20] linux-user: move hppa signal.c parts to hppa directory

On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > hppa/signal.c, except adding includes and > exporting setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH for 2.13 v2 13/20] linux-user: move riscv signal.c parts to riscv directory

On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > riscv/signal.c, except adding includes and > exporting setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH for-2.12 1/4] Revert "monitor: enable IO thread for (qmp & !mux) typed"

On Fri, Mar 23, 2018 at 10:49:31AM -0500, Eric Blake wrote: > On 03/23/2018 09:08 AM, Peter Xu wrote: > > This reverts commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1. > > > > Signed-off-by: Peter Xu > > Not fatal to taking this patch as-is, but it's always nice to include a

Re: [Qemu-devel] [PATCH for 2.13 v2 11/20] linux-user: move alpha signal.c parts to alpha directory

On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > alpha/signal.c, except adding includes and > exporting setup_frame() and setup_rt_frame(). > > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé

Re: [Qemu-devel] [PATCH for 2.13 v2 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

On 03/23/2018 07:57 PM, Laurent Vivier wrote: > No code change, only move code from signal.c to > mips/signal.c, except adding includes and > exporting setup_frame() and setup_rt_frame(). > > mips64/signal.c includes mips/signal.c > > Signed-off-by: Laurent Vivier

Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests

On Fri, Mar 23, 2018 at 01:36:28PM -0500, Eric Blake wrote: > On 03/23/2018 01:30 PM, Christian Borntraeger wrote: > > > > Even that didn't work - 'make check' fails with either 1/4 or 4/4 applied > > > in isolation, so I'm squashing them into a single patch. > > > > Yes, "qmp: introduce

Re: [Qemu-devel] [PATCH v2 5/5] Remove unnecessary variables for function return value

On Fri, Mar 23, 2018 at 03:32:02PM +0100, Laurent Vivier wrote: > Re-run Coccinelle script scripts/coccinelle/return_directly.cocci > > Signed-off-by: Laurent Vivier ppc part Acked-by: David Gibson > --- > accel/tcg/translate-all.c

[Qemu-devel] [PATCH for 2.13 v2 03/20] linux-user: move arm signal.c parts to arm directory

No code change, only move code from signal.c to arm/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/arm/signal.c| 754 +

[Qemu-devel] [PATCH for 2.13 v2 18/20] linux-user: move mips/mips64 signal.c parts to mips directory

No code change, only move code from signal.c to mips/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). mips64/signal.c includes mips/signal.c Signed-off-by: Laurent Vivier --- linux-user/mips/signal.c | 382

[Qemu-devel] [PATCH for 2.13 v2 13/20] linux-user: move riscv signal.c parts to riscv directory

No code change, only move code from signal.c to riscv/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/riscv/signal.c| 200 +++ linux-user/riscv/target_signal.h | 3 +

[Qemu-devel] [PATCH for 2.13 v2 19/20] linux-user: move ppc/ppc64 signal.c parts to ppc directory

No code change, only move code from signal.c to ppc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/ppc/signal.c| 671 +

[Qemu-devel] [PATCH for 2.13 v2 20/20] linux-user: define TARGET_ARCH_HAS_SETUP_FRAME

Instead of calling setup_frame() conditionally to a list of known targets, define TARGET_ARCH_HAS_SETUP_FRAME if the target provides the function and call it only if the macro is defined. Signed-off-by: Laurent Vivier --- linux-user/aarch64/target_signal.h| 1 +

[Qemu-devel] [PATCH for 2.13 v2 16/20] linux-user: move i386/x86_64 signal.c parts to i386 directory

No code change, only move code from signal.c to i386/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). x86_64/signal.c includes i386/signal.c Signed-off-by: Laurent Vivier --- linux-user/i386/signal.c | 584

[Qemu-devel] [PATCH for 2.13 v2 08/20] linux-user: move openrisc signal.c parts to openrisc directory

No code change, only move code from signal.c to openrisc/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/openrisc/signal.c| 213 linux-user/openrisc/target_signal.h |

[Qemu-devel] [PATCH for 2.13 v2 17/20] linux-user: move sparc/sparc64 signal.c parts to sparc directory

No code change, only move code from signal.c to sparc/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). sparc64/signal.c includes sparc/signal.c Signed-off-by: Laurent Vivier --- linux-user/signal.c| 604

[Qemu-devel] [PATCH for 2.13 v2 15/20] linux-user: move xtensa signal.c parts to xtensa directory

No code change, only move code from signal.c to xtensa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/signal.c | 253 - linux-user/xtensa/signal.c| 257

[Qemu-devel] [PATCH for 2.13 v2 11/20] linux-user: move alpha signal.c parts to alpha directory

No code change, only move code from signal.c to alpha/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/alpha/signal.c| 262 +++

[Qemu-devel] [PATCH for 2.13 v2 10/20] linux-user: move m68k signal.c parts to m68k directory

No code change, only move code from signal.c to m68k/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/m68k/signal.c| 410

[Qemu-devel] [PATCH for 2.13 v2 09/20] linux-user: move s390x signal.c parts to s390x directory

No code change, only move code from signal.c to s390x/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c| 309 +++

[Qemu-devel] [PATCH for 2.13 v2 01/20] linux-user: create a dummy per arch signal.c

Create a signal-common.h for future use by these new files and use it in the existing signal.c Signed-off-by: Laurent Vivier --- linux-user/Makefile.objs | 2 +- linux-user/aarch64/signal.c| 18 +++ linux-user/alpha/signal.c | 18 +++

[Qemu-devel] [PATCH for 2.13 v2 07/20] linux-user: move nios2 signal.c parts to nios2 directory

No code change, only move code from signal.c to nios2/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/nios2/signal.c| 236 +++ linux-user/nios2/target_signal.h | 4 +

[Qemu-devel] [PATCH for 2.13 v2 02/20] linux-user: move aarch64 signal.c parts to aarch64 directory

No code change, only move code from signal.c to aarch64/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/aarch64/signal.c| 561 +

[Qemu-devel] [PATCH for 2.13 v2 12/20] linux-user: move tilegx signal.c parts to tilegx directory

No code change, only move code from signal.c to tilegx/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/signal.c | 165 - linux-user/tilegx/signal.c| 168

[Qemu-devel] [PATCH for 2.13 v2 05/20] linux-user: move microblaze signal.c parts to microblaze directory

No code change, only move code from signal.c to microblaze/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/microblaze/signal.c| 230 ++

[Qemu-devel] [PATCH for 2.13 v2 06/20] linux-user: move cris signal.c parts to cris directory

No code change, only move code from signal.c to cris/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/cris/signal.c| 171

[Qemu-devel] [PATCH for 2.13 v2 14/20] linux-user: move hppa signal.c parts to hppa directory

No code change, only move code from signal.c to hppa/signal.c, except adding includes and exporting setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/hppa/signal.c| 192 linux-user/hppa/target_signal.h | 3 +

[Qemu-devel] [PATCH for 2.13 v2 04/20] linux-user: move sh4 signal.c parts to sh4 directory

No code change, only move code from signal.c to sh4/signal.c, except adding includes and exporting setup_frame() and setup_rt_frame(). Signed-off-by: Laurent Vivier --- linux-user/sh4/signal.c| 332 +

[Qemu-devel] [PATCH for 2.13 v2 00/20] linux-user: move arch specific parts to arch directories

Some files like signal.c are really hard to read because all architectures are mixed in the same file. This series moves from signal.c these parts to the architecture dedicated directories in linux-user. Moreover, this allows to compare easier functions between architectures (it helps to debug

Re: [Qemu-devel] [PULL 00/10] target-arm queue

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180323184958.14252-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PULL 00/10] target-arm queue === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle

On 23/03/2018 18:47, Eric Blake wrote: > On 03/23/2018 09:31 AM, Laurent Vivier wrote: >> I've re-run some scripts from the coccinelle directory, >> and they have found some problems. >> >> This series fixes them. >> >> v2: only change PATCH 4/4 >>    - keep comments >>    - fix indentation >>   

Re: [Qemu-devel] raw iotest regressions in 2.12.0-rc0

On 03/22/2018 08:54 AM, Peter Xu wrote: On Wed, Mar 21, 2018 at 05:58:48PM -0400, John Snow wrote: ./check -v -raw Failures: 109 132 136 148 152 183 ./check -v raw Failures: 055 Failed 5 of 5 tests Maybe these are known, but I wanted to consolidate them for rc0 for something easy to

Re: [Qemu-devel] [PATCH] monitor: fix expected qmp_capabilities error description regression

On 03/23/2018 10:50 AM, Marc-André Lureau wrote: If we are going to remove below chunk, how about do it in prettier way instead of hacking around the error again? Like: diff --git a/monitor.c b/monitor.c index 77f4c41cfa..849fa23bf9 100644 --- a/monitor.c +++ b/monitor.c @@ -1203,8 +1203,14

Re: [Qemu-devel] [PATCH for-2.12 v2 06/12] qemu-iotests: Test invalid resize on luks

On 03/21/2018 12:37 PM, Kevin Wolf wrote: This tests that the .bdrv_truncate implementation for luks doesn't crash for invalid image sizes. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/210 | 37 + tests/qemu-iotests/210.out | 16

Re: [Qemu-devel] [PATCH for-2.12 0/2] i386/hyperv: fully control Hyper-V features in CPUID

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180323125808.4479-1-rka...@virtuozzo.com Subject: [Qemu-devel] [PATCH for-2.12 0/2] i386/hyperv: fully control Hyper-V features in CPUID === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH for-2.12 v2 03/12] qemu-iotests: Test vdi image creation with QMP

On 03/21/2018 12:37 PM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- tests/qemu-iotests/211 | 246 + tests/qemu-iotests/211.out | 97 ++ tests/qemu-iotests/group | 1 + 3 files changed, 344

[Qemu-devel] [PATCH v2] target-arm: Check undefined opcodes for SWP in A32 decoder

Thanks for the feedback Peter. Removing the redundant check on bit 23 and adding checks for the "should be" bits as well (bits [11:8]). The following patch should make sure we are not treating architecturally Undefined instructions as a SWP, by verifying the opcodes as per section A8.8.229 of

Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig"

On Mon, Mar 12, 2018 at 02:11:11PM +0100, Igor Mammedov wrote: > New option will be used to allow commands, which are prepared/need > to run run in preconfig state. Other commands that should be able > to run in preconfig state, should be ammeded to not expect machine > in initialized state or

Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state

On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote: > Ban it for now, if someone would need it to work early, > one would have to implement checks if HMP command is valid > at preconfig state. > > Signed-off-by: Igor Mammedov > --- > v4: > * v3 was only printing

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

On Mon, Mar 12, 2018 at 02:11:09PM +0100, Igor Mammedov wrote: > This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, > allowing the configuration of QEMU from QMP before the machine jumps > into board initialization code of machine_run_board_init() > > Intent is to allow

[Qemu-devel] [Bug 1663287] Re: Illegal delay slot code causes abort on mips64

** Tags added: mips -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1663287 Title: Illegal delay slot code causes abort on mips64 Status in QEMU: New Bug description: During some randomised

Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig"

On 03/12/2018 08:11 AM, Igor Mammedov wrote: New option will be used to allow commands, which are prepared/need to run run in preconfig state. Other commands that should be able s/run run in/run, during/ to run in preconfig state, should be ammeded to not expect machine s/ammeded/amended/

[Qemu-devel] [Bug 1754372] Re: Set MIPS MSA in ELF Auxiliary Vectors

** Tags added: mips -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1754372 Title: Set MIPS MSA in ELF Auxiliary Vectors Status in QEMU: In Progress Bug description: The MIPS MSA feature is

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

On Fri, Mar 23, 2018 at 03:49:38PM -0500, Eric Blake wrote: > On 03/23/2018 03:42 PM, Eduardo Habkost wrote: > > On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > > > it will allow to reuse parse_NumaOptions() for parsing > > > configuration commands received via QMP interface > > >

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

On Mon, Mar 12, 2018 at 02:11:09PM +0100, Igor Mammedov wrote: > This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, > allowing the configuration of QEMU from QMP before the machine jumps > into board initialization code of machine_run_board_init() > > Intent is to allow

Re: [Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option

On 03/12/2018 08:11 AM, Igor Mammedov wrote: I know you wrote this before softfreeze, but I'm only just now getting a chance to review. ...[1] This option allows pausing QEMU in the new RUN_STATE_PRECONFIG state, allowing the configuration of QEMU from QMP before the machine jumps into board

Re: [Qemu-devel] [PATCH 2/4] error: Remove NULL checks on error_propagate() calls

On 03/22/2018 11:12 AM, Laurent Vivier wrote: Re-run Coccinelle patch scripts/coccinelle/error_propagate_null.cocci Signed-off-by: Laurent Vivier --- io/channel-websock.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Misses an offender in numa.c, why?

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

On 03/23/2018 03:42 PM, Eduardo Habkost wrote: On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: it will allow to reuse parse_NumaOptions() for parsing configuration commands received via QMP interface Signed-off-by: Igor Mammedov --- end: +if (err)

[Qemu-devel] [PATCH for-2.12] tests: Silence false positive warning on generated test name

Running 'make check' on rawhide with gcc 8.0.1 fails: tests/test-visitor-serialization.c: In function 'main': tests/test-visitor-serialization.c:1127:34: error: '/primitives/' directive writing 12 bytes into a region of size between 1 and 128 [-Werror=format-overflow=] The warning is a false

Re: [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions()

On Mon, Mar 12, 2018 at 02:11:08PM +0100, Igor Mammedov wrote: > it will allow to reuse parse_NumaOptions() for parsing > configuration commands received via QMP interface > > Signed-off-by: Igor Mammedov > --- > include/sysemu/numa.h | 1 + > numa.c| 48

Re: [Qemu-devel] [PATCH v4 1/9] numa: postpone options post-processing till machine_run_board_init()

On Mon, Mar 12, 2018 at 02:11:07PM +0100, Igor Mammedov wrote: > in preparation for numa options to being handled via QMP before > machine_run_board_init(), move final numa configuration checks > and processing to machine_run_board_init() so it could take into > account both CLI (via

[Qemu-devel] [PULL 5/5] migration: Fix block migration flag case

From: "Dr. David Alan Gilbert" Fix the case where when a migration with a bad protocol is tried, we leave the block migration capability set. (This is a cut down version of my 'migration: Fix block failure cases' where it's other case was fixed by Peter's dd0ee30caeebbd )

[Qemu-devel] [PULL 4/5] migration/block: compare only read blocks against the rate limiter

From: Peter Lieven only read_done blocks are in the queued to be flushed to the migration stream. submitted blocks are still in flight. Signed-off-by: Peter Lieven Message-Id: <1520507908-16743-6-git-send-email...@kamp.de> Reviewed-by: Juan Quintela

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/5] atapi: change unlimited recursion to while loop

On 03/23/2018 04:17 PM, Paolo Bonzini wrote: > On 23/03/2018 21:08, John Snow wrote: >> >> >> On 02/23/2018 10:26 AM, Paolo Bonzini wrote: >>> Real hardware doesn't have an unlimited stack, so the unlimited >>> recursion in the ATAPI code smells a bit. In fact, the call to >>>

[Qemu-devel] [PULL 1/5] migration: convert socket server to QIONetListener

From: "Daniel P. Berrange" Instead of creating a QIOChannelSocket directly for the migration server socket, use a QIONetListener. This provides the ability to listen on multiple sockets at the same time, so enables full support for IPv4/IPv6 dual stack. For example,

[Qemu-devel] [PULL 3/5] migration/block: limit the number of parallel I/O requests

From: Peter Lieven the current implementation submits up to 512 I/O requests in parallel which is much to high especially for a background task. This patch adds a maximum limit of 16 I/O requests that can be submitted in parallel to avoid monopolizing the I/O device.

[Qemu-devel] [PULL 2/5] migration: Fix rate limiting issue on RDMA migration

From: Lidong Chen RDMA migration implement save_page function for QEMUFile, but ram_control_save_page do not increase bytes_xfer. So when doing RDMA migration, it will use whole bandwidth. Signed-off-by: Lidong Chen Message-Id:

[Qemu-devel] [PULL 0/5] migration queue

From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> The following changes since commit 4c2c1015905fa1d616750dfe024b4c0b35875950: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20180323' into staging (2018-03-23 10:20:54 +) are available in the Git repos

Re: [Qemu-devel] [PATCH] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

On Fri, Mar 16, 2018 at 07:36:42AM -0700, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace > with > per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE > in order that to improve

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 0/5] atapi: change unlimited recursion to while loop

On 23/03/2018 21:08, John Snow wrote: > > > On 02/23/2018 10:26 AM, Paolo Bonzini wrote: >> Real hardware doesn't have an unlimited stack, so the unlimited >> recursion in the ATAPI code smells a bit. In fact, the call to >> ide_transfer_start easily becomes a tail call with a small change >>

Re: [Qemu-devel] [PATCH v5.2 for 2.13 3/4] docs: tpm: add VM save/restore example and troubleshooting guide

* Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > On 03/21/2018 02:42 PM, Dr. David Alan Gilbert wrote: > > * Stefan Berger (stef...@linux.vnet.ibm.com) wrote: > > > Extend the docs related to TPM with specs related to VM save and > > > restore and a troubleshooting guide for TPM migration. >

Re: [Qemu-devel] [RFC PATCH 0/5] atapi: change unlimited recursion to while loop

On 02/23/2018 10:26 AM, Paolo Bonzini wrote: > Real hardware doesn't have an unlimited stack, so the unlimited > recursion in the ATAPI code smells a bit. In fact, the call to > ide_transfer_start easily becomes a tail call with a small change > to the code (patch 4). The remaining four

Re: [Qemu-devel] [PATCH v3] RISC-V: Fix riscv_isa_string memory size bug

On Thu, 22 Mar 2018 15:17:16 PDT (-0700), d...@redhat.com wrote: "Richard W.M. Jones" writes: DJ, am I remembering correctly that you tried the test case on the HiFive evaluation board and it didn't demonstrate the bug? I tested it on the vc707 board, without seeing the

Re: [Qemu-devel] [PATCH for-2.12 2/2] i386/hyperv: error out if features requested but unsupported

On Fri, Mar 23, 2018 at 03:58:08PM +0300, Roman Kagan wrote: > In order to guarantee compatibility on migration, QEMU should have > complete control over the features it announces to the guest via CPUID. > > However, for a number of Hyper-V-related cpu properties, if the > corresponding feature

Re: [Qemu-devel] [PATCH v3 2/2] i386/kvm: lower requirements for Hyper-V frequency MSRs exposure

On Fri, Mar 23, 2018 at 12:45:30PM +0300, Roman Kagan wrote: > On Thu, Mar 22, 2018 at 03:38:13PM -0300, Eduardo Habkost wrote: > > On Thu, Mar 22, 2018 at 04:58:03PM +0300, Roman Kagan wrote: > > > On Thu, Mar 22, 2018 at 10:22:18AM -0300, Eduardo Habkost wrote: > > > > On Thu, Mar 22, 2018 at

Re: [Qemu-devel] [PATCH for-2.12 1/2] i386/hyperv: add hv-frequencies cpu property

On Fri, Mar 23, 2018 at 03:58:07PM +0300, Roman Kagan wrote: > In order to guarantee compatibility on migration, QEMU should have > complete control over the features it announces to the guest via CPUID. > > However, the declared availability of Hyper-V frequency MSRs > (HV_X64_MSR_TSC_FREQUENCY

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

> Actually, you only need the parent to get the status from the child, which can be passed in other way than through common memory. Certainly, it *can* be, but the glibc code we're trying to run in the guest here doesn't do it in some other way, it uses common memory. Having QEMU effectively

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/5] error: Remove NULL checks on error_propagate() calls

On 23.03.2018 15:32, Laurent Vivier wrote: > Re-run Coccinelle patch > scripts/coccinelle/error_propagate_null.cocci > > Signed-off-by: Laurent Vivier > --- > io/channel-websock.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[Qemu-devel] [Bug 1673976] Re: linux-user clone() can't handle glibc posix_spawn() (causes locale-gen to assert)

Hello Sorry for the delay... Actually, you only need the parent to get the status from the child, which can be passed in other way than through common memory. The idea is to use pipefd to actually wait for the child to either terminate or successfully call execve. As follow: When the

[Qemu-devel] [PULL 10/10] target/arm: Always set FAR to a known unknown value for debug exceptions

For debug exceptions due to breakpoints or the BKPT instruction which are taken to AArch32, the Fault Address Register is architecturally UNKNOWN. We were using that as license to simply not set env->exception.vaddress, but this isn't correct, because it will expose to the guest whatever old

[Qemu-devel] [PULL 08/10] target/arm: Factor out code to calculate FSR for debug exceptions

When a debug exception is taken to AArch32, it appears as a Prefetch Abort, and the Instruction Fault Status Register (IFSR) must be set. The IFSR has two possible formats, depending on whether LPAE is in use. Factor out the code in arm_debug_excp_handler() which picks an FSR value into its own

[Qemu-devel] [PULL 07/10] target/arm: Honour MDCR_EL2.TDE when routing exceptions due to BKPT/BRK

The MDCR_EL2.TDE bit allows the exception level targeted by debug exceptions to be set to EL2 for code executing at EL0. We handle this in the arm_debug_target_el() function, but this is only used for hardware breakpoint and watchpoint exceptions, not for the exception generated when the guest

[Qemu-devel] [PULL 09/10] target/arm: Set FSR for BKPT, BRK when raising exception

Now that we have a helper function specifically for the BRK and BKPT instructions, we can set the exception.fsr there rather than in arm_cpu_do_interrupt_aarch32(). This allows us to use our new arm_debug_exception_fsr() helper. In particular this fixes a bug where we were hardcoding the

[Qemu-devel] [PULL 03/10] hw/intc/arm_gicv3: Fix secure-GIC NS ICC_PMR and ICC_RPR accesses

If the GIC has the security extension support enabled, then a non-secure access to ICC_PMR must take account of the non-secure view of interrupt priorities, where real priorities 0x00..0x7f are secure-only and not visible to the non-secure guest, and priorities 0x80..0xff are shown to the guest as

[Qemu-devel] [PULL 01/10] arm/translate-a64: treat DISAS_UPDATE as variant of DISAS_EXIT

From: Victor Kamensky In OE project 4.15 linux kernel boot hang was observed under single cpu aarch64 qemu. Kernel code was in a loop waiting for vtimer arrival, spinning in TC generated blocks, while interrupt was pending unprocessed. This happened because when qemu tried to

[Qemu-devel] [PULL 05/10] i.MX: Support serial RS-232 break properly

From: Trent Piepho Linux does not detect a break from this IMX serial driver as a magic sysrq. Nor does it note a break in the port error counts. The former is because the Linux driver uses the BRCD bit in the USR2 register to trigger the RS-232 break handler in the kernel,

[Qemu-devel] [PULL 06/10] mach-virt: Set VM's SMBIOS system version to mc->name

From: Wei Huang Instead of using "1.0" as the system version of SMBIOS, we should use mc->name for mach-virt machine type to be consistent other architectures. With this patch, "dmidecode -t 1" (e.g., "-M virt-2.12,accel=kvm") will show: Handle 0x0100, DMI type 1, 27 bytes

[Qemu-devel] [PULL 00/10] target-arm queue

Ten arm-related bug fixes for 2.12... thanks -- PMM The following changes since commit 4c2c1015905fa1d616750dfe024b4c0b35875950: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20180323' into staging (2018-03-23 10:20:54 +) are available in the Git repository at: git

[Qemu-devel] [PULL 04/10] hw/arm/bcm2836: Use the Cortex-A7 instead of Cortex-A15

The BCM2836 uses a Cortex-A7, not a Cortex-A15. Update the device to use the correct CPU. https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not available, so the very similar Cortex-A15 was used.

[Qemu-devel] [PULL 02/10] sdhci: fix incorrect use of Error *

From: Paolo Bonzini Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err was unused, and this made the static analyzer unhappy. Signed-off-by: Paolo Bonzini Message-id: 20180320151355.25854-1-pbonz...@redhat.com Reviewed-by: Peter

Re: [Qemu-devel] [PULL 11/26] pci-bridge/i82801b11: clear bridge registers on platform reset

Michael, Peter, On 02/08/18 20:09, Michael S. Tsirkin wrote: > From: Laszlo Ersek > > The "i82801b11-bridge" device model is a descendant of "base-pci-bridge" > (TYPE_PCI_BRIDGE). However, unlike other similar devices, such as > > - pci-bridge, > - pcie-pci-bridge, > - PCIE

Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests

On 03/23/2018 01:30 PM, Christian Borntraeger wrote: Even that didn't work - 'make check' fails with either 1/4 or 4/4 applied in isolation, so I'm squashing them into a single patch. Yes, "qmp: introduce QMPCapability" added an assert, that was fixed by a later on patch. So the original

Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests

On 03/23/2018 06:17 PM, Eric Blake wrote: > On 03/23/2018 10:53 AM, Eric Blake wrote: > >> Actually, we should revert things in reverse order of the original commits, >> so that we aren't introducing yet more temporary breakage. >> >> Since you reverted: >> >> $ git describe 3fd2457 d003f7a

Re: [Qemu-devel] [PATCH v2 0/7] ramfb: simple boot framebuffer, no legacy vga

On 03/23/18 18:07, Gerd Hoffmann wrote: > On Fri, Mar 23, 2018 at 04:12:21PM +0100, Laszlo Ersek wrote: >> On 03/23/18 15:51, Gerd Hoffmann wrote: >>> Hi, >>> I believe the only point of this device model (and the associated guest fw driver) is Windows-on-KVM/aarch64. >>> >>> The other

Re: [Qemu-devel] [PATCH for-2.12 0/4] Fix crashes with CAN bus and ISA DMA devices

On 03/16/2018 06:15 AM, Paolo Bonzini wrote: > On 16/03/2018 10:51, Thomas Huth wrote: >> The new CAN bus devices and some older ISA devices that use DMA can be >> used to crash QEMU. These patches introduce some proper checks so that >> the users get a proper error message instead. >> >> Alexey

Re: [Qemu-devel] [PATCH v2 0/5] coccinelle: re-run scripts from scripts/coccinelle

On 03/23/2018 09:31 AM, Laurent Vivier wrote: I've re-run some scripts from the coccinelle directory, and they have found some problems. This series fixes them. v2: only change PATCH 4/4 - keep comments - fix indentation I didn't remove changes in autogenerated files as it seems

Re: [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle

On 03/23/2018 07:37 AM, Michael Tokarev wrote: 22.03.2018 19:12, Laurent Vivier wrote: I've re-run some scripts from the coccinelle directory, and they have found some problems. This series fixes them. Laurent Vivier (4): error: Strip trailing '\n' from error string arguments (again again)

Re: [Qemu-devel] [PATCH v4 1/3] update-linux-headers.sh: add unistd.h and kvm on MIPS

* Michael S. Tsirkin (m...@redhat.com) wrote: > Rework the update script slightly, add the unistd.h header and its > dependencies on all architectures. > > This also removes the IA64 and MIPS from a KVM blacklist: > Linux dropped IA64, and there was never a reason to > exclude MIPS from kvm

[Qemu-devel] [PULL 4/4] qapi: Force UTF8 encoding when parsing qapi files

Commit d4e5ec877 already fixed things to work around Python 3's lame bug of having LC_ALL=C not be 8-bit clean, when parsing the main QMP qapi files; but failed to do likewise in the tests directory. As a result, running 'LC_ALL=C make check' fails on escape-too-big and unicode-str when using

[Qemu-devel] [PULL 3/4] Revert "monitor: enable IO thread for (qmp & !mux) typed"

From: Peter Xu This reverts commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1. Enabling OOB caused several iotests failures; due to the imminent 2.12 release, the safest action is to disable OOB for now. If other patches fix the issues that iotests exposed, it may be turned

[Qemu-devel] [PULL 2/4] Revert "tests: qmp-test: verify command batching"

From: Peter Xu This reverts commit 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8. Enabling OOB caused several iotests failures; due to the imminent 2.12 release, the safest action is to disable OOB, but first we have to revert tests that rely on OOB. Signed-off-by: Peter Xu

[Qemu-devel] [PULL 0/4] QAPI patches for 2018-03-23, for 2.12-rc1

The following changes since commit 4c2c1015905fa1d616750dfe024b4c0b35875950: Merge remote-tracking branch 'remotes/borntraeger/tags/s390x-20180323' into staging (2018-03-23 10:20:54 +) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-qapi-2018-03-23

[Qemu-devel] [PULL 1/4] Revert "tests: qmp-test: add oob test"

From: Peter Xu This reverts commit d003f7a8f9cafe50119975844fa01afc2baf41fb. Enabling OOB caused several iotests failures; due to the imminent 2.12 release, the safest action is to disable OOB, but first we have to revert tests that rely on OOB. Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH] target/xtensa: fix timers test

Hi Max, On 03/23/2018 10:17 AM, Max Filippov wrote: > Change frequency of the core used in tests so that clock cycle takes > exactly 64ns. Change icount power used in tests to 6, so that each > instruction takes exactly 1 clock cycle. With these changes the > assumptions of the xtensa timers test

Re: [Qemu-devel] [PATCH for-2.12 0/4] Turn OOB off for 2.12-rc1, revert OOB tests

On 03/23/2018 10:53 AM, Eric Blake wrote: Actually, we should revert things in reverse order of the original commits, so that we aren't introducing yet more temporary breakage. Since you reverted: $ git describe 3fd2457 d003f7a 91ad450 0213031 --match=v\* v2.11.0-2595-g3fd2457d18e

  1   2   3   >