Re: [Qemu-devel] [PATCH v2 4/4] target-i386: Add NPT support

2018-06-29 Thread Jan Kiszka
On 2018-06-27 14:14, Paolo Bonzini wrote: > On 03/04/2018 17:36, Jan Kiszka wrote: >> >> +static hwaddr get_hphys(CPUState *cs, hwaddr gphys, MMUAccessType >> access_type, >> +int *prot) >> +{ >> +CPUX86State *env = _CPU(cs)->env; >> +uint64_t rsvd_mask =

[Qemu-devel] [PATCH v2] fix fdiv instruction

2018-06-29 Thread John Arbuckle
When the fdiv instruction divides a finite number by zero, the result actually depends on the FPSCR[ZE] bit. If this bit is set, the return value is the value originally in the destination register. If it is not set the result should be either positive or negative infinity. The sign of this result

Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode.

2018-06-29 Thread Zhang Chen
On Fri, Jun 29, 2018 at 5:14 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 06/27/2018 03:41 PM, Zhang Chen wrote: > > > From: Zhang Chen > > > > > > Suggested by Markus Armbruster rename COLO unknown mode to none mode. > > > > > > Signed-off-by: Zhang Chen

[Qemu-devel] about live memory snapshot

2018-06-29 Thread Gonglei (Arei)
Hi Peter, As we discussed in LC3 China, the current scheme of "migration to file" can't fit on production environment, which will cause the snapshot file bigger and bigger when the guest is under enough memory pressure. We can't assume what size the snapshot file is. Pls have a look if we

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Joe Perches
On Fri, 2018-06-29 at 15:41 -0500, Eric Blake wrote: > On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote: > > Do not match the IEC binary prefix as camelcase typedefs. > > > > This fixes: > > > > ERROR: "foo * bar" should be "foo *bar" > > #310: FILE: hw/ppc/ppc440_uc.c:564: > >

[Qemu-devel] [PATCH 0/2] Fix qemu-system-aarch64 crash

2018-06-29 Thread Richard Henderson
The sequence of events was (1) Kernel executed a disabled sve insn, (2) Undefined Instruction trap went to EL3, (3) Lookup of the exception handler saw el3 and returned asidx 1, (4) Which hadn't been set up. So there's definitely a bug with SVE exception routing. That said... With just

[Qemu-devel] [PATCH 1/2] target/arm: Always return ARMASIdx_NS when num_ases == 1

2018-06-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index e310ffc29d..c26cc43ea8 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -2915,7 +2915,7 @@ enum { /* Return the address

[Qemu-devel] [PATCH 2/2] cpu: Assert asidx_from_attrs return value in range

2018-06-29 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qom/cpu.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index cce2fd6acc..bd796579ee 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -620,11 +620,13 @@ static inline hwaddr

[Qemu-devel] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

2018-06-29 Thread Tony Krowiak
Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device driver by writing a UUID to a sysfs attribute

[Qemu-devel] [PATCH v6 3/5] s390x/ap: base Adjunct Processor (AP) object model

2018-06-29 Thread Tony Krowiak
From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- MAINTAINERS | 12 +++ hw/s390x/Makefile.objs |2 + hw/s390x/ap-bridge.c | 76 ++

[Qemu-devel] [PATCH v6 5/5] s390: doc: detailed specifications for AP virtualization

2018-06-29 Thread Tony Krowiak
This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak Signed-off-by: Tony Krowiak --- MAINTAINERS

[Qemu-devel] [PATCH v6 1/5] linux-headers: linux header updates for AP support

2018-06-29 Thread Tony Krowiak
Updates the linux header files in preparation for introduction of the VFIO AP device: * Added a feature ID to indicate AP facilities are installed * Added a device attribute to the KVM_S390_VM_CRYPTO group to indicate whether AP instructions are to be interpreted * Added VFIO device

[Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

2018-06-29 Thread Tony Krowiak
From: Tony Krowiak This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed on

[Qemu-devel] [PATCH v6 2/5] s390x/cpumodel: Set up CPU model for AP device support

2018-06-29 Thread Tony Krowiak
A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP facilities are installed. This feature will be enabled by the kernel only if the AP

[Qemu-devel] [PATCH v3 3/3] Add "Group Identifier" support to Red Hat PCI Express bridge.

2018-06-29 Thread Venu Busireddy
Add a new bridge device "pcie-downstream" with a Vendor ID of PCI_VENDOR_ID_REDHAT and a Device ID of PCI_DEVICE_ID_REDHAT_DOWNPORT_FAILOVER. Also, add the "Vendor-Specific" capability to the bridge to contain the "Group Identifier" that will be used to pair a virtio device with the passthrough

[Qemu-devel] [PATCH v3 2/3] Add "Group Identifier" support to Red Hat PCI bridge.

2018-06-29 Thread Venu Busireddy
Add the "Vendor-Specific" capability to the Red Hat PCI bridge device "pci-bridge", to contain the "Group Identifier" that will be used to pair a virtio device with the passthrough device attached to that bridge. Also, change the Device ID of the bridge to PCI_DEVICE_ID_REDHAT_BRIDGE_FAILOVER to

[Qemu-devel] [PATCH v3 virtio 1/1] Add "Group Identifier" to virtio PCI capabilities.

2018-06-29 Thread Venu Busireddy
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the virtio PCI capabilities to allow for the grouping of devices. Signed-off-by: Venu Busireddy --- content.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/content.tex b/content.tex index

[Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Venu Busireddy
The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address for pairing the virtio device and the passthrough device. The thread "netvsc: refactor notifier/event handling

[Qemu-devel] [PATCH v3 1/3] Add "Group Identifier" support to virtio devices.

2018-06-29 Thread Venu Busireddy
Use the virtio PCI capability "VIRTIO_PCI_CAP_GROUP_ID_CFG" to store the "Group Identifier" specified via the command line option "failover-group-id" for the virtio device. The capability will be present in the virtio device's configuration space iff the "failover-group-id" option is specified.

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 01:55:07PM -0500, Venu Busireddy wrote: > On 2018-06-27 22:27:33 -0500, Venu Busireddy wrote: > > On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote: > > > > On 2018-06-27 23:12:12 +0300, Michael S.

[Qemu-devel] [PATCH] accel/tcg: Avoid caching overwritten tlb entries

2018-06-29 Thread Richard Henderson
When installing a TLB entry, remove any cached version of the same page in the VTLB. If the existing TLB entry matches, do not copy into the VTLB, but overwrite it. Signed-off-by: Richard Henderson --- This may fix some problems with Q800 that Laurent reported. On IRC, Peter suggested that

Re: [Qemu-devel] [PATCH] migration: Appease coverity, skip empty block trees

2018-06-29 Thread John Snow
On 06/29/2018 01:07 PM, Stefan Hajnoczi wrote: > On Fri, Jun 22, 2018 at 04:11:22PM -0400, John Snow wrote: >> If a tree consists exclusively of implicit filter nodes, we might crash >> QEMU. This configuration should not exist in practice, but if it did, >> skipping it would be fine. >> >> For

[Qemu-devel] [Bug 1587065] Re: btrfs qemu-ga - multiple mounts block fsfreeze

2018-06-29 Thread Andreas Hasenack
** Description changed: [Impact] - * An explanation of the effects of the bug on users and +  * An explanation of the effects of the bug on users and - * justification for backporting the fix to the stable release. +  * justification for backporting the fix to the stable release. -

Re: [Qemu-devel] RISC-V platform

2018-06-29 Thread Alistair Francis
On Fri, Jun 29, 2018 at 2:05 PM, G 3 wrote: > Hi, I noticed your RISC-V patches on the mailing list and had a question > that I think you may be able to answer. Has anyone defined a RISC-V platform > yet? What I mean is defining what devices would be found on a RISC-V > motherboard. I do hope to

[Qemu-devel] RISC-V platform

2018-06-29 Thread G 3
Hi, I noticed your RISC-V patches on the mailing list and had a question that I think you may be able to answer. Has anyone defined a RISC-V platform yet? What I mean is defining what devices would be found on a RISC-V motherboard. I do hope to see RISC-V based desktop systems one day. But

[Qemu-devel] [PATCH v2 17/21] docker: drop QEMU build-dep from bootstrap

2018-06-29 Thread Alex Bennée
This is best done with any child images that actually need it. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-bootstrap.docker | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-bootstrap.docker

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Image fleecing test case 222

2018-06-29 Thread John Snow
On 06/29/2018 01:58 PM, Eric Blake wrote: > On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Fam Zheng >> >> This tests the workflow of creating a lightweight point-in-time snapshot >> with blockdev-backup command, and exporting it with built-in NBD server. >> >> It's

Re: [Qemu-devel] [PATCH 1/2] qapi: Add comments to aid debugging generated introspection

2018-06-29 Thread Eric Blake
On 06/29/2018 02:55 PM, Eric Blake wrote: The generated qapi-introspect.c changes only with the addition of comments, such as: | @@ -14927,6 +15410,7 @@ | {} | })), | QLIT_QDICT(((QLitDictEntry[]) { | +/* QCryptoBlockInfoLUKSSlot */ | { "members",

[Qemu-devel] [PATCH v2 15/21] docker: Do not run tests in 'intermediate' images

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé We can still build the DOCKER_INTERMEDIATE_IMAGES images, but they won't appear in 'make test*@$IMAGE'. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 13/21] docker: ubuntu: Use SDL2

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Do not test the deprecated API versions (see cabd35840749d). Debian MXE MinGW cross images are already using SDL2. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/ubuntu.docker | 4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v2 19/21] docker: add special rule for deboostrapped images

2018-06-29 Thread Alex Bennée
We might as well have a custom rule for this. For one things the dependencies are different. We drop the test and EXECUTABLE lines from the general rule as they are no longer needed there. Signed-off-by: Alex Bennée --- tests/docker/Makefile.include | 26 +- 1 file

[Qemu-devel] [PATCH v2 16/21] docker: add env parser to docker.py build step

2018-06-29 Thread Alex Bennée
We need to pass environment variables down to the debbootstrap.pre script to be able to specify build parameters. Signed-off-by: Alex Bennée --- tests/docker/docker.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/docker/docker.py b/tests/docker/docker.py index

[Qemu-devel] [PATCH v2 18/21] docker: add special handling for FROM:debian-%-user targets

2018-06-29 Thread Alex Bennée
These will have been build with debootstrap so we need to check against the debian-bootstrap dockerfile. This does mean sticking to debian-FOO-user as the naming conventions for boot-strapped images. The actual cross image is built on top. Signed-off-by: Alex Bennée --- tests/docker/docker.py |

[Qemu-devel] [PATCH v2 21/21] .shippable.yml: add linux-user cross-build for ppc-softmmu

2018-06-29 Thread Alex Bennée
Use our new ability to use linux-user powered docker images to build ppc-softmmu. Signed-off-by: Alex Bennée --- .shippable.yml | 8 1 file changed, 8 insertions(+) diff --git a/.shippable.yml b/.shippable.yml index f74a3de3ff..12f9d3b221 100644 --- a/.shippable.yml +++

[Qemu-devel] [PATCH v2 09/21] linux-user: introduce preexit_cleanup

2018-06-29 Thread Alex Bennée
To avoid repeating ourselves move our preexit clean-up code into a helper function. I figured the continuing effort to split of the syscalls made it worthwhile creating a new file for it now. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé

[Qemu-devel] [PATCH v2 20/21] docker: add linux-user powered cross builder for QEMU

2018-06-29 Thread Alex Bennée
We can't use cross compilers in the current Debian stable and Debian sid is sketchy as hell. So for powerpc fall back to dog-fooding our own linux-user to do the build. As we can only build the base image with a suitably configured source tree we fall back to checking for it's existence when we

[Qemu-devel] [PATCH v2 10/21] linux-user: add gcov support to preexit_cleanup

2018-06-29 Thread Alex Bennée
As we don't always take the normal exit path when running a guest we can skip the normal exit destructors where gcov normally dumps it's info. The GCC manual suggests long running programs use __gcov_dump() to flush out the coverage state periodically so we use that here. Signed-off-by: Alex

[Qemu-devel] [PATCH v2 12/21] docker: ubuntu: Update the package list before installing new ones

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since docker caches the different layers, updating the package list does not invalidate the previous "apt-get update" layer, and it is likely "apt-get install" hits an outdated repository. See

[Qemu-devel] [PATCH v2 14/21] docker: Clean the MXE base image

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Using the duplicated same package is confusing. Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian8-mxe.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 06/21] travis: add gcovr summary for GCOV build

2018-06-29 Thread Alex Bennée
This gives a more useful summary, sorted by descending % coverage, after the tests have run. The final numbers will give an idea if our coverage is getting better or worse. To keep the width sane we need to post process the file that the old gcovr tool generates. This is done with a mix of sed,

[Qemu-devel] [PATCH v2 08/21] build-system: add coverage-report target

2018-06-29 Thread Alex Bennée
This will build a coverage report under the current directory in reports/coverage. At the users option a report can be generated by directly invoking something like: make foo/bar/coverage-report.html Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe

[Qemu-devel] [PATCH v2 11/21] docker: filter out linux-user builds for mingw

2018-06-29 Thread Alex Bennée
The recent change from TARGET_DIRS to TARGET_LIST (208ecb3e1) had the effect of defaulting all docker builds to the current configured set of targets. This is actually reasonable behaviour but does run into problems if you have linux-user builds configured and you want to test the windows cross

[Qemu-devel] [PATCH v2 05/21] docker: add gcovr to travis image

2018-06-29 Thread Alex Bennée
Useful for debugging if nothing else as the gcovr on the Travis images are a little old. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/docker/dockerfiles/travis.docker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 03/21] build-system: remove per-test GCOV reporting

2018-06-29 Thread Alex Bennée
I'm not entirely sure who's using this information and certainly in a CI environment it just washes over as additional noise. Later patches will provide new reporting options so a user who wants to analyse individual tests will be able to use that to get the information. Signed-off-by: Alex

[Qemu-devel] [PATCH v2 07/21] build-system: add clean-coverage target

2018-06-29 Thread Alex Bennée
This can be used to remove any stale coverage data before any particular test run. This is useful for analysing individual tests. Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- v2 - s/to any/to delete any/ --- Makefile | 11 +++ docs/devel/testing.rst |

[Qemu-devel] [PATCH v2 02/21] travis: test out-of-tree builds

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Force one config to build 'out-of-tree' (object files and executables are created in a tree outside the project source code). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- .travis.yml | 8 +++- 1 file

[Qemu-devel] [PATCH v2 04/21] .gitignore: add .gcov files

2018-06-29 Thread Alex Bennée
These are temporary files generated on gcov runs and shouldn't be included in the source tree. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git

[Qemu-devel] [PATCH v2 00/21] Travis, Code Coverage and Cross Build updates

2018-06-29 Thread Alex Bennée
Hi, I've picked up some more of Philippe's fixes and in the process had another look at the problem of cross compiling powerpc. In the end the consensus seems to be a linux-user build was the best solution as there are still supported native powerpc toolchains in Jessie (until 2020). So I dusted

[Qemu-devel] [PATCH v2 01/21] travis: do not waste time cloning unused submodules

2018-06-29 Thread Alex Bennée
From: Philippe Mathieu-Daudé Builds only require: - dtc - keycodemapdb - capstone Signed-off-by: Philippe Mathieu-Daudé [AJB: drop wget cache] Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v6 0/2] New block driver: blklogwrites

2018-06-29 Thread Ari Sundholm
This patch series adds a new block driver, blklogwrites, to QEMU. The driver is given two block devices: a raw device backed by an image or a host block device, and a log device, typically backed by a file, on which writes to the raw device are logged. The logging format used is the same as in

[Qemu-devel] [PATCH v6 2/2] block: Add blklogwrites

2018-06-29 Thread Ari Sundholm
From: Aapo Vienamo Implements a block device write logging system, similar to Linux kernel device mapper dm-log-writes. The write operations that are performed on a block device are logged to a file or another block device. The write log format is identical to the dm-log-writes format.

[Qemu-devel] [PATCH v6 1/2] block: Move two block permission constants to the relevant enum

2018-06-29 Thread Ari Sundholm
This allows using the two constants outside of block.c, which will happen in a subsequent patch. Signed-off-by: Ari Sundholm --- block.c | 6 -- include/block/block.h | 7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index

Re: [Qemu-devel] [PATCH v5 04/46] checkpatch: Recognize IEC binary prefix definitions

2018-06-29 Thread Eric Blake
On 06/25/2018 07:41 AM, Philippe Mathieu-Daudé wrote: Do not match the IEC binary prefix as camelcase typedefs. This fixes: ERROR: "foo * bar" should be "foo *bar" #310: FILE: hw/ppc/ppc440_uc.c:564: +size = 8 * MiB * sh; total: 1 errors, 0 warnings, 433 lines

[Qemu-devel] [Bug 1755912] Re: qemu-system-x86_64 crashed with SIGABRT when using option -vga qxl

2018-06-29 Thread Leonardo Müller
QEMU from git apparently is fixed, but Ubuntu's version is still problematic. Using an Xubuntu 18.04 guest, it's possible to reproduce the crash using: while true ; do xrandr --output Virtual-0 --mode 640x480 ; sleep 1 ; xrandr --output Virtual-0 --mode 1280x720 ; sleep 1 ; xrandr --output

Re: [Qemu-devel] [Qemu-block] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread Kevin Wolf
Am 29.06.2018 um 22:16 hat Eric Blake geschrieben: > On 06/29/2018 03:07 PM, John Snow wrote: > > CC Qemu Block; looks like QED is a bit busted. > > > > On 06/27/2018 10:25 AM, Quytelda Kahja wrote: > > > Hello all, > > > I wanted to submit a bug report in the tracker, but it seem to require > >

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 05:16:52PM -0300, Eduardo Habkost wrote: > On Fri, Jun 29, 2018 at 05:18:21PM +0200, Igor Mammedov wrote: > > On Fri, 29 Jun 2018 12:14:05 +0100 > > Daniel P. Berrangé wrote: > > > > > On Fri, Jun 29, 2018 at 01:08:38PM +0200, Paolo Bonzini wrote: > > > > On 29/06/2018

Re: [Qemu-devel] [PATCH v2 12/20] 9p: darwin: Explicitly cast comparisons of mode_t with -1

2018-06-29 Thread Eric Blake
On 05/31/2018 08:26 PM, Keno Fischer wrote: Comparisons of mode_t with -1 require an explicit cast, since mode_t is unsigned on Darwin. It's not JUST that mode_t is unsigned (an unsigned int compares just fine against -1), but ALSO that mode_t has unspecified width. That is, you cannot

Re: [Qemu-devel] [PULL v3 00/60] Misc patches for soft freeze

2018-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2018 03:03 PM, Peter Maydell wrote: > On 29 June 2018 at 12:05, Paolo Bonzini wrote: >> The following changes since commit 4a83bf2f339d4b63ecd5ef48b9816c3b7ee24553: >> >> Merge remote-tracking branch >> 'remotes/juanquintela/tags/migration/20180627' into staging (2018-06-28 >>

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 02:55:44PM -0500, Eric Blake wrote: > Now that we have useful access to the type name as a comment > in the generated qapi-introspect.c, we don't need to regenerate > code with a temporary -u option just to get at type names. > > Signed-off-by: Eric Blake Reviewed-by:

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 05:18:21PM +0200, Igor Mammedov wrote: > On Fri, 29 Jun 2018 12:14:05 +0100 > Daniel P. Berrangé wrote: > > > On Fri, Jun 29, 2018 at 01:08:38PM +0200, Paolo Bonzini wrote: > > > On 29/06/2018 13:07, Greg Kurz wrote: > > > Also asserting current_machine != NULL is

Re: [Qemu-devel] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread Eric Blake
On 06/29/2018 03:07 PM, John Snow wrote: CC Qemu Block; looks like QED is a bit busted. On 06/27/2018 10:25 AM, Quytelda Kahja wrote: Hello all, I wanted to submit a bug report in the tracker, but it seem to require an Ubuntu One account, which I'm having trouble with, so I'll just give it

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 01:47:59PM +0200, Paolo Bonzini wrote: > On 29/06/2018 13:42, Cédric Le Goater wrote: > >> Yeah, doing anything non-trivial in class_init is just asking for trouble, > >> as conceivably nothing is initialized at that point. > > > > May be we should consider having a set of

Re: [Qemu-devel] [PATCH 1/2] qapi: Add comments to aid debugging generated introspection

2018-06-29 Thread Eric Blake
On 06/29/2018 02:55 PM, Eric Blake wrote: We consciously chose in commit 1a9a507b to hide QAPI type names from the generated introspection output, but added a command line option -u to unmask the type name when doing a debug build. At that time, we generated a monolithic C string, so there was

Re: [Qemu-devel] [BUG] qed_aio_write_alloc: Assertion `s->allocating_acb == NULL' failed.

2018-06-29 Thread John Snow
CC Qemu Block; looks like QED is a bit busted. On 06/27/2018 10:25 AM, Quytelda Kahja wrote: > Hello all, > I wanted to submit a bug report in the tracker, but it seem to require > an Ubuntu One account, which I'm having trouble with, so I'll just > give it here and hopefully somebody can make

[Qemu-devel] [PATCH] tcg: Fix --disable-tcg build breakage

2018-06-29 Thread Philippe Mathieu-Daudé
Fix the --disable-tcg breakage introduced by 8bca9a03ec60d: $ configure --disable-tcg [...] $ make -C i386-softmmu exec.o make: Entering directory 'i386-softmmu' CC exec.o In file included from source/qemu/exec.c:62:0: source/qemu/include/exec/ram_addr.h:96:6:

Re: [Qemu-devel] [PATCH v2] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 11:39:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 29, 2018 at 12:35:09PM +0200, Paolo Bonzini wrote: > > On 29/06/2018 12:29, Greg Kurz wrote: > > > It is unsafe to rely on *_enabled() helpers before the accelerator has > > > been initialized, ie,

Re: [Qemu-devel] [PATCH 3/3] accel: forbid early use of kvm_enabled() and friends

2018-06-29 Thread Eduardo Habkost
On Thu, Jun 28, 2018 at 12:15:33PM +0200, Greg Kurz wrote: > It is unsafe to rely on *_enabled() helpers before the accelerator has > been initialized, ie, accel_init_machine() has succeeded, because they > always return false. But it is still possible to end up calling them > indirectly by

[Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eric Blake
Now that we have useful access to the type name as a comment in the generated qapi-introspect.c, we don't need to regenerate code with a temporary -u option just to get at type names. Signed-off-by: Eric Blake --- scripts/qapi-gen.py| 5 + scripts/qapi/introspect.py | 12

[Qemu-devel] [PATCH 1/2] qapi: Add comments to aid debugging generated introspection

2018-06-29 Thread Eric Blake
We consciously chose in commit 1a9a507b to hide QAPI type names from the generated introspection output, but added a command line option -u to unmask the type name when doing a debug build. At that time, we generated a monolithic C string, so there was no better way to do things (we could not

[Qemu-devel] [PATCH 0/2] qapi: easier debugging of introspection file

2018-06-29 Thread Eric Blake
When inspecting the generated qapi-introspect.c (for debugging, or to see what QAPI changes are user visible vs. internal only), the fact that we've intentionally masked names from the QMP client makes it harder to tie back generated code back to the original QAPI .json files. We have a -u switch

Re: [Qemu-devel] [PATCH] block/fleecing-filter: new filter driver for fleecing

2018-06-29 Thread John Snow
On 06/21/2018 11:48 AM, Vladimir Sementsov-Ogievskiy wrote: > We need to synchronize backup job with reading from fleecing image > like it was done in block/replication.c. > > Otherwise, the following situation is theoretically possible: > > 1. client start reading > 2. client understand,

Re: [Qemu-devel] [PATCH 2/3] spapr: compute default value of "hpt-max-page-size" later

2018-06-29 Thread Eduardo Habkost
On Thu, Jun 28, 2018 at 12:15:14PM +0200, Greg Kurz wrote: [...] > @@ -2527,6 +2527,18 @@ static void spapr_machine_init(MachineState *machine) > QLIST_INIT(>phbs); > QTAILQ_INIT(>pending_dimm_unplugs); > > +/* This is for pseries-2.12 and older machine types */ > +if

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Emilio G. Cota
On Fri, Jun 29, 2018 at 19:38:02 +0100, Mark Cave-Ayland wrote: > On 29/06/18 19:18, Emilio G. Cota wrote: > >I tried the last known good commit (as per your bisect) and get the same > >results > >as above. > > > >Is there any other way I could try reproducing this? Also, can you > >reproduce

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-29 Thread Venu Busireddy
On 2018-06-27 22:27:33 -0500, Venu Busireddy wrote: > On 2018-06-28 04:54:16 +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 27, 2018 at 05:34:17PM -0500, Venu Busireddy wrote: > > > On 2018-06-27 23:12:12 +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jun 27, 2018 at 02:59:01PM -0500, Venu

Re: [Qemu-devel] [PULL, 14/18] translate-all: discard TB when tb_link_page returns an existing matching TB

2018-06-29 Thread Emilio G. Cota
On Fri, Jun 29, 2018 at 10:25:03 +0300, Pavel Dovgalyuk wrote: > This patch breaks record/replay. > > I run execution recording of the WindowsXP machine with the following script: > > ./bin/qemu-system-i386 -d in_asm,exec -D xp_save.log -global > apic-common.vapic=off \ > -icount

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Mark Cave-Ayland
On 29/06/18 19:18, Emilio G. Cota wrote: On Fri, Jun 29, 2018 at 13:17:11 +0100, Mark Cave-Ayland wrote: Whilst trying to debug an issue in OpenBIOS, I noticed that the gdbstub single-step functionality was broken which I bisected down to this commit: (snip) commit

Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2018-06-29 Thread John Snow
On 06/29/2018 02:00 PM, Eric Blake wrote: > On 05/20/2014 01:04 AM, Fam Zheng wrote: >> Thanks for Eric's and Markus' reviewing! > > Thread necromancy - now that patch 15/15 has had a revival four years > later (two different threads proposing a test 222 for image fleecing) - > I want to

Re: [Qemu-devel] [RFC v3 07/10] hw/m68k: add Nubus support

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/display/macfb.c | 56 ++ hw/nubus/Makefile.objs | 4 +

Re: [Qemu-devel] [RFC v3 02/10] ADB: VIA probes ADB bus when it is idle

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/input/adb-kbd.c| 4 ++ hw/input/adb-mouse.c | 4 ++ hw/input/adb.c| 115

Re: [Qemu-devel] [RFC v3 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-06-29 Thread Mark Cave-Ayland
On 28/06/18 00:29, Laurent Vivier wrote: I'm rebasing some of these patches for seven years now, too many years... if you want to test the machine, I'm sorry, it doesn't boot a MacROM, but you can boot a linux kernel from the command line. You can install your own disk using debian-installer,

Re: [Qemu-devel] target/ppc: gdbstub single-step broken since TranslatorOps conversion

2018-06-29 Thread Emilio G. Cota
On Fri, Jun 29, 2018 at 13:17:11 +0100, Mark Cave-Ayland wrote: > Whilst trying to debug an issue in OpenBIOS, I noticed that the gdbstub > single-step functionality was broken which I bisected down to this commit: (snip) > commit b0c2d5213a14f8b9d44096ee879a5d7f10fbc505 > Author: Emilio G. Cota

Re: [Qemu-devel] [PULL v2 0/7] riscv-pull queue

2018-06-29 Thread Philippe Mathieu-Daudé
the Git repository at: > > g...@github.com:alistair23/qemu.git tags/pull-riscv-pull-20180629 > > for you to fetch changes up to e4847c96685e210649e6ec90fecd732a744dad75: > > hw/riscv/sifive_u: Connect the Cadence GEM Ethernet

Re: [Qemu-devel] [PULL v3 00/60] Misc patches for soft freeze

2018-06-29 Thread Peter Maydell
On 29 June 2018 at 12:05, Paolo Bonzini wrote: > The following changes since commit 4a83bf2f339d4b63ecd5ef48b9816c3b7ee24553: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20180627' > into staging (2018-06-28 15:31:42 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH v2 0/3] qcow2 compress threads

2018-06-29 Thread Kevin Wolf
Am 20.06.2018 um 16:48 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > Here are compress threads for qcow2, to increase performance of > compressed writes. Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-29 Thread Sebastian Bauer
Hi, Am 2018-06-19 06:36, schrieb David Gibson: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. Please make sure your patches are against the current

[Qemu-devel] [PULL 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: John Snow Signed-off-by: Stefan Hajnoczi --- hw/block/fdc.c| 6 +++--- hw/block/trace-events | 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index

[Qemu-devel] [PULL 05/11] hw/char/parallel: Convert from pdebug() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/char/parallel.c | 16 +--- hw/char/trace-events | 4 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index

[Qemu-devel] [PULL 04/11] hw/char/serial: Convert from DPRINTF macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/char/serial.c | 5 +++-- hw/char/trace-events | 4 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/char/serial.c b/hw/char/serial.c index 605b0d02f9..26f53ba02f

Re: [Qemu-devel] [PATCH v20 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2018-06-29 Thread Eric Blake
On 05/20/2014 01:04 AM, Fam Zheng wrote: Thanks for Eric's and Markus' reviewing! Thread necromancy - now that patch 15/15 has had a revival four years later (two different threads proposing a test 222 for image fleecing) - I want to double check if anything else in this series still needs

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Image fleecing test case 222

2018-06-29 Thread Eric Blake
On 06/29/2018 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: From: Fam Zheng This tests the workflow of creating a lightweight point-in-time snapshot with blockdev-backup command, and exporting it with built-in NBD server. It's tested that any post-snapshot writing to the original device

[Qemu-devel] [PULL 03/11] sdcard: Reduce sdcard_set_blocklen() trace digits

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Per the Physical Layer Simplified Spec. "5.3 CSD Register": "The maximum block length might therefore be in the range 512...2048 bytes" Therefore 3 hexdigits are enough to report the block length. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan

[Qemu-devel] [PULL 11/11] hw/block/pflash_cfi: Convert from DPRINTF() macro to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé [Fixed lx -> PRIx64 as suggested by Philippe. --Stefan] Signed-off-by: Stefan Hajnoczi --- hw/block/pflash_cfi01.c | 42 +++-- hw/block/pflash_cfi02.c | 18 +-

Re: [Qemu-devel] [PATCH v3] docs: add guidance on configuring CPU models for x86

2018-06-29 Thread Eduardo Habkost
On Wed, Jun 27, 2018 at 05:01:03PM +0100, Daniel P. Berrangé wrote: > With the recent set of CPU hardware vulnerabilities on x86, it is > increasingly difficult to understand which CPU configurations are > good to use and what flaws they might be vulnerable to. > > This doc attempts to help

[Qemu-devel] [PULL 02/11] trace: Fix format string for the struct timeval members casted to size_t

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé This fixes when using GCC with -Wformat-signedness: migration/trace.h: In function ‘_nocheck__trace_dirty_bitmap_load_success’: migration/trace.h:6368:24: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 3 has type ‘long unsigned

[Qemu-devel] [PULL 08/11] hw/net/ne2000: Convert printf() calls to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/ne2000.c | 8 ++-- hw/net/trace-events | 2 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 26b234b7eb..07d79e317f

[Qemu-devel] [PULL 09/11] hw/net/etraxfs_eth: Convert printf() calls to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Suggested-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/etraxfs_eth.c | 8 hw/net/trace-events | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/net/etraxfs_eth.c

[Qemu-devel] [PULL 00/11] Tracing patches

2018-06-29 Thread Stefan Hajnoczi
The following changes since commit 609ef9f451759151d0bfe7c3843410ab94d68f18: Merge remote-tracking branch 'remotes/berrange/tags/qio-next-pull-request' into staging (2018-06-28 17:53:31 +0100) are available in the Git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL 06/11] hw/input/tsc2005: Convert a fprintf() call to trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/input/tsc2005.c| 7 +++ hw/input/trace-events | 3 +++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index

[Qemu-devel] [PULL 07/11] hw/net/ne2000: Add trace events

2018-06-29 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi --- hw/net/ne2000.c | 17 - hw/net/trace-events | 4 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index

[Qemu-devel] [PULL 01/11] simpletrace: Convert name from mapping record to str

2018-06-29 Thread Stefan Hajnoczi
From: Eduardo Habkost The rest of the code assumes that idtoname is a (int -> str) dictionary, so convert the data accordingly. This is necessary to make the script work with Python 3 (where reads from a binary file return 'bytes' objects, not 'str'). Fixes the following error: $ python3

  1   2   3   4   5   >