Re: [Qemu-devel] [PATCH for 3.0 01/10] tests/.gitignore: don't ignore docker tests

2018-07-09 Thread Fam Zheng
On Mon, 07/09 16:21, Alex Bennée wrote: > This was being a little over enthusiastic hiding files. What is "this" that hides test-* and calls for this patch? > > Signed-off-by: Alex Bennée > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/test

Re: [Qemu-devel] [RFC 05/15] s390-bios: Factor finding boot device out of virtio code path

2018-07-09 Thread Christian Borntraeger
On 07/05/2018 07:25 PM, Jason J. Herne wrote: [...] > -IPL_assert(found, "No virtio device found"); Can you also change the boot-serial testcase: this seems to work: diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index 952a2e7ead..b03b55d182 100644 --- a/tests/boot-serial

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Peter Maydell
On 9 July 2018 at 23:03, Thomas Huth wrote: > On 09.07.2018 23:42, Peter Maydell wrote: >> On 9 July 2018 at 22:03, Thomas Huth wrote: >>> When trying to "device_add bcm2837" on a machine that is not suitable for >>> this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": >>>

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-09 Thread David Gibson
On Tue, Jul 10, 2018 at 12:22:44PM +1000, Alexey Kardashevskiy wrote: > On Mon, 2 Jul 2018 16:26:44 +1000 > Alexey Kardashevskiy wrote: > > > The following changes since commit edb1fb337f65f82fe32b989c4f018efe85c1dddb: > > > > pseries: Update SLOF firmware image (2018-07-02 16:21:30 +1000) >

[Qemu-devel] [PATCH v3 10/10] block: Use common write req handling in truncate

2018-07-09 Thread Fam Zheng
Truncation is the last to convert from open coded req handling to reusing helpers. This time the permission check in prepare has to adapt to the new caller: it checks a different permission bit, and doesn't trigger the before write notifier. Also, truncation should always trigger a bs->total_secto

[Qemu-devel] [PATCH v3 08/10] block: Use common req handling in copy offloading

2018-07-09 Thread Fam Zheng
This brings the request handling logic inline with write and discard, fixing write_gen, resize_cb, dirty bitmaps and image size refreshing. The last of these issues broke iotest case 222, which is now fixed. Signed-off-by: Fam Zheng --- block/io.c | 22 +- 1 file changed, 9 i

[Qemu-devel] [PATCH v3 07/10] block: Use common req handling for discard

2018-07-09 Thread Fam Zheng
Reuse the new bdrv_co_write_req_prepare/finish helpers. The variation here is that discard requests don't affect bs->wr_highest_offset, and it cannot extend the image. Signed-off-by: Fam Zheng --- block/io.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-)

[Qemu-devel] [PATCH v3 09/10] block: Fix bdrv_co_truncate overlap check

2018-07-09 Thread Fam Zheng
If we are growing the image and potentially using preallocation for the new area, we need to make sure that no write requests are made to the "preallocated" area which is [@old_size, @offset), not [@offset, offset * 2 - @old_size). Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- block/io.c

[Qemu-devel] [PATCH v3 05/10] block: Extract common write req handling

2018-07-09 Thread Fam Zheng
As a mechanical refactoring patch, this is the first step towards unified and more correct write code paths. This is helpful because multiple BlockDriverState fields need to be updated after modifying image data, and it's hard to maintain in multiple places such as copy offload, discard and truncat

[Qemu-devel] [PATCH v3 03/10] block: Use BdrvChild to discard

2018-07-09 Thread Fam Zheng
Other I/O functions are already using a BdrvChild pointer in the API, so make discard do the same. It makes it possible to initiate the same permission checks before doing I/O, and much easier to share the helper functions for this, which will be added and used by write, truncate and copy range pat

[Qemu-devel] [PATCH v3 04/10] block: Use uint64_t for BdrvTrackedRequest byte fields

2018-07-09 Thread Fam Zheng
This matches the types used for bytes in the rest parts of block layer. In the case of bdrv_co_truncate, new_bytes can be the image size which probably doesn't fit in a 32 bit int. Signed-off-by: Fam Zheng --- block/io.c| 8 +--- include/block/block_int.h | 4 ++-- 2 files ch

[Qemu-devel] [PATCH v3 06/10] block: Fix handling of image enlarging write

2018-07-09 Thread Fam Zheng
Two problems exist when a write request that enlarges the image (i.e. write beyond EOF) finishes: 1) parent is not notified about size change; 2) dirty bitmap is not resized although we try to set the dirty bits; Fix them just like how bdrv_co_truncate works. Reported-by: Kevin Wolf Signed-off-

[Qemu-devel] [PATCH v3 02/10] block: Add copy offloading trace points

2018-07-09 Thread Fam Zheng
A few trace points that can help reveal what is happening in a copy offloading I/O path. Signed-off-by: Fam Zheng --- block/file-posix.c | 2 ++ block/io.c | 4 block/iscsi.c | 3 +++ block/trace-events | 6 ++ 4 files changed, 15 insertions(+) diff --git a/block/file-posi

[Qemu-devel] [PATCH v3 00/10] block: Fix dst reading after tail copy offloading

2018-07-09 Thread Fam Zheng
Based-on: 20180709163719.87107-1-vsement...@virtuozzo.com v3: - Rebase onto Vladmir's: [PATCH v5 0/4] fix image fleecing on top of master, which has blklogwrites to be converted to BdrvChild for the bdrv_co_pdiscard() parameter. [Kevin] - Add file_ prefix to file protocol tr

[Qemu-devel] [PATCH v3 01/10] block: Prefix file driver trace points with "file_"

2018-07-09 Thread Fam Zheng
With in one module, trace points usually have a common prefix named after the module name. paio_submit and paio_submit_co are the only two trace points so far in the two file protocol drivers. As we are adding more, having a common prefix here is better so that trace points can be enabled with a gl

[Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" by default

2018-07-09 Thread Laurent Vivier
From: Philippe Mathieu-Daudé This can still be reported using the "-d unimp" command line option. Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/fprintf\(stderr,\s?(".*not implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g' Signed-off-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout

2018-07-09 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/(\s+)printf\s*\(("Unhandled.*)\);/\1fprintf(stderr, \2);/g' Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20180706155127.7483-4-f4...@amsat.org> Signed-of

[Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default

2018-07-09 Thread Laurent Vivier
From: Philippe Mathieu-Daudé This can still be reported using the "-d unimp" command line option. Fixes: https://bugs.launchpad.net/qemu/+bug/1777226 Reported-by: John Paul Adrian Glaubitz Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id

[Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-09 Thread Laurent Vivier
The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-07-06 18:18:08 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-reques

[Qemu-devel] [PATCH 4/7 V8] configure: add libpmem support

2018-07-09 Thread junyan . he
From: Junyan He Add a pair of configure options --{enable,disable}-libpmem to control whether QEMU is compiled with PMDK libpmem [1]. QEMU may write to the host persistent memory (e.g. in vNVDIMM label emulation and live migration), so it must take the proper operations to ensure the persistence

[Qemu-devel] [PATCH 3/7 V8] hostmem-file: add the 'pmem' option

2018-07-09 Thread junyan . he
From: Junyan He When QEMU emulates vNVDIMM labels and migrates vNVDIMM devices, it needs to know whether the backend storage is a real persistent memory, in order to decide whether special operations should be performed to ensure the data persistence. This boolean option 'pmem' allows users to s

[Qemu-devel] [Bug 1780814] Re: lib/raid6/neon4.c:118:1: internal compiler error

2018-07-09 Thread siva krishna
Thanks peter maydell for your comments. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1780814 Title: lib/raid6/neon4.c:118:1: internal compiler error Status in QEMU: Invalid Bug description:

[Qemu-devel] [PATCH 7/7 V8] migration/ram: ensure write persistence on loading all data to PMEM.

2018-07-09 Thread junyan . he
From: Junyan He Because we need to make sure the pmem kind memory data is synced after migration, we choose to call pmem_persist() when the migration finish. This will make sure the data of pmem is safe and will not lose if power is off. Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Re

[Qemu-devel] [PATCH 1/7 V8] memory, exec: Expose all memory block related flags.

2018-07-09 Thread junyan . he
From: Junyan He We need to use these flags in other files rather than just in exec.c, For example, RAM_SHARED should be used when create a ram block from file. We expose them the exec/memory.h Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- exec.c

[Qemu-devel] [PATCH 5/7 V8] mem/nvdimm: ensure write persistence to PMEM in label emulation

2018-07-09 Thread junyan . he
From: Junyan He Guest writes to vNVDIMM labels are intercepted and performed on the backend by QEMU. When the backend is a real persistent memort, QEMU needs to take proper operations to ensure its write persistence on the persistent memory. Otherwise, a host power failure may result in the loss

[Qemu-devel] [PATCH 0/7 V8] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-07-09 Thread junyan . he
From: Junyan He QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and live migration. If the backend is on the persistent memory, QEMU needs to take proper operations to ensure its writes persistent on the persistent memory. Otherwise, a host power failure may result in the loss the

[Qemu-devel] [PATCH 2/7 V8] memory, exec: switch file ram allocation functions to 'flags' parameters

2018-07-09 Thread junyan . he
From: Junyan He As more flag parameters besides the existing 'share' are going to be added to following functions memory_region_init_ram_from_file qemu_ram_alloc_from_fd qemu_ram_alloc_from_file let's switch them to use the 'flags' parameters so as to ease future flag additions. The existing 'sh

[Qemu-devel] [PATCH 6/7 V8] migration/ram: Add check and info message to nvdimm post copy.

2018-07-09 Thread junyan . he
From: Junyan He The nvdimm kind memory does not support post copy now. We disable post copy if we have nvdimm memory and print some log hint to user. Signed-off-by: Junyan He Reviewed-by: Stefan Hajnoczi Reviewed-by: Igor Mammedov --- migration/ram.c | 9 + 1 file changed, 9 insertio

Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial

2018-07-09 Thread Markus Armbruster
Peter Krempa writes: > On Fri, Jul 06, 2018 at 16:56:46 +0200, Kevin Wolf wrote: >> Am 06.07.2018 um 13:11 hat Cornelia Huck geschrieben: >> > On Wed, 4 Jul 2018 17:14:02 +0100 >> > Peter Maydell wrote: >> > >> > > On 4 July 2018 at 14:34, Kevin Wolf wrote: >> > > > Essentially, what is import

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

2018-07-09 Thread Markus Armbruster
Ari Sundholm writes: > On 07/09/2018 10:07 AM, Markus Armbruster wrote: >> Ari Sundholm writes: >> >>> This was accidentally omitted. Thanks to Eric Blake for spotting this. >>> >>> Signed-off-by: Ari Sundholm >>> --- >>> qapi/block-core.json | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >

Re: [Qemu-devel] [PATCH v2 8/9] block: Fix bdrv_co_truncate overlap check

2018-07-09 Thread Fam Zheng
On Fri, 07/06 17:09, Eric Blake wrote: > On 07/05/2018 02:37 AM, Fam Zheng wrote: > > If we are growing the image and potentially using preallocation for the > > new area, we need to make sure that no write requests are made to the > > "preallocated" area which [@old_size, @offset), not [@offset, o

Re: [Qemu-devel] [PATCH 5/9] monitor: suspend monitor instead of send CMD_DROP

2018-07-09 Thread Peter Xu
On Fri, Jul 06, 2018 at 03:19:56PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Fri, Jul 06, 2018 at 10:09:58AM +0200, Markus Armbruster wrote: > >> If I understand the code correctly, the response queue > >> mon->qmp..qmp_requests gets drained into the output buffer mon->outbuf >

Re: [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes

2018-07-09 Thread Peter Xu
On Fri, Jul 06, 2018 at 11:56:59AM +0100, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > > > > > Based on the series to unbreak postcopy: > > > Subject:

[Qemu-devel] [PATCH] make pci_bridge_region_cleanup to be done in rcu queue after flatview_destroy.

2018-07-09 Thread QiaoChong
pci_bridge_region_cleanup need to done after flatview_destroy, because memory_region_unref need access memory regions in PCIBridgeWindows in flatview_destroy. here we delay pci_bridge_region_cleanup to be done in rcu queue work. bellow are gdb backtraces. oldcode mr->name will be freed in object

Re: [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes

2018-07-09 Thread Peter Xu
On Tue, Jul 10, 2018 at 07:26:40AM +0530, Balamuruhan S wrote: > On Thu, Jul 05, 2018 at 11:17:46AM +0800, Peter Xu wrote: > > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > > > Based on the series to unbreak postcopy: > > Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery > >

Re: [Qemu-devel] [PATCH v5 4/4] block/backup: fix fleecing scheme: use serialized writes

2018-07-09 Thread Fam Zheng
On Mon, 07/09 19:37, Vladimir Sementsov-Ogievskiy wrote: > Fleecing scheme works as follows: we want a kind of temporary snapshot > of active drive A. We create temporary image B, with B->backing = A. > Then we start backup(sync=none) from A to B. From this point, B reads > as point-in-time snapsho

Re: [Qemu-devel] [PATCH v5 3/4] block: add BDRV_REQ_SERIALISING flag

2018-07-09 Thread Fam Zheng
On Mon, 07/09 19:37, Vladimir Sementsov-Ogievskiy wrote: > Serialized writes should be used in copy-on-write of backup(sync=none) > for image fleecing scheme. > > We need to change an assert in bdrv_aligned_pwritev, added in > 28de2dcd88de. The assert may fail now, because call to > wait_serialisi

Re: [Qemu-devel] [PATCH] make pci_bridge_region_cleanup to be done in rcu queue after flatview_destroy.

2018-07-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1531190661-19327-1-git-send-email-qiaoch...@loongson.cn Subject: [Qemu-devel] [PATCH] make pci_bridge_region_cleanup to be done in rcu queue after flatview_destroy. === TEST

[Qemu-devel] [PATCH] make pci_bridge_region_cleanup to be done in rcu queue after flatview_destroy.

2018-07-09 Thread QiaoChong
pci_bridge_region_cleanup need to done after flatview_destroy, because memory_region_unref need access memory regions in PCIBridgeWindows in flatview_destroy. here we delay pci_bridge_region_cleanup to be done in rcu queue work. bellow are gdb backtraces. oldcode mr->name will be freed in object

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2018-07-09 Thread Alexey Kardashevskiy
On Mon, 2 Jul 2018 16:26:44 +1000 Alexey Kardashevskiy wrote: > The following changes since commit edb1fb337f65f82fe32b989c4f018efe85c1dddb: > > pseries: Update SLOF firmware image (2018-07-02 16:21:30 +1000) > > are available in the git repository at: > > g...@github.com:aik/qemu.git tag

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > The current patch set includes all the feedback received for proposals [3] > and [4]. For the sake of completeness, patch for the virtio specification > is also included here. Following is the updated proposal. > > 1. Extend the vir

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 04:00:36PM +0300, Roman Kagan wrote: > There are a few things that need to be specific for PT and/or PV > transport, the matching identifier among them, but I guess a lot can > still be in common. Maybe but frankly unless someone actually plans to bother implementing all th

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > What do we buy > for using a random address during initial discovery and requiring VF to > complete the handshake? I don't see advantages to using a random address that is then changed either: changing a MAC causes network downtime for

Re: [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes

2018-07-09 Thread Balamuruhan S
On Thu, Jul 05, 2018 at 11:17:46AM +0800, Peter Xu wrote: > Based-on: <20180627132246.5576-1-pet...@redhat.com> > > Based on the series to unbreak postcopy: > Subject: [PATCH v3 0/4] migation: unbreak postcopy recovery > Message-Id: <20180627132246.5576-1-pet...@redhat.com> > > This series in

Re: [Qemu-devel] [PATCH v2 6/6] riscv64-softmmu.mak: Build Virtio Block support

2018-07-09 Thread Michael Clark
On Tue, 10 Jul 2018 at 12:29 PM, Alistair Francis wrote: > Add build time support for the VirtIO block device. This allows us to > attach a drive using the virtio-blk-device. I’m not sure what has changed in master, but VirtIO block and net for both softmmu-riscv32 and softmmu-riscv64 were prev

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > The plan is to enable group ID based matching in the first place rather than > match by MAC, the latter of which is fragile and problematic. It isn't all that fragile - hyperv used same for a while, so if someone posts working patches w

[Qemu-devel] [PATCH] spapr: Correct inverted test in spapr_pc_dimm_node()

2018-07-09 Thread David Gibson
This function was introduced between v2.11 and v2.12 to replace obsolete ways of specifying the NUMA nodes for DIMMs. It's used to find the correct node for an LMB, by locating which DIMM object it lies within. Unfortunately, one of the checks is inverted, so we check whether the address is less

Re: [Qemu-devel] [PATCH v5 2/4] block: split flags in copy_range

2018-07-09 Thread Fam Zheng
On Mon, 07/09 19:37, Vladimir Sementsov-Ogievskiy wrote: > Pass read flags and write flags separately. This is needed to handle > coming BDRV_REQ_NO_SERIALISING clearly in following patches. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH v5 1/4] block/io: fix copy_range

2018-07-09 Thread Fam Zheng
On Mon, 07/09 19:37, Vladimir Sementsov-Ogievskiy wrote: > Here two things are fixed: > > 1. Architecture > > On each recursion step, we go to the child of src or dst, only for one > of them. So, it's wrong to create tracked requests for both on each > step. It leads to tracked requests duplicati

[Qemu-devel] [PATCH hack dontapply v2 8/7 untested] acpi: support cst change notifications

2018-07-09 Thread Michael S. Tsirkin
(Ab)use cpu hotplug event infrastructure to report per-CPU _CST change events. Signed-off-by: Michael S. Tsirkin --- Untested infrastructure to notify about _CST changes. include/hw/acpi/cpu.h | 4 hw/acpi/cpu.c | 39 +++ hw/acpi/trace-events

Re: [Qemu-devel] [PATCH] sm501: Update screen on frame buffer address change

2018-07-09 Thread David Gibson
On Mon, Jul 09, 2018 at 07:02:36PM +0200, BALATON Zoltan wrote: > When the guest changes the address of the frame buffer we need to > refresh the screen to correctly display the new content. This fixes > display update problems when changing between screens on AmigaOS. > > Signed-off-by: BALATON Z

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread si-wei liu
On 7/9/2018 6:00 AM, Roman Kagan wrote: On Tue, Jul 03, 2018 at 03:27:23PM -0700, si-wei liu wrote: On 7/3/2018 2:58 AM, Roman Kagan wrote: So how is this coordination going to work? One possibility is that the PV device emits a QMP event upon the guest driver confirming the support for fai

[Qemu-devel] [PATCH v2 6/6] riscv64-softmmu.mak: Build Virtio Block support

2018-07-09 Thread Alistair Francis
Add build time support for the VirtIO block device. This allows us to attach a drive using the virtio-blk-device. Signed-off-by: Alistair Francis --- default-configs/riscv64-softmmu.mak | 2 ++ 1 file changed, 2 insertions(+) diff --git a/default-configs/riscv64-softmmu.mak b/default-configs/r

[Qemu-devel] [PATCH v2 5/6] hw/riscv/sifive_u: Connect the Xilinx PCIe

2018-07-09 Thread Alistair Francis
Connect the Xilinx PCIe device based on the information in the device tree stored in the ROM of the HiFish Unleashed board. Signed-off-by: Alistair Francis --- default-configs/riscv32-softmmu.mak | 1 + default-configs/riscv64-softmmu.mak | 1 + hw/riscv/sifive_u.c | 64 +++

[Qemu-devel] [PATCH v2 4/6] hw/riscv/virt: Connect a VGA PCIe device

2018-07-09 Thread Alistair Francis
Signed-off-by: Alistair Francis --- default-configs/riscv32-softmmu.mak | 3 +++ default-configs/riscv64-softmmu.mak | 3 +++ hw/riscv/virt.c | 7 ++- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/default-configs/riscv32-softmmu.mak b/default-configs/risc

[Qemu-devel] [PATCH v2 3/6] hw/riscv/virt: Connect the gpex PCIe

2018-07-09 Thread Alistair Francis
Connect the gpex PCIe device based on the device tree included in the HiFive Unleashed ROM. Signed-off-by: Alistair Francis --- default-configs/riscv32-softmmu.mak | 3 ++ default-configs/riscv64-softmmu.mak | 3 ++ hw/riscv/virt.c | 58 + includ

[Qemu-devel] [PATCH v2 2/6] hw/riscv/virt: Increase the number of interrupts

2018-07-09 Thread Alistair Francis
Increase the number of interrupts to match the HiFive Unleashed board. Signed-off-by: Alistair Francis --- include/hw/riscv/virt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h index 91163d6cbf..7cb2742070 100644 --- a/inclu

[Qemu-devel] [PATCH v2 1/6] hw/riscv/virtio: Set the soc device tree node as a simple-bus

2018-07-09 Thread Alistair Francis
To allow Linux to ennumerate devices on the /soc/ node set it as a "simple-bus". Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index aeada2498d..5336166f6d 100644 --- a/hw/riscv/virt.c +++

[Qemu-devel] [PATCH v2 0/6] Connect a PCIe host and graphics support to RISC-V

2018-07-09 Thread Alistair Francis
V2: - Use the gpex PCIe host for virt - Add support for SiFive U PCIe Alistair Francis (6): hw/riscv/virtio: Set the soc device tree node as a simple-bus hw/riscv/virt: Increase the number of interrupts hw/riscv/virt: Connect the gpex PCIe hw/riscv/virt: Connect a VGA PCIe device hw/r

Re: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-09 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 2018071024.542612-1-...@redhat.com Subject: [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=

[Qemu-devel] [PATCH hack dontapply v2 6/7] acpi: aml generation for _CST

2018-07-09 Thread Michael S. Tsirkin
This adds a method called CCST under CPUS. Each CPU will add _CST calling in turn CCST from there. As _CST needs to change across migration, we use dynamic loading of tables as follows: - a special scratch buffer, 4K in size is requested from bios through the loader. - each time CCST executes,

[Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor

2018-07-09 Thread Michael S. Tsirkin
Based on patch by Igor Mammedov. This is a hack: we definitely shouldn't do it unconditionally, and initialization should be handled differently (through an isa device?). io port to use should depend on the PC type and should be documented. Notifications should be supported. Signed-off-by: Micha

[Qemu-devel] [PATCH hack dontapply v2 2/7] acpi: generalize aml_package / aml_varpackage

2018-07-09 Thread Michael S. Tsirkin
VarPackage can accept an expression evaluating to int, not just an int. Change the API to make it more generic. Further, rather than have users call the correct API depending on value passed, use either PackageOp or VarPackageOp automatically. Signed-off-by: Michael S. Tsirkin --- include/hw/acp

[Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation

2018-07-09 Thread Michael S. Tsirkin
Now that basic support for guest CPU PM is upstream, I started looking for making it migrateable. Since a VM can be migrated between different hosts, PM info needs to change each time with move the VM to a different host. This adds infrastructure - based on Load/Unload - to support exactly that:

[Qemu-devel] [PATCH hack dontapply v2 5/7] acpi: init header without linking

2018-07-09 Thread Michael S. Tsirkin
build_header inits the table header and then adds it to list for checksumming and linking into XSDT. Dynamically loaded SSDTs are not linked into XSDT so they just need the header initialized. Split out the relevant part of build_header so it can be invoked externally for this purpose. Signed-off

[Qemu-devel] [PATCH hack dontapply v2 1/7] acpi: aml: add aml_register()

2018-07-09 Thread Michael S. Tsirkin
Based on a patch by Igor Mammedov. Signed-off-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 5 + hw/acpi/aml-build.c | 21 + 2 files changed, 26 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml

[Qemu-devel] [PATCH hack dontapply v2 3/7] acpi: aml_load/aml_unload

2018-07-09 Thread Michael S. Tsirkin
Dynamic loading/unloading of tables. Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c | 21 + 2 files changed, 23 insertions(+) diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h index 7cf2cf64bf..f764

[Qemu-devel] [PATCH hack dontapply v2 4/7] acpi: export acpi_checksum

2018-07-09 Thread Michael S. Tsirkin
For most tables we supply to guests checksum is calculated by the bios at load time. However, when table needs to be changed later dynamically, QEMU has to calculate the checksum. Export acpi_checksum so ACPI generation code can re-use it. Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-09 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 02:54:12AM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > > Every time we create new PC machine-types in QEMU, the defaults > > for SMBIOS fields change unnecessarily because the version field > > defaults to MachineClas

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > Every time we create new PC machine-types in QEMU, the defaults > for SMBIOS fields change unnecessarily because the version field > defaults to MachineClass::name. > > This can cause unexpected side-effects, like triggering licens

[Qemu-devel] [Qemu-block] 2018-07-09 Incremental Backup Status Report

2018-07-09 Thread John Snow
On 07/02/2018 07:47 PM, John Snow wrote: > I'm tracking the following series for Incremental Backup right now; if > it's not on this list, I don't know about it: > > [Qemu-devel] [PATCH v4 0/2] block: formalize and test fleecing​ Merged. > [Qemu-devel] [PATCH v2 0/3] image fleecing Dropped i

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 08:19:17PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 05:52:32PM +0200, Igor Mammedov wrote: > > On Fri, 6 Jul 2018 02:53:09 +0300 > > "Michael S. Tsirkin" wrote: > > > > > VarPackage can accept an expression evaluating to int, not just an int. > > > Change

Re: [Qemu-devel] [PATCH 3/6] bloc/qcow2: drop dirty_bitmaps_loaded state variable

2018-07-09 Thread John Snow
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > This variable doesn't work as it should, because it is actually cleared > in qcow2_co_invalidate_cache() by memset(). Drop it, as the following > patch will introduce new behavior. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > -

Re: [Qemu-devel] [PATCH 1/2] qga-win: prevent crash when executing fsinfo command

2018-07-09 Thread Michael Roth
Quoting Sameeh Jubran (2018-06-28 18:33:58) > > > On Fri, Jun 29, 2018 at 12:44 AM, Eric Blake wrote: > > On 06/26/2018 10:10 AM, Sameeh Jubran wrote: > > From: Sameeh Jubran > > The fsinfo command is currently implemented for Windows only and it's > disk >

Re: [Qemu-devel] [PULL v4 0/7] riscv-pull queue

2018-07-09 Thread Michael Clark
On Tue, Jul 10, 2018 at 9:52 AM, Alistair Francis wrote: > On Mon, Jul 9, 2018 at 3:00 AM, Andreas Schwab wrote: > > What is the state of the sifive_u emulation? When I tried to boot a bbl > > with an included kernel I get these errors: > > > > qemu-system-riscv64: plic: invalid register write:

Re: [Qemu-devel] [PATCH 2/6] block/qcow2: improve error message in qcow2_inactivate

2018-07-09 Thread John Snow
On 06/28/2018 08:16 AM, Eric Blake wrote: > On 06/26/2018 08:50 AM, Vladimir Sementsov-Ogievskiy wrote: >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   block/qcow2.c | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/block/qcow2.c b/block/qcow2.c >> in

Re: [Qemu-devel] [PATCH 1/6] iotests: 169: drop deprecated 'autoload' parameter

2018-07-09 Thread John Snow
On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Sebastian Bauer
Hi, Am 2018-07-09 23:23, schrieb Eduardo Habkost: List of machines with default_display==NULL on those architectures: alpha: none empty machine mips: mipssim MIPS MIPSsim platform none empty machine ppc*: bamboo bamboo mpc8544ds

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Thomas Huth
On 09.07.2018 23:42, Peter Maydell wrote: > On 9 July 2018 at 22:03, Thomas Huth wrote: >> When trying to "device_add bcm2837" on a machine that is not suitable for >> this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": >> >> echo "{'execute':'qmp_capabilities'} {'execute':

Re: [Qemu-devel] [PULL v4 0/7] riscv-pull queue

2018-07-09 Thread Alistair Francis
On Mon, Jul 9, 2018 at 3:00 AM, Andreas Schwab wrote: > What is the state of the sifive_u emulation? When I tried to boot a bbl > with an included kernel I get these errors: > > qemu-system-riscv64: plic: invalid register write: 2090 > qemu-system-riscv64: plic: invalid register write: 20

Re: [Qemu-devel] [PULL 0/2] Machine/NUMA fixes for -rc0

2018-07-09 Thread Peter Maydell
On 9 July 2018 at 18:41, Eduardo Habkost wrote: > The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2018-07-06 18:18:08 +0100) > > are available in the Git repository at: > > git://

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Peter Maydell
On 9 July 2018 at 22:03, Thomas Huth wrote: > When trying to "device_add bcm2837" on a machine that is not suitable for > this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": > > echo "{'execute':'qmp_capabilities'} {'execute':'device_add', " \ > "'arguments':{'driver':'bcm

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Thomas Huth
On 09.07.2018 23:31, Eduardo Habkost wrote: > On Mon, Jul 09, 2018 at 11:03:00PM +0200, Thomas Huth wrote: >> When trying to "device_add bcm2837" on a machine that is not suitable for >> this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": >> >> echo "{'execute':'qmp_capabili

Re: [Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Eduardo Habkost
On Mon, Jul 09, 2018 at 11:03:00PM +0200, Thomas Huth wrote: > When trying to "device_add bcm2837" on a machine that is not suitable for > this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": > > echo "{'execute':'qmp_capabilities'} {'execute':'device_add', " \ > "'argument

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Eduardo Habkost
On Fri, Jul 06, 2018 at 08:53:42AM +0200, Gerd Hoffmann wrote: > On Thu, Jul 05, 2018 at 01:35:01PM -0300, Eduardo Habkost wrote: > > Do we have a list of all machine-types with default_display==NULL > > that would be affected by this? > > There are not many which use the default vga thing in the

[Qemu-devel] [PATCH v2 33/33] target/mips: Add definition of nanoMIPS I7200 CPU

2018-07-09 Thread Aleksandar Markovic
From: Stefan Markovic Add definition of the first nanoMIPS processor in QEMU. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/translate_init.inc.c | 37 + 1 file changed, 37 insertions(+) diff -

[Qemu-devel] [PATCH v2 32/33] gdbstub: Add XML support for GDB for nanoMIPS

2018-07-09 Thread Aleksandar Markovic
From: Stefan Markovic Add XML support files for GDB for nanoMIPS. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- MAINTAINERS| 3 ++- gdb-xml/nanomips-cp0.xml | 13 + gdb-xml/nanomips-cpu.xml | 44 +

Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

2018-07-09 Thread Eduardo Habkost
On Mon, Jul 09, 2018 at 06:08:33PM -0300, Eduardo Habkost wrote: > On Fri, Jul 06, 2018 at 08:53:42AM +0200, Gerd Hoffmann wrote: > > On Thu, Jul 05, 2018 at 01:35:01PM -0300, Eduardo Habkost wrote: > > > Do we have a list of all machine-types with default_display==NULL > > > that would be affected

[Qemu-devel] [PATCH v2 31/33] gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub

2018-07-09 Thread Aleksandar Markovic
From: James Hogan nanoMIPS has no ISA bit in the PC, so remove the handling of the low bit of the PC in the MIPS gdbstub for nanoMIPS. This prevents the PC being read as e.g. 0xbfc1, and prevents writing to the PC clearing MIPS_HFLAG_M16. Signed-off-by: James Hogan Signed-off-by: Yongbok Ki

Re: [Qemu-devel] [PATCH v2 1/1] tests/migration: Skip tests for ppc tcg

2018-07-09 Thread Thomas Huth
On 06.07.2018 16:31, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > PPC tcg seems to be failing migration tests quite regularly; > we believe this is TCG bugs in dirty bit updating; it's > not clear why PPC fails more but lets skip for the moment. > > $ ./tests/migratio

[Qemu-devel] [PATCH v2 30/33] mips_malta: Fix semihosting argument passing for nanoMIPS bare metal

2018-07-09 Thread Aleksandar Markovic
From: Stefan Markovic Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- hw/mips/mips_malta.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c index d1a7c1f..8bb1686 100644 --- a

[Qemu-devel] [PATCH v2 27/33] target/mips: Add ELF flags for MIPS machine variants

2018-07-09 Thread Aleksandar Markovic
From: Aleksandar Markovic Add MIPS machine variants ELF flags so that the emulation behavior can be adjusted if needed. Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- include/elf.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/elf.

[Qemu-devel] [PATCH v2 29/33] mips_malta: Setup GT64120 BARs in nanoMIPS bootloader

2018-07-09 Thread Aleksandar Markovic
From: Paul Burton Setup the GT64120 BARs in the nanoMIPS bootloader, in the same way that they are setup in the MIPS32 bootloader. This is necessary for Linux to be able to access peripherals, including the UART. Signed-off-by: Paul Burton Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar M

[Qemu-devel] [PATCH v2 26/33] target/mips: Fix ERET/ERETNC behavior related to ADEL exception

2018-07-09 Thread Aleksandar Markovic
From: Yongbok Kim Fix ERET/ERETNC so that ADEL exception can be raised. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/op_helper.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target/mips/op_help

[Qemu-devel] [PATCH v2 28/33] mips_malta: Add basic nanoMIPS boot code for MIPS' Malta

2018-07-09 Thread Aleksandar Markovic
From: Matthew Fortune Added very very basic nanoMIPS boot code but this is hacked in unconditionally currently. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- hw/mips/mips_malta.c | 75 +++- inc

[Qemu-devel] [PATCH v2 22/33] target/mips: Adjust behavior of Config3's ISAOnExc bit for nanoMIPS

2018-07-09 Thread Aleksandar Markovic
From: Yongbok Kim Config3.ISAOnExc is read only in nanoMIPS. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/op_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/mips/op_helper.c b/target/mips/op

[Qemu-devel] [PATCH v2 23/33] target/mips: Adjust exception_resume_pc() for nanoMIPS

2018-07-09 Thread Aleksandar Markovic
From: James Hogan We shouldn't set the ISA bit in CP0_EPC for nanoMIPS. Signed-off-by: James Hogan Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/targ

[Qemu-devel] [PATCH] hw/arm/bcm283x: Fix crash with device_add bcm2837 on unsupported machines

2018-07-09 Thread Thomas Huth
When trying to "device_add bcm2837" on a machine that is not suitable for this device, you can quickly crash QEMU afterwards, e.g. with "info qtree": echo "{'execute':'qmp_capabilities'} {'execute':'device_add', " \ "'arguments':{'driver':'bcm2837'}} {'execute': 'human-monitor-command', " \ "'ar

[Qemu-devel] [PATCH v2 19/33] target/mips: Implement emualtion of nanoMIPS LLWP/SCWP pair

2018-07-09 Thread Aleksandar Markovic
From: Yongbok Kim Implement nanoMIPS LLWP and SCWP instruction pair. Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- linux-user/mips/cpu_loop.c | 25 --- target/mips/cpu.h | 2 + target/mips/helper.h | 2 + target/m

[Qemu-devel] [PATCH v2 21/33] target/mips: Add updating CP0 BadInstrX register for nanoMIPs only

2018-07-09 Thread Aleksandar Markovic
From: Stefan Markovic Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Stefan Markovic --- target/mips/helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/mips/helper.c b/target/mips/helper.c index 5299f21..9535131 100644 --- a/target/mips/hel

  1   2   3   >