Hi,
This series failed docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 20181029173437.32559-1-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] scsi-generic
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> ---
> hw/Makefile.objs| 1 +
> hw/nubus/Makefile.objs | 4 +
> hw/nubus/mac-nubus-
On 6 November 2018 at 14:13, Eduardo Habkost wrote:
> The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
> seems to provide an older version. Change the existing rules to
> use command output instead of exit code, to make it compatible
> with older GNU make versions.
>
> Signed-off-
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
A device can report an excessive number of VPD pages when asked for a
list; this can cause an out-of-bounds access to buf in
scsi_generic_set_vpd_bl_emulation. It should not happen, but
it is technically not incorrect so handle it: do not check any by
On 10/29/18 2:34 PM, Paolo Bonzini wrote:
Block limits emulation is just placing 0xb0 as the final byte of the
VPD pages list. However, VPD page numbers must be sorted, so change
that to an in-place insert. Since I couldn't find any disk that triggered
the loop more than once, this was teste
Currently replay_get_byte() does not check for an error
from getc(). Coverity points out (CID 1390622) that this
could result in unexpected behaviour (such as looping
forever, if we use the replay_get_dword() return value
for a loop count). We don't expect reads from the replay
log to fail, and if
On 6 November 2018 at 15:15, Philippe Mathieu-Daudé wrote:
> No worry, I'm not mad at all, but there might be an issue in your git PR
> workflow, this series also missed your maintainer S-o-b.
>
> Peter: Can you add a such check in your scripts? (during next merge window,
> no hurry).
>
> Rather t
On Tue 06 Nov 2018 04:13:58 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> 06.11.2018 18:06, Alberto Garcia wrote:
>> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>
>>> +buf = g_try_malloc(csize);
>>> +if (!buf) {
>>> +return -ENOMEM;
>>> +}
>>> +i
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181029173437.32559-1-pbonz...@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] scsi-generic: fixes for Block Limits emulation
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n
The slirp socreate() function can only fail if the attempt
to malloc() the struct socket fails. Switch to using
g_new() instead, which will allow us to remove the
error-handling code from its callers.
Signed-off-by: Peter Maydell
---
We already use g_new/g_malloc in slirp, including for
mbuf buff
Currently fork_exec() fork()s, and then creates and connects the
child socket which it uses for communication with the parent in
the child process. This is awkward because the child has no
mechanism to report failure back to the parent, which might end
up blocked forever in accept(). The child code
Now that socreate() can never fail, we can remove the code
that was trying to handle that situation.
In particular this removes code in tcp_connect() that
provoked Coverity to complain (CID 1005724): in
closesocket(accept(inso->s, (struct sockaddr *)&addr, &addrlen));
if the accept() call fails t
There are three outstanding Coverity issues for the slirp code.
This patchset fixes them:
* easiest first, we explicitly check for so->s == -1 in slirp_send()
to avoid possibly passing -1 to the send() function.
In an ideal world we could assert() it wasn't -1, but the
slirp code is too c
On 06/11/2018 15:52, Thomas Huth wrote:
> On 2018-11-02 10:05, P J P wrote:
>> +-- On Sat, 27 Oct 2018, P J P wrote --+
>> |+-- On Sun, 21 Oct 2018, P J P wrote --+
>> || The length parameter values are not negative, thus use an unsigned
>> || type 'size_t' for them. Many routines pass 'len' values
On 2018-11-06 16:13, Stefan Berger wrote:
> Display a message during the test using g_test_message rather
> than fprintf.
>
> Signed-off-by: Stefan Berger
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> i
On 6/11/18 15:13, Michael S. Tsirkin wrote:
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/hex-loader-check-data contains data files used
by the hexloader-test, and configure individually
06.11.2018 16:53, Alberto Garcia wrote:
> On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index e9d24b801e..950b9f7ec6 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -3956,14 +3956,15 @@ fail:
>> int qcow2_deco
06.11.2018 18:06, Alberto Garcia wrote:
> On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>
>> +buf = g_try_malloc(csize);
>> +if (!buf) {
>> +return -ENOMEM;
>> +}
>> +iov.iov_base = buf;
>> +iov.iov_len = csize;
>> +qemu_iovec_init_external(
Coverity complains (CID 1005726) that we might pass -1 as the fd
argument to send() in slirp_send(), because we previously checked for
"so->s == -1 && so->extra". The case of "so->s == -1 but so->extra
NULL" should not in theory happen, but it is hard to guarantee
because various places in the cod
On Thu 01 Nov 2018 07:27:37 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> +buf = g_try_malloc(csize);
> +if (!buf) {
> +return -ENOMEM;
> +}
> +iov.iov_base = buf;
> +iov.iov_len = csize;
> +qemu_iovec_init_external(&local_qiov, &iov, 1);
>
> -iov.iov_base
Display a message during the test using g_test_message rather
than fprintf.
Signed-off-by: Stefan Berger
---
tests/tpm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 93a5beba01..5f217a2d92 100644
--- a/tests/tpm-tests.c
+++
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> ---
> arch_init.c| 4 +
> hw/display/Makefile.objs | 1 +
> hw/d
On 2018-11-02 16:22, Mark Cave-Ayland wrote:
> From: Laurent Vivier
>
> Co-developed-by: Mark Cave-Ayland
> Signed-off-by: Mark Cave-Ayland
> Signed-off-by: Laurent Vivier
> Reviewed-by: Hervé Poussineau
> ---
> hw/misc/mac_via.c | 190
> +
On 21/10/18 19:58, P J P wrote:
From: Prasad J Pandit
The length parameter values are not negative, thus use an unsigned
type 'size_t' for them. Many routines pass 'len' values to memcpy(3)
calls. If it was negative, it could lead to memory corruption issues.
Add check to avoid it.
Reported-by
On 2018-11-04 14:41, Mark Cave-Ayland wrote:
> On 04/11/2018 06:53, no-re...@patchew.org wrote:
>
>> Hi,
>>
>> This series seems to have some coding style problems. See output below for
>> more information:
>>
>> Type: series
>> Message-id: 20181102152257.20637-1-mark.cave-ayl...@ilande.co.uk
>> S
On 2018-11-02 10:05, P J P wrote:
> +-- On Sat, 27 Oct 2018, P J P wrote --+
> |+-- On Sun, 21 Oct 2018, P J P wrote --+
> || The length parameter values are not negative, thus use an unsigned
> || type 'size_t' for them. Many routines pass 'len' values to memcpy(3)
> || calls. If it was negative,
Hi Peter,
Can you apply this patch as a CI bug-fix?
Thanks,
Phil.
On 6/11/18 15:27, Philippe Mathieu-Daudé wrote:
On 6/11/18 15:13, Eduardo Habkost wrote:
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use com
On 11/6/18 6:51 AM, Thomas Huth wrote:
On 2018-10-30 22:47, Stefan Berger wrote:
From: Marc-André Lureau
If swtpm is not found in $PATH or --tpm2 isn't supported, we display
this in the test log. We cannot mark the test as skipped due to a bug in
certain versions of the gtester environment tha
On Tue, Nov 06, 2018 at 11:23:33AM +0100, Gerd Hoffmann wrote:
> Print a warning for deprecated and obsolete devices.
> Also add support state to device listing.
>
> Signed-off-by: Gerd Hoffmann
Should we also add a runtime flag to block these?
E.g. I can see libvirt doing that and passing
the r
On 11/6/18 3:13 AM, Marc-André Lureau wrote:
Hi
On Tue, Nov 6, 2018 at 9:24 AM P J P wrote:
From: Prasad J Pandit
When TIS request is done, set 'sts' data field across all localities.
The code certainly meant to set the field across all localities.
However I don't see in the "TCG PC Client
On 6/11/18 15:13, Eduardo Habkost wrote:
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use command output instead of exit code, to make it compatible
with older GNU make versions.
You were quicker, I just found
On Tue, Nov 06, 2018 at 11:23:31AM +0100, Gerd Hoffmann wrote:
> Indicates support state for something (device, backend, subsystem, ...)
> in qemu. Add QemuSupportState field to ObjectClass. Add some support
> code.
>
> TODO: wire up to qom-list-types
>
> Signed-off-by: Gerd Hoffmann
> ---
[..
On 11/6/18 12:21 AM, P J P wrote:
From: Prasad J Pandit
When TIS request is done, set 'sts' data field across all localities.
Signed-off-by: Prasad J Pandit
Reviewed-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm
;
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/seabios-20181106-pull-request
>
> for you to fetch changes up to 0b8f74488e50f98b04e63157f85fde8a13f8d6aa:
>
> update seabios to master snapshot (2018-11-06 12:23:58 +0100)
>
> ---
Peter Maydell writes:
> Looking through code I noticed that in target/arm/translate.c there
> is the following comment in the decode for the load-acquire/store-release
> instructions:
>
> /* Since the emulation does not have barriers,
> the acquire/release semantics need no speci
On Thu 01 Nov 2018 07:27:38 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> Do decompression in threads, like it is already done for compression.
> This improves asynchronous compressed reads performance.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Alberto Garcia
Berto
The $(SHELLSTATUS) variable requires GNU make >= 4.2, but Travis
seems to provide an older version. Change the existing rules to
use command output instead of exit code, to make it compatible
with older GNU make versions.
Signed-off-by: Eduardo Habkost
---
I think that's the cause of the Travis
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote:
> On 5/11/18 19:14, Michael S. Tsirkin wrote:
> > From: Peter Maydell
> >
> > Currently tests/hex-loader-check-data contains data files used
> > by the hexloader-test, and configure individually symlinks those
> > data files
Pavel has a new email address, cc'd - steve
On 11/6/2018 12:42 AM, Dominique Martinet wrote:
> (added various kvm/virtualization lists in Cc as well as qemu as I don't
> know who's "wrong" here)
>
> Pavel Tatashin wrote on Thu, Jul 19, 2018:
>> Allow sched_clock() to be used before schec_clock_in
(added various kvm/virtualization lists in Cc as well as qemu as I don't
know who's "wrong" here)
Pavel Tatashin wrote on Thu, Jul 19, 2018:
> Allow sched_clock() to be used before schec_clock_init() is called.
> This provides with a way to get early boot timestamps on machines with
> unstable clo
On Thu 01 Nov 2018 07:27:36 PM CET, Vladimir Sementsov-Ogievskiy wrote:
> diff --git a/block/qcow2.c b/block/qcow2.c
> index e9d24b801e..950b9f7ec6 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3956,14 +3956,15 @@ fail:
> int qcow2_decompress_cluster(BlockDriverState *bs, uint64_t clus
61f0f4b4947:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20181105' into
> staging (2018-11-06 09:10:46 +)
>
> are available in the Git repository at:
>
> https://git.linaro.org/people/pmaydell/qemu-arm.git
> tags/p
On 6/11/18 14:10, Peter Maydell wrote:
On 31 October 2018 at 00:31, Eduardo Habkost wrote:
From: Cleber Rosa
A number of QEMU tests are written in Python, and may benefit
from an untainted Python venv.
By using make rules, tests that depend on specific Python libs
can set that rule as a requ
Public bug reported:
Launching a centos74 iso VM today does not work anymore on x86_64
without increasing the size of the memory parameter. For example with
this command :
$ /opt/qemu-3.0.0/bin/qemu-system-x86_64 --curses -enable-kvm -drive
file=file.dd,index=0,media=disk -drive file=centos-
x8
On 5 November 2018 at 19:44, Alistair Francis wrote:
> Coverity caught a malloc() call that was never freed. This patch ensures
> that we free the memory but also updates the allocation to use
> g_strdup_printf() instead of malloc().
>
> Signed-off-by: Alistair Francis
> Suggested-by: Peter Mayde
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/acpi-test-data contains data files used by the
bios-tables-test, and configure individually symlinks those
data files into the build directory using a wildcard.
Using a wildcard like this is a bad idea, because if
Looks like we've fixed them all already in the past months, e.g. with:
f7d6bfcdc0fe49040aac3ac131a319cb5427957e
spapr_pci: fail gracefully with non-pseries machine types
2363d5ee231bf047479422d56d3b85b7d37a7c23
hw/ppc/spapr_cpu_core: Add a proper check for spapr machine
ef0e8fc768a561dd13a8
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
Currently tests/hex-loader-check-data contains data files used
by the hexloader-test, and configure individually symlinks those
data files into the build directory using a wildcard.
Using a wildcard like this is a bad idea, becaus
On 5/11/18 19:14, Michael S. Tsirkin wrote:
From: Peter Maydell
The FILES variable is used to accumulate a list of things to symlink
from the source tree into the build tree. These don't have to be
individual files; symlinking an entire directory of data files is
also fine. Rename it to somet
On 31 October 2018 at 00:31, Eduardo Habkost wrote:
> From: Cleber Rosa
>
> A number of QEMU tests are written in Python, and may benefit
> from an untainted Python venv.
>
> By using make rules, tests that depend on specific Python libs
> can set that rule as a requirement, along with rules that
Am 01.11.2018 um 07:29 hat Fam Zheng geschrieben:
> Use error_report for situations that affect user operation (i.e. we're
> actually returning error), and warn_report/warn_report_err when some
> less critical error happened but the user operation can still carry on.
>
> For raw_normalize_devicep
On 6 November 2018 at 11:20, Peter Maydell wrote:
> On 6 November 2018 at 11:07, Michael S. Tsirkin wrote:
>> On Tue, Nov 06, 2018 at 09:18:49AM +0100, Thomas Huth wrote:
>>> On 2018-11-05 19:14, Michael S. Tsirkin wrote:
>>> > The following changes since commit
>>> > b2f7a038bb4c4fc5ce6b8486e85
On 01/11/2018 11:44, Igor Mammedov wrote:
> object_new() returns a new backend with refcount == 1 and
> then later object_property_add_child() increases refcount to 2
> So when ivshmem is desroyed, the backend it has created isn't
> destroyed along with it as children cleanup will bring
> backend's
在 2018/11/6 20:28, Paolo Bonzini 写道:
> On 06/11/2018 13:27, li qiang wrote:
>> The addr is 0~0x1fff, but when addr is at the near the end ,for example
>> 0x1fffe, the add>>2 can be 2047
>>
>> and as script_ram is a uint32_t and so s->script_ram[addr >> 2] can read
>> out of the script_ram.
> How s
On Tue, Nov 06, 2018 at 09:10:45AM +0300, Pavel Dovgalyuk wrote:
> > From: David Gibson [mailto:da...@gibson.dropbear.id.au]
> > On Tue, Oct 30, 2018 at 12:30:31PM +0300, Pavel Dovgalyuk wrote:
> > > This patch fixes processing of mtmsr instructions in icount mode.
> > > In this mode writing to int
On 6 November 2018 at 12:27, li qiang wrote:
> The addr is 0~0x1fff, but when addr is at the near the end ,for example
> 0x1fffe, the add>>2 can be 2047
>
> and as script_ram is a uint32_t and so s->script_ram[addr >> 2] can read
> out of the script_ram.
But script_ram is declared as
uint32_t s
Validate that frontend callbacks for CHR_EVENT_OPENED/CHR_EVENT_CLOSED
events are being issued when expected and in strictly pairing order.
Signed-off-by: Artem Pisarenko
---
tests/test-char.c | 80 +--
1 file changed, 78 insertions(+), 2 delet
> this is unnecessary change, I can drop on commit
Oops, didn't noticed your message before sent v3.
When chardev is multiplexed (mux=on) there are a lot of cases where
CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from
frontend side) is broken. There are either generation of multiple
repeated or extra CHR_EVENT_OPENED events, or CHR_EVENT_CLOSED just
isn't generated at all.
This is m
On 6 November 2018 at 12:38, li qiang wrote:
>
> 在 2018/11/6 20:28, Paolo Bonzini 写道:
>> On 06/11/2018 13:27, li qiang wrote:
>>> The addr is 0~0x1fff, but when addr is at the near the end ,for example
>>> 0x1fffe, the add>>2 can be 2047
>>>
>>> and as script_ram is a uint32_t and so s->script_ram
This issue actually more complex. Idea of generating events from inside
function called '*_set_handlers' isn't good, at least its implicit nature, and
especially a fact, that function decides about open state (see 'fe_open'
variable), but generates event only in one direction. Combined with
'mu
On 06/11/2018 13:27, li qiang wrote:
> The addr is 0~0x1fff, but when addr is at the near the end ,for example
> 0x1fffe, the add>>2 can be 2047
>
> and as script_ram is a uint32_t and so s->script_ram[addr >> 2] can read
> out of the script_ram.
How so? s->script_ram has size 2048, it's okay
On 06/11/2018 13:03, Peter Maydell wrote:
> When can this masking have any effect? These functions are
> the read and write ops for lsi_ram_ops, which we register with
> memory_region_init_io(&s->ram_io, OBJECT(s), &lsi_ram_ops, s,
> "lsi-ram", 0x2000);
> which specifi
在 2018/11/6 20:03, Peter Maydell 写道:
> On 6 November 2018 at 11:53, P J P wrote:
>> From: Prasad J Pandit
>>
>> While accessing script ram[2048] via 'lsi_ram_read/write' routines,
>> 'addr' could exceed the ram range. Mask high order bits to avoid
>> OOB access.
>>
>> Reported-by: Mark Kanda
>>
From: Xiao Guangrong
Adapt the compression code to the threaded workqueue
Signed-off-by: Xiao Guangrong
---
migration/ram.c | 313 +---
1 file changed, 115 insertions(+), 198 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index
On Wed, Oct 31, 2018 at 06:24:56AM +, Chen Zhang wrote:
> The issue was reported as in https://bugs.launchpad.net/qemu/+bug/1793859
>
> When an OpenGL accelerated GTK window is used for iGVT-g DMA Buf device,
> window scaling would cause guest cursor to move in undesirable velocity.
>
> To fi
From: Xiao Guangrong
It will be used by threaded workqueue
Signed-off-by: Xiao Guangrong
---
include/qemu/bitops.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index 3f0926cf40..c522958852 100644
--- a/include/qemu/bitops.h
++
From: Xiao Guangrong
It's the benhcmark of threaded-workqueue, also it's a good
example to show how threaded-workqueue is used
Signed-off-by: Xiao Guangrong
---
tests/Makefile.include | 5 +-
tests/threaded-workqueue-bench.c | 256 +++
2 files ch
From: Xiao Guangrong
Adapt the compression code to the threaded workqueue
Signed-off-by: Xiao Guangrong
---
migration/ram.c | 225
1 file changed, 81 insertions(+), 144 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index a
From: Xiao Guangrong
This modules implements the lockless and efficient threaded workqueue.
Three abstracted objects are used in this module:
- Request.
It not only contains the data that the workqueue fetches out
to finish the request but also offers the space to save the result
af
From: Xiao Guangrong
Changelog in v2:
These changes are based on Paolo's suggestion:
1) rename the lockless multithreads model to threaded workqueue
2) hugely improve the internal design, that make all the request be
a large array, properly partition it, assign requests to threads
respectiv
When blk_flush called in NVMe reset path S/C queues are already freed
which means that re-entering AIO handling loop having some IO requests
unfinished will lockup or crash as their SG structures being potentially
reused. Call blk_drain before freeing the queues to avoid this nasty
scenario.
Signe
On 6 November 2018 at 11:53, P J P wrote:
> From: Prasad J Pandit
>
> While accessing script ram[2048] via 'lsi_ram_read/write' routines,
> 'addr' could exceed the ram range. Mask high order bits to avoid
> OOB access.
>
> Reported-by: Mark Kanda
> Signed-off-by: Prasad J Pandit
> ---
> hw/scs
From: Prasad J Pandit
While accessing script ram[2048] via 'lsi_ram_read/write' routines,
'addr' could exceed the ram range. Mask high order bits to avoid
OOB access.
Reported-by: Mark Kanda
Signed-off-by: Prasad J Pandit
---
hw/scsi/lsi53c895a.c | 2 ++
1 file changed, 2 insertions(+)
diff
Looking through code I noticed that in target/arm/translate.c there
is the following comment in the decode for the load-acquire/store-release
instructions:
/* Since the emulation does not have barriers,
the acquire/release semantics need no special
handling */
This is out
On 2018-10-30 22:47, Stefan Berger wrote:
> From: Marc-André Lureau
>
> If swtpm is not found in $PATH or --tpm2 isn't supported, we display
> this in the test log. We cannot mark the test as skipped due to a bug in
> certain versions of the gtester environment that interprets a skipped test
> as
On 5 November 2018 at 22:44, Brad Smith wrote:
> ping.
>
Thanks for the ping, applied to master for rc0.
-- PMM
In exynos4210_init() we allocate memory for an Exynos4210State
struct. Generally devices can assume that the memory allocated
for their state struct is zero-initialized; we broke that
assumption here by using g_new(). Use g_new0() instead.
(In particular, some code assumes that the various irq arra
In do_ats_write() we construct a PAR value based on the result
of the translation. A comment says "S2WLK and FSTAGE are always
zero, because we don't implement virtualization".
Since we do in fact now implement virtualization, add the missing
code that sets these bits based on the reported ARMMMUF
In handle_vec_simd_shli() we have a check:
if (size > 3 && !is_q) {
unallocated_encoding(s);
return;
}
However this can never be true, because we calculate
int size = 32 - clz32(immh) - 1;
where immh is a 4 bit field which we know cannot be all-zeroes.
So the clz32()
Check the return value from load_image_targphys(), which tells us
whether our attempt to load the BIOS image into RAM failed.
(Spotted by Coverity, CID 1190305.)
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Michael Walle
Message-id: 20181030170032.1844-1-peter.mayd
#x27; into
staging (2018-11-06 09:10:46 +)
are available in the Git repository at:
https://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20181106
for you to fetch changes up to 23463e0e4aeb2f0a9c60549a2c163f4adc0b8512:
target/arm: Fix ATS1Hx instructions (2018-11-06 11:3
ATS1HR and ATS1HW (which allow AArch32 EL2 to do address translations
on the EL2 translation regime) were implemented in commit 14db7fe09a2c8.
However, we got them wrong: these should do stage 1 address translations
as defined for NS-EL2, which is ARMMMUIdx_S1E2. We were incorrectly
making them per
Hi
On Mon, Nov 5, 2018 at 4:46 PM Artem Pisarenko
wrote:
>
> When chardev is multiplexed (mux=on) there are a lot of cases, when
> CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from
> frontend side) is broken. There are either generation of multiple
> repeated or extra CHR_EVENT_OPEN
Berto,
Well noted about the "after implementation".
Kindly,
Andrey Shinkevich
On 05.11.2018 19:08, Alberto Garcia wrote:
> On Wed 31 Oct 2018 05:47:19 PM CET, Andrey Shinkevich
> wrote:
>> Adding a parameter to QMP block-stream command to allow discarding
>> blocks in the backing chain while
OK, David,
I will implement that with the next series.
Kindly,
Andrey Shinkevich
On 31.10.2018 20:38, Dr. David Alan Gilbert wrote:
> * Andrey Shinkevich (andrey.shinkev...@virtuozzo.com) wrote:
>> Adding a parameter to QMP block-stream command to allow discarding
>> blocks in the backing chai
The following changes since commit 7d56239f159afc2e7bd42623947e56ba48f37836:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181102'
into staging (2018-11-02 17:17:12 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/seabios-201
On 6 November 2018 at 11:07, Michael S. Tsirkin wrote:
> On Tue, Nov 06, 2018 at 09:18:49AM +0100, Thomas Huth wrote:
>> On 2018-11-05 19:14, Michael S. Tsirkin wrote:
>> > The following changes since commit
>> > b2f7a038bb4c4fc5ce6b8486e8513dfd97665e2a:
>> >
>> > Merge remote-tracking branch '
Hi
On Mon, Nov 5, 2018 at 4:47 PM Artem Pisarenko
wrote:
>
> Validate that frontend callbacks for CHR_EVENT_OPENED/CHR_EVENT_CLOSED
> events are being issued when expected and in strictly pairing order.
>
> Signed-off-by: Artem Pisarenko
> ---
> tests/test-char.c | 80
> +++
Am 06.11.2018 um 09:56 hat Leonid Bloch geschrieben:
> Hi Phil, Hi Eric,
>
> (Eric, for some reason you weren't CC'd to this thread - sorry.)
>
> On 11/5/18 5:58 PM, Philippe Mathieu-Daudé wrote:
> > Hi Leonid,
> >
> > On 4/11/18 19:07, Leonid Bloch wrote:
> >> The lookup table for power-of-two
On Tue, Nov 06, 2018 at 09:18:49AM +0100, Thomas Huth wrote:
> On 2018-11-05 19:14, Michael S. Tsirkin wrote:
> > The following changes since commit b2f7a038bb4c4fc5ce6b8486e8513dfd97665e2a:
> >
> > Merge remote-tracking branch 'remotes/rth/tags/pull-softfloat-20181104'
> > into staging (2018-1
When gdb_set_stop_cpu() is called with a CPU associated to a process
currently not attached by the GDB client, return without modifying the
stop CPU. Otherwise, GDB gets confused if it receives packets with a
thread-id it does not know about.
Signed-off-by: Luc Michel
Acked-by: Alistair Francis
Add support for the '!' extended mode packet. This is required for the
multiprocess extension.
Signed-off-by: Luc Michel
---
gdbstub.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index bd4895ac0a..4132227092 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1294,10 +129
When a new connection is established, we set the first process to be
attached, and the others detached. The first CPU of the first process
is selected as the current CPU.
Signed-off-by: Luc Michel
Reviewed-by: Alistair Francis
---
gdbstub.c | 20 +++-
1 file changed, 15 insertio
Add support for the vAttach packets. In multiprocess mode, GDB sends
them to attach to additional processes.
Signed-off-by: Luc Michel
---
gdbstub.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/gdbstub.c b/gdbstub.c
index 4132227092..ba365808db 100644
Change the Xfer:features:read: packet handling to support the
multiprocess extension. This packet is used to request the XML
description of the CPU. In multiprocess mode, different descriptions can
be sent for different processes.
This function now takes the process to send the description for as
Create two separate CPU clusters for APUs and RPUs.
Signed-off-by: Luc Michel
---
include/hw/arm/xlnx-zynqmp.h | 3 +++
hw/arm/xlnx-zynqmp.c | 21 +
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zyn
Add multiprocess extension support by enabling multiprocess mode when
the peer requests it, and by replying that we actually support it in the
qSupported reply packet.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Alistair Francis
---
gdbstub.c | 6 ++
1 file chan
The gdb_get_cpu_pid() function does the PID lookup for the given CPU. It
checks if the CPU is a direct child of a CPU cluster. If it is, the
returned PID is the cluster ID plus one (cluster IDs start at 0, GDB
PIDs at 1). When the CPU is not a child of such a container, the PID of
the first process
changes since v3:
- patch 1cpu_cluster.h: remove QEMU_ from the multiple includes
guard #ifdef/#define [Alistair]
- patch 1cpu_cluster.c: include osdep.h first [Alistair]
- patch 1use uint64_t for cluster ID for prosperity :) [Philippe]
- patch 1auto-assign
101 - 200 of 250 matches
Mail list logo
