[Qemu-devel] [PATCH V5_resend 0/7] nvdimm: support MAP_SYNC for memory-backend-file

2018-11-19 Thread Zhang Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at

[Qemu-devel] [PATCH V5_resend 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto

2018-11-19 Thread Zhang Yi
Signed-off-by: Zhang Yi A set of RAM_SYNC_ON_OFF_AUTO{AUTO,ON,OFF} flags are added to qemu_ram_mmap(): - If RAM_SYNC_ON_OFF_AUTO_ON is present, qemu_ram_mmap() will try to pass MAP_SYNC to mmap(). It will then fail if the host OS or the backend file do not support MAP_SYNC, or MAP_SYNC is

[Qemu-devel] [PATCH V5_resend 6/7] hostmem: add more information in error messages

2018-11-19 Thread Zhang Yi
When there are multiple memory backends in use, including the object type name, ID and the property name in the error message can help users to locate the error. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- backends/hostmem-file.c | 6 -- backends/hostmem.c | 8 +---

[Qemu-devel] [PATCH V5_resend 2/7] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter

2018-11-19 Thread Zhang Yi
As more flag parameters besides the existing 'shared' are going to be added to qemu_ram_mmap(), let's switch 'shared' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c| 3 +--

[Qemu-devel] [PATCH V5_resend 4/7] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-11-19 Thread Zhang Yi
When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition can guarantee the persistence of guest write to the backend file without other QEMU actions (e.g., periodic fsync() by QEMU). A set of RAM_SYNC flags are added to qemu_ram_mmap(): Signed-off-by:

[Qemu-devel] [PATCH V5_resend 7/7] hostmem-file: add 'sync' option

2018-11-19 Thread Zhang Yi
This option controls whether QEMU mmap(2) the memory backend file with MAP_SYNC flag, which can fully guarantee the guest write persistence to the backend, if MAP_SYNC flag is supported by the host kernel (Linux kernel 4.15 and later) and the backend is a file supporting DAX (e.g., file on

[Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

2018-11-19 Thread Zhang Yi
object_get_canonical_path_component() returns a string which must be freed using g_free(). Signed-off-by: Zhang Yi --- numa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/numa.c b/numa.c index 50ec016..3875e1e 100644 --- a/numa.c +++ b/numa.c @@ -533,6 +533,7 @@ void

[Qemu-devel] [PATCH V5_resend 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the 'flags' parameter

2018-11-19 Thread Zhang Yi
As more flag parameters besides the existing 'share' are going to be added to qemu_ram_alloc_from_{file,fd}(), let's swith 'share' to a 'flags' parameters in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c | 6 -- 1 file

[Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-19 Thread P J P
From: Prasad J Pandit While performing mmio device r/w operations, guest could set 'addr' parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 after setting new 'locty' via 'tpm_tis_new_active_locality'. Add check to avoid OOB access. Reported-by: Cheng Feng Signed-off-by: Prasad

Re: [Qemu-devel] [RFC v1 17/23] riscv: tcg-target: Add direct load and store instructions

2018-11-19 Thread Richard Henderson
On 11/20/18 12:06 AM, Alistair Francis wrote: > On Fri, Nov 16, 2018 at 9:10 AM Richard Henderson > wrote: >> >> On 11/15/18 11:36 PM, Alistair Francis wrote: >>> +tcg_out_opc_reg(s, OPC_ADD, base, TCG_GUEST_BASE_REG, addr_regl); >> >> Should avoid this when guest_base == 0, which happens

Re: [Qemu-devel] [RFC v1 20/23] riscv: tcg-target: Add the target init code

2018-11-19 Thread Richard Henderson
On 11/20/18 12:04 AM, Alistair Francis wrote: > On Fri, Nov 16, 2018 at 9:26 AM Richard Henderson > wrote: >> >> On 11/15/18 11:36 PM, Alistair Francis wrote: >>> +tcg_regset_set_reg(s->reserved_regs, TCG_REG_L0); >>> +tcg_regset_set_reg(s->reserved_regs, TCG_REG_L1); >>> +

Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30

2018-11-19 Thread Peter Xu
On Mon, Nov 19, 2018 at 07:08:13PM +0100, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Nov 19, 2018 at 02:17:27PM +0800, Peter Xu wrote: > >> I reproduced the error with a FreeBSD guest and this change (which > >> possibly can be squashed into "tests: qmp-test: add queue full test")

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-19 Thread Gerd Hoffmann
Hi, > just an update, I enabled the debug prints and I saw two timeouts fired > with a lot > of time lost (~780ms between "init timer" and "Scan for VGA ..."), > putting other prints I discovered that a lot of time is spent in the > tpm_setup(), > during the probe of the 2 TPM devices: > >

Re: [Qemu-devel] [PATCH for-3.2 02/41] glib-compat: add g_spawn_async_with_fds() fallback

2018-11-19 Thread Thomas Huth
On 2018-11-19 23:50, Samuel Thibault wrote: > Marc-André Lureau, le mer. 14 nov. 2018 16:36:04 +0400, a ecrit: >> Signed-off-by: Marc-André Lureau > > Reviewed-by: Samuel Thibault > > include/glib-compat.h maintainers, may I keep this in my slirp tree, to > be pushed to master when

Re: [Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-19 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 4:57 AM Samuel Thibault wrote: > > g_spawn_async_with_fds is portable on Windows, so we can now enable > fork_exec support there. > > Thanks Daniel P. Berrangé for the notice! > > Signed-off-by: Samuel Thibault Reviewed-by: Marc-André Lureau > --- > slirp/misc.c |

[Qemu-devel] [PULL 1/1] update seabios to 1.12

2018-11-19 Thread Gerd Hoffmann
Seabios 1.12 has been released yesterday. Update our snapshot builds to the final release. git shortlog Kevin O'Connor (2): shadow: Rework bios copy code to prevent gcc array-bounds warning docs: Note v1.12.0 release Shmuel Eiderman (1): pvscsi: Scan all 64

[Qemu-devel] [PULL 0/1] Seabios 1.12 20181120 patches

2018-11-19 Thread Gerd Hoffmann
The following changes since commit cb968d275c145467c8b385a3618a207ec111eab1: Update version for v3.1.0-rc1 release (2018-11-13 18:16:14 +) are available in the git repository at: git://git.kraxel.org/qemu tags/seabios-1.12-20181120-pull-request for you to fetch changes up to

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-19 Thread Marc-André Lureau
Hi On Mon, Nov 19, 2018 at 5:59 PM Daniel P. Berrangé wrote: > > When debugging QEMU it is often useful to put a breakpoint on the > error_setg_internal method impl. > > Unfortunately the object_property_add / object_class_property_add > methods call object_property_find /

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:47:40PM -0200, Eduardo Habkost wrote: > On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: > n > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > On Fri, 16 Nov 2018 01:45:51 -0200 > > > Eduardo Habkost wrote: > > > > > > > On

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 10:08:42PM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 07:47:40PM -0200, Eduardo Habkost wrote: > > On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: > > n > > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > > On Fri,

[Qemu-devel] [PATCH 2/2] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

2018-11-19 Thread Max Filippov
Now that xtensa_count_regs does the right thing, remove manual initialization of these fields from the affected configurations and let xtensa_finalize_config initialize them. Add XTREG_END to terminate register lists. Signed-off-by: Max Filippov --- target/xtensa/core-dc232b.c|

[Qemu-devel] [PATCH 0/2] target/xtensa fixes for 3.1

2018-11-19 Thread Max Filippov
Hello, the following two patches fix gdbserver register counting for xtensa-softmmu and xtensa-linux and drops explicit register counters from DC232B and DC233C core configurations. Max Filippov (2): target/xtensa: gdbstub fix register counting target/xtensa: drop num_[core_]regs from

[Qemu-devel] [PATCH 1/2] target/xtensa: gdbstub fix register counting

2018-11-19 Thread Max Filippov
In order to communicate correctly with gdb xtensa gdbstub must provide expected number of registers in 'g' packet response. xtensa-elf-gdb expects both nonprivileged and privileged registers. xtensa-linux-gdb only expects nonprivileged registers. gdb only counts one contiguous stretch of

Re: [Qemu-devel] [PATCH for-3.2 38/41] net: do not depend on slirp internals

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:21:36 +0100, a ecrit: > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 37/41] slirp: replace ARRAY_SIZE with G_N_ELEMENTS

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:17:56 +0100, a ecrit: > On 14/11/18 13:36, Marc-André Lureau wrote: > > Do not require QEMU macro. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé Daniel P. Berrangé, le mer. 14 nov. 2018 14:15:15 +, a ecrit:

Re: [Qemu-devel] [PATCH for-3.2 36/41] slirp: remove dead TCP_ACK_HACK code

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 14:12:06 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:38PM +0400, Marc-André Lureau wrote: > > Untouched since original introduction in 2004. > > > > Signed-off-by: Marc-André Lureau > > --- > > slirp/tcp_input.c | 23 +-- > > 1

Re: [Qemu-devel] [PATCH for-3.2 35/41] slirp: NULL is defined by glib (at least)

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 14:11:34 +, a ecrit: > NULL is defined in stddef.h for at least 15 years AFAICT, so > even glib shouldn't bother to define it :-) So I'd suggest > changing $subject to just defer to stddef.h > > On Wed, Nov 14, 2018 at 04:36:37PM +0400, Marc-André

Re: [Qemu-devel] [PATCH for-3.2 33/41] slirp: replace qemu_notify_event() with a callback

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:35 +0400, a ecrit: > Use a "slirp socket" helper function to call the callback when > sbdrop() returns true. It's really far from clear what this should be doing :) I'd say find out how to rephrase 86073017e384 ("slirp: Signal free input buffer space

Re: [Qemu-devel] [PATCH for-3.2 32/41] slirp: remove unused sbflush()

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 14:05:33 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:34PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/sbuf.h | 1 - > > 1 file changed, 1 deletion(-) > > Reviewed-by: Daniel P. Berrangé Applied to my tree,

Re: [Qemu-devel] [PATCH for-3.2 34/41] slirp: remove #if notdef dead code

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 14:07:38 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:36PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/ip_input.c | 200 -- > > slirp/tcp_input.c | 39 - >

Re: [Qemu-devel] [PATCH for-3.2 31/41] slirp: add a callback to log guest errors

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:33 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH 07/22] gpio/puv3_gpio: Convert sysbus initfunction to realize function

2018-11-19 Thread maozy
On 11/19/18 10:31 PM, Peter Maydell wrote: On 19 November 2018 at 12:08, Mao Zhongyi wrote: Use DeviceClass rather than SysBusDeviceClass in puv3_gpio_class_init(). Cc: g...@mprc.pku.edu.cn Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju --- hw/gpio/puv3_gpio.c | 28

Re: [Qemu-devel] [PATCH for-3.2 30/41] slirp: replace trace functions with DEBUG calls

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:32 +0400, a ecrit: > Remove a dependency on QEMU. Use the existing logging facilities. I'm hesitating on this one: this is not really a debugging print (as in qemu debugging), but a real user debugging print. We do want to compile this in without

Re: [Qemu-devel] [PATCH for-3.2 29/41] slirp: improve a bit the debug macros

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:31 +0400, a ecrit: > Let them accept multiple arguments. Simplify the inner argument > handling of DEBUG_ARGS/DEBUG_MISC_DEBUG_ERROR. > > Signed-off-by: Marc-André Lureau Applied to my tree, thanks!

[Qemu-devel] [PATCH] usb-host: set ifs.detached as true if kernel driver is not active

2018-11-19 Thread linzhecheng
If no kernel driver is active, we can already claim and perform I/O on it without detaching it. Signed-off-by: linzhecheng diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index f31e9cbbb8..db4ae1e6e8 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1119,6 +1119,10 @@

Re: [Qemu-devel] [PATCH for-3.2 28/41] slirp: replace error_report() with g_critical()

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:30 +0400, a ecrit: > Reduce dependency on QEMU. QEMU could use a custom log handler if it > wants to redirect/filter it. > > Signed-off-by: Marc-André Lureau Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 26/41] slirp: replace compile time DO_KEEPALIVE

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:28 +0400, a ecrit: > Use a global variable instead (similar to slirp_debug) > > Signed-off-by: Marc-André Lureau Applied to my tree, thanks!

Re: [Qemu-devel] [PATCH for-3.2 25/41] slirp: replace SIZEOF_CHAR_P with glib equivalent

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:14:35 +0100, a ecrit: > On 14/11/18 13:36, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé Applied to my tree, thanks!

Re: [Qemu-devel] [qemu-s390x] [PATCH 21/22] event-facility: ChangeSysBusDeviceClass *sbdc to SysBusDeviceClass *sbc

2018-11-19 Thread maozy
On 11/19/18 10:10 PM, Thomas Huth wrote: On 2018-11-19 13:25, Cornelia Huck wrote: On Mon, 19 Nov 2018 20:08:19 +0800 Mao Zhongyi wrote: Most of the SysBusDeviceClass variables are named sbc, and sbdc here is a bit weird, so changing sbdc to keep it consistent with others might look good.

Re: [Qemu-devel] [PATCH for-3.2 27/41] slirp: remove unused global slirp_instance

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:55:18 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:29PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h | 2 -- > > 1 file changed, 2 deletions(-) > > Reviewed-by: Daniel P. Berrangé Applied to my

Re: [Qemu-devel] [PATCH for-3.2 21/41] slirp: remove HAVE_SYS_FILIO_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:52:12 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:23PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 2 +- > > slirp/slirp_config.h | 6 -- > > 2 files changed, 1 insertion(+), 7

Re: [Qemu-devel] [PATCH for-3.2 24/41] slirp: replace HOST_WORDS_BIGENDIAN with glib equivalent

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:14:16 +0100, a ecrit: > On 14/11/18 13:36, Marc-André Lureau wrote: > > One more step towards making the project independent from QEMU. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé Daniel P. Berrangé, le mer.

Re: [Qemu-devel] [PATCH for-3.2 20/41] slirp: remove HAVE_SYS_IOCTL_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:51:29 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:22PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 2 +- > > slirp/slirp_config.h | 6 -- > > 2 files changed, 1 insertion(+), 7

Re: [Qemu-devel] [PATCH for-3.2 23/41] slirp: remove unused HAVE_INET_ATON

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:54:33 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:25PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp_config.h | 6 -- > > 1 file changed, 6 deletions(-) > > Reviewed-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH for-3.2 22/41] slirp: remove unused DECLARE_IOVEC

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:53:31 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:24PM +0400, Marc-André Lureau wrote: > > It's actually qemu configure CONFIG_IOVEC that is being used. > > That makes it sound like slirp is using CONFIG_IOVEC, but AFAICT > that's only used by

Re: [Qemu-devel] [PATCH for-3.2 19/41] slirp: remove unused HAVE_SYS_SELECT_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:51:01 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:21PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/main.h | 4 > > slirp/slirp.h| 4 > > slirp/slirp_config.h | 6 -- > > 3

Re: [Qemu-devel] [PATCH for-3.2 16/41] slirp: remove unused HAVE_SYS_STROPTS_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:49:08 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:18PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 5 - > > slirp/slirp_config.h | 3 --- > > 2 files changed, 8 deletions(-) > >

Re: [Qemu-devel] [PATCH for-3.2 18/41] slirp: remove unused HAVE_SYS_WAIT_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:50:33 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:20PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 4 > > slirp/slirp_config.h | 3 --- > > 2 files changed, 7 deletions(-) > >

Re: [Qemu-devel] [PATCH for-3.2 17/41] slirp: remove unused HAVE_ARPA_INET_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:50:01 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:19PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp_config.h | 6 -- > > 1 file changed, 6 deletions(-) > > Reviewed-by: Daniel P. Berrangé

Re: [Qemu-devel] [PATCH for-3.2 15/41] slirp: remove NO_UNIX_SOCKETS

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:48:37 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:17PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 3 --- > > slirp/slirp_config.h | 6 -- > > 2 files changed, 9 deletions(-) > >

Re: [Qemu-devel] [PATCH for-3.2 14/41] slirp: remove unused HAVE_SYS_BITYPES_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:47:57 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:16PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 4 > > slirp/slirp_config.h | 3 --- > > 2 files changed, 7 deletions(-) > >

Re: [Qemu-devel] [PATCH for-3.2 13/41] slirp: remove HAVE_SYS_SIGNAL_H

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:47:32 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:15PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp.h| 3 --- > > slirp/slirp_config.h | 3 --- > > 2 files changed, 6 deletions(-) > >

[Qemu-devel] [PATCH] slirp: Enable fork_exec support on Windows

2018-11-19 Thread Samuel Thibault
g_spawn_async_with_fds is portable on Windows, so we can now enable fork_exec support there. Thanks Daniel P. Berrangé for the notice! Signed-off-by: Samuel Thibault --- slirp/misc.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 11:50:56AM +0100, Cornelia Huck wrote: > On Thu, 15 Nov 2018 10:05:59 + > Daniel P. Berrangé wrote: > > > On Wed, Nov 14, 2018 at 09:38:31PM -0200, Eduardo Habkost wrote: > > > Many of the current virtio-*-pci device types actually represent > > > 3 different types of

[Qemu-devel] more serial ports on arm?

2018-11-19 Thread Jason A. Donenfeld
Hey guys, I sort of lost track of the discussion, but what ever happened to adding an extra serial port to the arm virt machine? I'm still carrying around the attached patch to run build.wireguard.com and I'd of course like to see a real solution upstream. Jason diff -ru qemu-3.0.0/hw/arm/virt.c

Re: [Qemu-devel] [PATCH 22/22] core/sysbus: remove the SysBusDeviceClass::init path

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 09:31:39PM -0200, Eduardo Habkost wrote: > On Mon, Nov 19, 2018 at 08:08:20PM +0800, Mao Zhongyi wrote: > > Currently, all sysbus devices have been converted to realize(), > > so remove this path. > > > > Cc: ehabk...@redhat.com > > Cc: th...@redhat.com > > Cc:

Re: [Qemu-devel] [PATCH 22/22] core/sysbus: remove the SysBusDeviceClass::init path

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 08:08:20PM +0800, Mao Zhongyi wrote: > Currently, all sysbus devices have been converted to realize(), > so remove this path. > > Cc: ehabk...@redhat.com > Cc: th...@redhat.com > Cc: pbonz...@redhat.com > Cc: arm...@redhat.com > Cc: peter.mayd...@linaro.org > Cc:

[Qemu-devel] [Bug 1798451] Re: MMX emulation is missing on HVF Acceleration

2018-11-19 Thread Roman Bolshakov
** Summary changed: - HVF linux on OSX hangs 2nd time started after adding socket + MMX emulation is missing on HVF Acceleration ** Description changed: - Robs-MacBook-Pro-2:~ robmaskell$ qemu-system-x86_64 --version QEMU emulator version 3.0.0 Host: MacOS - 10.13.6 Model Name:

Re: [Qemu-devel] [PATCH 2/2] numa: Match struct to typedef name

2018-11-19 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 03:17:52PM -0600, Eric Blake wrote: > There's no reason to violate our naming conventions by having a > struct with a different name than its typedef. Messed up since > its introduction in commit 8c85901e, but made more obvious when > commit 3bfe5716 promoted it to

Re: [Qemu-devel] [PATCH for-3.2 03/41] slirp: simplify fork_exec()

2018-11-19 Thread Eric Blake
On 11/19/18 4:59 PM, Samuel Thibault wrote: Mmm, I don't think any portability issue remains. SO_OOBINLINE is used in other places, the rest is portable. There is the setsid() call which may just not make sense on Windows, but we could just disable it there. I have pushed to

Re: [Qemu-devel] [PATCH for-3.2 12/41] slirp: remove the disabled readv()/writev() code path

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:46:46 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:14PM +0400, Marc-André Lureau wrote: > > The soread() function may be used on datagram sockets, and would > > provide different behaviour if HAVE_READV was set, on empty datagrams. > > This looks like

Re: [Qemu-devel] [PATCH for-3.2 11/41] slirp: remove FULL_BOLT

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:46:02 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:13PM +0400, Marc-André Lureau wrote: > > Looking at git history, this looks like something from the past, when > > there was a tty layer. Let's remove it. > > > > Signed-off-by: Marc-André Lureau >

Re: [Qemu-devel] [PATCH for-3.2 10/41] slirp: remove PROBE_CONN dead-code

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:12:04 +0100, a ecrit: > On 14/11/18 13:36, Marc-André Lureau wrote: > > Nobody cares for over 14y. Somebody can revert or rewrite if > > interested by that. > > > > Signed-off-by: Marc-André Lureau > > Reviewed-by: Philippe Mathieu-Daudé Daniel

Re: [Qemu-devel] [PATCH v2] Acceptance tests: add Linux initrd checking test

2018-11-19 Thread Eduardo Habkost
On Thu, Nov 15, 2018 at 12:41:09PM -0200, Wainer dos Santos Moschetta wrote: > Hi Eduardo, > > Since you have already queued this patch for 4.0, I would like to know if I > should send a v3 to address Eric's review. Or if you can edit the patch > yourself given the changes are trivial. I can

Re: [Qemu-devel] [PATCH for-3.2 07/41] slirp: add clock_get_ns() callback

2018-11-19 Thread Samuel Thibault
Paolo Bonzini, le jeu. 15 nov. 2018 13:54:02 +0100, a ecrit: > On 14/11/2018 13:36, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/libslirp.h | 6 ++ > > net/slirp.c | 19 +++ > > slirp/if.c | 2 +- > > slirp/ip6_icmp.c | 6

Re: [Qemu-devel] [PATCH for-3.2 05/41] slirp: use a callback structure to interface with qemu

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:10:15 +0100, a ecrit: > With the const qualifier: > Reviewed-by: Philippe Mathieu-Daudé Stefan Hajnoczi, le mer. 14 nov. 2018 14:30:14 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:07PM +0400, Marc-André Lureau wrote: > > -typedef void

Re: [Qemu-devel] [RFC v1 17/23] riscv: tcg-target: Add direct load and store instructions

2018-11-19 Thread Alistair Francis
On Fri, Nov 16, 2018 at 9:10 AM Richard Henderson wrote: > > On 11/15/18 11:36 PM, Alistair Francis wrote: > > +tcg_out_opc_reg(s, OPC_ADD, base, TCG_GUEST_BASE_REG, addr_regl); > > Should avoid this when guest_base == 0, which happens fairly regularly for a > 64-bit guest. > > > +/*

Re: [Qemu-devel] [RFC v1 20/23] riscv: tcg-target: Add the target init code

2018-11-19 Thread Alistair Francis
On Fri, Nov 16, 2018 at 9:26 AM Richard Henderson wrote: > > On 11/15/18 11:36 PM, Alistair Francis wrote: > > +tcg_regset_set_reg(s->reserved_regs, TCG_REG_L0); > > +tcg_regset_set_reg(s->reserved_regs, TCG_REG_L1); > > +tcg_regset_set_reg(s->reserved_regs, TCG_REG_RA); > > Why are

Re: [Qemu-devel] [PATCH for-3.2 04/41] slirp: remove unused M_TRAILINGSPACE

2018-11-19 Thread Samuel Thibault
Daniel P. Berrangé, le mer. 14 nov. 2018 13:32:57 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:06PM +0400, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/mbuf.h | 1 - > > 1 file changed, 1 deletion(-) > > Reviewed-by: Daniel P. Berrangé Applied to my tree,

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 04:55:13PM -0500, Bandan Das wrote: > baldu...@units.it writes: > > > hello > > > > I'm building qemu from source and happily using it since a bit > > (2.3.0) > > > > Since 3.1.0-rc0 (including latest 3.1.0-rc1) I'm no more able to start > > qemu, getting: > > > >

Re: [Qemu-devel] [PATCH for-3.2 03/41] slirp: simplify fork_exec()

2018-11-19 Thread Samuel Thibault
Hello, Daniel P. Berrangé, le mer. 14 nov. 2018 14:22:34 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:05PM +0400, Marc-André Lureau wrote: > > Use g_spawn_async_with_fds() to setup the child. > > > > GSpawn handles reaping the child, and closing parent file descriptors. > > The g_spawn*

Re: [Qemu-devel] [PATCH for-3.2 03/41] slirp: simplify fork_exec()

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:05 +0400, a ecrit: > Use g_spawn_async_with_fds() to setup the child. > > GSpawn handles reaping the child, and closing parent file descriptors. > > Signed-off-by: Marc-André Lureau Applied to my slirp-2 tree, thanks! Samuel

Re: [Qemu-devel] [PATCH for-3.2 02/41] glib-compat: add g_spawn_async_with_fds() fallback

2018-11-19 Thread Samuel Thibault
Marc-André Lureau, le mer. 14 nov. 2018 16:36:04 +0400, a ecrit: > Signed-off-by: Marc-André Lureau Reviewed-by: Samuel Thibault include/glib-compat.h maintainers, may I keep this in my slirp tree, to be pushed to master when appropriate? Samuel > --- > include/glib-compat.h | 56

Re: [Qemu-devel] [PATCH for-3.2 01/41] slirp: move socket pair creation in helper function

2018-11-19 Thread Samuel Thibault
Hello, Marc-André Lureau, le mer. 14 nov. 2018 16:36:03 +0400, a ecrit: > Originally, the patch was fixing a bunch of issues, but Peter beat me > to it with earlier commit "slirp: fork_exec(): create and connect > child socket before fork()". > > Factor out socket pair creation, to simplify the

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Bandan Das
baldu...@units.it writes: > hello > > I'm building qemu from source and happily using it since a bit > (2.3.0) > > Since 3.1.0-rc0 (including latest 3.1.0-rc1) I'm no more able to start > qemu, getting: > > 8< > install:115> qemu > qemu: error: failed to set MSR 0x10a to 0x0 >

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 01:07:59PM -0500, Michael S. Tsirkin wrote: n > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > On Fri, 16 Nov 2018 01:45:51 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > > > One

[Qemu-devel] [RFC PATCH 1/1] target/ppc: support single stepping with KVM HV

2018-11-19 Thread Fabiano Rosas
The hardware singlestep mechanism in POWER works via a Trace Interrupt (0xd00) that happens after any instruction executes, whenever MSR_SE = 1 (PowerISA Section 6.5.15 - Trace Interrupt). However, with kvm_hv, the Trace Interrupt happens inside the guest and KVM has no visibility of it.

[Qemu-devel] [RFC PATCH 0/1] single step for KVM HV

2018-11-19 Thread Fabiano Rosas
Single stepping via GDB/gdbstub is currently not working with KVM HV. When asking for a single step (stepi), KVM simply ignores the request and execution continues. This has the direct effect of breaking GDB's 'step', 'stepi', 'next', 'nexti' commands. The 'continue' command is also affected

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:42:58 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > > On Mon, 19 Nov 2018 13:07:59 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > And I

Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-19 Thread David Hildenbrand
On 19.11.18 20:51, Markus Armbruster wrote: > Copying Igor and Eduardo for a hostmem.c bug. Search for "core dumped". > > David Hildenbrand writes: > Tests have to be fixed up: - Two BUGs were hardcoded that are fixed now - The string-input-visitor now actually returns a

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Cole Robinson
On 11/19/2018 01:35 PM, Dr. David Alan Gilbert wrote: * baldu...@units.it (baldu...@units.it) wrote: hi thanks for taking the time to reply Dr. David Alan Gilbert writes: I suspect that this might be some problem on my side, as I couldn't find any similar report (apart some old (qemu-2.8.50)

Re: [Qemu-devel] [PATCH v1 6/9] qapi: rewrite string-input-visitor

2018-11-19 Thread Markus Armbruster
Copying Igor and Eduardo for a hostmem.c bug. Search for "core dumped". David Hildenbrand writes: >>> >>> Tests have to be fixed up: >>> - Two BUGs were hardcoded that are fixed now >>> - The string-input-visitor now actually returns a parsed list and not >>> an ordered set. >> >> I'd

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:56:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:42:58 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > > On Mon, 19 Nov 2018 13:07:59 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > And I

Re: [Qemu-devel] [PATCH] Acceptance test: add coverage tests for -smp option

2018-11-19 Thread Eduardo Habkost
On Mon, Nov 19, 2018 at 04:48:00PM -0200, Wainer dos Santos Moschetta wrote: > On 11/12/2018 02:31 PM, Eduardo Habkost wrote: > > On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote: > > > This adds tests for SMP option, by passing -smp with > > > various combinations of

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Cornelia Huck
On Mon, 19 Nov 2018 13:42:58 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > > On Mon, 19 Nov 2018 13:07:59 -0500 > > "Michael S. Tsirkin" wrote: > > > And I strongly believe command line users really really do not want all > > > this mess.

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Dr. David Alan Gilbert
* baldu...@units.it (baldu...@units.it) wrote: > > A colleague has confirmed this on his FX-8320 on Fedora 29 with the > > virt-next repo; so it's nothing that's special about your machine; > > it's 3.1 that really doesn't like the old AMDs. > > ouch! does this mean that I must stop upgrading

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread balducci
> A colleague has confirmed this on his FX-8320 on Fedora 29 with the > virt-next repo; so it's nothing that's special about your machine; > it's 3.1 that really doesn't like the old AMDs. ouch! does this mean that I must stop upgrading qemu or do you think that some development work will be

Re: [Qemu-devel] [PATCH] Acceptance test: add coverage tests for -smp option

2018-11-19 Thread Wainer dos Santos Moschetta
On 11/12/2018 02:31 PM, Eduardo Habkost wrote: On Fri, Nov 09, 2018 at 02:58:00PM -0500, Wainer dos Santos Moschetta wrote: This adds tests for SMP option, by passing -smp with various combinations of cpus, cores, threads, and sockets values it checks that invalid topologies are not accepted

Re: [Qemu-devel] [PATCH] 9p: take write lock on fid path updates

2018-11-19 Thread P J P
+-- On Thu, 15 Nov 2018, Greg Kurz wrote --+ | Recent commit 5b76ef50f62079a fixed a race where v9fs_co_open2() could | possibly overwrite a fid path with v9fs_path_copy() while it is being | accessed by some other thread, ie, use-after-free that can be detected | by ASAN with a custom 9p client.

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 07:32:38PM +0100, Cornelia Huck wrote: > On Mon, 19 Nov 2018 13:07:59 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > > On Fri, 16 Nov 2018 01:45:51 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Thu,

Re: [Qemu-devel] SeaBIOS booting time optimization

2018-11-19 Thread Stefano Garzarella
On Mon, Nov 19, 2018 at 3:15 PM Gerd Hoffmann wrote: > On Mon, Nov 19, 2018 at 01:07:13PM +, Stefan Hajnoczi wrote: > > On Mon, Nov 19, 2018 at 11:42:28AM +0100, Stefano Garzarella wrote: > > > On Mon, Nov 19, 2018 at 9:49 AM Gerd Hoffmann > wrote: > > > > > > > Why at runtime? What is bad

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-19 Thread Dr. David Alan Gilbert
* baldu...@units.it (baldu...@units.it) wrote: > hi > > thanks for taking the time to reply > > Dr. David Alan Gilbert writes: > > > I suspect that this might be some problem on my side, as I couldn't > > > find any similar report (apart some old (qemu-2.8.50) threads, that > > > didn't help) >

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Cornelia Huck
On Mon, 19 Nov 2018 13:07:59 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > > On Fri, 16 Nov 2018 01:45:51 -0200 > > Eduardo Habkost wrote: > > > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > And once

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-19 Thread Michael S. Tsirkin
On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:28 +0100 > Samuel Ortiz wrote: > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > Description Table). RSDT only allow for 32-bit addressses and have thus > > been deprecated. Since

[Qemu-devel] [PATCH v2] target/i386: kvm: add VMX migration blocker

2018-11-19 Thread Paolo Bonzini
Nested VMX does not support live migration yet. Add a blocker until that is worked out. Nested SVM only does not support it, but unfortunately it is enabled by default for -cpu host so we cannot really disable it. Signed-off-by: Paolo Bonzini --- target/i386/kvm.c | 12 1 file

Re: [Qemu-devel] [PATCH] target/i386: kvm: add VMX and SVM migration blockers

2018-11-19 Thread Paolo Bonzini
On 16/11/18 17:56, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Nested VMX and SVM do not support live migration yet. Add a blocker >> until that is worked out. >> >> Signed-off-by: Paolo Bonzini >> --- >> target/i386/kvm.c | 25 + >> 1

Re: [Qemu-devel] [PATCH] migration: savevm: consult migration blockers

2018-11-19 Thread Paolo Bonzini
On 16/11/18 18:12, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> There is really no difference between live migration and savevm, except >> that savevm does not require bdrv_invalidate_cache to be implemented >> by all disks. However, it is unlikely that savevm

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote: > On 19/11/18 16:31, Igor Mammedov wrote: > > I've tried to give suggestions how to restructure series > > on per patch basis. In my opinion it quite possible to split > > series in several smaller ones and it should really help with >

Re: [Qemu-devel] [PULL 00/10] target-arm queue

2018-11-19 Thread Peter Maydell
(2018-11-19 14:31:48 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20181119 > > for you to fetch changes up to a00d7f2048c2a1a6a4487ac195c804c78adcf60e: > > MAINTAINERS: list myself as

Re: [Qemu-devel] [PATCH for-4.0 v2] virtio: Provide version-specific variants of virtio PCI devices

2018-11-19 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 11:41:05AM +0100, Cornelia Huck wrote: > On Fri, 16 Nov 2018 01:45:51 -0200 > Eduardo Habkost wrote: > > > On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote: > > > > One thing that I'm very much not convinced about is the naming, > > > specifically leaving

  1   2   3   >