Hi Peter,
On 2018/11/24 2:45, Peter Maydell wrote:
> On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote:
>>
>> Hi Peter,
>> Thanks for the review and comments.
>>
>>>
>>> On 8 November 2018 at 10:29, Dongjiu Geng wrote:
+bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset)
>>
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1498144
Title:
Failure bo
On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote:
> +static uint64_t get_free_request_bitmap(Threads *threads, ThreadLocal
> *thread)
> +{
> +uint64_t request_fill_bitmap, request_done_bitmap, result_bitmap;
> +
> +request_fill_bitmap = atomic_rcu_read(&thread->reques
On Thu, Nov 22, 2018 at 15:20:25 +0800, guangrong.x...@gmail.com wrote:
> + /*
> + * the bit in these two bitmaps indicates the index of the ＠requests
This @ is not ASCII, is it?
> + * respectively. If it's the same, the corresponding request is free
> + * and owned by the user, i.e
On Thu, Nov 22, 2018 at 17:12:34 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > In preparation for plugin support.
> >
> > Signed-off-by: Emilio G. Cota
>
> More macros for the macro-god. I guess this works but I wonder if it's
> possible to do a clean-up ala softfloat and the expe
On Fri, Nov 23, 2018 at 17:04:28 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > Signed-off-by: Emilio G. Cota
> > ---
> > bsd-user/syscall.c | 9 +
> > linux-user/syscall.c | 3 +++
> > 2 files changed, 12 insertions(+)
> >
> > diff --git a/bsd-user/syscall.c b/bsd-user/s
On Fri, Nov 23, 2018 at 16:52:31 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > Signed-off-by: Emilio G. Cota
>
> This commit message needs more description. What is this plugin mask
> for? Are we extending the TB flags with a mask of loaded plugins so we
> can correctly identify w
On Fri, Nov 23, 2018 at 17:10:53 +, Alex Bennée wrote:
> Emilio G. Cota writes:
(snip)
> > @@ -1322,12 +1323,21 @@ static void qemu_tcg_rr_wait_io_event(CPUState *cpu)
> >
> > static void qemu_wait_io_event(CPUState *cpu)
> > {
> > +bool asleep = false;
> > +
>
> slept?
Changed to slep
On Thu, Nov 22, 2018 at 17:09:22 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > This will be used by plugin code to flush the code cache as well
> > as doing other bookkeeping in a safe work environment.
>
> This seems a little excessive given the plugin code could just call
> tb_fl
On Fri, Nov 23, 2018 at 17:00:59 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > Signed-off-by: Emilio G. Cota
> > ---
> > accel/tcg/translate-all.c | 6 ++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> > index 3
(Plus a qht-bench trivial patch.)
Note that these apply on top of rth's tcg-next-for-4.0.
Thanks,
Emilio
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/exec/tb-hash.h | 2 +-
include/{exec/tb-hash-xx.h => qemu/xxhash.h} | 6 +++---
tests/qht-bench.c| 2 +-
util/qsp.c | 2 +-
4 files changed, 6 in
Before moving them all to include/qemu/xxhash.h.
Reviewed-by: Alex Bennée
Signed-off-by: Emilio G. Cota
---
include/exec/tb-hash-xx.h | 41 +--
include/exec/tb-hash.h| 2 +-
tests/qht-bench.c | 2 +-
util/qsp.c| 12 ++--
Which we forgot to do in bd224fce60 ("qht-bench: add -p flag
to precompute hash values", 2018-09-26).
Signed-off-by: Emilio G. Cota
---
tests/qht-bench.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qht-bench.c b/tests/qht-bench.c
index 2089e2bed1..636750d39f 100644
--- a/tests/qht-
Change the order in which we extract a/b and c/d to
match the output of the upstream xxhash32.
Tested with:
https://github.com/cota/xxhash/tree/qemu
Signed-off-by: Emilio G. Cota
---
include/qemu/xxhash.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/qemu
On Fri, Nov 23, 2018 at 06:53:07PM +, Peter Maydell wrote:
> On Fri, 23 Nov 2018 at 18:24, Eduardo Habkost wrote:
> >
> > On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote:
> > > One thing I would like to do with this new "cpu cluster"
> > > concept is to use it to handle a problem
On Thu, Nov 22, 2018 at 17:15:20 +, Alex Bennée wrote:
>
> Emilio G. Cota writes:
>
> > It will be used for TB hashing soon.
> >
> > Signed-off-by: Emilio G. Cota
> > ---
> > include/qemu/xxhash.h | 40 +++-
> > 1 file changed, 27 insertions(+), 13 delet
Hi Alex,
I'm also terribly sorry for the delay in responding to this. I'm only now
having the time resources to come back to this topic and figure out a way
forward with my proposal. Please see my notes below (quoting only the relevant
sections).
> On Nov 6, 2018, at 9:32 PM, Alex Williamson
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181123144558.5048-1-richard.hender...@linaro.org
Type: series
Subject: [Qemu-devel] [PATCH for-4.0 v2 00/37] tcg: Assorted cleanups
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
31.10.2018 14:35, Anton Nefedov wrote:
> A block driver can provide a callback to report driver-specific
> statistics.
>
> file-posix driver now reports discard statistics
>
> Signed-off-by: Anton Nefedov
> ---
> qapi/block-core.json | 39 +++
> includ
On Fri, 23 Nov 2018 at 14:31, gengdongjiu wrote:
>
> Hi Peter,
> Thanks for the comments and mail.
>
> >
> > On 22 November 2018 at 10:28, Peter Maydell
> > wrote:
> > > On 22 November 2018 at 03:05, gengdongjiu wrote:
> > >>> >
> > >>> Shouldn't there be something in here to say "only report
On Fri, 23 Nov 2018 at 18:24, Eduardo Habkost wrote:
>
> On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote:
> > One thing I would like to do with this new "cpu cluster"
> > concept is to use it to handle a problem we have at the
> > moment with TCG, where we assume all CPUs have the sa
On Wed, 21 Nov 2018 at 14:34, gengdongjiu wrote:
>
> Hi Peter,
> Thanks for the review and comments.
>
> >
> > On 8 November 2018 at 10:29, Dongjiu Geng wrote:
> > > +bool write_part_cpustate_to_list(ARMCPU *cpu, ptrdiff_t fieldoffset)
> >
> > What is this about? Nothing else in QEMU needs to m
31.10.2018 14:35, Anton Nefedov wrote:
> This will help to identify how many of the user-issued discard operations
> (accounted on a device level) have actually suceeded down on the host file
> (even though the numbers will not be exactly the same if non-raw format
> driver is used (e.g. qcow2 send
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote:
> From: Xiao Guangrong
>
> Adapt the compression code to the threaded workqueue
>
> Signed-off-by: Xiao Guangrong
> ---
> migration/ram.c | 308
>
> 1 file changed, 110 insert
On 23/11/18 18:06, Edgar E. Iglesias wrote:
> On Fri, Nov 23, 2018 at 06:02:25PM +0100, Edgar E. Iglesias wrote:
>> On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote:
>>> On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote:
Hi Edgar,
>>>
>>> Hi Philippe,
>>>
On Fri, Nov 23, 2018 at 11:10:40AM +0800, maozy wrote:
> Hi, Eduardo
>
> On 11/20/18 7:31 AM, Eduardo Habkost wrote:
> > On Mon, Nov 19, 2018 at 08:08:20PM +0800, Mao Zhongyi wrote:
> > > Currently, all sysbus devices have been converted to realize(),
> > > so remove this path.
> > >
> > > Cc: eh
On Fri, 23 Nov 2018 at 18:16, Eduardo Habkost wrote:
> I think this is good enough for now (as long as there's a comment
> like Peter suggested). Allowing parent_realize to be NULL would
> be inconvenient to all code that uses parent_realize today.
>
> Personally, I would love to get rid of paren
On Fri, 23 Nov 2018 at 18:11, Eduardo Habkost wrote:
> On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote:
> > This commit adds the cpu-cluster type. It aims at gathering CPUs from
> > the same cluster in a machine.
> >
> > For now it only has a `cluster-id` property.
> >
> > Signed-off-by
On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote:
> On Fri, 23 Nov 2018 at 18:11, Eduardo Habkost wrote:
> > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote:
> > > This commit adds the cpu-cluster type. It aims at gathering CPUs from
> > > the same cluster in a machine.
> >
On 23/11/18 19:17, Dr. David Alan Gilbert wrote:
> * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote:
>> From: Xiao Guangrong
>>
>> Adapt the compression code to the threaded workqueue
>>
>> Signed-off-by: Xiao Guangrong
>> ---
>> migration/ram.c | 308
>> -
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 23/11/18 19:17, Dr. David Alan Gilbert wrote:
> > * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote:
> >> From: Xiao Guangrong
> >>
> >> Adapt the compression code to the threaded workqueue
> >>
> >> Signed-off-by: Xiao Guangrong
> >> --
31.10.2018 14:34, Anton Nefedov wrote:
> Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
but be careful: on git am, the chunk about read-only case goes into
scsi_disk_emulate_write_same instead of scsi_disk_emulate_unmap (at least for
me, with latest master branch and
Hi,
Sorry for not reviewing this series earlier. I just stumbled
upon this part of the code:
On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote:
> This commit adds the cpu-cluster type. It aims at gathering CPUs from
> the same cluster in a machine.
>
> For now it only has a `cluster-id
31.10.2018 14:34, Anton Nefedov wrote:
> Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
On 01/11/18 16:11, Artem Pisarenko wrote:
> This fixes wrong interfacing between virtio serial port and bus
> models, and corresponding chardev backends, caused extra and incorrect
> activity during guest boot process (when virtserialport device used).
>
> Signed-off-by: Artem Pisarenko
> ---
>
31.10.2018 14:34, Anton Nefedov wrote:
> Make the stat fields definition slightly more readable.
> Also reorder total_time_ns stats read-write-flush as done elsewhere.
> Cosmetic change only.
>
> Signed-off-by: Anton Nefedov
Reviewed-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block-core.j
On Fri, Nov 23, 2018 at 06:02:25PM +0100, Edgar E. Iglesias wrote:
> On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote:
> > On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote:
> > > Hi Edgar,
> >
> > Hi Philippe,
> >
> > >
> > > On 23/11/18 14:54, Edgar E. Igl
On Fri, Nov 23, 2018 at 05:59:45PM +0100, Edgar E. Iglesias wrote:
> On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote:
> > Hi Edgar,
>
> Hi Philippe,
>
> >
> > On 23/11/18 14:54, Edgar E. Iglesias wrote:
> > > From: "Edgar E. Iglesias"
> > >
> > > Don't assert on RX descr
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
Reviewed-by: Alex Bennée
> ---
> bsd-user/syscall.c | 3 +++
> linux-user/exit.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
> index 66492aaf5d..b7818af450 100644
> --- a/bsd-user
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
> ---
> cpus.c| 10 ++
> exec.c| 2 ++
> qom/cpu.c | 2 ++
> 3 files changed, 14 insertions(+)
>
> diff --git a/cpus.c b/cpus.c
> index 28e39f045a..3efe89354d 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -43,6 +43,7 @@
> #
On Fri, 23 Nov 2018 at 16:59, Edgar E. Iglesias
wrote:
> Not sure if it's too late to even get the removal of the assert into this
> release? Peter?
If you're happy that removing the assert is the correct fix,
yes, this could go in before rc3 next week.
thanks
-- PMM
On Fri, Nov 23, 2018 at 05:46:17PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Edgar,
Hi Philippe,
>
> On 23/11/18 14:54, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Don't assert on RX descriptor settings when the receiver is
> > disabled. This fixes an issue with incoming pac
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
> ---
> bsd-user/syscall.c | 9 +
> linux-user/syscall.c | 3 +++
> 2 files changed, 12 insertions(+)
>
> diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c
> index b7818af450..4993f81b2b 100644
> --- a/bsd-user/syscall.c
> ++
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
> ---
> accel/tcg/translate-all.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index 3423cf74db..1690e3fd5b 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/t
Hi all!
The series brings threads to qcow2 encryption/decryption path,
like it is already done for compression.
Based-on: Kevin's block-next branch [d3db1496c5]
Performance gain is illustrated by the following test:
]# cat test.sh
#!/bin/bash
size=1G
src=/ssd/src.raw
dst=/ssd/dst.enc.qcow2
e
We'll need per-thread data (crypto blocks) for encryption threads.
Prepare threads infrastructure for it.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 6 ++
block/qcow2-threads.c | 25 ++---
2 files changed, 28 insertions(+), 3 deletions(-)
di
Emilio G. Cota writes:
> XXX: store hostaddr from non-i386 TCG backends
> XXX: what hostaddr to return for I/O accesses?
> XXX: what hostaddr to return for cross-page accesses?
>
> Here the trickiest feature is passing the host address to
> memory callbacks that request it. Perhaps it would be
Encryption will be done in threads, to take benefit of it, we should
move it out of the lock first.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.
Add thread-based encrypt/decrypt. QCrypto don't support parallel
operations with one block, so we need QCryptoBlock for each thread.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 12 +
block/qcow2-threads.c | 62 +++
block
Move compression-on-threads to separate file. Encryption will be in it
too.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 7 ++
block/qcow2-threads.c | 197 ++
block/qcow2.c | 169
bl
qcow2.h depends on block_int.h. Compilation isn't broken currently only
due to block_int.h always included before qcow2.h. Though, it seems
better to directly include block_int.h in qcow2.h.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 1 +
1 file changed, 1 insertion(+)
diff
The state will grow in further commits, so it's good to give it its own
structure.
Make naming generic, as threads will be used for encryption too.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.h | 8 ++--
block/qcow2-threads.c | 11 ++-
block/qcow2.c
Background: decryption will be done in threads, to take benefit of it,
we should move it out of the lock first.
But let's go further: it turns out, that for locking around switch
cases we have only two variants: when we just do memset(0) not
releasing the lock (it is useless) and when we actually
qemu_iovec_memset has @offset parameter, so using hd_qiov for it is not
needed.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 5467089cfe..bbd6df3614 100644
--- a/b
Move generic part out of qcow2_co_do_compress, to reuse it for
encryption and rename things that would be shared with encryption path.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-threads.c | 41 -
1 file changed, 28 insertions(+), 13 deleti
Do encryption/decryption in threads, like it is already done for
compression. This improves asynchronous encrypted io.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.
Use thread_pool_submit_co, instead of reinventing it here. Note, that
thread_pool_submit_aio() never returns an error, so checking it was an
extra thing.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-threads.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
Emilio G. Cota writes:
> Signed-off-by: Emilio G. Cota
This commit message needs more description. What is this plugin mask
for? Are we extending the TB flags with a mask of loaded plugins so we
can correctly identify what code was generated under what plugins?
> ---
> include/exec/exec-all
Hi Edgar,
On 23/11/18 14:54, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Don't assert on RX descriptor settings when the receiver is
> disabled. This fixes an issue with incoming packets on an
> unused GEM.
>
> Reported-by: mbilal
> Signed-off-by: Edgar E. Iglesias
> ---
> hw/ne
On Fri, Nov 23, 2018 at 02:20:17PM +0100, Edgar E. Iglesias wrote:
> On Fri, Nov 23, 2018 at 02:59:32PM +0500, mbilal wrote:
> > Hi,
> >
> > Thanks for reply.
> >
> > According to your suggestion I've tested with 3.1 rc2 release and problem is
> > still exist in this release also.
> >
> > Here i
Hi Mao,
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> pci_dec_21154_device_class_init().
>
> Cc: da...@gibson.dropbear.id.au
> Cc: m...@redhat.com
> Cc: marcel.apfelb...@gmail.com
> Cc: qemu-...@nongnu.org
>
> Signed-off-by: Mao Zhongyi
> Signed-off-
On Fri, Nov 23, 2018 at 11:30:35PM +0800, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> etraxfs_timer_class_init().
>
> Cc: edgar.igles...@gmail.com
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Edgar E. Iglesias
> ---
> hw/timer/etra
On 23/11/18 10:01, Roman Kagan wrote:
> elf2dmp is keyed on "$posix" = "yes", but "$posix" doesn't seem to be
> set anywhere.
>
> The original intent was presumably to skip building it on Windows, so
> check for "$mingw32" = "no" instead.
>
> Signed-off-by: Roman Kagan
> ---
> configure | 2 +-
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> puv3_ost_class_init().
>
> Cc: g...@mprc.pku.edu.cn
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/timer/puv3_ost.c | 13 ++---
>
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> etraxfs_timer_class_init().
>
> Cc: edgar.igles...@gmail.com
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/timer/etraxfs_timer.c | 14 +++
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> onenand_class_init().
>
> Cc: kw...@redhat.com
> Cc: mre...@redhat.com
> Cc: qemu-bl...@nongnu.org
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> --
On Fri, Nov 23, 2018 at 4:54 PM Kevin O'Connor wrote:
>
> On Fri, Nov 23, 2018 at 12:18:13PM +0100, Stefano Garzarella wrote:
> > On Fri, Nov 23, 2018 at 7:21 AM Gerd Hoffmann wrote:
> > > On Thu, Nov 22, 2018 at 04:13:38PM +0100, Stefano Garzarella wrote:
> > > > On Thu, Nov 22, 2018 at 12:51 PM
> -Original Message-
> From: Qemu-devel [mailto:qemu-devel-
> bounces+shameerali.kolothum.thodi=huawei@nongnu.org] On Behalf Of
> Eric Auger
> Sent: 21 September 2018 09:18
> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu-
> de...@nongnu.org; qemu-...@nongnu.org; peter.may
On Thu, Nov 22, 2018 at 11:29:32AM +0100, Igor Mammedov wrote:
> * arm/virt is broken but it looks like linux doesn't care, lets fix it
> anyways
> * x86, got lucky since we didn't use extended fields,
>fix it so that it will calculate checksum using correct length
>so that it would be e
On Thu, Nov 22, 2018 at 11:29:33AM +0100, Igor Mammedov wrote:
> AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp)
> for checksum calculation isn't correct since we are adding extra 16 bytes.
> But acpi_data_push() zeroes out table, so just by luck we are summing up
> exta z
31.10.2018 14:34, Anton Nefedov wrote:
> This adds some protection from accounting unitialized cookie.
uninitialized
> That is, block_acct_failed/done without previous block_acct_start;
> in that case, cookie probably holds values from previous operation.
>
> (Note: it might also be unitialized
On Thu, Nov 22, 2018 at 01:35:05PM +, Peter Maydell wrote:
> The API of cpu_physical_memory_write_rom() is odd, because it
> takes an AddressSpace, unlike all the other cpu_physical_memory_*
> access functions. We note this oddity as a TODO in the
> docs/devel/loads-stores.rst documentation.
>
On Fri, Nov 23, 2018 at 12:18:13PM +0100, Stefano Garzarella wrote:
> On Fri, Nov 23, 2018 at 7:21 AM Gerd Hoffmann wrote:
> > On Thu, Nov 22, 2018 at 04:13:38PM +0100, Stefano Garzarella wrote:
> > > On Thu, Nov 22, 2018 at 12:51 PM Gerd Hoffmann wrote:
> > > > On Thu, Nov 22, 2018 at 12:08:55PM
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> grlib_gptimer_class_init().
>
> Cc: chout...@adacore.com
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/timer/grlib_gptimer.c | 11 +--
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> g364fb_sysbus_class_init().
>
> Cc: pbonz...@redhat.com
> Cc: kra...@redhat.com
> Cc: f4...@amsat.org
> Cc: alistair.fran...@wdc.com
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
> Reviewe
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> milkymist_pfpu_class_init().
>
> Cc: mich...@walle.cc
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/misc/milkymist-pfpu.c | 12 +-
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> milkymist_softusb_class_init().
>
> Cc: mich...@walle.cc
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/input/milkymist-softusb.c | 16 +++
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> pl050_class_init().
>
> Cc: peter.mayd...@linaro.org
> Cc: qemu-...@nongnu.org
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/input/pl050.
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> puv3_gpio_class_init().
>
> Cc: g...@mprc.pku.edu.cn
> Cc: peter.mayd...@linaro.org
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/gpio/pu
Currently, all sysbus devices have been converted to realize(),
so remove this path.
Cc: ehabk...@redhat.com
Cc: th...@redhat.com
Cc: pbonz...@redhat.com
Cc: arm...@redhat.com
Cc: peter.mayd...@linaro.org
Cc: richard.hender...@linaro.org
Cc: alistair.fran...@wdc.com
Signed-off-by: Mao Zhongyi
Si
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> puv3_intc_class_init().
>
> Cc: g...@mprc.pku.edu.cn
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/intc/puv3_intc.c | 11 ---
> 1
Use DeviceClass rather than SysBusDeviceClass in
puv3_ost_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/puv3_ost.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/timer/puv3_ost.c b/hw/timer/puv3
The init function doesn't do anything at all, so we
just omit it.
Cc: sstabell...@kernel.org
Cc: anthony.per...@citrix.com
Cc: xen-de...@lists.xenproject.org
Cc: peter.mayd...@linaro.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/xen/xen_backend.c | 7 ---
1 file change
Use DeviceClass rather than SysBusDeviceClass in
pci_dec_21154_device_class_init().
Cc: da...@gibson.dropbear.id.au
Cc: m...@redhat.com
Cc: marcel.apfelb...@gmail.com
Cc: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: David Gibson
Acked-by: David Gibso
On 23/11/18 16:30, Mao Zhongyi wrote:
> Use DeviceClass rather than SysBusDeviceClass in
> grlib_apbuart_class_init().
>
> Cc: chout...@adacore.com
> Cc: marcandre.lur...@redhat.com
> Cc: pbonz...@redhat.com
>
> Signed-off-by: Mao Zhongyi
> Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Ma
Use DeviceClass rather than SysBusDeviceClass in
etraxfs_timer_class_init().
Cc: edgar.igles...@gmail.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/etraxfs_timer.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/timer/etraxfs_tim
Use DeviceClass rather than SysBusDeviceClass in
onenand_class_init().
Cc: kw...@redhat.com
Cc: mre...@redhat.com
Cc: qemu-bl...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/block/onenand.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
dif
Use DeviceClass rather than SysBusDeviceClass in
puv3_intc_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/intc/puv3_intc.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/intc/puv3_intc.c b/hw/intc/puv3_i
Use DeviceClass rather than SysBusDeviceClass in
g364fb_sysbus_class_init().
Cc: pbonz...@redhat.com
Cc: kra...@redhat.com
Cc: f4...@amsat.org
Cc: alistair.fran...@wdc.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Alistair Francis
---
hw/display/g364fb.c | 9 +++
The SysBusDeviceClass::init() interface is considered
as a legacy interface and there are currently some
efforts going on to get rid of it. Thus convert
SysBusDeviceClass::init to DeviceClass::realize.
v2 -> v1:
- SYS_BUS_DEVICE(dev) was used in a function several
times, so use a variable 'sbd
Use DeviceClass rather than SysBusDeviceClass in
puv3_pm_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/misc/puv3_pm.c | 10 --
1 file changed, 4 insertions(+), 6 del
Use DeviceClass rather than SysBusDeviceClass in
nvram_sysbus_class_init().
Cc: pbonz...@redhat.com
Cc: marcandre.lur...@redhat.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
---
hw/nvram/ds1225y.c | 12 +---
1 file changed, 5 insertion
Use DeviceClass rather than SysBusDeviceClass in
grlib_gptimer_class_init().
Cc: chout...@adacore.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/grlib_gptimer.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/timer/grlib_gptimer.c b/
Use DeviceClass rather than SysBusDeviceClass in
milkymist_hpdmc_class_init().
Cc: g...@mprc.pku.edu.cn
Cc: mich...@walle.cc
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
---
hw/misc/milkymist-hpdmc.c | 9 +++--
1 file changed, 3 insertions(+)
Use DeviceClass rather than SysBusDeviceClass in
tusb6010_class_init().
Cc: kra...@redhat.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/usb/tusb6010.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
index a2
Use DeviceClass rather than SysBusDeviceClass in
milkymist_pfpu_class_init().
Cc: mich...@walle.cc
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/misc/milkymist-pfpu.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/misc/milkymist-pfpu.c b/hw
Use DeviceClass rather than SysBusDeviceClass in
puv3_dma_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/dma/puv3_dma.c | 10 --
1 file changed, 4 insertions(+), 6 de
Use DeviceClass rather than SysBusDeviceClass in
mv88w8618_wlan_class_init().
Cc: jan.kis...@web.de
Cc: peter.mayd...@linaro.org
Cc: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Philippe Mathieu-Daudé
---
hw/arm/musicpal.c | 9 -
1 file chan
Use DeviceClass rather than SysBusDeviceClass in
empty_slot_class_init().
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/core/empty_slot.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
1 - 100 of 215 matches
Mail list logo
