Hi,
> Right. The main issue is that we need to make sure only
> in-tree devices are supported.
Well, that is under debate right now, see:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04912.html
> vhost-user by design
> is for out of tree users. It needn't be hard,
> maybe it's enou
On 12/11/18 4:10 AM, Joel Stanley wrote:
> This register does not exist in hardware. It is here to allow the guest
> code to cause Qemu to exit when required.
>
> The register address chosen is unused in the emulated machines
> datasheets.
yes. I checked also.
On the AST2600, 0x1A0 is now in th
On 12/11/18 4:10 AM, Joel Stanley wrote:
> This adds a node to the guest's device tree that allows it to cause Qemu
> to exit when the guest shuts down.
Do you think we could find a way to add the same node under U-Boot for
tests using flash images ? or could we just add the node in DT ? Would
th
I figure Kevin knows, but you typoed his e-mail address. I fixed it for
you.
Anton Kuchin writes:
> Hello,
>
> I'm trying to switch from -drive parameter to -blockdev + -device and
> having problems. Looks like with this option I have no way to set the
> name of created BlockBackend, but some
usb packets with no payload (zero length) seem to happen in practice for
whatever reason. Add a check and skip the packet then, otherwise we'll
trigger an assert.
Reported-by: Leonardo Soares Müller
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-audio.c | 3 +++
1 file changed, 3 insertions(+)
d
The libfdt installed in the system is preferred to the dtc submodule by
default. The recent libfdt update added a new symbol - fdt_check_full -
and this breaks compile if there is an older libfdt installed in
the system.
This changes the test to force ./configure into using newer libfdt.
Signed-o
The FDT blob which the spapr machine renders at reset time produces
warnings like this:
my-181211-154309.dts: Warning (unit_address_format): Node
/memory@8000 unit name should not have leading 0s
my-181211-154309.dts: Warning (unit_address_format): Node
/memory@4000 unit
Here is my FDT queue for sPAPR.
This is based on sha1
41bcd77 Cédric Le Goater "spapr: Add a pseries-4.0 machine type".
Please comment. Thanks.
Alexey Kardashevskiy (3):
configure/fdt: Use more strict test for libfdt version
ppc/spapr: Receive and store device tree blob from SLOF
spapr:
SLOF receives a device tree and updates it with various properties
before switching to the guest kernel and QEMU is not aware of any changes
made by SLOF. Since there is no real RTAS (QEMU implements it), it makes
sense to pass the SLOF final device tree to QEMU to let it implement
RTAS related tas
[Expired for QEMU because there has been no activity for 60 days.]
** Changed in: qemu
Status: Incomplete => Expired
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1368204
Title:
WinME isn't
On Tue, Dec 11, 2018 at 03:51:09AM +, xuyandong wrote:
> > On Tue, Dec 11, 2018 at 02:55:43AM +, xuyandong wrote:
> > > On Tue, Dec 11, 2018 at 01:47:37AM +, xuyandong wrote:
> > > > > On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > > > > > > Hi all,
> > > > > > > > >
On Tue, Dec 11, 2018 at 03:51:09AM +, xuyandong wrote:
> > There could we a way to work around this.
> > Does below help?
>
> I am sorry to tell you, I tested this patch and it doesn't work fine.
What happens?
> >
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index
> > 236a20
On 10/12/2018 20:30, Greg Kurz wrote:
> On Mon, 10 Dec 2018 17:20:43 +1100
> David Gibson wrote:
>
>> On Mon, Nov 12, 2018 at 03:12:26PM +1100, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 12/11/2018 05:10, Greg Kurz wrote:
Hi Alexey,
Just a few remarks. See below.
On
On 10/12/2018 17:20, David Gibson wrote:
> On Mon, Nov 12, 2018 at 03:12:26PM +1100, Alexey Kardashevskiy wrote:
>>
>>
>> On 12/11/2018 05:10, Greg Kurz wrote:
>>> Hi Alexey,
>>>
>>> Just a few remarks. See below.
>>>
>>> On Thu, 8 Nov 2018 12:44:06 +1100
>>> Alexey Kardashevskiy wrote:
>>>
>>
> On Tue, Dec 11, 2018 at 02:55:43AM +, xuyandong wrote:
> > On Tue, Dec 11, 2018 at 01:47:37AM +, xuyandong wrote:
> > > > On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > In our test, we conf
On Fri, 19 May 2017 at 16:10, Jay Zhou wrote:
>
> Hi Paolo and Wanpeng,
>
> On 2017/5/17 16:38, Wanpeng Li wrote:
> > 2017-05-17 15:43 GMT+08:00 Paolo Bonzini :
> >>> Recently, I have tested the performance before migration and after
> >>> migration failure
> >>> using spec cpu2006 https://www.sp
On Tue, Dec 11, 2018 at 02:55:43AM +, xuyandong wrote:
> On Tue, Dec 11, 2018 at 01:47:37AM +, xuyandong wrote:
> > > On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > > > > Hi all,
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > In our test, we configured VM with s
This register does not exist in hardware. It is here to allow the guest
code to cause Qemu to exit when required.
The register address chosen is unused in the emulated machines
datasheets.
Signed-off-by: Joel Stanley
---
hw/misc/aspeed_scu.c | 5 +
1 file changed, 5 insertions(+)
diff --gi
This adds a node to the guest's device tree that allows it to cause Qemu
to exit when the guest shuts down.
Signed-off-by: Joel Stanley
---
hw/arm/aspeed.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 515898548284.
This series adds a feature to the ASPEED machine that allows the guest
to cause itself to exit. It was tested with romulus-bmc and palmetto-bmc
with a Linux kernel as the guest.
To test:
cd linux
$ export ARCH=arm CROSS_COMPILE=arm-linux-gnueabi-
$ make aspeed_g4_defconfig
$ ./scripts/config
On Tue, 11 Dec 2018, David Gibson wrote:
On Mon, Dec 10, 2018 at 09:54:51PM +0100, BALATON Zoltan wrote:
Yes, I don't really know what these tests use but I think "lame" test is
mostly floating point but tried with "lame_vmx" which should at least use
some vector ops and "mplayer -benchmark" tes
On Tue, Dec 11, 2018 at 01:47:37AM +, xuyandong wrote:
> > On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > > > Hi all,
> > > > > >
> > > > > >
> > > > > >
> > > > > > In our test, we configured VM with several pci-bridges and a
> > > > > > virtio-net nic been attached with bu
On 14/11/2018 02:56, Paolo Bonzini wrote:
> On 13/11/2018 15:51, Dr. David Alan Gilbert wrote:
>> * Alexey Kardashevskiy (a...@ozlabs.ru) wrote:
>>> This adds a "KVM" marker to the "into mtree -f" to tell the user if
>>> a particular memory section is registered as a KVM memory slot; useful
>>>
On Sun, Dec 09, 2018 at 08:46:05PM +0100, Cédric Le Goater wrote:
> Currently, the interrupt presenter of the vCPU is set at realize
> time. Setting it at reset will become useful when the new machine
> supporting both interrupt modes is introduced. In this machine, the
> interrupt mode is chosen a
On Tue, Dec 11, 2018 at 01:47:37AM +, xuyandong wrote:
> On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > > Hi all,
> > > > >
> > > > >
> > > > >
> > > > > In our test, we configured VM with several pci-bridges and a
> > > > > virtio-net nic been attached with bus 4,
> > > > >
On Sun, Dec 09, 2018 at 08:46:06PM +0100, Cédric Le Goater wrote:
> Depending on the interrupt mode chosen, enable or disable the XIVE
> MMIOs.
>
> Signed-off-by: Cédric Le Goater
> ---
> include/hw/ppc/spapr_xive.h | 1 +
> hw/intc/spapr_xive.c| 9 +
> hw/ppc/spapr_irq.c
On Mon, Dec 10, 2018 at 11:17:33PM +0100, Cédric Le Goater wrote:
> On 12/9/18 8:46 PM, Cédric Le Goater wrote:
> > This pseries machine makes use of a new sPAPR IRQ backend supporting
> > the XIVE interrupt mode.
> >
> > The guest OS is required to have support for the XIVE exploitation
> > mode
On Sun, Dec 09, 2018 at 08:46:07PM +0100, Cédric Le Goater wrote:
> The interrupt mode is chosen by the CAS negotiation process and
> activated after a reset to take into account the required changes in
> the machine. These impact the device tree layout, the interrupt
> presenter object and the exp
On Sat, Dec 08, 2018 at 11:58:59AM +, xuyandong wrote:
> > > > Hi all,
> > > >
> > > >
> > > >
> > > > In our test, we configured VM with several pci-bridges and a
> > > > virtio-net nic been attached with bus 4,
> > > >
> > > > After VM is startup, We ping this nic from host to judge if it is
On Mon, Dec 10, 2018 at 08:15:40AM +0100, Cédric Le Goater wrote:
> On 12/10/18 5:27 AM, David Gibson wrote:
> > On Sun, Dec 09, 2018 at 08:45:54PM +0100, Cédric Le Goater wrote:
> >> The last sub-engine of the XIVE architecture is the Interrupt
> >> Virtualization Presentation Engine (IVPE). On HW
On Mon, Dec 10, 2018 at 10:52:18AM -0200, Fabiano Rosas wrote:
> David Gibson writes:
>
> >> >> +if (arch_info->address == trace_handler_addr) {
> >> >> +cpu_synchronize_state(cs);
> >> >> +kvm_remove_breakpoint(cs, trace_handler_addr, 4,
> >> >> GDB_BREAKPOINT_SW);
> >> >> +
On Mon, Dec 10, 2018 at 09:54:51PM +0100, BALATON Zoltan wrote:
> On Mon, 10 Dec 2018, David Gibson wrote:
> > On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote:
> > > On Fri, 7 Dec 2018, Mark Cave-Ayland wrote:
> > > > This patchset is an attempt at trying to improve the VMX (Altivec)
we should perform these actions as same as usb_host_close.
Signed-off-by: linzhecheng
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index b6602ded4e..833250a886 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -988,7 +988,9 @@ static void usb_host_exit_notifier(struct N
On Mon, Dec 10, 2018 at 08:53:17AM +0100, Cédric Le Goater wrote:
> On 12/10/18 7:39 AM, David Gibson wrote:
> > On Sun, Dec 09, 2018 at 08:46:00PM +0100, Cédric Le Goater wrote:
> >> The XIVE interface for the guest is described in the device tree under
> >> the "interrupt-controller" node. A coup
On Fri, Dec 07, 2018 at 15:59:11 +, Peter Maydell wrote:
> We use cpu_stop_current() to ensure the current CPU has stopped
> from places like qemu_system_reset_request(). Unfortunately its
> current implementation has a race. It calls qemu_cpu_stop(),
> which sets cpu->stopped to true even thou
On Mon, Dec 10, 2018 at 12:25:26PM -0600, Richard Henderson wrote:
> On 12/9/18 11:17 PM, David Gibson wrote:
> > On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote:
> >> These helpers allow us to move FP register values to/from the specified
> >> TCGv_i64
> >> argument.
> >>
> >> To
On Mon, Dec 10, 2018 at 7:28 AM Alex Bennée wrote:
>
> Signed-off-by: Alex Bennée
> ---
> tests/tcg/xtensa/Makefile| 93
> tests/tcg/xtensa/Makefile.softmmu-target | 43 +++
> 2 files changed, 43 insertions(+), 93 deletions(-)
> delete mode 10064
On Mon, Dec 10, 2018 at 10:36:29PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 10, 2018 at 6:30 PM Gerd Hoffmann wrote:
> >
> > On Mon, Nov 26, 2018 at 04:42:40PM +0400, Marc-André Lureau wrote:
> > > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> > > review, let's d
On Mon, Dec 10, 2018 at 12:22:37PM -0800, si-wei liu wrote:
>
>
> On 12/10/2018 9:41 AM, Michael S. Tsirkin wrote:
> > On Mon, Dec 10, 2018 at 11:15:47AM -0500, Venu Busireddy wrote:
> > > Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY.
> > > The first is emitted when the
On Mon, 10 Dec 2018, Richard Henderson wrote:
On 12/10/18 2:54 PM, BALATON Zoltan wrote:
Tried it on i5 650 which has: sse sse2 ssse3 sse4_1 sse4_2. I assume x86_64
should be supported but not sure what are the CPU requirements.
Not quite. I only support avx1 and later.
I thought about suppo
On 11/30/18 4:03 PM, Eric Blake wrote:
Our open-coding of strtol handling forgot to handle overflow
conditions. What's more, since we insiste on a user-supplied
partition to be non-zero, we can use 0 rather than -1 for our
initial value to distinguish when a partition is not being
served, for sli
On 12/9/18 8:46 PM, Cédric Le Goater wrote:
> This pseries machine makes use of a new sPAPR IRQ backend supporting
> the XIVE interrupt mode.
>
> The guest OS is required to have support for the XIVE exploitation
> mode of the POWER9 interrupt controller.
>
> Signed-off-by: Cédric Le Goater
> --
On Mon, 10 Dec 2018 at 21:32, Wedson Almeida Filho wrote:
>
> Hi Peter,
>
> We put this together months ago and hadn't kept up to date with the changes
> here.
>
> We're happy to see that support has been added for the VI bit. Is it going to
> be available in the v3.1.0 release?
Yes, that commi
On 12/5/18 9:03 AM, Vladimir Sementsov-Ogievskiy wrote:
01.12.2018 1:03, Eric Blake wrote:
Consolidate on using decimal (not hex) and on outputting the
option reply name (not just value) when the client reports
protocol discrepancies from the server. While it won't affect
normal operation, it m
On 12/7/18 10:41 AM, Alex Williamson wrote:
Create properties to be able to define speeds and widths for PCIe
links. The only tricky bit here is that our get and set callbacks
translate from the fixed QAPI automagic enums to those we define
in PCI code to represent the actual register segment va
On Mon, Dec 03, 2018 at 10:08:35 -0600, Richard Henderson wrote:
> This tidies guest_base handling such that (1) we require no scratch
> registers, (2) we require no extra instructions besides the memory op,
> and (3) we reduce the size of the memory op by omitting a prefix.
>
> In principal point
Hi Peter,
We put this together months ago and hadn't kept up to date with the changes
here.
We're happy to see that support has been added for the VI bit. Is it going
to be available in the v3.1.0 release?
Thanks,
-Wedson
On Mon, Dec 10, 2018 at 8:41 PM Peter Maydell
wrote:
> On Mon, 10 Dec 2
On Mon, 10 Dec 2018 19:28:10 +0100
Paolo Bonzini wrote:
> It is not used outside hw/vfio/common.c, so it does not need to
> be extern.
>
> Cc: Alex Williamson
> Signed-off-by: Paolo Bonzini
> ---
> hw/vfio/common.c | 2 +-
> include/hw/vfio/vfio-common.h | 1 -
> 2 files changed,
On 12/10/18 11:31 AM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
The 'journal' is a shared block of RAM between QEMU and it's
s/it's/its/ (here, you want possessive)
fuse daemon. It's typically a shmfs file and it's specified as:
whereas here, both uses of "it's"
On 12/10/18 11:31 AM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
Add a cache BAR into which files will be directly mapped.
The size cacn be set with the cache-size= property, e.g.
s/cacn/can/
-device vhost-user-fs-pci,chardev=char0,tag=myfs,cache-size=16G
Signed
On 12/10/18 2:54 PM, BALATON Zoltan wrote:
>> What was your host machine. IIUC this change will only improve
>> performance if the host tcg backend is able to implement TCG vector
>> ops in terms of vector ops on the host.
>
> Tried it on i5 650 which has: sse sse2 ssse3 sse4_1 sse4_2. I assume x
On 12/10/18 11:31 AM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG'
and the data structure 'virtio_pci_shm_cap' to go with it.
They allow defining shared memory regions with sizes and offsets
of 2^32 and more.
Hi again,
On 12/7/18 4:59 PM, Peter Maydell wrote:
> We use cpu_stop_current() to ensure the current CPU has stopped
> from places like qemu_system_reset_request(). Unfortunately its
> current implementation has a race. It calls qemu_cpu_stop(),
> which sets cpu->stopped to true even though the CP
On Mon, 10 Dec 2018, David Gibson wrote:
On Mon, Dec 10, 2018 at 01:33:53AM +0100, BALATON Zoltan wrote:
On Fri, 7 Dec 2018, Mark Cave-Ayland wrote:
This patchset is an attempt at trying to improve the VMX (Altivec) instruction
performance by making use of the new TCG vector operations where po
On Mon, Dec 10, 2018 at 15:47:15 -0200, Eduardo Habkost wrote:
> On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote:
> > On Fri, Dec 07, 2018 at 18:41:07 -0200, Eduardo Habkost wrote:
> > > I've noticed QEMU Travis builds are failing recently, and they
> > > seem to happen only on the -
On Mon, 10 Dec 2018 at 18:38, Andrew Walbran wrote:
>
> From: Wedson Almeida Filho
>
> This lets hypervisors running at EL2 inject virtual interrupts into guest VMs.
>
> Signed-off-by: Wedson Almeida Filho
> Signed-off-by: Andrew Walbran
Hi; thanks for this patch. I'm a bit confused -- can you
Patchew URL:
https://patchew.org/QEMU/20181210173151.16629-1-dgilb...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
On 12/10/2018 9:31 AM, Michael S. Tsirkin wrote:
On Mon, Dec 10, 2018 at 11:15:48AM -0500, Venu Busireddy wrote:
From: Si-Wei Liu
When a VF is hotplugged into the guest, datapath switching will be
performed immediately, which is sub-optimal in terms of timing, and
could end up with substant
On 12/10/2018 9:41 AM, Michael S. Tsirkin wrote:
On Mon, Dec 10, 2018 at 11:15:47AM -0500, Venu Busireddy wrote:
Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY.
The first is emitted when the guest negotiates the F_STANDBY feature
bit. The second is emitted when the vi
On 12/10/18 12:50 PM, Vladimir Sementsov-Ogievskiy wrote:
10.12.2018 21:09, Andrey Shinkevich wrote:
In the 'Format specific information' section of the 'qemu-img info'
command output, the supplemental information about existing QCOW2
bitmaps will be shown, such as a bitmap name, flags and granu
On 12/10/18 1:26 PM, Philippe Mathieu-Daudé wrote:
> Hi Fabrice,
>
> On Fri, Dec 7, 2018 at 5:06 PM wrote:
>>
>> As "xchg" reads and writes both operands, the "+m" is required to avoid
>> undefined behavior on -O2 compilation.
>>
>> Signed-off-by: Fabrice Desclaux
Reviewed-by: Richard Henderson
On 12/10/18 10:15 AM, Venu Busireddy wrote:
Added two new events, FAILOVER_PLUG_PRIMARY and FAILOVER_UNPLUG_PRIMARY.
The first is emitted when the guest negotiates the F_STANDBY feature
bit. The second is emitted when the virtio_net driver is removed, either
manually or as a result of guest reboo
Hi Fabrice,
On Fri, Dec 7, 2018 at 5:06 PM wrote:
>
> As "xchg" reads and writes both operands, the "+m" is required to avoid
> undefined behavior on -O2 compilation.
>
> Signed-off-by: Fabrice Desclaux
> ---
> tests/tcg/i386/test-i386.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> +static inline void get_vsr(TCGv_i64 dst, int n)
> +{
> +tcg_gen_ld_i64(dst, cpu_env, offsetof(CPUPPCState, vsr[n]));
> +}
> +
> +static inline void set_vsr(int n, TCGv_i64 src)
> +{
> +tcg_gen_st_i64(src, cpu_env, offsetof(CPUPPCState, vsr[n]))
If the maximum number of devices allowed on a bus is 1 and a device
which is plugged into the bus is subsequently unplugged, attempting to replug
the device fails with error "Bus 'xxx' does not support hotplugging".
The "error" is detected in the qbus_is_full(BusState *bus) function
(qdev_monitor.c
Hello,
I'm trying to switch from -drive parameter to -blockdev + -device and
having problems. Looks like with this option I have no way to set the
name of created BlockBackend, but some QMP and HMP commands are trying
to find blk with blk_by_name() and fail to locate my device (e.g.
hmp_comm
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland
> ---
> target/ppc/helper.h | 8
> target/ppc/int_helper.c | 7 ---
> target/ppc/translate/vmx-impl.inc.c | 16
> 3 files changed, 8 insertions(+), 23 deletion
On Mon, Dec 10, 2018 at 03:34:27PM -0200, Eduardo Habkost wrote:
> On Mon, Dec 10, 2018 at 12:07:20PM -0500, Emilio G. Cota wrote:
> > On Mon, Dec 10, 2018 at 14:36:01 -0200, Eduardo Habkost wrote:
> > > On Sun, Dec 09, 2018 at 05:27:38PM -0500, Emilio G. Cota wrote:
> > > > Can you try re-running
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland
> ---
> target/ppc/translate.c | 1 +
> target/ppc/translate/vmx-impl.inc.c | 64
> ++---
> 2 files changed, 40 insertions(+), 25 deletions(-)
Reviewed-by: Richard Henders
On Thu, Dec 06, 2018 at 11:14:23AM +0100, remy.n...@blade-group.com wrote:
> +if (is_new) {
> +new_node->pfd.fd = fd;
> +} else {
> +deleted = aio_remove_fd_handler(ctx, node);
> +new_node->pfd = node->pfd;
Does this drop revents? Imagine revent
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> Instead of accessing the FPR, VMX and VSX registers through static arrays of
> TCGv_i64 globals, remove them and change the helpers to load/store data
> directly
> within cpu_env.
>
> Signed-off-by: Mark Cave-Ayland
> ---
> target/ppc/translate.c |
10.12.2018 21:09, Andrey Shinkevich wrote:
> In the 'Format specific information' section of the 'qemu-img info'
> command output, the supplemental information about existing QCOW2
> bitmaps will be shown, such as a bitmap name, flags and granularity:
>
[...]
> --- a/block/qcow2.c
> +++ b/block/
Hi
On Thu, Dec 6, 2018 at 8:25 PM Markus Armbruster wrote:
>
> Marc-André Lureau writes:
>
> > Making a discriminator conditonal doesn't make much sense.
>
> Good point (so easy to overlook!), but why first add the 'if' feature
> broken that way in PATCH 16, then fix it up in PATCH 18?
Not sure
On Mon, Dec 10, 2018 at 2:11 PM Markus Armbruster wrote:
>
> Markus Armbruster writes:
>
> > Marc-André Lureau writes:
> >
> >> Hi
> >> On Thu, Dec 6, 2018 at 9:42 PM Markus Armbruster wrote:
> >>>
> >>> Marc-André Lureau writes:
> >>>
> >>> > Wrap generated enum/struct members and code with #
On Mon, 10 Dec 2018 at 18:31, Peter Maydell wrote:
>
> On Mon, 10 Dec 2018 at 17:57, Peter Maydell wrote:
> >
> > Switch the microblaze target from the old unassigned_access hook
> > to the transaction_failed hook.
> >
> > The notable difference is that rather than it being called
> > for all phy
Hi
On Mon, Dec 10, 2018 at 6:30 PM Gerd Hoffmann wrote:
>
> On Mon, Nov 26, 2018 at 04:42:40PM +0400, Marc-André Lureau wrote:
> > As discussed during "[PATCH v4 00/29] vhost-user for input & GPU"
> > review, let's define a common set of backend conventions to help with
> > management layer imple
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> +avr = tcg_temp_new_i64();
> \
> EA = tcg_temp_new();
> \
> gen_addr_reg_index(ctx, EA);
>
On 12/7/18 2:56 AM, Mark Cave-Ayland wrote:
> -gen_helper_f##op(cpu_fpr[rD(ctx->opcode)], cpu_env,
> \
> - cpu_fpr[rA(ctx->opcode)],
> \
> - cpu_fpr[rC(ctx->opcode)], cpu_fpr[rB(ctx->opcode)]);
>
On Mon, 10 Dec 2018 at 17:57, Peter Maydell wrote:
>
> Switch the microblaze target from the old unassigned_access hook
> to the transaction_failed hook.
>
> The notable difference is that rather than it being called
> for all physical memory accesses which fail (including
> those made by DMA devi
These are just like any other struct or union, so they should have
CamelCase typedefs.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a8d6e44107..b4b3495044 100755
--- a/scripts/c
QTAILQ is a doubly linked list, with a pointer-to-pointer to the last
element from the head, and the previous element from each node.
But if you squint enough, QTAILQ becomes a combination of a singly-linked
forwards list, and another singly-linked list which goes backwards and
is circular. This
This will be needed when we change the QTAILQ head and elem structs
to unions. However, it is also consistent with the usage elsewhere
in QEMU for other list head structs (see for example FsMountList).
Note that most QTAILQs only need their name in order to do backwards
walks. Those do not break
Most list head structs need not be given a name. In most cases the
name is given just in case one is going to use QTAILQ_LAST, QTAILQ_PREV
or reverse iteration, but this does not apply to lists of other kinds,
and even for QTAILQ in practice this is only rarely needed. In addition,
we will soon r
These are not present for other kinds of queue, and unused.
Zap them before more changes are made to the QTAILQ
implementation.
Signed-off-by: Paolo Bonzini
---
include/qemu/queue.h | 14 ++
scripts/cocci-macro-file.h | 10 --
2 files changed, 6 insertions(+), 18 deleti
Use the QTAILQ_IN_USE macro instead, it does the same thing but in a
few patches its definition will change.
Signed-off-by: Paolo Bonzini
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 81f95d920b..7604b2183b 100644
--- a/blockdev.
It is not used outside hw/vfio/common.c, so it does not need to
be extern.
Cc: Alex Williamson
Signed-off-by: Paolo Bonzini
---
hw/vfio/common.c | 2 +-
include/hw/vfio/vfio-common.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/com
This series includes two changes that are a bit intertwined.
The main one is to reimplement QTAILQ in a way that simplifies
backwards walking of the list. The in-memory layout actually
stays the same, but the C description of it changes so that
(also thanks to typeof) you don't have to specify a
On 12/10/18 7:10 PM, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov
Reviewed-by: Philippe Mathieu-Daudé
> ---
> tests/acpi-utils.h | 8
> 1 file changed, 8 deletions(-)
>
> diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
> index 4f4899d..c8844a2 100644
> --- a/tests/acpi-ut
The new definition of QTAILQ does not require passing the headname,
remove it.
Signed-off-by: Paolo Bonzini
---
cpus-common.c | 2 +-
dump.c | 2 +-
hw/core/qdev.c | 4 ++--
hw/scsi/scsi-bus.c | 2 +-
hw/usb/combined-pa
Whole FADT is fetched as part of RSDT referenced tables in
fetch_rsdt_referenced_tables() albeit a bit later than when FADT
is partially parsed in fadt_fetch_facs_and_dsdt_ptrs().
However there is no reason for calling fetch_rsdt_referenced_tables()
so late, just move it right after we fetched RSDT
On 12/9/18 11:17 PM, David Gibson wrote:
> On Fri, Dec 07, 2018 at 08:56:30AM +, Mark Cave-Ayland wrote:
>> These helpers allow us to move FP register values to/from the specified
>> TCGv_i64
>> argument.
>>
>> To prevent FP helpers accessing the cpu_fpr array directly, add extra TCG
>> tempor
some parts of sanitize_fadt_ptrs() do redundant job
- locating FADT
- checking original checksum
There is no need to do it as test_acpi_fadt_table() already does that,
so drop duplicate code and move remaining fixup code into
test_acpi_fadt_table().
Signed-off-by: Igor Mammedov
---
tests/bi
RSDT referenced tables always have length at offset 4 and checksum at
offset 9, that's enough for reusing fetch_table() and replacing custom
RSDT fetching code with it.
While at it
* merge fetch_rsdt_referenced_tables() into test_acpi_rsdt_table()
* drop test_data::rsdt_table/rsdt_tables_addr/rsd
replace a bunch of ACPI_READ_ARRAY/ACPI_READ_FIELD macro, that read
SMBIOS table field by field with one memread() to fetch whole table
at once and drop no longer used ACPI_READ_ARRAY/ACPI_READ_FIELD macro.
Signed-off-by: Igor Mammedov
---
tests/acpi-utils.h | 17 -
tests/b
Signed-off-by: Igor Mammedov
---
tests/acpi-utils.h | 8
1 file changed, 8 deletions(-)
diff --git a/tests/acpi-utils.h b/tests/acpi-utils.h
index 4f4899d..c8844a2 100644
--- a/tests/acpi-utils.h
+++ b/tests/acpi-utils.h
@@ -70,14 +70,6 @@ typedef struct {
g_assert_cmpstr(ACPI_ASSE
AcpiSdtTable::header::signature is the only remained field from
AcpiTableHeader structure used by tests. Instead of using packed
structure to access signature, just read it directly from table
blob and remove no longer used AcpiSdtTable::header / union and
keep only AcpiSdtTable::aml byte array.
S
Move fetch_table() into acpi-utils.c renaming it to acpi_fetch_table()
and reuse it in vmgenid-test that reads RSDT and then tables it references,
to find and parse VMGNEID SSDT.
While at it wrap RSDT referenced tables enumeration into FOREACH macro
(similar to what we do with QLIST_FOREACH & co) t
Currently in the 1st case we store table body fetched from QEMU in
AcpiSdtTable::aml minus it's header but in the 2nd case when we
load reference aml from disk, it holds whole blob including header.
More over in the 1st case, we read header in separate AcpiSdtTable::header
structure and then jump o
It allows to remove a bit more of code duplication and
reuse common utility to get ACPI tables from guest (modulo RSDP).
While at it, consolidate signature checking into fetch_table() instead
of open-codding it.
Considering FACS is special and doesn't have checksum, make checksum
validation optin
While working on adding tests for virt/arm board (uefi/XSDT/64-bit table
pointers),
I found it's rather difficult to deal with mixed ACPI testing code that we've
collected so far. So instead of just adding a pile of XSDT hacks on top, here
goes small refactoring series:
* that removes dead code
1 - 100 of 290 matches
Mail list logo
