On Mon, Feb 04, 2019 at 04:10:37PM +0100, Thomas Huth wrote:
>
> Hi Gerd,
>
> I noticed that certain FreeDOS images are not working correctly anymore
> with the current version of QEMU, for example
> http://www.qemu-advent-calendar.org/2016/download/day10.tar.xz ... It
> aborts with:
>
>
+CC [Dave Chinner], to maintain updated CC list
> > This patch series has implementation for "virtio pmem".
> > "virtio pmem" is fake persistent memory(nvdimm) in guest
> > which allows to bypass the guest page cache. This also
> > implements a VIRTIO based asynchronous flush mechanism.
>
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
IIRC there were some endianess fixes for this in the past ... can you
still reproduce this issue with the latest version of QEMU and a recent
kernel? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
The -no-frame option has been deprecated with QEMU v2.12. It was only
useful with SDL1.2 - now that we've removed support for SDL1.2, we
can certainly remove the -no-frame option, too.
Signed-off-by: Thomas Huth
---
include/sysemu/sysemu.h | 1 -
qemu-deprecated.texi| 6 --
Yuval Shaia writes:
> On Mon, Feb 04, 2019 at 09:23:49AM +0100, Markus Armbruster wrote:
>> Yuval Shaia writes:
>>
>> > On Fri, Feb 01, 2019 at 08:33:44AM +0100, Markus Armbruster wrote:
>> >> Eric Blake writes:
>> >>
>> >> > On 1/31/19 2:08 PM, Yuval Shaia wrote:
>> >> >> On Thu, Jan 31,
Philippe Mathieu-Daudé writes:
> Many functions have documentation before the implementation in
> cutils.c. Since we expect documentation around the prototype
> declaration in headers,
We do?
There are two justifiable function comment placement styles: (1) next to
definition, and (2) next to
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-ebl...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Message-id: 20190205035704.26014-1-ebl...@redhat.com
On Thu, Jan 17, 2019 at 01:51:13PM +1100, Alexey Kardashevskiy wrote:
> The current code assumes that we can address more bits on a PCI bus
> for DMA than we really can but there is no way knowing the actual limit.
>
> This makes a better guess for the number of levels and if the kernel
> fails
On Mon, Feb 04, 2019 at 10:10:05AM +, Daniel P. Berrangé wrote:
> On Mon, Feb 04, 2019 at 12:09:04PM +1100, David Gibson wrote:
> > On Sat, Feb 02, 2019 at 12:23:58AM +0530, P J P wrote:
> > > From: Prasad J Pandit
> > >
> > > On ppc hosts, hypervisor shares following system attributes
> > >
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> Boston is built around a Xilinx FPGA, which includes a PCIe root port
> and an UART. An Intel EG20T PCH connects the I/O peripherals, but only
> the SATA bus is emulated.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
On 2/4/19 10:08 PM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20190205035704.26014-1-ebl...@redhat.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> 2/8 Checking commit bd906b01ffe8 (nbd:
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> This platform use standard PC devices connected to an ISA bus.
> Networking is provided by a ne2000 chipset.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/mips/Kconfig | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-ebl...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190205035704.26014-1-ebl...@redhat.com
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-ebl...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Type: series
Message-id:
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> The Jazz use the RC4030 Asic to provide an EISA bus and DMA/IRQ. The
> framebuffer display is managed by a G364, the network card is a Sonic
> DP83932. A QLogic ESP216 provides a SCSI bus.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
>
From: Vladimir Sementsov-Ogievskiy
We have several paranoid checks for ioc != NULL. But ioc may become
NULL only on close, which should not happen during requests handling.
Also, we check ioc only sometimes, not after each yield, which is
inconsistent. Let's drop these checks. However, for
From: Vladimir Sementsov-Ogievskiy
This coroutine will serve nbd reconnects, so, rename it to be something
more generic.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20190201130138.94525-7-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
From: Vladimir Sementsov-Ogievskiy
Keep all connection code in one file, to be able to implement reconnect
in further patches.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-Id: <20190201130138.94525-3-vsement...@virtuozzo.com>
Reviewed-by: Eric Blake
[eblake: format tweak]
From: Vladimir Sementsov-Ogievskiy
We generally do very similar things around nbd_read: error_prepend
specifying what we have tried to read, and be_to_cpu conversion of
integers.
So, it seems reasonable to move common things to helper functions,
which:
1. simplify code a bit
2. generalize
From: Vladimir Sementsov-Ogievskiy
To implement nbd reconnect in further patches, we need to distinguish
error codes, returned by nbd server, from channel errors, to reconnect
only in the latter case.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id:
From: Vladimir Sementsov-Ogievskiy
Split connection code to reuse it for reconnect.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20190201130138.94525-4-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
block/nbd-client.c | 33
From: Vladimir Sementsov-Ogievskiy
Use exported report, not the variable to be reused (should not really
matter).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Eric Blake
Message-Id: <20190201130138.94525-5-vsement...@virtuozzo.com>
Signed-off-by: Eric Blake
---
The following changes since commit 773c4a6228fd910556cee2d477ee56c591a3:
test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20
+)
are available in the Git repository at:
https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-02-04
for you to fetch changes up to
The existing qemu-nbd --partition code claims to handle logical
partitions up to 8, since its introduction in 2008 (commit 7a5ca86).
However, the implementation is bogus (actual MBR logical partitions
form a sort of linked list, with one partition per extended table
entry, rather than four logical
Patchew URL:
https://patchew.org/QEMU/1549336101-17623-1-git-send-email-th...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
On 2019-02-04 21:26, Philippe Mathieu-Daudé wrote:
> The MIPSsim machine only emulates an 8250 UART and a simple network
> controller, connected via an ISA bus.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> default-configs/mips-softmmu-common.mak | 1 -
> hw/mips/Kconfig
On 2019-02-04 21:45, Philippe Mathieu-Daudé wrote:
> When building with TSC_VERBOSE not defined, we get:
> CC arm-softmmu/hw/input/tsc210x.o
> hw/input/tsc210x.c: In function ‘tsc2102_data_register_write’:
> hw/input/tsc210x.c:554:5: error: label at end of compound statement
>
Now that support for SDL 1.2 has been removed, we can clean up
the sdlaudio code a little bit, too.
Thomas Huth (2):
audio/sdlaudio: Remove the semaphore code
audio/sdlaudio: Simplify the sdl_callback function
audio/sdlaudio.c | 188 +++
1
On 1/30/19 1:17 AM, Thomas Huth wrote:
>> test ... -a ...
>>
>> is not portable (POSIX permits non-XSI systems to omit support for these
>> operators, but even where they are supported, there are some inherently
>> ambiguous inputs where you CANNOT predict whether the shell will parse
>> -a as a
The semaphore code was only working with SDL1.2 - with SDL2, it causes
a deadlock. Since we've removed support for SDL1.2 recently, we can
now completely remove the semaphore code from sdlaudio.c.
Signed-off-by: Thomas Huth
---
audio/sdlaudio.c | 145
At the end of the while-loop, either "samples" or "sdl->live" is zero, so
now that we've removed the semaphore code, the content of the while-loop
is always only executed once. Thus we can remove the while-loop now to
get rid of one indentation level here.
Signed-off-by: Thomas Huth
---
On 2/4/19 8:25 PM, Eric Blake wrote:
> Flag commit attribution tags that are unusual (often because they
> were a typo), but only as a warning (because sometimes a humorous
> or otherwise useful tag is intentionally supplied).
>
> This picks the 6 most popular tags, each with 700 or more uses
On Tue, Feb 05, 2019 at 12:18:06AM +0100, Philippe Mathieu-Daudé wrote:
> Reviewed-by: BALATON Zoltan
> Tested-by: Thomas Huth
> Signed-off-by: Philippe Mathieu-Daudé
ppc parts
Acked-by: David Gibson
> ---
> hw/alpha/typhoon.c | 1 -
> hw/arm/allwinner-a10.c
On Mon, Feb 04, 2019 at 10:11:07PM +0100, Hervé Poussineau wrote:
> Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit :
> > In 47973a2dbf we split the last generic chipset out of the PC
> > board, but forgot to remove the include of "hw/i386/pc.h".
> > Since it is now unused, remove it.
> >
>
POSIX says that it is better to use &&/|| and two separate test
invocations than it is to try and use -a and -o (in fact, there
are some tests that are inherently ambiguous to parse if the
user passes in corner-case input like "(").
Since we cannot guarantee which shell runs configure, we cannot
Flag commit attribution tags that are unusual (often because they
were a typo), but only as a warning (because sometimes a humorous
or otherwise useful tag is intentionally supplied).
This picks the 6 most popular tags, each with 700 or more uses (well,
S-o-b was already checked for
On 2/4/19 5:29 PM, Philippe Mathieu-Daudé wrote:
> On 2/4/19 11:55 PM, Eric Blake wrote:
>> Flag commit attribution tags that are unusual (often because they
>> were a typo), but only as a warning (because sometimes a humorous
>> or otherwise useful tag is intentionally supplied).
>>
>> This picks
On Mon, Feb 04, 2019 at 05:59:16PM +, Peter Maydell wrote:
> On Mon, 4 Feb 2019 at 14:43, Michael S. Tsirkin wrote:
> >
> > The following changes since commit b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4:
> >
> > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into
> > staging
On Mon, Feb 04, 2019 at 05:59:16PM +, Peter Maydell wrote:
> On Mon, 4 Feb 2019 at 14:43, Michael S. Tsirkin wrote:
> >
> > The following changes since commit b3fc0af1ff5e922d4dd7c875394dbd26dc7313b4:
> >
> > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into
> > staging
On Mon, Feb 04, 2019 at 03:29:21PM +, Daniel P. Berrangé wrote:
> On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote:
> > Hmm I do think we want to build the contrib tools,
> > otherwise they bitrot too quickly, witness follow-up
> > patches that fix the compilation.
> >
> >
On Fri, 1 Feb 2019 at 10:28, Jason Wang wrote:
>
>
> On 2019/1/30 下午1:48, Yongji Xie wrote:
> > On Wed, 30 Jan 2019 at 10:32, Jason Wang wrote:
> >>
> >> On 2019/1/22 下午4:31, elohi...@gmail.com wrote:
> >>> +static int
> >>> +vu_queue_inflight_get(VuDev *dev, VuVirtq *vq, int desc_idx)
> >>> +{
On 2/4/19 7:18 PM, Philippe Mathieu-Daudé wrote:
> These tests explode on OpenBSD:
>
> $ gmake check-block
> [...]
> 238[17:16:09] [17:16:09] [failed, exit status 1] - output
> mismatch (see 238.out.bad)
> --- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan
Patchew URL: https://patchew.org/QEMU/20190205001835.25660-1-phi...@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
Since the ahci-test uses qemu-img, add a dependency to build it
before using it.
This fixes:
$ gmake check-qtest V=1
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/ahci-test
Failed to execute child process "/tmp/qemu-test.19tMRF/qemu-img" (No such
file
This test explodes on OpenBSD:
$ gmake check-block
[...]
208[14:46:03] [14:46:03] [failed, exit status 1] - output
mismatch (see 208.out.bad)
--- /tmp/qemu-test.9cUFe0/tests/qemu-iotests/208.outTue Jan 29 13:33:43
2019
+++
Instead of checking for a supported platforms, it might be useful
to test for the opposite.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qemu-iotests/iotests.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py
On 2/4/19 10:55 PM, Michael S. Tsirkin wrote:
> On Mon, Feb 04, 2019 at 08:46:33PM +0100, Philippe Mathieu-Daudé wrote:
>> On 2/4/19 8:32 PM, Michael S. Tsirkin wrote:
>>> On Mon, Feb 04, 2019 at 07:41:38PM +0100, Laszlo Ersek wrote:
On 02/04/19 18:47, Michael S. Tsirkin wrote:
> On Mon,
These tests explode on OpenBSD:
$ gmake check-block
[...]
238[17:16:09] [17:16:09] [failed, exit status 1] - output
mismatch (see 238.out.bad)
--- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan 29 17:09:03
2019
+++
Various fixes I encountered while trying to run QEMU test suite on OpenBSD.
This is the 'block' part of the v2.
Most non-RFC patches are reviewed and could be applied.
Since v2:
- Added R-b tags
- Addressed Eric's comments (in code and commit descriptions)
Since v1:
- various qemu-block fixes
Various sed regexp from common.filter use sed GNU extensions.
Instead of spending time to write these regex to be POSIX compliant,
verify the GNU sed is available and use it.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qemu-iotests/common.filter | 36
This test simply hangs with no information on OpenBSD.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qemu-iotests/209 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209
index 259e991ec6..7eb41e4363 100755
--- a/tests/qemu-iotests/209
+++
Bash is not always installed as /bin/bash. In particular on OpenBSD,
the package installs it in /usr/local/bin.
Use the 'env' shebang to search bash in the $PATH.
Patch created mechanically by running:
$ git grep -lE '#! ?/bin/bash' -- tests/qemu-iotests \
| while read f; do \
sed -i
Since a9660664fde, some iotests use qemu-nbd.
Add a dependency to build it before using it.
This fixes:
$ make check-block
GEN qemu-img-cmds.h
CC qemu-img.o
LINKqemu-img
CC qemu-io.o
LINKqemu-io
CC tests/qemu-iotests/socket_scm_helper.o
On 1/31/19 7:17 AM, mahaocong wrote:
> From: mahaocong
>
Please use "git send-email" where possible, it will help keep the
formatting right. Use "RESEND" or "v4" when sending out a cover letter
revision, so the tools can see it as a new thread properly.
Sorry for the hassle!
> This patch
On 1/29/19 11:21 PM, Eric Blake wrote:
> On 1/29/19 11:53 AM, Philippe Mathieu-Daudé wrote:
>> Various sed regexp from common.filter use sed GNU extensions.
>> Instead of spending time to write these regex to be POSIX compliant,
>> verify the GNU sed is available and use it.
>>
>> Signed-off-by:
On 04.02.19 23:48, Collin Walling wrote:
> On 1/30/19 10:57 AM, David Hildenbrand wrote:
>> When hotplugging a PCI bridge right now to the root port, we resolve
>> pci_get_bus(pdev)->parent_dev, which results in a SEGFAULT. Hotplugging
>> really only works right now when hotplugging to another
On 2/4/19 9:49 PM, no-re...@patchew.org wrote:
> Patchew URL:
> https://patchew.org/QEMU/20190204204517.23698-1-phi...@redhat.com/
>
> This series failed the docker-mingw@fedora build test. Please find the
> testing commands and
> their output below. If you have Docker installed, you can
On 2/4/19 11:55 PM, Eric Blake wrote:
> Flag commit attribution tags that are unusual (often because they
> were a typo), but only as a warning (because sometimes a humorous
> or otherwise useful tag is intentionally supplied).
>
> This picks the 6-most popular tags, each with 700 or more uses
Since uWireSlave is only used in this new header, there is no
need to expose it via "qemu/typedefs.h".
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 2 ++
hw/arm/nseries.c | 2 +-
hw/arm/palm.c | 2 +-
hw/input/tsc2005.c | 2 +-
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/exynos4_boards.c | 3 ++-
hw/arm/mps2-tz.c | 3 ++-
hw/net/lan9118.c | 1 -
include/hw/net/lan9118.h | 2 ++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c
index
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/net/ne2000-isa.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/hw/net/ne2000-isa.h b/include/hw/net/ne2000-isa.h
index ff2bed9c95..527337c454 100644
--- a/include/hw/net/ne2000-isa.h
+++
Add an entries the Blizzard device in MAINTAINERS.
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
hw/arm/nseries.c | 1 +
hw/display/blizzard.c | 2 +-
include/hw/devices.h | 7 ---
This commit finally deletes "hw/devices.h".
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/gumstix.c | 2 +-
hw/arm/integratorcp.c | 2 +-
hw/arm/mainstone.c | 2 +-
hw/arm/realview.c | 2 +-
hw/arm/versatilepb.c | 2 +-
hw/net/smc91c111.c |
Reviewed-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/nseries.c | 1 +
hw/misc/cbus.c | 2 +-
include/hw/devices.h | 14 --
include/hw/misc/cbus.h | 32
5 files changed, 35
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/kzm.c | 2 +-
hw/arm/mps2.c| 2 +-
hw/arm/realview.c| 1 +
hw/arm/vexpress.c| 2 +-
hw/net/lan9118.c | 2 +-
include/hw/devices.h | 3 ---
include/hw/net/lan9118.h | 19 +++
The TC6393XB_RAM definition introduced in 64b40bc54a9 is no
more used since a0b753dfd39. Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
hw/arm/tosa.c | 2 +-
hw/display/tc6393xb.c | 2 +-
include/hw/devices.h | 10
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 1 +
hw/arm/stellaris.c | 2 +-
hw/input/stellaris_input.c | 2 +-
include/hw/devices.h | 3 ---
include/hw/input/gamepad.h | 21 +
5 files changed, 24 insertions(+), 5 deletions(-)
Reviewed-by: BALATON Zoltan
Tested-by: Thomas Huth
Signed-off-by: Philippe Mathieu-Daudé
---
hw/alpha/typhoon.c | 1 -
hw/arm/allwinner-a10.c | 1 -
hw/arm/collie.c | 1 -
hw/arm/cubieboard.c | 1 -
Hi,
As his first comment describes itself, the "hw/devices.h" contains
declarations for "Devices that have nowhere better to go."
This series remove it, creating new headers for devices covered there.
MAINTAINERS is updated.
I also included 2 cleanups while working on this, in "qemu/typedefs.h"
Reviewed-by: Thomas Huth
Reviewed-by: Cédric Le Goater
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 5158985482..e98ede5a86 100644
--- a/hw/arm/aspeed.c
+++
On 1/4/19 8:35 PM, Thomas Huth wrote:
> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé
>> ---
>> As init helper in "hw/char/pl011.h"
>> ---
>> hw/net/smc91c111.c | 17 -
>> include/hw/net/smc91c111.h | 25
On 1/30/19 10:57 AM, David Hildenbrand wrote:
The primary bus number corresponds always to the bus number of the
bus the bridge is attached to.
Right now, if we have two bridges attached to the same bus (e.g. root
bus) this is however not the case. The first bridge will have primary
bus 0, the
On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote:
> This patch series has implementation for "virtio pmem".
> "virtio pmem" is fake persistent memory(nvdimm) in guest
> which allows to bypass the guest page cache. This also
> implements a VIRTIO based asynchronous flush
On 2/4/19 4:54 PM, David Hildenbrand wrote:
On 04.02.19 21:19, Collin Walling wrote:
On 1/30/19 10:57 AM, David Hildenbrand wrote:
We decided to always create the PCI host bridge, even if 'zpci' is not
enabled (due to migration compatibility). This however right now allows
to add zPCI/PCI
On 2/4/19 3:56 PM, Eric Blake wrote:
> Flag commit attribution tags that are unusual (often because they
> were a typo), but only as a warning (because sometimes a humorous
> or otherwise useful tag is intentionally supplied).
>
> This picks the 6-most popular tags, each with 700 or more uses
On 2/4/19 4:05 PM, Eric Blake wrote:
> Since qemu currently doesn't flush persistent bitmaps to disk until
> shutdown (which might be MUCH later), it's useful if 'query-block'
> at least shows WHICH bitmaps will (eventually) make it to persistent
> storage. Update affected iotests.
>
>
Flag commit attribution tags that are unusual (often because they
were a typo), but only as a warning (because sometimes a humorous
or otherwise useful tag is intentionally supplied).
This picks the 6-most popular tags, each with 700 or more uses (well,
S-o-b was already checked for
On 04.02.19 23:42, Collin Walling wrote:
> On 2/4/19 4:54 PM, David Hildenbrand wrote:
>> On 04.02.19 21:19, Collin Walling wrote:
>>> On 1/30/19 10:57 AM, David Hildenbrand wrote:
We decided to always create the PCI host bridge, even if 'zpci' is not
enabled (due to migration
On 1/30/19 10:57 AM, David Hildenbrand wrote:
When hotplugging a PCI bridge right now to the root port, we resolve
pci_get_bus(pdev)->parent_dev, which results in a SEGFAULT. Hotplugging
really only works right now when hotplugging to another bridge.
Instead, we have to properly check if we are
On Mon, 4 Feb 2019 22:23:40 +
"Singh, Brijesh" wrote:
> The RAM device presents a memory region that should be handled
> as an IO region and should not be pinned.
>
> In the case of the vfio-pci, RAM device represents a MMIO BAR
> and the memory region is not backed by pages hence
>
On 1/24/19 12:29 PM, Peter Maydell wrote:
> On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote:
>>
>> On 1/24/19 2:45 AM, Markus Armbruster wrote:
>>
Signed-off-by: Michael Tokarev
Revieved-by: Michael Tokarev
>>>
>>> Typo in Reviewed-by.
>>
>> Should we tighten checkpatch.pl to flag
Currently, a callback registered through the RAMBlock notifier
is not able to get the memory region type (i.e callback is not
able to use memory_region_is_ram_device function). This is
because mr->ram assignment happens _after_ the memory is allocated
whereas the callback is executed during
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=1667249
Since v1:
* check the error code from memory_region_from_host() before
accessing the mr.
Brijesh Singh (2):
memory: Fix the memory region type assignment order
target/i386: sev: Do not pin the ram device memory region
memory.c
The RAM device presents a memory region that should be handled
as an IO region and should not be pinned.
In the case of the vfio-pci, RAM device represents a MMIO BAR
and the memory region is not backed by pages hence
KVM_MEMORY_ENCRYPT_REG_REGION fails to lock the memory range.
Fixes:
Flag commit attribution tags that are unusual (often because they
were a typo), but only as a warning (because sometimes a humorous
or otherwise useful tag is intentionally supplied).
This picks the 6-most popular tags, each with 700 or more uses (well,
S-o-b was already checked for
On Mon, Feb 04, 2019 at 08:46:33PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Michael,
>
> On 2/4/19 8:32 PM, Michael S. Tsirkin wrote:
> > On Mon, Feb 04, 2019 at 07:41:38PM +0100, Laszlo Ersek wrote:
> >> On 02/04/19 18:47, Michael S. Tsirkin wrote:
> >>> On Mon, Feb 04, 2019 at 05:03:24PM
On 04.02.19 21:19, Collin Walling wrote:
> On 1/30/19 10:57 AM, David Hildenbrand wrote:
>> We decided to always create the PCI host bridge, even if 'zpci' is not
>> enabled (due to migration compatibility). This however right now allows
>> to add zPCI/PCI devices to a VM although the guest will
On 01/30/2019 08:22 AM, Cornelia Huck wrote:
The flow for processing ssch requests can be improved by splitting
the BUSY state:
- CP_PROCESSING: We reject any user space requests while we are in
the process of translating a channel program and submitting it to
the hardware. Use -EAGAIN
Introduced in cd390083ad1, these macros don't need to be in
a generic header.
Add documentation to justify their use.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Stefano Garzarella
Reviewed-by: David Gibson
---
v2: Fixed checkpatch warnings (tabs)
---
hw/core/bus.c | 2 +-
The size_to_str() function doesn't need to be in a generic header.
It makes also sense to find this function in the same header as
the opposite string to size functions: qemu_strtosz*().
Note that this function is already implemented in util/cutils.c.
Since we introduce a new function in a
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/unicore32/puv3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/unicore32/puv3.c
This series is a fairly trivial cleanup of "cutils.h"
(size_to_str() and ctype macros moved into it), and
some documentation improvements.
Since v2:
- Fixed RISC-V (Laurent)
Since v1:
- Fixed checkpatch errors (patchew)
- Added Stefano R-b
$ git backport-diff -u v2
[] : patches are
On 2/4/19 11:59 AM, Alex Williamson wrote:
> On Thu, 17 Jan 2019 21:53:16 +
> "Singh, Brijesh" wrote:
>
>> The RAM device presents a memory region that should be handled
>> as an IO region and should not be pinned.
>>
>> In the case of the vfio-pci, RAM device represents a MMIO BAR
>> and
Many functions have documentation before the implementation in
cutils.c. Since we expect documentation around the prototype
declaration in headers, move the comments in cutils.h.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Gibson
Reviewed-by: Stefano Garzarella
---
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ppc/prep.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
Le 04/02/2019 à 22:04, Philippe Mathieu-Daudé a écrit :
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Hervé Poussineau
Since 47973a2dbf, it is useless to include "hw/i386/pc.h"
on the ppc/unicore32/sparc64 boards.
The last non-x86 targets still requiring it are alpha/hppa/mips,
because the I8259 intc is still deeply mixed with the PC board.
Philippe Mathieu-Daudé (3):
hw/sparc64/sun4u: Drop useless inclusion
In 47973a2dbf we split the last generic chipset out of the PC
board, but forgot to remove the include of "hw/i386/pc.h".
Since it is now unused, remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc64/sun4u.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/sparc64/sun4u.c
1 - 100 of 471 matches
Mail list logo
