From: Corey Minyard
It had spaces between cases in some places and not others. Add a space
for every one.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 1 +
hw/i2c/smbus_slave.c | 9 +
2 files changed, 10 insertions(+)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eep
On Thu, Feb 28, 2019 at 12:11:00PM -0600, Eric Blake wrote:
> On 2/27/19 10:20 AM, Daniel P. Berrangé wrote:
> > From: "Daniel P. Berrange"
> >
> > Currently any client which can complete the TLS handshake is able to use
> > the NBD server. The server admin can turn on the 'verify-peer' option
>
From: Corey Minyard
Keep someone from passing in a bogus number
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 0ba5763fc2..37167e7244 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2
On Thu, 28 Feb 2019 at 17:59, Greg Kurz wrote:
>
> Build fails with gcc 9:
>
> CC ppc64-softmmu/hw/scsi/virtio-scsi.o
> hw/scsi/virtio-scsi.c: In function ‘virtio_scsi_do_tmf’:
> hw/scsi/virtio-scsi.c:265:39: error: taking address of packed member of
> ‘struct virtio_scsi_ctrl_tmf_req’ may
From: Corey Minyard
There is no vmstate handling for SMBus, so no device sitting on SMBus
can have a state transfer that works reliably. So add it.
Signed-off-by: Corey Minyard
Cc: Paolo Bonzini
Cc: Michael S. Tsirkin
Cc: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
---
hw/i
From: Corey Minyard
This will be needed by coming I2C changes.
Signed-off-by: Corey Minyard
Reviewed-by: Dr. David Alan Gilbert
---
include/migration/vmstate.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 067b126cf1..a6
From: Corey Minyard
It's not necessary, it won't be called if it's NULL.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 760594b3f1..2f90287b69 100644
--- a/hw/i2c/smbus_eeprom
From: Corey Minyard
The logic of handling quick SMBus commands was wrong. If you get a
finish event with no data, that's a quick command.
Document the quick command while we are at it.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_slave.c | 35 +++
inc
From: Corey Minyard
The I2C block read function of pm_smbus was completely broken. It
required doing some direct I2C handling because it didn't have a
defined size, the OS code just reads bytes until it marks the
transaction finished.
This also required adjusting how the AMIBIOS workaround code
From: Corey Minyard
There were two different read functions, and with the removal of
the command passed in there is no functional difference. So remove
one of them. With that you don't need one of the states, so that
can be removed, too.
Signed-off-by: Corey Minyard
---
hw/i2c/smbus_eeprom.c
From: Corey Minyard
Reset the contents to init data and reset the offset on a machine
reset.
Signed-off-by: Corey Minyard
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/smbus_eeprom.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/smbus_eeprom.c
From: Corey Minyard
i2c_recv() cannot fail, so there is no need to check the return
value. It also returns unt8_t, so comparing with < 0 is not
meaningful.
Fix up various I2C controllers to remove the unneeded code.
Signed-off-by: Corey Minyard
Suggested-by: Peter Maydell
---
hw/i2c/aspeed_
From: Corey Minyard
Transfer the state information for the SMBus registers and
internal data so it will work on a VM transfer.
Signed-off-by: Corey Minyard
Cc: Michael S. Tsirkin
Cc: Paolo Bonzini
Cc: Dr. David Alan Gilbert
Reviewed-by: Dr. David Alan Gilbert
---
hw/acpi/piix4.c
From: Corey Minyard
Migration capability is being added for pm_smbus and SMBus devices.
This change will allow backwards compatibility to be kept when
migrating back to an old qemu version. Add a bool to the machine
class tho keep smbus migration from happening. Future changes
will use this.
S
From: Corey Minyard
Create a type name and a cast macro and use those through the
code.
Signed-off-by: Corey Minyard
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/smbus_eeprom.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/h
From: Corey Minyard
It was hard-coded to 256 in a number of places, create a constant
for that.
Signed-off-by: Corey Minyard
Reviewed-by: Philippe Mathieu-Daudé
---
hw/i2c/smbus_eeprom.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/
From: Corey Minyard
It can't fail, and now that it returns a uint8_t a 0xff mask
is unnecessary.
Signed-off-by: Corey Minyard
Suggested-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
---
hw/arm/stellaris.c | 2 +-
1 file c
From: Corey Minyard
There were two different write functions and the SMBus code kept
track of the command.
Keeping track of the command wasn't useful, in fact it wasn't quite
correct for the eeprom_smbus code. And there is no need for two write
functions. Just have one write function and the f
From: Corey Minyard
It is never supposed to fail and cannot return an error, so just
have it return the proper type. Have it return 0xff on nothing
available, since that's what would happen on a real bus.
Signed-off-by: Corey Minyard
Reviewed-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Da
From: Corey Minyard
Transfer the state of the EEPROM on a migration. This way the
data remains consistent on migration.
This required moving the actual data to a separate array and
using the data provided in the init function as a separate
initialization array, since a pointer property has to b
or-release-20190228
for you to fetch changes up to c203d4514b9c8c1c3bf25988a81edf3813eb3c6d:
i2c: Verify that the count passed in to smbus_eeprom_init() is valid
(2019-02-27 21:06:08 -0600)
This has been out there long enough,
From: Corey Minyard
smbus.c and smbus.h had device side code, master side code, and
smbus.h has some smbus_eeprom.c definitions. Split them into
separate files.
Signed-off-by: Corey Minyard
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
---
MAINTAINERS
On Thu, 28 Feb 2019 at 17:55, Greg Kurz wrote:
>
> Build fails with gcc 9:
>
> CC slirp/ndp_table.o
> slirp/ndp_table.c: In function ‘ndp_table_add’:
> slirp/ndp_table.c:31:23: error: taking address of packed member of ‘struct
> ndpentry’ may result in an unaligned pointer value
> [-Werro
On 2/28/19 5:46 PM, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta
> Reviewed-by: Eric Blake
>
> Note that since thunking occurs throughout the lifetime of the QEMU
> instance, there is no matching 'free' to correct.
>
> ---
> thunk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
On 2/27/19 10:20 AM, Daniel P. Berrangé wrote:
> From: "Daniel P. Berrange"
>
> Currently any client which can complete the TLS handshake is able to use
> the NBD server. The server admin can turn on the 'verify-peer' option
> for the x509 creds to require the client to provide a x509 certificate
On Thu, Feb 28, 2019 at 04:06:06PM +0100, Greg Kurz wrote:
> Build fails with gcc 9:
>
> crypto/block-luks.c:689:18: error: taking address of packed member of ‘struct
> QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 689 | be32_to_cpu
On 2/28/19 9:18 AM, Stephen Checkoway wrote:
> I wonder if it would make sense to maintain a small cache of TLBs. The
> majority of cases are likely to involving setting segment registers to one
> of a handful of segments (e.g., setting es to ds or ss). So it might be nice
> to avoid the flushes en
Build fails with gcc 9:
CC ppc64-softmmu/hw/scsi/virtio-scsi.o
hw/scsi/virtio-scsi.c: In function ‘virtio_scsi_do_tmf’:
hw/scsi/virtio-scsi.c:265:39: error: taking address of packed member of ‘struct
virtio_scsi_ctrl_tmf_req’ may result in an unaligned pointer value
[-Werror=address-of-pa
Build fails with gcc 9:
CC hw/usb/dev-mtp.o
hw/usb/dev-mtp.c: In function ‘usb_mtp_write_metadata’:
hw/usb/dev-mtp.c:1754:36: error: taking address of packed member of ‘struct
’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
1754 |
Build fails with gcc 9:
CC slirp/ndp_table.o
slirp/ndp_table.c: In function ‘ndp_table_add’:
slirp/ndp_table.c:31:23: error: taking address of packed member of ‘struct
ndpentry’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
31 | if (in6_equal(&ndp_
On 28/02/2019 17.28, Richard Henderson wrote:
> On 2/28/19 4:27 AM, Thomas Huth wrote:
>> From: Philippe Mathieu-Daudé
>>
>> Richard obviously maintains this subdirectory, make this official :)
>>
>> Remove the qemu-devel@nongnu.org entry because the list is always
>> selected by the 'All patches
From: Paul Durrant
The locally allocated QDict-s need to be freed. ('file_layer' will be
freed implicitly since it is added as an object to 'driver_layer').
Spotted by Coverity: CID 1398649
While in the neighbourhood free 'driver' and 'filename' as soon as they are
added to the QDicts. Freeing
On 2/27/19 11:14 PM, David Hildenbrand wrote:
> I guess signal + sigsetjmp/siglongjmp is the one with the smalles LOC?
> Will give it a try.
I suppose it depends on how you write it.
struct sigaction sa = {
.sa_mask = SA_RESETHAND | SA_NODEFER,
.sa_handler = sig_sigill,
};
erard/qemu-dm.git
tags/pull-xen-20190228
for you to fetch changes up to 156ac94463b42b0b9beea263af9866dfcd3683e0:
xen-block: stop leaking memory in xen_block_drive_create() (2019-02-28
17:21:12 +)
Xen queue
* xen-b
>
> are available in the git repository at:
>
> git://git.kraxel.org/qemu tags/audio-20190228-pull-request
>
> for you to fetch changes up to 9399ef168377d9e7f2e33b1c2eb61751aa1b72fa:
>
> audio/sdlaudio: Simplify the
From: Paul Durrant
The assignment to 'p' is unnecessary as the code will either goto 'invalid'
or p will get overwritten.
Spotted by Coverity: CID 1398638
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
Acked-by: Anthony PERARD
Message-Id: <20190215162533.19475-3-paul.durr...@citrix.c
From: Paul Durrant
The function needs to make sure it is passed a valid disk name. This is
easily done by making sure that the parsing loop results in a non-zero
value.
Spotted by Coverity: CID 1398640
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
Acked-by: Anthony PERARD
Message-Id
From: Paul Durrant
The if() statement is clearly bogus (dead code which should have been
cleaned up when grant mapping was removed).
Spotted by Coverity: CID 1398635
While in the neighbourhood, add a missing 'fall through' annotation.
Reported-by: Peter Maydell
Signed-off-by: Paul Durrant
Ac
On Thu, Feb 28, 2019 at 01:28:46PM +0100, David Hildenbrand wrote:
> Can somebody please pick this up in the near future? (@Eduardo, @MST,
> @Paolo, @David - I have no idea who the right person is :) )
>
> The longer we wait, the more likely it is that some stuff gets upstreamed
> that conflicts w
On Mon, Dec 17, 2018 at 10:57:30AM -0500, Tony Krowiak wrote:
> The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the
> max_index
> value of the BusState structure with the max_dev value of the BusClass
> structure
> to determine whether the maximum number of children has been re
On 2/28/19 12:27 AM, David Hildenbrand wrote:
> +/* fast path if we don't need the register content */
> +if (!get_field(s->fields, b2)) {
> +uint8_t enr = get_field(s->fields, d2) & (NUM_VEC_ELEMENTS(es) - 1);
> +
> +read_vec_element_i64(o->out, get_field(s->fields, v3), en
Public bug reported:
Host: clean Ubuntu Disco with QEMU 3.1
Guest: Alpine Linux edge with xmlto
Steps to set up guest:
curl -O
http://dl-cdn.alpinelinux.org/alpine/edge/releases/ppc64le/netboot/vmlinuz-vanilla
curl -O
http://dl-cdn.alpinelinux.org/alpine/edge/releases/ppc64le/netboot/initramfs
On Thu, Feb 14, 2019 at 05:57:33AM -0500, Igor Mammedov wrote:
> QEMU will crashes with
> qapi/qobject-output-visitor.c:210: qobject_output_complete: Assertion
> `qov->root && ((&qov->stack)->slh_first == ((void *)0))' failed
> when trying to get value of not set hostmem's "host-nodes"
> property
On 2/28/19 12:36 AM, David Hildenbrand wrote:
> On 27.02.19 17:02, Richard Henderson wrote:
>> On 2/26/19 3:38 AM, David Hildenbrand wrote:
>>> Also fairly easy to implement. One issue we have is that exceptions will
>>> result in some vectors already being modified. At least handle it
>>> consiste
This is all extremely helpful! I'll dig in and try this approach soon.
> On Feb 28, 2019, at 11:11, Richard Henderson
> wrote:
>
>> Are you thinking that this should be modeled as independent sets of TLBs,
>> one per mode?
>
> One per segment you mean?
Yes.
> Yes, exactly. Since each segm
Am 28.02.2019 um 18:04 hat Sergio Lopez geschrieben:
> On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote:
> > Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben:
> > > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote:
> > > > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben:
On 2/28/19 10:55 AM, Zhang Chen wrote:
> From: Zhang Chen
>
> In this patch we add the processing state for COLOExitReason,
> because we have to identify COLO in the failover processing state or
> failover error state. In the way, we can handle all the failover state.
> We have improved the descr
On 2/28/19 10:55 AM, Zhang Chen wrote:
> From: Zhang Chen
>
> Remove the "active" variable in example for query-colo-status.
>
> Signed-off-by: Zhang Chen
> ---
> qapi/migration.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
Might be nice to mention tha
From: Zhang Chen
Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user got nothing to call
query_colo_status after failover.
Signed-off-by: Zhang Chen
---
migration/colo.c | 28 +++-
1 file changed, 23 insertions(+), 5 deleti
On Thu, Feb 28, 2019 at 04:50:53PM +0100, Kevin Wolf wrote:
> Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben:
> > On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote:
> > > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben:
> > > > Stopping the dataplane requires calling to blk_set_ai
From: Zhang Chen
Delay to close COLO for auto start VM after failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 -
migration/migration.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration/colo.
On 28/02/2019 08:39, Andrew Randrianasulu wrote:
>>> configure line:
>>> setarch i686 ./configure --target-list=ppc64-softmmu
>>>
>>> launch line:
>>> ppc64-softmmu/qemu-system-ppc64 -display
>>> sdl,gl=on -hda /mnt/sdb1/PPC-img/alpine_disk.img
>>>
>>> where alpine_disk.img is HDD installed Alpine
From: Zhang Chen
When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.
Signed-off-by: Zhang Chen
---
migration/colo.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/migration/colo.c b/migrat
From: Zhang Chen
In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.
Signed-of
From: Zhang Chen
Remove the "active" variable in example for query-colo-status.
Signed-off-by: Zhang Chen
---
qapi/migration.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 48e21880a3..f4c1762dfc 100644
--- a/qapi/migrati
From: Zhang Chen
In migration_incoming_state_destroy(void) will check the mis->to_src_file
to double close the mis->to_src_file when occur COLO failover.
Signed-off-by: Zhang Chen
Reviewed-by: Dr. David Alan Gilbert
---
migration/colo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migr
From: Zhang Chen
Signed-off-by: Zhang Chen
---
migration/colo.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index dbe2b88807..d1ae2e6d11 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -197,10 +197,16 @@ void colo_do
From: Zhang Chen
This series focus on COLO failover bug fix and optimization.
V2:
- Add patch 4/7 to handle failover state.
- Add new patches to optimize failover status.
V1:
- Init patch.
Zhang Chen (7):
Migration/colo.c: Fix double close bug when occur COLO failover
Migration/colo.c:
On 28/02/2019 06:38, Gerd Hoffmann wrote:
> On Thu, Feb 28, 2019 at 06:01:30AM +, Mark Cave-Ayland wrote:
>> On 28/02/2019 05:49, Gerd Hoffmann wrote:
>>
>>> Hi,
>>>
Right, at the moment all the MacOS driver does is parse the resolution
list from the
EDID and add them to the
On Thu, Feb 28, 2019 at 12:01 AM Mark Cave-Ayland <
mark.cave-ayl...@ilande.co.uk> wrote:
> On 27/02/2019 05:27, Gerd Hoffmann wrote:
>
> > On Tue, Feb 26, 2019 at 04:11:06PM -0500, G 3 wrote:
> >> When I use edid=on, I do see a lot of extra resolutions available in
> Mac OS
> >> 9 and Mac OS X, j
Signed-off-by: Aarushi Mehta
Reviewed-by: Eric Blake
Note that since thunking occurs throughout the lifetime of the QEMU
instance, there is no matching 'free' to correct.
---
thunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/thunk.c b/thunk.c
index d5d8645cd4..17f3d32
On Thu, 28 Feb 2019 16:09:48 +
Shameerali Kolothum Thodi wrote:
> Hi Eric,
>
> > -Original Message-
> > From: Auger Eric [mailto:eric.au...@redhat.com]
> > Sent: 27 February 2019 17:53
> > To: Shameerali Kolothum Thodi ;
> > shannon.zha...@gmail.com; peter.mayd...@linaro.org;
> > ima
On 28/02/2019 04.00, Wei, Danmei wrote:
> Hi,
>
> When we build qemu with "-Wmaybe-uninitialized" on, and got the following
> error information.
> CC qobject/json-streamer.o
> CC qobject/json-parser.o
> CC qobject/block-qdict.o
> qobject/block-qdict.c: In function 'qdict_arra
On 28.02.19 17:34, Richard Henderson wrote:
> On 2/27/19 11:48 PM, David Hildenbrand wrote:
>> I think that would be wrong. It is only an alignment hint.
>>
>> "Setting the alignment hint to a non-zero value
>> that doesn’t correspond to the alignment of the second operand may
>> reduce performance
On 2/27/19 11:48 PM, David Hildenbrand wrote:
> I think that would be wrong. It is only an alignment hint.
>
> "Setting the alignment hint to a non-zero value
> that doesn’t correspond to the alignment of the second operand may
> reduce performance on some models."
>
> So we must not inject an ex
On Thu, 28 Feb 2019 at 16:14, Philippe Mathieu-Daudé wrote:
> Then I moved this file in a watched dir. I see warnings are not fatal,
> and from the manpage there is the '-W' option:
>
> sphinx-build(1)
>
> -W Turn warnings into errors.
> This means that the build stops at the firs
On Thu, 28 Feb 2019 16:03:24 +0100
Eric Auger wrote:
> Now we have the extended memory map (high IO regions beyond the
> scalable RAM) and dynamic IPA range support at KVM/ARM level
> we can bump the legacy 255GB initial RAM limit. The actual maximum
> RAM size now depends on the physical CPU and
On 2/28/19 4:27 AM, Thomas Huth wrote:
> From: Philippe Mathieu-Daudé
>
> Richard obviously maintains this subdirectory, make this official :)
>
> Remove the qemu-devel@nongnu.org entry because the list is always
> selected by the 'All patches CC here' section.
>
> Cc: Richard Henderson
> Sign
On Thu, 28 Feb 2019 at 16:01, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> On 2/28/19 3:56 PM, Peter Maydell wrote:
> > Commit the initial Sphinx conf.py and skeleton index.rst as
> > generated with sphinx-quickstart. We'll update these to
> > add QEMU-specific tweaks in subsequent commits.
> >
On Thu, 28 Feb 2019 at 15:49, Philippe Mathieu-Daudé wrote:
>
> Hi Peter,
>
> On 2/28/19 3:56 PM, Peter Maydell wrote:
> > if test "$docs" != "no" ; then
> > - if has makeinfo && has pod2man; then
> > + if has makeinfo && has pod2man && has sphinx-build; then
>
> Unrelated to your patch, I trie
On Thu, 28 Feb 2019 16:03:22 +0100
Eric Auger wrote:
> This patch implements the machine class kvm_type() callback.
> It returns the number of bits requested to implement the whole GPA
> range including the RAM and IO regions located beyond.
> The returned value in passed though the KVM_CREATE_VM
Patchew URL:
https://patchew.org/QEMU/20190228145624.24885-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190228145624.24885-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/11] Enable bui
On 2/28/19 3:56 PM, Peter Maydell wrote:
> sphinx-build complains:
>
> docs/cpu-hotplug.rst:67: ERROR: Unexpected indentation.
> docs/cpu-hotplug.rst:69: ERROR: Unexpected indentation.
> docs/cpu-hotplug.rst:74: WARNING: Block quote ends without a blank line;
> unexpected unindent.
> docs/cpu-hot
On 2/28/19 7:01 AM, Stephen Checkoway wrote:
> I'm very new to this part of the code base. I'm not entirely sure how the
> softmmu translation process works. It looks like each target defines a
> number of MMU_MODES and each memory access TCG instruction (I'm not sure
> what these are called) encod
On Thu, 28 Feb 2019 10:59:13 -0500
"Jason J. Herne" wrote:
> On 2/4/19 6:41 AM, Cornelia Huck wrote:
> >> @@ -148,6 +370,9 @@ int do_cio(SubChannelId schid, uint32_t ccw_addr, int
> >> fmt)
> >> continue;
> >> }
> >>
> >> +print_irb_err(&irb);
> >> +ba
On Wed, 27 Feb 2019 at 14:00, Aleksandar Markovic
wrote:
>
> From: Aleksandar Markovic
>
> Merge remote-tracking branch
> 'remotes/berrange/tags/authz-core-pull-request' into staging (2019-02-26
> 17:59:41 +)
>
> are available in the git repository at:
>
> https://github.com/AMarkovic/q
Hi Eric,
> -Original Message-
> From: Auger Eric [mailto:eric.au...@redhat.com]
> Sent: 27 February 2019 17:53
> To: Shameerali Kolothum Thodi ;
> shannon.zha...@gmail.com; peter.mayd...@linaro.org;
> imamm...@redhat.com; qemu-devel@nongnu.org; qemu-...@nongnu.org
> Cc: xuwei (O) ; Linuxar
On 2/28/19 9:35 AM, Aarushi Mehta wrote:
>
> Signed-off-by: Aarushi Mehta
> ---
> Note that since thunking occurs throughout the lifetime of the QEMU instance,
> there is no matching 'free' to correct
This sentence is vital to the patch, so it belongs above the --- and
S-o-b as part of the comm
On Thu, 28 Feb 2019 16:03:19 +0100
Eric Auger wrote:
> Add the kvm_arm_get_max_vm_ipa_size() helper that returns the
> number of bits in the IPA address space supported by KVM.
>
> This capability needs to be known to create the VM with a
> specific IPA max size (kvm_type passed along KVM_CREATE
On Thu, 28 Feb 2019 16:03:21 +0100
Eric Auger wrote:
> Up to now the memory map has been static and the high IO region
> base has always been 256GiB.
>
> This patch modifies the virt_set_memmap() function, which freezes
> the memory map, so that the high IO range base becomes floating,
> located
Hi Peter,
On 2/28/19 3:56 PM, Peter Maydell wrote:
> Commit the initial Sphinx conf.py and skeleton index.rst as
> generated with sphinx-quickstart. We'll update these to
> add QEMU-specific tweaks in subsequent commits.
>
> Signed-off-by: Peter Maydell
> ---
> docs/conf.py | 168
Patchew URL:
https://patchew.org/QEMU/20190228145624.24885-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190228145624.24885-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/11] Enable bui
On 2/4/19 6:41 AM, Cornelia Huck wrote:
...
+static void print_irb_err(Irb *irb)
+{
+Ccw0 *this_ccw = u32toptr(irb->scsw.cpa);
+Ccw0 *prev_ccw = u32toptr(irb->scsw.cpa - 8);
I don't think you can cast this conditionally to format 0 -- I'd pass
in the format from do_cio and handle it a
On 2/28/19 3:56 PM, Peter Maydell wrote:
> Don't hard-code the QEMU version number into conf.py. Instead
> we either pass it to sphinx-build on the command line, or
> (if doing a standalone Sphinx run in a readthedocs.org setup)
> extract it from the VERSION file.
>
> Signed-off-by: Peter Maydell
Patchew URL:
https://patchew.org/QEMU/20190228145624.24885-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190228145624.24885-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/11] Enable bui
On Thu, 28 Feb 2019 16:03:17 +0100
Eric Auger wrote:
> In the prospect to introduce an extended memory map supporting more
> RAM, let's split the memory map array into two parts:
>
> - the former a15memmap, renamed base_memmap, contains regions below
> and including the RAM. MemMapEntries init
Am 28.02.2019 um 16:01 hat Sergio Lopez geschrieben:
> On Wed, Feb 27, 2019 at 06:37:14PM +0100, Kevin Wolf wrote:
> > Am 27.02.2019 um 17:52 hat Sergio Lopez geschrieben:
> > > Stopping the dataplane requires calling to blk_set_aio_context, which
> > > may need to wait for a running job to be comp
> Peter Maydell wrote:
> This patchset enables building and installing the various rST
> docs we have started to accumulate in our docs/ directory.
For the entire series:
Acked-by: Aleksandar Markovic
It does this using Sphinx (which is the docs tooling that the
> Linux kernel uses). The seri
Hi Peter,
On 2/28/19 3:56 PM, Peter Maydell wrote:
> Add support to our configure and makefile machinery for building
> our rST docs into HTML files.
>
> Building the documentation now requires that sphinx-build is
> available; this seems better than allowing half the docs to
> be built if it is
On Thu, 2019-02-28 at 13:50 +, Daniel P. Berrangé wrote:
> On Thu, Feb 28, 2019 at 07:12:45PM +0530, Aarushi Mehta wrote:
> > Hi
> >
> > This is a trivial contribution part of the BiteSizedTasks on the
> > wiki.
> > I found this discussion
> > http://git.corpit.ru/?p=qemu.git;a=commit;h=b45c0
Signed-off-by: Aarushi Mehta
---
Note that since thunking occurs throughout the lifetime of the QEMU instance,
there is no matching 'free' to correct
It might be valuable to edit the BiteSizedTasks to reflect that g_new is
favoured over g_malloc
thunk.c | 2 +-
1 file changed, 1 insertion(+)
Patchew URL:
https://patchew.org/QEMU/20190228145624.24885-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190228145624.24885-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/11] Enable bui
Patchew URL:
https://patchew.org/QEMU/20190228145624.24885-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190228145624.24885-1-peter.mayd...@linaro.org
Subject: [Qemu-devel] [PATCH v2 00/11] Enable bui
On Mon, 25 Feb 2019 09:25:30 +0800
Wei Yang wrote:
> All the example code are indented with four spaces except this one.
>
> Fix this by adding four spaces here.
>
> Signed-off-by: Wei Yang
> Reviewed-by: Eric Blake
> Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
> ---
>
On 2/28/19 9:06 AM, Greg Kurz wrote:
> Build fails with gcc 9:
>
> crypto/block-luks.c:689:18: error: taking address of packed member of ‘struct
> QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
> [-Werror=address-of-packed-member]
> 689 | be32_to_cpus(&luks->header.payloa
Build fails with gcc 9:
crypto/block-luks.c:689:18: error: taking address of packed member of ‘struct
QCryptoBlockLUKSHeader’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
689 | be32_to_cpus(&luks->header.payload_offset);
| ^
This patch implements the machine class kvm_type() callback.
It returns the number of bits requested to implement the whole GPA
range including the RAM and IO regions located beyond.
The returned value in passed though the KVM_CREATE_VM ioctl and
this allows KVM to set the stage2 tables dynamically
In the prospect to introduce an extended memory map supporting more
RAM, let's split the memory map array into two parts:
- the former a15memmap, renamed base_memmap, contains regions below
and including the RAM. MemMapEntries initialized in this array
have a static size and base address.
- ex
This series aims to bump the 255GB RAM limit in machvirt and paves the
way to device memory addition.
In machvirt versions < 4.0, the initial RAM starts at 1GB and can
grow up to 255GB. From 256GB onwards we find IO regions such as the
additional GICv3 RDIST region, high PCIe ECAM region and high
Apologies. I started writing this response several days ago but got busy.
> On Feb 26, 2019, at 11:56, Richard Henderson
> wrote:
>
> I am happy to have proper segmentation support upstream, but having read
> through your patch I think I would approach it differently: I would
> incorporate
> s
101 - 200 of 366 matches
Mail list logo
