Re: [Qemu-devel] [PATCH 19/26] target/sparc: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
On 4/3/19 10:43 AM, Richard Henderson wrote: > Cc: Artyom Tarasenko > Cc: Mark Cave-Ayland > Signed-off-by: Richard Henderson > --- > target/sparc/cpu.h | 5 +- > target/sparc/cpu.c | 5 +- > target/sparc/ldst_helper.c | 15 > target/sparc/mmu_helper.c | 175 +

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote: >>Wei Yang writes: > > [...] > > > @@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char > **argv, > > static MachineClass *select_machine(void) > { > -

Re: [Qemu-devel] [Qemu-arm] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill

2019-04-02 Thread Peter Maydell
On Wed, 3 Apr 2019 at 10:44, Richard Henderson wrote: > +bool arm_cpu_tlb_fill(CPUState *cs, vaddr address, int size, > + MMUAccessType access_type, int mmu_idx, > + bool probe, uintptr_t retaddr) > +{ > +ARMCPU *cpu = ARM_CPU(cs); > + > +#ifdef CONFI

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Peter Maydell
On Wed, 3 Apr 2019 at 11:52, Tommy Jin wrote: > That command line option doesn't work for boston, although I didn't get any > obvious error, no Ethernet card appears either. Does the guest kernel find the PCI device (eg appears in kernel bootup messages, appears in 'lspci' output)? It's worth do

Re: [Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host

2019-04-02 Thread Peter Maydell
On Wed, 3 Apr 2019 at 10:46, Richard Henderson wrote: > > For this combination, we can tell whether or not the address > being accessed is within the 4GB range that is accessible by > the guest. Otherwise the fault must be elsewhere in qemu, > accessing qemu data structures. > > Signed-off-by: Ri

Re: [Qemu-devel] [PATCH] Adds virtio_net as the default netcard for mips boston board.

2019-04-02 Thread Tommy Jin
Hi Peter, That command line option doesn't work for boston, although I didn't get any obvious error, no Ethernet card appears either. Where can I get that arm image/command which can work well for you with " -netdev user,id=mynet -device virtio-net-pci,netdev=mynet" ? Anyway, if that command

[Qemu-devel] [PATCH 24/26] tcg: Use CPUClass::tlb_fill in cputlb.c

2019-04-02 Thread Richard Henderson
We can now use the CPUClass hook instead of a named function. Create a static tlb_fill function to avoid other changes within cputlb.c. This also which also isolates the asserts implied. Remove the named tlb_fill function from all of the targets. Signed-off-by: Richard Henderson --- include/ex

[Qemu-devel] [PATCH 26/26] tcg: Use tlb_fill probe from tlb_vaddr_to_host

2019-04-02 Thread Richard Henderson
Most of the existing users would continue around a loop which would fault the tlb entry in via a normal load/store. But for SVE we have a true non-faulting case which requires the new probing form of tlb_fill. Signed-off-by: Richard Henderson --- include/exec/cpu_ldst.h | 40 ---

[Qemu-devel] [PATCH 25/26] tcg: Remove CPUClass::handle_mmu_fault

2019-04-02 Thread Richard Henderson
This hook is now completely replaced by tlb_fill. Signed-off-by: Richard Henderson --- include/qom/cpu.h | 3 --- accel/tcg/user-exec.c | 13 +++-- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 7e96a0aed3..8afcf0c427 1006

[Qemu-devel] [PATCH 20/26] target/tilegx: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/tilegx/cpu.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/tilegx/cpu.c b/target/tilegx/cpu.c index bfe9be59b5..be50976c6f 100644 --- a/target/tilegx/cpu.c +++ b/target/tilegx/cpu.c @@ -24,6 +24,8 @@ #include "q

[Qemu-devel] [PATCH 17/26] target/s390x: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: qemu-s3...@nongnu.org Cc: Cornelia Huck Cc: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/internal.h| 5 +- target/s390x/cpu.c | 5 +- target/s390x/excp_helper.c | 156 + target/s390x/mem_helper.c | 29 --- 4 fi

[Qemu-devel] [PATCH 18/26] target/sh4: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Aurelien Jarno Signed-off-by: Richard Henderson --- target/sh4/cpu.h | 5 +- target/sh4/cpu.c | 5 +- target/sh4/helper.c| 197 - target/sh4/op_helper.c | 12 --- 4 files changed, 101 insertions(+), 118 deletions(-) diff --git a/t

[Qemu-devel] [PATCH 23/26] target/xtensa: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Max Filippov Signed-off-by: Richard Henderson --- target/xtensa/cpu.h| 5 +-- target/xtensa/cpu.c| 5 ++- target/xtensa/helper.c | 74 +- 3 files changed, 42 insertions(+), 42 deletions(-) diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu

[Qemu-devel] [PATCH 16/26] target/riscv: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Note that env->pc is removed from the qemu_log as that value is garbage. The PC isn't recovered until cpu_restore_state, called from cpu_loop_exit_restore, called from riscv_raise_exception. Cc: qemu-ri...@nongnu.org Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH 21/26] target/tricore: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Bastian Koppelmann Signed-off-by: Richard Henderson --- target/tricore/cpu.h | 6 +++--- target/tricore/cpu.c | 1 + target/tricore/helper.c| 27 +++ target/tricore/op_helper.c | 26 -- 4 files changed, 23 insertions(+), 37 de

[Qemu-devel] [PATCH 11/26] target/mips: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Note that env->active_tc.PC is removed from the qemu_log as that value is garbage. The PC isn't recovered until cpu_restore_state, called from cpu_loop_exit_restore, called from do_raise_exception_err. Cc: Aleksandar Markovic Cc: Aleksandar Rikalo Signed-off-by: Richard Henderson --- target/m

[Qemu-devel] [PATCH 22/26] target/unicore32: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Guan Xuetao Signed-off-by: Richard Henderson --- target/unicore32/cpu.h | 5 +++-- target/unicore32/cpu.c | 5 + target/unicore32/helper.c| 23 --- target/unicore32/op_helper.c | 14 -- target/unicore32/softmmu.c | 19 +++---

[Qemu-devel] [PATCH 09/26] target/m68k: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 5 ++- target/m68k/cpu.c | 2 +- target/m68k/helper.c| 87 ++--- target/m68k/op_helper.c | 15 --- 4 files changed, 50 insertions(+), 59 deletions(-) diff --git

[Qemu-devel] [PATCH 19/26] target/sparc: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Artyom Tarasenko Cc: Mark Cave-Ayland Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 5 +- target/sparc/cpu.c | 5 +- target/sparc/ldst_helper.c | 15 target/sparc/mmu_helper.c | 175 +++-- 4 files changed, 93 insertions(

[Qemu-devel] [PATCH 13/26] target/nios2: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Chris Wulff Cc: Marek Vasut Signed-off-by: Richard Henderson --- target/nios2/cpu.h| 5 +- target/nios2/cpu.c| 5 +- target/nios2/helper.c | 181 -- target/nios2/mmu.c| 12 --- 4 files changed, 92 insertions(+), 111 deletions(-) diff

[Qemu-devel] [PATCH 14/26] target/openrisc: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Stafford Horne Signed-off-by: Richard Henderson --- target/openrisc/cpu.h | 5 ++-- target/openrisc/cpu.c | 5 ++-- target/openrisc/mmu.c | 65 ++- 3 files changed, 39 insertions(+), 36 deletions(-) diff --git a/target/openrisc/cpu.h b/target/openri

[Qemu-devel] [PATCH 15/26] target/ppc: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: qemu-...@nongnu.org Cc: David Gibson Signed-off-by: Richard Henderson --- target/ppc/cpu.h| 7 +++ target/ppc/mmu_helper.c | 19 +-- target/ppc/translate_init.inc.c | 5 ++--- target/ppc/user_only_helper.c | 14 -- 4 files changed,

[Qemu-devel] [PATCH 10/26] target/microblaze: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 5 +- target/microblaze/cpu.c | 5 +- target/microblaze/helper.c| 142 +- target/microblaze/op_helper.c | 19 - 4 files changed, 78 insertions(+), 93 dele

[Qemu-devel] [PATCH 08/26] target/lm32: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Michael Walle Signed-off-by: Richard Henderson --- target/lm32/cpu.h | 5 +++-- target/lm32/cpu.c | 5 ++--- target/lm32/helper.c| 12 +--- target/lm32/op_helper.c | 16 4 files changed, 14 insertions(+), 24 deletions(-) diff --git a/target/lm32/cp

[Qemu-devel] [PATCH 12/26] target/moxie: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Anthony Green Signed-off-by: Richard Henderson --- target/moxie/cpu.h| 5 ++-- target/moxie/cpu.c| 5 ++-- target/moxie/helper.c | 61 ++- 3 files changed, 19 insertions(+), 52 deletions(-) diff --git a/target/moxie/cpu.h b/target/moxie/cpu.

[Qemu-devel] [PATCH 06/26] target/hppa: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 8 target/hppa/cpu.c| 5 ++--- target/hppa/mem_helper.c | 22 +- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index c062c7969c..e0e5d879

[Qemu-devel] [PATCH 07/26] target/i386: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
We do not support probing, but we do not need it yet either. Cc: Paolo Bonzini Cc: Eduardo Habkost Signed-off-by: Richard Henderson --- target/i386/cpu.h | 5 ++-- target/i386/cpu.c | 5 ++-- target/i386/excp_helper.c | 61 +-- target/i386/

[Qemu-devel] [PATCH 02/26] tcg: Add CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
This hook will replace the (user-only mode specific) handle_mmu_fault hook, and the (system mode specific) tlb_fill function. The handle_mmu_fault hook was written as if there was a valid way to recover from an mmu fault, and had 3 possible return states. In reality, the only valid action is to ra

[Qemu-devel] [PATCH 03/26] target/alpha: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/cpu.h| 5 ++-- target/alpha/cpu.c| 5 ++-- target/alpha/helper.c | 50 +++ target/alpha/mem_helper.c | 16 - 4 files changed, 35 insertions(+), 41 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH 04/26] target/arm: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/arm/internals.h | 10 +++-- target/arm/cpu.c | 22 +- target/arm/helper.c| 97 ++ target/arm/op_helper.c | 29 ++--- 4 files changed, 72 insertions(+), 86 deletion

[Qemu-devel] [PATCH 01/26] tcg: Assert h2g_valid for 32-bit guest on 64-bit host

2019-04-02 Thread Richard Henderson
For this combination, we can tell whether or not the address being accessed is within the 4GB range that is accessible by the guest. Otherwise the fault must be elsewhere in qemu, accessing qemu data structures. Signed-off-by: Richard Henderson --- accel/tcg/user-exec.c | 9 + 1 file ch

[Qemu-devel] [PATCH 00/26] tcg: Add CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
There is currently a lot of confusion between foo_cpu_handle_mmu_fault and tlb_fill. In particular, foo_cpu_handle_mmu_fault was only defined for user-only, and its only valid action was to set up the cpu for cpu_loop_exit so that we can deliver a SIGSEGV to the guest. And yet, we had code that t

[Qemu-devel] [PATCH 05/26] target/cris: Convert to CPUClass::tlb_fill

2019-04-02 Thread Richard Henderson
Cc: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target/cris/cpu.h | 5 +-- target/cris/cpu.c | 5 ++- target/cris/helper.c| 67 +++-- target/cris/op_helper.c | 28 - 4 files changed, 42 insertions(+), 63 deletions(-

[Qemu-devel] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources

2019-04-02 Thread Eric Blake
In commit 0c1d50bd, I added a couple of TODO comments about whether we consult bl.request_alignment when responding to NBD_OPT_INFO. At the time, qemu as server was hard-coding an advertised alignment of 512 to clients that promised to obey constraints, and there was no function for getting at a de

[Qemu-devel] [PATCH 1/7] nbd/server: Fix blockstatus trace

2019-04-02 Thread Eric Blake
Don't increment remaining_bytes until we know that we will actually be including the current block status extent in the reply; otherwise, the value traced will include a bytes value that is oversized by the length of the next block status extent which did not get sent because it instead ended the l

[Qemu-devel] [PATCH 5/7] block: Fix BDRV_BLOCK_RAW status to honor alignment

2019-04-02 Thread Eric Blake
Previous patches mentioned how the blkdebug filter driver demonstrates a bug present in our NBD server; the bug is also present with the raw format driver when probing occurs. Basically, if we specify a particular alignment > 1, but defer the actual block status to the underlying file, and the unde

[Qemu-devel] [PATCH 6/7] nbd/server: Avoid unaligned read/block_status from backing

2019-04-02 Thread Eric Blake
The NBD server code used bdrv_block_status_above() to determine where to fragment structured read and block status replies. However, the protocol can only advertise the active layer's minimum block size; if the active layer is backed by another file with smaller alignment, then we can end up leaki

[Qemu-devel] [PATCH for-4.1 7/7] nbd/server: Avoid unaligned dirty-bitmap status

2019-04-02 Thread Eric Blake
The NBD spec requires that responses to NBD_CMD_BLOCK_STATUS be aligned to the server's advertised min_block alignment, if the client agreed to abide by alignments. In general, since dirty bitmap granularity cannot go below 512, and it is hard to provoke qcow2 to go above an alignment of 512, this

[Qemu-devel] [PATCH 2/7] nbd/server: Trace server noncompliance on unaligned requests

2019-04-02 Thread Eric Blake
We've recently added traces for clients to flag server non-compliance; let's do the same for servers to flag client non-compliance. According to the spec, if the client requests NBD_INFO_BLOCK_SIZE, it is promising to send all requests aligned to those boundaries. Of course, if the client does not

[Qemu-devel] [PATCH 4/7] iotests: Update 241 to expose backing layer fragmentation

2019-04-02 Thread Eric Blake
Previous commits have mentioned that our NBD server still sends unaligned fragments when an active layer with large advertised minimum block size is backed by another layer with a smaller block size. Expand the test to actually cover this scenario, by using qcow2 encryption (which forces 512-byte a

[Qemu-devel] [PATCH for-4.0? 0/7] Final round of NBD alignment fixes

2019-04-02 Thread Eric Blake
My recent pull request for -rc2 documented several places where our server still does not comply with the NBD specification with regards to alignment. This series finishes the work in making everything compliant, insofar as I could test. The first three patches are rather trivial - they don't driv

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-02 Thread Peter Xu
On Tue, Apr 02, 2019 at 03:41:10PM +, Elijah Shakkour wrote: > > > > -Original Message- > > From: Knut Omang > > Sent: Monday, April 1, 2019 5:24 PM > > To: Elijah Shakkour ; Peter Xu > > > > Cc: Michael S. Tsirkin ; Alex Williamson > > ; Marcel Apfelbaum > > ; Stefan Hajnoczi ; > >

Re: [Qemu-devel] [PATCH v2] migration: avoid filling ignore-shared ramblock when in incoming migration

2019-04-02 Thread Peter Xu
On Tue, Apr 02, 2019 at 11:30:01AM -0400, Catherine Ho wrote: > Commit 18269069c310 ("migration: Introduce ignore-shared capability") > addes ignore-shared capability to bypass the shared ramblock (e,g, > membackend + numa node). It does good to live migration. > > This commit expectes that QEMU d

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field

2019-04-02 Thread Zhang, Chen
> -Original Message- > From: John Snow [mailto:js...@redhat.com] > Sent: Wednesday, April 3, 2019 5:07 AM > To: Zhang, Chen ; Laurent Vivier ; > qemu-dev ; Fam Zheng > Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap > file to related field > > > > On 3/29/19 4:20

Re: [Qemu-devel] [RFC for-4.1 5/5] pcie: Simplify pci_adjust_config_limit()

2019-04-02 Thread David Gibson
On Tue, Apr 02, 2019 at 03:53:05PM +0200, Greg Kurz wrote: > On Tue, 2 Apr 2019 16:40:28 +1100 > David Gibson wrote: > > > Since c2077e2c "pci: Adjust PCI config limit based on bus topology", > > pci_adjust_config_limit() has been used in the config space read and write > > paths to only permit

[Qemu-devel] [PATCH v2] vmstate: check subsection_found is enough

2019-04-02 Thread Wei Yang
subsection_found is true implies vmdesc is not NULL. This patch remove the additional check on vmdesc and rename subsection_found to vmdesc_has_subsections to make it more self-explain. Signed-off-by: Wei Yang --- v2: * rename it to vmdesc_has_subsections --- migration/vmstate.c | 8

Re: [Qemu-devel] [PATCH] vmstate: check subsection_found is enough

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 07:44:23PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> subsection_found is true implies vmdesc is not NULL. >> >> Signed-off-by: Wei Yang >> --- >> migration/vmstate.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote: >Wei Yang writes: [...] @@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char **argv, static MachineClass *select_machine(void) { -MachineClass *machine_class = fin

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Peter Maydell
On Wed, 3 Apr 2019 at 02:16, Eduardo Habkost wrote: > > On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote: > > One wrinkle to watch out for is code paths that are used in the > > linux-user emulator, where there is no machine at all... For instance > > cpu_common_realizefn() handles th

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" wrote: > > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVEV, using directly Use full instruction names, with the only exception of possible Bachus-Naur forms... again. > tcg registers and performing logic on them instead of > using h

Re: [Qemu-devel] [PULL 10/14] nbd/client: Reject inaccessible tail of inconsistent server

2019-04-02 Thread Eric Blake
On 4/1/19 9:08 AM, Eric Blake wrote: > The NBD spec suggests that a server should never advertise a size > inconsistent with its minimum block alignment, as that tail is > effectively inaccessible to a compliant client obeying those block > constraints. Since we have a habit of rounding up rather t

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
On Apr 2, 2019 5:20 PM, "Mateja Marjanovic" wrote: > > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVEV, using directly > tcg registers and performing logic on them instead of > using helpers. > > In the following table, the first column is the performance > before this patch. T

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add unmaintained bitmap file to related field

2019-04-02 Thread John Snow
On 3/29/19 4:20 PM, Zhang Chen wrote: > From: Zhang Chen > > Add bitmap.h and bitops.h to Dirty Bitmaps field. > > Signed-off-by: Zhang Chen > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 56139ac8ab..360af3e8ca 100644 > ---

Re: [Qemu-devel] [PATCH v4 5/5] target/mips: Refactor and fix INSERT. instructions

2019-04-02 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v4 5/5] target/mips: Refactor and fix INSERT. > instructions > > From: Mateja Marjanovic > > The old version of the helper for the INSERT. MSA instructions > has been replaced with four helpers that don't use switch, and change > the endianness of th

Re: [Qemu-devel] [PATCH v4 2/5] target/mips: Fix MSA instructions ST. on big endian host

2019-04-02 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v4 2/5] target/mips: Fix MSA instructions ST. on big > endian host > > From: Mateja Marjanovic > > Fix the case when the host is a big endian machine, and change > the approach toward ST. instruction helpers. > > Signed-off-by: Mateja Marjanovic > ---

Re: [Qemu-devel] [PATCH v4 1/5] target/mips: Fix MSA instructions LD. on big endian host

2019-04-02 Thread Aleksandar Markovic
> From: Mateja Marjanovic > Subject: [PATCH v4 1/5] target/mips: Fix MSA instructions LD. on big > endian host > > From: Mateja Marjanovic > > Fix the case when the host is a big endian machine, and change > the approach toward LD. instruction helpers. > > Signed-off-by: Mateja Marjanovic > ---

Re: [Qemu-devel] [PATCH v3] s390: diagnose 318 info reset and migration support

2019-04-02 Thread Collin Walling
On 4/1/19 5:48 PM, Collin Walling wrote: [...] --- This version is posted in tandem with a new kernel patch that changes how the execution of the diag 0x318 instruction is handled. A link to this series will be attached as a reply to this series for convenience. https://www.spinics.net/list

Re: [Qemu-devel] [PATCH v2] target/mips: add * to comments and realign them to fix checkpatch warnings

2019-04-02 Thread Aleksandar Markovic
> From: Jules Irenge > Subject: [PATCH v2] target/mips: add * to comments and realign them to fix > checkpatch warnings > > Add * to comments and realign to fix warnings issued by checkpatch.pl tool > "WARNING: Block comments use a leading /* on a separate line" > within the file "target/mips/cp

Re: [Qemu-devel] [PATCH 0/3] acpi: More trace points

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 6:18 PM, Markus Armbruster wrote: > I wrote these patches to help me debug an unplug failure. I expect > them to be helpful for others, too. Appreciated. FYI I have a WiP branch where I use existing tracepoints to check events order and timing (using Avocado). Series: Reviewed-by: Phi

Re: [Qemu-devel] [PATCH v3 4/8] Extend the command-line to provide memory latency and bandwidth information

2019-04-02 Thread Eduardo Habkost
On Tue, Apr 02, 2019 at 11:46:37AM +0200, Igor Mammedov wrote: > On Tue, 2 Apr 2019 12:42:37 +0800 > Tao Xu wrote: > > > On 2/6/19 6:11 PM, Igor Mammedov wrote: > > > On Thu, 31 Jan 2019 15:16:54 +0800 > > > Tao Xu wrote: > > > > > >> From: Liu Jingqi > > >> > > >> Add -numa hmat-lb option t

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Eduardo Habkost
On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote: > On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote: > > > > Igor Mammedov writes: > > > maybe we can assert in qdev_get_machine() if machine hasn't been created > > > yet? > > > with this at least it will be hard to misuse functi

Re: [Qemu-devel] [PATCH v3 4/8] Extend the command-line to provide memory latency and bandwidth information

2019-04-02 Thread Eduardo Habkost
On Wed, Feb 06, 2019 at 11:11:24AM +0100, Igor Mammedov wrote: > On Thu, 31 Jan 2019 15:16:54 +0800 > Tao Xu wrote: > > > From: Liu Jingqi > > > > Add -numa hmat-lb option to provide System Locality Latency and > > Bandwidth Information. These memory attributes help to build > > System Locality

[Qemu-devel] [ANNOUNCE] QEMU 4.0.0-rc2 is now available

2019-04-02 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 4.0 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-4.0.0-rc2.tar.xz http://downl

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
> +/* > + * [MSA] ILVEV.D wd, ws, wt > + * > + * Vector Interleave Even (Double data elements) > + * > + */ Double -> Doubleword

Re: [Qemu-devel] [PATCH] vmstate: check subsection_found is enough

2019-04-02 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > subsection_found is true implies vmdesc is not NULL. > > Signed-off-by: Wei Yang > --- > migration/vmstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/vmstate.c b/migration/vmstate.c > index e2bbb7b5f7.

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Philippe Mathieu-Daudé
On 4/2/19 7:07 PM, Aleksandar Markovic wrote: >> From: Philippe Mathieu-Daudé >> Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize >> ILVEV. MSA instructions >> >> Hi Mateja, >> >> On 4/2/19 5:15 PM, Mateja Marjanovic wrote: >>> From: Mateja Marjanovic >>> >>> Optimize set of MSA in

[Qemu-devel] [Bug 1815889] Re: qemu-system-x86_64 crashed with signal 31 in __pthread_setaffinity_new()

2019-04-02 Thread Daniel Berrange
FYI the QEMU change merged in the following pull request changed to return an EPERM errno for the thread affinity syscalls: commit 12f067cc14b90aef60b2b7d03e1df74cc50a0459 Merge: 84bdc58c06 035121d23a Author: Peter Maydell Date: Thu Mar 28 12:04:52 2019 + Merge remote-tracking branch '

Re: [Qemu-devel] [PATCH] migration: avoid copying ignore-shared ramblock when in incoming migration

2019-04-02 Thread Dr. David Alan Gilbert
* Catherine Ho (catherine.h...@gmail.com) wrote: > On Tue, 2 Apr 2019 at 20:37, Peter Xu wrote: > > > On Tue, Apr 02, 2019 at 05:06:15PM +0800, Catherine Ho wrote: > > > On Tue, 2 Apr 2019 at 15:58, Peter Xu wrote: > > > > > > > On Tue, Apr 02, 2019 at 03:47:16PM +0800, Catherine Ho wrote: > > >

[Qemu-devel] [Bug 1815889]

2019-04-02 Thread Marek Olšák
(In reply to Michel Dänzer from comment #8) > Mesa doesn't really need explicit thread affinity at all. All it wants is > that certain sets of threads run on the same CPU module; it doesn't care > which particular CPU module that is. What's really needed is an API to > express this affinity between

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Aleksandar Markovic
> From: Philippe Mathieu-Daudé > Subject: Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize > ILVEV. MSA instructions > > Hi Mateja, > > On 4/2/19 5:15 PM, Mateja Marjanovic wrote: > > From: Mateja Marjanovic > > > > Optimize set of MSA instructions ILVEV, using directly > > tcg registers an

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote: > > Igor Mammedov writes: > > maybe we can assert in qdev_get_machine() if machine hasn't been created > > yet? > > with this at least it will be hard to misuse function or catch invalid > > users. > > (but it still might miss some use cases

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/97] Patch Round-up for stable 3.0.1, freeze on 2019-04-08

2019-04-02 Thread Cole Robinson
On 4/1/19 4:58 PM, Michael Roth wrote: > Hi everyone, > > > The following new patches are queued for QEMU stable v3.0.1: > > https://github.com/mdroth/qemu/commits/stable-3.0-staging > > The release

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-02 Thread Paolo Bonzini
On 02/04/19 18:18, Kevin Wolf wrote: > Am 26.03.2019 um 15:11 hat Paolo Bonzini geschrieben: >> - but actually (and a precursor to using IOCB_CMD_POLL) it should be >> possible to have just one LinuxAioState per AioContext, and then >> it can simply share the AioContext's EventNotifier. This remov

[Qemu-devel] [PATCH 3/3] acpi/pcihp: Add a few more trace points related to unplug

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/pcihp.c | 7 +++ hw/acpi/trace-events | 3 +++ 2 files changed, 10 insertions(+) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 7729c5338b..613406d09b 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -152,6 +152,8 @@ static void ac

Re: [Qemu-devel] [PATCH v5 2/2] target/mips: Optimize ILVEV. MSA instructions

2019-04-02 Thread Philippe Mathieu-Daudé
Hi Mateja, On 4/2/19 5:15 PM, Mateja Marjanovic wrote: > From: Mateja Marjanovic > > Optimize set of MSA instructions ILVEV, using directly > tcg registers and performing logic on them instead of > using helpers. Maybe you can still let this previous comment (if still valid): Performance mea

[Qemu-devel] [PATCH 2/3] acpi/pcihp: Convert debug printf()s to trace events

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/pcihp.c | 25 - hw/acpi/trace-events | 9 + 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 88e4ae1bcd..7729c5338b 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi

[Qemu-devel] [PATCH 1/3] acpi/piix4: Convert debug printf()s to trace events

2019-04-02 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/acpi/piix4.c | 14 +++--- hw/acpi/trace-events | 4 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 9c079d6834..546ba036ed 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -39,1

[Qemu-devel] [PATCH 0/3] acpi: More trace points

2019-04-02 Thread Markus Armbruster
I wrote these patches to help me debug an unplug failure. I expect them to be helpful for others, too. Markus Armbruster (3): acpi/piix4: Convert debug printf()s to trace events acpi/pcihp: Convert debug printf()s to trace events acpi/pcihp: Add a few more trace points related to unplug h

Re: [Qemu-devel] QEMU event loop optimizations

2019-04-02 Thread Kevin Wolf
Am 26.03.2019 um 15:11 hat Paolo Bonzini geschrieben: > - but actually (and a precursor to using IOCB_CMD_POLL) it should be > possible to have just one LinuxAioState per AioContext, and then > it can simply share the AioContext's EventNotifier. This removes > the need to do the event_notifier_tes

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Cornelia Huck
On Tue, 2 Apr 2019 18:05:15 +0200 Thomas Huth wrote: > On 02/04/2019 18.00, Cornelia Huck wrote: > > On Fri, 29 Mar 2019 11:11:01 + > > Daniel P. Berrangé wrote: > > > >> The GCC 9 compiler complains about many places in s390 code > >> that take the address of members of the 'struct SCHIB

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Markus Armbruster
Igor Mammedov writes: > On Tue, 2 Apr 2019 21:09:39 +0800 > Like Xu wrote: > >> On 2019/4/2 19:27, Markus Armbruster wrote: >> > Like Xu writes: >> > >> >> This patch makes the remaining dozen or so uses of the global >> >> current_machine outside vl.c use qdev_get_machine() instead, >> >> a

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 03:28:48PM +0200, Markus Armbruster wrote: >>Wei Yang writes: >> >>> Now all the functions used to select machine is local and the call flow >>> looks like below: >>> >>> select_machine() >>> find_default_machine() >>> machine_parse(

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Daniel P . Berrangé
On Tue, Apr 02, 2019 at 06:00:33PM +0200, Cornelia Huck wrote: > On Fri, 29 Mar 2019 11:11:01 + > Daniel P. Berrangé wrote: > > > The GCC 9 compiler complains about many places in s390 code > > that take the address of members of the 'struct SCHIB' which > > is marked packed: > > > > hw/vfio

Re: [Qemu-devel] Block format 'raw' does not support the option 'share-rw'

2019-04-02 Thread Kevin Wolf
Am 28.03.2019 um 21:48 hat Michal Suchánek geschrieben: > On Thu, 28 Mar 2019 16:56:48 +0100 > Michal Suchánek wrote: > > > Hello, > > > > I tried to update my machine definitions to work with current qemu. > > > > Unfortunately, while qemu 2.11 supports disk sharing with raw images > > qemu 3.

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Laszlo, On 4/2/19 5:52 PM, Laszlo Ersek wrote: > On 04/02/19 17:42, Auger Eric wrote: >> Hi Laszlo, >> >> On 4/2/19 12:33 PM, Laszlo Ersek wrote: >>> On 04/02/19 09:42, Igor Mammedov wrote: On Mon, 1 Apr 2019 15:07:05 +0200 Laszlo Ersek wrote: > On 03/29/19 14:56, Auger Eric wr

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Thomas Huth
On 02/04/2019 18.00, Cornelia Huck wrote: > On Fri, 29 Mar 2019 11:11:01 + > Daniel P. Berrangé wrote: > >> The GCC 9 compiler complains about many places in s390 code >> that take the address of members of the 'struct SCHIB' which >> is marked packed: >> >> hw/vfio/ccw.c: In function ‘vfio_c

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Cornelia Huck
On Fri, 29 Mar 2019 11:11:01 + Daniel P. Berrangé wrote: > The GCC 9 compiler complains about many places in s390 code > that take the address of members of the 'struct SCHIB' which > is marked packed: > > hw/vfio/ccw.c: In function ‘vfio_ccw_io_notifier_handler’: > hw/vfio/ccw.c:133:15: war

Re: [Qemu-devel] [PULL v2 0/8] Miscellaneous patches for 2019-04-02

2019-04-02 Thread Peter Maydell
On Tue, 2 Apr 2019 at 22:10, Markus Armbruster wrote: > > The following changes since commit d61d1a1fb2f1db6c54651844a28389c523f3f8c7: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20190402-pull-request' into staging (2019-04-02 > 08:18:24 +0100)

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:52, Laszlo Ersek wrote: > On 04/02/19 17:42, Auger Eric wrote: > The firmware does consume DT: > > - If you start QEMU *with* "-no-acpi", then the DT is both consumed by > the firmware (for its own information needs), and passed on to the OS. > > - If you sta

Re: [Qemu-devel] [PATCH v2] vl.c: make current_machine as non-global variable

2019-04-02 Thread Igor Mammedov
On Tue, 2 Apr 2019 21:09:39 +0800 Like Xu wrote: > On 2019/4/2 19:27, Markus Armbruster wrote: > > Like Xu writes: > > > >> This patch makes the remaining dozen or so uses of the global > >> current_machine outside vl.c use qdev_get_machine() instead, > >> and then make current_machine local

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Hi Laszlo, On 4/2/19 12:33 PM, Laszlo Ersek wrote: > On 04/02/19 09:42, Igor Mammedov wrote: >> On Mon, 1 Apr 2019 15:07:05 +0200 >> Laszlo Ersek wrote: >> >>> On 03/29/19 14:56, Auger Eric wrote: Hi Ard, On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 14:1

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:42, Auger Eric wrote: > Hi Laszlo, > > On 4/2/19 12:33 PM, Laszlo Ersek wrote: >> On 04/02/19 09:42, Igor Mammedov wrote: >>> On Mon, 1 Apr 2019 15:07:05 +0200 >>> Laszlo Ersek wrote: >>> On 03/29/19 14:56, Auger Eric wrote: > Hi Ard, > > On 3/29/19 2:14 PM, Ard Bi

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Auger Eric
Laszlo, On 4/2/19 5:38 PM, Laszlo Ersek wrote: > On 04/02/19 17:29, Auger Eric wrote: >> Hi Laszlo, >> >> On 4/1/19 3:07 PM, Laszlo Ersek wrote: >>> On 03/29/19 14:56, Auger Eric wrote: Hi Ard, On 3/29/19 2:14 PM, Ard Biesheuvel wrote: > On Fri, 29 Mar 2019 at 14:12, Auger Eric

[Qemu-devel] [PATCH v5 10/10] qcow2: do encryption in threads

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Do encryption/decryption in threads, like it is already done for compression. This improves asynchronous encrypted io. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 8 ++ block/qcow2-cluster.c | 7 ++--- block/qcow2-threads.c | 65

Re: [Qemu-devel] QEMU and vIOMMU support for emulated VF passthrough to nested (L2) VM

2019-04-02 Thread Elijah Shakkour
> -Original Message- > From: Knut Omang > Sent: Monday, April 1, 2019 5:24 PM > To: Elijah Shakkour ; Peter Xu > > Cc: Michael S. Tsirkin ; Alex Williamson > ; Marcel Apfelbaum > ; Stefan Hajnoczi ; > qemu-devel@nongnu.org > Subject: Re: QEMU and vIOMMU support for emulated VF passthrou

[Qemu-devel] [PATCH v5 03/10] qcow2: add separate file for threaded data processing functions

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Move compression-on-threads to separate file. Encryption will be in it too. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 7 ++ block/qcow2-threads.c | 201 ++ block/qcow2.c | 169 ---

Re: [Qemu-devel] [PATCH v3 07/10] hw/arm/virt: Introduce opt-in feature "fdt"

2019-04-02 Thread Laszlo Ersek
On 04/02/19 17:29, Auger Eric wrote: > Hi Laszlo, > > On 4/1/19 3:07 PM, Laszlo Ersek wrote: >> On 03/29/19 14:56, Auger Eric wrote: >>> Hi Ard, >>> >>> On 3/29/19 2:14 PM, Ard Biesheuvel wrote: On Fri, 29 Mar 2019 at 14:12, Auger Eric wrote: > > Hi Shameer, > > On 3/29/19 10

[Qemu-devel] [PATCH v5 07/10] qcow2: qcow2_co_preadv: improve locking

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Background: decryption will be done in threads, to take benefit of it, we should move it out of the lock first. But let's go further: it turns out, that for locking around switch cases we have only two variants: when we just do memset(0) not releasing the lock (it is useless) and when we actually

[Qemu-devel] [PATCH v5 06/10] qcow2-threads: split out generic path

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
Move generic part out of qcow2_co_do_compress, to reuse it for encryption and rename things that would be shared with encryption path. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 4 ++-- block/qcow2-threads.c | 47

[Qemu-devel] [PATCH v5 02/10] qcow2.h: add missing include

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
qcow2.h depends on block_int.h. Compilation isn't broken currently only due to block_int.h always included before qcow2.h. Though, it seems better to directly include block_int.h in qcow2.h. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia --- block/qcow2.h | 1 +

  1   2   3   >