[PATCH] x86: Check for machine state object class before typecasting it

In v4.2.0-246-ged9e923c3c the SMM property was moved from PC machine class to x86 machine class. Makes sense, but the change was too aggressive: in target/i386/kvm.c:kvm_arch_init() it altered check which sets SMRAM if given machine has SMM enabled. The line that detects whether given machine objec

Re: [PATCH] x86: Check for machine state object class before typecasting it

Patchew URL: https://patchew.org/QEMU/7cc91bab3191bfd7e071bdd3fdf7fe2a2991deb0.1577692822.git.mpriv...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it l

Re: [Qemu-devel] [PATCH] RISCV: support riscv vector extension 0.7.1

On 2019/12/28 9:14, Richard Henderson wrote: On 12/25/19 8:36 PM, LIU Zhiwei wrote: struct {     uint64_t vreg[32 * RV_VLEN_MAX / 64] QEMU_ALIGNED(16);     target_ulong vxrm;     target_ulong vxsat;     target_ulong vl;     target_ulong vstart;     target_ulong

[PATCH] scripts/git.orderfile: Display decodetree before C source

To avoid scrolling each instruction when reviewing tcg helpers written for the decodetree script, display the .decode files (similar to header declarations) before the C source (implementation of previous declarations). Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 3 +++ 1 f

[Bug 1857449] Re: QEMU x86_64 -nographic full system breaks host Bash terminal line wrapping state after simulation ends, requires reset or "tput smam" to fix it

Ah, thanks for looking into this and identifying it to guest code Philippe. I don't know much about terminals, but yes, they are such archaic interfaces, maybe there is no API for it :-( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH] 9p: local: fix memory leak

Please describe the memory leak, and if possible how you noticed it. Indeed the previous 2 calls to g_path_get_dirname() aren't free'd. On 12/30/19 3:23 AM, Yan Wang wrote: Signed-off-by: Yan Wang --- hw/9pfs/9p-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. machine class to x86 machine class. Makes sense, but the change was too aggressive: in target/i386/kvm.c:kvm_arch_init() it altered check which

[PATCH 0/2] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list

Noticed we could clean this while reviewing Richard patch last night: https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html Philippe Mathieu-Daudé (2): tcg: Search includes from the project root source directory configure: Remove tcg/ from the preprocessor include search list con

[PATCH 1/2] tcg: Search includes from the project root source directory

We currently search both the root and the tcg/ directories for tcg files: $ git grep '#include "tcg/' | wc -l 28 $ git grep '#include "tcg[^/]' | wc -l 94 To simplify the preprocessor search path, unify by expliciting the tcg/ directory. Patch created mechanically by running: $ for x

[PATCH 2/2] configure: Remove tcg/ from the preprocessor include search list

All tcg includes are relative to the repository root directory, we can safely remove the tcg/ directory from the include search path list. Signed-off-by: Philippe Mathieu-Daudé --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 940bf9e87a..74dad08580 100

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 9:00 AM, Michal Privoznik wrote: >> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC > > Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. This depends on how you format the hash :-) I've used 'git describe ed9e923c3c' because

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 10:35 AM, Michal Prívozník wrote: On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. This depends on how you format the hash :-) I

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé: [...] > tcg/tcg-op.h | 2 +- > tcg/tcg.h | 4 ++-- > tcg/tcg-common.c | 2 +- > tcg/tcg-op-gvec.c | 8 > tcg/tcg-op-vec.c | 6 +++--- > tcg/tcg-op.c

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

Hi Stefan, On 12/30/19 10:53 AM, Stefan Weil wrote: Am 30.12.19 um 10:08 schrieb Philippe Mathieu-Daudé: [...] tcg/tcg-op.h | 2 +- tcg/tcg.h | 4 ++-- tcg/tcg-common.c | 2 +- tcg/tcg-op-gvec.c | 8 tcg/tcg-op-vec.c

Re: PCI memory sync question (kvm,dpdk,e1000,packet stalled)

> It could be a bug in QEMU's e1000 emulation - maybe it's not doing > things in the correct order and causes a race condition with the DPDK > polling driver - or it could be a bug in the DPDK e1000 driver regarding > the order in which the descriptor ring and RX Head/Tail MMIO registers > are upda

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé ha scritto: > > I'd prefer not changing those files. > > OK, I'll wait to see what Richard/Markus prefer. > I think it's best if you keep the include directives as-is for files only needed from tcg/, and move the other headers (those that are need

[PATCH 3/6] hw/arm/allwinner-a10: Move SoC definitions out of header

These definitions are specific to the A10 SoC and don't need to be exported to the different Allwinner peripherals. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/allwinner-a10.h | 6 -- hw/arm/allwinner-a10.c | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) di

[PATCH 0/6] hw/arm/cubieboard: Few cleanups, add acceptance tests

After looking at Niek Linnenbank implementation of the Allwinner H3 [1], I looked what is common in the A10 [2]. Add some tests before modifying the code further. [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg665532.html [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg666809

[PATCH 2/6] tests/boot_linux_console: Add a SD card test for the CubieBoard

The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://docs.armbian.com/Developer-Guide_Build-Preparation/ The cpio image used comes from the linux-build-test project: https://github.com/groeck/linux-build-test If ARM is a target being built, "make check-

[PATCH 1/6] tests/boot_linux_console: Add initrd test for the CubieBoard

This test boots a Linux kernel on a CubieBoard and verify the serial output is working. The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://docs.armbian.com/Developer-Guide_Build-Preparation/ The cpio image used comes from the linux-build-test project:

[PATCH 5/6] hw/arm/allwinner-a10: Remove local qemu_irq variables

We won't reuse the CPU IRQ/FIQ variables. Simplify by calling qdev_get_gpio_in() in place. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/allwinner-a10.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index 966fbd4a6

[PATCH 4/6] hw/arm/allwinner-a10: Simplify by passing IRQs with qdev_pass_gpios()

By calling qdev_pass_gpios() we don't need to hold a copy of the IRQs from the INTC into the SoC state. Instead of filling an array of qemu_irq and passing it around, we can now directly call qdev_get_gpio_in() on the SoC. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/allwinner-a10.h

[RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob

We do not model the Sunxi Multipoint USB. The Linux kernel OOPS when booting: [ cut here ] WARNING: CPU: 0 PID: 144 at drivers/usb/musb/sunxi.c:400 sunxi_musb_ep_offset+0x39/0x3c sunxi_musb_ep_offset called with non 0 offset Modules linked in: CPU: 0 PID: 144 Com

[PATCH] MAINTAINERS: Remove Claudio Fontana bouncing email

Claudio Fontana Huawei email is bouncing, remove it. The message you sent to claudio.font...@huawei.com couldn't be delivered due to: Recipient email address is possibly incorrect. Further information: 5.1.1 Error: invalid recipients Signed-off-by: Philippe Mathieu-Daudé --- MAINTAIN

Re: [PATCH v2 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

Hi, Here a short status report of this patch series. For V3 update I already prepared the following: - reworked all review comments from Philippe, except: - patch#8: question for the SID, whether command-line override is required (and how is the best way for machine-specific cli arg?) [1] - a

Re: [PATCH] 9p: local: fix memory leak

On Montag, 30. Dezember 2019 03:23:47 CET Yan Wang wrote: > Signed-off-by: Yan Wang > --- > hw/9pfs/9p-local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index ca641390fb..d0592c3b45 100644 > --- a/hw/9pfs/9p-local.c > +++ b

Re: [RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob

Hello Philippe, I have a suggestion: probably you can apply (almost) the same patch to get USB working for A10 as I did in the Allwinner H3, in patch #4 "add USB host controller" [1] That way you can avoid the DTB modifications and with low effort get USB working as well for this board. As far as

Re: [PATCH v2] accel/kvm: Make "kernel_irqchip" default on

On 12/28/19 11:43 AM, Xiaoyao Li wrote: > Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an > accelerator property") moves kernel_irqchip property from "-machine" to > "-accel kvm", but it forgets to set the default value of > kernel_irqchip_allowed and kernel_irqchip_split. > > A

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 10:35 AM, Michal Prívozník wrote: >> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: >>> On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved from PC >>> >>> Typo v4.2.0-246-ged9e9

Re: [PULL 4/8] vfio/pci: Respond to KVM irqchip change notifier

On Tue, Nov 26, 2019 at 05:01:47PM +1100, David Gibson wrote: > VFIO PCI devices already respond to the pci intx routing notifier, in order > to update kernel irqchip mappings when routing is updated. However this > won't handle the case where the irqchip itself is replaced by a different > model

Re: [PATCH] x86: Check for machine state object class before typecasting it

On 12/30/19 2:17 PM, Michal Prívozník wrote: On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 10:35 AM, Michal Prívozník wrote: On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: In v4.2.0-246-ged9e923c3c the SMM property was moved f

Re: [RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob

On 12/30/19 12:33 PM, Niek Linnenbank wrote: Hello Philippe, I have a suggestion: probably you can apply (almost) the same patch to get USB working for A10 as I did in the Allwinner H3, in patch #4 "add USB host controller" [1] That way you can avoid the DTB modifications and with low effort g

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

On 12/30/19 11:33 AM, Paolo Bonzini wrote: Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé > ha scritto: > I'd prefer not changing those files. OK, I'll wait to see what Richard/Markus prefer. I think it's best if you keep the include directives as-is fo

Re: [PATCH v3 6/8] tests/acceptance: Do not set the machine type manually

On 12/29/19 8:45 PM, Philippe Mathieu-Daudé wrote: Since commit ba21bde93 we don't need to set the machine type manually, the one set by the ":avocado: tags=machine" will be used. Correct. Suggested-by: Cleber Rosa Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/machine_avr6

Re: [PATCH v2 08/10] arm: allwinner-h3: add Security Identifier device

On 12/18/19 9:49 PM, Niek Linnenbank wrote: Hi Philippe, On Tue, Dec 17, 2019 at 8:45 AM Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: Hi Niek, On 12/17/19 12:35 AM, Niek Linnenbank wrote: > The Security Identifier device in Allwinner H3 System on Chip > gives ap

Re: [PATCH v2 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

On 12/30/19 12:28 PM, Niek Linnenbank wrote: Hi, Here a short status report of this patch series. Good idea! For V3 update I already prepared the following:  - reworked all review comments from Philippe, except:    - patch#8: question for the SID, whether command-line override is require

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

On Mon, Dec 30, 2019 at 3:02 PM Philippe Mathieu-Daudé wrote: > On 12/30/19 11:33 AM, Paolo Bonzini wrote: > > Il lun 30 dic 2019, 09:59 Philippe Mathieu-Daudé > > ha scritto: > > > > > I'd prefer not changing those files. > > > > OK, I'll wait to see what Richa

Re: [PATCH] MAINTAINERS: Remove Claudio Fontana bouncing email

Reviewed-by: Alex Bennée On Mon, 30 Dec 2019, 11:19 Philippe Mathieu-Daudé, wrote: > Claudio Fontana Huawei email is bouncing, remove it. > > The message you sent to claudio.font...@huawei.com couldn't be > delivered due to: Recipient email address is possibly incorrect. > > Further infor

Re: [PATCH] MAINTAINERS: Remove Claudio Fontana bouncing email

On 12/30/19 12:18 PM, Philippe Mathieu-Daudé wrote: Claudio Fontana Huawei email is bouncing, remove it. The message you sent to claudio.font...@huawei.com couldn't be delivered due to: Recipient email address is possibly incorrect. Further information: 5.1.1 Error: invalid recipi

Re: [PATCH v40 20/21] target/avr: Add Avocado test

Hi Michael, On 12/29/19 7:51 PM, Michael Rolnik wrote: The test is based on https://github.com/seharris/qemu-avr-tests/tree/master/free-rtos/Demo demo which. If working correctly, prints 'ABCDEFGHIJKLMNOPQRSTUVWX' out. it also demostrates that timer and IRQ are working Signed-off-by: Michael Ro

Re: [PATCH 1/2] tcg: Search includes from the project root source directory

Yes, of course (I thought it would be clear from the message, but perhaps it was a bit implicit). Paolo Il lun 30 dic 2019, 16:48 Philippe Mathieu-Daudé ha scritto: > On Mon, Dec 30, 2019 at 3:02 PM Philippe Mathieu-Daudé > wrote: > > On 12/30/19 11:33 AM, Paolo Bonzini wrote: > > > Il lun 30

Re: [PATCH v40 20/21] target/avr: Add Avocado test

Hi Wainer. thanks for reviewing. 1. when `self.vm.shutdown()` is not called `self.vm.get_log()` returns `ERROR: argument of type 'NoneType' is not iterable` 2. I will remove the unnecessary imports Thanks, Michael Rolnik On Mon, Dec 30, 2019 at 7:37 PM Wainer dos Santos Moschetta < waine...@re

Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards

Hi Philippe. Thank you for joining the effort. Regards, Michael Rolnik On Mon, Dec 30, 2019 at 12:45 AM Philippe Mathieu-Daudé wrote: > Hi, > > This series add the arduino boards, aiming at removing the > 'sample' board that doesn't follow any specification. > > Since v2: > - rebased on Micha

[PATCH 1/2] travis.yml: avocado: Print logs of non-pass tests only

The acceptance tests build on Travis is configured to print the entire Avocado's job log in case any test fail. Usually one is interested on failed tests only though. So this change the Travis configuration in order to show the log of tests which status is different from 'PASS' and 'SKIP' only. Not

[PATCH 0/2] travis: Improve log browseability

While I was working on [1] I needed to check what dependencies were missing on Travis environment to build a kernel. The test was coded so that a build failure would cancel the test. As a result, and because all tests pass'ed (or cancel'ed) I could not see the Avocado logs (consequentely not able t

[PATCH 2/2] travis.yml: Detach build and test steps

Currently build and test commands are a single step in a Travis's `script` block. In order to see the output of the tests one needs to scroll down the log to find where the build messages ended and the limit is not clear. If they were in different steps then Travis would print the result build comm

Re: [RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob

Hey Philippe, I took a second look at this and, it seems my previous suggestion was only partly valid. The kernel error you reported came from the driver in drivers/usb/musb/sunxi.c. Apparently, this is an Allwinner specific driver for M-USB. And I don't see it documented in the A10 user manual.

Re: [PATCH v2 00/10] Add Allwinner H3 SoC and Orange Pi PC Machine

On Mon, Dec 30, 2019 at 3:56 PM Philippe Mathieu-Daudé wrote: > On 12/30/19 12:28 PM, Niek Linnenbank wrote: > > Hi, > > > > Here a short status report of this patch series. > > Good idea! > > > > > For V3 update I already prepared the following: > > - reworked all review comments from Philippe

Re: [PATCH 1/6] tests/boot_linux_console: Add initrd test for the CubieBoard

On 12/30/19 9:09 AM, Philippe Mathieu-Daudé wrote: This test boots a Linux kernel on a CubieBoard and verify the serial output is working. The kernel image and DeviceTree blob are built by the Armbian project (based on Debian): https://docs.armbian.com/Developer-Guide_Build-Preparation/ The c

[PATCH] display/gtk: get proper refreshrate

>From 70c95b18fa056b2dd0ecc202ab517bc775b986da Mon Sep 17 00:00:00 2001 From: Nikola Pavlica Date: Mon, 30 Dec 2019 18:17:35 +0100 Subject: [PATCH] display/gtk: get proper refreshrate Signed-off-by: Nikola Pavlica --- ui/gtk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/ui/gtk.c b/

[Bug 1818937] Re: Crash with HV_ERROR on macOS host

Are there any updates? Trying to run the IE11 image from Microsoft (based on Windows 8.1) and it is crashing with this error sporadically :-\ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1818937 Tit

qemu_set_fd_handler callback is delayed

Hi, I am new to QEMU and I am using qemu-3.0.1, I noticed a strange behavior for qemu_set_fd_handler that the callback for reading from a file descriptor is delayed then expected while the file descriptor(socket) has a data to read. I register a callback for reading from a socket using qemu_set

Re: [PATCH] display/gtk: get proper refreshrate

Hi Nikola, Thanks for your patch! On 12/30/19 6:28 PM, Nikola Pavlica wrote: From 70c95b18fa056b2dd0ecc202ab517bc775b986da Mon Sep 17 00:00:00 2001 From: Nikola Pavlica Date: Mon, 30 Dec 2019 18:17:35 +0100 Subject: [PATCH] display/gtk: get proper refreshrate Can you describe here the probl

Re: [Bug 1818937] Crash with HV_ERROR on macOS host

Try against 4.2. Cameron Esfahani di...@apple.com "In the elder days of Art, Builders wrought with greatest care each minute and unseen part; For the gods see everywhere." "The Builders", H. W. Longfellow > On Dec 30, 2019, at 8:41 AM, Alex Fliker > wrote: > > Are there any updates? Tryin