Re: [PATCH v5 4/7] dwc-hsotg (dwc2) USB host controller emulation

On 5/20/20 11:24 PM, Paul Zimmerman wrote: > On Wed, May 20, 2020 at 6:18 AM Peter Maydell > wrote: > > On Wed, 20 May 2020 at 06:49, Paul Zimmerman > wrote: > > Is there a tree somewhere that has a working example of a >

[PATCH v2] arm/aspeed: Rework NIC attachment

The number of MACs supported by an Aspeed SoC is defined by "macs_num" under the SoC model, that is two for the AST2400 and AST2500 and four the AST2600. The model initializes the maximum number of supported MACs but the number of realized devices is caped by the number of network device back-ends

Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference

Hello, +-- On Thu, 21 May 2020, Paolo Bonzini wrote --+ | I think the code here was expecting frame_size_p to be 0 if cmd->frame is | NULL. Can you check why this is not the case, or whether it ever was the | case? static MegasasCmd *megasas_enqueue_frame(MegasasState *s, hwaddr frame, .

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

On 24/05/2020 14.09, David CARLIER wrote: > Hi here porting qemu_getauxval to FreeBSD. Thanks. Regards. > > From 5be5e56a59631b28ed7b738d251dda252ba9b03e Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Sun, 24 May 2020 13:03:32 +0100 > Subject: [PATCH] util/getauxval: FreeBSD has a similar

Re: [PATCH] hw/display/omap_dss: Replace fprintf() call by qemu_log_mask(LOG_UNIMP)

On 24/05/2020 12.38, Philippe Mathieu-Daudé wrote: > Replace fprintf() call by qemu_log_mask(LOG_UNIMP), which is > disabled by default. This avoid flooding the terminal when > fuzzing the device. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/display/omap_dss.c | 2 +- > 1 file changed, 1

Re: [PATCH v3 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

On 5/26/20 8:45 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Move out x86-specific structures from generic machine code. >> >> Acked-by: Richard Henderson >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> qapi/machine-target.json | 45 ++

About the PVH in Seabios

Hello all, The current PVH has been implemented in Qemu and Qboot/uefi, i am not familiar with the PVH implementation history, and found there is no PVH support in Seabios, my question is do we have plan to support PVH in Seabios? thanks. Regards, Yang

Re: [PATCH 1/1] util/oslib: Returns real thread identifier on FreeBSD and NetBSD

>From 792fbcd9114f43bd80fd1ef5b25cd9935a536f9f Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 26 May 2020 08:25:26 +0100 Subject: [PATCH] util/oslib: Returns the real thread identifier on FreeBSD and NetBSD getpid is good enough in a mono thread context, however thr_self/_lwp_self refl

Re: [PATCH v3 2/9] qapi/misc: Restrict LostTickPolicy enum to machine code

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

On 25.05.20 17:06, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/machine.json | 90 ++ > qapi/misc.json | 90 -- > include/sysemu/balloon.h | 2 +- > balloon.c

Re: [PATCH v3 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

On 5/26/20 9:23 AM, Philippe Mathieu-Daudé wrote: > On 5/26/20 8:45 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Move out x86-specific structures from generic machine code. >>> >>> Acked-by: Richard Henderson >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> qapi/ma

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

On 26.05.20 09:35, David Hildenbrand wrote: > On 25.05.20 17:06, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> qapi/machine.json | 90 ++ >> qapi/misc.json | 90 -- >> i

Re: [PATCH 1/1] util/getauxval: Porting to FreeBSD getauxval feature

>From 316cbdea0434a523c78d3f18fe7e6697577e4aae Mon Sep 17 00:00:00 2001 From: David Carlier Date: Tue, 26 May 2020 08:33:12 +0100 Subject: [PATCH] util/getauxval: Porting to FreeBSD the getauxval feature FreeBSD has a similar API for auxiliary vector. Signed-off-by: David Carlier --- configure

Re: About the PVH in Seabios

Hi Yang, On Tue, May 26, 2020 at 03:18:26PM +0800, Yang Zhong wrote: > Hello all, > > The current PVH has been implemented in Qemu and Qboot/uefi, i am not > familiar with the PVH implementation history, and found there is no > PVH support in Seabios, my question is do we have plan to support > P

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé A brief note on why restricting "to machine code" is useful would be nice. Same for the other patches. Acked-by: Markus Armbruster

Re: [PATCH v3 5/9] qapi/misc: Restrict query-vm-generation-id command to machine code

Philippe Mathieu-Daudé writes: > Acked-by: Igor Mammedov > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster

Re: [PATCH v6 20/21] hw/mips: Add some logging for bad register offset cases

On 5/18/20 10:09 PM, Aleksandar Markovic wrote: > Log the cases where a guest attempts read or write using bad > register offset. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé Not well tested apparently, because it doesn't build with GCC 5.4.0 (Ubuntu): hw/mips/ma

Re: [PATCH v3 6/9] qapi/misc: Move query-uuid command to machine code

Why is this patch titled "Move FOO command to machine code", while other patches are titled "Restrict FOO command to machine code"? Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster

Re: [PATCH v3 3/9] qapi/misc.json: Correct balloon documentation

On 25.05.20 17:06, Philippe Mathieu-Daudé wrote: > The documentation incorrectly uses the "size of the balloon" > description when it should be "logical size of the VM". Fix it. > > The relation between both values is: > > logical_vm_size = vm_ram_size - balloon_size > > Reported-by: David Hil

Re: [PATCH v3 7/9] qapi/misc: Restrict ACPI commands to machine code

Philippe Mathieu-Daudé writes: > Acked-by: Igor Mammedov > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster

Re: [PATCH v6 21/21] hw/mips: Rename malta/mipssim/r4k/jazz files in hw/mips

On 5/18/20 10:09 PM, Aleksandar Markovic wrote: > Machine file names should not have prefix "mips_". > > Fuloong2e machine source file will be handled in a separate patch, > to avoid conflicts. That patch is pending integration into the > main tree. > > Reviewed-by: Philippe Mathieu-Daudé > Sign

Re: [PATCH v3 8/9] qapi/misc: Restrict PCI commands to machine code

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster

Re: [PATCH] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

On 5/15/20 10:42 AM, Philippe Mathieu-Daudé wrote: > The Fuloong machine never had to use "audio/audio.h", remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/mips/mips_fulong2e.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e

Re: [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot

On 5/10/20 11:01 PM, Philippe Mathieu-Daudé wrote: > The PMON firmware behave differently regarding it is run > after a cold/warm reset. A simple bit flip fix the issue, > however we need to know the type of reset to set it. > Currently QEMU only supports COLD reset. > > This series contains vario

Re: [PATCH v6 17/21] MAINTAINERS: Change Aleksandar Rikalo's email address

On 5/18/20 10:09 PM, Aleksandar Markovic wrote: > Aleksandar Rikalo wants to use a different email address from > now on. > > Reviewed-by: Aleksandar Rikalo > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Signed-off-by: Aleksandar Markovic > --- > .mailmap| 3

Re: [PATCH v2 2/3] megasas: avoid NULL pointer dereference

On 26/05/20 09:18, P J P wrote: > Later when address_space_map() returns 'NULL' above, '*plen' is not set to > zero. > > diff --git a/exec.c b/exec.c > index 5162f0d12f..4eea84bf66 100644 > --- a/exec.c > +++ b/exec.c > @@ -3538,6 +3538,7 @@ void *address_space_map(AddressSpace *as, > > if

[Bug 1880518] Re: issue while installing docker inside s390x container

The error message that I posted above is all that I see when I go to pull and image. Following is the log from docker daemon time="2020-05-26T07:34:31.385796553Z" level=info msg="API listen on /var/run/docker.sock" time="2020-05-26T07:34:34.607431981Z" level=debug msg="Calling GET /_ping" time="

Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices

On 26/05/20 08:27, Markus Armbruster wrote: >> It cannot happen, because a device must be unparented before it's >> destroyed and unparenting takes care of unrealizing the device. > > I can't see where unparenting takes care of unrealizing. Can you help > me? Hidden in plain sight: static void

Re: [PATCH 0/2] mips: Minor simplifications for KVM use

ping... On 4/29/20 10:29 AM, Philippe Mathieu-Daudé wrote: > A pair of trivial patches while reviewing Huacai's > "KVM target support for MIPS64" series. > > Philippe Mathieu-Daudé (2): > hw/mips/mips_int: De-duplicate KVM interrupt delivery > target/mips/kvm: Assert unreachable code is not u

[PATCH v3] exec: set map length to zero when returning NULL

From: Prasad J Pandit When mapping physical memory into host's virtual address space, 'address_space_map' may return NULL if BounceBuffer is in_use. Set and return '*plen = 0' to avoid later NULL pointer dereference. Reported-by: Alexander Bulekov Fixes: https://bugs.launchpad.net/qemu/+bug/187

Re: [PATCH 51/55] qdev: Make qdev_realize() support bus-less devices

On 26/05/20 07:14, Markus Armbruster wrote: >>> The contract must specify exactly what happens to the reference count, >>> case by case. >> >> For both qdev_realize and qdev_realize_and_unref, on return the caller >> need not care about keeping alive the device in the long-term. >> >> For qdev_real

[PULL 1/8] es1370: check total frame count against current frame

From: Prasad J Pandit A guest user may set channel frame count via es1370_write() such that, in es1370_transfer_audio(), total frame count 'size' is lesser than the number of frames that are processed 'cnt'. int cnt = d->frame_cnt >> 16; int size = d->frame_cnt & 0x; if (size < cnt)

[PULL 5/8] audio: fix wavcapture segfault

From: Bruce Rogers Commit 571a8c522e caused the HMP wavcapture command to segfault when processing audio data in audio_pcm_sw_write(), where a NULL sw->hw->pcm_ops is dereferenced. This fix checks that the pointer is valid before dereferincing it. A similar fix is also made in the parallel functi

[PULL 8/8] hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

From: Philippe Mathieu-Daudé The Fuloong machine never had to use "audio/audio.h", remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Huacai Chen Message-id: 20200515084209.9419-1-f4...@amsat.org Signed-off-by: Gerd Hoffmann --- hw/mips/mips_fulong2e.c | 1 - 1 file changed, 1 del

[PULL 7/8] audio: Let capture_callback handler use const buffer argument

From: Philippe Mathieu-Daudé The buffer is the captured input to pass to backends. As we should not modify it, mark the argument const. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200505132603.8575-3-f4...@amsat.org> Signed-off-by: Gerd Hoffmann --- audio/audio.h | 2 +- audio/w

[PULL 0/8] Audio 20200526 patches

The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 18:54:47 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-202

[PULL 2/8] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

From: Philippe Mathieu-Daudé Use the generic AUDIO_HOST_ENDIANNESS definition instead of a custom one. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20200505100750.27332-1-f4...@amsat.org Signed-off-by: Gerd Hoffmann --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 delet

[PULL 3/8] audio/jack: add JACK client audiodev

From: Geoffrey McRae This commit adds a new audiodev backend to allow QEMU to use JACK as both an audio sink and source. Signed-off-by: Geoffrey McRae Message-Id: <20200512101603.e3db73a0...@moya.office.hostfission.com> Signed-off-by: Gerd Hoffmann --- configure | 17 ++ audio/a

[PULL 4/8] audio/mixeng: fix clang 10+ warning

From: Volker Rümelin The code in CONV_NATURAL_FLOAT() and CLIP_NATURAL_FLOAT() seems to use the constant 2^31-0.5 to convert float to integer and back. But the float type lacks the required precision and the constant used for the conversion is 2^31. This is equiva- lent to a [-1.f, 1.f] <-> [INT3

[PULL 6/8] audio: Let audio_sample_to_uint64() use const samples argument

From: Philippe Mathieu-Daudé The samples are the input to convert to u64. As we should not modify them, mark the argument const. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200505132603.8575-2-f4...@amsat.org> Signed-off-by: Gerd Hoffmann --- audio/audio.h | 2 +- audio/mixeng.c | 4

Re: [PATCH v3] exec: set map length to zero when returning NULL

On 5/26/20 9:50 AM, P J P wrote: > From: Prasad J Pandit > > When mapping physical memory into host's virtual address space, > 'address_space_map' may return NULL if BounceBuffer is in_use. > Set and return '*plen = 0' to avoid later NULL pointer dereference. > > Reported-by: Alexander Bulekov

Re: [PATCH 1/2] hw/mips/mips_int: De-duplicate KVM interrupt delivery

On 12/05/2020 09.08, Philippe Mathieu-Daudé wrote: > On 4/29/20 10:48 AM, chen huacai wrote: >> Hi, Philippe, >> >> On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé >> wrote: >>> >>> Refactor duplicated code in a single place. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>>   hw/m

Re: [PATCH 00/14] hw/display: Omnibus cleanups

On Tue, May 26, 2020 at 08:22:38AM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, for your convenience I joined all the hw/display/ > patches I sent recently altogether in a series. Nice service. I was about to collect them from my inbox after sending out the audio pull req ... thanks, Gerd

Re: [PATCH 11/14] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion

On Tue, May 26, 2020 at 08:22:49AM +0200, Philippe Mathieu-Daudé wrote: > To avoid the orphan I/O memory region being added in the /unattached > QOM container, register the PCI device as its owner. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC: This might break migration --verbose plea

Re: [PATCH v7 00/32] Add subcluster allocation to qcow2

Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH 2/2] qmp: Expose MachineClass::default_ram_id

On 5/25/20 8:06 PM, Eduardo Habkost wrote: On Mon, May 25, 2020 at 07:03:28PM +0200, Michal Privoznik wrote: If a management application (like Libvirt) want's to preserve migration ability and switch to '-machine memory-backend' it needs to set exactly the same RAM id as QEMU would. Since the id

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

On 5/26/20 9:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Signed-off-by: Philippe Mathieu-Daudé > > A brief note on why restricting "to machine code" is useful would be > nice. Same for the other patches. > > Acked-by: Markus Armbruster > What about this? "QEMU ca

Re: About the PVH in Seabios

On Tue, May 26, 2020 at 09:36:51AM +0200, Stefano Garzarella wrote: > Hi Yang, > > On Tue, May 26, 2020 at 03:18:26PM +0800, Yang Zhong wrote: > > Hello all, > > > > The current PVH has been implemented in Qemu and Qboot/uefi, i am not > > familiar with the PVH implementation history, and found t

Re: [PATCH 11/14] hw/display/vmware_vga: Let the PCI device own its I/O MemoryRegion

On 5/26/20 10:01 AM, Gerd Hoffmann wrote: > On Tue, May 26, 2020 at 08:22:49AM +0200, Philippe Mathieu-Daudé wrote: >> To avoid the orphan I/O memory region being added in the /unattached >> QOM container, register the PCI device as its owner. >> >> Signed-off-by: Philippe Mathieu-DaudÃÂ

Re: [PATCH 1/2] hw/mips/mips_int: De-duplicate KVM interrupt delivery

On 5/26/20 9:57 AM, Thomas Huth wrote: > On 12/05/2020 09.08, Philippe Mathieu-Daudé wrote: >> On 4/29/20 10:48 AM, chen huacai wrote: >>> Hi, Philippe, >>> >>> On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé >>> wrote: Refactor duplicated code in a single place. Signed-

[PATCH v5 0/5] block: widen and check consistency of size-related BlockConf properties

BlockConf includes several properties counted in bytes. Enhance their handling in a some aspects, specifically - accept common size suffixes (k, m) - perform consistency checks on the values, to prevent their silent truncation and rounding - lift the upper limit on physical_block_size and logic

[PATCH v5 1/5] virtio-blk: store opt_io_size with correct size

The width of opt_io_size in virtio_blk_config is 32bit. However, it's written with virtio_stw_p; this may result in value truncation, and on big-endian systems with legacy virtio in completely bogus readings in the guest. Use the appropriate accessor to store it. Signed-off-by: Roman Kagan Revi

[PATCH v5 2/5] block: consolidate blocksize properties consistency checks

Several block device properties related to blocksize configuration must be in certain relationship WRT each other: physical block must be no smaller than logical block; min_io_size, opt_io_size, and discard_granularity must be a multiple of a logical block. To ensure these requirements are met, ad

[PATCH v5 5/5] block: lift blocksize property limit to 2 MiB

Logical and physical block sizes in QEMU are limited to 32 KiB. This appears unnecessary tight, and we've seen bigger block sizes handy at times. Lift the limitation up to 2 MiB which appears to be good enough for everybody, and matches the qcow2 cluster size limit. Signed-off-by: Roman Kagan -

[PATCH v5 3/5] qdev-properties: blocksize: use same limits in code and description

Make it easier (more visible) to maintain the limits on the blocksize properties in sync with the respective description, by using macros both in the code and in the description. Signed-off-by: Roman Kagan --- v4 -> v5: - split out into separate patch [Philippe] hw/core/qdev-properties.c | 21 +

Re: [PATCH v3 9/9] qapi/misc: Restrict device memory commands to machine code

Philippe Mathieu-Daudé writes: > Acked-by: Igor Mammedov > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Markus Armbruster All patches: drop the /misc from qapi/misc: in the title, if you don't mind. Observation: before series after machine-target

[PATCH v5 4/5] block: make size-related BlockConf properties accept size suffixes

Several BlockConf properties represent respective sizes in bytes so it makes sense to accept size suffixes for them. Turn them into uint64_t and use size-suffix-capable setters/getters on them. Also, as some of them are exposed to the guest by scsi and virtio-blk devices as an integer of a specif

[PATCH v2 1/2] qapi: Fix comment format for @CpuInstanceProperties

In 176d2cda0de, the @die-id attribute was introduced to CpuInstanceProperties type. However, it mangled the comment. Signed-off-by: Michal Privoznik --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/machine.json b/qapi/machine.json index ff7b5032e3.

[PATCH v2 0/2] qmp: Expose MachineClass::default_ram_id

v2 of: https://lists.nongnu.org/archive/html/qemu-devel/2020-05/msg07103.html diff to v1: - in 2/2 I made the default-ram-id optional, because as it turns out, not every machine type has it set. Michal Privoznik (2): qapi: Fix comment format for @CpuInstanceProperties qmp: Expose Machine

[PATCH v2 2/2] qmp: Expose MachineClass::default_ram_id

If a management application (like Libvirt) want's to preserve migration ability and switch to '-machine memory-backend' it needs to set exactly the same RAM id as QEMU would. Since the id is machine type dependant, expose it under 'query-machines' result. Some machine types don't have the attribute

Re: [PATCH] pci: Display PCI IRQ pin in "info pci"

Peter Xu writes: > Hi, Markus, > > Thanks for commenting. Please see below. > > On Mon, May 25, 2020 at 10:19:09AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Sometimes it would be good to be able to read the pin number along >> > with the IRQ number allocated. Since we'll dum

Re: [PATCH 0/2] tests/qtest/fuzz: Avoid QTest serialization

On Tue, May 26, 2020 at 07:58:18AM +0200, Philippe Mathieu-Daudé wrote: > Hi Alexander, > > I forgot to share these 2 patches wrote before > the direct MemoryRegion fuzzer sent yesterday. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (2): > tests/qtest/fuzz: Avoid QTest ioport serializati

Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices

Paolo Bonzini writes: > On 26/05/20 08:27, Markus Armbruster wrote: >>> It cannot happen, because a device must be unparented before it's >>> destroyed and unparenting takes care of unrealizing the device. >> >> I can't see where unparenting takes care of unrealizing. Can you help >> me? > > Hi

Re: [PATCH v3 1/9] target/i386: Restrict X86CPUFeatureWord to X86 targets

Philippe Mathieu-Daudé writes: > On 5/26/20 9:23 AM, Philippe Mathieu-Daudé wrote: >> On 5/26/20 8:45 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> Move out x86-specific structures from generic machine code. Acked-by: Richard Henderson Signed-off-by: Ph

Re: [PATCH 00/14] hw/display: Omnibus cleanups

Patchew URL: https://patchew.org/QEMU/20200526062252.19852-1-f4...@amsat.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200526062252.19852-1-f4...@amsat.org Subject: [PATCH 00/14] hw/display: Omnibus cleanups Type: series ==

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

Philippe Mathieu-Daudé writes: > On 5/26/20 9:38 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Signed-off-by: Philippe Mathieu-Daudé >> >> A brief note on why restricting "to machine code" is useful would be >> nice. Same for the other patches. >> >> Acked-by: Markus

Re: [PATCH 0/2] tests/qtest/fuzz: Avoid QTest serialization

On 5/26/20 10:56 AM, Stefan Hajnoczi wrote: > On Tue, May 26, 2020 at 07:58:18AM +0200, Philippe Mathieu-Daudé wrote: >> Hi Alexander, >> >> I forgot to share these 2 patches wrote before >> the direct MemoryRegion fuzzer sent yesterday. >> >> Regards, >> >> Phil. >> >> Philippe Mathieu-Daudé (2):

Re: [PATCH v2] hw/display/cg3: Convert debug printf()s to trace events

On 25/05/2020 12:28, Philippe Mathieu-Daudé wrote: > Convert DPRINTF() to trace events and remove ifdef'ry. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Order addr/val/size (Mark review) > --- > hw/display/cg3.c| 14 -- > hw/display/trace-events | 4 > 2 files

Re: [PATCH] tests/acceptance/boot_linux: Skip slow Aarch64 'virt' machine TCG test

+Cleber On 5/11/20 6:51 PM, Lukas Straub wrote: > On Mon, 11 May 2020 10:11:20 +0100 > Peter Maydell wrote: > >> On Sat, 9 May 2020 at 14:18, Lukas Straub wrote: >>> Hi, >>> Why not simply add slow tag to the test. Like: >>> :avocado: tags=slow >>> >>> The slow tests can then be skipped with >>

Re: [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions

On Tue, 26 May 2020 at 03:21, Yan Zhao wrote: > so which regions should keep ops->write and which regions should not? Devices which never need to return a transaction failure and which never care about transaction attributes can continue to use ops->write (this is most devices). It's only if you

Re: [PATCH] MAINTAINERS: add Thomas as additional s390x maintainer

On Mon, 25 May 2020 20:15:50 +0200 Thomas Huth wrote: > On 25/05/2020 17.58, Cornelia Huck wrote: > > ...because two people are better than one. > > > > Cc: Thomas Huth > > Signed-off-by: Cornelia Huck > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/MAI

Re: [PATCH v6 1/3] memory: drop guest writes to read-only ram device regions

On Mon, 25 May 2020 at 11:20, Paolo Bonzini wrote: > Not all of them, only those that need to return MEMTX_ERROR. I would > like some guidance from Peter as to whether (or when) reads from ROMs > should return MEMTX_ERROR. This way, we can use that information to > device what the read-only ram

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

+Laurent On 5/26/20 11:04 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/26/20 9:38 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> Signed-off-by: Philippe Mathieu-Daudé >>> >>> A brief note on why restricting "to machine code" is useful would

[PATCH v3 0/2] hw/m68k/mcf52xx: Replace hw_error() by qemu_log_mask()

Since v2: Addressed Thomas review comments: - use PRIx16 format for 16-bit values Since v1: Addressed Thomas review comments: - return instead of break + call update() - fixed format strings - add more LOG_UNIMP Supersedes: <20200518094904.24226-1-f4...@amsat.org> Philippe Mathieu-Daudé (2): h

[PATCH v3 1/2] hw/m68k/mcf5206: Reduce m5206_mbar_read/write() offset arg to 16-bit

All calls to m5206_mbar_read/m5206_mbar_write are used with 'offset = hwaddr & 0x3ff', so we are sure the offset fits in 16-bit. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- v3: Use PRIx16 --- hw/m68k/mcf5206.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v3 2/2] hw/m68k/mcf52xx: Replace hw_error() by qemu_log_mask()

hw_error() calls exit(). This a bit overkill when we can log the accesses as unimplemented or guest error. When fuzzing the devices, we don't want the whole process to exit. Replace some hw_error() calls by qemu_log_mask(). Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/mcf5206.c | 10 +

Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices

On Tue, 19 May 2020 16:55:46 +0200 Markus Armbruster wrote: > init_event_facility() creates the SCLP events bus with two SCLP event > devices (sclpquiesce and sclp-cpu-hotplug). It leaves the devices > unrealized. A comment explains they will be realized "via the bus". > > The bus's realize me

Re: [PATCH 09/14] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report()

On Tue, May 26, 2020 at 08:22:47AM +0200, Philippe Mathieu-Daudé wrote: > DPRINTF() calls are disabled by default, so when unexpected > data is used, the whole process abort without information. > > Display a bit of information with error_report() before crashing. Reviewed-by: Edgar E. Iglesias

Re: [PATCH 0/7] hw/sparc/leon3: Few fixes and disable HelenOS test

On 5/25/20 1:02 PM, Fred Konrad wrote: > Sorry Philippe I missed that. > > Would be happy to do a PR if needed but: >   * I never did that. >   * Looking at https://wiki.qemu.org/Contribute/SubmitAPullRequest, I > don't have >     the signed GPG key either. Thanks Fred for following this series.

Re: [PATCH 50/55] s390x/event-facility: Simplify creation of SCLP event devices

On 19.05.20 16:55, Markus Armbruster wrote: > init_event_facility() creates the SCLP events bus with two SCLP event > devices (sclpquiesce and sclp-cpu-hotplug). It leaves the devices > unrealized. A comment explains they will be realized "via the bus". > > The bus's realize method sclp_events_b

Re: [PATCH v3] exec: set map length to zero when returning NULL

On Tue, May 26, 2020 at 9:53 AM P J P wrote: > > From: Prasad J Pandit > > When mapping physical memory into host's virtual address space, > 'address_space_map' may return NULL if BounceBuffer is in_use. > Set and return '*plen = 0' to avoid later NULL pointer dereference. > > Reported-by: Alexan

Re: [PATCH v6 20/21] hw/mips: Add some logging for bad register offset cases

уто, 26. мај 2020. у 09:42 Philippe Mathieu-Daudé је написао/ла: > > On 5/18/20 10:09 PM, Aleksandar Markovic wrote: > > Log the cases where a guest attempts read or write using bad > > register offset. > > > > Reviewed-by: Philippe Mathieu-Daudé > > Tested-by: Philippe Mathieu-Daudé > > Not wel

5.1 proposed schedule

Here's a draft schedule for 5.1: 2019-07-06: softfreeze 2019-07-14: hardfreeze, rc0 2019-07-21: rc1 2019-07-28: rc2 2019-08-04: rc3 2019-08-11: release, or rc4 if we need it 2019-08-18: release if we needed an rc4 Does that work for people? I don't think there's anything we particularly need to t

Re: [PATCH v7 00/32] Add subcluster allocation to qcow2

Patchew URL: https://patchew.org/QEMU/cover.1590429901.git.be...@igalia.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/b

Re: [PATCH v3] exec: set map length to zero when returning NULL

On Tue, 26 May 2020 at 08:53, P J P wrote: > > From: Prasad J Pandit > > When mapping physical memory into host's virtual address space, > 'address_space_map' may return NULL if BounceBuffer is in_use. > Set and return '*plen = 0' to avoid later NULL pointer dereference. > > Reported-by: Alexande

Re: [PATCH 14/19] util/async: Fixed tsan warnings

On Fri, May 22, 2020 at 12:07:50PM -0400, Robert Foley wrote: > For example: > Atomic write of size 8 at 0x7b4800113c28 by main thread (mutexes: write > M30): > #0 __tsan_atomic64_exchange (qemu-system-aarch64+0x386f85) > #1 aio_bh_poll util/async.c:146:5 (qemu-system-aarch64+0xcd1f61)

Re: [PATCH v6 20/21] hw/mips: Add some logging for bad register offset cases

On 5/26/20 12:05 PM, Aleksandar Markovic wrote: > уто, 26. мај 2020. у 09:42 Philippe Mathieu-Daudé је > написао/ла: >> >> On 5/18/20 10:09 PM, Aleksandar Markovic wrote: >>> Log the cases where a guest attempts read or write using bad >>> register offset. >>> >>> Reviewed-by: Philippe Mathieu-Dau

Re: [PATCH 00/12] hw/mips/fuloong2e: PoC to fix hang after reboot

уто, 26. мај 2020. у 09:47 Philippe Mathieu-Daudé је написао/ла: > > On 5/10/20 11:01 PM, Philippe Mathieu-Daudé wrote: > > The PMON firmware behave differently regarding it is run > > after a cold/warm reset. A simple bit flip fix the issue, > > however we need to know the type of reset to set it

Re: [PATCH v5 0/5] block: widen and check consistency of size-related BlockConf properties

Patchew URL: https://patchew.org/QEMU/20200526081740.256236-1-rvka...@yandex-team.ru/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGI

Re: [PATCH v2 5/7] sm501: Replace hand written implementation with pixman where possible

On Thu, May 21, 2020 at 09:39:44PM +0200, BALATON Zoltan wrote: > Besides being faster this should also prevent malicious guests to > abuse 2D engine to overwrite data or cause a crash. > uint32_t src_base = s->twoD_source_base & 0x03FF; > -uint8_t *src = s->local_mem + src_ba

Re: [PATCH v6 20/21] hw/mips: Add some logging for bad register offset cases

уто, 26. мај 2020. у 12:38 Philippe Mathieu-Daudé је написао/ла: > > On 5/26/20 12:05 PM, Aleksandar Markovic wrote: > > уто, 26. мај 2020. у 09:42 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> On 5/18/20 10:09 PM, Aleksandar Markovic wrote: > >>> Log the cases where a guest attempts read o

[PATCH 01/14] MAINTAINERS: Add Huacai Chen as fuloong2e co-maintainer

From: Huacai Chen I submitted the MIPS/fuloong2e support about ten years ago, and after that I became a MIPS kernel developer. Last year, Philippe Mathieu- Daudé asked me that whether I can be a reviewer of MIPS/fuloong2e, and I promised that I will do some QEMU work in the next year (i.e., 2020

Re: [PATCH v5 0/5] block: widen and check consistency of size-related BlockConf properties

Patchew URL: https://patchew.org/QEMU/20200526081740.256236-1-rvka...@yandex-team.ru/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

[PATCH 02/14] hw/pci-host: Use CONFIG_PCI_BONITO to select the Bonito North Bridge

From: Philippe Mathieu-Daudé Ease the kconfig selection by introducing CONFIG_PCI_BONITO to select the Bonito North Bridge. Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daudé Message-id: <20200510210128.18343-6-f4...@amsat.org> Reviewed-by: Huacai Chen Signed-off-by: Phili

[PATCH 00/14] hw/mips: patch queue for 2020-05-26

Hi, This is the current state of my hw/mips/next tree. - MAINTAINERS updated to welcome Huacai Chen and Jiaxun Yang, and update Aleksandar Rikalo's email address, - Trivial improvements in the Bonito64 North Bridge and the Fuloong 2e machine, - MIPS Machines names unified without 'mips_' pr

[PATCH 05/14] hw/pci-host/bonito: Map all the Bonito64 I/O range

To ease following guest accesses to the Bonito64 chipset, map its I/O range as UnimplementedDevice. We can now see the accesses to unimplemented peripheral using the '-d unimp' command line option. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-9-f4...@amsat.org> Signed-off-by

[PATCH 06/14] hw/pci-host/bonito: Map the different PCI ranges more detailled

Better describe the Bonito64 MEM HI/LO and I/O PCI ranges, add more PCI regions as unimplemented. Message-id: <20200510210128.18343-10-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 32 1 file changed, 28 insertions(+), 4 deleti

Re: [PATCH v5 0/5] block: widen and check consistency of size-related BlockConf properties

Patchew URL: https://patchew.org/QEMU/20200526081740.256236-1-rvka...@yandex-team.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200526081740.256236-1-rvka...@yandex-team.ru Subject: [PATCH v5 0/5] block: widen and check cons

[PATCH 03/14] hw/pci-host/bonito: Fix DPRINTF() format strings

Reviewed-by: Huacai Chen Message-id: <20200510210128.18343-7-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bonito.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index f212796044..b874468ea6 100644 -

[PATCH 08/14] hw/pci-host/bonito: Set the Config register reset value with FIELD_DP32

Describe some bits of the Config registers fields with the registerfields API. Use the FIELD_DP32() macro to set the BONGENCFG register bits at reset. Reviewed-by: Aleksandar Markovic Message-id: <20200510210128.18343-12-f4...@amsat.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/bon

  1   2   3   4   >